[GitHub] [arrow] sagnikc-dremio commented on a change in pull request #7641: ARROW-9328: [C++][Gandiva] Add LTRIM, RTRIM, BTRIM functions for string

sagnikc-dremio commented on a change in pull request #7641: URL: https://github.com/apache/arrow/pull/7641#discussion_r459212543 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -305,21 +342,104 @@ const char* trim_utf8(gdv_int64 context, const char* data, gdv_int

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

jorgecarleitao edited a comment on pull request #7796: URL: https://github.com/apache/arrow/pull/7796#issuecomment-662800174 The test `csv_query_group_by_avg_with_projection` is now failing (after rebase). The query is `SELECT avg(c12), c1 FROM aggregate_test_100 GROUP BY c1` and th

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

jorgecarleitao edited a comment on pull request #7796: URL: https://github.com/apache/arrow/pull/7796#issuecomment-662800174 The test `csv_query_group_by_avg_with_projection` is now failing (after rebase). The query is `SELECT avg(c12), c1 FROM aggregate_test_100 GROUP BY c1` and th

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

jorgecarleitao edited a comment on pull request #7796: URL: https://github.com/apache/arrow/pull/7796#issuecomment-662800174 The test `csv_query_group_by_avg_with_projection` is now failing (after rebase). The query is `SELECT avg(c12), c1 FROM aggregate_test_100 GROUP BY c1` and th

[GitHub] [arrow] jorgecarleitao commented on pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

jorgecarleitao commented on pull request #7796: URL: https://github.com/apache/arrow/pull/7796#issuecomment-662800174 The test `csv_query_group_by_avg_with_projection` is now failing (after rebase). The query is `SELECT avg(c12), c1 FROM aggregate_test_100 GROUP BY c1` and the error

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

jorgecarleitao commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r459189282 ## File path: rust/datafusion/src/execution/context.rs ## @@ -455,12 +495,11 @@ impl ExecutionContext { input_schema: &Schema, ) -> Res

[GitHub] [arrow] offthewall123 commented on a change in pull request #7815: ARROW-9536: [Java] Miss parameters in PlasmaOutOfMemoryException.java

offthewall123 commented on a change in pull request #7815: URL: https://github.com/apache/arrow/pull/7815#discussion_r459188625 ## File path: java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaOutOfMemoryException.java ## @@ -22,11 +22,11 @@ */ public class

[GitHub] [arrow] offthewall123 commented on a change in pull request #7815: ARROW-9536: [Java] Miss parameters in PlasmaOutOfMemoryException.java

offthewall123 commented on a change in pull request #7815: URL: https://github.com/apache/arrow/pull/7815#discussion_r459170893 ## File path: java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaOutOfMemoryException.java ## @@ -22,11 +22,11 @@ */ public class

[GitHub] [arrow] andygrove commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

andygrove commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r45953 ## File path: rust/datafusion/src/execution/context.rs ## @@ -455,12 +495,11 @@ impl ExecutionContext { input_schema: &Schema, ) -> Result>

[GitHub] [arrow] kou commented on a change in pull request #7818: ARROW-9541: [C++] CMakeLists requires UTF8PROC_STATIC when building static library

kou commented on a change in pull request #7818: URL: https://github.com/apache/arrow/pull/7818#discussion_r459082935 ## File path: cpp/src/arrow/CMakeLists.txt ## @@ -488,6 +488,9 @@ add_dependencies(arrow ${ARROW_LIBRARIES}) if(ARROW_BUILD_STATIC AND WIN32) target_compi

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

jorgecarleitao commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r459018140 ## File path: rust/datafusion/src/execution/context.rs ## @@ -455,12 +495,11 @@ impl ExecutionContext { input_schema: &Schema, ) -> Res

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

jorgecarleitao commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r459018140 ## File path: rust/datafusion/src/execution/context.rs ## @@ -455,12 +495,11 @@ impl ExecutionContext { input_schema: &Schema, ) -> Res

[GitHub] [arrow] andygrove commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

andygrove commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r459011360 ## File path: rust/datafusion/src/execution/context.rs ## @@ -455,12 +495,11 @@ impl ExecutionContext { input_schema: &Schema, ) -> Result>

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

jorgecarleitao commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r459008561 ## File path: rust/datafusion/src/execution/context.rs ## @@ -455,12 +495,11 @@ impl ExecutionContext { input_schema: &Schema, ) -> Res

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

jorgecarleitao commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r459008561 ## File path: rust/datafusion/src/execution/context.rs ## @@ -455,12 +495,11 @@ impl ExecutionContext { input_schema: &Schema, ) -> Res

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

jorgecarleitao commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r459007486 ## File path: rust/datafusion/src/execution/context.rs ## @@ -455,12 +495,11 @@ impl ExecutionContext { input_schema: &Schema, ) -> Res

[GitHub] [arrow] andygrove edited a comment on pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

andygrove edited a comment on pull request #7796: URL: https://github.com/apache/arrow/pull/7796#issuecomment-662465471 ~This is looking good overall. I think we need to keep the Alias in the logical plan though.~ This is an

[GitHub] [arrow] andygrove commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

andygrove commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r459007002 ## File path: rust/datafusion/src/execution/context.rs ## @@ -455,12 +495,11 @@ impl ExecutionContext { input_schema: &Schema, ) -> Result>

[GitHub] [arrow] andygrove commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

andygrove commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r459006369 ## File path: rust/datafusion/src/execution/physical_plan/expressions.rs ## @@ -47,81 +47,43 @@ use arrow::compute::kernels::sort::{SortColumn, SortOptio

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

jorgecarleitao commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r459002736 ## File path: rust/datafusion/src/execution/physical_plan/expressions.rs ## @@ -47,81 +47,43 @@ use arrow::compute::kernels::sort::{SortColumn, Sort

[GitHub] [arrow] nealrichardson commented on pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

nealrichardson commented on pull request #7668: URL: https://github.com/apache/arrow/pull/7668#issuecomment-662617524 Merging; will address any followup concerns in ARROW-9187. This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson closed pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

nealrichardson closed pull request #7668: URL: https://github.com/apache/arrow/pull/7668 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] nealrichardson commented on pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

nealrichardson commented on pull request #7668: URL: https://github.com/apache/arrow/pull/7668#issuecomment-662587689 Here's an informal benchmark that shows the benefit of pushing all of this work down into Arrow, reproducing how the "old" way (on current master) calls `as.vector` on all

[GitHub] [arrow] github-actions[bot] commented on pull request #7818: ARROW-9541: [C++] CMakeLists requires UTF8PROC_STATIC when building static library

github-actions[bot] commented on pull request #7818: URL: https://github.com/apache/arrow/pull/7818#issuecomment-662586350 https://issues.apache.org/jira/browse/ARROW-9541 This is an automated message from the Apache Git Serv

[GitHub] [arrow] BryanCutler commented on a change in pull request #7676: ARROW-9371: [Java] Run vector tests for both allocators

BryanCutler commented on a change in pull request #7676: URL: https://github.com/apache/arrow/pull/7676#discussion_r458925035 ## File path: java/vector/pom.xml ## @@ -97,6 +103,58 @@ + +org.apache.maven.plugins +maven-surefire-plugin +

[GitHub] [arrow] github-actions[bot] commented on pull request #7819: ARROW-9405: [R] Switch to cpp11

github-actions[bot] commented on pull request #7819: URL: https://github.com/apache/arrow/pull/7819#issuecomment-662541583 https://issues.apache.org/jira/browse/ARROW-9405 This is an automated message from the Apache Git Serv

[GitHub] [arrow] github-actions[bot] commented on pull request #7816: ARROW-9528: [Python] Honor tzinfo when converting from datetime

github-actions[bot] commented on pull request #7816: URL: https://github.com/apache/arrow/pull/7816#issuecomment-662541582 https://issues.apache.org/jira/browse/ARROW-9528 This is an automated message from the Apache Git Serv

[GitHub] [arrow] emkornfield commented on pull request #7805: ARROW-9528: [Python] Honor tzinfo when converting from datetime

emkornfield commented on pull request #7805: URL: https://github.com/apache/arrow/pull/7805#issuecomment-662527331 yes. This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [arrow] emkornfield closed pull request #7805: ARROW-9528: [Python] Honor tzinfo when converting from datetime

emkornfield closed pull request #7805: URL: https://github.com/apache/arrow/pull/7805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [arrow] kszucs commented on pull request #7805: ARROW-9528: [Python] Honor tzinfo when converting from datetime

kszucs commented on pull request #7805: URL: https://github.com/apache/arrow/pull/7805#issuecomment-662523425 @emkornfield I think we can close this in favor of #7816 This is an automated message from the Apache Git Service.

[GitHub] [arrow] romainfrancois opened a new pull request #7819: [R]: Switch from Rcpp to cpp11

romainfrancois opened a new pull request #7819: URL: https://github.com/apache/arrow/pull/7819 This is very much work in progress. I've started by tackling code generation, as we cannot just use `cpp11::cpp_register()` as is, because e.g. of the `#if defined(ARROW_R_WITH_ARROW)` thing.

[GitHub] [arrow] github-actions[bot] commented on pull request #7818: [ARROW-9541] CMakeLists requires UTF8PROC_STATIC when building static library

github-actions[bot] commented on pull request #7818: URL: https://github.com/apache/arrow/pull/7818#issuecomment-662516297 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] kszucs commented on a change in pull request #7816: [Python] Better timezone support

kszucs commented on a change in pull request #7816: URL: https://github.com/apache/arrow/pull/7816#discussion_r458859987 ## File path: python/pyarrow/tests/test_convert_builtin.py ## @@ -811,6 +875,125 @@ def test_sequence_timestamp():

[GitHub] [arrow] kszucs commented on a change in pull request #7816: [Python] Better timezone support

kszucs commented on a change in pull request #7816: URL: https://github.com/apache/arrow/pull/7816#discussion_r458859987 ## File path: python/pyarrow/tests/test_convert_builtin.py ## @@ -811,6 +875,125 @@ def test_sequence_timestamp():

[GitHub] [arrow] GPSnoopy opened a new pull request #7818: [ARROW-9541] CMakeLists requires UTF8PROC_STATIC when building static library

GPSnoopy opened a new pull request #7818: URL: https://github.com/apache/arrow/pull/7818 Add utf8proc_static as an expected library name. If building Arrow as a static library, define UTF8PROC_STATIC. This is an automated

[GitHub] [arrow] andygrove commented on pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

andygrove commented on pull request #7796: URL: https://github.com/apache/arrow/pull/7796#issuecomment-662465471 This is looking good overall. I think we need to keep the Alias in the logical plan though. This is an automate

[GitHub] [arrow] andygrove commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

andygrove commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r458804968 ## File path: rust/datafusion/src/execution/physical_plan/expressions.rs ## @@ -47,81 +47,43 @@ use arrow::compute::kernels::sort::{SortColumn, SortOptio

[GitHub] [arrow] andygrove commented on a change in pull request #7796: ARROW-9516: [Rust][DataFusion] refactor of column names

andygrove commented on a change in pull request #7796: URL: https://github.com/apache/arrow/pull/7796#discussion_r458803878 ## File path: rust/datafusion/src/execution/context.rs ## @@ -455,12 +495,11 @@ impl ExecutionContext { input_schema: &Schema, ) -> Result>

[GitHub] [arrow] andygrove closed pull request #7811: ARROW-9534: [Rust] [DataFusion] Added support for lit to all supported rust types.

andygrove closed pull request #7811: URL: https://github.com/apache/arrow/pull/7811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] rymurr commented on a change in pull request #7676: ARROW-9371: [Java] Run vector tests for both allocators

rymurr commented on a change in pull request #7676: URL: https://github.com/apache/arrow/pull/7676#discussion_r458770955 ## File path: java/vector/pom.xml ## @@ -97,6 +103,58 @@ + +org.apache.maven.plugins +maven-surefire-plugin + +

[GitHub] [arrow] kszucs commented on pull request #7816: [Python] Better timezone support

kszucs commented on pull request #7816: URL: https://github.com/apache/arrow/pull/7816#issuecomment-662420317 @emkornfield I managed to implement TzinfoToString on the C++ side. Currently adding timezone inference support. T

[GitHub] [arrow] liyafan82 commented on a change in pull request #7676: ARROW-9371: [Java] Run vector tests for both allocators

liyafan82 commented on a change in pull request #7676: URL: https://github.com/apache/arrow/pull/7676#discussion_r458746598 ## File path: java/vector/pom.xml ## @@ -97,6 +103,58 @@ + +org.apache.maven.plugins +maven-surefire-plugin +

[GitHub] [arrow] rymurr commented on a change in pull request #7676: ARROW-9371: [Java] Run vector tests for both allocators

rymurr commented on a change in pull request #7676: URL: https://github.com/apache/arrow/pull/7676#discussion_r458736961 ## File path: java/vector/src/test/java/org/apache/arrow/vector/TestBitVectorHelper.java ## @@ -22,50 +22,50 @@ import static org.junit.jupiter.api.Asserti

[GitHub] [arrow] liyafan82 commented on a change in pull request #7676: ARROW-9371: [Java] Run vector tests for both allocators

liyafan82 commented on a change in pull request #7676: URL: https://github.com/apache/arrow/pull/7676#discussion_r458732733 ## File path: java/vector/src/test/java/org/apache/arrow/vector/TestBitVectorHelper.java ## @@ -22,50 +22,50 @@ import static org.junit.jupiter.api.Asse

[GitHub] [arrow] liyafan82 commented on a change in pull request #7676: ARROW-9371: [Java] Run vector tests for both allocators

liyafan82 commented on a change in pull request #7676: URL: https://github.com/apache/arrow/pull/7676#discussion_r458732479 ## File path: java/vector/src/test/java/org/apache/arrow/vector/TestBitVectorHelper.java ## @@ -22,50 +22,50 @@ import static org.junit.jupiter.api.Asse

[GitHub] [arrow] liyafan82 commented on a change in pull request #7676: ARROW-9371: [Java] Run vector tests for both allocators

liyafan82 commented on a change in pull request #7676: URL: https://github.com/apache/arrow/pull/7676#discussion_r458732034 ## File path: java/vector/pom.xml ## @@ -97,6 +103,58 @@ + +org.apache.maven.plugins +maven-surefire-plugin +

[GitHub] [arrow] rymurr commented on a change in pull request #7815: ARROW-9536: [Java] Miss parameters in PlasmaOutOfMemoryException.java

rymurr commented on a change in pull request #7815: URL: https://github.com/apache/arrow/pull/7815#discussion_r458679661 ## File path: java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaOutOfMemoryException.java ## @@ -22,11 +22,11 @@ */ public class PlasmaO

[GitHub] [arrow] rymurr commented on a change in pull request #7676: ARROW-9371: [Java] Run vector tests for both allocators

rymurr commented on a change in pull request #7676: URL: https://github.com/apache/arrow/pull/7676#discussion_r458672541 ## File path: java/vector/pom.xml ## @@ -97,6 +103,58 @@ + +org.apache.maven.plugins +maven-surefire-plugin + +

[GitHub] [arrow] github-actions[bot] commented on pull request #7817: ARROW-9377: [Java] Support unsigned dictionary indices

github-actions[bot] commented on pull request #7817: URL: https://github.com/apache/arrow/pull/7817#issuecomment-662293548 https://issues.apache.org/jira/browse/ARROW-9377 This is an automated message from the Apache Git Serv

[GitHub] [arrow] liyafan82 commented on a change in pull request #7676: ARROW-9371: [Java] Run vector tests for both allocators

liyafan82 commented on a change in pull request #7676: URL: https://github.com/apache/arrow/pull/7676#discussion_r458591969 ## File path: java/vector/pom.xml ## @@ -97,6 +103,58 @@ + +org.apache.maven.plugins +maven-surefire-plugin +

[GitHub] [arrow] liyafan82 opened a new pull request #7817: ARROW-9377: [Java] Support unsigned dictionary indices

liyafan82 opened a new pull request #7817: URL: https://github.com/apache/arrow/pull/7817 See https://issues.apache.org/jira/browse/ARROW-9377 This is an automated message from the Apache Git Service. To respond to the messag