kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465505197
##
File path: cpp/src/arrow/ipc/reader.cc
##
@@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset(
const flatbuf::RecordBatch* metadata, const std::shared_p
sagnikc-dremio commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r465496907
##
File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc
##
@@ -87,6 +87,19 @@ TEST(TestExtendedMathOps, TestLogWithBase) {
EXPECT_EQ(c
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r465485532
##
File path: cpp/src/gandiva/precompiled/arithmetic_ops.cc
##
@@ -234,6 +234,25 @@ DIV_FLOAT(float64)
#undef DIV_FLOAT
+#define ROUND(TYPE)
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r465490152
##
File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc
##
@@ -87,6 +87,19 @@ TEST(TestExtendedMathOps, TestLogWithBase) {
EXPECT_EQ(cont
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r465485532
##
File path: cpp/src/gandiva/precompiled/arithmetic_ops.cc
##
@@ -234,6 +234,25 @@ DIV_FLOAT(float64)
#undef DIV_FLOAT
+#define ROUND(TYPE)
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r465485532
##
File path: cpp/src/gandiva/precompiled/arithmetic_ops.cc
##
@@ -234,6 +234,25 @@ DIV_FLOAT(float64)
#undef DIV_FLOAT
+#define ROUND(TYPE)
sagnikc-dremio commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r465480283
##
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##
@@ -101,4 +101,10 @@ TEST(TestArithmeticOps, TestDiv) {
context.Reset();
}
sagnikc-dremio commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r465480139
##
File path: cpp/src/gandiva/precompiled/arithmetic_ops.cc
##
@@ -234,6 +234,25 @@ DIV_FLOAT(float64)
#undef DIV_FLOAT
+#define ROUND(TYPE)
sagnikc-dremio commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r465480283
##
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##
@@ -101,4 +101,10 @@ TEST(TestArithmeticOps, TestDiv) {
context.Reset();
}
kou commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465476936
##
File path: cpp/src/arrow/ipc/reader.cc
##
@@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset(
const flatbuf::RecordBatch* metadata, const std::shared_ptr
kou closed pull request #7902:
URL: https://github.com/apache/arrow/pull/7902
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
kou commented on pull request #7902:
URL: https://github.com/apache/arrow/pull/7902#issuecomment-668931859
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465423744
##
File path: cpp/src/arrow/ipc/reader.cc
##
@@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset(
const flatbuf::RecordBatch* metadata, const std::shared_p
kou closed pull request #7897:
URL: https://github.com/apache/arrow/pull/7897
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
kou commented on pull request #7897:
URL: https://github.com/apache/arrow/pull/7897#issuecomment-668834469
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
kou commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465339816
##
File path: cpp/src/arrow/ipc/reader.cc
##
@@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset(
const flatbuf::RecordBatch* metadata, const std::shared_ptr
github-actions[bot] commented on pull request #7902:
URL: https://github.com/apache/arrow/pull/7902#issuecomment-668830212
https://issues.apache.org/jira/browse/ARROW-9650
This is an automated message from the Apache Git Serv
github-actions[bot] commented on pull request #7902:
URL: https://github.com/apache/arrow/pull/7902#issuecomment-668829583
Revision: 7a7ebea2d818a53a0ea3187f52b0031deeb8fc6d
Submitted crossbow builds: [ursa-labs/crossbow @
actions-464](https://github.com/ursa-labs/crossbow/branches/a
kou commented on pull request #7902:
URL: https://github.com/apache/arrow/pull/7902#issuecomment-668828816
@github-actions crossbow submit -g linux
This is an automated message from the Apache Git Service.
To respond to the m
kou opened a new pull request #7902:
URL: https://github.com/apache/arrow/pull/7902
Because it reached EOL.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
maxburke commented on pull request #7319:
URL: https://github.com/apache/arrow/pull/7319#issuecomment-668815376
Oh! One more :) This one uses the ParquetWriter trait instead of
std::fs::File:
https://github.com/urbanlogiq/arrow/commit/e15851e11cef942fcd3803cb80016c35e49dca1b
(our pr
maxburke commented on pull request #7319:
URL: https://github.com/apache/arrow/pull/7319#issuecomment-668810183
Small comment about the API, something I found necessary was being able to
pass in props to the writer interface:
https://github.com/urbanlogiq/arrow/commit/5e08cf655aa78536d1fe7
wesm commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r465310364
##
File path: cpp/src/arrow/util/compression.cc
##
@@ -131,7 +131,7 @@ Result>
Codec::Create(Compression::type codec_type,
if (compression_level_set) {
github-actions[bot] commented on pull request #7901:
URL: https://github.com/apache/arrow/pull/7901#issuecomment-668798574
https://issues.apache.org/jira/browse/ARROW-9543
This is an automated message from the Apache Git Serv
bkietz opened a new pull request #7901:
URL: https://github.com/apache/arrow/pull/7901
Replace `StringConverter` with `ParseValueTraits` and emphasize that the
function `ParseValue` is the entrypoint for parsing primitive values.
Replace `StringFormatter` with `FormatValueTraits` and
bkietz closed pull request #7793:
URL: https://github.com/apache/arrow/pull/7793
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465270135
##
File path: cpp/src/arrow/array/util.cc
##
@@ -74,6 +74,186 @@ class ArrayDataWrapper {
std::shared_ptr* out_;
};
+class ArrayDataEndianSwapper {
+ pu
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465269578
##
File path: cpp/src/arrow/type.h
##
@@ -1582,13 +1583,23 @@ class ARROW_EXPORT FieldRef {
// --
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465269890
##
File path: cpp/src/arrow/type.h
##
@@ -1600,6 +1611,12 @@ class ARROW_EXPORT Schema : public
detail::Fingerprintable,
bool Equals(const Schema& other,
github-actions[bot] commented on pull request #7900:
URL: https://github.com/apache/arrow/pull/7900#issuecomment-668771535
https://issues.apache.org/jira/browse/ARROW-9573
This is an automated message from the Apache Git Serv
bkietz commented on a change in pull request #7869:
URL: https://github.com/apache/arrow/pull/7869#discussion_r465261846
##
File path: cpp/src/arrow/dataset/file_base.cc
##
@@ -154,52 +157,101 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl(
return MakeVectorIterator
bkietz commented on a change in pull request #7869:
URL: https://github.com/apache/arrow/pull/7869#discussion_r465259555
##
File path: cpp/src/arrow/dataset/file_base.cc
##
@@ -154,52 +157,101 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl(
return MakeVectorIterator
bkietz opened a new pull request #7900:
URL: https://github.com/apache/arrow/pull/7900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465252291
##
File path: cpp/src/arrow/ipc/reader.cc
##
@@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset(
const flatbuf::RecordBatch* metadata, const std::shared_p
jorisvandenbossche commented on a change in pull request #7869:
URL: https://github.com/apache/arrow/pull/7869#discussion_r465242408
##
File path: cpp/src/arrow/dataset/filter.cc
##
@@ -1493,5 +1495,191 @@ Result>
Expression::Deserialize(const Buffer& serial
return Deserial
bkietz closed pull request #7896:
URL: https://github.com/apache/arrow/pull/7896
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nealrichardson commented on pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#issuecomment-66862
@github-actions autotune everything
This is an automated message from the Apache Git Service.
To respond to
nealrichardson commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r465136902
##
File path: r/src/arrow_types.h
##
@@ -17,25 +17,9 @@
#pragma once
-#include "./arrow_rcpp.h"
-
-template
-struct NoDelete {
- inline void o
romainfrancois commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r465137242
##
File path: r/R/schema.R
##
@@ -85,7 +85,6 @@ Schema <- R6Class("Schema",
active = list(
names = function() {
out <- Schema__field_n
nealrichardson commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r465135254
##
File path: r/R/schema.R
##
@@ -85,7 +85,6 @@ Schema <- R6Class("Schema",
active = list(
names = function() {
out <- Schema__field_n
andygrove commented on pull request #7894:
URL: https://github.com/apache/arrow/pull/7894#issuecomment-668644692
We can ignore the mac failure. It's a known issue.
This is an automated message from the Apache Git Service.
To
vertexclique commented on pull request #7894:
URL: https://github.com/apache/arrow/pull/7894#issuecomment-668644232
macos error is odd. since serde_derive is there:
https://github.com/apache/arrow/pull/7894/files#diff-c9a039d0f56d7ad3611f9278a44d9056R40
---
wqc200 commented on a change in pull request #7899:
URL: https://github.com/apache/arrow/pull/7899#discussion_r465104391
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -259,6 +260,11 @@ impl ExecutionContext {
self.datasources.insert(name.to_string(), pro
jorgecarleitao commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-668615992
Ups, forgot to change the status. Ready to review, @andygrove .
This is an automated message from the Apach
andygrove commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-668608855
@jorgecarleitao Is this still a draft or is it ready for review now?
This is an automated message from the Apach
romainfrancois commented on pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#issuecomment-668608898
I somehow lost the ability to lint locally:
```
r % CLANG_FORMAT=$(which clang-format) ./lint.sh
Traceback (most recent call last):
File
"/Users/romainfra
github-actions[bot] commented on pull request #7899:
URL: https://github.com/apache/arrow/pull/7899#issuecomment-668606160
https://issues.apache.org/jira/browse/ARROW-9632
This is an automated message from the Apache Git Serv
andygrove commented on a change in pull request #7899:
URL: https://github.com/apache/arrow/pull/7899#discussion_r465060246
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -259,6 +260,11 @@ impl ExecutionContext {
self.datasources.insert(name.to_string(),
andygrove commented on pull request #7894:
URL: https://github.com/apache/arrow/pull/7894#issuecomment-668605504
@vertexclique Please rebase now that the other related PR is merged.
This is an automated message from the Apach
andygrove closed pull request #7892:
URL: https://github.com/apache/arrow/pull/7892
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wqc200 opened a new pull request #7899:
URL: https://github.com/apache/arrow/pull/7899
I use ExecutionContextSchemaProvider in outside app, so i add keyword "pub"
for ExecutionContextSchemaProvider, and add a new func "new" for
ExecutionContextSchemaProvider.
I add keyword "pub" for
wqc200 closed pull request #7895:
URL: https://github.com/apache/arrow/pull/7895
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sbinet closed pull request #7754:
URL: https://github.com/apache/arrow/pull/7754
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sbinet commented on a change in pull request #7752:
URL: https://github.com/apache/arrow/pull/7752#discussion_r465026675
##
File path: go/arrow/internal/arrdata/arrdata.go
##
@@ -30,6 +30,7 @@ import (
var (
Records = make(map[string][]array.Record)
+ Prett
github-actions[bot] commented on pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#issuecomment-668579349
https://issues.apache.org/jira/browse/ARROW-9640
This is an automated message from the Apache Git Serv
sbinet commented on a change in pull request #7823:
URL: https://github.com/apache/arrow/pull/7823#discussion_r465023873
##
File path: go/arrow/ipc/cmd/arrow-json-integration-test/main.go
##
@@ -158,16 +148,6 @@ func cnvToARROW(arrowName, jsonName string, verbose bool)
error {
vertexclique edited a comment on pull request #7892:
URL: https://github.com/apache/arrow/pull/7892#issuecomment-668499855
@nevi-me @andygrove
ok so yeah what I can do moving forward is:
1. create a ticket and rebase master on top.
2. Finalize https://github.com/apache/arrow/pull/7
vertexclique commented on pull request #7892:
URL: https://github.com/apache/arrow/pull/7892#issuecomment-668499855
@nevi-me @andygrove
ok so yeah what i can do moving forward is:
1. create a ticket and rebase master on top.
2. Finalize https://github.com/apache/arrow/pull/7873 to
nevi-me commented on pull request #7892:
URL: https://github.com/apache/arrow/pull/7892#issuecomment-668495833
> @vertexclique I would prefer to have this PR only change the dependency
between arrow and flight. This is quite a large change in itself. We can create
follow-on PRs to make cha
liyafan82 commented on a change in pull request #7817:
URL: https://github.com/apache/arrow/pull/7817#discussion_r464922804
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestValueVector.java
##
@@ -2977,4 +2977,47 @@ public void testEmptyBufBehavior() {
liyafan82 commented on a change in pull request #7817:
URL: https://github.com/apache/arrow/pull/7817#discussion_r464922151
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestDictionaryVector.java
##
@@ -878,6 +880,103 @@ public void testEncodeStructSubFieldWi
jorisvandenbossche commented on issue #7857:
URL: https://github.com/apache/arrow/issues/7857#issuecomment-668448152
I suppose I remember https://issues.apache.org/jira/browse/ARROW-8427, which
seems somewhat similar (about only skipping underscores in child directories,
not in the base pa
tianchen92 commented on pull request #6156:
URL: https://github.com/apache/arrow/pull/6156#issuecomment-668444768
> @tianchen92 would you mind starting a thread on the ML, it seems that
@jacques-n might not have bandwidth.
ok, started already.
--
jorisvandenbossche commented on issue #7857:
URL: https://github.com/apache/arrow/issues/7857#issuecomment-668441257
Actually, this is a slightly different issue, since it is not about
underscores in partition keys, but in the base path. I thought this was
something we already fixed.
---
github-actions[bot] commented on pull request #7898:
URL: https://github.com/apache/arrow/pull/7898#issuecomment-668440282
https://issues.apache.org/jira/browse/ARROW-9642
This is an automated message from the Apache Git Serv
tianchen92 closed pull request #7861:
URL: https://github.com/apache/arrow/pull/7861
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mrkn opened a new pull request #7898:
URL: https://github.com/apache/arrow/pull/7898
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kou closed pull request #7747:
URL: https://github.com/apache/arrow/pull/7747
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
jorisvandenbossche commented on issue #7857:
URL: https://github.com/apache/arrow/issues/7857#issuecomment-668426497
There is already an issue about this ->
https://issues.apache.org/jira/browse/ARROW-9573
This is an automat
69 matches
Mail list logo
