github-actions[bot] commented on pull request #7916:
URL: https://github.com/apache/arrow/pull/7916#issuecomment-670828493
https://issues.apache.org/jira/browse/ARROW-9673
This is an automated message from the Apache Git Serv
wqc200 opened a new pull request #7916:
URL: https://github.com/apache/arrow/pull/7916
i use func 'DFParser::parse_sql' in outsie app with mysql dialect, but
parser_sql use generic dialect default, we need to add a parameter so that we
can pass in the dialect.
thanks.
emkornfield commented on a change in pull request #7817:
URL: https://github.com/apache/arrow/pull/7817#discussion_r467357953
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/ipc/TestUIntDictionaryRoundTrip.java
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apach
emkornfield commented on a change in pull request #7817:
URL: https://github.com/apache/arrow/pull/7817#discussion_r467357784
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/ipc/TestUIntDictionaryRoundTrip.java
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apach
emkornfield commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r467356218
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionUtil.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Sof
emkornfield commented on a change in pull request #7248:
URL: https://github.com/apache/arrow/pull/7248#discussion_r467354214
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorBufferVisitor.java
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the
emkornfield commented on a change in pull request #7816:
URL: https://github.com/apache/arrow/pull/7816#discussion_r467353299
##
File path: cpp/src/arrow/python/python_to_arrow.cc
##
@@ -191,10 +191,11 @@ struct ValueConverter {
template <>
struct ValueConverter {
- static
emkornfield commented on a change in pull request #7816:
URL: https://github.com/apache/arrow/pull/7816#discussion_r467353205
##
File path: ci/scripts/integration_spark.sh
##
@@ -22,6 +22,9 @@ source_dir=${1}
spark_dir=${2}
spark_version=${SPARK_VERSION:-master}
+# Use old
emkornfield closed pull request #7915:
URL: https://github.com/apache/arrow/pull/7915
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield commented on pull request #7915:
URL: https://github.com/apache/arrow/pull/7915#issuecomment-670813455
It seems travis is having issues today. I'm going to go ahead and merge
this.
This is an automated message f
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r467352487
##
File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc
##
@@ -87,6 +87,19 @@ TEST(TestExtendedMathOps, TestLogWithBase) {
EXPECT_EQ(cont
emkornfield closed pull request #7815:
URL: https://github.com/apache/arrow/pull/7815
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield commented on pull request #7815:
URL: https://github.com/apache/arrow/pull/7815#issuecomment-670812386
+1, thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
offthewall123 commented on a change in pull request #7815:
URL: https://github.com/apache/arrow/pull/7815#discussion_r467342682
##
File path:
java/plasma/src/test/java/org/apache/arrow/plasma/PlasmaClientTest.java
##
@@ -277,6 +278,20 @@ public void doByteBufferTest() {
c
kiszk commented on pull request #7915:
URL: https://github.com/apache/arrow/pull/7915#issuecomment-670799483
good catch!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
wesm commented on a change in pull request #7816:
URL: https://github.com/apache/arrow/pull/7816#discussion_r467330463
##
File path: ci/scripts/integration_spark.sh
##
@@ -22,6 +22,9 @@ source_dir=${1}
spark_dir=${2}
spark_version=${SPARK_VERSION:-master}
+# Use old behavio
fredgan commented on a change in pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#discussion_r467334354
##
File path: docs/source/format/Columnar.rst
##
@@ -76,7 +76,7 @@ concepts, here is a small glossary to help disambiguate.
* **Nested type**: a data type
eerhardt commented on pull request #6122:
URL: https://github.com/apache/arrow/pull/6122#issuecomment-670770541
Just a follow up here - a fix has been checked into .NET Framework 4.7 and
4.8 that makes this change no longer necessary. According to
https://github.com/dotnet/runtime/issues/1
andygrove commented on pull request #7798:
URL: https://github.com/apache/arrow/pull/7798#issuecomment-670725220
I completely agree. I just happen to have a protobuf definition for plans
and expressions as well as serde code for Java and Rust that I would be happy
to contribute. We would n
wesm commented on issue #7910:
URL: https://github.com/apache/arrow/issues/7910#issuecomment-670723509
Could you open a JIRA issue and describe in more detail the scenario that
leads to this error?
This is an automated messa
wesm commented on pull request #7798:
URL: https://github.com/apache/arrow/pull/7798#issuecomment-670723322
This PR makes me think that at some point (when someone gets really
motivated), it would be interesting to implement a non-language-dependent
benchmark harness for certain operations
github-actions[bot] commented on pull request #7915:
URL: https://github.com/apache/arrow/pull/7915#issuecomment-670721481
https://issues.apache.org/jira/browse/ARROW-9671
This is an automated message from the Apache Git Serv
emkornfield commented on pull request #7915:
URL: https://github.com/apache/arrow/pull/7915#issuecomment-670721077
Looks like formatting needs to be run:
```
template ::value &&
- (sizeof(T) <=
sizeof(uint64_t)), T>::type>
+
MingyuZhong opened a new pull request #7915:
URL: https://github.com/apache/arrow/pull/7915
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
kou commented on a change in pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#discussion_r467259196
##
File path: docs/source/format/Columnar.rst
##
@@ -76,7 +76,7 @@ concepts, here is a small glossary to help disambiguate.
* **Nested type**: a data type whos
bkietz commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r467084647
##
File path: r/src/array_from_vector.cpp
##
@@ -406,9 +403,12 @@ std::shared_ptr
MakeFactorArray(Rcpp::IntegerVector_ factor,
case Type::INT64:
wesm closed pull request #7903:
URL: https://github.com/apache/arrow/pull/7903
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
fredgan commented on pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#issuecomment-670605044
@sbinet Hi, It's not about Go part, but I just fix some typos when I read
the Document. Can you also help handle it? It's been a long time.
--
sbinet closed pull request #7752:
URL: https://github.com/apache/arrow/pull/7752
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
fredgan commented on pull request #7752:
URL: https://github.com/apache/arrow/pull/7752#issuecomment-670601511
@sbinet OK, good point. I renamed them, and moved them to `arrjson_test.go`.
This is an automated message from th
andygrove commented on pull request #7894:
URL: https://github.com/apache/arrow/pull/7894#issuecomment-670575931
Thanks @vertexclique ... your regex skills are better than mine.
One last thing ... we probably shouldn't have flight protocol changes as
part of this PR. Could you rever
jorisvandenbossche commented on pull request #7821:
URL: https://github.com/apache/arrow/pull/7821#issuecomment-670567980
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log
jorisvandenbossche closed pull request #7821:
URL: https://github.com/apache/arrow/pull/7821
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on pull request #7903:
URL: https://github.com/apache/arrow/pull/7903#issuecomment-670565444
Revision: 4300febdbf53bfebc98e5cea88b4b065ffc22041
Submitted crossbow builds: [ursa-labs/crossbow @
actions-469](https://github.com/ursa-labs/crossbow/branches/a
nealrichardson commented on pull request #7903:
URL: https://github.com/apache/arrow/pull/7903#issuecomment-670564397
@github-actions crossbow submit -g r
This is an automated message from the Apache Git Service.
To respond t
nealrichardson commented on a change in pull request #7911:
URL: https://github.com/apache/arrow/pull/7911#discussion_r467099186
##
File path: r/tests/testthat/test-dataset.R
##
@@ -391,6 +391,17 @@ test_that("filter() with %in%", {
collect(),
tibble(int = df1$int[c
vertexclique commented on pull request #7894:
URL: https://github.com/apache/arrow/pull/7894#issuecomment-670545087
@andygrove Seems like done.
This is an automated message from the Apache Git Service.
To respond to the messa
jorisvandenbossche commented on pull request #7793:
URL: https://github.com/apache/arrow/pull/7793#issuecomment-670506980
One note on this: officially, ISO 8601 says one has to use "T" as separator
for the date and time component of a string, and not a white space (although in
practice of
sbinet closed pull request #7823:
URL: https://github.com/apache/arrow/pull/7823
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sbinet commented on a change in pull request #7823:
URL: https://github.com/apache/arrow/pull/7823#discussion_r467016096
##
File path: go/arrow/internal/arrjson/arrjson_test.go
##
@@ -36,12 +42,11 @@ func TestReadWrite(t *testing.T) {
mem :=
memory.NewC
jorisvandenbossche commented on pull request #7907:
URL: https://github.com/apache/arrow/pull/7907#issuecomment-670496983
Added the specific case of a directory to the existing test about this
This is an automated message fro
fredgan commented on a change in pull request #7823:
URL: https://github.com/apache/arrow/pull/7823#discussion_r467012651
##
File path: go/arrow/internal/arrjson/arrjson_test.go
##
@@ -36,12 +42,11 @@ func TestReadWrite(t *testing.T) {
mem :=
memory.New
liyafan82 commented on a change in pull request #7248:
URL: https://github.com/apache/arrow/pull/7248#discussion_r467004875
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorDataVisitor.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apac
liyafan82 commented on a change in pull request #7248:
URL: https://github.com/apache/arrow/pull/7248#discussion_r467005269
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/validate/TestValidateVectorFull.java
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache
liyafan82 commented on a change in pull request #7248:
URL: https://github.com/apache/arrow/pull/7248#discussion_r467004312
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorBufferVisitor.java
##
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Ap
liyafan82 commented on a change in pull request #7248:
URL: https://github.com/apache/arrow/pull/7248#discussion_r467003950
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorBufferVisitor.java
##
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Ap
github-actions[bot] commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-670479711
Revision: e21e9ff23f98427d1898f8de99945549e2fabe12
Submitted crossbow builds: [ursa-labs/crossbow @
actions-468](https://github.com/ursa-labs/crossbow/branches/a
jorisvandenbossche commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-670479036
@github-actions crossbow submit test-conda-python-3.7-kartothek-latest
test-conda-python-3.7-kartothek-master
-
jorisvandenbossche commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-670478968
cc @fjetter @xhochy in case if are familiar with those failures
There are several failures like this (related to exit codes):
```
___
jorisvandenbossche commented on a change in pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#discussion_r466989211
##
File path: ci/docker/conda-python-kartothek.dockerfile
##
@@ -32,7 +32,14 @@ RUN conda install -c conda-forge -q \
storefact \
rymurr commented on a change in pull request #7815:
URL: https://github.com/apache/arrow/pull/7815#discussion_r466964416
##
File path:
java/plasma/src/test/java/org/apache/arrow/plasma/PlasmaClientTest.java
##
@@ -277,6 +278,20 @@ public void doByteBufferTest() {
client.r
sbinet commented on a change in pull request #7823:
URL: https://github.com/apache/arrow/pull/7823#discussion_r466958913
##
File path: go/arrow/arrio/arrio_test.go
##
@@ -94,19 +100,17 @@ func TestCopy(t *testing.T) {
mem
fredgan edited a comment on pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#issuecomment-670422135
@wesm Hi Wes, do you have any option about this? if no, can you help handle
it?
This is an automated messa
fredgan commented on pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#issuecomment-670422135
@wesm Hi wes, do you have any option about this? if no, can you help handle
it?
This is an automated message from
fredgan edited a comment on pull request #7823:
URL: https://github.com/apache/arrow/pull/7823#issuecomment-670420835
@sbinet Yeah, I agree. I have changed them to this. Sorry for long time to
reply. Should be OK now.
This i
fredgan commented on pull request #7823:
URL: https://github.com/apache/arrow/pull/7823#issuecomment-670420835
@sbinet Yeah, I agree. I have changed them to this. Should be OK now.
This is an automated message from the Apache
jhorstmann commented on pull request #7854:
URL: https://github.com/apache/arrow/pull/7854#issuecomment-670407634
@paddyhoran can you take a look at this PR?
This is an automated message from the Apache Git Service.
To respon
57 matches
Mail list logo
