tianchen92 commented on a change in pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#discussion_r471248061
##
File path: cpp/src/arrow/buffer_builder.h
##
@@ -292,6 +292,11 @@ class TypedBufferBuilder {
return Status::OK();
}
+ void AppendEmpty(int6
tianchen92 commented on a change in pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#discussion_r471247138
##
File path: cpp/src/arrow/array/builder_base.h
##
@@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder {
virtual Status AppendNull() = 0;
virtual St
github-actions[bot] commented on pull request #7979:
URL: https://github.com/apache/arrow/pull/7979#issuecomment-674652737
https://issues.apache.org/jira/browse/ARROW-9766
This is an automated message from the Apache Git Serv
emkornfield opened a new pull request #7979:
URL: https://github.com/apache/arrow/pull/7979
… and old logic
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
andygrove closed pull request #7978:
URL: https://github.com/apache/arrow/pull/7978
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
liyafan82 commented on pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#issuecomment-674619545
> @liyafan82 any reason why this can't be merged?
@emkornfield I don't think so.
I am going to merge this in a few days, if there is no more comment.
Thank all revi
liyafan82 commented on pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#issuecomment-674618715
> > The conda integration test is failing, because the default no
compression option is not supported by the specification. Maybe we need to
start a discussion in the ML.
>
github-actions[bot] commented on pull request #7978:
URL: https://github.com/apache/arrow/pull/7978#issuecomment-674584950
https://issues.apache.org/jira/browse/ARROW-9757
This is an automated message from the Apache Git Serv
andygrove commented on pull request #7978:
URL: https://github.com/apache/arrow/pull/7978#issuecomment-674584210
@alamb @jorgecarleitao fyi
This is an automated message from the Apache Git Service.
To respond to the message,
andygrove opened a new pull request #7978:
URL: https://github.com/apache/arrow/pull/7978
Users can now just add `use datafusion::prelude::*;` to bring in some key
items such as `ExecutionContext` to make it easier to get started.
Rustdocs updated and improved as well.
kou commented on pull request #7977:
URL: https://github.com/apache/arrow/pull/7977#issuecomment-674582839
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
kou closed pull request #7977:
URL: https://github.com/apache/arrow/pull/7977
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
andygrove closed pull request #7976:
URL: https://github.com/apache/arrow/pull/7976
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #7977:
URL: https://github.com/apache/arrow/pull/7977#issuecomment-674579363
https://issues.apache.org/jira/browse/ARROW-9764
This is an automated message from the Apache Git Serv
kou opened a new pull request #7977:
URL: https://github.com/apache/arrow/pull/7977
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wesm closed pull request #7816:
URL: https://github.com/apache/arrow/pull/7816
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm commented on issue #7968:
URL: https://github.com/apache/arrow/issues/7968#issuecomment-674571250
Can you direct this question to the dev@ or user@ mailing list (or open a
JIRA if you think you have found a bug or missing feature)?
github-actions[bot] commented on pull request #7976:
URL: https://github.com/apache/arrow/pull/7976#issuecomment-674569352
https://issues.apache.org/jira/browse/ARROW-9759
This is an automated message from the Apache Git Serv
andygrove opened a new pull request #7976:
URL: https://github.com/apache/arrow/pull/7976
- Implements `DataFrame.sort`
- Improves Rustdoc code examples to use `?` instead of `unwrap()`
- Implements `Expr.and` and `Expr.or` since I noticed those were missing
-
andygrove closed pull request #7879:
URL: https://github.com/apache/arrow/pull/7879
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #7916:
URL: https://github.com/apache/arrow/pull/7916
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r471146570
##
File path: rust/datafusion/src/execution/physical_plan/math_expressions.rs
##
@@ -20,36 +20,62 @@
use crate::error::ExecutionError;
use crate::e
andygrove commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r471146144
##
File path: rust/datafusion/src/execution/physical_plan/math_expressions.rs
##
@@ -20,36 +20,62 @@
use crate::error::ExecutionError;
use crate::execut
andygrove commented on pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#issuecomment-674563365
> I think that the logic of get_supertype is not entirely correct atm (e.g.
utf8 can be converted to all types), but we have an issue tracking that.
Yes, it is bad code an
andygrove closed pull request #7975:
URL: https://github.com/apache/arrow/pull/7975
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on pull request #7975:
URL: https://github.com/apache/arrow/pull/7975#issuecomment-674560250
Thanks @jorgecarleitao I added a test and removed the legacy batch_size
param everywhere now that it is in the configs. This really helped clean up the
UX some more.
-
jorgecarleitao edited a comment on pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#issuecomment-674555985
> I reviewed the logic carefully in this PR and I think overall it is quite
good. Nice work @jorgecarleitao. The only thing I personally think is needed
before it wo
jorgecarleitao commented on pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#issuecomment-674555985
> I reviewed the logic carefully in this PR and I think overall it is quite
good. Nice work @jorgecarleitao. The only thing I personally think is needed
before it would be
andygrove commented on a change in pull request #7975:
URL: https://github.com/apache/arrow/pull/7975#discussion_r471139144
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -373,363 +361,13 @@ impl ExecutionContext {
pub fn create_physical_plan(
&self,
jorgecarleitao commented on a change in pull request #7975:
URL: https://github.com/apache/arrow/pull/7975#discussion_r471137546
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -373,363 +361,13 @@ impl ExecutionContext {
pub fn create_physical_plan(
&
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r471134987
##
File path: rust/datafusion/src/execution/physical_plan/udf.rs
##
@@ -37,8 +37,11 @@ pub type ScalarUdf = Arc
Result + Send + Sync>;
pub struct S
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r471134155
##
File path: rust/datafusion/src/sql/planner.rs
##
@@ -523,10 +523,14 @@ impl SqlToRel {
let mut safe_args: Vec = vec
github-actions[bot] commented on pull request #7975:
URL: https://github.com/apache/arrow/pull/7975#issuecomment-674549512
https://issues.apache.org/jira/browse/ARROW-9758
This is an automated message from the Apache Git Serv
andygrove commented on pull request #7975:
URL: https://github.com/apache/arrow/pull/7975#issuecomment-674547945
@jorgecarleitao @alamb
This is an automated message from the Apache Git Service.
To respond to the message, ple
andygrove opened a new pull request #7975:
URL: https://github.com/apache/arrow/pull/7975
This PR mainly moves the physical query logic out of ExecutionContext and
into its own struct. There is a new `PhysicalPlanner` trait, and it is now
possible to bring-you-own planner if the one in Dat
andygrove closed pull request #7972:
URL: https://github.com/apache/arrow/pull/7972
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jorgecarleitao commented on pull request #7972:
URL: https://github.com/apache/arrow/pull/7972#issuecomment-674546437
> Thanks @jorgecarleitao I wanted to move the aggregate functions too but
ran into a problem and it probably relates to your PRs .. I will file a JIRA to
explain this.
andygrove commented on pull request #7972:
URL: https://github.com/apache/arrow/pull/7972#issuecomment-674545699
Thanks @jorgecarleitao I wanted to move the aggregate functions too but ran
into a problem and it probably relates to your PRs .. I will file a JIRA to
explain this.
jorgecarleitao commented on a change in pull request #7972:
URL: https://github.com/apache/arrow/pull/7972#discussion_r471127403
##
File path: rust/datafusion/src/dataframe.rs
##
@@ -0,0 +1,168 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
andygrove commented on pull request #7972:
URL: https://github.com/apache/arrow/pull/7972#issuecomment-674540473
@jorgecarleitao @alamb @houqp @jhorstmann This is ready for re-review.
Please see the updated PR description.
T
andygrove commented on a change in pull request #7972:
URL: https://github.com/apache/arrow/pull/7972#discussion_r471125731
##
File path: rust/datafusion/examples/memory_table_api.rs
##
@@ -51,15 +51,15 @@ fn main() -> Result<()> {
// declare a table in memory. In spark AP
emkornfield commented on a change in pull request #7973:
URL: https://github.com/apache/arrow/pull/7973#discussion_r471123867
##
File path: cpp/src/parquet/arrow/arrow_schema_test.cc
##
@@ -1140,5 +1144,235 @@ TEST(TestFromParquetSchema, CorruptMetadata) {
ASSERT_RAISES(IOEr
andygrove commented on a change in pull request #7972:
URL: https://github.com/apache/arrow/pull/7972#discussion_r471116942
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -89,12 +91,18 @@ impl ExecutionConfig {
}
/// Execution context for registering data sour
alamb commented on a change in pull request #7970:
URL: https://github.com/apache/arrow/pull/7970#discussion_r471021201
##
File path: rust/datafusion/Cargo.toml
##
@@ -53,6 +53,8 @@ rustyline = {version = "6.0", optional = true}
crossbeam = "0.7"
paste = "0.1"
num_cpus = "1.
alamb edited a comment on pull request #7971:
URL: https://github.com/apache/arrow/pull/7971#issuecomment-674512463
I left some comments on #7967 and I'll plan to review this PR after that one
gets finalized. You are a machine @jorgecarleitao 🚄
---
alamb commented on pull request #7971:
URL: https://github.com/apache/arrow/pull/7971#issuecomment-674512463
I left some comments on #7967 and I'll plan to review this PR after that one
gets finalized. You are a machine @jorgecarleitao
alamb commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r471097019
##
File path: rust/datafusion/src/execution/physical_plan/udf.rs
##
@@ -37,8 +37,11 @@ pub type ScalarUdf = Arc
Result + Send + Sync>;
pub struct ScalarFunc
jorgecarleitao commented on pull request #7830:
URL: https://github.com/apache/arrow/pull/7830#issuecomment-674512019
I agree with you @andygrove that we need to revisit the partitioning before
tackling this. Closing
This is
jorgecarleitao closed pull request #7830:
URL: https://github.com/apache/arrow/pull/7830
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jorgecarleitao commented on a change in pull request #7974:
URL: https://github.com/apache/arrow/pull/7974#discussion_r471097271
##
File path: rust/datafusion/src/execution/physical_plan/udf.rs
##
@@ -50,7 +58,7 @@ impl Debug for ScalarFunction {
f.debug_struct("Scalar
jorgecarleitao commented on a change in pull request #7974:
URL: https://github.com/apache/arrow/pull/7974#discussion_r471097263
##
File path: rust/datafusion/src/execution/physical_plan/udf.rs
##
@@ -87,7 +95,7 @@ impl Debug for ScalarFunctionExpr {
.field("fun",
github-actions[bot] commented on pull request #7974:
URL: https://github.com/apache/arrow/pull/7974#issuecomment-674510841
https://issues.apache.org/jira/browse/ARROW-9756
This is an automated message from the Apache Git Serv
jorgecarleitao commented on a change in pull request #7974:
URL: https://github.com/apache/arrow/pull/7974#discussion_r471097047
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -1087,7 +1101,7 @@ impl LogicalPlanBuilder {
/// Apply a projection
pub fn project(&
jorgecarleitao commented on pull request #7974:
URL: https://github.com/apache/arrow/pull/7974#issuecomment-674510486
FYI @andygrove @alamb @houqp : this is a draft because it depends on other
PRs being reviewed and accepted.
---
jorgecarleitao opened a new pull request #7974:
URL: https://github.com/apache/arrow/pull/7974
This PR is done on top of #7971 ,
Its current runtime consequence is that all our math functions now return
float32 or float64 depending on their incoming column (and use float32 for
othe
alamb commented on a change in pull request #7972:
URL: https://github.com/apache/arrow/pull/7972#discussion_r471094243
##
File path: rust/datafusion/src/dataframe.rs
##
@@ -15,42 +15,46 @@
// specific language governing permissions and limitations
// under the License.
-//
jorgecarleitao commented on a change in pull request #7972:
URL: https://github.com/apache/arrow/pull/7972#discussion_r471078546
##
File path: rust/datafusion/examples/memory_table_api.rs
##
@@ -51,15 +51,15 @@ fn main() -> Result<()> {
// declare a table in memory. In spa
github-actions[bot] commented on pull request #7973:
URL: https://github.com/apache/arrow/pull/7973#issuecomment-674492185
https://issues.apache.org/jira/browse/ARROW-8493
This is an automated message from the Apache Git Serv
emkornfield opened a new pull request #7973:
URL: https://github.com/apache/arrow/pull/7973
level
- Also add additional check that list annotated fields aren't repeated
- Adds unit test for SchemaManifest::Make to verify rep/def/ancestor
levels.
---
59 matches
Mail list logo
