arw2019 commented on a change in pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#discussion_r473660611
##
File path: python/setup.py
##
@@ -224,7 +224,7 @@ def _run_cmake(self):
static_lib_option = ''
cmake_options = [
-
kou commented on a change in pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#discussion_r473645378
##
File path: python/setup.py
##
@@ -224,7 +224,7 @@ def _run_cmake(self):
static_lib_option = ''
cmake_options = [
-
arw2019 commented on pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#issuecomment-677235758
> Could you replace existing `PYTHON_EXECUTABLE` with `Python3_EXECUTABLE`
and add note that "you need to use `PYTHON_EXECUTABLE` with CMake < 3.15" or
something?
> It's better
github-actions[bot] commented on pull request #8015:
URL: https://github.com/apache/arrow/pull/8015#issuecomment-677189079
https://issues.apache.org/jira/browse/PARQUET-1899
This is an automated message from the Apache Git Se
emkornfield opened a new pull request #8015:
URL: https://github.com/apache/arrow/pull/8015
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
emkornfield commented on pull request #7973:
URL: https://github.com/apache/arrow/pull/7973#issuecomment-676927791
CC @wesm or @pitrou
This is an automated message from the Apache Git Service.
To respond to the message, plea
sunchao closed pull request #8007:
URL: https://github.com/apache/arrow/pull/8007
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
sunchao commented on a change in pull request #8007:
URL: https://github.com/apache/arrow/pull/8007#discussion_r473493106
##
File path: rust/parquet/src/arrow/array_reader.rs
##
@@ -136,10 +136,8 @@ impl ArrayReader for PrimitiveArrayReader {
while records_read < batch
github-actions[bot] commented on pull request #8014:
URL: https://github.com/apache/arrow/pull/8014#issuecomment-676833486
https://issues.apache.org/jira/browse/ARROW-9808
This is an automated message from the Apache Git Serv
alimcmaster1 opened a new pull request #8014:
URL: https://github.com/apache/arrow/pull/8014
https://issues.apache.org/jira/browse/ARROW-9808
cc @jorisvandenbossche to correct me if i'm confused
This is an automated me
emkornfield commented on a change in pull request #8011:
URL: https://github.com/apache/arrow/pull/8011#discussion_r473424122
##
File path: go/arrow/type_traits_decimal128.go
##
@@ -39,8 +40,13 @@ func (decimal128Traits) BytesRequired(n int) int { return
Decimal128SizeBytes *
alamb commented on a change in pull request #8009:
URL: https://github.com/apache/arrow/pull/8009#discussion_r473348774
##
File path: rust/parquet/src/arrow/arrow_reader.rs
##
@@ -348,30 +348,101 @@ mod tests {
";
let converter = Utf8ArrayConverter {};
-
jeroen commented on a change in pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#discussion_r473347900
##
File path: ci/scripts/r_windows_build.sh
##
@@ -34,6 +34,12 @@ if [ "$RTOOLS_VERSION" = "35" ]; then
# lib-4.9.3 is for libraries compiled with gcc 4.9
kou commented on pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#issuecomment-676706601
Thanks.
Could you replace existing `PYTHON_EXECUTABLE` with `Python3_EXECUTABLE` and
add note that "you need to use `PYTHON_EXECUTABLE` with CMake < 3.15" or
something?
It's bet
andygrove closed pull request #7983:
URL: https://github.com/apache/arrow/pull/7983
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8013:
URL: https://github.com/apache/arrow/pull/8013#issuecomment-676701327
https://issues.apache.org/jira/browse/ARROW-9807
This is an automated message from the Apache Git Serv
kou commented on pull request #8011:
URL: https://github.com/apache/arrow/pull/8011#issuecomment-676697902
How about adding a CI job for s390x + Go on Travis CI as the first step like
https://github.com/apache/arrow/pull/7938 ?
-
nealrichardson opened a new pull request #8013:
URL: https://github.com/apache/arrow/pull/8013
Since the patch release won't get merged to master, we need to bump the R
package dev versions manually. This patch also fills in some NEWS.md bullets
for recently merged improvements.
---
andygrove closed pull request #7989:
URL: https://github.com/apache/arrow/pull/7989
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8012:
URL: https://github.com/apache/arrow/pull/8012#issuecomment-676668482
https://issues.apache.org/jira/browse/ARROW-9806
This is an automated message from the Apache Git Serv
andygrove closed pull request #7993:
URL: https://github.com/apache/arrow/pull/7993
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nealrichardson opened a new pull request #8012:
URL: https://github.com/apache/arrow/pull/8012
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
nealrichardson commented on a change in pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#discussion_r473296153
##
File path: ci/scripts/r_windows_build.sh
##
@@ -34,6 +34,12 @@ if [ "$RTOOLS_VERSION" = "35" ]; then
# lib-4.9.3 is for libraries compiled with
github-actions[bot] commented on pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#issuecomment-676625519
https://issues.apache.org/jira/browse/ARROW-9804
This is an automated message from the Apache Git Serv
github-actions[bot] commented on pull request #8011:
URL: https://github.com/apache/arrow/pull/8011#issuecomment-676625517
https://issues.apache.org/jira/browse/ARROW-9803
This is an automated message from the Apache Git Serv
vivkong opened a new pull request #8011:
URL: https://github.com/apache/arrow/pull/8011
The initial support will allow the unit tests to pass on s390x.
This is an automated message from the Apache Git Service.
To respond to t
nealrichardson commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-676607641
So this is failing because it's trying to build the bundled aws-sdk-cpp
external project, but that's not implemented:
https://travis-ci.org/github/ursa-labs/crossbow/builds
github-actions[bot] commented on pull request #8010:
URL: https://github.com/apache/arrow/pull/8010#issuecomment-676605445
https://issues.apache.org/jira/browse/ARROW-9587
This is an automated message from the Apache Git Serv
jorgecarleitao commented on pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#issuecomment-676603513
Ah, what a peace of mind that this offers me. Having to remember that
Selection is not a `select` was always a challenge!
-
jorgecarleitao commented on a change in pull request #8009:
URL: https://github.com/apache/arrow/pull/8009#discussion_r473249646
##
File path: rust/parquet/src/arrow/arrow_reader.rs
##
@@ -348,30 +348,101 @@ mod tests {
";
let converter = Utf8ArrayConverter
lidavidm opened a new pull request #8010:
URL: https://github.com/apache/arrow/pull/8010
- Fix a bug where writes would hang forever for DoExchange
- Make FlightRuntimeException#toString easier to read
- Have DoPut reliably clean up the FlightStream when the call ends (instead
of pote
jorgecarleitao commented on pull request #7993:
URL: https://github.com/apache/arrow/pull/7993#issuecomment-676593892
Ready to go, then!
-
andygrove closed pull request #8005:
URL: https://github.com/apache/arrow/pull/8005
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nealrichardson commented on a change in pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#discussion_r473152507
##
File path: ci/scripts/r_windows_build.sh
##
@@ -34,6 +34,12 @@ if [ "$RTOOLS_VERSION" = "35" ]; then
# lib-4.9.3 is for libraries compiled with
andygrove commented on pull request #7993:
URL: https://github.com/apache/arrow/pull/7993#issuecomment-676512584
After thinking about this some more, I'm also fine with the current
implementation that returns a DataFrame.
T
jeroen commented on a change in pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#discussion_r473134395
##
File path: ci/scripts/r_windows_build.sh
##
@@ -34,6 +34,12 @@ if [ "$RTOOLS_VERSION" = "35" ]; then
# lib-4.9.3 is for libraries compiled with gcc 4.9
jduo commented on a change in pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#discussion_r473125858
##
File path: format/Flight.proto
##
@@ -124,11 +124,6 @@ message HandshakeRequest {
* A defined protocol version
*/
uint64 protocol_version = 1;
-
alamb commented on a change in pull request #8005:
URL: https://github.com/apache/arrow/pull/8005#discussion_r473118534
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -419,13 +410,50 @@ impl Expr {
}
}
+/// Determine if this expression can produce nu
alamb commented on a change in pull request #8007:
URL: https://github.com/apache/arrow/pull/8007#discussion_r473116005
##
File path: rust/parquet/src/arrow/arrow_reader.rs
##
@@ -304,6 +304,45 @@ mod tests {
>(2, 100, 2, message_type, 15, 50, converter);
}
+
github-actions[bot] commented on pull request #8009:
URL: https://github.com/apache/arrow/pull/8009#issuecomment-676493621
https://issues.apache.org/jira/browse/ARROW-9790
This is an automated message from the Apache Git Serv
alamb commented on a change in pull request #8009:
URL: https://github.com/apache/arrow/pull/8009#discussion_r473111954
##
File path: rust/parquet/src/arrow/arrow_reader.rs
##
@@ -348,30 +348,101 @@ mod tests {
";
let converter = Utf8ArrayConverter {};
-
alamb opened a new pull request #8009:
URL: https://github.com/apache/arrow/pull/8009
I added two test cases in https://github.com/apache/arrow/pull/8007, which
increased coverage. However, upon further review, I noticed the choice of
parameters to hit edge conditions didn't cover the stri
nealrichardson commented on a change in pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#discussion_r473109016
##
File path: ci/scripts/r_windows_build.sh
##
@@ -34,6 +34,12 @@ if [ "$RTOOLS_VERSION" = "35" ]; then
# lib-4.9.3 is for libraries compiled with
github-actions[bot] commented on pull request #8008:
URL: https://github.com/apache/arrow/pull/8008#issuecomment-676477885
https://issues.apache.org/jira/browse/ARROW-9369
This is an automated message from the Apache Git Serv
sunchao commented on pull request #8007:
URL: https://github.com/apache/arrow/pull/8007#issuecomment-676475353
> @sunchao Could you review as well ?
Thanks for pinging! will do today.
This is an automated message from
kszucs opened a new pull request #8008:
URL: https://github.com/apache/arrow/pull/8008
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nealrichardson commented on pull request #7748:
URL: https://github.com/apache/arrow/pull/7748#issuecomment-676467710
@pitrou if you're satisfied, could you please merge?
This is an automated message from the Apache Git Servi
nealrichardson commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r473080054
##
File path: r/src/arrow_cpp11.h
##
@@ -35,8 +36,45 @@ SEXP as_sexp(const std::vector>& vec);
// https://github.com/apache/arrow/pull/7819#di
andygrove commented on a change in pull request #7993:
URL: https://github.com/apache/arrow/pull/7993#discussion_r473075611
##
File path: rust/datafusion/src/dataframe.rs
##
@@ -174,4 +174,18 @@ pub trait DataFrame {
/// Return the logical plan represented by this DataFr
alamb commented on a change in pull request #8007:
URL: https://github.com/apache/arrow/pull/8007#discussion_r473075068
##
File path: rust/parquet/src/arrow/array_reader.rs
##
@@ -1000,6 +998,33 @@ mod tests {
}
}
+#[test]
+fn test_primitive_array_reader
andygrove closed pull request #8006:
URL: https://github.com/apache/arrow/pull/8006
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb edited a comment on pull request #8007:
URL: https://github.com/apache/arrow/pull/8007#issuecomment-676450197
As the code that I removed in this PR added to support empty pages in
8a61570a8bd64ae6f6e47ce8efd2287c3c2feded (but it didn't seem to have any
tests), I was worried that thi
andygrove commented on pull request #8007:
URL: https://github.com/apache/arrow/pull/8007#issuecomment-676450729
@sunchao Could you review as well ?
This is an automated message from the Apache Git Service.
To respond to the
alamb commented on pull request #8007:
URL: https://github.com/apache/arrow/pull/8007#issuecomment-676450197
As the code that I removed in this PR added to support empty pages in
8a61570a8bd64ae6f6e47ce8efd2287c3c2feded (but it didn't seem to have any
tests), I was worried that this delet
romainfrancois commented on pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#issuecomment-676422266
And I can confirm that this works on master locally:
``` r
library(reticulate)
#> Warning: package 'reticulate' was built under R version 4.0.2
library(arrow)
github-actions[bot] commented on pull request #8007:
URL: https://github.com/apache/arrow/pull/8007#issuecomment-676414386
https://issues.apache.org/jira/browse/ARROW-9790
This is an automated message from the Apache Git Serv
alamb commented on a change in pull request #8007:
URL: https://github.com/apache/arrow/pull/8007#discussion_r473045357
##
File path: rust/parquet/src/arrow/array_reader.rs
##
@@ -136,10 +136,8 @@ impl ArrayReader for PrimitiveArrayReader {
while records_read < batch_s
alamb opened a new pull request #8007:
URL: https://github.com/apache/arrow/pull/8007
When I was reading a parquet file into `RecordBatches` using
`ParquetFileArrowReader` that had row groups that were 100,000 rows in length
with a batch size of 60,000, after reading 300,000 rows successfu
github-actions[bot] commented on pull request #8006:
URL: https://github.com/apache/arrow/pull/8006#issuecomment-676385386
https://issues.apache.org/jira/browse/ARROW-9800
This is an automated message from the Apache Git Serv
alamb opened a new pull request #8006:
URL: https://github.com/apache/arrow/pull/8006
Prior to this PR, the following output is printed during local execution of
a test:
```
min: [0] 1
max: [1] 1
min: [0] 1
max: [1] 1
min: [0] 1
max: [1] 1
min: [0] 1
max: [1]
romainfrancois edited a comment on pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#issuecomment-676374381
The error seems to happen on this call:
```r
x$`_export_to_c`(array_ptr, schema_ptr)
```
although there seems to be something there:
```r
romainfrancois commented on pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#issuecomment-676374381
The error seems to happen on this call:
```r
x$`_export_to_c`(array_ptr, schema_ptr)
```
This
romainfrancois commented on pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#issuecomment-676369629
I'm trying to debug what's wrong with the python tests that I previously
silenced in this PR:
That looks fine:
``` r
library(reticulate)
#> Warning: pa
andygrove commented on pull request #8005:
URL: https://github.com/apache/arrow/pull/8005#issuecomment-676364174
also @alamb fyi
This is an automated message from the Apache Git Service.
To respond to the message, please log
andygrove commented on pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#issuecomment-676356936
Thanks @alamb .. filed https://issues.apache.org/jira/browse/ARROW-9799 for
that
This is an automated message
andygrove closed pull request #7998:
URL: https://github.com/apache/arrow/pull/7998
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #7999:
URL: https://github.com/apache/arrow/pull/7999
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8005:
URL: https://github.com/apache/arrow/pull/8005#issuecomment-676322479
https://issues.apache.org/jira/browse/ARROW-9778
This is an automated message from the Apache Git Serv
romainfrancois commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r473009786
##
File path: r/tests/testthat/test-buffer.R
##
@@ -39,6 +39,7 @@ test_that("Buffer can be created from numeric vector", {
})
test_that("Buffer c
andygrove commented on pull request #8005:
URL: https://github.com/apache/arrow/pull/8005#issuecomment-676313018
@jorgecarleitao
This is an automated message from the Apache Git Service.
To respond to the message, please log
andygrove opened a new pull request #8005:
URL: https://github.com/apache/arrow/pull/8005
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb commented on a change in pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#discussion_r473002717
##
File path: rust/datafusion/src/execution/physical_plan/expressions.rs
##
@@ -966,11 +966,32 @@ impl fmt::Display for BinaryExpr {
impl PhysicalExpr for
alamb commented on pull request #7993:
URL: https://github.com/apache/arrow/pull/7993#issuecomment-676295725
That makes sense to me
On Tue, Aug 18, 2020 at 11:24 PM Jorge Leitao
wrote:
> *@jorgecarleitao* commented on this pull request.
> --
lidavidm commented on a change in pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#discussion_r472995325
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightClient.java
##
@@ -84,18 +81,15 @@
* Create a Flight client from an
romainfrancois commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r472991503
##
File path: r/src/array_from_vector.cpp
##
@@ -1064,42 +1062,42 @@ class FixedSizeBinaryVectorConverter : public
VectorConverter {
FixedSizeBin
andygrove closed pull request #8000:
URL: https://github.com/apache/arrow/pull/8000
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8004:
URL: https://github.com/apache/arrow/pull/8004#issuecomment-676130148
https://issues.apache.org/jira/browse/ARROW-8773
This is an automated message from the Apache Git Serv
kszucs opened a new pull request #8004:
URL: https://github.com/apache/arrow/pull/8004
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r472905861
##
File path: cpp/src/arrow/array/util.cc
##
@@ -74,6 +74,177 @@ class ArrayDataWrapper {
std::shared_ptr* out_;
};
+class ArrayDataEndianSwapper {
+ pu
kszucs commented on pull request #7986:
URL: https://github.com/apache/arrow/pull/7986#issuecomment-676051841
I've [bumbed](https://github.com/conda-forge/valgrind-feedstock/pull/11) the
valgrind version in the conda forge feedstock, perhaps that will help.
---
liyafan82 commented on pull request #7748:
URL: https://github.com/apache/arrow/pull/7748#issuecomment-676031385
After more experiments, I find @bkietz is right, as the test case crashed on
AMD64 Ubuntu 18.04 when dividing by floating point 0.
So I have accepted his suggestions (Thank yo
pitrou closed pull request #7981:
URL: https://github.com/apache/arrow/pull/7981
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou commented on pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#issuecomment-675987912
cc @lidavidm
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on pull request #8003:
URL: https://github.com/apache/arrow/pull/8003#issuecomment-675943838
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
PoojaChandak opened a new pull request #8003:
URL: https://github.com/apache/arrow/pull/8003
Observed a few changes. Suggesting the same. Kindly check.
This is an automated message from the Apache Git Service.
To respond to t
jeroen commented on a change in pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#discussion_r472849717
##
File path: ci/scripts/r_windows_build.sh
##
@@ -34,6 +34,12 @@ if [ "$RTOOLS_VERSION" = "35" ]; then
# lib-4.9.3 is for libraries compiled with gcc 4.9
liyafan82 commented on a change in pull request #7748:
URL: https://github.com/apache/arrow/pull/7748#discussion_r472827547
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##
@@ -492,6 +486,81 @@ TYPED_TEST(TestBinaryArithmeticFloating, Add) {
this->Ass
pitrou commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-675906606
@nealrichardson
This is an automated message from the Apache Git Service.
To respond to the message, please lo
romainfrancois commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r472790386
##
File path: r/tests/testthat/test-buffer.R
##
@@ -39,6 +39,7 @@ test_that("Buffer can be created from numeric vector", {
})
test_that("Buffer c
89 matches
Mail list logo
