emkornfield commented on pull request #8130:
URL: https://github.com/apache/arrow/pull/8130#issuecomment-69459
I don't think we should support this unless we can get consensus on
dev@parquet mailing list that we want to support this across java and C++ (if
java already supports it a po
emkornfield commented on pull request #8052:
URL: https://github.com/apache/arrow/pull/8052#issuecomment-689996230
> Rebased. Does someone want to review the doc at
https://pitrou.net/arrowdevdoc/format/CStreamInterface.html ?
I took a quick look and seemed reasonable (nothing jumped
github-actions[bot] commented on pull request #8156:
URL: https://github.com/apache/arrow/pull/8156#issuecomment-689994855
https://issues.apache.org/jira/browse/ARROW-9810
This is an automated message from the Apache Git Serv
emkornfield opened a new pull request #8156:
URL: https://github.com/apache/arrow/pull/8156
This adds helper methods for reconstructing all necessary metadata
for arrow types. For now this doesn't handle null_slot_usage (i.e.
children of FixedSizeList), it throws exceptions when nulls
emkornfield commented on a change in pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#discussion_r486028649
##
File path: cpp/src/arrow/array/builder_base.h
##
@@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder {
virtual Status AppendNull() = 0;
virtual S
tianchen92 commented on pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#issuecomment-689938956
@pitrou Thanks for your patch and careful review, I updated PR according to
the comments above.
@emkornfield doesn't matter :), pitrou helped disabled the failed test and
no
emkornfield commented on pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#issuecomment-689935755
@tianchen92 sorry I missed the tag. Is it possible the failure could be
related to https://issues.apache.org/jira/browse/ARROW-9603?filter=-2
---
andygrove closed pull request #8135:
URL: https://github.com/apache/arrow/pull/8135
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #8142:
URL: https://github.com/apache/arrow/pull/8142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on pull request #8142:
URL: https://github.com/apache/arrow/pull/8142#issuecomment-689861246
@andygrove -- I have rebased this PR and I believe I have implemented all
suggestions. There is one more lingering thing regarding parsing local
timestamps that I want to check out
nealrichardson closed pull request #8154:
URL: https://github.com/apache/arrow/pull/8154
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
nealrichardson closed pull request #8012:
URL: https://github.com/apache/arrow/pull/8012
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
alamb commented on a change in pull request #8142:
URL: https://github.com/apache/arrow/pull/8142#discussion_r485950446
##
File path: rust/datafusion/src/physical_plan/datetime_expressions.rs
##
@@ -0,0 +1,225 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+/
alamb commented on a change in pull request #8142:
URL: https://github.com/apache/arrow/pull/8142#discussion_r485935565
##
File path: rust/datafusion/src/physical_plan/datetime_expressions.rs
##
@@ -0,0 +1,225 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+/
github-actions[bot] commented on pull request #8155:
URL: https://github.com/apache/arrow/pull/8155#issuecomment-689833250
https://issues.apache.org/jira/browse/ARROW-9954
This is an automated message from the Apache Git Serv
jorgecarleitao opened a new pull request #8155:
URL: https://github.com/apache/arrow/pull/8155
This commit makes the creation of aggregate expressions similar to the
creation of built-in expressions.
This allows to share coercion rules and signatures between scalar and
aggregate fun
nealrichardson commented on a change in pull request #8150:
URL: https://github.com/apache/arrow/pull/8150#discussion_r485914346
##
File path: r/R/table.R
##
@@ -185,6 +185,36 @@ Table <- R6Class("Table", inherit = ArrowObject,
)
)
+bad_attributes <- function(x) {
+ UseM
eerhardt commented on a change in pull request #8146:
URL: https://github.com/apache/arrow/pull/8146#discussion_r485898496
##
File path: csharp/src/Apache.Arrow/Ipc/ArrowStreamWriter.cs
##
@@ -212,6 +212,96 @@ private void CountSelfAndChildrenNodes(IArrowType type,
ref int cou
MingyuZhong commented on a change in pull request #8143:
URL: https://github.com/apache/arrow/pull/8143#discussion_r485907213
##
File path: cpp/src/arrow/util/decimal.cc
##
@@ -42,34 +45,40 @@ namespace arrow {
using internal::SafeLeftShift;
using internal::SafeSignedAdd;
+
github-actions[bot] commented on pull request #8154:
URL: https://github.com/apache/arrow/pull/8154#issuecomment-689801423
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
nealrichardson commented on pull request #8154:
URL: https://github.com/apache/arrow/pull/8154#issuecomment-689800447
@github-actions crossbow submit homebrew-r-autobrew
This is an automated message from the Apache Git Servic
nealrichardson opened a new pull request #8154:
URL: https://github.com/apache/arrow/pull/8154
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
nealrichardson closed pull request #8152:
URL: https://github.com/apache/arrow/pull/8152
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
pitrou commented on a change in pull request #8143:
URL: https://github.com/apache/arrow/pull/8143#discussion_r485888089
##
File path: cpp/src/arrow/util/decimal.cc
##
@@ -42,34 +45,40 @@ namespace arrow {
using internal::SafeLeftShift;
using internal::SafeSignedAdd;
+#ifde
MingyuZhong commented on a change in pull request #8143:
URL: https://github.com/apache/arrow/pull/8143#discussion_r485885307
##
File path: cpp/src/arrow/util/decimal.cc
##
@@ -42,34 +45,40 @@ namespace arrow {
using internal::SafeLeftShift;
using internal::SafeSignedAdd;
+
github-actions[bot] commented on pull request #8153:
URL: https://github.com/apache/arrow/pull/8153#issuecomment-689747629
https://issues.apache.org/jira/browse/ARROW-9616
This is an automated message from the Apache Git Serv
nealrichardson opened a new pull request #8153:
URL: https://github.com/apache/arrow/pull/8153
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
kiszk commented on a change in pull request #8147:
URL: https://github.com/apache/arrow/pull/8147#discussion_r485785372
##
File path: java/vector/src/main/java/org/apache/arrow/vector/IntVector.java
##
@@ -164,7 +165,9 @@ private void setValue(int index, int value) {
* @par
kiszk commented on a change in pull request #8147:
URL: https://github.com/apache/arrow/pull/8147#discussion_r485785372
##
File path: java/vector/src/main/java/org/apache/arrow/vector/IntVector.java
##
@@ -164,7 +165,9 @@ private void setValue(int index, int value) {
* @par
github-actions[bot] commented on pull request #8152:
URL: https://github.com/apache/arrow/pull/8152#issuecomment-689697572
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
OfekShilon opened a new pull request #8152:
URL: https://github.com/apache/arrow/pull/8152
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
elferherrera commented on pull request #8129:
URL: https://github.com/apache/arrow/pull/8129#issuecomment-689647404
I wasn't aware of tch-rs. I will have a look at it and how it creates the
torch tensors. Thanks for the info.
Regarding the features, I was planning to implement the fm
github-actions[bot] commented on pull request #8146:
URL: https://github.com/apache/arrow/pull/8146#issuecomment-689623840
https://issues.apache.org/jira/browse/ARROW-5034
This is an automated message from the Apache Git Serv
github-actions[bot] commented on pull request #8148:
URL: https://github.com/apache/arrow/pull/8148#issuecomment-689586337
https://issues.apache.org/jira/browse/ARROW-9104
This is an automated message from the Apache Git Serv
github-actions[bot] commented on pull request #8127:
URL: https://github.com/apache/arrow/pull/8127#issuecomment-689579549
Revision: 8c58d24820a44204095711f42748f304b7de65ad
Submitted crossbow builds: [ursa-labs/crossbow @
actions-522](https://github.com/ursa-labs/crossbow/branches/a
xhochy commented on pull request #8127:
URL: https://github.com/apache/arrow/pull/8127#issuecomment-689578161
@github-actions crossbow submit conda-linux-gcc-py36-aarch64
This is an automated message from the Apache G
pitrou commented on pull request #8052:
URL: https://github.com/apache/arrow/pull/8052#issuecomment-689575836
Rebased. Does someone want to review the doc at
https://pitrou.net/arrowdevdoc/format/CStreamInterface.html ?
This
pitrou commented on pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#issuecomment-689569522
@tianchen92 The Parquet failure is probably a bug in the nested Parquet
reader. I've pushed changes to your branch, be careful to pick them up.
---
pitrou commented on a change in pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#discussion_r485588382
##
File path: cpp/src/arrow/array/builder_dict.h
##
@@ -233,6 +233,20 @@ class DictionaryBuilderBase : public ArrayBuilder {
return indices_builder_.App
github-actions[bot] commented on pull request #8127:
URL: https://github.com/apache/arrow/pull/8127#issuecomment-689559291
Revision: 9b3e31bda2608d364ad1dde2bcf4ab12dfe23885
Submitted crossbow builds: [ursa-labs/crossbow @
actions-521](https://github.com/ursa-labs/crossbow/branches/a
xhochy commented on pull request #8127:
URL: https://github.com/apache/arrow/pull/8127#issuecomment-689557890
@github-actions crossbow submit conda-linux-gcc-py36-aarch64
This is an automated message from the Apache G
github-actions[bot] commented on pull request #8151:
URL: https://github.com/apache/arrow/pull/8151#issuecomment-689540884
https://issues.apache.org/jira/browse/ARROW-9279
This is an automated message from the Apache Git Serv
pitrou closed pull request #8131:
URL: https://github.com/apache/arrow/pull/8131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tianchen92 opened a new pull request #8151:
URL: https://github.com/apache/arrow/pull/8151
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pitrou commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r485575668
##
File path: cpp/src/parquet/kms_client_factory.h
##
@@ -0,0 +1,42 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
github-actions[bot] commented on pull request #8150:
URL: https://github.com/apache/arrow/pull/8150#issuecomment-689530988
https://issues.apache.org/jira/browse/ARROW-9271
This is an automated message from the Apache Git Serv
romainfrancois opened a new pull request #8150:
URL: https://github.com/apache/arrow/pull/8150
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
pitrou commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r485569777
##
File path: cpp/src/parquet/key_toolkit.h
##
@@ -0,0 +1,123 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licen
ggershinsky commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r485567679
##
File path: cpp/src/parquet/properties_driven_crypto_factory.cc
##
@@ -0,0 +1,278 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+/
pitrou commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r485558482
##
File path: cpp/src/parquet/key_toolkit.h
##
@@ -0,0 +1,123 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licen
pitrou commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r485557938
##
File path: cpp/src/parquet/key_toolkit.h
##
@@ -0,0 +1,123 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licen
pitrou commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r485557493
##
File path: cpp/src/parquet/key_toolkit.h
##
@@ -0,0 +1,123 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licen
pitrou commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r485556981
##
File path: cpp/src/parquet/key_toolkit.h
##
@@ -0,0 +1,123 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licen
ggershinsky commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r485535843
##
File path: cpp/src/parquet/key_toolkit.h
##
@@ -0,0 +1,123 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
pereverges closed issue #8140:
URL: https://github.com/apache/arrow/issues/8140
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ggershinsky commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r485510128
##
File path: cpp/src/parquet/properties_driven_crypto_factory.h
##
@@ -0,0 +1,207 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+//
xhochy commented on pull request #8127:
URL: https://github.com/apache/arrow/pull/8127#issuecomment-689468483
Needs `pygit2` on `aarch64` for the package upload, requested here:
https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/761
-
pitrou closed pull request #8141:
URL: https://github.com/apache/arrow/pull/8141
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on pull request #8127:
URL: https://github.com/apache/arrow/pull/8127#issuecomment-689455537
Revision: 9b3e31bda2608d364ad1dde2bcf4ab12dfe23885
Submitted crossbow builds: [ursa-labs/crossbow @
actions-520](https://github.com/ursa-labs/crossbow/branches/a
alamb commented on pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#issuecomment-689455228
🎉 Hooray!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
xhochy commented on pull request #8127:
URL: https://github.com/apache/arrow/pull/8127#issuecomment-689454442
@github-actions crossbow submit conda-linux-gcc-py36-aarch64
This is an automated message from the Apache G
github-actions[bot] commented on pull request #8149:
URL: https://github.com/apache/arrow/pull/8149#issuecomment-689442469
https://issues.apache.org/jira/browse/ARROW-9645
This is an automated message from the Apache Git Serv
jhorstmann commented on a change in pull request #8142:
URL: https://github.com/apache/arrow/pull/8142#discussion_r485468664
##
File path: rust/datafusion/src/physical_plan/datetime_expressions.rs
##
@@ -0,0 +1,225 @@
+// Licensed to the Apache Software Foundation (ASF) under o
jorisvandenbossche opened a new pull request #8149:
URL: https://github.com/apache/arrow/pull/8149
WIP, still need to deprecate hdfs as well
This is an automated message from the Apache Git Service.
To respond to the message,
pitrou commented on a change in pull request #8143:
URL: https://github.com/apache/arrow/pull/8143#discussion_r485460964
##
File path: cpp/src/arrow/util/decimal.cc
##
@@ -42,34 +45,40 @@ namespace arrow {
using internal::SafeLeftShift;
using internal::SafeSignedAdd;
+#ifde
pitrou commented on a change in pull request #8143:
URL: https://github.com/apache/arrow/pull/8143#discussion_r485460551
##
File path: cpp/src/arrow/util/decimal.cc
##
@@ -42,34 +45,40 @@ namespace arrow {
using internal::SafeLeftShift;
using internal::SafeSignedAdd;
+#ifde
pitrou commented on pull request #8143:
URL: https://github.com/apache/arrow/pull/8143#issuecomment-689434791
Be careful: it seems you updated the `testing` submodule.
This is an automated message from the Apache Git Service.
pitrou commented on a change in pull request #8148:
URL: https://github.com/apache/arrow/pull/8148#discussion_r485435374
##
File path: cpp/src/parquet/test_encryption_util.h
##
@@ -57,6 +57,7 @@ const char kFooterEncryptionKey[] = "0123456789012345"; //
128bit/16
const char
pitrou commented on pull request #8139:
URL: https://github.com/apache/arrow/pull/8139#issuecomment-689413221
> you should either pass a URI ("s3://...) and no filesystem, or either a
filesystem object with a "normal" path (without scheme prefix), but never the
combo of filesystem object Ã
github-actions[bot] commented on pull request #8148:
URL: https://github.com/apache/arrow/pull/8148#issuecomment-689410400
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
revit13 opened a new pull request #8148:
URL: https://github.com/apache/arrow/pull/8148
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jorisvandenbossche closed pull request #8139:
URL: https://github.com/apache/arrow/pull/8139
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jorisvandenbossche commented on pull request #8139:
URL: https://github.com/apache/arrow/pull/8139#issuecomment-689380287
Failures are brew installation failures, so ignoring those
This is an automated message from the Apache
github-actions[bot] commented on pull request #8147:
URL: https://github.com/apache/arrow/pull/8147#issuecomment-689362095
https://issues.apache.org/jira/browse/ARROW-9680
This is an automated message from the Apache Git Serv
liyafan82 commented on pull request #8147:
URL: https://github.com/apache/arrow/pull/8147#issuecomment-689356664
In the first commit of this PR, we only support IntVector.
This is an automated message from the Apache Git Serv
liyafan82 opened a new pull request #8147:
URL: https://github.com/apache/arrow/pull/8147
This issue was first discussed in the ML
(https://lists.apache.org/thread.html/r480387ec9ec822f3ed30e9131109e43874a1c4d18af74ede1a7e41c5%40%3Cdev.arrow.apache.org%3E),
from which we have received some
76 matches
Mail list logo
