[GitHub] [arrow] kou closed pull request #8350: ARROW-10179: [Rust] Fixed error in labeler

2020-10-05 Thread GitBox
kou closed pull request #8350: URL: https://github.com/apache/arrow/pull/8350 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler

2020-10-05 Thread GitBox
jorgecarleitao commented on a change in pull request #8350: URL: https://github.com/apache/arrow/pull/8350#discussion_r500038618 ## File path: .github/workflows/dev_labeler/labeler.yml ## @@ -16,7 +16,7 @@ # under the License. rust-lang: Review comment: I am now rea

[GitHub] [arrow] Luminarys commented on pull request #8344: Add BasicDecimal256 Multiplication Support (PR for decimal256 branch, not master)

2020-10-05 Thread GitBox
Luminarys commented on pull request #8344: URL: https://github.com/apache/arrow/pull/8344#issuecomment-704062865 I'll take a closer look tommorow, but we should also wait for feedback from @MingyuZhong before proceeding. Thi

[GitHub] [arrow] kou commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler

2020-10-05 Thread GitBox
kou commented on a change in pull request #8350: URL: https://github.com/apache/arrow/pull/8350#discussion_r500022517 ## File path: .github/workflows/dev_labeler/labeler.yml ## @@ -16,7 +16,7 @@ # under the License. rust-lang: Review comment: We use `lang-rust` not

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler

2020-10-05 Thread GitBox
jorgecarleitao commented on a change in pull request #8350: URL: https://github.com/apache/arrow/pull/8350#discussion_r500016659 ## File path: .github/workflows/dev_labeler/labeler.yml ## @@ -16,7 +16,9 @@ # under the License. rust-lang: -- any: ['rust/*'] + - rust/* Revi

[GitHub] [arrow] github-actions[bot] commented on pull request #8357: ARROW-10189: [C] Fixed typo in C-Data interface example

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8357: URL: https://github.com/apache/arrow/pull/8357#issuecomment-704034969 https://issues.apache.org/jira/browse/ARROW-10189 This is an automated message from the Apache Git Ser

[GitHub] [arrow] kou commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler

2020-10-05 Thread GitBox
kou commented on a change in pull request #8350: URL: https://github.com/apache/arrow/pull/8350#discussion_r500011422 ## File path: .github/workflows/dev_labeler/labeler.yml ## @@ -16,7 +16,9 @@ # under the License. rust-lang: -- any: ['rust/*'] + - rust/* Review comment:

[GitHub] [arrow] jorgecarleitao opened a new pull request #8357: ARROW-10189: [C] Fixed typo in C-Data interface example

2020-10-05 Thread GitBox
jorgecarleitao opened a new pull request #8357: URL: https://github.com/apache/arrow/pull/8357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] github-actions[bot] commented on pull request #8356: ARROW-10139: [C++] Add support for building arrow_testing without building tests

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8356: URL: https://github.com/apache/arrow/pull/8356#issuecomment-704029648 https://issues.apache.org/jira/browse/ARROW-10139 This is an automated message from the Apache Git Ser

[GitHub] [arrow] kou opened a new pull request #8356: ARROW-10139: [C++] Add support for building arrow_testing without building tests

2020-10-05 Thread GitBox
kou opened a new pull request #8356: URL: https://github.com/apache/arrow/pull/8356 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] emkornfield commented on pull request #8344: Add BasicDecimal256 Multiplication Support (PR for decimal256 branch, not master)

2020-10-05 Thread GitBox
emkornfield commented on pull request #8344: URL: https://github.com/apache/arrow/pull/8344#issuecomment-704025011 @Luminarys have you looked at the CI errors (I think there might be a few flaky things going on but wanted to check that you were ok merging)? ---

[GitHub] [arrow] github-actions[bot] commented on pull request #8355: ARROW-10188: [Rust] [DataFusion] Fixed DataFusion examples.

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8355: URL: https://github.com/apache/arrow/pull/8355#issuecomment-704014922 https://issues.apache.org/jira/browse/ARROW-10188 This is an automated message from the Apache Git Ser

[GitHub] [arrow] jorgecarleitao closed pull request #8296: ARROW-10041: [Rust] Added check of data type to GenericString::from.

2020-10-05 Thread GitBox
jorgecarleitao closed pull request #8296: URL: https://github.com/apache/arrow/pull/8296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] jorgecarleitao opened a new pull request #8355: ARROW-10188: [Rust] [DataFusion] Fixed DataFusion examples.

2020-10-05 Thread GitBox
jorgecarleitao opened a new pull request #8355: URL: https://github.com/apache/arrow/pull/8355 Also renamed an example, that reffered to the old name "table_api". This is an automated message from the Apache Git Service. To r

[GitHub] [arrow] jorgecarleitao commented on pull request #8333: ARROW-10167: [Rust] [DataFusion] Support DictionaryArray in sql.rs tests, by using standard pretty printer

2020-10-05 Thread GitBox
jorgecarleitao commented on pull request #8333: URL: https://github.com/apache/arrow/pull/8333#issuecomment-704006086 @alamb we need a small rebase to merge. This is an automated message from the Apache Git Service. To respon

[GitHub] [arrow] jorgecarleitao closed pull request #8334: ARROW-8205: [Rust] [DataFusion] Added check to uniqueness of column names.

2020-10-05 Thread GitBox
jorgecarleitao closed pull request #8334: URL: https://github.com/apache/arrow/pull/8334 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler

2020-10-05 Thread GitBox
jorgecarleitao commented on a change in pull request #8350: URL: https://github.com/apache/arrow/pull/8350#discussion_r499979599 ## File path: .github/workflows/dev_labeler/labeler.yml ## @@ -16,7 +16,9 @@ # under the License. rust-lang: -- any: ['rust/*'] + - rust/* Revi

[GitHub] [arrow] github-actions[bot] commented on pull request #8354: [Rust] [Parquet] Schema roundtrip - use Arrow schema from Parquet metadata when available

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8354: URL: https://github.com/apache/arrow/pull/8354#issuecomment-703985294 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] carols10cents opened a new pull request #8354: [Rust] [Parquet] Schema roundtrip - use Arrow schema from Parquet metadata when available

2020-10-05 Thread GitBox
carols10cents opened a new pull request #8354: URL: https://github.com/apache/arrow/pull/8354 @nevi-me This is one commit on top of https://github.com/apache/arrow/pull/8330 that I'm opening to get some feedback from you on about whether this will help with ARROW-10168. I *think* this will

[GitHub] [arrow] kou commented on a change in pull request #8315: ARROW-9266: [Python][Packaging] Enable S3 support in macOS wheels

2020-10-05 Thread GitBox
kou commented on a change in pull request #8315: URL: https://github.com/apache/arrow/pull/8315#discussion_r499956145 ## File path: dev/tasks/python-wheels/osx-build.sh ## @@ -67,6 +67,7 @@ function build_wheel { -DARROW_GANDIVA=OFF \ -DARROW_GRPC_USE_SHAR

[GitHub] [arrow] github-actions[bot] commented on pull request #8353: ARROW-10181: [Rust] Skip compiling one test on 32 bit ARM architecture

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8353: URL: https://github.com/apache/arrow/pull/8353#issuecomment-703970908 https://issues.apache.org/jira/browse/ARROW-10181 This is an automated message from the Apache Git Ser

[GitHub] [arrow] andygrove opened a new pull request #8353: ARROW-10181: [Rust] Skip compiling one test on 32 bit ARM architecture

2020-10-05 Thread GitBox
andygrove opened a new pull request #8353: URL: https://github.com/apache/arrow/pull/8353 This PR allows the tests to be compiled on 32-bit ARM (e.g. Raspberry Pi). This is an automated message from the Apache Git Service. To

[GitHub] [arrow] pgovind commented on a change in pull request #8348: ARROW-6972: [C#] Support for StructArrays

2020-10-05 Thread GitBox
pgovind commented on a change in pull request #8348: URL: https://github.com/apache/arrow/pull/8348#discussion_r499948831 ## File path: csharp/src/Apache.Arrow/Ipc/MessageSerializer.cs ## @@ -57,16 +58,30 @@ internal static Schema GetSchema(Flatbuf.Schema schema) f

[GitHub] [arrow] eerhardt commented on a change in pull request #8348: ARROW-6972: [C#] Support for StructArrays

2020-10-05 Thread GitBox
eerhardt commented on a change in pull request #8348: URL: https://github.com/apache/arrow/pull/8348#discussion_r499947637 ## File path: csharp/src/Apache.Arrow/Ipc/MessageSerializer.cs ## @@ -57,16 +58,30 @@ internal static Schema GetSchema(Flatbuf.Schema schema)

[GitHub] [arrow] nevi-me commented on pull request #8330: [Rust] [Parquet] Add roundtrip Arrow -> Parquet tests for all supported Arrow DataTypes

2020-10-05 Thread GitBox
nevi-me commented on pull request #8330: URL: https://github.com/apache/arrow/pull/8330#issuecomment-703962361 > @nevi-me I went ahead and merged in [your PR](https://github.com/integer32llc/arrow/pull/1), rebased this PR's branch on rust-parquet-arrow-writer, added one commit to explicitl

[GitHub] [arrow] pgovind commented on a change in pull request #8348: ARROW-6972: [C#] Support for StructArrays

2020-10-05 Thread GitBox
pgovind commented on a change in pull request #8348: URL: https://github.com/apache/arrow/pull/8348#discussion_r499927750 ## File path: csharp/src/Apache.Arrow/Ipc/MessageSerializer.cs ## @@ -57,16 +58,30 @@ internal static Schema GetSchema(Flatbuf.Schema schema) f

[GitHub] [arrow] pgovind commented on a change in pull request #8348: ARROW-6972: [C#] Support for StructArrays

2020-10-05 Thread GitBox
pgovind commented on a change in pull request #8348: URL: https://github.com/apache/arrow/pull/8348#discussion_r499936611 ## File path: csharp/test/Apache.Arrow.Tests/StructArrayTests.cs ## @@ -0,0 +1,86 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [arrow] pgovind commented on a change in pull request #8348: ARROW-6972: [C#] Support for StructArrays

2020-10-05 Thread GitBox
pgovind commented on a change in pull request #8348: URL: https://github.com/apache/arrow/pull/8348#discussion_r499936190 ## File path: csharp/src/Apache.Arrow/Types/StructType.cs ## @@ -28,7 +28,7 @@ public sealed class StructType : ArrowType public IEnumerable Fiel

[GitHub] [arrow] kou commented on a change in pull request #8350: ARROW-10179: [Rust] Fixed error in labeler

2020-10-05 Thread GitBox
kou commented on a change in pull request #8350: URL: https://github.com/apache/arrow/pull/8350#discussion_r499934569 ## File path: .github/workflows/dev_labeler/labeler.yml ## @@ -16,7 +16,9 @@ # under the License. rust-lang: -- any: ['rust/*'] + - rust/* Review comment:

[GitHub] [arrow] pgovind commented on a change in pull request #8348: ARROW-6972: [C#] C# support for StructArrays

2020-10-05 Thread GitBox
pgovind commented on a change in pull request #8348: URL: https://github.com/apache/arrow/pull/8348#discussion_r499927750 ## File path: csharp/src/Apache.Arrow/Ipc/MessageSerializer.cs ## @@ -57,16 +58,30 @@ internal static Schema GetSchema(Flatbuf.Schema schema) f

[GitHub] [arrow] pgovind commented on a change in pull request #8348: ARROW-6972: [C#] C# support for StructArrays

2020-10-05 Thread GitBox
pgovind commented on a change in pull request #8348: URL: https://github.com/apache/arrow/pull/8348#discussion_r499925085 ## File path: csharp/src/Apache.Arrow/Arrays/StructArray.cs ## @@ -21,13 +21,13 @@ namespace Apache.Arrow { public class StructArray : Array { -

[GitHub] [arrow] BryanCutler commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build

2020-10-05 Thread GitBox
BryanCutler commented on pull request #8352: URL: https://github.com/apache/arrow/pull/8352#issuecomment-703941527 I think we might have to add a patch to fix that nested timezone problem from earlier in #7804 , but lets see how the integration run goes ---

[GitHub] [arrow] ursabot commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build

2020-10-05 Thread GitBox
ursabot commented on pull request #8352: URL: https://github.com/apache/arrow/pull/8352#issuecomment-703941186 [AMD64 Conda Crossbow Submit (#131023)](https://ci.ursalabs.org/#builders/98/builds/655) builder has been succeeded. Revision: 7c62c5b6daec1d35f0f75bac56163323e8559596

[GitHub] [arrow] BryanCutler commented on pull request #7804: [WIP][CI] Add patch for Spark integration to handle pyarrow struct arrays with tz timestamps

2020-10-05 Thread GitBox
BryanCutler commented on pull request #7804: URL: https://github.com/apache/arrow/pull/7804#issuecomment-703941258 I think we might have to add a patch to fix that nested timezone problem from earlier, but lets see how the integration run goes -

[GitHub] [arrow] BryanCutler removed a comment on pull request #7804: [WIP][CI] Add patch for Spark integration to handle pyarrow struct arrays with tz timestamps

2020-10-05 Thread GitBox
BryanCutler removed a comment on pull request #7804: URL: https://github.com/apache/arrow/pull/7804#issuecomment-703941258 I think we might have to add a patch to fix that nested timezone problem from earlier, but lets see how the integration run goes -

[GitHub] [arrow] github-actions[bot] commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8352: URL: https://github.com/apache/arrow/pull/8352#issuecomment-703940839 https://issues.apache.org/jira/browse/ARROW-10178 This is an automated message from the Apache Git Ser

[GitHub] [arrow] BryanCutler commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build

2020-10-05 Thread GitBox
BryanCutler commented on pull request #8352: URL: https://github.com/apache/arrow/pull/8352#issuecomment-703940620 @ursabot crossbow submit test-conda-python-3.8-spark-master This is an automated message from the Apache Git S

[GitHub] [arrow] BryanCutler opened a new pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build

2020-10-05 Thread GitBox
BryanCutler opened a new pull request #8352: URL: https://github.com/apache/arrow/pull/8352 Spark master branch has been updated for Arrow 1.0.1, the patch to fix Java compilation can be removed. This is an automated message

[GitHub] [arrow] github-actions[bot] commented on pull request #8351: ARROW-9870: [R] Friendly interface for filesystems (S3)

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8351: URL: https://github.com/apache/arrow/pull/8351#issuecomment-703929272 https://issues.apache.org/jira/browse/ARROW-9870 This is an automated message from the Apache Git Serv

[GitHub] [arrow] nealrichardson opened a new pull request #8351: ARROW-9870: [R] Friendly interface for filesystems (S3)

2020-10-05 Thread GitBox
nealrichardson opened a new pull request #8351: URL: https://github.com/apache/arrow/pull/8351 Goals: * Make it easy to copy/move files from one fs to another (e.g. copy from/to S3) * Simplify the ability to use a FileSystem + path to point to a file(s), without having to carry a

[GitHub] [arrow] eerhardt commented on a change in pull request #8348: ARROW-6972: [C#] C# support for StructArrays

2020-10-05 Thread GitBox
eerhardt commented on a change in pull request #8348: URL: https://github.com/apache/arrow/pull/8348#discussion_r499882330 ## File path: csharp/test/Apache.Arrow.Tests/ArrayBuilderTests.cs ## @@ -73,7 +73,6 @@ public void StringArrayBuilderHandlesNullsAndEmptyStrings()

[GitHub] [arrow] wesm closed pull request #8314: ARROW-10147: [Python] Pandas metadata fails if index name not JSON-serializable

2020-10-05 Thread GitBox
wesm closed pull request #8314: URL: https://github.com/apache/arrow/pull/8314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] github-actions[bot] commented on pull request #8315: ARROW-9266: [Python][Packaging] Enable S3 support in macOS wheels

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8315: URL: https://github.com/apache/arrow/pull/8315#issuecomment-703916845 Revision: 16a9f0916e8a9c5e10e0f66a086ad54c84676d34 Submitted crossbow builds: [ursa-labs/crossbow @ actions-604](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] kszucs commented on pull request #8315: ARROW-9266: [Python][Packaging] Enable S3 support in macOS wheels

2020-10-05 Thread GitBox
kszucs commented on pull request #8315: URL: https://github.com/apache/arrow/pull/8315#issuecomment-703916030 @github-actions crossbow submit wheel-osx-* This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] nealrichardson commented on pull request #8315: ARROW-9266: [Python][Packaging] Enable S3 support in macOS wheels

2020-10-05 Thread GitBox
nealrichardson commented on pull request #8315: URL: https://github.com/apache/arrow/pull/8315#issuecomment-703914601 @kszucs please rebase This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] nealrichardson closed pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-10-05 Thread GitBox
nealrichardson closed pull request #8304: URL: https://github.com/apache/arrow/pull/8304 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-10-05 Thread GitBox
nealrichardson commented on pull request #8304: URL: https://github.com/apache/arrow/pull/8304#issuecomment-703905964 https://issues.apache.org/jira/browse/ARROW-10180 for the docs This is an automated message from the Apache

[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-10-05 Thread GitBox
nealrichardson commented on pull request #8304: URL: https://github.com/apache/arrow/pull/8304#issuecomment-703903846 > (I think that updating the documentation can be worked as a follow-up task.) Ok. I'll make a followup JIRA and merge this. Thanks again! -

[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-10-05 Thread GitBox
kou commented on pull request #8304: URL: https://github.com/apache/arrow/pull/8304#issuecomment-703902680 Thanks! We have https://arrow.apache.org/docs/developers/cpp/building.html#build-dependency-management for C++. (I think that updating the documentation can be worked as a f

[GitHub] [arrow] Luminarys commented on pull request #8344: Add BasicDecimal256 Multiplication Support (PR for decimal256 branch, not master)

2020-10-05 Thread GitBox
Luminarys commented on pull request #8344: URL: https://github.com/apache/arrow/pull/8344#issuecomment-703890063 Added benchmark, multiplication takes ~21ns. This is an automated message from the Apache Git Service. To respon

[GitHub] [arrow] pitrou commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

2020-10-05 Thread GitBox
pitrou commented on a change in pull request #8305: URL: https://github.com/apache/arrow/pull/8305#discussion_r499861786 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -143,97 +150,235 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl( return MakeVectorIterator

[GitHub] [arrow] pitrou commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

2020-10-05 Thread GitBox
pitrou commented on a change in pull request #8305: URL: https://github.com/apache/arrow/pull/8305#discussion_r499860771 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -143,97 +150,235 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl( return MakeVectorIterator

[GitHub] [arrow] bkietz commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

2020-10-05 Thread GitBox
bkietz commented on a change in pull request #8305: URL: https://github.com/apache/arrow/pull/8305#discussion_r499859844 ## File path: python/pyarrow/dataset.py ## @@ -694,22 +697,23 @@ def _ensure_write_partitioning(scheme): return scheme -def write_dataset(data, base

[GitHub] [arrow] bkietz commented on pull request #8317: ARROW-10134: [Python][Dataset] Add ParquetFileFragment.num_row_groups

2020-10-05 Thread GitBox
bkietz commented on pull request #8317: URL: https://github.com/apache/arrow/pull/8317#issuecomment-703876867 @jorisvandenbossche PTAL This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [arrow] bkietz commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

2020-10-05 Thread GitBox
bkietz commented on a change in pull request #8305: URL: https://github.com/apache/arrow/pull/8305#discussion_r499859431 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -143,97 +150,235 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl( return MakeVectorIterator

[GitHub] [arrow] wesm closed pull request #8302: ARROW-10121: [C++] Fix emission of new dictionaries in IPC writer

2020-10-05 Thread GitBox
wesm closed pull request #8302: URL: https://github.com/apache/arrow/pull/8302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] wesm commented on a change in pull request #8302: ARROW-10121: [C++] Fix emission of new dictionaries in IPC writer

2020-10-05 Thread GitBox
wesm commented on a change in pull request #8302: URL: https://github.com/apache/arrow/pull/8302#discussion_r499856714 ## File path: cpp/src/arrow/ipc/writer.cc ## @@ -982,13 +982,7 @@ class ARROW_EXPORT IpcFormatWriter : public RecordBatchWriter { RETURN_NOT_OK(CheckSt

[GitHub] [arrow] github-actions[bot] commented on pull request #8350: ARROW-10179: [Rust] Fixed error in labeler

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8350: URL: https://github.com/apache/arrow/pull/8350#issuecomment-703869134 https://issues.apache.org/jira/browse/ARROW-10179 This is an automated message from the Apache Git Ser

[GitHub] [arrow] jorgecarleitao closed pull request #8347: Testing github labels.

2020-10-05 Thread GitBox
jorgecarleitao closed pull request #8347: URL: https://github.com/apache/arrow/pull/8347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] bkietz closed pull request #8311: ARROW-10008: [C++][Dataset] Fix filtering/row group statistics of dict columns

2020-10-05 Thread GitBox
bkietz closed pull request #8311: URL: https://github.com/apache/arrow/pull/8311 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] jorgecarleitao commented on pull request #8350: ARROW-10179: [Rust] Fixed error in labeler

2020-10-05 Thread GitBox
jorgecarleitao commented on pull request #8350: URL: https://github.com/apache/arrow/pull/8350#issuecomment-703868313 fyi @andygrove This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] bkietz commented on a change in pull request #8343: ARROW-9147: [C++][Dataset] Support projection from null->any type

2020-10-05 Thread GitBox
bkietz commented on a change in pull request #8343: URL: https://github.com/apache/arrow/pull/8343#discussion_r499848398 ## File path: cpp/src/arrow/dataset/projector.cc ## @@ -46,6 +46,15 @@ Status CheckProjectable(const Schema& from, const Schema& to) {

[GitHub] [arrow] jorgecarleitao opened a new pull request #8350: ARROW-10179: [Rust] Fixed error in labeler

2020-10-05 Thread GitBox
jorgecarleitao opened a new pull request #8350: URL: https://github.com/apache/arrow/pull/8350 @kszucs, It seems that I used a notation in the labeler that [is only supported in the master version of it](https://github.com/actions/labeler/issues/73#issuecomment-639034278). This PR fixes t

[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8304: URL: https://github.com/apache/arrow/pull/8304#issuecomment-703857874 Revision: 406febf38f380f8e75ecd14af5118c6761baf65d Submitted crossbow builds: [ursa-labs/crossbow @ actions-603](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] github-actions[bot] commented on pull request #8349: ARROW-3080: [Python] Unify Arrow to Python object conversion paths

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8349: URL: https://github.com/apache/arrow/pull/8349#issuecomment-703855507 Revision: f823a17f209e16c9583ee3ad630730d5164ec98b Submitted crossbow builds: [ursa-labs/crossbow @ actions-602](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-10-05 Thread GitBox
nealrichardson commented on pull request #8304: URL: https://github.com/apache/arrow/pull/8304#issuecomment-703854677 @github-actions crossbow submit test-r-rhub-ubuntu-gcc-release test-r-rocker-r-base-latest This is an auto

[GitHub] [arrow] kszucs commented on pull request #8349: ARROW-3080: [Python] Unify Arrow to Python object conversion paths

2020-10-05 Thread GitBox
kszucs commented on pull request #8349: URL: https://github.com/apache/arrow/pull/8349#issuecomment-703854189 @github-actions crossbow submit test-conda-python-3.8-hypothesis This is an automated message from the Apache Git S

[GitHub] [arrow] kszucs commented on a change in pull request #8349: ARROW-3080: [Python] Unify Arrow to Python object conversion paths

2020-10-05 Thread GitBox
kszucs commented on a change in pull request #8349: URL: https://github.com/apache/arrow/pull/8349#discussion_r499836082 ## File path: python/pyarrow/tests/strategies.py ## @@ -293,3 +359,32 @@ def tables(draw, type, rows=None, max_fields=None): all_chunked_arrays = chunked_ar

[GitHub] [arrow] andygrove closed pull request #8338: ARROW-8735: [Rust] [Parquet] Allow arm 32 to use soft hash implementation

2020-10-05 Thread GitBox
andygrove closed pull request #8338: URL: https://github.com/apache/arrow/pull/8338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] kszucs commented on a change in pull request #8349: ARROW-3080: [Python] Unify Arrow to Python object conversion paths

2020-10-05 Thread GitBox
kszucs commented on a change in pull request #8349: URL: https://github.com/apache/arrow/pull/8349#discussion_r499835603 ## File path: cpp/src/arrow/python/python_to_arrow.cc ## @@ -1004,6 +991,9 @@ Result> ConvertPySequence(PyObject* obj, PyObject* PyObject* seq; OwnedR

[GitHub] [arrow] pgovind commented on a change in pull request #8348: ARROW-6972: [C#] C# support for StructArrays

2020-10-05 Thread GitBox
pgovind commented on a change in pull request #8348: URL: https://github.com/apache/arrow/pull/8348#discussion_r499823191 ## File path: csharp/test/Apache.Arrow.Tests/ArrayBuilderTests.cs ## @@ -73,6 +73,67 @@ public void StringArrayBuilderHandlesNullsAndEmptyStrings()

[GitHub] [arrow] github-actions[bot] commented on pull request #8349: ARROW-3080: [Python] Unify Arrow to Python object conversion paths

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8349: URL: https://github.com/apache/arrow/pull/8349#issuecomment-703849579 https://issues.apache.org/jira/browse/ARROW-3080 This is an automated message from the Apache Git Serv

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

2020-10-05 Thread GitBox
jorisvandenbossche commented on a change in pull request #8305: URL: https://github.com/apache/arrow/pull/8305#discussion_r499831141 ## File path: python/pyarrow/dataset.py ## @@ -694,22 +697,23 @@ def _ensure_write_partitioning(scheme): return scheme -def write_datase

[GitHub] [arrow] kszucs opened a new pull request #8349: ARROW-3080: [Python] Unify Arrow to Python object conversion paths

2020-10-05 Thread GitBox
kszucs opened a new pull request #8349: URL: https://github.com/apache/arrow/pull/8349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #8348: ARROW-6972: [C#] C# support for StructArrays

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8348: URL: https://github.com/apache/arrow/pull/8348#issuecomment-703842934 https://issues.apache.org/jira/browse/ARROW-6972 This is an automated message from the Apache Git Serv

[GitHub] [arrow] pgovind commented on a change in pull request #8348: ARROW-6972: [C#] C# support for StructArrays

2020-10-05 Thread GitBox
pgovind commented on a change in pull request #8348: URL: https://github.com/apache/arrow/pull/8348#discussion_r499823191 ## File path: csharp/test/Apache.Arrow.Tests/ArrayBuilderTests.cs ## @@ -73,6 +73,67 @@ public void StringArrayBuilderHandlesNullsAndEmptyStrings()

[GitHub] [arrow] github-actions[bot] commented on pull request #8348: C# support for StructArrays

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8348: URL: https://github.com/apache/arrow/pull/8348#issuecomment-703838060 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] pgovind commented on a change in pull request #8348: C# support for StructArrays

2020-10-05 Thread GitBox
pgovind commented on a change in pull request #8348: URL: https://github.com/apache/arrow/pull/8348#discussion_r499817006 ## File path: csharp/src/Apache.Arrow/Arrays/ArrowArrayBuilderFactory.cs ## @@ -59,6 +59,7 @@ static class ArrowArrayBuilderFactory case Ar

[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8304: URL: https://github.com/apache/arrow/pull/8304#issuecomment-703833299 Revision: 548b6f33b02f651b2c8cf1b43c3db40aba8fb6a6 Submitted crossbow builds: [ursa-labs/crossbow @ actions-601](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] pgovind opened a new pull request #8348: C# support for StructArrays

2020-10-05 Thread GitBox
pgovind opened a new pull request #8348: URL: https://github.com/apache/arrow/pull/8348 Fix for https://issues.apache.org/jira/browse/ARROW-6972 Add support for `StructArray`. It'd be nice to have an easier way to construct a `StructArray`, but that can come in a follow up PR -

[GitHub] [arrow] tconkling commented on pull request #8216: ARROW-8394: [JS] Upgrade to TypeScript 4.0.2, fix typings for TS 3.9+

2020-10-05 Thread GitBox
tconkling commented on pull request #8216: URL: https://github.com/apache/arrow/pull/8216#issuecomment-703832898 Thanks a lot for your work on this, @trxcllnt! Really excited for this to land in a release. This is an automat

[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-10-05 Thread GitBox
nealrichardson commented on pull request #8304: URL: https://github.com/apache/arrow/pull/8304#issuecomment-703832109 @github-actions crossbow submit -g r This is an automated message from the Apache Git Service. To respond t

[GitHub] [arrow] carols10cents commented on pull request #8330: [Rust] [Parquet] Add roundtrip Arrow -> Parquet tests for all supported Arrow DataTypes

2020-10-05 Thread GitBox
carols10cents commented on pull request #8330: URL: https://github.com/apache/arrow/pull/8330#issuecomment-703830182 @nevi-me I went ahead and merged in [your PR](https://github.com/integer32llc/arrow/pull/1), rebased this PR's branch on rust-parquet-arrow-writer, added one commit to expli

[GitHub] [arrow] github-actions[bot] commented on pull request #8347: Testing github labels.

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8347: URL: https://github.com/apache/arrow/pull/8347#issuecomment-703824279 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] pitrou commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

2020-10-05 Thread GitBox
pitrou commented on a change in pull request #8305: URL: https://github.com/apache/arrow/pull/8305#discussion_r499805082 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -143,97 +150,235 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl( return MakeVectorIterator

[GitHub] [arrow] jorgecarleitao opened a new pull request #8347: Testing github labels.

2020-10-05 Thread GitBox
jorgecarleitao opened a new pull request #8347: URL: https://github.com/apache/arrow/pull/8347 This is a test to the github labels, which were recently introduced for rust. This is an automated message from the Apache Git Ser

[GitHub] [arrow] github-actions[bot] commented on pull request #8346: ARROW-10164: [Rust] Add support for DictionaryArray to cast kernel

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8346: URL: https://github.com/apache/arrow/pull/8346#issuecomment-703824202 https://issues.apache.org/jira/browse/ARROW-10164 This is an automated message from the Apache Git Ser

[GitHub] [arrow] bkietz commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

2020-10-05 Thread GitBox
bkietz commented on a change in pull request #8305: URL: https://github.com/apache/arrow/pull/8305#discussion_r499804639 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -143,97 +150,235 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl( return MakeVectorIterator

[GitHub] [arrow] pitrou commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

2020-10-05 Thread GitBox
pitrou commented on a change in pull request #8305: URL: https://github.com/apache/arrow/pull/8305#discussion_r499803394 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -143,97 +150,235 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl( return MakeVectorIterator

[GitHub] [arrow] pitrou commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

2020-10-05 Thread GitBox
pitrou commented on a change in pull request #8305: URL: https://github.com/apache/arrow/pull/8305#discussion_r499803394 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -143,97 +150,235 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl( return MakeVectorIterator

[GitHub] [arrow] pitrou commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

2020-10-05 Thread GitBox
pitrou commented on a change in pull request #8305: URL: https://github.com/apache/arrow/pull/8305#discussion_r499799105 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -143,97 +150,235 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl( return MakeVectorIterator

[GitHub] [arrow] alamb opened a new pull request #8346: ARROW-10164: [Rust] Add support for DictionaryArray to cast kernel

2020-10-05 Thread GitBox
alamb opened a new pull request #8346: URL: https://github.com/apache/arrow/pull/8346 NOTE: this builds on #8333 and https://github.com/apache/arrow/pull/8340 This PR adds support to the rust compute kernal casting `DictionaryArray` to/from `PrimitiveArray`/`StringArray` It d

[GitHub] [arrow] alamb commented on pull request #8345: ARROW-10164: [Rust] Add support for DictionaryArray to cast kernel

2020-10-05 Thread GitBox
alamb commented on pull request #8345: URL: https://github.com/apache/arrow/pull/8345#issuecomment-703816290 Closing so I can make a draft PR. Sorry for noise This is an automated message from the Apache Git Service. To respo

[GitHub] [arrow] alamb opened a new pull request #8345: ARROW-10164: [Rust] Add support for DictionaryArray to cast kernel

2020-10-05 Thread GitBox
alamb opened a new pull request #8345: URL: https://github.com/apache/arrow/pull/8345 NOTE: this builds on #8333 and https://github.com/apache/arrow/pull/8340 This PR adds support to the rust compute kernal casting `DictionaryArray` to/from `PrimitiveArray`/`StringArray` It d

[GitHub] [arrow] alamb closed pull request #8345: ARROW-10164: [Rust] Add support for DictionaryArray to cast kernel

2020-10-05 Thread GitBox
alamb closed pull request #8345: URL: https://github.com/apache/arrow/pull/8345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] pitrou commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

2020-10-05 Thread GitBox
pitrou commented on a change in pull request #8305: URL: https://github.com/apache/arrow/pull/8305#discussion_r499788958 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -143,97 +150,235 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl( return MakeVectorIterator

[GitHub] [arrow] github-actions[bot] commented on pull request #8344: Add BasicDecimal256 Multiplication Support

2020-10-05 Thread GitBox
github-actions[bot] commented on pull request #8344: URL: https://github.com/apache/arrow/pull/8344#issuecomment-703801449 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] BryanCutler commented on pull request #8337: ARROW-10151: [Python] Add support for MapArray conversion to Pandas

2020-10-05 Thread GitBox
BryanCutler commented on pull request #8337: URL: https://github.com/apache/arrow/pull/8337#issuecomment-703797500 Ping @pitrou @jorisvandenbossche to please take a look, thanks! This is an automated message from the Apache G

[GitHub] [arrow] Luminarys opened a new pull request #8344: Add BasicDecimal256 Multiplication Support

2020-10-05 Thread GitBox
Luminarys opened a new pull request #8344: URL: https://github.com/apache/arrow/pull/8344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] BryanCutler commented on a change in pull request #8337: ARROW-10151: [Python] Add support for MapArray conversion to Pandas

2020-10-05 Thread GitBox
BryanCutler commented on a change in pull request #8337: URL: https://github.com/apache/arrow/pull/8337#discussion_r499767269 ## File path: cpp/src/arrow/python/arrow_to_pandas.cc ## @@ -791,6 +791,114 @@ Status ConvertListsLike(const PandasOptions& options, const ChunkedArray

  1   2   >