emkornfield commented on pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#issuecomment-712610825
@liyafan82 I renamed to Decimal256, let me know if you have other comments
on the Java side. @pitrou I'm still working through your comments.
jorgecarleitao commented on pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#issuecomment-712601468
Some changes since last time:
1. added a small tool to verify memory allocations and verified no leaks
2. added the test that @pitrou suggested to verify that we
jorgecarleitao commented on a change in pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#discussion_r508213973
##
File path: rust/arrow-c-integration/tests/test_sql.py
##
@@ -0,0 +1,51 @@
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation
emkornfield commented on pull request #7110:
URL: https://github.com/apache/arrow/pull/7110#issuecomment-712584960
I'll try to take a look later this week (please ping me if I forget).
This is an automated message from the
jorgecarleitao commented on pull request #8481:
URL: https://github.com/apache/arrow/pull/8481#issuecomment-712584694
We are already force-pushing to master on every release, which goes against
best practices of an open-source project.
AFAIK, in open source, there is a strong
wesm edited a comment on pull request #8481:
URL: https://github.com/apache/arrow/pull/8481#issuecomment-712567457
If a PR has a base commit that is one of the master commits that is part of
the rebased master (i.e. some commit between the date the RC was cut and the
date of the release),
wesm commented on pull request #8481:
URL: https://github.com/apache/arrow/pull/8481#issuecomment-712567457
If a PR has a base commit that is one of the master commits that is part of
the rebased master (i.e. some commit between the date the RC was cut and the
date of the release), then
jorgecarleitao commented on pull request #8481:
URL: https://github.com/apache/arrow/pull/8481#issuecomment-712566577
@kszucs, would it be possible to avoid force-pushing to PRs after a release
(even if master is force-pushed)? IMO it is very confusing to the contributor
(committer or
wesm commented on pull request #8491:
URL: https://github.com/apache/arrow/pull/8491#issuecomment-712563608
We have some self-hosted aarch64 machines that we could use to run these,
too, at some point
This is an automated
wesm commented on pull request #8472:
URL: https://github.com/apache/arrow/pull/8472#issuecomment-712563172
@bkietz presumably this yields smaller code size, too?
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-712547428
Revision: 53507f9f06fe474e15d468c8d8f54aba7a33d3b2
Submitted crossbow builds: [ursa-labs/crossbow @
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-712546156
@github-actions crossbow submit -g conda -g wheel
This is an automated message from the Apache Git Service.
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-712546068
I didn't realize the .ci_support files were vendored from
https://github.com/conda-forge/arrow-cpp-feedstock. I updated the files to
cyb70289 commented on a change in pull request #8466:
URL: https://github.com/apache/arrow/pull/8466#discussion_r508164101
##
File path: cpp/src/arrow/compute/kernels/aggregate_var_std.cc
##
@@ -57,6 +63,54 @@ struct VarStdState {
this->m2 = m2;
}
+ // int32/16/8:
sunchao commented on pull request #8300:
URL: https://github.com/apache/arrow/pull/8300#issuecomment-712479156
From the description the changes proposed here makes sense to me as well -
but seems the PR itself is messed up and contains many unrelated changes.
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-712469831
Revision: 4a4a7c222a80bd6c484897eb8da135b80b8a7da5
Submitted crossbow builds: [ursa-labs/crossbow @
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-712468902
@github-actions crossbow submit -g conda -g wheel
This is an automated message from the Apache Git Service.
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508062401
##
File path: cpp/src/arrow/type.cc
##
@@ -131,6 +133,7 @@ std::string ToString(Type::type id) {
TO_STRING_CASE(FLOAT)
TO_STRING_CASE(DOUBLE)
kszucs commented on pull request #8491:
URL: https://github.com/apache/arrow/pull/8491#issuecomment-712392450
I'd suggest to expand the docker-compose configuration on short term until
we can figure out a nicer way to map different arch naming conventions.
pitrou commented on pull request #8491:
URL: https://github.com/apache/arrow/pull/8491#issuecomment-712373502
@xhochy @kszucs Can you help with this? Our conventions are getting in the
way here (e.g. `ARCH` is `amd64` rather than `x86_64`, we use a specific hash
for the upstream
jorgecarleitao commented on pull request #8430:
URL: https://github.com/apache/arrow/pull/8430#issuecomment-712369692
@vertexclique , I think that the feature is appreciated, but the
implementation shows some underlying issue with the API to build arrays.
IMO, In light of this PR we
AWSjswinney commented on pull request #8491:
URL: https://github.com/apache/arrow/pull/8491#issuecomment-712367815
This change makes it possible to build aarch64 python wheels, but I haven't
figured out how to modify the CI code to use Travis CI the do Arm builds.
Travis-CI.com is the
pitrou commented on pull request #8491:
URL: https://github.com/apache/arrow/pull/8491#issuecomment-712367868
You'll need to create a Travis-CI job that runs this docker-compose entry.
This is an automated message from the
AWSjswinney opened a new pull request #8491:
URL: https://github.com/apache/arrow/pull/8491
add support for building python aarch64 wheels for linux
This is an automated message from the Apache Git Service.
To respond to the
keeratsingh commented on a change in pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#discussion_r507971603
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightRuntimeException.java
##
@@ -29,7 +29,7 @@
/**
* Create a new
keeratsingh commented on a change in pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#discussion_r507971481
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/CallOptions.java
##
@@ -56,7 +56,7 @@ public static CallOption
kszucs closed pull request #8479:
URL: https://github.com/apache/arrow/pull/8479
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kszucs commented on pull request #8479:
URL: https://github.com/apache/arrow/pull/8479#issuecomment-712337836
Closing since the vote has passed.
This is an automated message from the Apache Git Service.
To respond to the
maartenbreddels commented on pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#issuecomment-712319882
Thanks for the reviews Antoine!
This is an automated message from the Apache Git Service.
To respond to
pitrou closed pull request #8490:
URL: https://github.com/apache/arrow/pull/8490
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #8490:
URL: https://github.com/apache/arrow/pull/8490#issuecomment-712310200
Travis-CI: https://travis-ci.org/github/pitrou/arrow/builds/737137831
AppVeyor: https://ci.appveyor.com/project/pitrou/arrow/builds/35834777
CI failures are unrelated.
Luminarys commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507913864
##
File path: cpp/src/arrow/util/decimal_benchmark.cc
##
@@ -148,6 +148,21 @@ static void BinaryMathOp(benchmark::State& state) { //
NOLINT non-const
pitrou commented on pull request #8468:
URL: https://github.com/apache/arrow/pull/8468#issuecomment-712295030
You may want to remove the regex variant of this if you want to move this
forward without depending on resolving the re2 dependency issue.
pitrou commented on pull request #8490:
URL: https://github.com/apache/arrow/pull/8490#issuecomment-712295200
Thanks @emkornfield, I'll just wait for CI then.
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #8490:
URL: https://github.com/apache/arrow/pull/8490#issuecomment-712294262
https://issues.apache.org/jira/browse/ARROW-10348
This is an automated message from the Apache Git
pitrou opened a new pull request #8490:
URL: https://github.com/apache/arrow/pull/8490
Found by OSS-Fuzz. Should fix the following issue:
* https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=26422
This is an automated
chrish42 commented on pull request #7110:
URL: https://github.com/apache/arrow/pull/7110#issuecomment-712262192
@emkornfield Here's the latest version, rebased on the latest Arrow code
(been some changes with DictMemo -> DictFeidlMapper, etc.). There are
`Schema::FromJson()` and
andygrove commented on a change in pull request #8482:
URL: https://github.com/apache/arrow/pull/8482#discussion_r507863412
##
File path: rust/arrow/src/util/buffered_iterator.rs
##
@@ -0,0 +1,138 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
zeroshade commented on pull request #8471:
URL: https://github.com/apache/arrow/pull/8471#issuecomment-712247323
Any luck from anyone to get a quick review on this?
This is an automated message from the Apache Git Service.
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507837493
##
File path: cpp/src/parquet/arrow/reader_internal.cc
##
@@ -645,7 +645,9 @@ static Status DecimalIntegerTransfer(RecordReader* reader,
MemoryPool* pool,
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507836798
##
File path: cpp/src/arrow/util/decimal_test.cc
##
@@ -26,6 +26,7 @@
#include
#include
+#include
Review comment:
Ah, I see that we also use
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507836439
##
File path: cpp/src/arrow/util/decimal_test.cc
##
@@ -26,6 +26,7 @@
#include
#include
+#include
Review comment:
Can we include
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507834391
##
File path: cpp/src/arrow/util/decimal_benchmark.cc
##
@@ -191,6 +206,7 @@ static void BinaryBitOp(benchmark::State& state) { //
NOLINT non-const
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507834219
##
File path: cpp/src/arrow/util/decimal_benchmark.cc
##
@@ -148,6 +148,21 @@ static void BinaryMathOp(benchmark::State& state) { //
NOLINT non-const
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507832411
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -775,4 +833,119 @@ int32_t BasicDecimal128::CountLeadingBinaryZeros() const {
}
}
+#if
bkietz commented on pull request #8472:
URL: https://github.com/apache/arrow/pull/8472#issuecomment-712233535
@emkornfield I'm implementing a subset of `std::variant`'s functionality but
all members which are present are compatible; if we switch to using
`std::variant` at some point no
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507832075
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -775,4 +833,119 @@ int32_t BasicDecimal128::CountLeadingBinaryZeros() const {
}
}
+#if
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507830440
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -775,4 +833,119 @@ int32_t BasicDecimal128::CountLeadingBinaryZeros() const {
}
}
+#if
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507828684
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -254,67 +254,125 @@ BasicDecimal128& BasicDecimal128::operator>>=(uint32_t
bits) {
namespace {
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507826076
##
File path: cpp/src/arrow/type_traits.h
##
@@ -614,7 +635,7 @@ template
using is_list_type =
std::integral_constant::value ||
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507823242
##
File path: cpp/src/arrow/type.cc
##
@@ -131,6 +133,7 @@ std::string ToString(Type::type id) {
TO_STRING_CASE(FLOAT)
TO_STRING_CASE(DOUBLE)
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507820725
##
File path: cpp/src/arrow/python/decimal.cc
##
@@ -145,8 +146,9 @@ Status DecimalFromPythonDecimal(PyObject* python_decimal,
const DecimalType& arr
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r50781
##
File path: cpp/src/arrow/ipc/metadata_internal.cc
##
@@ -236,7 +236,8 @@ static inline TimeUnit::type
FromFlatbufferUnit(flatbuf::TimeUnit unit) {
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507816678
##
File path: cpp/src/arrow/c/bridge_test.cc
##
@@ -740,6 +741,7 @@ TEST_F(TestArrayExport, Primitive) {
TestPrimitive(large_utf8(), R"(["foo", "bar",
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507816678
##
File path: cpp/src/arrow/c/bridge_test.cc
##
@@ -740,6 +741,7 @@ TEST_F(TestArrayExport, Primitive) {
TestPrimitive(large_utf8(), R"(["foo", "bar",
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507814509
##
File path: cpp/src/arrow/array/validate.cc
##
@@ -64,6 +64,13 @@ struct ValidateArrayVisitor {
return Status::OK();
}
+ Status Visit(const
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507813280
##
File path: cpp/src/arrow/array/array_test.cc
##
@@ -2426,7 +2433,43 @@ TEST_P(DecimalTest, WithNulls) {
this->TestCreate(precision, draw, valid_bytes,
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507812828
##
File path: cpp/src/arrow/array/array_test.cc
##
@@ -2426,7 +2433,43 @@ TEST_P(DecimalTest, WithNulls) {
this->TestCreate(precision, draw, valid_bytes,
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507811608
##
File path: cpp/src/arrow/array/builder_decimal.h
##
@@ -58,6 +58,35 @@ class ARROW_EXPORT Decimal128Builder : public
FixedSizeBinaryBuilder {
pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507810468
##
File path: cpp/src/arrow/array/array_dict_test.cc
##
@@ -857,40 +857,48 @@ TEST(TestDecimalDictionaryBuilder, Basic) {
pitrou closed pull request #8271:
URL: https://github.com/apache/arrow/pull/8271
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#issuecomment-712205549
Thank you very much @maartenbreddels !
This is an automated message from the Apache Git Service.
To respond to the
pitrou commented on pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#issuecomment-712204248
macOS CI failures are unrelated.
This is an automated message from the Apache Git Service.
To respond to the
pitrou commented on a change in pull request #8466:
URL: https://github.com/apache/arrow/pull/8466#discussion_r507800242
##
File path: cpp/src/arrow/compute/kernels/aggregate_var_std.cc
##
@@ -57,6 +63,54 @@ struct VarStdState {
this->m2 = m2;
}
+ // int32/16/8:
pitrou commented on a change in pull request #8466:
URL: https://github.com/apache/arrow/pull/8466#discussion_r507711886
##
File path: cpp/src/arrow/compute/kernels/aggregate_var_std.cc
##
@@ -57,6 +63,54 @@ struct VarStdState {
this->m2 = m2;
}
+ // int32/16/8:
cyb70289 commented on a change in pull request #8466:
URL: https://github.com/apache/arrow/pull/8466#discussion_r507784895
##
File path: cpp/src/arrow/compute/kernels/aggregate_var_std.cc
##
@@ -57,6 +63,54 @@ struct VarStdState {
this->m2 = m2;
}
+ // int32/16/8:
pitrou commented on pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#issuecomment-712151765
Will update for the new `FunctionDoc` functionality and then merge.
This is an automated message from the Apache
pitrou closed pull request #8457:
URL: https://github.com/apache/arrow/pull/8457
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #8457:
URL: https://github.com/apache/arrow/pull/8457#issuecomment-712136427
Travis-CI build: https://travis-ci.org/github/pitrou/arrow/builds/737045923
CI failures are unrelated.
This
vertexclique commented on pull request #8430:
URL: https://github.com/apache/arrow/pull/8430#issuecomment-712135918
@jorgecarleitao @nevi-me Can I push this out of the door peeps? I am kind
of blocked by this atm.
This is
pitrou commented on a change in pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#discussion_r507720929
##
File path: rust/arrow-c-integration/tests/test_sql.py
##
@@ -0,0 +1,51 @@
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation (ASF)
pitrou commented on a change in pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#discussion_r507719587
##
File path: rust/arrow-c-integration/tests/test_sql.py
##
@@ -0,0 +1,51 @@
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation (ASF)
pitrou commented on a change in pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#discussion_r507718118
##
File path: rust/arrow-c-integration/src/lib.rs
##
@@ -0,0 +1,162 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
pitrou closed pull request #8374:
URL: https://github.com/apache/arrow/pull/8374
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lidavidm closed pull request #8476:
URL: https://github.com/apache/arrow/pull/8476
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on a change in pull request #8466:
URL: https://github.com/apache/arrow/pull/8466#discussion_r507711886
##
File path: cpp/src/arrow/compute/kernels/aggregate_var_std.cc
##
@@ -57,6 +63,54 @@ struct VarStdState {
this->m2 = m2;
}
+ // int32/16/8:
pitrou commented on a change in pull request #8466:
URL: https://github.com/apache/arrow/pull/8466#discussion_r507711304
##
File path: cpp/src/arrow/compute/kernels/aggregate_var_std.cc
##
@@ -57,6 +63,54 @@ struct VarStdState {
this->m2 = m2;
}
+ // int32/16/8:
lidavidm commented on a change in pull request #8476:
URL: https://github.com/apache/arrow/pull/8476#discussion_r507708211
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/BackpressureStrategy.java
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache
lidavidm commented on a change in pull request #8476:
URL: https://github.com/apache/arrow/pull/8476#discussion_r507710515
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/BackpressureStrategy.java
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache
pitrou commented on a change in pull request #8457:
URL: https://github.com/apache/arrow/pull/8457#discussion_r507709352
##
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##
@@ -302,19 +299,38 @@ void AddSortingKernels(VectorKernel base, VectorFunction*
func) {
}
pitrou commented on pull request #8374:
URL: https://github.com/apache/arrow/pull/8374#issuecomment-712125394
+1, will merge.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
pitrou commented on a change in pull request #8374:
URL: https://github.com/apache/arrow/pull/8374#discussion_r507708717
##
File path: docs/source/python/ipc.rst
##
@@ -330,21 +330,3 @@ An object can be reconstructed from its component-based
representation using
pitrou commented on pull request #8489:
URL: https://github.com/apache/arrow/pull/8489#issuecomment-712113484
Indeed, on Python 3.5, we have:
```python
>>> timezone.utc.tzname(None)
'UTC+00:00'
```
This is an
pitrou closed pull request #8407:
URL: https://github.com/apache/arrow/pull/8407
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #8407:
URL: https://github.com/apache/arrow/pull/8407#issuecomment-712109254
+1, thank you @cyb70289
This is an automated message from the Apache Git Service.
To respond to the message,
pitrou commented on pull request #8457:
URL: https://github.com/apache/arrow/pull/8457#issuecomment-712106591
Will rebase and merge.
This is an automated message from the Apache Git Service.
To respond to the message, please
maartenbreddels commented on pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#issuecomment-712043258
Hi @pitrou, yes, I've addressed all comments, should be good for a (last?)
review.
This is an automated
pitrou commented on pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#issuecomment-712014021
@maartenbreddels Don't hesitate to tell me when this PR is ready again.
This is an automated message from the
alamb commented on a change in pull request #8473:
URL: https://github.com/apache/arrow/pull/8473#discussion_r507632793
##
File path: rust/datafusion/src/physical_plan/common.rs
##
@@ -31,53 +32,58 @@ use array::{
};
use arrow::datatypes::{DataType, SchemaRef};
use
praveenbingo closed pull request #8467:
URL: https://github.com/apache/arrow/pull/8467
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs commented on pull request #8489:
URL: https://github.com/apache/arrow/pull/8489#issuecomment-711927614
@jorisvandenbossche python 3.5 build is failing.
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #8489:
URL: https://github.com/apache/arrow/pull/8489#issuecomment-711865534
https://issues.apache.org/jira/browse/ARROW-9963
This is an automated message from the Apache Git
jorisvandenbossche opened a new pull request #8489:
URL: https://github.com/apache/arrow/pull/8489
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
93 matches
Mail list logo
