[GitHub] [arrow] github-actions[bot] commented on pull request #8524: ARROW-10345: [C++][Compute] Fix NaN error in sorting and topn kernels

2020-10-25 Thread GitBox
github-actions[bot] commented on pull request #8524: URL: https://github.com/apache/arrow/pull/8524#issuecomment-716315945 https://issues.apache.org/jira/browse/ARROW-10345 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #8523: ARROW-10325: [C++][Compute] Refine aggregate kernel registration

2020-10-25 Thread GitBox
github-actions[bot] commented on pull request #8523: URL: https://github.com/apache/arrow/pull/8523#issuecomment-716315946 https://issues.apache.org/jira/browse/ARROW-10325 This is an automated message from the Apache Git

[GitHub] [arrow] cyb70289 opened a new pull request #8524: ARROW-10345: [C++][Compute] Fix NaN error in sorting and topn kernels

2020-10-25 Thread GitBox
cyb70289 opened a new pull request #8524: URL: https://github.com/apache/arrow/pull/8524 For sorting kernel, this patch treats NaN as the largest floating point number and moves them to the end of array, before Nulls. For partition_nth kernel, this patch ignores NaN (treats them as

[GitHub] [arrow] cyb70289 opened a new pull request #8523: ARROW-10325: [C++][Compute] Refine aggregate kernel registration

2020-10-25 Thread GitBox
cyb70289 opened a new pull request #8523: URL: https://github.com/apache/arrow/pull/8523 Separate Mode and Variance/Stddev kernels registration from basic aggregation kernels. This is an automated message from the Apache

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #8486: ARROW-10336: [Rust] Added FromIter and ToIter for string arrays

2020-10-25 Thread GitBox
jorgecarleitao edited a comment on pull request #8486: URL: https://github.com/apache/arrow/pull/8486#issuecomment-716298625 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] jorgecarleitao commented on pull request #8486: ARROW-10336: [Rust] Added FromIter and ToIter for string arrays

2020-10-25 Thread GitBox
jorgecarleitao commented on pull request #8486: URL: https://github.com/apache/arrow/pull/8486#issuecomment-716298625 @vertexclique , do you refer to the `DATA_TYPE`? I changed it to upper case after clippy asked me not to not express `const` as upper case.

[GitHub] [arrow] emkornfield commented on pull request #7110: ARROW-8952: [C++] WIP Support for textual, JSON schema representation

2020-10-25 Thread GitBox
emkornfield commented on pull request #7110: URL: https://github.com/apache/arrow/pull/7110#issuecomment-716293734 sorry for delay, will try to look tomorrow. This is an automated message from the Apache Git Service. To

[GitHub] [arrow] kou commented on pull request #8499: [CI] Pin homebrew LLVM@9

2020-10-25 Thread GitBox
kou commented on pull request #8499: URL: https://github.com/apache/arrow/pull/8499#issuecomment-716211405 Great! FYI: We can't use LLVM 11 on Ubuntu Xenial because g++ 5 on Ubuntu Xenial is old to use LLVM 11. LLVM 11 requires C++ 14 but g++ 5's C++ 14 support is limited. We're

[GitHub] [arrow] github-actions[bot] commented on pull request #8521: ARROW-10385: [C++][Gandiva] Add support for LLVM 11

2020-10-25 Thread GitBox
github-actions[bot] commented on pull request #8521: URL: https://github.com/apache/arrow/pull/8521#issuecomment-716210452 Revision: f136c6d016bbea7ff0651bce3391ff1e1a52c5cd Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #8521: ARROW-10385: [C++][Gandiva] Add support for LLVM 11

2020-10-25 Thread GitBox
kou commented on pull request #8521: URL: https://github.com/apache/arrow/pull/8521#issuecomment-716210482 MinGW link problem is caused by https://github.com/msys2/MINGW-packages/issues/7170 . It'll be fixed in upstream. I'll merge this in a few days if nobody objects it. Because

[GitHub] [arrow] kou commented on pull request #8521: ARROW-10385: [C++][Gandiva] Add support for LLVM 11

2020-10-25 Thread GitBox
kou commented on pull request #8521: URL: https://github.com/apache/arrow/pull/8521#issuecomment-716210137 @github-actions crossbow submit -g nightly This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] nevi-me closed pull request #8300: ARROW-10135: [Rust] [Parquet] Refactor file module to help adding sources

2020-10-25 Thread GitBox
nevi-me closed pull request #8300: URL: https://github.com/apache/arrow/pull/8300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] nevi-me closed pull request #8482: ARROW-10332: [Rust] Allow CSV reader to iterate from start up to end

2020-10-25 Thread GitBox
nevi-me closed pull request #8482: URL: https://github.com/apache/arrow/pull/8482 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] nevi-me commented on a change in pull request #8517: ARROW-10381: [Rust] Generalized Ordering for inter-array comparisons

2020-10-25 Thread GitBox
nevi-me commented on a change in pull request #8517: URL: https://github.com/apache/arrow/pull/8517#discussion_r511642958 ## File path: rust/arrow/src/array/ord.rs ## @@ -15,297 +15,280 @@ // specific language governing permissions and limitations // under the License.

[GitHub] [arrow] github-actions[bot] commented on pull request #8522: [Java] Bump Avro to 1.10.0

2020-10-25 Thread GitBox
github-actions[bot] commented on pull request #8522: URL: https://github.com/apache/arrow/pull/8522#issuecomment-716148173 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] Fokko opened a new pull request #8522: [Java] Bump Avro to 1.10.0

2020-10-25 Thread GitBox
Fokko opened a new pull request #8522: URL: https://github.com/apache/arrow/pull/8522 Small fixes, and removes the old Joda library for good: https://github.com/apache/avro/releases/tag/release-1.10.0 This is an automated

[GitHub] [arrow] nevi-me commented on pull request #8402: ARROW-8426: [Rust] [Parquet] - Add more support for converting Dicts

2020-10-25 Thread GitBox
nevi-me commented on pull request #8402: URL: https://github.com/apache/arrow/pull/8402#issuecomment-716110760 @carols10cents @alamb I think the whole reader logic needs replumbing ... There's at least a 1:1 mapping between Parquet types and Arrow types, and we can cast from Arrow types