github-actions[bot] commented on pull request #8790:
URL: https://github.com/apache/arrow/pull/8790#issuecomment-735036936
https://issues.apache.org/jira/browse/ARROW-10755
This is an automated message from the Apache Git Ser
wjones1 opened a new pull request #8790:
URL: https://github.com/apache/arrow/pull/8790
Built this based on what I saw existing for the numeric implementations.
Most of it was already there.
This is an automated message from
eerhardt commented on pull request #8694:
URL: https://github.com/apache/arrow/pull/8694#issuecomment-735020461
I believe the next round of releases is scheduled for sometime in January.
(See [this recent dev-list
thread](https://lists.apache.org/thread.html/r913292d53736affaff5933c1416fed
eerhardt closed pull request #8694:
URL: https://github.com/apache/arrow/pull/8694
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
andygrove commented on pull request #8788:
URL: https://github.com/apache/arrow/pull/8788#issuecomment-735015949
I haven't reviewed in detail but the changes look logical and make sense to
me.
This is an automated message fr
github-actions[bot] commented on pull request #8789:
URL: https://github.com/apache/arrow/pull/8789#issuecomment-735012632
https://issues.apache.org/jira/browse/ARROW-10754
This is an automated message from the Apache Git Ser
kou opened a new pull request #8789:
URL: https://github.com/apache/arrow/pull/8789
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nevi-me commented on a change in pull request #8788:
URL: https://github.com/apache/arrow/pull/8788#discussion_r531799717
##
File path: rust/arrow/src/json/reader.rs
##
@@ -1022,6 +846,228 @@ impl Reader {
Ok(Arc::new(builder.finish()))
}
+fn build_struct_ar
github-actions[bot] commented on pull request #8788:
URL: https://github.com/apache/arrow/pull/8788#issuecomment-735003554
https://issues.apache.org/jira/browse/ARROW-4544
This is an automated message from the Apache Git Serv
nevi-me commented on pull request #8788:
URL: https://github.com/apache/arrow/pull/8788#issuecomment-735002962
CC @houqp
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
nevi-me opened a new pull request #8788:
URL: https://github.com/apache/arrow/pull/8788
This allows reading nested JSON data provided in a schema. If the expected
value doesn't exist, or is not an object, it is deemed to be null.
I tested that the implementation correctly creates a n
github-actions[bot] commented on pull request #8787:
URL: https://github.com/apache/arrow/pull/8787#issuecomment-734999641
https://issues.apache.org/jira/browse/ARROW-10752
This is an automated message from the Apache Git Ser
lyndonb-bq commented on pull request #8725:
URL: https://github.com/apache/arrow/pull/8725#issuecomment-734999023
@lidavidm That's a really good point, there is a lot of code that wasn't
facing direct testing. I followed suggestion of moving the parsing logic to an
internal header (the cli
velvia commented on pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#issuecomment-734998072
Thanks everyone!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou opened a new pull request #8787:
URL: https://github.com/apache/arrow/pull/8787
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nevi-me closed pull request #8688:
URL: https://github.com/apache/arrow/pull/8688
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me commented on pull request #8739:
URL: https://github.com/apache/arrow/pull/8739#issuecomment-734986453
@alamb @jorgecarleitao this is blocking some work that I'm doing on parquet,
so I'd like to limit the scope of the PR to just nested structs, as I want to
submit a PR that correct
nevi-me commented on a change in pull request #8739:
URL: https://github.com/apache/arrow/pull/8739#discussion_r531781486
##
File path: rust/arrow/src/array/equal/structure.rs
##
@@ -15,45 +15,97 @@
// specific language governing permissions and limitations
// under the Licen
nevi-me commented on a change in pull request #8739:
URL: https://github.com/apache/arrow/pull/8739#discussion_r531780455
##
File path: rust/arrow/src/array/equal/structure.rs
##
@@ -15,13 +15,15 @@
// specific language governing permissions and limitations
// under the Licen
jorgecarleitao commented on pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#issuecomment-734979662
@nevi-me , I went through it already. Thanks a lot!
This is an automated message from the Apache Git Servic
nevi-me commented on pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#issuecomment-734975494
@jorgecarleitao I've just gone through this, and don't have anything else to
add. Can I merge it?
This is an auto
jorgecarleitao commented on pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#issuecomment-734972509
@velvia , just needs time from a committer: typically over the weekend I run
through all PRs in order of appearenace and merge them if ready. Thanks a for
the patience.
-
velvia commented on pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#issuecomment-734971636
How does it get merged from here? Sorry unclear on the process, thanks!
This is an automated message from the Apac
github-actions[bot] commented on pull request #8786:
URL: https://github.com/apache/arrow/pull/8786#issuecomment-734970636
https://issues.apache.org/jira/browse/ARROW-10751
This is an automated message from the Apache Git Ser
github-actions[bot] commented on pull request #8786:
URL: https://github.com/apache/arrow/pull/8786#issuecomment-734970404
Revision: 47ba128be9d91ac27746c64967e9a5faf1936220
Submitted crossbow builds: [ursa-labs/crossbow @
actions-736](https://github.com/ursa-labs/crossbow/branches/a
kou commented on pull request #8786:
URL: https://github.com/apache/arrow/pull/8786#issuecomment-734969821
@github-actions crossbow submit
example-cpp-minimal-build-static-system-dependency
This is an automated message from
kou opened a new pull request #8786:
URL: https://github.com/apache/arrow/pull/8786
Because we require RE2 with ARROW_COMPUTE by default.
See also: ARROW-10541 and #8756
This is an automated message from the Apache Git
kou closed pull request #8783:
URL: https://github.com/apache/arrow/pull/8783
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
nevi-me commented on pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#issuecomment-734965964
> Now some other jobs failed. Maybe we can rerun those?
CI seems to be misbehaving, it's not letting me cancel the workflow, even
though the tests have failed. I'll leave th
Dandandan commented on pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#issuecomment-734963747
Now some other jobs failed. Maybe we can rerun those?
This is an automated message from the Apache Git Service.
nevi-me commented on pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#issuecomment-734958652
> Could you push an empty commit to trigger CI again?
We can rerun failed CI jobs from the UI, which is often better as it doesn't
trigger AppVeyor and Travis CI
-
Dandandan commented on pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#issuecomment-734958248
> @Dandandan I'm not sure why the Windows build failed and I assume it is
unrelated but the logs are not available. Could you push an empty commit to
trigger CI again?
Ju
andygrove commented on pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#issuecomment-734956532
@Dandandan I'm not sure why the Windows build failed and I assume it is
unrelated but the logs are not available. Could you push an empty commit to
trigger CI again?
-
andygrove closed pull request #8771:
URL: https://github.com/apache/arrow/pull/8771
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#issuecomment-734952829
@jorgecarleitao I made some improvements to remove any join expressions from
the filter which helped for some cases but there is still one failing test
related to filter push do
andygrove commented on pull request #8731:
URL: https://github.com/apache/arrow/pull/8731#issuecomment-734931460
This is really interesting and I have started reviewing this now. Sorry for
the delay.
Here are some initial thoughts I had while looking at this:
- Would this be a
andygrove commented on pull request #8743:
URL: https://github.com/apache/arrow/pull/8743#issuecomment-734915475
I haven't reviewed in detail yet but LGTM
This is an automated message from the Apache Git Service.
To respond t
jorgecarleitao commented on pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#issuecomment-734914984
Got it. I understand now.
I agree that there is a bug: the push down should not push down like it is
doing now.
I also think that the filter should not be the
nevi-me closed pull request #8779:
URL: https://github.com/apache/arrow/pull/8779
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Dandandan commented on a change in pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#discussion_r531689316
##
File path: rust/benchmarks/src/bin/nyctaxi.rs
##
@@ -92,7 +92,7 @@ async fn datafusion_sql_benchmarks(
debug: bool,
) -> Result<()> {
let mu
andygrove commented on pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#issuecomment-734910372
With this syntax, the WHERE clause can contain both JOIN conditions and
regular filter conditions. For example:
```sql
FROM
customer,
orders,
linei
nevi-me commented on a change in pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#discussion_r531452276
##
File path: rust/benchmarks/src/bin/nyctaxi.rs
##
@@ -92,7 +92,7 @@ async fn datafusion_sql_benchmarks(
debug: bool,
) -> Result<()> {
let mut
jorgecarleitao edited a comment on pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#issuecomment-734907835
Thanks @andygrove.
I am a bit confused: why is there a filter on the plan? I thought that the
logical plan of
```
SELECT t1_id, t1_name, t2_name FR
jorgecarleitao commented on pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#issuecomment-734907835
Thanks @andygrove.
I am a bit confused: why is there a filter on the plan? I thought that the
logical plan of
```
SELECT t1_id, t1_name, t2_name FROM t1,
nevi-me commented on pull request #8731:
URL: https://github.com/apache/arrow/pull/8731#issuecomment-734905050
I'm really having FOMO wondering how we could leverage Apache Calcite in
Rust, as it has the relational algebra bits needed for the neat integration
with DataFusion.
Right now
jorgecarleitao commented on pull request #8731:
URL: https://github.com/apache/arrow/pull/8731#issuecomment-734903535
I already have an overview, but I also need more time to outline the design
in my head. I was planning to write a google docs with the high level
description (I do it mostl
andygrove commented on pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#issuecomment-734903494
@jorgecarleitao This code is basically working but I think it has exposed a
bug in the filter push down logic where it tries to push a filter down through
the join where the exp
alamb commented on pull request #8731:
URL: https://github.com/apache/arrow/pull/8731#issuecomment-734902280
THis looks really cool @nevi-me -- I will try and find time tomorrow to
review it carefully in depth. Thank you
Th
github-actions[bot] commented on pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#issuecomment-734900524
https://issues.apache.org/jira/browse/ARROW-10729
This is an automated message from the Apache Git Ser
github-actions[bot] commented on pull request #8784:
URL: https://github.com/apache/arrow/pull/8784#issuecomment-734900515
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
andygrove opened a new pull request #8785:
URL: https://github.com/apache/arrow/pull/8785
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sweb opened a new pull request #8784:
URL: https://github.com/apache/arrow/pull/8784
This is a follow up to #8640
Currently, there is a first working IPC reader test using data from
`testing/arrow-ipc-stream/integration/0.14.1/generated_decimal.arrow_file`
However, this lead
andygrove closed pull request #8751:
URL: https://github.com/apache/arrow/pull/8751
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lidavidm commented on a change in pull request #8725:
URL: https://github.com/apache/arrow/pull/8725#discussion_r531652380
##
File path: cpp/src/arrow/flight/flight_test.cc
##
@@ -1186,6 +1188,159 @@ class TestBasicHeaderAuthMiddleware : public
::testing::Test {
std::shared
github-actions[bot] commented on pull request #8778:
URL: https://github.com/apache/arrow/pull/8778#issuecomment-734864295
Revision: feba139a8e7769ad9b08f6cddbf56fe180068451
Submitted crossbow builds: [ursa-labs/crossbow @
actions-735](https://github.com/ursa-labs/crossbow/branches/a
xhochy commented on pull request #8778:
URL: https://github.com/apache/arrow/pull/8778#issuecomment-734863443
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To
romainfrancois commented on pull request #8650:
URL: https://github.com/apache/arrow/pull/8650#issuecomment-734843309
ping @kszucs @bkietz I don't necessarily need a full review at this point,
as this is far from done and will need further changes, but perhaps you can
have a look and let m
github-actions[bot] commented on pull request #8778:
URL: https://github.com/apache/arrow/pull/8778#issuecomment-734811547
Revision: 6943580fc43d200d372bbddce9c6b4feef5b8aa1
Submitted crossbow builds: [ursa-labs/crossbow @
actions-734](https://github.com/ursa-labs/crossbow/branches/a
xhochy commented on pull request #8778:
URL: https://github.com/apache/arrow/pull/8778#issuecomment-734810477
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #8778:
URL: https://github.com/apache/arrow/pull/8778#issuecomment-734807898
Revision: 7430878247ec5dc61b44b74051a9370258f7047d
Submitted crossbow builds: [ursa-labs/crossbow @
actions-733](https://github.com/ursa-labs/crossbow/branches/a
xhochy commented on pull request #8778:
URL: https://github.com/apache/arrow/pull/8778#issuecomment-734806805
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #8783:
URL: https://github.com/apache/arrow/pull/8783#issuecomment-734772262
https://issues.apache.org/jira/browse/ARROW-10749
This is an automated message from the Apache Git Ser
liyafan82 opened a new pull request #8783:
URL: https://github.com/apache/arrow/pull/8783
The current format looks like this: `Collection(...`, the right embrace is
omitted.
This is an automated message from the Apache Git S
romainfrancois commented on pull request #8650:
URL: https://github.com/apache/arrow/pull/8650#issuecomment-734746906
This is still quite wip, as I navigate how the various `Converter` work
together.
It all feels a bit weird to operate in terms of single values, i.e. via the
`Appen
github-actions[bot] commented on pull request #8778:
URL: https://github.com/apache/arrow/pull/8778#issuecomment-734716946
Revision: d5a18644ddd2287ea51ee9b02efa05d3ad979d7c
Submitted crossbow builds: [ursa-labs/crossbow @
actions-732](https://github.com/ursa-labs/crossbow/branches/a
xhochy commented on pull request #8778:
URL: https://github.com/apache/arrow/pull/8778#issuecomment-734716175
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To
66 matches
Mail list logo
