github-actions[bot] commented on pull request #8797:
URL: https://github.com/apache/arrow/pull/8797#issuecomment-735353580
https://issues.apache.org/jira/browse/ARROW-10760
This is an automated message from the Apache Git Ser
jorgecarleitao opened a new pull request #8797:
URL: https://github.com/apache/arrow/pull/8797
This fixes an error on which a predicate depending on columns from both
sides of a join was being pushed down through the join, causing incorrect plans.
The solution adopted here is to only
nevi-me closed pull request #8795:
URL: https://github.com/apache/arrow/pull/8795
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me closed pull request #8788:
URL: https://github.com/apache/arrow/pull/8788
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me commented on a change in pull request #8788:
URL: https://github.com/apache/arrow/pull/8788#discussion_r532161786
##
File path: rust/arrow/test/data/nested_structs.json
##
@@ -0,0 +1,4 @@
+{"a": {"b": true, "c": {"d": "text"}}}
Review comment:
I opened https://i
kou closed pull request #8789:
URL: https://github.com/apache/arrow/pull/8789
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
kou commented on pull request #8789:
URL: https://github.com/apache/arrow/pull/8789#issuecomment-735295530
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
kou closed pull request #8787:
URL: https://github.com/apache/arrow/pull/8787
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
kou commented on pull request #8787:
URL: https://github.com/apache/arrow/pull/8787#issuecomment-735295378
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on pull request #8796:
URL: https://github.com/apache/arrow/pull/8796#issuecomment-735291963
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
jorgecarleitao opened a new pull request #8796:
URL: https://github.com/apache/arrow/pull/8796
@nevi-me , @alamb @jhorstmann , I have been playing around with the buffers
on the arrow crate, and just for the fun, tried to replace all our `memory`
logic by a simple `Vec`. Perhaps unsurpris
nevi-me commented on a change in pull request #8731:
URL: https://github.com/apache/arrow/pull/8731#discussion_r532104073
##
File path: rust/datafusion/src/physical_plan/sql.rs
##
@@ -0,0 +1,246 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
nevi-me commented on a change in pull request #8731:
URL: https://github.com/apache/arrow/pull/8731#discussion_r532104014
##
File path: rust/sql/src/postgres/reader.rs
##
@@ -0,0 +1,938 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Th
nevi-me closed pull request #8790:
URL: https://github.com/apache/arrow/pull/8790
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me closed pull request #8781:
URL: https://github.com/apache/arrow/pull/8781
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me closed pull request #8772:
URL: https://github.com/apache/arrow/pull/8772
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me closed pull request #8793:
URL: https://github.com/apache/arrow/pull/8793
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Dandandan commented on pull request #8795:
URL: https://github.com/apache/arrow/pull/8795#issuecomment-735279563
FYI @jorgecarleitao I saw you did recently work on take.
This is an automated message from the Apache Git Servic
github-actions[bot] commented on pull request #8795:
URL: https://github.com/apache/arrow/pull/8795#issuecomment-735279133
https://issues.apache.org/jira/browse/ARROW-10763
This is an automated message from the Apache Git Ser
Dandandan opened a new pull request #8795:
URL: https://github.com/apache/arrow/pull/8795
This PR significantly speeds up the take (primitive and boolean) kernels for
non-null arrays.
```
take i32 512time: [1.1847 us 1.1879 us 1.1915 us]
github-actions[bot] commented on pull request #8794:
URL: https://github.com/apache/arrow/pull/8794#issuecomment-735277538
https://issues.apache.org/jira/browse/ARROW-10759
This is an automated message from the Apache Git Ser
yordan-pavlov commented on a change in pull request #8794:
URL: https://github.com/apache/arrow/pull/8794#discussion_r532094849
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -376,6 +378,27 @@ pub fn cast(array: &ArrayRef, to_type: &DataType) ->
Result {
nevi-me commented on a change in pull request #8794:
URL: https://github.com/apache/arrow/pull/8794#discussion_r532094059
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -376,6 +378,27 @@ pub fn cast(array: &ArrayRef, to_type: &DataType) ->
Result {
Int
yordan-pavlov opened a new pull request #8794:
URL: https://github.com/apache/arrow/pull/8794
This PR implements casting string (Utf8) to date (Date32(Day)) for a more
user-friendly and readable way for creating date literals in SQL queries using
an expression such as `CAST('2019-01-01' AS
nevi-me commented on pull request #8792:
URL: https://github.com/apache/arrow/pull/8792#issuecomment-735272976
Looks like there's still a lot for me clean up on the `levels.rs` file. I'll
document in detail how the algorithm I've adopted works, with some examples.
andygrove commented on a change in pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#discussion_r532057124
##
File path: rust/datafusion/src/sql/planner.rs
##
@@ -322,10 +317,80 @@ impl<'a, S: SchemaProvider> SqlToRel<'a, S> {
));
}
-
andygrove commented on a change in pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#discussion_r532054884
##
File path: rust/datafusion/src/sql/planner.rs
##
@@ -322,10 +317,80 @@ impl<'a, S: SchemaProvider> SqlToRel<'a, S> {
));
}
-
nevi-me commented on a change in pull request #8792:
URL: https://github.com/apache/arrow/pull/8792#discussion_r532047229
##
File path: rust/parquet/src/arrow/levels.rs
##
@@ -0,0 +1,692 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
nevi-me commented on a change in pull request #8792:
URL: https://github.com/apache/arrow/pull/8792#discussion_r532047192
##
File path: rust/parquet/src/arrow/levels.rs
##
@@ -0,0 +1,692 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
nevi-me commented on pull request #8793:
URL: https://github.com/apache/arrow/pull/8793#issuecomment-735238354
The Python 3.5 failure is expected, Python 3.5 is being removed in another PR
This is an automated message from th
codecov-io edited a comment on pull request #8793:
URL: https://github.com/apache/arrow/pull/8793#issuecomment-735230983
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8793?src=pr&el=h1) Report
> Merging
[#8793](https://codecov.io/gh/apache/arrow/pull/8793?src=pr&el=desc) (36dd3d2)
alamb commented on a change in pull request #8792:
URL: https://github.com/apache/arrow/pull/8792#discussion_r532037000
##
File path: rust/parquet/src/arrow/arrow_writer.rs
##
@@ -423,25 +313,64 @@ fn write_leaf(
Ok(written as i64)
}
-/// A struct that represents defini
Dandandan commented on pull request #8772:
URL: https://github.com/apache/arrow/pull/8772#issuecomment-735233785
@nevi-me lints are fixed
This is an automated message from the Apache Git Service.
To respond to the message, pl
codecov-io commented on pull request #8793:
URL: https://github.com/apache/arrow/pull/8793#issuecomment-735230983
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8793?src=pr&el=h1) Report
> Merging
[#8793](https://codecov.io/gh/apache/arrow/pull/8793?src=pr&el=desc) (27706de)
into
nevi-me commented on pull request #8772:
URL: https://github.com/apache/arrow/pull/8772#issuecomment-735229621
@Dandandan looks like there's some clippy lints that need fixing (from the
macOS CI failures)
This is an automate
github-actions[bot] commented on pull request #8793:
URL: https://github.com/apache/arrow/pull/8793#issuecomment-735228950
https://issues.apache.org/jira/browse/ARROW-10757
This is an automated message from the Apache Git Ser
nevi-me commented on pull request #8793:
URL: https://github.com/apache/arrow/pull/8793#issuecomment-735228869
🤡 so the Rust CI won't run because no files have been changed. I'm going to
bump the nightly to force things to move
-
nevi-me opened a new pull request #8793:
URL: https://github.com/apache/arrow/pull/8793
Fixes Ci failures by separating running tests, and discarding artefacts
after testing
Also adds a separate test for `arrow` on stable
alamb commented on a change in pull request #8790:
URL: https://github.com/apache/arrow/pull/8790#discussion_r532036432
##
File path: rust/parquet/src/arrow/arrow_writer.rs
##
@@ -1023,9 +1038,6 @@ mod tests {
}
#[test]
-#[should_panic(
Review comment:
👍
alamb commented on a change in pull request #8788:
URL: https://github.com/apache/arrow/pull/8788#discussion_r532035806
##
File path: rust/arrow/src/json/reader.rs
##
@@ -1559,6 +1608,54 @@ mod tests {
}
}
+#[test]
+fn test_nested_struct_json_arrays() {
alamb commented on a change in pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#discussion_r532035179
##
File path: rust/datafusion/src/sql/planner.rs
##
@@ -322,10 +317,80 @@ impl<'a, S: SchemaProvider> SqlToRel<'a, S> {
));
}
-
nevi-me commented on a change in pull request #8790:
URL: https://github.com/apache/arrow/pull/8790#discussion_r532035226
##
File path: rust/parquet/src/arrow/arrow_writer.rs
##
@@ -665,6 +670,16 @@ where
values
}
+fn get_bool_array_slice(array: &arrow_array::BooleanArr
alamb commented on pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#issuecomment-735225696
> @jorgecarleitao This code is basically working but I think it has exposed
a bug in the filter push down logic where it tries to push a filter down
through the join where the expre
nevi-me commented on a change in pull request #8792:
URL: https://github.com/apache/arrow/pull/8792#discussion_r532034509
##
File path: rust/parquet/src/arrow/arrow_writer.rs
##
@@ -176,87 +194,17 @@ fn write_leaves(
}
Ok(())
}
-ArrowD
nevi-me commented on pull request #8739:
URL: https://github.com/apache/arrow/pull/8739#issuecomment-735224685
> I am going to retrigger the tests on github and then plan to merge this PR
if they pass
@alamb something's filling up our space on CI, so the tests might still
fail. I tr
alamb commented on pull request #8739:
URL: https://github.com/apache/arrow/pull/8739#issuecomment-735223342
The CI failures seem unrelated
For example:
https://github.com/apache/arrow/pull/8739/checks?check_run_id=1465465859
```
test result: ok. 56 passed; 0 failed;
github-actions[bot] commented on pull request #8792:
URL: https://github.com/apache/arrow/pull/8792#issuecomment-735223276
https://issues.apache.org/jira/browse/ARROW-9728
This is an automated message from the Apache Git Serv
alamb commented on a change in pull request #8739:
URL: https://github.com/apache/arrow/pull/8739#discussion_r532032623
##
File path: rust/arrow/src/array/equal/structure.rs
##
@@ -30,19 +32,51 @@ fn equal_values(
.iter()
.zip(rhs.child_data())
.all(|
alamb commented on a change in pull request #8746:
URL: https://github.com/apache/arrow/pull/8746#discussion_r532032034
##
File path: rust/datafusion/src/logical_plan/expr.rs
##
@@ -821,3 +851,26 @@ fn create_name(e: &Expr, input_schema: &Schema) ->
Result {
pub fn exprlist_t
nevi-me opened a new pull request #8792:
URL: https://github.com/apache/arrow/pull/8792
save progress (11/11/2020)
save progress
Integrating level calculations in writer
Some tests are failing, still have a long way to go
fix lints
save progress
I'm
alamb commented on a change in pull request #8715:
URL: https://github.com/apache/arrow/pull/8715#discussion_r532031780
##
File path: rust/arrow/src/datatypes.rs
##
@@ -1149,13 +1155,34 @@ impl DataType {
}
}
+impl NullableDataType {
+/// Creates a new data type con
Dandandan commented on pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#issuecomment-735222176
I also removed the now unused buffered iterator as it is unused by now, and
I think will not lead to efficient code in general.
alamb commented on pull request #8715:
URL: https://github.com/apache/arrow/pull/8715#issuecomment-735222106
If the CI tests pass, I suggest we update the PR's title too to reflect what
this PR does now -- something perhaps like "Do not store (unused) field name in
DataType, only store nul
nevi-me closed pull request #8791:
URL: https://github.com/apache/arrow/pull/8791
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nevi-me commented on pull request #8791:
URL: https://github.com/apache/arrow/pull/8791#issuecomment-735221930
CI failure is not because of tests, so I'm merging this
This is an automated message from the Apache Git Service.
alamb commented on pull request #8715:
URL: https://github.com/apache/arrow/pull/8715#issuecomment-735221904
@ch-sc -- I think this PR needs a rebase against `master` -- the issue with
the integration tests has been fixed I believe
alamb commented on a change in pull request #8731:
URL: https://github.com/apache/arrow/pull/8731#discussion_r532030344
##
File path: rust/datafusion/src/physical_plan/sql.rs
##
@@ -0,0 +1,246 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contrib
nevi-me commented on pull request #8791:
URL: https://github.com/apache/arrow/pull/8791#issuecomment-735208460
Thanks Daniël, I'm looking into what we can change in our CI to avoid
running out of disk space. I'll try fix that today.
Given that CI isn't cheap (as we now see from Travi
github-actions[bot] commented on pull request #8791:
URL: https://github.com/apache/arrow/pull/8791#issuecomment-735187335
https://issues.apache.org/jira/browse/ARROW-10756
This is an automated message from the Apache Git Ser
Dandandan opened a new pull request #8791:
URL: https://github.com/apache/arrow/pull/8791
Was introduced in https://github.com/apache/arrow/pull/8688 , I guess
because the CI there ran before the merge.
This is an automated
60 matches
Mail list logo
