[GitHub] [arrow] github-actions[bot] commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757111058 Revision: 5b0c9f0a210bcbdb9a04e069bbfc4ba9ceccf0b6 Submitted crossbow builds: [ursa-labs/crossbow @ actions-862](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] terencehonles commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757110986 @github-actions crossbow submit wheel-win-cp36m This is an automated message from the Apache Git Service. To

[GitHub] [arrow] codecov-io edited a comment on pull request #9122: ARROW-10299: [Rust] Use IPC Metadata V5 as default

2021-01-08 Thread GitBox
codecov-io edited a comment on pull request #9122: URL: https://github.com/apache/arrow/pull/9122#issuecomment-756042833 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9122?src=pr&el=h1) Report > Merging [#9122](https://codecov.io/gh/apache/arrow/pull/9122?src=pr&el=desc) (b3829c7)

[GitHub] [arrow] github-actions[bot] commented on pull request #9145: ARROW-10777: [Packaging][Python] Build sdist by Crossbow

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #9145: URL: https://github.com/apache/arrow/pull/9145#issuecomment-757108526 Revision: 9f2c3a6e10982d36aab53a3070f77623e72c20c7 Submitted crossbow builds: [ursa-labs/crossbow @ actions-861](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] github-actions[bot] commented on pull request #9145: ARROW-10777: [Packaging][Python] Build sdist by Crossbow

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #9145: URL: https://github.com/apache/arrow/pull/9145#issuecomment-757108433 https://issues.apache.org/jira/browse/ARROW-10777 This is an automated message from the Apache Git Ser

[GitHub] [arrow] kou commented on pull request #9145: ARROW-10777: [Packaging][Python] Build sdist by Crossbow

2021-01-08 Thread GitBox
kou commented on pull request #9145: URL: https://github.com/apache/arrow/pull/9145#issuecomment-757108429 @github-actions crossbow submit sdist This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] kou opened a new pull request #9145: ARROW-10777: [Packaging][Python] Build sdist by Crossbow

2021-01-08 Thread GitBox
kou opened a new pull request #9145: URL: https://github.com/apache/arrow/pull/9145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] mqy commented on pull request #9137: ARROW-8676: [Rust] IPC RecordBatch body compression

2021-01-08 Thread GitBox
mqy commented on pull request #9137: URL: https://github.com/apache/arrow/pull/9137#issuecomment-757107707 > Did you notice something with it? I might need a bit more context :) ``` pub struct BodyCompressionArgs { pub codec: CompressionType, pub method: BodyCompressi

[GitHub] [arrow] terencehonles commented on a change in pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on a change in pull request #8916: URL: https://github.com/apache/arrow/pull/8916#discussion_r554301286 ## File path: dev/tasks/python-wheels/win-build.bat ## @@ -22,11 +22,19 @@ @rem --file=arrow\ci\conda_env_gandiva.yml ^ -@rem create conda enviro

[GitHub] [arrow] terencehonles commented on a change in pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on a change in pull request #8916: URL: https://github.com/apache/arrow/pull/8916#discussion_r554300596 ## File path: dev/tasks/python-wheels/win-build.bat ## @@ -22,11 +22,19 @@ @rem --file=arrow\ci\conda_env_gandiva.yml ^ -@rem create conda enviro

[GitHub] [arrow] kou commented on a change in pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
kou commented on a change in pull request #8916: URL: https://github.com/apache/arrow/pull/8916#discussion_r554296439 ## File path: dev/tasks/python-wheels/win-build.bat ## @@ -22,11 +22,19 @@ @rem --file=arrow\ci\conda_env_gandiva.yml ^ -@rem create conda environment for

[GitHub] [arrow] nevi-me commented on pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml

2021-01-08 Thread GitBox
nevi-me commented on pull request #9031: URL: https://github.com/apache/arrow/pull/9031#issuecomment-757101028 Hey @huitseeker, the errors in integration tests should be fixed now, may you please kindly rebase This is an aut

[GitHub] [arrow] nevi-me closed pull request #9129: ARROW-11169: [Rust] Add a comment explaining where float total_order algorithm came from

2021-01-08 Thread GitBox
nevi-me closed pull request #9129: URL: https://github.com/apache/arrow/pull/9129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] nevi-me closed pull request #9049: ARROW-8853: [Rust] [Integration Testing] Enable Flight tests

2021-01-08 Thread GitBox
nevi-me closed pull request #9049: URL: https://github.com/apache/arrow/pull/9049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] nevi-me commented on pull request #9137: ARROW-8676: [Rust] IPC RecordBatch body compression

2021-01-08 Thread GitBox
nevi-me commented on pull request #9137: URL: https://github.com/apache/arrow/pull/9137#issuecomment-757099760 > @nevi-me would you please have a look at `BodyCompressionBuilder` from [ipc/gen/Message.rs](https://github.com/apache/arrow/blob/a2e7d3a87fb8fa1cc98a54029c0262df468838fa/rust/arr

[GitHub] [arrow] github-actions[bot] commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757098383 Revision: e218e7e0e81fdff71a0e9f573c550adade797199 Submitted crossbow builds: [ursa-labs/crossbow @ actions-860](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] terencehonles commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757098298 @github-actions crossbow submit wheel-win-cp36m This is an automated message from the Apache Git Service. To

[GitHub] [arrow] mqy commented on pull request #9137: ARROW-8676: [Rust] IPC RecordBatch body compression

2021-01-08 Thread GitBox
mqy commented on pull request #9137: URL: https://github.com/apache/arrow/pull/9137#issuecomment-757098021 @nevi-me would you please have a look at `BodyCompressionBuilder` from [ipc/gen/Message.rs](https://github.com/apache/arrow/blob/a2e7d3a87fb8fa1cc98a54029c0262df468838fa/rust/arrow/s

[GitHub] [arrow] github-actions[bot] commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757096365 Revision: 774ccd0e8f130dac9bef2debecad8b59f993cb15 Submitted crossbow builds: [ursa-labs/crossbow @ actions-859](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] terencehonles commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757096304 @github-actions crossbow submit wheel-win-* conda-win-* This is an automated message from the Apache Git Ser

[GitHub] [arrow] nealrichardson commented on a change in pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
nealrichardson commented on a change in pull request #9143: URL: https://github.com/apache/arrow/pull/9143#discussion_r554280947 ## File path: r/R/dataset-format.R ## @@ -104,9 +104,31 @@ CsvFileFormat$create <- function(..., opts = csv_file_format_parse_options(...)) } cs

[GitHub] [arrow] nealrichardson commented on a change in pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
nealrichardson commented on a change in pull request #9143: URL: https://github.com/apache/arrow/pull/9143#discussion_r554280774 ## File path: r/R/dataset-format.R ## @@ -104,9 +104,31 @@ CsvFileFormat$create <- function(..., opts = csv_file_format_parse_options(...)) } cs

[GitHub] [arrow] nealrichardson commented on a change in pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
nealrichardson commented on a change in pull request #9143: URL: https://github.com/apache/arrow/pull/9143#discussion_r554280501 ## File path: r/tests/testthat/test-dataset.R ## @@ -303,11 +303,54 @@ test_that("Other text delimited dataset", { filter(integer > 6) %>%

[GitHub] [arrow] ianmcook commented on a change in pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
ianmcook commented on a change in pull request #9143: URL: https://github.com/apache/arrow/pull/9143#discussion_r554278223 ## File path: r/R/dataset-format.R ## @@ -104,9 +104,31 @@ CsvFileFormat$create <- function(..., opts = csv_file_format_parse_options(...)) } csv_file

[GitHub] [arrow] ianmcook commented on a change in pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
ianmcook commented on a change in pull request #9143: URL: https://github.com/apache/arrow/pull/9143#discussion_r554277501 ## File path: r/R/dataset-format.R ## @@ -104,9 +104,31 @@ CsvFileFormat$create <- function(..., opts = csv_file_format_parse_options(...)) } csv_file

[GitHub] [arrow] ianmcook commented on a change in pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
ianmcook commented on a change in pull request #9143: URL: https://github.com/apache/arrow/pull/9143#discussion_r554271178 ## File path: r/tests/testthat/test-dataset.R ## @@ -303,11 +303,54 @@ test_that("Other text delimited dataset", { filter(integer > 6) %>% su

[GitHub] [arrow] jonkeane commented on a change in pull request #9118: Arrow 10623: [CI][R] Version 1.0.1 breaks data.frame attributes when reading file written by 2.0.0

2021-01-08 Thread GitBox
jonkeane commented on a change in pull request #9118: URL: https://github.com/apache/arrow/pull/9118#discussion_r554263558 ## File path: r/tests/testthat/test-backwards-compatibility.R ## @@ -0,0 +1,159 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [arrow] github-actions[bot] commented on pull request #8833: WIP ARROW-10803: [R] Failure to compile on R 3.4

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8833: URL: https://github.com/apache/arrow/pull/8833#issuecomment-757056568 Revision: 46faf210f04d68b0be9ee72a8b10fc3116f1a190 Submitted crossbow builds: [ursa-labs/crossbow @ actions-858](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] nealrichardson commented on pull request #8833: WIP ARROW-10803: [R] Failure to compile on R 3.4

2021-01-08 Thread GitBox
nealrichardson commented on pull request #8833: URL: https://github.com/apache/arrow/pull/8833#issuecomment-757056290 @github-actions crossbow submit test-r-versions This is an automated message from the Apache Git Service. T

[GitHub] [arrow] gangliao closed issue #9144: error: could not compile `parquet`

2021-01-08 Thread GitBox
gangliao closed issue #9144: URL: https://github.com/apache/arrow/issues/9144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] gangliao commented on issue #9144: error: could not compile `parquet`

2021-01-08 Thread GitBox
gangliao commented on issue #9144: URL: https://github.com/apache/arrow/issues/9144#issuecomment-757049065 Thanks. @sunchao This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [arrow] sunchao edited a comment on issue #9144: error: could not compile `parquet`

2021-01-08 Thread GitBox
sunchao edited a comment on issue #9144: URL: https://github.com/apache/arrow/issues/9144#issuecomment-757047671 @gangliao this should be fixed by #9138. Can you update to the latest master and see if the issue is gone? This

[GitHub] [arrow] sunchao commented on issue #9144: error: could not compile `parquet`

2021-01-08 Thread GitBox
sunchao commented on issue #9144: URL: https://github.com/apache/arrow/issues/9144#issuecomment-757047671 @gangliao this should be fixed by #9138. Can you try again to see if the issue is gone? This is an automated message f

[GitHub] [arrow] github-actions[bot] commented on pull request #8833: WIP ARROW-10803: [R] Failure to compile on R 3.4

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8833: URL: https://github.com/apache/arrow/pull/8833#issuecomment-757046918 Revision: 1eaeea704961edf0525811be74dc47aa62803ed3 Submitted crossbow builds: [ursa-labs/crossbow @ actions-857](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] nealrichardson commented on pull request #8833: WIP ARROW-10803: [R] Failure to compile on R 3.4

2021-01-08 Thread GitBox
nealrichardson commented on pull request #8833: URL: https://github.com/apache/arrow/pull/8833#issuecomment-757046639 @github-actions crossbow submit test-r-versions This is an automated message from the Apache Git Service. T

[GitHub] [arrow] gangliao commented on issue #9144: error: could not compile `parquet`

2021-01-08 Thread GitBox
gangliao commented on issue #9144: URL: https://github.com/apache/arrow/issues/9144#issuecomment-757045552 ```shell Compiling lazy_static v1.4.0 Compiling cfg-if v0.1.10 Compiling cfg-if v1.0.0 Compiling futures-core v0.3.9 Compiling slab v0.4.2 Compiling f

[GitHub] [arrow] nealrichardson edited a comment on pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
nealrichardson edited a comment on pull request #9143: URL: https://github.com/apache/arrow/pull/9143#issuecomment-757043963 > @nealrichardson let me know if you'd also like to me to add text in these two places in the `dataset_factory` and `FileFormat` docs explaining that some readr-styl

[GitHub] [arrow] nealrichardson commented on pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
nealrichardson commented on pull request #9143: URL: https://github.com/apache/arrow/pull/9143#issuecomment-757043963 > @nealrichardson let me know if you'd also like to me to add text in these two places in the `dataset_factory` and `FileFormat` docs explaining that some readr-style optio

[GitHub] [arrow] nealrichardson commented on a change in pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
nealrichardson commented on a change in pull request #9143: URL: https://github.com/apache/arrow/pull/9143#discussion_r554241301 ## File path: r/tests/testthat/test-dataset.R ## @@ -303,11 +303,54 @@ test_that("Other text delimited dataset", { filter(integer > 6) %>%

[GitHub] [arrow] kou commented on a change in pull request #9096: [Python][Packaging] Refactor manylinux and windows wheel building [WIP]

2021-01-08 Thread GitBox
kou commented on a change in pull request #9096: URL: https://github.com/apache/arrow/pull/9096#discussion_r554240959 ## File path: docker-compose.yml ## @@ -120,9 +117,113 @@ x-hierarchy: # helper services - impala - postgres + - python-wheel-manylinux-2010 + - pyth

[GitHub] [arrow] github-actions[bot] commented on pull request #8833: WIP ARROW-10803: [R] Failure to compile on R 3.4

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8833: URL: https://github.com/apache/arrow/pull/8833#issuecomment-757038891 Revision: 0962bb92cd6bc7fdda3b79d72b45044644eacb80 Submitted crossbow builds: [ursa-labs/crossbow @ actions-856](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] nealrichardson commented on pull request #8833: WIP ARROW-10803: [R] Failure to compile on R 3.4

2021-01-08 Thread GitBox
nealrichardson commented on pull request #8833: URL: https://github.com/apache/arrow/pull/8833#issuecomment-757038597 @github-actions crossbow submit test-r-versions This is an automated message from the Apache Git Service. T

[GitHub] [arrow] carols10cents commented on pull request #9049: ARROW-8853: [Rust] [Integration Testing] Enable Flight tests

2021-01-08 Thread GitBox
carols10cents commented on pull request #9049: URL: https://github.com/apache/arrow/pull/9049#issuecomment-757036793 Rebased, and CI is looking good! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] westonpace commented on pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

2021-01-08 Thread GitBox
westonpace commented on pull request #8984: URL: https://github.com/apache/arrow/pull/8984#issuecomment-757028786 Thanks for the insight @pitrou . Your guess was right, there was a bug with multi-byte index types. I believe I have addressed your concerns. ---

[GitHub] [arrow] gangliao opened a new issue #9144: error: could not compile `parquet`

2021-01-08 Thread GitBox
gangliao opened a new issue #9144: URL: https://github.com/apache/arrow/issues/9144 ```rust error[E0063]: missing fields `file_offset`, `ordinal`, `total_compressed_size` in initializer of `RowGroup` --> /home/scq/.cargo/git/checkouts/arrow-c68ed0db3d7d4cdb/a8e2a6e/rust/parquet/sr

[GitHub] [arrow] westonpace commented on a change in pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

2021-01-08 Thread GitBox
westonpace commented on a change in pull request #8984: URL: https://github.com/apache/arrow/pull/8984#discussion_r554221218 ## File path: cpp/src/arrow/array/concatenate_test.cc ## @@ -225,6 +225,86 @@ TEST_F(ConcatenateTest, DictionaryType) { }); } +TEST_F(ConcatenateTe

[GitHub] [arrow] westonpace commented on a change in pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

2021-01-08 Thread GitBox
westonpace commented on a change in pull request #8984: URL: https://github.com/apache/arrow/pull/8984#discussion_r554221067 ## File path: cpp/src/arrow/array/concatenate.cc ## @@ -163,6 +163,46 @@ static Status PutOffsets(const std::shared_ptr& src, Offset first_offset ret

[GitHub] [arrow] westonpace commented on a change in pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

2021-01-08 Thread GitBox
westonpace commented on a change in pull request #8984: URL: https://github.com/apache/arrow/pull/8984#discussion_r554221000 ## File path: cpp/src/arrow/array/concatenate.cc ## @@ -163,6 +163,46 @@ static Status PutOffsets(const std::shared_ptr& src, Offset first_offset ret

[GitHub] [arrow] westonpace commented on a change in pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

2021-01-08 Thread GitBox
westonpace commented on a change in pull request #8984: URL: https://github.com/apache/arrow/pull/8984#discussion_r554220685 ## File path: cpp/src/arrow/array/array_dict.cc ## @@ -44,6 +44,29 @@ namespace arrow { using internal::checked_cast; using internal::CopyBitmap; +st

[GitHub] [arrow] westonpace commented on a change in pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

2021-01-08 Thread GitBox
westonpace commented on a change in pull request #8984: URL: https://github.com/apache/arrow/pull/8984#discussion_r554220491 ## File path: cpp/src/arrow/array/concatenate_test.cc ## @@ -225,6 +225,86 @@ TEST_F(ConcatenateTest, DictionaryType) { }); } +TEST_F(ConcatenateTe

[GitHub] [arrow] codecov-io edited a comment on pull request #9049: ARROW-8853: [Rust] [Integration Testing] Enable Flight tests

2021-01-08 Thread GitBox
codecov-io edited a comment on pull request #9049: URL: https://github.com/apache/arrow/pull/9049#issuecomment-752979498 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9049?src=pr&el=h1) Report > Merging [#9049](https://codecov.io/gh/apache/arrow/pull/9049?src=pr&el=desc) (863420d)

[GitHub] [arrow] ianmcook edited a comment on pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
ianmcook edited a comment on pull request #9143: URL: https://github.com/apache/arrow/pull/9143#issuecomment-757016760 @nealrichardson let me know if you'd also like to me to add text in these two places in the `dataset_factory` and `FileFormat` docs explaining that some readr-style option

[GitHub] [arrow] ianmcook edited a comment on pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
ianmcook edited a comment on pull request #9143: URL: https://github.com/apache/arrow/pull/9143#issuecomment-757016760 @nealrichardson let me know if you'd also like to me to explain in the `dataset_factory` and `FileFormat` docs that some readr-style options are not supported in `...`

[GitHub] [arrow] westonpace commented on a change in pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

2021-01-08 Thread GitBox
westonpace commented on a change in pull request #8984: URL: https://github.com/apache/arrow/pull/8984#discussion_r554217651 ## File path: cpp/src/arrow/type.h ## @@ -1367,6 +1367,12 @@ class ARROW_EXPORT DictionaryUnifier { /// after this is called virtual Status GetResu

[GitHub] [arrow] westonpace commented on a change in pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

2021-01-08 Thread GitBox
westonpace commented on a change in pull request #8984: URL: https://github.com/apache/arrow/pull/8984#discussion_r554217479 ## File path: cpp/src/arrow/array/concatenate.cc ## @@ -163,6 +163,46 @@ static Status PutOffsets(const std::shared_ptr& src, Offset first_offset ret

[GitHub] [arrow] westonpace commented on a change in pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

2021-01-08 Thread GitBox
westonpace commented on a change in pull request #8984: URL: https://github.com/apache/arrow/pull/8984#discussion_r554217402 ## File path: cpp/src/arrow/array/array_dict.cc ## @@ -44,6 +44,29 @@ namespace arrow { using internal::checked_cast; using internal::CopyBitmap; +st

[GitHub] [arrow] ianmcook commented on pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
ianmcook commented on pull request #9143: URL: https://github.com/apache/arrow/pull/9143#issuecomment-757016760 @nealrichardson let me know if you'd also like to me to add a note here in the `dataset_factory()` docs explaining that some readr-style options are not supported https://github

[GitHub] [arrow] nealrichardson commented on a change in pull request #9118: Arrow 10623: [CI][R] Version 1.0.1 breaks data.frame attributes when reading file written by 2.0.0

2021-01-08 Thread GitBox
nealrichardson commented on a change in pull request #9118: URL: https://github.com/apache/arrow/pull/9118#discussion_r554211387 ## File path: r/extra-tests/test-read-files.R ## @@ -0,0 +1,165 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

[GitHub] [arrow] kou commented on a change in pull request #9045: ARROW-11180: [Developer] cmake-format pre-commit hook doesn't run

2021-01-08 Thread GitBox
kou commented on a change in pull request #9045: URL: https://github.com/apache/arrow/pull/9045#discussion_r554201859 ## File path: run-cmake-format.py ## @@ -21,58 +21,20 @@ import pathlib import subprocess import sys +import argparse +from pathlib import Path Review comme

[GitHub] [arrow] github-actions[bot] commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757013322 Revision: 3d641a16c261d8fba103958606fa4b6f197b6483 Submitted crossbow builds: [ursa-labs/crossbow @ actions-855](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] terencehonles commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757013001 @github-actions crossbow submit wheel-win-cp36m wheel-win-cp37m wheel-win-cp38 This is an automated message

[GitHub] [arrow] github-actions[bot] commented on pull request #9045: ARROW-11180: [Developer] cmake-format pre-commit hook doesn't run

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #9045: URL: https://github.com/apache/arrow/pull/9045#issuecomment-757012526 https://issues.apache.org/jira/browse/ARROW-11180 This is an automated message from the Apache Git Ser

[GitHub] [arrow] jorisvandenbossche commented on pull request #9136: Fix walk

2021-01-08 Thread GitBox
jorisvandenbossche commented on pull request #9136: URL: https://github.com/apache/arrow/pull/9136#issuecomment-757010735 @michaelnarodovitch thanks for the fix, but this is already fixed on master by not using the S3FSWrapper class at all anymore (see https://github.com/apache/arrow/pull/

[GitHub] [arrow] codecov-io edited a comment on pull request #9116: ARROW-11156: [Rust][DataFusion] Create hashes vectorized in hash join [WIP]

2021-01-08 Thread GitBox
codecov-io edited a comment on pull request #9116: URL: https://github.com/apache/arrow/pull/9116#issuecomment-755963787 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9116?src=pr&el=h1) Report > Merging [#9116](https://codecov.io/gh/apache/arrow/pull/9116?src=pr&el=desc) (dcc9045)

[GitHub] [arrow] nealrichardson closed pull request #9141: ARROW-11190: [C++] Clean up compiler warnings

2021-01-08 Thread GitBox
nealrichardson closed pull request #9141: URL: https://github.com/apache/arrow/pull/9141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] github-actions[bot] commented on pull request #8833: WIP ARROW-10803: [R] Failure to compile on R 3.4

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8833: URL: https://github.com/apache/arrow/pull/8833#issuecomment-757007471 Revision: 1506415af3e1055716eeed814c2ec74eb02e6879 Submitted crossbow builds: [ursa-labs/crossbow @ actions-854](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] nealrichardson commented on pull request #8833: WIP ARROW-10803: [R] Failure to compile on R 3.4

2021-01-08 Thread GitBox
nealrichardson commented on pull request #8833: URL: https://github.com/apache/arrow/pull/8833#issuecomment-757007064 @github-actions crossbow submit test-r-versions This is an automated message from the Apache Git Service. T

[GitHub] [arrow] Dandandan commented on pull request #9116: ARROW-11156: [Rust][DataFusion] Create hashes vectorized in hash join [WIP]

2021-01-08 Thread GitBox
Dandandan commented on pull request #9116: URL: https://github.com/apache/arrow/pull/9116#issuecomment-757006724 This is nearing readiness. Need to do some final cleanup & add a test for the collision detection. Benchmarks results are still roughly the same. --

[GitHub] [arrow] github-actions[bot] commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757006640 Revision: 3d641a16c261d8fba103958606fa4b6f197b6483 Submitted crossbow builds: [ursa-labs/crossbow @ actions-853](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] terencehonles commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757006168 @github-actions crossbow submit wheel-win-cp39 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757004710 Revision: d4afd67e24eb5bbd0d525352db35af6393ceab76 Submitted crossbow builds: [ursa-labs/crossbow @ actions-852](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] terencehonles commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-757004364 @github-actions crossbow submit wheel-win-cp39 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #9143: URL: https://github.com/apache/arrow/pull/9143#issuecomment-757001158 https://issues.apache.org/jira/browse/ARROW-10463 This is an automated message from the Apache Git Ser

[GitHub] [arrow] ianmcook opened a new pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-08 Thread GitBox
ianmcook opened a new pull request #9143: URL: https://github.com/apache/arrow/pull/9143 Improves messaging for currently unsupported readr parse options and improves handling in related cases such as ambiguous partial argument names and invalid combinations of Arrow and readr options --

[GitHub] [arrow] huitseeker commented on pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml

2021-01-08 Thread GitBox
huitseeker commented on pull request #9031: URL: https://github.com/apache/arrow/pull/9031#issuecomment-756999694 @nevi-me @andygrove The release verification component should now be fixed. Besides that, some integration tests seem to be running on the wrong side of a source incompatible c

[GitHub] [arrow] bkietz commented on a change in pull request #9095: ARROW-10183: [C++] Apply composable futures to CSV

2021-01-08 Thread GitBox
bkietz commented on a change in pull request #9095: URL: https://github.com/apache/arrow/pull/9095#discussion_r554155616 ## File path: cpp/src/arrow/util/iterator.h ## @@ -35,6 +36,13 @@ namespace arrow { +namespace detail { + +template +using result_of_t = typename std::

[GitHub] [arrow] github-actions[bot] commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-756998688 Revision: abb3bc027c5608ff59a24969ff21f25380935752 Submitted crossbow builds: [ursa-labs/crossbow @ actions-851](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] terencehonles commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-756998246 @github-actions crossbow submit wheel-win-cp39 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] xhochy commented on a change in pull request #9140: ARROW-11189: [Developer] support benchmark diff between JSONs

2021-01-08 Thread GitBox
xhochy commented on a change in pull request #9140: URL: https://github.com/apache/arrow/pull/9140#discussion_r554190275 ## File path: dev/archery/archery/benchmark/core.py ## @@ -27,12 +27,13 @@ def median(values): class Benchmark: -def __init__(self, name, unit, less

[GitHub] [arrow] xhochy commented on pull request #9096: [Python][Packaging] Refactor manylinux and windows wheel building [WIP]

2021-01-08 Thread GitBox
xhochy commented on pull request #9096: URL: https://github.com/apache/arrow/pull/9096#issuecomment-756989524 The OSX issue is that `protobuf` is installed through `brew` and that doesn't install it using `cmake`. You could conditionally add the following line https://github.com/apache/a

[GitHub] [arrow] github-actions[bot] commented on pull request #9142: ARROW-11193: [Java][Documentation] Add Java ListVector Documentation

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #9142: URL: https://github.com/apache/arrow/pull/9142#issuecomment-756988361 https://issues.apache.org/jira/browse/ARROW-11193 This is an automated message from the Apache Git Ser

[GitHub] [arrow] jonkeane commented on pull request #9118: Arrow 10623: [CI][R] Version 1.0.1 breaks data.frame attributes when reading file written by 2.0.0

2021-01-08 Thread GitBox
jonkeane commented on pull request #9118: URL: https://github.com/apache/arrow/pull/9118#issuecomment-756985440 And fork CI passing: https://github.com/jonkeane/arrow/actions/runs/472646827 https://github.com/jonkeane/arrow/actions/runs/472646829

[GitHub] [arrow] github-actions[bot] commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-756984580 Revision: 5cdc1d90d1b5a66b79b161ca9738351753e6b418 Submitted crossbow builds: [ursa-labs/crossbow @ actions-850](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] terencehonles commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-756983913 @github-actions crossbow submit wheel-win-cp39 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-756981622 Revision: dbbb36c78c17674912f02b1c0227cadc2e8e06a5 Submitted crossbow builds: [ursa-labs/crossbow @ actions-849](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] terencehonles commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-756981176 @github-actions crossbow submit wheel-win-cp38 wheel-win-cp39 conda-win-vs2017-py39 This is an automated me

[GitHub] [arrow] terencehonles commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-756980819 backing out Sutou Kouhei's changes temporarily to see where things stand without the subsequent modifications. -

[GitHub] [arrow] github-actions[bot] commented on pull request #9142: Add Java ListVector Documentation

2021-01-08 Thread GitBox
github-actions[bot] commented on pull request #9142: URL: https://github.com/apache/arrow/pull/9142#issuecomment-756979343 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] jjbskir opened a new pull request #9142: Add Java ListVector Documentation

2021-01-08 Thread GitBox
jjbskir opened a new pull request #9142: URL: https://github.com/apache/arrow/pull/9142 Added documentation for the Java [ListVector](https://arrow.apache.org/docs/java/reference/org/apache/arrow/vector/complex/ListVector.html) class. I found using it to be difficult with out any concrete

[GitHub] [arrow] mqy commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

2021-01-08 Thread GitBox
mqy commented on pull request #9133: URL: https://github.com/apache/arrow/pull/9133#issuecomment-756975918 > LGTM. Thanks a lot for taking this! @jorgecarleitao thanks for the review. It seems the CI is getting close to success, please review again.

[GitHub] [arrow] terencehonles commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-08 Thread GitBox
terencehonles commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-756969805 > #8881 has merged now so I think this needs to be rebased. Thanks for the heads up @nealrichardson

[GitHub] [arrow] mqy commented on a change in pull request #9137: ARROW-8676: [Rust] IPC RecordBatch body compression

2021-01-08 Thread GitBox
mqy commented on a change in pull request #9137: URL: https://github.com/apache/arrow/pull/9137#discussion_r554081674 ## File path: rust/arrow/src/ipc/compression.rs ## @@ -0,0 +1,122 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

[GitHub] [arrow] alamb commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

2021-01-08 Thread GitBox
alamb commented on pull request #9138: URL: https://github.com/apache/arrow/pull/9138#issuecomment-756962524 > IMO we should pin the exact version in Cargo.toml I agree This is an automated message from the Apache Git

[GitHub] [arrow] mqy commented on a change in pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

2021-01-08 Thread GitBox
mqy commented on a change in pull request #9138: URL: https://github.com/apache/arrow/pull/9138#discussion_r554158804 ## File path: rust/parquet/Cargo.toml ## @@ -29,7 +29,7 @@ build = "build.rs" edition = "2018" [dependencies] -parquet-format = "2.6.1" +parquet-format = "~

[GitHub] [arrow] jorgecarleitao commented on pull request #9138: ARROW-11187: [Rust] [Parquet] Fix Build error by Pin specific parquet-format-rs version

2021-01-08 Thread GitBox
jorgecarleitao commented on pull request #9138: URL: https://github.com/apache/arrow/pull/9138#issuecomment-756956898 Having a library version be set after a format version is funny, as it is entirely possible to backward incompatibly change an API without backward incompatibly change the

[GitHub] [arrow] ovr commented on pull request #9139: ARROW-11188: [Rust] Support crypto functions from PostgreSQL dialect …

2021-01-08 Thread GitBox
ovr commented on pull request #9139: URL: https://github.com/apache/arrow/pull/9139#issuecomment-756956692 Thank you @alamb for notice 👍 I've done with PR, marked it as ready for review and awaiting review from DF's team. --

[GitHub] [arrow] quinnj commented on a change in pull request #9121: ARROW-11158: [Julia] Implement Decimal256 support for Julia

2021-01-08 Thread GitBox
quinnj commented on a change in pull request #9121: URL: https://github.com/apache/arrow/pull/9121#discussion_r554149673 ## File path: julia/Arrow/README.md ## @@ -1,13 +1,38 @@ # Arrow -[![Build Status](https://travis-ci.com/JuliaData/Arrow.jl.svg?branch=master)](https://t

[GitHub] [arrow] kszucs commented on pull request #9111: ARROW-11140: [Rust] [CI] Experimenting with Buildkite

2021-01-08 Thread GitBox
kszucs commented on pull request #9111: URL: https://github.com/apache/arrow/pull/9111#issuecomment-756953345 Preferably, of course it comes with a maintenance cost. This is an automated message from the Apache Git Service. T

[GitHub] [arrow] alamb commented on pull request #9139: ARROW-11188: [Rust] Support crypto functions from PostgreSQL dialect …

2021-01-08 Thread GitBox
alamb commented on pull request #9139: URL: https://github.com/apache/arrow/pull/9139#issuecomment-756952094 This PR probably needs to be rebased to pick up the fix for #9138 FYI This is an automated message from the Apac

[GitHub] [arrow] quinnj commented on a change in pull request #9121: ARROW-11158: [Julia] Implement Decimal256 support for Julia

2021-01-08 Thread GitBox
quinnj commented on a change in pull request #9121: URL: https://github.com/apache/arrow/pull/9121#discussion_r554147764 ## File path: julia/Arrow/Project.toml ## @@ -1,9 +1,10 @@ name = "Arrow" uuid = "69666777-d1a9-59fb-9406-91d4454c9d45" authors = ["quinnj "] -version = "

  1   2   3   >