mqy commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757434194
@nevi-me got it, thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please l
nevi-me edited a comment on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757433583
> * Is it make sense to `enable the SIMD feature by default`
No, because we want `stable` support by default, so simd is opt-in
(ARROW-6717)
> * Change static
nevi-me commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757433583
> * Is it make sense to `enable the SIMD feature by default`
No, because we want `stable` support by default, so simd is opt-in
(ARROW-6717)
> * Change static configu
mqy edited a comment on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757433133
List some possible TODO/discussion about the SIMD feature:
- Is it make sense to `enable the SIMD feature by default` [1]? I noticed
that
[servo/pathfinder](https://gith
mqy commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757433133
List some possible TODOs/discussion about the SIMD feature:
- Is it make sense to `enable the SIMD feature by default` [1]? I noticed
that
[servo/pathfinder](https://github.com
codecov-io edited a comment on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757361386
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=h1) Report
> Merging
[#9148](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=desc) (181a78d)
github-actions[bot] commented on pull request #9152:
URL: https://github.com/apache/arrow/pull/9152#issuecomment-757423106
https://issues.apache.org/jira/browse/ARROW-11196
This is an automated message from the Apache Git Ser
kou opened a new pull request #9152:
URL: https://github.com/apache/arrow/pull/9152
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mqy commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757421222
> How about merging `simd_x86` and `simd_aarch64` together, on the
presumption that as long as we use the same library for both (`packed_simd_2`
now, `stdsimd` later), we don't need t
nevi-me commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757420452
How about merging `simd_x86` and `simd_aarch64` together, on the presumption
that as long as we use the same library for both (`packed_simd_2` now,
`stdsimd` later), we don't need
mqy commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757418739
#8891 added `simd_x86`.
How about add `simd: { any(simd_x86, simd_aarch64) }` in this PR?
This is an automated mess
nevi-me commented on pull request #9031:
URL: https://github.com/apache/arrow/pull/9031#issuecomment-757101028
Hey @huitseeker, the errors in integration tests should be fixed now, may
you please kindly rebase
This is an aut
mqy commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554158804
##
File path: rust/parquet/Cargo.toml
##
@@ -29,7 +29,7 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "2.6.1"
+parquet-format = "~
github-actions[bot] commented on pull request #9142:
URL: https://github.com/apache/arrow/pull/9142#issuecomment-756979343
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
xhochy commented on pull request #8916:
URL: https://github.com/apache/arrow/pull/8916#issuecomment-757370153
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ianmcook commented on pull request #9143:
URL: https://github.com/apache/arrow/pull/9143#issuecomment-757016760
@nealrichardson let me know if you'd also like to me to add a note here in
the `dataset_factory()` docs explaining that some readr-style options are not
supported
https://github
ovr commented on pull request #9139:
URL: https://github.com/apache/arrow/pull/9139#issuecomment-756956692
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
nealrichardson commented on a change in pull request #9118:
URL: https://github.com/apache/arrow/pull/9118#discussion_r554211387
##
File path: r/extra-tests/test-read-files.R
##
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contribut
codecov-io commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756860174
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=h1) Report
> Merging
[#9138](https://codecov.io/gh/apache/arrow/pull/9138?src=pr&el=desc) (0969097)
into
nealrichardson commented on pull request #9143:
URL: https://github.com/apache/arrow/pull/9143#issuecomment-757043963
> @nealrichardson let me know if you'd also like to me to add text in these
two places in the `dataset_factory` and `FileFormat` docs explaining that some
readr-style optio
bkietz commented on a change in pull request #9140:
URL: https://github.com/apache/arrow/pull/9140#discussion_r554038453
##
File path: dev/archery/archery/cli.py
##
@@ -586,14 +585,29 @@ def _get_comparisons_as_json(comparisons):
return buf.getvalue()
-def _format_comp
github-actions[bot] commented on pull request #9145:
URL: https://github.com/apache/arrow/pull/9145#issuecomment-757108433
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
github-actions[bot] commented on pull request #9118:
URL: https://github.com/apache/arrow/pull/9118#issuecomment-756941897
Revision: da48c83b1587e49b92c074096bae7e74db2e712f
Submitted crossbow builds: [ursa-labs/crossbow @
actions-848](https://github.com/ursa-labs/crossbow/branches/a
codecov-io edited a comment on pull request #9049:
URL: https://github.com/apache/arrow/pull/9049#issuecomment-752979498
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9049?src=pr&el=h1) Report
> Merging
[#9049](https://codecov.io/gh/apache/arrow/pull/9049?src=pr&el=desc) (863420d)
github-actions[bot] commented on pull request #9045:
URL: https://github.com/apache/arrow/pull/9045#issuecomment-757012526
https://issues.apache.org/jira/browse/ARROW-11180
This is an automated message from the Apache Git Ser
codecov-io commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757361386
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=h1) Report
> Merging
[#9148](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=desc) (b67c47a)
into
github-actions[bot] commented on pull request #9141:
URL: https://github.com/apache/arrow/pull/9141#issuecomment-756923338
https://issues.apache.org/jira/browse/ARROW-11190
This is an automated message from the Apache Git Ser
nevi-me commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554121387
##
File path: rust/parquet/Cargo.toml
##
@@ -29,7 +29,7 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "2.6.1"
+parquet-format
sunchao edited a comment on issue #9144:
URL: https://github.com/apache/arrow/issues/9144#issuecomment-757047671
@gangliao this should be fixed by #9138. Can you update to the latest master
and see if the issue is gone?
This
nevi-me closed pull request #9129:
URL: https://github.com/apache/arrow/pull/9129
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
sunchao commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554095087
##
File path: rust/parquet/Cargo.toml
##
@@ -29,7 +29,7 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "2.6.1"
+parquet-format
alamb commented on pull request #9139:
URL: https://github.com/apache/arrow/pull/9139#issuecomment-756952094
This PR probably needs to be rebased to pick up the fix for #9138 FYI
This is an automated message from the Apac
github-actions[bot] commented on pull request #8916:
URL: https://github.com/apache/arrow/pull/8916#issuecomment-756981622
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
github-actions[bot] commented on pull request #9137:
URL: https://github.com/apache/arrow/pull/9137#issuecomment-756822180
https://issues.apache.org/jira/browse/ARROW-8676
This is an automated message from the Apache Git Serv
github-actions[bot] commented on pull request #9150:
URL: https://github.com/apache/arrow/pull/9150#issuecomment-757386393
https://issues.apache.org/jira/browse/ARROW-10180
This is an automated message from the Apache Git Ser
github-actions[bot] commented on pull request #9147:
URL: https://github.com/apache/arrow/pull/9147#issuecomment-757305199
https://issues.apache.org/jira/browse/ARROW-11177
This is an automated message from the Apache Git Ser
bkietz commented on a change in pull request #9134:
URL: https://github.com/apache/arrow/pull/9134#discussion_r554077313
##
File path: cpp/src/arrow/util/thread_pool.cc
##
@@ -84,10 +84,10 @@ static void WorkerLoop(std::shared_ptr
state,
break;
}
{
-
alamb closed pull request #9133:
URL: https://github.com/apache/arrow/pull/9133
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on pull request #9149:
URL: https://github.com/apache/arrow/pull/9149#issuecomment-757364177
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
github-actions[bot] commented on pull request #9139:
URL: https://github.com/apache/arrow/pull/9139#issuecomment-756887914
https://issues.apache.org/jira/browse/ARROW-11188
This is an automated message from the Apache Git Ser
nealrichardson closed pull request #9141:
URL: https://github.com/apache/arrow/pull/9141
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
bkietz commented on a change in pull request #9095:
URL: https://github.com/apache/arrow/pull/9095#discussion_r554155616
##
File path: cpp/src/arrow/util/iterator.h
##
@@ -35,6 +36,13 @@
namespace arrow {
+namespace detail {
+
+template
+using result_of_t = typename std::
github-actions[bot] commented on pull request #9151:
URL: https://github.com/apache/arrow/pull/9151#issuecomment-757389014
https://issues.apache.org/jira/browse/ARROW-11173
This is an automated message from the Apache Git Ser
bkietz closed pull request #9134:
URL: https://github.com/apache/arrow/pull/9134
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on a change in pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#discussion_r554137789
##
File path: rust/parquet/Cargo.toml
##
@@ -29,7 +29,7 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "2.6.1"
+parquet-format =
jonkeane commented on a change in pull request #9118:
URL: https://github.com/apache/arrow/pull/9118#discussion_r554263558
##
File path: r/tests/testthat/test-backwards-compatibility.R
##
@@ -0,0 +1,159 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
github-actions[bot] commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757359389
https://issues.apache.org/jira/browse/ARROW-11194
This is an automated message from the Apache Git Ser
xhochy commented on a change in pull request #9140:
URL: https://github.com/apache/arrow/pull/9140#discussion_r554190275
##
File path: dev/archery/archery/benchmark/core.py
##
@@ -27,12 +27,13 @@ def median(values):
class Benchmark:
-def __init__(self, name, unit, less
paddyhoran commented on pull request #9116:
URL: https://github.com/apache/arrow/pull/9116#issuecomment-757131336
@Dandandan I was trying to set up the process for running the integration
tests this morning and I cancelled your travis job by accident. I'm not
familiar with Travis, I looke
quinnj commented on a change in pull request #9121:
URL: https://github.com/apache/arrow/pull/9121#discussion_r554147764
##
File path: julia/Arrow/Project.toml
##
@@ -1,9 +1,10 @@
name = "Arrow"
uuid = "69666777-d1a9-59fb-9406-91d4454c9d45"
authors = ["quinnj "]
-version = "
kou commented on pull request #8916:
URL: https://github.com/apache/arrow/pull/8916#issuecomment-757376249
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
nealrichardson commented on pull request #9141:
URL: https://github.com/apache/arrow/pull/9141#issuecomment-756918737
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nealrichardson commented on pull request #8833:
URL: https://github.com/apache/arrow/pull/8833#issuecomment-756844542
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
bkietz commented on pull request #9141:
URL: https://github.com/apache/arrow/pull/9141#issuecomment-756912826
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
bkietz commented on pull request #9134:
URL: https://github.com/apache/arrow/pull/9134#issuecomment-756886802
non apache CI: https://github.com/michalursa/arrow/runs/1667448683
Rust failures are unrelated.
This is an a
codecov-io edited a comment on pull request #9116:
URL: https://github.com/apache/arrow/pull/9116#issuecomment-755963787
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
jorgecarleitao commented on a change in pull request #9139:
URL: https://github.com/apache/arrow/pull/9139#discussion_r554389768
##
File path: rust/datafusion/src/physical_plan/crypto_expressions.rs
##
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under
xhochy commented on a change in pull request #8916:
URL: https://github.com/apache/arrow/pull/8916#discussion_r554475665
##
File path: dev/tasks/python-wheels/win-build.bat
##
@@ -22,11 +22,21 @@
@rem --file=arrow\ci\conda_env_gandiva.yml ^
-@rem create conda environment f
mqy commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756832552
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
nealrichardson commented on pull request #8916:
URL: https://github.com/apache/arrow/pull/8916#issuecomment-756896235
#8881 has merged now so I think this needs to be rebased.
This is an automated message from the Apache Git
ianmcook commented on a change in pull request #9143:
URL: https://github.com/apache/arrow/pull/9143#discussion_r554271178
##
File path: r/tests/testthat/test-dataset.R
##
@@ -303,11 +303,54 @@ test_that("Other text delimited dataset", {
filter(integer > 6) %>%
su
jonkeane commented on pull request #9118:
URL: https://github.com/apache/arrow/pull/9118#issuecomment-756923877
@github-actions crossbow submit test-r-version-compatibility
This is an automated message from the Apache Git Ser
alamb commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756831758
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
nevi-me closed pull request #9049:
URL: https://github.com/apache/arrow/pull/9049
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
kszucs commented on pull request #9111:
URL: https://github.com/apache/arrow/pull/9111#issuecomment-756953345
Preferably, of course it comes with a maintenance cost.
This is an automated message from the Apache Git Service.
T
jorisvandenbossche commented on pull request #9136:
URL: https://github.com/apache/arrow/pull/9136#issuecomment-757010735
@michaelnarodovitch thanks for the fix, but this is already fixed on master
by not using the S3FSWrapper class at all anymore (see
https://github.com/apache/arrow/pull/
terencehonles edited a comment on pull request #8916:
URL: https://github.com/apache/arrow/pull/8916#issuecomment-757364190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nealrichardson edited a comment on pull request #9143:
URL: https://github.com/apache/arrow/pull/9143#issuecomment-757043963
> @nealrichardson let me know if you'd also like to me to add text in these
two places in the `dataset_factory` and `FileFormat` docs explaining that some
readr-styl
nevi-me commented on pull request #9137:
URL: https://github.com/apache/arrow/pull/9137#issuecomment-756815481
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
nevi-me commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756829437
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
terencehonles commented on pull request #8916:
URL: https://github.com/apache/arrow/pull/8916#issuecomment-756969805
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
carols10cents commented on pull request #9049:
URL: https://github.com/apache/arrow/pull/9049#issuecomment-757036793
Rebased, and CI is looking good!
This is an automated message from the Apache Git Service.
To respond to the
huitseeker commented on pull request #9031:
URL: https://github.com/apache/arrow/pull/9031#issuecomment-756999694
@nevi-me @andygrove The release verification component should now be fixed.
Besides that, some integration tests seem to be running on the wrong side of a
source incompatible c
yordan-pavlov commented on a change in pull request #9064:
URL: https://github.com/apache/arrow/pull/9064#discussion_r554469567
##
File path: rust/datafusion/src/physical_plan/parquet.rs
##
@@ -209,6 +251,479 @@ impl ParquetExec {
}
}
+#[derive(Debug, Clone)]
+/// Predi
codecov-io edited a comment on pull request #9122:
URL: https://github.com/apache/arrow/pull/9122#issuecomment-756042833
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9122?src=pr&el=h1) Report
> Merging
[#9122](https://codecov.io/gh/apache/arrow/pull/9122?src=pr&el=desc) (b3829c7)
andygrove commented on pull request #9149:
URL: https://github.com/apache/arrow/pull/9149#issuecomment-757364159
@alamb @jorgecarleitao fyi
This is an automated message from the Apache Git Service.
To respond to the message,
andygrove closed pull request #9149:
URL: https://github.com/apache/arrow/pull/9149
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jorgecarleitao closed pull request #9124:
URL: https://github.com/apache/arrow/pull/9124
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
bkietz commented on pull request #9131:
URL: https://github.com/apache/arrow/pull/9131#issuecomment-756820340
non-apache CI: https://github.com/bkietz/arrow/runs/1665173020
This is an automated message from the Apache Git Ser
mqy commented on a change in pull request #9137:
URL: https://github.com/apache/arrow/pull/9137#discussion_r554081674
##
File path: rust/arrow/src/ipc/compression.rs
##
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
ianmcook edited a comment on pull request #9143:
URL: https://github.com/apache/arrow/pull/9143#issuecomment-757016760
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
codecov-io edited a comment on pull request #9064:
URL: https://github.com/apache/arrow/pull/9064#issuecomment-753605727
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9064?src=pr&el=h1) Report
> Merging
[#9064](https://codecov.io/gh/apache/arrow/pull/9064?src=pr&el=desc) (5d7dda7)
michalursa commented on pull request #9134:
URL: https://github.com/apache/arrow/pull/9134#issuecomment-756913220
I'll address TaskGroup in
[ARROW-11191](https://issues.apache.org/jira/browse/ARROW-11191)
This is an automate
gangliao closed issue #9144:
URL: https://github.com/apache/arrow/issues/9144
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
kou commented on a change in pull request #9045:
URL: https://github.com/apache/arrow/pull/9045#discussion_r554201859
##
File path: run-cmake-format.py
##
@@ -21,58 +21,20 @@
import pathlib
import subprocess
import sys
+import argparse
+from pathlib import Path
Review comme
nevi-me commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757359551
@alamb @jorgecarleitao I see decent performance increases in benchmarks, but
because my device gets hot running the benchmarks, I'm opting to view them as
not too reliable.
mqy commented on pull request #9137:
URL: https://github.com/apache/arrow/pull/9137#issuecomment-756821780
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
terencehonles commented on a change in pull request #8916:
URL: https://github.com/apache/arrow/pull/8916#discussion_r554300596
##
File path: dev/tasks/python-wheels/win-build.bat
##
@@ -22,11 +22,19 @@
@rem --file=arrow\ci\conda_env_gandiva.yml ^
-@rem create conda enviro
romainfrancois commented on pull request #8650:
URL: https://github.com/apache/arrow/pull/8650#issuecomment-756833600
Now pulled in the commit from #8886 so that this uses `Converter::Extend()`
instead of the R specific previous `AppendRange()`.
I believe that for the chunker class
alamb closed pull request #9138:
URL: https://github.com/apache/arrow/pull/9138
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Dandandan commented on pull request #9116:
URL: https://github.com/apache/arrow/pull/9116#issuecomment-757006724
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
alamb commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756821495
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
github-actions[bot] commented on pull request #9140:
URL: https://github.com/apache/arrow/pull/9140#issuecomment-756893154
https://issues.apache.org/jira/browse/ARROW-11189
This is an automated message from the Apache Git Ser
sunchao commented on issue #9144:
URL: https://github.com/apache/arrow/issues/9144#issuecomment-757047671
@gangliao this should be fixed by #9138. Can you try again to see if the
issue is gone?
This is an automated message f
github-actions[bot] commented on pull request #9143:
URL: https://github.com/apache/arrow/pull/9143#issuecomment-757001158
https://issues.apache.org/jira/browse/ARROW-10463
This is an automated message from the Apache Git Ser
nevi-me commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756805692
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
westonpace commented on a change in pull request #8984:
URL: https://github.com/apache/arrow/pull/8984#discussion_r554217402
##
File path: cpp/src/arrow/array/array_dict.cc
##
@@ -44,6 +44,29 @@ namespace arrow {
using internal::checked_cast;
using internal::CopyBitmap;
+st
jorgecarleitao commented on pull request #9138:
URL: https://github.com/apache/arrow/pull/9138#issuecomment-756956898
Having a library version be set after a format version is funny, as it is
entirely possible to backward incompatibly change an API without backward
incompatibly change the
bkietz edited a comment on pull request #9141:
URL: https://github.com/apache/arrow/pull/9141#issuecomment-756923529
@nealrichardson not sure how to resolve those warnings. For example some of
them are supposed to be silenced but the compiler doesn't recognize the flag:
https://github.com/
kou commented on a change in pull request #9096:
URL: https://github.com/apache/arrow/pull/9096#discussion_r554240959
##
File path: docker-compose.yml
##
@@ -120,9 +117,113 @@ x-hierarchy:
# helper services
- impala
- postgres
+ - python-wheel-manylinux-2010
+ - pyth
1 - 100 of 195 matches
Mail list logo
