[GitHub] [arrow] cyb70289 commented on a change in pull request #8920: ARROW-10831: [C++][Compute] Implement quantile kernel

2021-01-11 Thread GitBox
cyb70289 commented on a change in pull request #8920: URL: https://github.com/apache/arrow/pull/8920#discussion_r61409 ## File path: cpp/src/arrow/compute/kernels/aggregate_test.cc ## @@ -1321,5 +1321,288 @@ TEST_F(TestVarStdKernelIntegerLength, Basics) { } #endif +// +

[GitHub] [arrow] RafayAK edited a comment on pull request #8491: ARROW-10349: [Python] linux aarch64 wheels

2021-01-11 Thread GitBox
RafayAK edited a comment on pull request #8491: URL: https://github.com/apache/arrow/pull/8491#issuecomment-753345204 So, PyArrow takes a colossal amount of time when building for `aarch64`, probably because it building from sources each time, and running the build in a CI with emulation o

[GitHub] [arrow] kou closed pull request #9145: ARROW-10777: [Packaging][Python] Build sdist by Crossbow

2021-01-11 Thread GitBox
kou closed pull request #9145: URL: https://github.com/apache/arrow/pull/9145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] kou commented on pull request #9145: ARROW-10777: [Packaging][Python] Build sdist by Crossbow

2021-01-11 Thread GitBox
kou commented on pull request #9145: URL: https://github.com/apache/arrow/pull/9145#issuecomment-758445695 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] kou closed pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

2021-01-11 Thread GitBox
kou closed pull request #9157: URL: https://github.com/apache/arrow/pull/9157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] kou commented on pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

2021-01-11 Thread GitBox
kou commented on pull request #9157: URL: https://github.com/apache/arrow/pull/9157#issuecomment-758443365 +1 The Java JNI failure is unrelated: https://github.com/apache/arrow/pull/9157/checks?check_run_id=1685053738#step:17:1 ```text Post job cleanup. /bin/tar -cz -f /hom

[GitHub] [arrow] github-actions[bot] commented on pull request #9173: ARROW-11219: [CI][Ruby][MinGW] Reduce CI time

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9173: URL: https://github.com/apache/arrow/pull/9173#issuecomment-758442695 https://issues.apache.org/jira/browse/ARROW-11219 This is an automated message from the Apache Git Ser

[GitHub] [arrow] kou opened a new pull request #9173: ARROW-11219: [CI][Ruby][MinGW] Reduce CI time

2021-01-11 Thread GitBox
kou opened a new pull request #9173: URL: https://github.com/apache/arrow/pull/9173 36m -> 12m This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] cyb70289 commented on a change in pull request #8920: ARROW-10831: [C++][Compute] Implement quantile kernel

2021-01-11 Thread GitBox
cyb70289 commented on a change in pull request #8920: URL: https://github.com/apache/arrow/pull/8920#discussion_r44079 ## File path: cpp/src/arrow/compute/kernels/aggregate_test.cc ## @@ -1321,5 +1321,288 @@ TEST_F(TestVarStdKernelIntegerLength, Basics) { } #endif +// +

[GitHub] [arrow] cyb70289 commented on a change in pull request #8920: ARROW-10831: [C++][Compute] Implement quantile kernel

2021-01-11 Thread GitBox
cyb70289 commented on a change in pull request #8920: URL: https://github.com/apache/arrow/pull/8920#discussion_r42914 ## File path: cpp/src/arrow/compute/kernels/aggregate_test.cc ## @@ -1321,5 +1321,288 @@ TEST_F(TestVarStdKernelIntegerLength, Basics) { } #endif +// +

[GitHub] [arrow] cyb70289 commented on a change in pull request #8920: ARROW-10831: [C++][Compute] Implement quantile kernel

2021-01-11 Thread GitBox
cyb70289 commented on a change in pull request #8920: URL: https://github.com/apache/arrow/pull/8920#discussion_r42052 ## File path: cpp/src/arrow/compute/kernels/aggregate_quantile.cc ## @@ -0,0 +1,296 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow] cyb70289 commented on a change in pull request #8920: ARROW-10831: [C++][Compute] Implement quantile kernel

2021-01-11 Thread GitBox
cyb70289 commented on a change in pull request #8920: URL: https://github.com/apache/arrow/pull/8920#discussion_r40576 ## File path: cpp/src/arrow/compute/kernels/aggregate_quantile.cc ## @@ -0,0 +1,296 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow] cyb70289 commented on a change in pull request #8920: ARROW-10831: [C++][Compute] Implement quantile kernel

2021-01-11 Thread GitBox
cyb70289 commented on a change in pull request #8920: URL: https://github.com/apache/arrow/pull/8920#discussion_r39172 ## File path: cpp/src/arrow/compute/kernels/aggregate_quantile.cc ## @@ -0,0 +1,296 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow] cyb70289 commented on a change in pull request #8920: ARROW-10831: [C++][Compute] Implement quantile kernel

2021-01-11 Thread GitBox
cyb70289 commented on a change in pull request #8920: URL: https://github.com/apache/arrow/pull/8920#discussion_r39123 ## File path: cpp/src/arrow/compute/kernels/aggregate_quantile.cc ## @@ -0,0 +1,296 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow] svjack opened a new issue #9172: Is Expression have decomposition methods ?

2021-01-11 Thread GitBox
svjack opened a new issue #9172: URL: https://github.com/apache/arrow/issues/9172 pyarrow.dataset.Expression seems support assume __invert__ and or , They all useful to construct with another expression. But what about decomposition to its components?

[GitHub] [arrow] nealrichardson commented on pull request #9171: ARROW-11218: [R] Make SubTreeFileSystem print method more informative

2021-01-11 Thread GitBox
nealrichardson commented on pull request #9171: URL: https://github.com/apache/arrow/pull/9171#issuecomment-758374100 Fun times, the S3 test fails on windows: https://github.com/apache/arrow/pull/9171/checks?check_run_id=1685548429#step:10:966 -

[GitHub] [arrow] nealrichardson closed pull request #9168: ARROW-10834: [R] Fix print method for SubTreeFileSystem

2021-01-11 Thread GitBox
nealrichardson closed pull request #9168: URL: https://github.com/apache/arrow/pull/9168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] nealrichardson closed pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-11 Thread GitBox
nealrichardson closed pull request #9143: URL: https://github.com/apache/arrow/pull/9143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] nealrichardson commented on pull request #9170: ARROW-11176: [R] Expose memory pool name and document setting it

2021-01-11 Thread GitBox
nealrichardson commented on pull request #9170: URL: https://github.com/apache/arrow/pull/9170#issuecomment-758371255 @github-actions rebase This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] nealrichardson closed pull request #9165: ARROW-11210: [CI] Restore workflows that had been blocked by INFRA

2021-01-11 Thread GitBox
nealrichardson closed pull request #9165: URL: https://github.com/apache/arrow/pull/9165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] github-actions[bot] commented on pull request #9171: ARROW-11218: [R] Make SubTreeFileSystem print method more informative

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9171: URL: https://github.com/apache/arrow/pull/9171#issuecomment-758363354 https://issues.apache.org/jira/browse/ARROW-11218 This is an automated message from the Apache Git Ser

[GitHub] [arrow] ianmcook opened a new pull request #9171: ARROW-11218: [R] Make SubTreeFileSystem print method more informative

2021-01-11 Thread GitBox
ianmcook opened a new pull request #9171: URL: https://github.com/apache/arrow/pull/9171 Adds a print method for `SubTreeFileSystem` objects that prints the scheme and path when the base file system is local or S3. This is a

[GitHub] [arrow] westonpace commented on pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

2021-01-11 Thread GitBox
westonpace commented on pull request #8984: URL: https://github.com/apache/arrow/pull/8984#issuecomment-758347141 @jorisvandenbossche It's pretty close but there are a few differences. - The pandas code allows the index type to expand (e.g. from uint8_t to uint16_t). In fact, it loo

[GitHub] [arrow] westonpace edited a comment on pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

2021-01-11 Thread GitBox
westonpace edited a comment on pull request #8984: URL: https://github.com/apache/arrow/pull/8984#issuecomment-758347141 @jorisvandenbossche It's pretty close but there are a few differences. - The pandas code allows the index type to expand (e.g. from uint8_t to uint16_t). In fact,

[GitHub] [arrow] github-actions[bot] commented on pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9157: URL: https://github.com/apache/arrow/pull/9157#issuecomment-758326299 Revision: 1806d481cad540d3f155eece06e85d8e4bb69947 Submitted crossbow builds: [ursa-labs/crossbow @ actions-874](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] kou commented on pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

2021-01-11 Thread GitBox
kou commented on pull request #9157: URL: https://github.com/apache/arrow/pull/9157#issuecomment-758317630 @github-actions crossbow submit centos-*-amd64 This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] codecov-io commented on pull request #9169: ARROW-11216: [Rust] add doc example for StringDictionaryBuilder

2021-01-11 Thread GitBox
codecov-io commented on pull request #9169: URL: https://github.com/apache/arrow/pull/9169#issuecomment-758317240 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9169?src=pr&el=h1) Report > Merging [#9169](https://codecov.io/gh/apache/arrow/pull/9169?src=pr&el=desc) (7ab19e3) into

[GitHub] [arrow] github-actions[bot] commented on pull request #9170: ARROW-11176: [R] Expose memory pool name and document setting it

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9170: URL: https://github.com/apache/arrow/pull/9170#issuecomment-758313538 https://issues.apache.org/jira/browse/ARROW-11176 This is an automated message from the Apache Git Ser

[GitHub] [arrow] github-actions[bot] commented on pull request #9169: ARROW-11216: [Rust] add doc example for StringDictionaryBuilder

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9169: URL: https://github.com/apache/arrow/pull/9169#issuecomment-758311714 https://issues.apache.org/jira/browse/ARROW-11216 This is an automated message from the Apache Git Ser

[GitHub] [arrow] nealrichardson commented on pull request #9170: ARROW-11176: [R] Expose memory pool name and document setting it

2021-01-11 Thread GitBox
nealrichardson commented on pull request #9170: URL: https://github.com/apache/arrow/pull/9170#issuecomment-758301990 @pitrou your review requested for the C++ change; you don't have to have an opinion about the R code (but you may!) ---

[GitHub] [arrow] kszucs removed a comment on pull request #9096: ARROW-11212: [Packaging][Python] Use vcpkg as dependency source for manylinux and windows wheels [WIP]

2021-01-11 Thread GitBox
kszucs removed a comment on pull request #9096: URL: https://github.com/apache/arrow/pull/9096#issuecomment-758282789 @github-actions crossbow -c ursacomputing/crossbow submit -g wheel This is an automated message from the Ap

[GitHub] [arrow] nealrichardson opened a new pull request #9170: ARROW-11176: [R] Expose memory pool name and document setting it

2021-01-11 Thread GitBox
nealrichardson opened a new pull request #9170: URL: https://github.com/apache/arrow/pull/9170 Also: * Exposes `SupportedBackendNames` from the C++ library (perhaps it should be renamed and include "memory" in it, was just following what the internal functions were calling it) so we

[GitHub] [arrow] github-actions[bot] commented on pull request #9168: ARROW-10834: [R] Fix print method for SubTreeFileSystem

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9168: URL: https://github.com/apache/arrow/pull/9168#issuecomment-758288034 https://issues.apache.org/jira/browse/ARROW-10834 This is an automated message from the Apache Git Ser

[GitHub] [arrow] github-actions[bot] commented on pull request #9096: ARROW-11212: [Packaging][Python] Use vcpkg as dependency source for manylinux and windows wheels

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9096: URL: https://github.com/apache/arrow/pull/9096#issuecomment-758287910 https://issues.apache.org/jira/browse/ARROW-11212 This is an automated message from the Apache Git Ser

[GitHub] [arrow] alamb opened a new pull request #9169: ARROW-11216: [Rust] add doc example for StringDictionaryBuilder

2021-01-11 Thread GitBox
alamb opened a new pull request #9169: URL: https://github.com/apache/arrow/pull/9169 I find myself trying to remember the exact incantation to create a `StringDictionaryBuilder` so I figured I would add it as a doc example

[GitHub] [arrow] kszucs commented on pull request #9096: ARROW-11212: [Packaging][Python] Use vcpkg as dependency source for manylinux and windows wheels

2021-01-11 Thread GitBox
kszucs commented on pull request #9096: URL: https://github.com/apache/arrow/pull/9096#issuecomment-758282789 @github-actions crossbow -c ursacomputing/crossbow submit -g wheel This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #9167: ARROW-11136: [R] Bindings for is.nan

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9167: URL: https://github.com/apache/arrow/pull/9167#issuecomment-758276517 https://issues.apache.org/jira/browse/ARROW-11136 This is an automated message from the Apache Git Ser

[GitHub] [arrow] alamb commented on pull request #9116: ARROW-11156: [Rust][DataFusion] Create hashes vectorized in hash join

2021-01-11 Thread GitBox
alamb commented on pull request #9116: URL: https://github.com/apache/arrow/pull/9116#issuecomment-758274127 Hi @Dandandan thanks ! I will try and review this over the next few days. This is an automated message from the Ap

[GitHub] [arrow] ovr commented on pull request #9114: ARROW-11149: [Rust] DF Support List/LargeList/FixedSizeList in create_batch_empty

2021-01-11 Thread GitBox
ovr commented on pull request #9114: URL: https://github.com/apache/arrow/pull/9114#issuecomment-758273338 @andygrove Can you take a look? Thanks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [arrow] alamb edited a comment on pull request #9163: ARROW-11209: [Rust] DF - Better error message on unsupported GROUP BY

2021-01-11 Thread GitBox
alamb edited a comment on pull request #9163: URL: https://github.com/apache/arrow/pull/9163#issuecomment-758272774 BTW @ovr I am not sure what type you were grouping on, but I had started working on support for String dictionary support for grouping but have gotten distracted. Just FYI -

[GitHub] [arrow] alamb commented on pull request #9163: ARROW-11209: [Rust] DF - Better error message on unsupported GROUP BY

2021-01-11 Thread GitBox
alamb commented on pull request #9163: URL: https://github.com/apache/arrow/pull/9163#issuecomment-758272774 BTW @ovr I am not sure what type you were grouping on, but I had started working on support for String dictionary support for grouping but have gotten distracted. --

[GitHub] [arrow] github-actions[bot] commented on pull request #9166: ARROW-10283: [Python] Define PY_SSIZE_T_CLEAN to deal with Python deprecation warning

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9166: URL: https://github.com/apache/arrow/pull/9166#issuecomment-758269890 https://issues.apache.org/jira/browse/ARROW-10283 This is an automated message from the Apache Git Ser

[GitHub] [arrow] ovr commented on pull request #9163: ARROW-11209: [Rust] DF - Better error message on unsupported GROUP BY

2021-01-11 Thread GitBox
ovr commented on pull request #9163: URL: https://github.com/apache/arrow/pull/9163#issuecomment-758269792 Thanks, @andygrove, for the notice. I've updated the description, and I will use a more useful description in my PRs.

[GitHub] [arrow] github-actions[bot] commented on pull request #9165: ARROW-11210: [CI] Restore workflows that had been blocked by INFRA

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9165: URL: https://github.com/apache/arrow/pull/9165#issuecomment-758266509 https://issues.apache.org/jira/browse/ARROW-11210 This is an automated message from the Apache Git Ser

[GitHub] [arrow] kszucs commented on pull request #9096: ARROW-11212: [Packaging][Python] Use vcpkg as dependency source for manylinux and windows wheels

2021-01-11 Thread GitBox
kszucs commented on pull request #9096: URL: https://github.com/apache/arrow/pull/9096#issuecomment-758265696 @github-actions crossbow -c ursacomputing/crossbow submit -g wheel This is an automated message from the Apache Git

[GitHub] [arrow] alamb commented on pull request #9123: ARROW-10917: [Doc] Update feature matrix for Rust

2021-01-11 Thread GitBox
alamb commented on pull request #9123: URL: https://github.com/apache/arrow/pull/9123#issuecomment-758265481 @nevi-me is this ready to go? I think the 3.0 release is just about to happen so we should probably merge it in soon (TM) -

[GitHub] [arrow] alamb edited a comment on pull request #9076: ARROW-11108: [Rust] Fixed performance issue in mutableBuffer.

2021-01-11 Thread GitBox
alamb edited a comment on pull request #9076: URL: https://github.com/apache/arrow/pull/9076#issuecomment-758263983 FWIW given the "touch most of the codepaths" property of this PR, it might be good to wait to merge this PR until after 3.0 is shipped (in the next few days) in case it intr

[GitHub] [arrow] alamb edited a comment on pull request #9076: ARROW-11108: [Rust] Fixed performance issue in mutableBuffer.

2021-01-11 Thread GitBox
alamb edited a comment on pull request #9076: URL: https://github.com/apache/arrow/pull/9076#issuecomment-758263983 FWIW given the "touch most of the codepaths" property of this PR, it might be good to wait to merge this PR until after 3.0 is shipped in case it introduces any subtle new b

[GitHub] [arrow] github-actions[bot] commented on pull request #9145: ARROW-10777: [Packaging][Python] Build sdist by Crossbow

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9145: URL: https://github.com/apache/arrow/pull/9145#issuecomment-758264034 Revision: 394084a7dabb5f02625d08355e7647d687e37b53 Submitted crossbow builds: [ursa-labs/crossbow @ actions-873](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] alamb commented on pull request #9076: ARROW-11108: [Rust] Fixed performance issue in mutableBuffer.

2021-01-11 Thread GitBox
alamb commented on pull request #9076: URL: https://github.com/apache/arrow/pull/9076#issuecomment-758263983 FWIW it might be good to wait to merge this PR until after 3.0 is shipped in case it introduces any subtle new bugs we would have longer to shake the out --

[GitHub] [arrow] github-actions[bot] commented on pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9157: URL: https://github.com/apache/arrow/pull/9157#issuecomment-758263630 Revision: 218829af712ca289fa70ed4193a4922e89d21ee2 Submitted crossbow builds: [ursa-labs/crossbow @ actions-872](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] alamb commented on pull request #9076: ARROW-11108: [Rust] Fixed performance issue in mutableBuffer.

2021-01-11 Thread GitBox
alamb commented on pull request #9076: URL: https://github.com/apache/arrow/pull/9076#issuecomment-758262159 I would also like to note that this is EPIC work @jorgecarleitao -- nicely done. This is an automated message from

[GitHub] [arrow] alamb commented on a change in pull request #9076: ARROW-11108: [Rust] Fixed performance issue in mutableBuffer.

2021-01-11 Thread GitBox
alamb commented on a change in pull request #9076: URL: https://github.com/apache/arrow/pull/9076#discussion_r555376474 ## File path: rust/arrow/src/compute/kernels/comparison.rs ## @@ -184,23 +180,33 @@ fn is_like_pattern(c: char) -> bool { pub fn like_utf8_scalar(left: &St

[GitHub] [arrow] andygrove commented on pull request #9156: ARROW-11201: [Rust][DataFusion] create_batch_empty - support more types

2021-01-11 Thread GitBox
andygrove commented on pull request #9156: URL: https://github.com/apache/arrow/pull/9156#issuecomment-758250978 @ovr Please update the PR description - if you look at other open PRs you can get a better idea for how these are normally written. These descriptions are important because they

[GitHub] [arrow] andygrove edited a comment on pull request #9163: ARROW-11209: [Rust] DF - Provider better error message on unsupported…

2021-01-11 Thread GitBox
andygrove edited a comment on pull request #9163: URL: https://github.com/apache/arrow/pull/9163#issuecomment-758249298 Hi @ovr could you write a more descriptive PR description? The PR description becomes the commit message when the PR is merged so we want it to explain exactly what the c

[GitHub] [arrow] andygrove commented on pull request #9163: ARROW-11209: [Rust] DF - Provider better error message on unsupported…

2021-01-11 Thread GitBox
andygrove commented on pull request #9163: URL: https://github.com/apache/arrow/pull/9163#issuecomment-758249298 Hi @ovr could you write a more description PR description? The PR description becomes the commit message when the PR is merged so we want it to explain exactly what the change i

[GitHub] [arrow] ianmcook commented on a change in pull request #9168: ARROW-10834: [R] Fix print method for SubTreeFileSystem

2021-01-11 Thread GitBox
ianmcook commented on a change in pull request #9168: URL: https://github.com/apache/arrow/pull/9168#discussion_r555361025 ## File path: r/R/filesystem.R ## @@ -418,10 +418,12 @@ SubTreeFileSystem$create <- function(base_path, base_fs = NULL) { `$.SubTreeFileSystem` <- functi

[GitHub] [arrow] kszucs commented on a change in pull request #9096: ARROW-11212: [Packaging][Python] Use vcpkg as dependency source for manylinux and windows wheels

2021-01-11 Thread GitBox
kszucs commented on a change in pull request #9096: URL: https://github.com/apache/arrow/pull/9096#discussion_r555358083 ## File path: .env ## @@ -18,6 +18,12 @@ # All of the following environment variables are required to set default values # for the parameters in docker-com

[GitHub] [arrow] alamb closed pull request #9139: ARROW-11188: [Rust] Support crypto functions from PostgreSQL dialect

2021-01-11 Thread GitBox
alamb closed pull request #9139: URL: https://github.com/apache/arrow/pull/9139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] alamb commented on pull request #9139: ARROW-11188: [Rust] Support crypto functions from PostgreSQL dialect

2021-01-11 Thread GitBox
alamb commented on pull request #9139: URL: https://github.com/apache/arrow/pull/9139#issuecomment-758243354 Thanks again for the contribution @ovr ! This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] kszucs commented on a change in pull request #9096: ARROW-11212: [Packaging][Python] Use vcpkg as dependency source for manylinux and windows wheels

2021-01-11 Thread GitBox
kszucs commented on a change in pull request #9096: URL: https://github.com/apache/arrow/pull/9096#discussion_r555358083 ## File path: .env ## @@ -18,6 +18,12 @@ # All of the following environment variables are required to set default values # for the parameters in docker-com

[GitHub] [arrow] alamb commented on pull request #9139: ARROW-11188: [Rust] Support crypto functions from PostgreSQL dialect

2021-01-11 Thread GitBox
alamb commented on pull request #9139: URL: https://github.com/apache/arrow/pull/9139#issuecomment-758242999 I filed https://issues.apache.org/jira/browse/ARROW-11214 to track the feature flag idea This is an automated messa

[GitHub] [arrow] ianmcook opened a new pull request #9168: ARROW-10834: [R] Fix print method for SubTreeFileSystem

2021-01-11 Thread GitBox
ianmcook opened a new pull request #9168: URL: https://github.com/apache/arrow/pull/9168 This PR modifies ``` `$.SubTreeFileSystem` ``` to return `NULL` if the named object is not found in the object. This allows the `print()` method of `ArrowObject` to print `SubTreeFileSystem` objects wi

[GitHub] [arrow] jonkeane commented on a change in pull request #9167: ARROW-11136: [R] Bindings for is.nan

2021-01-11 Thread GitBox
jonkeane commented on a change in pull request #9167: URL: https://github.com/apache/arrow/pull/9167#discussion_r555349558 ## File path: r/R/expression.R ## @@ -111,7 +111,8 @@ cast_array_expression <- function(x, to_type, safe = TRUE, ...) { .unary_function_map <- list(

[GitHub] [arrow] nealrichardson commented on a change in pull request #9167: ARROW-11136: [R] Bindings for is.nan

2021-01-11 Thread GitBox
nealrichardson commented on a change in pull request #9167: URL: https://github.com/apache/arrow/pull/9167#discussion_r555347689 ## File path: r/tests/testthat/test-dataset.R ## @@ -417,6 +417,17 @@ test_that("filter() with is.na()", { ) }) +test_that("filter() with is.na

[GitHub] [arrow] github-actions[bot] commented on pull request #9164: ARROW-10663: [C++] Fix is_in and index_in behaviour

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9164: URL: https://github.com/apache/arrow/pull/9164#issuecomment-758214764 https://issues.apache.org/jira/browse/ARROW-10663 This is an automated message from the Apache Git Ser

[GitHub] [arrow] jonkeane opened a new pull request #9167: ARROW-11136: [R] Bindings for is.nan

2021-01-11 Thread GitBox
jonkeane opened a new pull request #9167: URL: https://github.com/apache/arrow/pull/9167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] github-actions[bot] commented on pull request #9163: ARROW-11209: [Rust] DF - Provider better error message on unsupported…

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #9163: URL: https://github.com/apache/arrow/pull/9163#issuecomment-758202435 https://issues.apache.org/jira/browse/ARROW-11209 This is an automated message from the Apache Git Ser

[GitHub] [arrow] xhochy commented on pull request #8878: ARROW-10861: [Python] Update minimal NumPy version to 1.16.6

2021-01-11 Thread GitBox
xhochy commented on pull request #8878: URL: https://github.com/apache/arrow/pull/8878#issuecomment-758190980 Oh yes, definitely! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] jorisvandenbossche commented on pull request #8878: ARROW-10861: [Python] Update minimal NumPy version to 1.16.6

2021-01-11 Thread GitBox
jorisvandenbossche commented on pull request #8878: URL: https://github.com/apache/arrow/pull/8878#issuecomment-758190349 @xhochy do we still want to do this for pyarrow 3.0 ? This is an automated message from the Apache Git

[GitHub] [arrow] jorisvandenbossche commented on pull request #9166: ARROW-10283: [Python] Define PY_SSIZE_T_CLEAN to deal with Python deprecation warning

2021-01-11 Thread GitBox
jorisvandenbossche commented on pull request #9166: URL: https://github.com/apache/arrow/pull/9166#issuecomment-758189723 See 4th bullet point at https://docs.python.org/3/whatsnew/3.8.html#changes-in-the-c-api / first note box at https://docs.python.org/3/c-api/arg.html#strings-and-buffer

[GitHub] [arrow] jorisvandenbossche opened a new pull request #9166: ARROW-10283: [Python] Define PY_SSIZE_T_CLEAN to deal with Python deprecation warning

2021-01-11 Thread GitBox
jorisvandenbossche opened a new pull request #9166: URL: https://github.com/apache/arrow/pull/9166 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] nealrichardson opened a new pull request #9165: ARROW-11210: [CI] Restore workflows that had been blocked by INFRA

2021-01-11 Thread GitBox
nealrichardson opened a new pull request #9165: URL: https://github.com/apache/arrow/pull/9165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] nealrichardson commented on pull request #9121: ARROW-11158: [Julia] Implement Decimal256 support for Julia

2021-01-11 Thread GitBox
nealrichardson commented on pull request #9121: URL: https://github.com/apache/arrow/pull/9121#issuecomment-758184038 @quinnj if you rebase (or push additional changes), the Julia CI should be re-enabled. This is an automate

[GitHub] [arrow] ianmcook commented on a change in pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-11 Thread GitBox
ianmcook commented on a change in pull request #9143: URL: https://github.com/apache/arrow/pull/9143#discussion_r555297933 ## File path: r/tests/testthat/test-dataset.R ## @@ -303,11 +303,68 @@ test_that("Other text delimited dataset", { filter(integer > 6) %>% su

[GitHub] [arrow] kou commented on pull request #9145: ARROW-10777: [Packaging][Python] Build sdist by Crossbow

2021-01-11 Thread GitBox
kou commented on pull request #9145: URL: https://github.com/apache/arrow/pull/9145#issuecomment-758183258 @github-actions crossbow submit -g packaging This is an automated message from the Apache Git Service. To respond to t

[GitHub] [arrow] kou commented on pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

2021-01-11 Thread GitBox
kou commented on pull request #9157: URL: https://github.com/apache/arrow/pull/9157#issuecomment-758181943 @github-actions crossbow submit centos-*-amd64 This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] kou closed pull request #9158: ARROW-11205: [GLib][Dataset] Add GADFileFormat and its family

2021-01-11 Thread GitBox
kou closed pull request #9158: URL: https://github.com/apache/arrow/pull/9158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] kou commented on pull request #9158: ARROW-11205: [GLib][Dataset] Add GADFileFormat and its family

2021-01-11 Thread GitBox
kou commented on pull request #9158: URL: https://github.com/apache/arrow/pull/9158#issuecomment-758177804 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] nealrichardson closed pull request #9118: ARROW-10623: [CI][R] Version 1.0.1 breaks data.frame attributes when reading file written by 2.0.0

2021-01-11 Thread GitBox
nealrichardson closed pull request #9118: URL: https://github.com/apache/arrow/pull/9118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] nealrichardson commented on a change in pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-11 Thread GitBox
nealrichardson commented on a change in pull request #9143: URL: https://github.com/apache/arrow/pull/9143#discussion_r555288000 ## File path: r/tests/testthat/test-dataset.R ## @@ -303,11 +303,68 @@ test_that("Other text delimited dataset", { filter(integer > 6) %>%

[GitHub] [arrow] nealrichardson closed pull request #8833: ARROW-10803: Support R >= 3.3 and add CI

2021-01-11 Thread GitBox
nealrichardson closed pull request #8833: URL: https://github.com/apache/arrow/pull/8833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] pitrou commented on a change in pull request #9140: ARROW-11189: [Developer] support benchmark diff between JSONs

2021-01-11 Thread GitBox
pitrou commented on a change in pull request #9140: URL: https://github.com/apache/arrow/pull/9140#discussion_r555286272 ## File path: ci/conda_env_archery.yml ## @@ -15,8 +15,28 @@ # specific language governing permissions and limitations # under the License. +# cli click

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #9130: ARROW-10247: [C++][Dataset] Support writing datasets partitioned on dictionary columns

2021-01-11 Thread GitBox
jorisvandenbossche commented on a change in pull request #9130: URL: https://github.com/apache/arrow/pull/9130#discussion_r555285509 ## File path: cpp/src/arrow/dataset/partition.cc ## @@ -562,6 +569,8 @@ inline Result> CountsToOffsets( // since no Writers accept a selection v

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #9130: ARROW-10247: [C++][Dataset] Support writing datasets partitioned on dictionary columns

2021-01-11 Thread GitBox
jorisvandenbossche commented on a change in pull request #9130: URL: https://github.com/apache/arrow/pull/9130#discussion_r555275756 ## File path: cpp/src/arrow/dataset/partition.h ## @@ -288,16 +288,58 @@ class ARROW_DS_EXPORT PartitioningOrFactory { /// \brief Assemble lists

[GitHub] [arrow] nealrichardson commented on a change in pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-11 Thread GitBox
nealrichardson commented on a change in pull request #9143: URL: https://github.com/apache/arrow/pull/9143#discussion_r555280727 ## File path: r/tests/testthat/test-dataset.R ## @@ -303,11 +303,68 @@ test_that("Other text delimited dataset", { filter(integer > 6) %>%

[GitHub] [arrow] pitrou opened a new pull request #9164: ARROW-10663: [C++] Fix is_in and index_in behaviour

2021-01-11 Thread GitBox
pitrou opened a new pull request #9164: URL: https://github.com/apache/arrow/pull/9164 * Reject duplicates in SetLookupOptions::value_set, because otherwise the indices returned by index_in would be relative to a deduplicated value_set. * Honour SetLookup::skip_nulls in is_in.

[GitHub] [arrow] pitrou commented on a change in pull request #9130: ARROW-10247: [C++][Dataset] Support writing datasets partitioned on dictionary columns

2021-01-11 Thread GitBox
pitrou commented on a change in pull request #9130: URL: https://github.com/apache/arrow/pull/9130#discussion_r555279313 ## File path: cpp/src/arrow/dataset/partition.cc ## @@ -562,6 +569,8 @@ inline Result> CountsToOffsets( // since no Writers accept a selection vector. clas

[GitHub] [arrow] github-actions[bot] commented on pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

2021-01-11 Thread GitBox
github-actions[bot] commented on pull request #8916: URL: https://github.com/apache/arrow/pull/8916#issuecomment-758162702 Revision: c532cd17b37c4a2a43052d926d1717d42d10be9d Submitted crossbow builds: [ursa-labs/crossbow @ actions-871](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] ovr opened a new pull request #9163: ARROW-11209: [Rust] DF - Provider better error message on unsupported…

2021-01-11 Thread GitBox
ovr opened a new pull request #9163: URL: https://github.com/apache/arrow/pull/9163 … GROUP BY Hello! Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #9130: ARROW-10247: [C++][Dataset] Support writing datasets partitioned on dictionary columns

2021-01-11 Thread GitBox
jorisvandenbossche commented on a change in pull request #9130: URL: https://github.com/apache/arrow/pull/9130#discussion_r555273007 ## File path: cpp/src/arrow/dataset/partition.cc ## @@ -562,6 +569,8 @@ inline Result> CountsToOffsets( // since no Writers accept a selection v

[GitHub] [arrow] pitrou commented on a change in pull request #9130: ARROW-10247: [C++][Dataset] Support writing datasets partitioned on dictionary columns

2021-01-11 Thread GitBox
pitrou commented on a change in pull request #9130: URL: https://github.com/apache/arrow/pull/9130#discussion_r555271701 ## File path: cpp/src/arrow/dataset/partition.cc ## @@ -562,6 +569,8 @@ inline Result> CountsToOffsets( // since no Writers accept a selection vector. clas

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #9130: ARROW-10247: [C++][Dataset] Support writing datasets partitioned on dictionary columns

2021-01-11 Thread GitBox
jorisvandenbossche commented on a change in pull request #9130: URL: https://github.com/apache/arrow/pull/9130#discussion_r555270347 ## File path: cpp/src/arrow/dataset/partition.cc ## @@ -562,6 +569,8 @@ inline Result> CountsToOffsets( // since no Writers accept a selection v

[GitHub] [arrow] jorisvandenbossche commented on pull request #9161: ARROW-11049: [Python] Expose alternate memory pools

2021-01-11 Thread GitBox
jorisvandenbossche commented on pull request #9161: URL: https://github.com/apache/arrow/pull/9161#issuecomment-758151625 Looks good, no comments on the Python code. Maybe not critical for *this* PR, but I have some suggestions (or questions) for expanded docs: - I would add some mor

[GitHub] [arrow] westonpace commented on a change in pull request #9095: ARROW-10183: [C++] Apply composable futures to CSV

2021-01-11 Thread GitBox
westonpace commented on a change in pull request #9095: URL: https://github.com/apache/arrow/pull/9095#discussion_r555266265 ## File path: cpp/src/arrow/util/future_test.cc ## @@ -832,6 +832,145 @@ TEST(FutureCompletionTest, FutureVoid) { } } +TEST(FutureAllTest, Simple)

[GitHub] [arrow] pitrou commented on a change in pull request #9161: ARROW-11049: [Python] Expose alternate memory pools

2021-01-11 Thread GitBox
pitrou commented on a change in pull request #9161: URL: https://github.com/apache/arrow/pull/9161#discussion_r555265463 ## File path: python/pyarrow/tests/test_memory.py ## @@ -133,3 +133,24 @@ def test_env_var(): if should_have_mimalloc: check_env_var("mimalloc"

[GitHub] [arrow] jjbskir commented on a change in pull request #9142: ARROW-11193: [Java][Documentation] Add Java ListVector Documentation

2021-01-11 Thread GitBox
jjbskir commented on a change in pull request #9142: URL: https://github.com/apache/arrow/pull/9142#discussion_r555264027 ## File path: docs/source/java/vector.rst ## @@ -217,6 +217,55 @@ to be declared is that writer/reader is not as efficient as direct access } }

[GitHub] [arrow] kszucs commented on a change in pull request #9161: ARROW-11049: [Python] Expose alternate memory pools

2021-01-11 Thread GitBox
kszucs commented on a change in pull request #9161: URL: https://github.com/apache/arrow/pull/9161#discussion_r555263751 ## File path: python/pyarrow/tests/test_memory.py ## @@ -133,3 +133,24 @@ def test_env_var(): if should_have_mimalloc: check_env_var("mimalloc"

[GitHub] [arrow] kszucs commented on a change in pull request #9161: ARROW-11049: [Python] Expose alternate memory pools

2021-01-11 Thread GitBox
kszucs commented on a change in pull request #9161: URL: https://github.com/apache/arrow/pull/9161#discussion_r555263751 ## File path: python/pyarrow/tests/test_memory.py ## @@ -133,3 +133,24 @@ def test_env_var(): if should_have_mimalloc: check_env_var("mimalloc"

[GitHub] [arrow] ianmcook commented on a change in pull request #9143: ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset

2021-01-11 Thread GitBox
ianmcook commented on a change in pull request #9143: URL: https://github.com/apache/arrow/pull/9143#discussion_r554441947 ## File path: r/tests/testthat/test-dataset.R ## @@ -303,11 +303,54 @@ test_that("Other text delimited dataset", { filter(integer > 6) %>% su

  1   2   >