codecov-io commented on pull request #9243:
URL: https://github.com/apache/arrow/pull/9243#issuecomment-764451929
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9243?src=pr&el=h1) Report
> Merging
[#9243](https://codecov.io/gh/apache/arrow/pull/9243?src=pr&el=desc) (64abbc5)
into
seddonm1 commented on a change in pull request #9243:
URL: https://github.com/apache/arrow/pull/9243#discussion_r561653478
##
File path: rust/datafusion/src/physical_plan/string_expressions.rs
##
@@ -34,42 +34,446 @@ macro_rules! downcast_vec {
}};
}
-/// concatenate st
jorgecarleitao commented on pull request #9281:
URL: https://github.com/apache/arrow/pull/9281#issuecomment-764422417
@ovr, this is what I was trying to express in your PR: we can use
`ArrayData` directly and thereby support arbitrary nested types.
github-actions[bot] commented on pull request #9281:
URL: https://github.com/apache/arrow/pull/9281#issuecomment-764412043
https://issues.apache.org/jira/browse/ARROW-11333
This is an automated message from the Apache Git Ser
jorgecarleitao opened a new pull request #9281:
URL: https://github.com/apache/arrow/pull/9281
# Rational
Creating an empty array was scattered around parquet, arrow and datafusion
crates, mostly derived from need. Recently, #9156 harmonized some of that for
list arrays.
However
jorgecarleitao commented on a change in pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#discussion_r561618199
##
File path: rust/arrow/src/array/array_primitive.rs
##
@@ -86,13 +86,9 @@ impl PrimitiveArray {
}
/// Returns the primitive value at in
jorgecarleitao commented on a change in pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#discussion_r561618199
##
File path: rust/arrow/src/array/array_primitive.rs
##
@@ -86,13 +86,9 @@ impl PrimitiveArray {
}
/// Returns the primitive value at in
jorgecarleitao commented on a change in pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#discussion_r561618199
##
File path: rust/arrow/src/array/array_primitive.rs
##
@@ -86,13 +86,9 @@ impl PrimitiveArray {
}
/// Returns the primitive value at in
jorgecarleitao commented on a change in pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#discussion_r561618199
##
File path: rust/arrow/src/array/array_primitive.rs
##
@@ -86,13 +86,9 @@ impl PrimitiveArray {
}
/// Returns the primitive value at in
codecov-io edited a comment on pull request #9122:
URL: https://github.com/apache/arrow/pull/9122#issuecomment-756042833
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9122?src=pr&el=h1) Report
> Merging
[#9122](https://codecov.io/gh/apache/arrow/pull/9122?src=pr&el=desc) (8ccc5bd)
nevi-me commented on pull request #9122:
URL: https://github.com/apache/arrow/pull/9122#issuecomment-764332590
> @nevi-me is this one ready to merge? Should we rebase it against latest
master and rerun the checks? Or I can merge it in as is too
I've rebased, and changed a few comment
codecov-io edited a comment on pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#issuecomment-761864117
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9235?src=pr&el=h1) Report
> Merging
[#9235](https://codecov.io/gh/apache/arrow/pull/9235?src=pr&el=desc) (f5413b1)
codecov-io edited a comment on pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#issuecomment-761864117
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9235?src=pr&el=h1) Report
> Merging
[#9235](https://codecov.io/gh/apache/arrow/pull/9235?src=pr&el=desc) (2b5cc6a)
cyb70289 commented on a change in pull request #9280:
URL: https://github.com/apache/arrow/pull/9280#discussion_r561589436
##
File path: cpp/src/arrow/compute/internals_benchmark.cc
##
@@ -0,0 +1,86 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
cyb70289 commented on a change in pull request #9280:
URL: https://github.com/apache/arrow/pull/9280#discussion_r561589279
##
File path: cpp/src/arrow/compute/internals_benchmark.cc
##
@@ -0,0 +1,86 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
cyb70289 commented on pull request #9274:
URL: https://github.com/apache/arrow/pull/9274#issuecomment-764217852
> @cyb70289 `arrow::dataset::Expression::Call::options` requires that
virtual destructor since a `shared_ptr` is used to store
subclasses of FunctionOptions. Removing this virtua
liyafan82 commented on pull request #9187:
URL: https://github.com/apache/arrow/pull/9187#issuecomment-764200223
> @liyafan82 But, I don't agree. See this section comment in source code:
>
https://github.com/apache/arrow/blob/691286975f277f00586cabc6d834ff1efd8caf8c/java/vector/src/main/
mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r561521360
##
File path: cpp/src/arrow/adapters/orc/adapter_util.cc
##
@@ -316,10 +326,482 @@ Status AppendBatch(const liborc::Type* type,
liborc::ColumnVectorBa
mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r561520934
##
File path: cpp/src/arrow/adapters/orc/adapter_util.cc
##
@@ -316,10 +326,482 @@ Status AppendBatch(const liborc::Type* type,
liborc::ColumnVectorBa
mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r561520435
##
File path: cpp/src/arrow/adapters/orc/adapter_util.cc
##
@@ -40,15 +44,21 @@ namespace orc {
using internal::checked_cast;
-// The number of na
liyafan82 commented on pull request #9187:
URL: https://github.com/apache/arrow/pull/9187#issuecomment-764197687
> @liyafan82, does it imply that `setValueCount` should always be called
before `vector.getBufferSizeFor` to have the guaranteed result without failure?
It would be great if we
codecov-io edited a comment on pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#issuecomment-761621256
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9215?src=pr&el=h1) Report
> Merging
[#9215](https://codecov.io/gh/apache/arrow/pull/9215?src=pr&el=desc) (5cd8075)
WeichenXu123 edited a comment on pull request #9187:
URL: https://github.com/apache/arrow/pull/9187#issuecomment-763540715
> In a streaming scenario, in which you fill up batches up to a given size,
you need to check the buffer size without actually closing the batch.
Yes. and I thi
tyrelr commented on pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#issuecomment-764164139
Rebased. But I didn't hit the merge conflicts during... I can see that a
number of tests were swapped to use Buffer::from_slice_ref()... so I'll add
another commit to switch to t
github-actions[bot] commented on pull request #9280:
URL: https://github.com/apache/arrow/pull/9280#issuecomment-764142561
https://issues.apache.org/jira/browse/ARROW-8928
This is an automated message from the Apache Git Serv
wesm opened a new pull request #9280:
URL: https://github.com/apache/arrow/pull/9280
These are only preliminary benchmarks but may help in examining
microperformance overhead related to `ExecBatch` and its implementation (as a
`vector`).
It may be desirable to devise an "array refer
rtyler commented on a change in pull request #9240:
URL: https://github.com/apache/arrow/pull/9240#discussion_r561361029
##
File path: rust/parquet/src/arrow/array_reader.rs
##
@@ -912,11 +912,36 @@ impl ArrayReader for
ListArrayReader {
));
}
-
mathyingzhou edited a comment on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-764050107
> I didn't see anything rust related in this PR so I removed the Rust label
@alamb Thanks! There is nothing parquet-related in this PR either. Can the
parquet la
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-764050107
> I didn't see anything rust related in this PR so I removed the Rust label
@alamb Sorry it didn’t appear in the right place but there is nothing
parquet-related in thi
mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r561405645
##
File path: cpp/src/arrow/adapters/orc/adapter_test.cc
##
@@ -157,4 +225,2478 @@ TEST(TestAdapter, readIntAndStringFileMultipleStripes) {
EXPECT
alamb commented on a change in pull request #9278:
URL: https://github.com/apache/arrow/pull/9278#discussion_r561366255
##
File path: rust/datafusion/src/logical_plan/expr.rs
##
@@ -422,6 +422,136 @@ impl Expr {
nulls_first,
}
}
+
+/// Performs a
alamb commented on pull request #9278:
URL: https://github.com/apache/arrow/pull/9278#issuecomment-764011355
Thanks @jorgecarleitao and @Dandandan . I am personally quite excited at
using this same idea for expression rewriting.
--
Dandandan commented on a change in pull request #9279:
URL: https://github.com/apache/arrow/pull/9279#discussion_r561307105
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -423,7 +423,7 @@ where
let mut offsets_buffer = MutableBuffer::from_len_zeroed(bytes_offse
Dandandan commented on pull request #9279:
URL: https://github.com/apache/arrow/pull/9279#issuecomment-763951458
I think a nice followup for `take_string` would maybe be looking into using
the offsets data to calculate the total length of the buffer to allocate, which
should be pretty fast
Dandandan commented on a change in pull request #9279:
URL: https://github.com/apache/arrow/pull/9279#discussion_r561307105
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -423,7 +423,7 @@ where
let mut offsets_buffer = MutableBuffer::from_len_zeroed(bytes_offse
kou commented on pull request #9155:
URL: https://github.com/apache/arrow/pull/9155#issuecomment-763948236
Great!
Can we only build Java packages(*) without publishing to the Maven Central
Repository for testing? For example, our nightly Gandiva for Java builds[1]
just build `*.jar`
github-actions[bot] commented on pull request #9279:
URL: https://github.com/apache/arrow/pull/9279#issuecomment-763944867
https://issues.apache.org/jira/browse/ARROW-11332
This is an automated message from the Apache Git Ser
Dandandan opened a new pull request #9279:
URL: https://github.com/apache/arrow/pull/9279
This PR changes take string to use `MutableBuffer` to create a byte array
directly instead of converting it from a `Vec`.
There used to be some overhead compared to using a `Vec` and converting it
andygrove commented on pull request #9155:
URL: https://github.com/apache/arrow/pull/9155#issuecomment-763939243
>
>
> Sorry for my late response.
>
> We have a post manual(!) task that publishes Java packages to the Maven
Central Repository:
https://cwiki.apache.org/conflue
kou commented on pull request #9155:
URL: https://github.com/apache/arrow/pull/9155#issuecomment-763933322
Sorry for my late response.
We have a post manual(!) task that publishes Java packages to the Maven
Central Repository:
https://cwiki.apache.org/confluence/display/ARROW/Releas
jorgecarleitao edited a comment on pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#issuecomment-763898758
I made a mistake in benchmarking and have to retract my statement. I am
really sorry for the noise. :(
I mistakenly updated the wrong part of the code before r
andygrove commented on pull request #9278:
URL: https://github.com/apache/arrow/pull/9278#issuecomment-763902393
I just wanted to add that there is no need to wait for me to review before
merging.
This is an automated messag
jorgecarleitao commented on pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#issuecomment-763898758
I made a mistake in benchmarking and have to retract my statement. I am
really sorry for the noise. :(
I mistakenly updated the wrong part of the code before running
mbrubeck commented on a change in pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#discussion_r561239323
##
File path: rust/arrow/src/buffer.rs
##
@@ -963,11 +968,131 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0u8`, i
mbrubeck commented on a change in pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#discussion_r561239323
##
File path: rust/arrow/src/buffer.rs
##
@@ -963,11 +968,131 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0u8`, i
mbrubeck commented on a change in pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#discussion_r561239323
##
File path: rust/arrow/src/buffer.rs
##
@@ -963,11 +968,131 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0u8`, i
codecov-io edited a comment on pull request #9276:
URL: https://github.com/apache/arrow/pull/9276#issuecomment-763672876
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9276?src=pr&el=h1) Report
> Merging
[#9276](https://codecov.io/gh/apache/arrow/pull/9276?src=pr&el=desc) (07d8ce8)
jorgecarleitao commented on a change in pull request #9278:
URL: https://github.com/apache/arrow/pull/9278#discussion_r561229060
##
File path: rust/datafusion/src/logical_plan/expr.rs
##
@@ -422,6 +422,136 @@ impl Expr {
nulls_first,
}
}
+
+/// Pe
andygrove commented on pull request #9278:
URL: https://github.com/apache/arrow/pull/9278#issuecomment-763885202
I took a quick look and this looks good to me. I will try and review in more
detail tonight.
This is an automat
mbrubeck commented on pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#issuecomment-763880774
> When we commit to master we squash all commits. Would you be willing to
take credit for this whole PR + your changes?
I think it would be more appropriate to keep your na
jorgecarleitao commented on pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#issuecomment-763878812
I validated that with @mbrubeck 's change, we can just use `collect` and
drop the `trusted_len` and `unsafe` hack with the same performance on the
arithmetics 🎉 🎉🎉
@
mbrubeck edited a comment on pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#issuecomment-763846523
I was able to speed up the fast path of `extend_from_iter` by a few percent,
by splitting the loop into two parts. This version is only about 8% slower
than `extend_from_
mbrubeck edited a comment on pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#issuecomment-763846523
I was able to speed up the fast path of `extend_from_iter` by a few percent,
by splitting the loop into two parts. This version is only about 8% slower
than `extend_from_
github-actions[bot] commented on pull request #9278:
URL: https://github.com/apache/arrow/pull/9278#issuecomment-763867008
https://issues.apache.org/jira/browse/ARROW-11330
This is an automated message from the Apache Git Ser
alamb commented on a change in pull request #9278:
URL: https://github.com/apache/arrow/pull/9278#discussion_r561197743
##
File path: rust/datafusion/src/optimizer/utils.rs
##
@@ -46,75 +50,48 @@ pub fn exprlist_to_column_names(
/// Recursively walk an expression tree, colle
alamb opened a new pull request #9278:
URL: https://github.com/apache/arrow/pull/9278
## Problem:
* There are several places in the DataFusion codebase where a walk of an
Expression tree is needed
* The logic of how to walk the tree is replicated
* Adding new expression types often
mbrubeck commented on pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#issuecomment-763846523
I was able to speed up the fast path of `extend_from_iter` by a few percent,
by splitting the loop into two parts. This version is only about 8% slower
than `extend_from_trusted
jorgecarleitao closed pull request #9277:
URL: https://github.com/apache/arrow/pull/9277
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
github-actions[bot] removed a comment on pull request #9277:
URL: https://github.com/apache/arrow/pull/9277#issuecomment-763808991
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Th
alamb closed pull request #9114:
URL: https://github.com/apache/arrow/pull/9114
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb edited a comment on pull request #9114:
URL: https://github.com/apache/arrow/pull/9114#issuecomment-763838115
The travis CI run is backed up --
https://github.com/apache/arrow/pull/9114/checks?check_run_id=1735587739 hasn't
finished -- and this PR has no non-rust changes. I think it
alamb commented on pull request #9114:
URL: https://github.com/apache/arrow/pull/9114#issuecomment-763838115
The travis CI run is backed up -- and this PR has no non-rust changes. I
think it is good to go
This is an automate
alamb commented on pull request #9114:
URL: https://github.com/apache/arrow/pull/9114#issuecomment-763837298
Awesome -- thanks @ovr !
This is an automated message from the Apache Git Service.
To respond to the message, please
bkietz commented on pull request #9274:
URL: https://github.com/apache/arrow/pull/9274#issuecomment-763833521
I think the best way to resolve this issue is to avoid direct instances of
derived classes of FunctionOptions in Cython, since Cython inappropriately
applies `offsetof`. For exampl
jorgecarleitao commented on a change in pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#discussion_r561163855
##
File path: rust/arrow/src/buffer.rs
##
@@ -963,11 +968,131 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0
jorgecarleitao commented on a change in pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#discussion_r561163855
##
File path: rust/arrow/src/buffer.rs
##
@@ -963,11 +968,131 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0
jorgecarleitao commented on a change in pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#discussion_r561163855
##
File path: rust/arrow/src/buffer.rs
##
@@ -963,11 +968,131 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0
codecov-io commented on pull request #9277:
URL: https://github.com/apache/arrow/pull/9277#issuecomment-763823687
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9277?src=pr&el=h1) Report
> Merging
[#9277](https://codecov.io/gh/apache/arrow/pull/9277?src=pr&el=desc) (c636cf1)
into
bkietz commented on pull request #9274:
URL: https://github.com/apache/arrow/pull/9274#issuecomment-763823491
@cyb70289 `arrow::dataset::Expression::Call::options` requires that virtual
destructor since a `shared_ptr` is used to store subclasses of
FunctionOptions. Removing this virtual de
github-actions[bot] commented on pull request #9277:
URL: https://github.com/apache/arrow/pull/9277#issuecomment-763817914
https://issues.apache.org/jira/browse/ARROW-11329
This is an automated message from the Apache Git Ser
github-actions[bot] commented on pull request #9277:
URL: https://github.com/apache/arrow/pull/9277#issuecomment-763808991
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
mqy commented on a change in pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#discussion_r561133856
##
File path: rust/arrow/src/buffer.rs
##
@@ -1008,7 +1008,7 @@ impl MutableBuffer {
let mut dst = unsafe { ptr.as_ptr().add(len) as *mut T };
mbrubeck opened a new pull request #9277:
URL: https://github.com/apache/arrow/pull/9277
This speeds up development by avoiding rebuilding the whole library
when any file in the package directory is touched.
This is an aut
mbrubeck commented on a change in pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#discussion_r561128399
##
File path: rust/arrow/src/buffer.rs
##
@@ -963,11 +968,131 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0u8`, i
mqy commented on pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#issuecomment-763763668
> Looks like there is an error in the SIMD tests
https://github.com/apache/arrow/pull/9235/checks?
`cargo test --doc --package arrow --
buffer::MutableBuffer::extend_from_trust
mqy commented on a change in pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#discussion_r561038192
##
File path: rust/arrow/src/buffer.rs
##
@@ -963,11 +968,130 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0u8`, increm
mqy commented on a change in pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#discussion_r561038192
##
File path: rust/arrow/src/buffer.rs
##
@@ -963,11 +968,130 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0u8`, increm
mqy commented on a change in pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#discussion_r561038192
##
File path: rust/arrow/src/buffer.rs
##
@@ -963,11 +968,130 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0u8`, increm
ovr commented on pull request #9114:
URL: https://github.com/apache/arrow/pull/9114#issuecomment-763672988
@alamb Rebased + renamed NYI -> `NotYetImplemented` in Arrow. Thanks
This is an automated message from the Apache Git
codecov-io commented on pull request #9276:
URL: https://github.com/apache/arrow/pull/9276#issuecomment-763672876
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9276?src=pr&el=h1) Report
> Merging
[#9276](https://codecov.io/gh/apache/arrow/pull/9276?src=pr&el=desc) (47bf88b)
into
codecov-io commented on pull request #9271:
URL: https://github.com/apache/arrow/pull/9271#issuecomment-763660623
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9271?src=pr&el=h1) Report
> Merging
[#9271](https://codecov.io/gh/apache/arrow/pull/9271?src=pr&el=desc) (9933c7b)
into
alamb commented on pull request #9235:
URL: https://github.com/apache/arrow/pull/9235#issuecomment-763651758
Looks like there is an error in the SIMD tests
https://github.com/apache/arrow/pull/9235/checks?check_run_id=1733044845
```
failures:
src/buffer.rs - buffer
github-actions[bot] commented on pull request #9276:
URL: https://github.com/apache/arrow/pull/9276#issuecomment-763648633
https://issues.apache.org/jira/browse/ARROW-11327
This is an automated message from the Apache Git Ser
Dandandan commented on pull request #9271:
URL: https://github.com/apache/arrow/pull/9271#issuecomment-763646185
This PR in itself is ready for review now. The change in approach will help
us in the future, even more with `Array.slice` being improved (will create a
ticket later), execution
alamb commented on a change in pull request #9276:
URL: https://github.com/apache/arrow/pull/9276#discussion_r561003845
##
File path: rust/datafusion/src/physical_plan/common.rs
##
@@ -121,121 +128,130 @@ pub fn build_file_list(dir: &str, filenames: &mut
Vec, ext: &str) -> Res
alamb opened a new pull request #9276:
URL: https://github.com/apache/arrow/pull/9276
The `create_batch_empty` function is used for creating output during
aggregation. As part of my plan for better dictionary support it also needs to
support DictionaryArray as well.
I think this may
alamb commented on a change in pull request #9275:
URL: https://github.com/apache/arrow/pull/9275#discussion_r560979269
##
File path: rust/datafusion/src/physical_plan/sort.rs
##
@@ -141,7 +141,10 @@ fn sort_batches(
batches: &Vec,
schema: &SchemaRef,
expr: &[Phy
WeichenXu123 commented on pull request #9187:
URL: https://github.com/apache/arrow/pull/9187#issuecomment-763621581
@liyafan82 But, I don't agree. See this section comment in source code:
https://github.com/apache/arrow/blob/691286975f277f00586cabc6d834ff1efd8caf8c/java/vector/src/main/j
HyukjinKwon commented on pull request #9187:
URL: https://github.com/apache/arrow/pull/9187#issuecomment-763607402
@liyafan82, does it imply that `setValueCount` should always be called
before `vector.getBufferSizeFor` to have the guaranteed result without failure?
It would be great if we
alamb commented on pull request #9122:
URL: https://github.com/apache/arrow/pull/9122#issuecomment-763601989
@nevi-me is this one ready to merge? Should we rebase it against latest
master and rerun the checks? Or I can merge it in as is too
---
liyafan82 commented on pull request #9187:
URL: https://github.com/apache/arrow/pull/9187#issuecomment-763600746
@bogdanghit @WeichenXu123 Thanks for your feedback.
IMO, calling `setValueCount` does not close the vector. You can still append
values and call `setValueCount` multiple t
alamb edited a comment on pull request #9262:
URL: https://github.com/apache/arrow/pull/9262#issuecomment-763597193
You can now see that the pretty print tests are running:
alamb commented on a change in pull request #9264:
URL: https://github.com/apache/arrow/pull/9264#discussion_r560947936
##
File path: rust/datafusion/src/test/mod.rs
##
@@ -106,137 +106,7 @@ pub fn aggr_test_schema() -> SchemaRef {
]))
}
-/// Format a batch as csv
-pub
codecov-io commented on pull request #9275:
URL: https://github.com/apache/arrow/pull/9275#issuecomment-763592223
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9275?src=pr&el=h1) Report
> Merging
[#9275](https://codecov.io/gh/apache/arrow/pull/9275?src=pr&el=desc) (0297af3)
into
alamb commented on a change in pull request #9114:
URL: https://github.com/apache/arrow/pull/9114#discussion_r560935453
##
File path: rust/arrow/src/error.rs
##
@@ -24,6 +24,9 @@ use std::error::Error;
/// Many different operations in the `arrow` crate return this error type.
github-actions[bot] commented on pull request #9275:
URL: https://github.com/apache/arrow/pull/9275#issuecomment-763583275
https://issues.apache.org/jira/browse/ARROW-11323
This is an automated message from the Apache Git Ser
alamb opened a new pull request #9275:
URL: https://github.com/apache/arrow/pull/9275
Prior to this PR, if a plan had an ORDER BY (Sort) that got no input rows,
you would get an output error.
Now the test passes and produces the (expected) no output rows
---
alamb closed pull request #9234:
URL: https://github.com/apache/arrow/pull/9234
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on pull request #9234:
URL: https://github.com/apache/arrow/pull/9234#issuecomment-763570051
I merged this branch locally to master and re-ran all the tests. Things
looked good so merging it in.
This is an a
1 - 100 of 128 matches
Mail list logo
