github-actions[bot] commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766625620
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
codecov-io edited a comment on pull request #9305:
URL: https://github.com/apache/arrow/pull/9305#issuecomment-766197876
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9305?src=pr&el=h1) Report
> Merging
[#9305](https://codecov.io/gh/apache/arrow/pull/9305?src=pr&el=desc) (e07f7e5)
jorgecarleitao opened a new pull request #9314:
URL: https://github.com/apache/arrow/pull/9314
Master and all PRs are failing with a deprecation warning in clippy. This
fixes it.
This is an automated message from the Apache
zhztheplayer commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-766616108
Hi @emkornfield @pitrou
I think I have addressed existing comments so would you like to take another
look now? Thanks a lot. Since this was submitted long time ago (be
jorgecarleitao commented on a change in pull request #9305:
URL: https://github.com/apache/arrow/pull/9305#discussion_r563510962
##
File path: rust/datafusion/src/scalar.rs
##
@@ -205,28 +205,104 @@ impl ScalarValue {
ScalarValue::Boolean(e) => {
A
jorgecarleitao commented on pull request #9232:
URL: https://github.com/apache/arrow/pull/9232#issuecomment-766611408
> Arrow is used inside DF, which is used to build databases on to of it. If
the user defines `DECIMAL(2,2)` it's a bit overhead to use i128 as
representation for it.
tyrelr commented on a change in pull request #9301:
URL: https://github.com/apache/arrow/pull/9301#discussion_r563502344
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -254,6 +254,137 @@ impl Default for TakeOptions {
}
}
+#[inline(always)]
+fn maybe_usize(i
jorgecarleitao closed pull request #9293:
URL: https://github.com/apache/arrow/pull/9293
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jorgecarleitao commented on a change in pull request #9256:
URL: https://github.com/apache/arrow/pull/9256#discussion_r563499210
##
File path: rust/arrow/src/json/writer.rs
##
@@ -0,0 +1,301 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
codecov-io edited a comment on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766538103
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=h1) Report
> Merging
[#9312](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=desc) (e1cf992)
jorgecarleitao commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766578945
The clippy error is unrelated.
This is an automated message from the Apache Git Service.
To respond to the
cyb70289 commented on pull request #9310:
URL: https://github.com/apache/arrow/pull/9310#issuecomment-766570951
mingw64 ci failure is not relevant
This is an automated message from the Apache Git Service.
To respond to the me
nevi-me commented on a change in pull request #9313:
URL: https://github.com/apache/arrow/pull/9313#discussion_r563480506
##
File path: rust/arrow/src/compute/kernels/trigonometry.rs
##
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
github-actions[bot] commented on pull request #9313:
URL: https://github.com/apache/arrow/pull/9313#issuecomment-766567197
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
nevi-me opened a new pull request #9313:
URL: https://github.com/apache/arrow/pull/9313
This is on top of #9297
I was curious if (ab)using the `compute::unary` kernel would perform better
on slightly complex functions.
I implemented the Haversine function, which calculates the
codecov-io commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766538103
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=h1) Report
> Merging
[#9312](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=desc) (84bce69)
into
github-actions[bot] commented on pull request #9312:
URL: https://github.com/apache/arrow/pull/9312#issuecomment-766530454
https://issues.apache.org/jira/browse/ARROW-11369
This is an automated message from the Apache Git Ser
jorgecarleitao opened a new pull request #9312:
URL: https://github.com/apache/arrow/pull/9312
This PR aims at splitting the large `expressions.rs` module in parts,
thereby making it easier to navigate and work with.
No backward incompatible changes are expected from this.
joeyac opened a new issue #9311:
URL: https://github.com/apache/arrow/issues/9311
writer.cc: construct table like
https://arrow.apache.org/docs/cpp/examples/row_columnar_conversion.html ::
VectorToColumnarTable, then use the following code write table to stdout:
```
arrow::Status Wri
tyrelr commented on a change in pull request #9301:
URL: https://github.com/apache/arrow/pull/9301#discussion_r563446434
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -254,6 +254,137 @@ impl Default for TakeOptions {
}
}
+#[inline(always)]
+fn maybe_usize(i
jorgecarleitao commented on a change in pull request #9301:
URL: https://github.com/apache/arrow/pull/9301#discussion_r563445497
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -254,6 +254,137 @@ impl Default for TakeOptions {
}
}
+#[inline(always)]
+fn maybe
tyrelr commented on a change in pull request #9301:
URL: https://github.com/apache/arrow/pull/9301#discussion_r563443673
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -254,6 +254,137 @@ impl Default for TakeOptions {
}
}
+#[inline(always)]
+fn maybe_usize(i
tyrelr commented on a change in pull request #9301:
URL: https://github.com/apache/arrow/pull/9301#discussion_r563443673
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -254,6 +254,137 @@ impl Default for TakeOptions {
}
}
+#[inline(always)]
+fn maybe_usize(i
github-actions[bot] commented on pull request #9310:
URL: https://github.com/apache/arrow/pull/9310#issuecomment-766501335
https://issues.apache.org/jira/browse/ARROW-11367
This is an automated message from the Apache Git Ser
cyb70289 opened a new pull request #9310:
URL: https://github.com/apache/arrow/pull/9310
t-Digest is a data structure to approximate accurate quantiles of
arbitrary length dataset using constant space.
This utility will be used in implementing approximate quantile kernel
and latency
WeichenXu123 commented on pull request #9187:
URL: https://github.com/apache/arrow/pull/9187#issuecomment-766499542
> A better way to get an estimate of buffer size would be to include a
density value for the avg number of bytes per record, similar to
setInitialCapacity(int valueCount, dou
houqp edited a comment on pull request #9309:
URL: https://github.com/apache/arrow/pull/9309#issuecomment-766489488
clippy is failing due to unrelated issue, can i fix it in the same PR or
should I create a new dedicated one to address the issue?
--
houqp commented on pull request #9309:
URL: https://github.com/apache/arrow/pull/9309#issuecomment-766489488
clippy is failing due to unrelated issue, should i fix it in the same PR or
create a new dedicated one to address the issue?
---
codecov-io edited a comment on pull request #9309:
URL: https://github.com/apache/arrow/pull/9309#issuecomment-766471716
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9309?src=pr&el=h1) Report
> Merging
[#9309](https://codecov.io/gh/apache/arrow/pull/9309?src=pr&el=desc) (474e14a)
codecov-io commented on pull request #9309:
URL: https://github.com/apache/arrow/pull/9309#issuecomment-766471716
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9309?src=pr&el=h1) Report
> Merging
[#9309](https://codecov.io/gh/apache/arrow/pull/9309?src=pr&el=desc) (5656232)
into
houqp commented on a change in pull request #9309:
URL: https://github.com/apache/arrow/pull/9309#discussion_r563404985
##
File path: rust/rustfmt.toml
##
@@ -15,9 +15,10 @@
# specific language governing permissions and limitations
# under the License.
+edition = "2018"
Re
github-actions[bot] commented on pull request #9309:
URL: https://github.com/apache/arrow/pull/9309#issuecomment-766461000
https://issues.apache.org/jira/browse/ARROW-11366
This is an automated message from the Apache Git Ser
houqp opened a new pull request #9309:
URL: https://github.com/apache/arrow/pull/9309
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r563395657
##
File path: cpp/src/arrow/adapters/orc/adapter_test.cc
##
@@ -58,6 +73,81 @@ class MemoryOutputStream : public liborc::OutputStream {
uint64_t len
tyrelr commented on a change in pull request #9304:
URL: https://github.com/apache/arrow/pull/9304#discussion_r563393453
##
File path: rust/arrow/src/buffer.rs
##
@@ -1188,6 +1209,57 @@ impl Drop for SetLenOnDrop<'_> {
}
}
+/// Creating a `MutableBuffer` instance by set
tyrelr commented on a change in pull request #9304:
URL: https://github.com/apache/arrow/pull/9304#discussion_r563393453
##
File path: rust/arrow/src/buffer.rs
##
@@ -1188,6 +1209,57 @@ impl Drop for SetLenOnDrop<'_> {
}
}
+/// Creating a `MutableBuffer` instance by set
mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r563393105
##
File path: cpp/src/arrow/adapters/orc/adapter_test.cc
##
@@ -157,4 +249,2151 @@ TEST(TestAdapter, readIntAndStringFileMultipleStripes) {
EXPECT
eladroz edited a comment on pull request #9285:
URL: https://github.com/apache/arrow/pull/9285#issuecomment-766086589
@xhochy @kszucs hi, I've published my experience with building on AWS arm64
VM's
[here](https://lists.apache.org/thread.html/r274a6f9a3d0133fe3b247ea9bb1da6c6f24fc1511508d1
gangliao edited a comment on issue #9307:
URL: https://github.com/apache/arrow/issues/9307#issuecomment-766417028
I tried two solutions:
```rust
let sql = concat!(
"SELECT b, d ",
"FROM t1 JOIN t2 ON t1.a = t2.a ",
"ORDER BY b A
gangliao commented on issue #9307:
URL: https://github.com/apache/arrow/issues/9307#issuecomment-766417028
I tried two solutions:
```rust
let sql = concat!(
"SELECT b, d ",
"FROM t1 JOIN t2 ON t1.a = t2.a ",
"ORDER BY b ASC ",
tyrelr commented on a change in pull request #9304:
URL: https://github.com/apache/arrow/pull/9304#discussion_r563336446
##
File path: rust/arrow/src/buffer.rs
##
@@ -1188,6 +1209,57 @@ impl Drop for SetLenOnDrop<'_> {
}
}
+/// Creating a `MutableBuffer` instance by set
tyrelr commented on a change in pull request #9304:
URL: https://github.com/apache/arrow/pull/9304#discussion_r563336446
##
File path: rust/arrow/src/buffer.rs
##
@@ -1188,6 +1209,57 @@ impl Drop for SetLenOnDrop<'_> {
}
}
+/// Creating a `MutableBuffer` instance by set
Dandandan edited a comment on issue #9307:
URL: https://github.com/apache/arrow/issues/9307#issuecomment-766404237
@gangliao I believe this is a SQL error, the `a` is ambiguous in the
projection. Could you try: `SELECT t1.a as a, b, d`?
Dandandan commented on issue #9307:
URL: https://github.com/apache/arrow/issues/9307#issuecomment-766404237
@gangliao I believe this is a SQL error, the `a` is ambiguous in the
projection. Could you try: `SELECT t1.a as a, b, d`
Joey9801 commented on pull request #9308:
URL: https://github.com/apache/arrow/pull/9308#issuecomment-766396406
I'm not sure this fix is substantial enough that it really needs a JIRA
ticket. Happy to make one and link it to this PR if I'm wrong about that though!
Joey9801 opened a new pull request #9308:
URL: https://github.com/apache/arrow/pull/9308
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
gangliao opened a new issue #9307:
URL: https://github.com/apache/arrow/issues/9307
```shell
"Schema contains duplicate unqualified field name \'a\'")
thread 'tests::simple_join' panicked at 'assertion failed: `(left == right)`
left: `1`,
right: `0`: the test returned a termin
codecov-io edited a comment on pull request #9306:
URL: https://github.com/apache/arrow/pull/9306#issuecomment-766366191
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9306?src=pr&el=h1) Report
> Merging
[#9306](https://codecov.io/gh/apache/arrow/pull/9306?src=pr&el=desc) (e9e6fe3)
codecov-io edited a comment on pull request #9306:
URL: https://github.com/apache/arrow/pull/9306#issuecomment-766366191
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9306?src=pr&el=h1) Report
> Merging
[#9306](https://codecov.io/gh/apache/arrow/pull/9306?src=pr&el=desc) (5fd156a)
eladroz edited a comment on pull request #9285:
URL: https://github.com/apache/arrow/pull/9285#issuecomment-766086589
@xhochy @kszucs hi, I've published my experience with building on AWS arm64
VM's
[here](https://lists.apache.org/thread.html/r274a6f9a3d0133fe3b247ea9bb1da6c6f24fc1511508d1
codecov-io commented on pull request #9306:
URL: https://github.com/apache/arrow/pull/9306#issuecomment-766366191
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9306?src=pr&el=h1) Report
> Merging
[#9306](https://codecov.io/gh/apache/arrow/pull/9306?src=pr&el=desc) (1a064a3)
into
tyrelr commented on pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#issuecomment-766361051
I'm still seeing a mix of inconsistent performance hits/bumps after the
rebase.
```
critcmp master-67d0c2e38 array-slice-83b8938af -t 10
grouparray-
github-actions[bot] commented on pull request #9306:
URL: https://github.com/apache/arrow/pull/9306#issuecomment-766360952
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
manojkarthick opened a new pull request #9306:
URL: https://github.com/apache/arrow/pull/9306
Add an option to print output in JSON format. in the parquet-read binary.
Having json output allows for easy analysis using tools like
[jq](https://stedolan.github.io/jq/). This PR builds on the c
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r56327
##
File path: cpp/src/arrow/memory_pool.h
##
@@ -149,6 +149,43 @@ class ARROW_EXPORT ProxyMemoryPool : public MemoryPool {
std::unique_ptr impl_;
}
nevi-me commented on a change in pull request #9297:
URL: https://github.com/apache/arrow/pull/9297#discussion_r563293232
##
File path: rust/arrow/src/compute/kernels/mod.rs
##
@@ -30,3 +30,4 @@ pub mod sort;
pub mod substring;
pub mod take;
pub mod temporal;
+pub mod unary;
nevi-me commented on a change in pull request #9297:
URL: https://github.com/apache/arrow/pull/9297#discussion_r563293232
##
File path: rust/arrow/src/compute/kernels/mod.rs
##
@@ -30,3 +30,4 @@ pub mod sort;
pub mod substring;
pub mod take;
pub mod temporal;
+pub mod unary;
nevi-me commented on a change in pull request #9297:
URL: https://github.com/apache/arrow/pull/9297#discussion_r563288134
##
File path: rust/arrow/src/compute/kernels/unary.rs
##
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contrib
Dandandan commented on pull request #9305:
URL: https://github.com/apache/arrow/pull/9305#issuecomment-766343030
CI failures don't seem to be related to the changes.
This is an automated message from the Apache Git Service.
T
ovr edited a comment on pull request #9232:
URL: https://github.com/apache/arrow/pull/9232#issuecomment-766338705
> Looking at the spec, a decimal type only supports 128 and 256 bits. So, I
am not understanding why we are trying to add support for
Int32,Int64,Int128,LargeDecimal here.
ovr commented on pull request #9232:
URL: https://github.com/apache/arrow/pull/9232#issuecomment-766338705
> Looking at the spec, a decimal type only supports 128 and 256 bits. So, I
am not understanding why we are trying to add support for
Int32,Int64,Int128,LargeDecimal here.
Arro
ovr commented on a change in pull request #9232:
URL: https://github.com/apache/arrow/pull/9232#discussion_r563282158
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -443,6 +456,13 @@ pub fn cast(array: &ArrayRef, to_type: &DataType) ->
Result {
))),
alamb commented on a change in pull request #9232:
URL: https://github.com/apache/arrow/pull/9232#discussion_r563278609
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -443,6 +456,13 @@ pub fn cast(array: &ArrayRef, to_type: &DataType) ->
Result {
))),
Dandandan commented on a change in pull request #9304:
URL: https://github.com/apache/arrow/pull/9304#discussion_r563279700
##
File path: rust/arrow/src/buffer.rs
##
@@ -1188,6 +1209,57 @@ impl Drop for SetLenOnDrop<'_> {
}
}
+/// Creating a `MutableBuffer` instance by
codecov-io edited a comment on pull request #9305:
URL: https://github.com/apache/arrow/pull/9305#issuecomment-766197876
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9305?src=pr&el=h1) Report
> Merging
[#9305](https://codecov.io/gh/apache/arrow/pull/9305?src=pr&el=desc) (6144a23)
codecov-io edited a comment on pull request #9305:
URL: https://github.com/apache/arrow/pull/9305#issuecomment-766197876
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9305?src=pr&el=h1) Report
> Merging
[#9305](https://codecov.io/gh/apache/arrow/pull/9305?src=pr&el=desc) (d612b0f)
Dandandan commented on pull request #9305:
URL: https://github.com/apache/arrow/pull/9305#issuecomment-766329608
@jorgecarleitao yes, but those are on `GroupByScalar` instead of
`ScalarValue`. I think it might clean up some code by having just one
`ScalarValue` enum defined and reusing fu
jorgecarleitao commented on pull request #9305:
URL: https://github.com/apache/arrow/pull/9305#issuecomment-766329191
I noticed that this is also being used in
`hash_aggregate::create_batch_from_map`.
This is an automated me
Dandandan commented on pull request #9300:
URL: https://github.com/apache/arrow/pull/9300#issuecomment-766327769
Creating an null array with known size might be another that might come up
in the future, but I am witholding that until it is supported by some use case.
-
Dandandan closed pull request #9300:
URL: https://github.com/apache/arrow/pull/9300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Dandandan edited a comment on pull request #9300:
URL: https://github.com/apache/arrow/pull/9300#issuecomment-766324078
@jorgecarleitao I agree, it makes more sense to wait until this is faster
and for now use the iterator for this case (even if it is slightly more
verbose).
I think at
Dandandan commented on pull request #9300:
URL: https://github.com/apache/arrow/pull/9300#issuecomment-766324078
@jorgecarleitao I agree, it makes more sense to wait until this is faster
and for now use the iterator for this case (even if it is slightl
I think at some point this version
jorgecarleitao closed pull request #9262:
URL: https://github.com/apache/arrow/pull/9262
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jorgecarleitao commented on pull request #9300:
URL: https://github.com/apache/arrow/pull/9300#issuecomment-766321620
Do you see any difference between this one and using the iterator? I would
expect them to perform equally well, since both are using `push`.
--
jorgecarleitao edited a comment on pull request #9232:
URL: https://github.com/apache/arrow/pull/9232#issuecomment-766319983
Hi @ovr , I went through what is here so far.
First of all, great stuff that you are taking this on.
Broadly speaking, this PR currently contains the fol
jorgecarleitao commented on a change in pull request #9301:
URL: https://github.com/apache/arrow/pull/9301#discussion_r563267292
##
File path: rust/arrow/src/datatypes.rs
##
@@ -357,10 +373,12 @@ impl JsonSerializable for u16 {
}
impl ArrowNativeType for u16 {
+#[inline
jorgecarleitao edited a comment on pull request #9232:
URL: https://github.com/apache/arrow/pull/9232#issuecomment-766319983
Hi @ovr , I went through what is here so far.
First of all, great stuff that you are taking this on.
Broadly speaking, this PR currently contains the fol
Dandandan commented on a change in pull request #9301:
URL: https://github.com/apache/arrow/pull/9301#discussion_r563265584
##
File path: rust/arrow/src/datatypes.rs
##
@@ -357,10 +373,12 @@ impl JsonSerializable for u16 {
}
impl ArrowNativeType for u16 {
+#[inline]
jorgecarleitao commented on pull request #9232:
URL: https://github.com/apache/arrow/pull/9232#issuecomment-766319983
Hi @ovr , I went through what is here so far.
First of all, great stuff that you are taking this on.
Broadly speaking, this PR currently contains the following
codecov-io edited a comment on pull request #9301:
URL: https://github.com/apache/arrow/pull/9301#issuecomment-766090110
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9301?src=pr&el=h1) Report
> Merging
[#9301](https://codecov.io/gh/apache/arrow/pull/9301?src=pr&el=desc) (5939a4e)
jorgecarleitao commented on pull request #9301:
URL: https://github.com/apache/arrow/pull/9301#issuecomment-766317722
@Dandandan , I pushed a fix and the benches were updated. For non-nulls,
this is now `[-20,-30%]` faster, but still 2x slower when the indices have
nulls, as the logic is n
81 matches
Mail list logo
