[GitHub] [arrow] chenchi-ponyai opened a new issue #9325: [arrow c++]When I read parquet file and get a arrow::Table, how can I convert it to std::vector?

2021-01-25 Thread GitBox
chenchi-ponyai opened a new issue #9325: URL: https://github.com/apache/arrow/issues/9325 I refer to https://github.com/apache/arrow/blob/master/cpp/examples/arrow/row-wise-conversion-example.cc But the demo is easy, the column I used is very complex. For example, there are list of st

[GitHub] [arrow] Dandandan commented on a change in pull request #9309: ARROW-11366: [Datafusion] support boolean literal in comparison expression

2021-01-25 Thread GitBox
Dandandan commented on a change in pull request #9309: URL: https://github.com/apache/arrow/pull/9309#discussion_r564293129 ## File path: rust/datafusion/src/optimizer/boolean_comparison.rs ## @@ -0,0 +1,270 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] houqp edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0

2021-01-25 Thread GitBox
houqp edited a comment on pull request #9230: URL: https://github.com/apache/arrow/pull/9230#issuecomment-767301487 I see what's going on, the rust tester implementation expects test server to output binding port: https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/

[GitHub] [arrow] cyb70289 removed a comment on pull request #9310: ARROW-11367: [C++] Implement t-digest approximate quantile utility

2021-01-25 Thread GitBox
cyb70289 removed a comment on pull request #9310: URL: https://github.com/apache/arrow/pull/9310#issuecomment-766570951 mingw64 ci failure is not relevant This is an automated message from the Apache Git Service. To respond t

[GitHub] [arrow] cyb70289 commented on pull request #9292: ARROW-11346: [C++][Compute] Implement quantile kernel benchmark

2021-01-25 Thread GitBox
cyb70289 commented on pull request #9292: URL: https://github.com/apache/arrow/pull/9292#issuecomment-767349125 mingw32 ci failure is not relevant This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [arrow] Dandandan commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0

2021-01-25 Thread GitBox
Dandandan commented on pull request #9230: URL: https://github.com/apache/arrow/pull/9230#issuecomment-767346005 Thanks @houqp that's very subtle... This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] houqp commented on a change in pull request #9256: WIP: ARROW-11310: [Rust] implement JSON writer

2021-01-25 Thread GitBox
houqp commented on a change in pull request #9256: URL: https://github.com/apache/arrow/pull/9256#discussion_r564283209 ## File path: rust/arrow/src/json/writer.rs ## @@ -0,0 +1,301 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-01-25 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-767340513 ubuntu-20.04-x86_64: https://conbench.ursa.dev/compare/runs/test_29a147dc864b4dc1bd2d7841ee35f23b...test_f304723b1e7f4488a59d6f58439df716/ test-agent: https://conbench.ursa.dev

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2021-01-25 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-767338954 ubuntu-20.04-x86_64: https://conbench.ursa.dev/compare/runs/{'0af17317-4926-4771-8684-9f61b42f1241': 'test_29a147dc864b4dc1bd2d7841ee35f23b', '4c58aed2-b4bb-4243-9574-eeb90e1dd49

[GitHub] [arrow] github-actions[bot] commented on pull request #9324: ARROW-11386: [Release] Fix post documents update script

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9324: URL: https://github.com/apache/arrow/pull/9324#issuecomment-767326648 https://issues.apache.org/jira/browse/ARROW-11386 This is an automated message from the Apache Git Ser

[GitHub] [arrow] kou closed pull request #9324: ARROW-11386: [Release] Fix post documents update script

2021-01-25 Thread GitBox
kou closed pull request #9324: URL: https://github.com/apache/arrow/pull/9324 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] github-actions[bot] removed a comment on pull request #9324: ARROW-11386: [Release] Fix post documents update script

2021-01-25 Thread GitBox
github-actions[bot] removed a comment on pull request #9324: URL: https://github.com/apache/arrow/pull/9324#issuecomment-767320004 https://issues.apache.org/jira/browse/ARROW-2064 This is an automated message from the Apache

[GitHub] [arrow] kou commented on pull request #9324: ARROW-2064: [Release] Fix post documents update script

2021-01-25 Thread GitBox
kou commented on pull request #9324: URL: https://github.com/apache/arrow/pull/9324#issuecomment-767325531 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] kou closed pull request #9273: ARROW-11325: [Packaging][C#] Release Apache.Arrow.Flight and Apache.Arrow.Flight.AspNetCore

2021-01-25 Thread GitBox
kou closed pull request #9273: URL: https://github.com/apache/arrow/pull/9273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] kou commented on pull request #9273: ARROW-11325: [Packaging][C#] Release Apache.Arrow.Flight and Apache.Arrow.Flight.AspNetCore

2021-01-25 Thread GitBox
kou commented on pull request #9273: URL: https://github.com/apache/arrow/pull/9273#issuecomment-767325004 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] github-actions[bot] commented on pull request #9324: ARROW-2064: [Release] Fix post documents update script

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9324: URL: https://github.com/apache/arrow/pull/9324#issuecomment-767320004 https://issues.apache.org/jira/browse/ARROW-2064 This is an automated message from the Apache Git Serv

[GitHub] [arrow] kou opened a new pull request #9324: ARROW-2064: [Release] Fix post documents update script

2021-01-25 Thread GitBox
kou opened a new pull request #9324: URL: https://github.com/apache/arrow/pull/9324 * Keep docs/c_glib/index.html that is generated by Jekyll. * Fix wrong pull request URL. This is an automated message from the Apache Git

[GitHub] [arrow] mqy edited a comment on pull request #9299: ARROW-11179: [Format] Make FB comments friendly to rust

2021-01-25 Thread GitBox
mqy edited a comment on pull request #9299: URL: https://github.com/apache/arrow/pull/9299#issuecomment-767312376 @pitrou @emkornfield thanks! > Looks OK to me as well, is it possible to generate one off docs with this change to confirm the figures look OK? As of `rust`, files

[GitHub] [arrow] mqy edited a comment on pull request #9299: ARROW-11179: [Format] Make FB comments friendly to rust

2021-01-25 Thread GitBox
mqy edited a comment on pull request #9299: URL: https://github.com/apache/arrow/pull/9299#issuecomment-767312376 @pitrou @emkornfield thanks! > Looks OK to me as well, is it possible to generate one off docs with this change to confirm the figures look OK? As of `rust`, files

[GitHub] [arrow] mqy commented on pull request #9299: ARROW-11179: [Format] Make FB comments friendly to rust

2021-01-25 Thread GitBox
mqy commented on pull request #9299: URL: https://github.com/apache/arrow/pull/9299#issuecomment-767312376 @pitrou @emkornfield thanks! > Looks OK to me as well, is it possible to generate one off docs with this change to confirm the figures look OK? As of `rust`, files `rust/

[GitHub] [arrow] houqp edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0

2021-01-25 Thread GitBox
houqp edited a comment on pull request #9230: URL: https://github.com/apache/arrow/pull/9230#issuecomment-767301487 I see what's going on, the rust tester implementation expects test server to output binding port: https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/

[GitHub] [arrow] houqp edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0

2021-01-25 Thread GitBox
houqp edited a comment on pull request #9230: URL: https://github.com/apache/arrow/pull/9230#issuecomment-767301487 I see what's going on, the rust tester implementation expects test server to output binding port: https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/

[GitHub] [arrow] cyb70289 commented on pull request #9315: ARROW-11372: [Release] Support RC verification on macOS-ARM64

2021-01-25 Thread GitBox
cyb70289 commented on pull request #9315: URL: https://github.com/apache/arrow/pull/9315#issuecomment-767305699 Looks this patch needs rebase? I'd like to reference it to verify RC on Arm64 linux. This is an automated mess

[GitHub] [arrow] emkornfield commented on pull request #9299: ARROW-11179: [Format] Make FB comments friendly to rust

2021-01-25 Thread GitBox
emkornfield commented on pull request #9299: URL: https://github.com/apache/arrow/pull/9299#issuecomment-767289020 Looks OK to me as well, is it possible to generate one off docs with this change to confirm the figures look OK? -

[GitHub] [arrow] houqp commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0

2021-01-25 Thread GitBox
houqp commented on pull request #9230: URL: https://github.com/apache/arrow/pull/9230#issuecomment-767301487 I see what's going on, the rust tester implementation expects test server to output binding port: https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/tester_

[GitHub] [arrow] houqp commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0

2021-01-25 Thread GitBox
houqp commented on pull request #9230: URL: https://github.com/apache/arrow/pull/9230#issuecomment-767294362 Following the steps shared by nevi, i was able to narrow down the reproducible case to simply running `cargo run --bin flight-test-integration-server -- --port=0` from within `integ

[GitHub] [arrow] houqp removed a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0

2021-01-25 Thread GitBox
houqp removed a comment on pull request #9230: URL: https://github.com/apache/arrow/pull/9230#issuecomment-767294362 Following the steps shared by nevi, i was able to narrow down the reproducible case to simply running `cargo run --bin flight-test-integration-server -- --port=0` from withi

[GitHub] [arrow] houqp removed a comment on pull request #9309: ARROW-11366: [Datafusion] support boolean literal in comparison expression

2021-01-25 Thread GitBox
houqp removed a comment on pull request #9309: URL: https://github.com/apache/arrow/pull/9309#issuecomment-766489488 clippy is failing due to unrelated issue, can i fix it in the same PR or should I create a new dedicated one to address the issue? -

[GitHub] [arrow] codecov-io edited a comment on pull request #9309: ARROW-11366: [Datafusion] support boolean literal in comparison expression

2021-01-25 Thread GitBox
codecov-io edited a comment on pull request #9309: URL: https://github.com/apache/arrow/pull/9309#issuecomment-766471716 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9309?src=pr&el=h1) Report > Merging [#9309](https://codecov.io/gh/apache/arrow/pull/9309?src=pr&el=desc) (325fa4d)

[GitHub] [arrow] mathyingzhou commented on a change in pull request #8648: ARROW-7906: [C++] [Python] Add ORC write support

2021-01-25 Thread GitBox
mathyingzhou commented on a change in pull request #8648: URL: https://github.com/apache/arrow/pull/8648#discussion_r564213532 ## File path: cpp/src/arrow/adapters/orc/adapter_test.cc ## @@ -157,4 +249,2151 @@ TEST(TestAdapter, readIntAndStringFileMultipleStripes) { EXPECT

[GitHub] [arrow] codecov-io commented on pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs

2021-01-25 Thread GitBox
codecov-io commented on pull request #9312: URL: https://github.com/apache/arrow/pull/9312#issuecomment-766538103 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=h1) Report > Merging [#9312](https://codecov.io/gh/apache/arrow/pull/9312?src=pr&el=desc) (84bce69) into

[GitHub] [arrow] codecov-io edited a comment on pull request #9291: ARROW-11345: [Rust] Made most ops not rely on `value(i)`

2021-01-25 Thread GitBox
codecov-io edited a comment on pull request #9291: URL: https://github.com/apache/arrow/pull/9291#issuecomment-765203292 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9291?src=pr&el=h1) Report > Merging [#9291](https://codecov.io/gh/apache/arrow/pull/9291?src=pr&el=desc) (032b2ba)

[GitHub] [arrow] github-actions[bot] commented on pull request #9318: ARROW-11383: [Rust] Faster bit AND and OR (2x)

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9318: URL: https://github.com/apache/arrow/pull/9318#issuecomment-767034982 https://issues.apache.org/jira/browse/ARROW-11383 This is an automated message from the Apache Git Ser

[GitHub] [arrow] seberg commented on pull request #8834: ARROW-10833: [Python] Allow pyarrow to be compiled on NumPy <1.16.6 and work on 1.20+

2021-01-25 Thread GitBox
seberg commented on pull request #8834: URL: https://github.com/apache/arrow/pull/8834#issuecomment-766909515 Thanks, our/Chuck's plan was to release NumPy this weekend, so it should work out then. This is an automated messa

[GitHub] [arrow] pitrou commented on a change in pull request #9296: ARROW-11350: [C++] Bump dependency versions

2021-01-25 Thread GitBox
pitrou commented on a change in pull request #9296: URL: https://github.com/apache/arrow/pull/9296#discussion_r563782232 ## File path: cpp/thirdparty/versions.txt ## @@ -25,35 +25,39 @@ # Abseil LTS branch, Sept 2020, Patch 2 ARROW_ABSL_BUILD_VERSION=0f3bb466b868b523cf1dc9b

[GitHub] [arrow] jorgecarleitao commented on pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs

2021-01-25 Thread GitBox
jorgecarleitao commented on pull request #9312: URL: https://github.com/apache/arrow/pull/9312#issuecomment-766578945 The clippy error is unrelated. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] kou commented on a change in pull request #9296: ARROW-11350: [C++] Bump dependency versions

2021-01-25 Thread GitBox
kou commented on a change in pull request #9296: URL: https://github.com/apache/arrow/pull/9296#discussion_r564134547 ## File path: cpp/thirdparty/versions.txt ## @@ -25,35 +25,39 @@ # Abseil LTS branch, Sept 2020, Patch 2 ARROW_ABSL_BUILD_VERSION=0f3bb466b868b523cf1dc9b2aa

[GitHub] [arrow] nevi-me removed a comment on pull request #9318: ARROW-11383: [Rust] Faster bit AND and OR (2x)

2021-01-25 Thread GitBox
nevi-me removed a comment on pull request #9318: URL: https://github.com/apache/arrow/pull/9318#issuecomment-767143458 Rihanna: Rebase Gone Bad? This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] codecov-io edited a comment on pull request #9211: ARROW-11239: [Rust] Fixed equality with offsets and nulls

2021-01-25 Thread GitBox
codecov-io edited a comment on pull request #9211: URL: https://github.com/apache/arrow/pull/9211#issuecomment-761444096 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9211?src=pr&el=h1) Report > Merging [#9211](https://codecov.io/gh/apache/arrow/pull/9211?src=pr&el=desc) (5371da4)

[GitHub] [arrow] codecov-io commented on pull request #9314: [Rust] Fix deprecation warning in clippy

2021-01-25 Thread GitBox
codecov-io commented on pull request #9314: URL: https://github.com/apache/arrow/pull/9314#issuecomment-766731276 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=h1) Report > Merging [#9314](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=desc) (d427d8f) into

[GitHub] [arrow] alamb closed pull request #9314: ARROW-11375: [Rust] Fix deprecation warning in clippy

2021-01-25 Thread GitBox
alamb closed pull request #9314: URL: https://github.com/apache/arrow/pull/9314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] arw2019 commented on pull request #9115: ARROW-10457: [CI] Fix Spark branch-3.0 integration tests

2021-01-25 Thread GitBox
arw2019 commented on pull request #9115: URL: https://github.com/apache/arrow/pull/9115#issuecomment-766852482 Closing in favour of #9210 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-01-25 Thread GitBox
ElenaHenderson removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-764916679 please benchmark This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [arrow] nevi-me closed pull request #9137: ARROW-8676: [Rust] IPC RecordBatch body compression

2021-01-25 Thread GitBox
nevi-me closed pull request #9137: URL: https://github.com/apache/arrow/pull/9137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] pitrou commented on pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build

2021-01-25 Thread GitBox
pitrou commented on pull request #9317: URL: https://github.com/apache/arrow/pull/9317#issuecomment-767001462 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-01-25 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-767227864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] ianmcook commented on pull request #9287: ARROW-11340: [C++] Add vcpkg.json manifest to cpp project root [WIP]

2021-01-25 Thread GitBox
ianmcook commented on pull request #9287: URL: https://github.com/apache/arrow/pull/9287#issuecomment-767166823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] pitrou commented on a change in pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build

2021-01-25 Thread GitBox
pitrou commented on a change in pull request #9317: URL: https://github.com/apache/arrow/pull/9317#discussion_r564010378 ## File path: cpp/build-support/run-test.sh ## @@ -65,14 +65,9 @@ function setup_sanitizers() { # Configure TSAN (ignored if this isn't a TSAN build).

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9305: ARROW-11362:[Rust][DataFusion] Use iterator APIs in to_array_of_size to improve performance

2021-01-25 Thread GitBox
jorgecarleitao commented on a change in pull request #9305: URL: https://github.com/apache/arrow/pull/9305#discussion_r563510962 ## File path: rust/datafusion/src/scalar.rs ## @@ -205,28 +205,104 @@ impl ScalarValue { ScalarValue::Boolean(e) => { A

[GitHub] [arrow] jorisvandenbossche commented on pull request #8834: ARROW-10833: [Python] Allow pyarrow to be compiled on NumPy <1.16.6 and work on 1.20+

2021-01-25 Thread GitBox
jorisvandenbossche commented on pull request #8834: URL: https://github.com/apache/arrow/pull/8834#issuecomment-766837148 Update on this: there is a release candidate that is being tested/approved at the moment, and my assumption is that we will release in 1 to 3 days. ---

[GitHub] [arrow] jorisvandenbossche commented on issue #9172: Is Expression have decomposition methods ?

2021-01-25 Thread GitBox
jorisvandenbossche commented on issue #9172: URL: https://github.com/apache/arrow/issues/9172#issuecomment-766845978 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #9294: ARROW-8919: [C++][Compute][Dataset] Add Function::DispatchBest to accomodate implicit casts

2021-01-25 Thread GitBox
jorisvandenbossche commented on a change in pull request #9294: URL: https://github.com/apache/arrow/pull/9294#discussion_r563875620 ## File path: python/pyarrow/tests/parquet/test_dataset.py ## @@ -206,7 +206,7 @@ def test_filters_equivalency(tempdir, use_legacy_dataset):

[GitHub] [arrow] eerhardt commented on pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

2021-01-25 Thread GitBox
eerhardt commented on pull request #8694: URL: https://github.com/apache/arrow/pull/8694#issuecomment-767155085 FYI - @Ulimo, the `3.0.0` nuget packages have been released. You can see them at: https://www.nuget.org/packages/Apache.Arrow.Flight/ https://www.nuget.org/packages/Apac

[GitHub] [arrow] alamb commented on pull request #9314: [Rust] Fix deprecation warning in clippy

2021-01-25 Thread GitBox
alamb commented on pull request #9314: URL: https://github.com/apache/arrow/pull/9314#issuecomment-766767675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] nevi-me commented on pull request #9137: ARROW-8676: [Rust] IPC RecordBatch body compression

2021-01-25 Thread GitBox
nevi-me commented on pull request #9137: URL: https://github.com/apache/arrow/pull/9137#issuecomment-767020365 I'll come back to this in the coming weeks This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] nealrichardson commented on pull request #9320: ARROW-7288: [C++][R] read_parquet() freezes on Windows with Japanese locale

2021-01-25 Thread GitBox
nealrichardson commented on pull request #9320: URL: https://github.com/apache/arrow/pull/9320#issuecomment-767129996 @github-actions autotune This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [arrow] jorgecarleitao closed pull request #9293: ARROW-11349: [Rust] Add from_iter_values to create arrays from (non null) values

2021-01-25 Thread GitBox
jorgecarleitao closed pull request #9293: URL: https://github.com/apache/arrow/pull/9293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] codecov-io edited a comment on pull request #9312: ARROW-11369: [DataFusion] Split expressions.rs

2021-01-25 Thread GitBox
codecov-io edited a comment on pull request #9312: URL: https://github.com/apache/arrow/pull/9312#issuecomment-766538103 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [arrow] jorgecarleitao commented on pull request #9314: [Rust] Fix deprecation warning in clippy

2021-01-25 Thread GitBox
jorgecarleitao commented on pull request #9314: URL: https://github.com/apache/arrow/pull/9314#issuecomment-766796537 It should be fixed now. :) This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] codecov-io edited a comment on pull request #9301: ARROW-11357: [Rust]: Fix out-of-bounds reads in `take` and other undefined behavior

2021-01-25 Thread GitBox
codecov-io edited a comment on pull request #9301: URL: https://github.com/apache/arrow/pull/9301#issuecomment-766090110 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9301?src=pr&el=h1) Report > Merging [#9301](https://codecov.io/gh/apache/arrow/pull/9301?src=pr&el=desc) (24dcba5)

[GitHub] [arrow] github-actions[bot] commented on pull request #9113: ARROW-11147: [CI][Python] Remove pandas=0.25.3 pin for dask-latest

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9113: URL: https://github.com/apache/arrow/pull/9113#issuecomment-766842718 Revision: 872e082c4de957c1db82c0ea0f94c4009c866494 Submitted crossbow builds: [ursacomputing/crossbow @ actions-45](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] nealrichardson commented on a change in pull request #9296: ARROW-11350: [C++] Bump dependency versions

2021-01-25 Thread GitBox
nealrichardson commented on a change in pull request #9296: URL: https://github.com/apache/arrow/pull/9296#discussion_r563866731 ## File path: cpp/thirdparty/versions.txt ## @@ -25,35 +25,39 @@ # Abseil LTS branch, Sept 2020, Patch 2 ARROW_ABSL_BUILD_VERSION=0f3bb466b868b52

[GitHub] [arrow] codecov-io commented on pull request #9318: ARROW-11383: [Rust] Faster bit AND and OR (2x)

2021-01-25 Thread GitBox
codecov-io commented on pull request #9318: URL: https://github.com/apache/arrow/pull/9318#issuecomment-767235917 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9318?src=pr&el=h1) Report > Merging [#9318](https://codecov.io/gh/apache/arrow/pull/9318?src=pr&el=desc) (550327d) into

[GitHub] [arrow] westonpace commented on pull request #9319: ARROW-11376: [C++] ThreadedTaskGroup failure with Thread Sanitizer enabled

2021-01-25 Thread GitBox
westonpace commented on pull request #9319: URL: https://github.com/apache/arrow/pull/9319#issuecomment-767120195 @pitrou Good catch This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] github-actions[bot] commented on pull request #9315: ARROW-11372: Support RC verification on macOS-ARM64

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9315: URL: https://github.com/apache/arrow/pull/9315#issuecomment-766763089 https://issues.apache.org/jira/browse/ARROW-11372 This is an automated message from the Apache Git Ser

[GitHub] [arrow] nevi-me commented on pull request #9318: ARROW-11383: [Rust] Faster bit AND and OR (2x)

2021-01-25 Thread GitBox
nevi-me commented on pull request #9318: URL: https://github.com/apache/arrow/pull/9318#issuecomment-767143458 Rihanna: Rebase Gone Bad? This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] pitrou commented on pull request #9299: ARROW-11179: [Format] Make FB comments friendly to rust

2021-01-25 Thread GitBox
pitrou commented on pull request #9299: URL: https://github.com/apache/arrow/pull/9299#issuecomment-766875433 No concern from me. @wesm @xhochy @emkornfield What do you think? This is an automated message from the Apache Git

[GitHub] [arrow] arw2019 closed pull request #9115: ARROW-10457: [CI] Fix Spark branch-3.0 integration tests

2021-01-25 Thread GitBox
arw2019 closed pull request #9115: URL: https://github.com/apache/arrow/pull/9115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] codecov-io edited a comment on pull request #9305: ARROW-11362:[Rust][DataFusion] Use iterator APIs in to_array_of_size to improve performance

2021-01-25 Thread GitBox
codecov-io edited a comment on pull request #9305: URL: https://github.com/apache/arrow/pull/9305#issuecomment-766197876 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [arrow] zhztheplayer commented on pull request #7030: ARROW-7808: [Java][Dataset] Implement Dataset Java API by JNI to C++

2021-01-25 Thread GitBox
zhztheplayer commented on pull request #7030: URL: https://github.com/apache/arrow/pull/7030#issuecomment-766616108 Hi @emkornfield @pitrou I think I have addressed existing comments so would you like to take another look now? Thanks a lot. Since this was submitted long time ago (be

[GitHub] [arrow] github-actions[bot] commented on pull request #9321: ARROW-7288: alternate R-only workaround for std::regex issue

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9321: URL: https://github.com/apache/arrow/pull/9321#issuecomment-767157694 https://issues.apache.org/jira/browse/ARROW-7288 This is an automated message from the Apache Git Serv

[GitHub] [arrow] ianmcook edited a comment on pull request #9287: ARROW-11340: [C++] Add vcpkg.json manifest to cpp project root

2021-01-25 Thread GitBox
ianmcook edited a comment on pull request #9287: URL: https://github.com/apache/arrow/pull/9287#issuecomment-767241021 @kszucs I added a Crossbow test. It runs a GHA job on a Windows instance. The job installs the current version of vcpkg, installs all the dependencies listed in `vcpkg.jso

[GitHub] [arrow] xhochy commented on a change in pull request #9315: ARROW-11372: [Release] Support RC verification on macOS-ARM64

2021-01-25 Thread GitBox
xhochy commented on a change in pull request #9315: URL: https://github.com/apache/arrow/pull/9315#discussion_r563799499 ## File path: dev/release/verify-release-candidate.sh ## @@ -215,7 +215,11 @@ setup_tempdir() { setup_miniconda() { # Setup short-lived miniconda for Pyt

[GitHub] [arrow] alamb commented on pull request #9312: ARROW-11369: [DataFusion] Split physical_plan/expressions.rs

2021-01-25 Thread GitBox
alamb commented on pull request #9312: URL: https://github.com/apache/arrow/pull/9312#issuecomment-766765773 Clippy error is addressed here: https://github.com/apache/arrow/pull/9314 This is an automated message from the Apac

[GitHub] [arrow] jorisvandenbossche closed pull request #9113: ARROW-11147: [CI][Python] Remove pandas=0.25.3 pin for dask-latest

2021-01-25 Thread GitBox
jorisvandenbossche closed pull request #9113: URL: https://github.com/apache/arrow/pull/9113 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] codecov-io edited a comment on pull request #9314: [Rust] Fix deprecation warning in clippy

2021-01-25 Thread GitBox
codecov-io edited a comment on pull request #9314: URL: https://github.com/apache/arrow/pull/9314#issuecomment-766731276 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=h1) Report > Merging [#9314](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=desc) (a4572d2)

[GitHub] [arrow] codecov-io edited a comment on pull request #9297: ARROW-11354: [Rust] Speed-up cast of dates and times (2-4x)

2021-01-25 Thread GitBox
codecov-io edited a comment on pull request #9297: URL: https://github.com/apache/arrow/pull/9297#issuecomment-765883730 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [arrow] kiszk commented on a change in pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian

2021-01-25 Thread GitBox
kiszk commented on a change in pull request #7507: URL: https://github.com/apache/arrow/pull/7507#discussion_r563899594 ## File path: cpp/src/arrow/array/util.h ## @@ -56,6 +56,14 @@ Result> MakeArrayFromScalar( namespace internal { +/// \brief Swap endian of each element

[GitHub] [arrow] github-actions[bot] commented on pull request #9287: ARROW-11340: [C++] Add vcpkg.json manifest to cpp project root [WIP]

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9287: URL: https://github.com/apache/arrow/pull/9287#issuecomment-767167113 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] gangliao edited a comment on issue #9307: [Rust][DataFusion] Join Statement: Schema contains duplicate unqualified field name

2021-01-25 Thread GitBox
gangliao edited a comment on issue #9307: URL: https://github.com/apache/arrow/issues/9307#issuecomment-766417028 I tried two solutions: ```rust let sql = concat!( "SELECT b, d ", "FROM t1 JOIN t2 ON t1.a = t2.a ", "ORDER BY b A

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9256: WIP: ARROW-11310: [Rust] implement JSON writer

2021-01-25 Thread GitBox
jorgecarleitao commented on a change in pull request #9256: URL: https://github.com/apache/arrow/pull/9256#discussion_r563499210 ## File path: rust/arrow/src/json/writer.rs ## @@ -0,0 +1,301 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [arrow] github-actions[bot] commented on pull request #9284: ARROW-10370: [Python] Clean-up filesystem handling in write_dataset

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9284: URL: https://github.com/apache/arrow/pull/9284#issuecomment-766808833 Revision: f855a3166addea9d615f1aa61ac5c5e090df3367 Submitted crossbow builds: [ursacomputing/crossbow @ actions-44](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] github-actions[bot] commented on pull request #9314: [Rust] Fix deprecation warning in clippy

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9314: URL: https://github.com/apache/arrow/pull/9314#issuecomment-766625620 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] Dandandan commented on a change in pull request #9305: ARROW-11362:[Rust][DataFusion] Use iterator APIs in to_array_of_size to improve performance

2021-01-25 Thread GitBox
Dandandan commented on a change in pull request #9305: URL: https://github.com/apache/arrow/pull/9305#discussion_r563564784 ## File path: rust/datafusion/src/scalar.rs ## @@ -205,28 +205,104 @@ impl ScalarValue { ScalarValue::Boolean(e) => { Arc::n

[GitHub] [arrow] nevi-me commented on a change in pull request #9313: [Rust] [Experiment] Trigonometry kernels

2021-01-25 Thread GitBox
nevi-me commented on a change in pull request #9313: URL: https://github.com/apache/arrow/pull/9313#discussion_r563480506 ## File path: rust/arrow/src/compute/kernels/trigonometry.rs ## @@ -0,0 +1,248 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] bkietz commented on a change in pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build

2021-01-25 Thread GitBox
bkietz commented on a change in pull request #9317: URL: https://github.com/apache/arrow/pull/9317#discussion_r563966100 ## File path: cpp/build-support/run-test.sh ## @@ -65,14 +65,9 @@ function setup_sanitizers() { # Configure TSAN (ignored if this isn't a TSAN build).

[GitHub] [arrow] svjack commented on issue #9172: Is Expression have decomposition methods ?

2021-01-25 Thread GitBox
svjack commented on issue #9172: URL: https://github.com/apache/arrow/issues/9172#issuecomment-766864484 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] nevi-me commented on a change in pull request #9297: ARROW-11354: [Rust] Speed-up cast of dates and times (2-4x)

2021-01-25 Thread GitBox
nevi-me commented on a change in pull request #9297: URL: https://github.com/apache/arrow/pull/9297#discussion_r563945256 ## File path: rust/arrow/src/compute/kernels/mod.rs ## @@ -30,3 +30,4 @@ pub mod sort; pub mod substring; pub mod take; pub mod temporal; +pub mod unary;

[GitHub] [arrow] ilya-biryukov commented on issue #9178: Support for the binary SQL type in rust/datafusion

2021-01-25 Thread GitBox
ilya-biryukov commented on issue #9178: URL: https://github.com/apache/arrow/issues/9178#issuecomment-766711505 Hi @jorgecarleitao, I forgot to mention my use-case involves an aggregate UDF. The `Accumulator` trait requires accepting and returning instances of `ScalarValue`. It was n

[GitHub] [arrow] nevi-me edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0

2021-01-25 Thread GitBox
nevi-me edited a comment on pull request #9230: URL: https://github.com/apache/arrow/pull/9230#issuecomment-766627433 > @houqp -- I think the instructions to run the tests locally are here: https://github.com/apache/arrow/blob/master/docs/source/format/Integration.rst > > @carols10ce

[GitHub] [arrow] bkietz commented on issue #9311: [arrow c++] How can I modify `RecordBatch` or `Table` value piped from another c++ program?

2021-01-25 Thread GitBox
bkietz commented on issue #9311: URL: https://github.com/apache/arrow/issues/9311#issuecomment-766925916 Arrow data structures like RecordBatch and Table are intended to be immutable, so modification of their internal buffers like this is not really supported. ---

[GitHub] [arrow] jeroen commented on pull request #9321: ARROW-7288: alternate R-only workaround for std::regex issue

2021-01-25 Thread GitBox
jeroen commented on pull request #9321: URL: https://github.com/apache/arrow/pull/9321#issuecomment-767183967 Few comments: - You can use `withr::with_locale()` to simplify temporary setting the locale - Most servers won't have the Japanese language pack installed, so `Sys.set

[GitHub] [arrow] codecov-io edited a comment on pull request #9298: ARROW-11355: [Rust] Aligned Date DataType with specification.

2021-01-25 Thread GitBox
codecov-io edited a comment on pull request #9298: URL: https://github.com/apache/arrow/pull/9298#issuecomment-765890484 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=h1) Report > Merging [#9298](https://codecov.io/gh/apache/arrow/pull/9298?src=pr&el=desc) (7da2e92)

[GitHub] [arrow] github-actions[bot] commented on pull request #9320: ARROW-7288: [C++][R] read_parquet() freezes on Windows with Japanese locale

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9320: URL: https://github.com/apache/arrow/pull/9320#issuecomment-767129392 https://issues.apache.org/jira/browse/ARROW-7288 This is an automated message from the Apache Git Serv

[GitHub] [arrow] pitrou commented on a change in pull request #9315: ARROW-11372: [Release] Support RC verification on macOS-ARM64

2021-01-25 Thread GitBox
pitrou commented on a change in pull request #9315: URL: https://github.com/apache/arrow/pull/9315#discussion_r563787651 ## File path: dev/release/verify-release-candidate.sh ## @@ -215,7 +215,11 @@ setup_tempdir() { setup_miniconda() { # Setup short-lived miniconda for Pyt

[GitHub] [arrow] github-actions[bot] commented on pull request #9322: [Release] Fix python post release script

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9322: URL: https://github.com/apache/arrow/pull/9322#issuecomment-767212890 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] github-actions[bot] commented on pull request #9313: [Rust] [Experiment] Trigonometry kernels

2021-01-25 Thread GitBox
github-actions[bot] commented on pull request #9313: URL: https://github.com/apache/arrow/pull/9313#issuecomment-766567197 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] joeyac commented on issue #9311: [arrow c++] How can I modify `RecordBatch` or `Table` value piped from another c++ program?

2021-01-25 Thread GitBox
joeyac commented on issue #9311: URL: https://github.com/apache/arrow/issues/9311#issuecomment-766898581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] jorisvandenbossche commented on pull request #9284: ARROW-10370: [Python] Clean-up filesystem handling in write_dataset

2021-01-25 Thread GitBox
jorisvandenbossche commented on pull request #9284: URL: https://github.com/apache/arrow/pull/9284#issuecomment-766808103 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [arrow] pitrou closed pull request #9284: ARROW-10370: [Python] Clean-up filesystem handling in write_dataset

2021-01-25 Thread GitBox
pitrou closed pull request #9284: URL: https://github.com/apache/arrow/pull/9284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

  1   2   3   >