sunchao commented on a change in pull request #9592:
URL: https://github.com/apache/arrow/pull/9592#discussion_r584251475
##
File path: rust/parquet/src/basic.rs
##
@@ -337,8 +396,11 @@ impl ColumnOrder {
// If the max is -0, the row group may contain +0 values as
houqp commented on pull request #9534:
URL: https://github.com/apache/arrow/pull/9534#issuecomment-787410693
alright, pushed reader offset rewind fix.
This is an automated message from the Apache Git Service.
To respond to
codecov-io edited a comment on pull request #9534:
URL: https://github.com/apache/arrow/pull/9534#issuecomment-782598126
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9534?src=pr=h1) Report
> Merging
[#9534](https://codecov.io/gh/apache/arrow/pull/9534?src=pr=desc) (e3312f2)
into
xhochy commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584248195
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
What is the reason for the
josiahyan commented on pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#issuecomment-787375395
Sorry about the delay! I've rebased the commits and manually merged in the
changes made in master.
This is an
chrystianrgs removed a comment on issue #9420:
URL: https://github.com/apache/arrow/issues/9420#issuecomment-787210056
Hi, your sequence no true, is false
This is an automated message from the Apache Git Service.
To respond
chrystianrgs commented on issue #9420:
URL: https://github.com/apache/arrow/issues/9420#issuecomment-787210056
Hi, your sequence no true, is false
This is an automated message from the Apache Git Service.
To respond to the
lidavidm closed pull request #9593:
URL: https://github.com/apache/arrow/pull/9593
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lidavidm closed pull request #9583:
URL: https://github.com/apache/arrow/pull/9583
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on pull request #9593:
URL: https://github.com/apache/arrow/pull/9593#issuecomment-787149976
The integration test passed:
https://github.com/apache/arrow/pull/9593/checks?check_run_id=1995394206
I'll manually retrigger a few times to see if there might be still
alamb commented on pull request #9523:
URL: https://github.com/apache/arrow/pull/9523#issuecomment-787133178
@edrevo cool -- thanks. There was one other use of crossbeam in the parquet
reader which I can try tomorrow morning. Thanks!
alamb commented on pull request #9593:
URL: https://github.com/apache/arrow/pull/9593#issuecomment-787131636
@lidavidm thank you for the help -- it is like you are writing the code for
me :)
This is an automated message
alamb commented on pull request #9593:
URL: https://github.com/apache/arrow/pull/9593#issuecomment-787131102
@lidavidm good call -- let me try something else
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #9576:
URL: https://github.com/apache/arrow/pull/9576#issuecomment-787130649
https://issues.apache.org/jira/browse/ARROW-11821
This is an automated message from the Apache Git
alamb commented on pull request #9576:
URL: https://github.com/apache/arrow/pull/9576#issuecomment-787129683
@pierwill I understand your position. Conveniently I have been working on a
script to improve the experience (https://github.com/apache/arrow/pull/9594) so
I am going to reopen
github-actions[bot] commented on pull request #9598:
URL: https://github.com/apache/arrow/pull/9598#issuecomment-787129095
https://issues.apache.org/jira/browse/ARROW-11804
This is an automated message from the Apache Git
alamb opened a new pull request #9598:
URL: https://github.com/apache/arrow/pull/9598
# Rationale
Currently all contributors are required to make a JIRA account and do some
mechanical JIRA creation to create well formed Arrow PRs. This is mindless work
and people who are used to it may
github-actions[bot] commented on pull request #9597:
URL: https://github.com/apache/arrow/pull/9597#issuecomment-787115229
https://issues.apache.org/jira/browse/ARROW-11820
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #9597:
URL: https://github.com/apache/arrow/pull/9597#issuecomment-787114763
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
elferherrera opened a new pull request #9597:
URL: https://github.com/apache/arrow/pull/9597
This adds a macro called creative_native to avoid DRY in the creation of
native types for alloc module
This is an automated
elferherrera commented on a change in pull request #9573:
URL: https://github.com/apache/arrow/pull/9573#discussion_r584165011
##
File path: rust/rfcs/LICENSE-APACHE
##
@@ -0,0 +1,201 @@
+ Apache License
Review comment:
I dont think so. If
elferherrera commented on a change in pull request #9573:
URL: https://github.com/apache/arrow/pull/9573#discussion_r584164907
##
File path: rust/rfcs/-template.md
##
@@ -0,0 +1,27 @@
+- Feature Name: (fill me in with a unique ident, `my_awesome_feature`)
+- Start Date:
elferherrera commented on a change in pull request #9573:
URL: https://github.com/apache/arrow/pull/9573#discussion_r584164881
##
File path: rust/rfcs/-template.md
##
@@ -0,0 +1,27 @@
+- Feature Name: (fill me in with a unique ident, `my_awesome_feature`)
Review comment:
nevi-me commented on a change in pull request #9573:
URL: https://github.com/apache/arrow/pull/9573#discussion_r584147360
##
File path: rust/rfcs/LICENSE-APACHE
##
@@ -0,0 +1,201 @@
+ Apache License
Review comment:
Do we need a license if
nealrichardson commented on a change in pull request #9591:
URL: https://github.com/apache/arrow/pull/9591#discussion_r584147300
##
File path: r/R/dataset-write.R
##
@@ -53,6 +53,17 @@
#' - `codec`: A [Codec] which will be used to compress body buffers of written
#' files.
codecov-io commented on pull request #9596:
URL: https://github.com/apache/arrow/pull/9596#issuecomment-787079131
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9596?src=pr=h1) Report
> Merging
[#9596](https://codecov.io/gh/apache/arrow/pull/9596?src=pr=desc) (f2a9f34)
into
github-actions[bot] commented on pull request #9594:
URL: https://github.com/apache/arrow/pull/9594#issuecomment-787077797
https://issues.apache.org/jira/browse/ARROW-11819
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #9594:
URL: https://github.com/apache/arrow/pull/9594#issuecomment-787076648
https://issues.apache.org/jira/browse/ARROW-11818
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #9594:
URL: https://github.com/apache/arrow/pull/9594#issuecomment-787075600
https://issues.apache.org/jira/browse/ARROW-11817
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #9594:
URL: https://github.com/apache/arrow/pull/9594#issuecomment-787075364
https://issues.apache.org/jira/browse/ARROW-11816
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #9594:
URL: https://github.com/apache/arrow/pull/9594#issuecomment-787075248
https://issues.apache.org/jira/browse/ARROW-11815
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #9596:
URL: https://github.com/apache/arrow/pull/9596#issuecomment-787074912
https://issues.apache.org/jira/browse/ARROW-11495
This is an automated message from the Apache Git
sundy-li opened a new pull request #9596:
URL: https://github.com/apache/arrow/pull/9596
We should consider number overflow in arithmetic operator functions.
```
UIn8 + UIn8 should be UInt16, but now it's UInt8
UInt16 * UInt16 should be UInt64, but now it's UInt16
```
github-actions[bot] commented on pull request #9594:
URL: https://github.com/apache/arrow/pull/9594#issuecomment-787073738
https://issues.apache.org/jira/browse/ARROW-11807
This is an automated message from the Apache Git
lidavidm commented on pull request #9593:
URL: https://github.com/apache/arrow/pull/9593#issuecomment-787070465
@alamb if I'm not mistaken, `serve().await?` will block until the server is
terminated, which means that the test is now stuck. Is there any way to start a
server without
github-actions[bot] commented on pull request #9595:
URL: https://github.com/apache/arrow/pull/9595#issuecomment-787064666
https://issues.apache.org/jira/browse/ARROW-11806
This is an automated message from the Apache Git
Dandandan opened a new pull request #9595:
URL: https://github.com/apache/arrow/pull/9595
This PR changes the way we create an array of indices for an inner join to
avoid generating a null bit map.
It seems currently not really ergonomic to do this with Arrow without
resorting to
yordan-pavlov edited a comment on pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#issuecomment-787062425
@nevi-me this probably deserves its own discussion, but you are pretty close
with your suggestion to avoid `ByteArray`;
I have been doing quite a lot of
yordan-pavlov commented on pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#issuecomment-787062425
@nevi-me this probably deserves its own discussion, but you are pretty close
with your suggestion to avoid ByteArray;
I have been doing quite a lot of profiling and
elferherrera commented on pull request #9567:
URL: https://github.com/apache/arrow/pull/9567#issuecomment-787061390
@seddonm1 I think you dont need to put the `#[cfg(feature)]` to all your
functions. As long as you only put it where you are going to use the module.
Something like this
elferherrera commented on pull request #9573:
URL: https://github.com/apache/arrow/pull/9573#issuecomment-787056503
I've been looking for ways to link the mdbook that could be generated for
the RFCs to the apache arrow website and to be honest, I don't think it is
possible. Also, I think
codecov-io commented on pull request #9594:
URL: https://github.com/apache/arrow/pull/9594#issuecomment-787054968
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9594?src=pr=h1) Report
> Merging
[#9594](https://codecov.io/gh/apache/arrow/pull/9594?src=pr=desc) (b3f0bc2)
into
github-actions[bot] commented on pull request #9594:
URL: https://github.com/apache/arrow/pull/9594#issuecomment-787052762
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
alamb opened a new pull request #9594:
URL: https://github.com/apache/arrow/pull/9594
This is a test PR with a minor fix, that has no JIRA issue, to automatically
create the issue
This is an automated message from the
alamb commented on pull request #9583:
URL: https://github.com/apache/arrow/pull/9583#issuecomment-787051349
Proposed PR here: https://github.com/apache/arrow/pull/9593
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #9593:
URL: https://github.com/apache/arrow/pull/9593#issuecomment-787051350
https://issues.apache.org/jira/browse/ARROW-11717
This is an automated message from the Apache Git
alamb opened a new pull request #9593:
URL: https://github.com/apache/arrow/pull/9593
# Background
Thanks to the 礪 ️ of @lidavidm
https://github.com/apache/arrow/pull/9583#issuecomment-786925049 it appears
that the Rust flight integration test prints `"Server listening"` before the
alamb commented on pull request #9583:
URL: https://github.com/apache/arrow/pull/9583#issuecomment-787050650
Thanks @lidavidm -- that sounds very plausible. I'll get a PR up with a
proposed fix
This is an automated message
nevi-me commented on pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#issuecomment-787049887
> While looking for a way to make loading array data from parquet files
faster
I think the biggest win with strings is if we could avoid `ByteArray` when
using the Arrow
alamb commented on a change in pull request #9571:
URL: https://github.com/apache/arrow/pull/9571#discussion_r584101216
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -1719,20 +1791,27 @@ mod tests {
#[test]
fn test_cast_string_to_timestamp() {
-
codecov-io commented on pull request #9592:
URL: https://github.com/apache/arrow/pull/9592#issuecomment-787041283
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9592?src=pr=h1) Report
> Merging
[#9592](https://codecov.io/gh/apache/arrow/pull/9592?src=pr=desc) (bbe9e0c)
into
nevi-me closed pull request #9571:
URL: https://github.com/apache/arrow/pull/9571
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nevi-me commented on a change in pull request #9592:
URL: https://github.com/apache/arrow/pull/9592#discussion_r584092785
##
File path: rust/parquet/src/schema/types.rs
##
@@ -972,18 +1011,22 @@ fn from_thrift_helper(
}
/// Method to convert to Thrift.
-pub fn
seddonm1 commented on pull request #9523:
URL: https://github.com/apache/arrow/pull/9523#issuecomment-787039512
@edrevo that is great that removing crossbeam solves the test case and it
sounds like a good plan anyway given Tokio explicitly talks about this
potential issue.
It
github-actions[bot] commented on pull request #9592:
URL: https://github.com/apache/arrow/pull/9592#issuecomment-787039217
https://issues.apache.org/jira/browse/ARROW-11803
This is an automated message from the Apache Git
nevi-me opened a new pull request #9592:
URL: https://github.com/apache/arrow/pull/9592
This implements the LogicalType from v2 of the format, by:
- renaming `parquet::basic::LogicalType` to `parquet::basic::ConvertedType`
to reflect the change in the spec
- implementing
edrevo commented on pull request #9523:
URL: https://github.com/apache/arrow/pull/9523#issuecomment-787038003
@alamb, I would like to spend this weekend unblocking a PR I have in
ballista which has been open for a week now, so I would appreciate if you could
pick up
ritchie46 commented on a change in pull request #9571:
URL: https://github.com/apache/arrow/pull/9571#discussion_r584089152
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -1719,20 +1791,27 @@ mod tests {
#[test]
fn test_cast_string_to_timestamp() {
-
58 matches
Mail list logo
