sunchao commented on a change in pull request #9592:
URL: https://github.com/apache/arrow/pull/9592#discussion_r584495886
##
File path: rust/parquet/src/schema/types.rs
##
@@ -972,18 +1011,22 @@ fn from_thrift_helper(
}
/// Method to convert to Thrift.
-pub fn
sunchao commented on a change in pull request #9592:
URL: https://github.com/apache/arrow/pull/9592#discussion_r584495886
##
File path: rust/parquet/src/schema/types.rs
##
@@ -972,18 +1011,22 @@ fn from_thrift_helper(
}
/// Method to convert to Thrift.
-pub fn
nevi-me commented on pull request #9592:
URL: https://github.com/apache/arrow/pull/9592#issuecomment-787629194
@sunchao I've updated the PR, @sadikovi I added a test that checks that we
roundtrip the logical type to the file.
liyafan82 closed pull request #9581:
URL: https://github.com/apache/arrow/pull/9581
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
liyafan82 commented on pull request #9581:
URL: https://github.com/apache/arrow/pull/9581#issuecomment-787626343
@nbruno Thanks for the PR. Merging.
This is an automated message from the Apache Git Service.
To respond to the
seddonm1 commented on a change in pull request #9565:
URL: https://github.com/apache/arrow/pull/9565#discussion_r584420423
##
File path: rust/datafusion/src/physical_plan/type_coercion.rs
##
@@ -168,20 +168,35 @@ fn maybe_data_types(
pub fn can_coerce_from(type_into: ,
jorgecarleitao closed pull request #9492:
URL: https://github.com/apache/arrow/pull/9492
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
seddonm1 commented on pull request #9523:
URL: https://github.com/apache/arrow/pull/9523#issuecomment-787565887
@alamb I have raised a PR to merge in the test so that we can ensure
whatever changes does not cause a hang.
github-actions[bot] commented on pull request #9603:
URL: https://github.com/apache/arrow/pull/9603#issuecomment-787560668
https://issues.apache.org/jira/browse/ARROW-11687
This is an automated message from the Apache Git
seddonm1 opened a new pull request #9603:
URL: https://github.com/apache/arrow/pull/9603
@alamb
This is the test that was hanging without `tokio::task::yield_now().await;`
so we should incorporate it for any future changes.
seddonm1 commented on pull request #9567:
URL: https://github.com/apache/arrow/pull/9567#issuecomment-787554082
Thanks @alamb and @elferherrera
I have incorporated both your ideas within the limitations of the rust
compiler; namely:
1. feature flag names if used like
emkornfield commented on pull request #8375:
URL: https://github.com/apache/arrow/pull/8375#issuecomment-787527668
@pitrou is this obsolete now? I think you checked this in?
This is an automated message from the Apache Git
emkornfield commented on pull request #7110:
URL: https://github.com/apache/arrow/pull/7110#issuecomment-787527442
ugh, sorry I never got to this. will try to look this week hopefully.
This is an automated message from the
emkornfield commented on pull request #9421:
URL: https://github.com/apache/arrow/pull/9421#issuecomment-787527208
a few nits, questions about the additional parameter otherwise LGTM.
This is an automated message from the
emkornfield commented on a change in pull request #9421:
URL: https://github.com/apache/arrow/pull/9421#discussion_r584364445
##
File path:
java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestBasicOperation.java
##
@@ -354,7 +360,7 @@ public void
emkornfield commented on a change in pull request #9421:
URL: https://github.com/apache/arrow/pull/9421#discussion_r584364405
##
File path:
java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestBasicOperation.java
##
@@ -63,6 +63,12 @@
*/
public class
emkornfield commented on a change in pull request #9421:
URL: https://github.com/apache/arrow/pull/9421#discussion_r584364044
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/ArrowMessage.java
##
@@ -137,21 +156,24 @@ public
emkornfield commented on a change in pull request #9421:
URL: https://github.com/apache/arrow/pull/9421#discussion_r584363848
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/ArrowMessage.java
##
@@ -67,7 +67,25 @@
*/
class ArrowMessage
emkornfield commented on a change in pull request #9421:
URL: https://github.com/apache/arrow/pull/9421#discussion_r584363690
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/ArrowMessage.java
##
@@ -67,7 +67,25 @@
*/
class ArrowMessage
emkornfield commented on pull request #8210:
URL: https://github.com/apache/arrow/pull/8210#issuecomment-787525998
CC @dianaclarke who I think has also been working on continuous benchmarking.
This is an automated message
kou commented on a change in pull request #9598:
URL: https://github.com/apache/arrow/pull/9598#discussion_r584360440
##
File path: dev/merge_arrow_pr.py
##
@@ -547,6 +566,86 @@ def get_pr_num():
return input("Which pull request would you like to merge? (e.g. 34): ")
alamb commented on pull request #9600:
URL: https://github.com/apache/arrow/pull/9600#issuecomment-787524146
> Thank you very much!I'm going to do this in two steps, step one: support
case-sensitive functionality, step two: make it case-insensitive by default,
and fix the test cases
kou commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584358894
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
I determined required abseil
yordan-pavlov commented on a change in pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#discussion_r584316571
##
File path: rust/arrow/src/array/array_binary.rs
##
@@ -258,6 +258,8 @@ where
}
}
+// calculate actual data_len,
josiahyan commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584312257
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
The currently available
josiahyan commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584312257
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
The currently available
josiahyan commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584312257
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
The currently available
josiahyan commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584312257
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
The currently available
josiahyan commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584312257
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
The currently available
josiahyan commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584312257
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
The currently available
josiahyan commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584312257
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
The currently available
josiahyan commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584312257
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
The currently available
josiahyan commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584312257
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
The currently available
josiahyan commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584312257
##
File path: ci/conda_env_unix.yml
##
@@ -19,6 +19,8 @@
autoconf
ccache
+google-cloud-cpp=1.20.0
Review comment:
The currently available
jorgecarleitao commented on pull request #9592:
URL: https://github.com/apache/arrow/pull/9592#issuecomment-787462991
FWIW, I think that we should have a bunch of golden parquet files and the
corresponding `.json`, e.g. generated by C++, so that we can change parquets'
implementation
andygrove commented on pull request #9600:
URL: https://github.com/apache/arrow/pull/9600#issuecomment-787461922
I think it is good that we default to Postgres dialect and case-sensitivity
but I would like to make it possible for users to choose other dialects and
case-sensitivity if
ritchie46 commented on pull request #9572:
URL: https://github.com/apache/arrow/pull/9572#issuecomment-787460336
I do think that an `AlignedVec` in Arrow could speed up some code and make
some internal code easier to maintain. If you want I could clean it up and
propose a PR.
To
codecov-io commented on pull request #9602:
URL: https://github.com/apache/arrow/pull/9602#issuecomment-787460272
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9602?src=pr=h1) Report
> Merging
[#9602](https://codecov.io/gh/apache/arrow/pull/9602?src=pr=desc) (85439c1)
into
github-actions[bot] commented on pull request #9602:
URL: https://github.com/apache/arrow/pull/9602#issuecomment-787457715
https://issues.apache.org/jira/browse/ARROW-11630
This is an automated message from the Apache Git
sundy-li opened a new pull request #9602:
URL: https://github.com/apache/arrow/pull/9602
- Introduce `limit: Option` for sort functions, then we can use
[partial_sort](https://crates.io/crates/partial_sort) to achieve better
performance in queries with limit & sort. Datafusion can use it
jorgecarleitao commented on pull request #9598:
URL: https://github.com/apache/arrow/pull/9598#issuecomment-787455963
@ritchie46 and @elferherrera , I agree with you. Arrow did have a slack
channel, but that was closed. See rational here:
thamht4190 edited a comment on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-787455523
I fixed all the comments in this pull, can you please take a look?
@emkornfield @pitrou @bkietz cc @ggershinsky
thamht4190 commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-787455523
I fixed all the comments in this pull, can you please take a look?
@emkornfield @pitrou @bkietz
This is an
wqc200 edited a comment on pull request #9600:
URL: https://github.com/apache/arrow/pull/9600#issuecomment-787454075
>
>
> Thanks @wqc200 -- this is great functionality to have.
>
> I would personally like to have datafusion follow postgres when it comes
to case sensitivity
wqc200 edited a comment on pull request #9600:
URL: https://github.com/apache/arrow/pull/9600#issuecomment-787454075
>
>
> Thanks @wqc200 -- this is great functionality to have.
>
> I would personally like to have datafusion follow postgres when it comes
to case sensitivity
wqc200 commented on pull request #9600:
URL: https://github.com/apache/arrow/pull/9600#issuecomment-787454075
>
>
> Thanks @wqc200 -- this is great functionality to have.
>
> I would personally like to have datafusion follow postgres when it comes
to case sensitivity (rather
wqc200 commented on pull request #9600:
URL: https://github.com/apache/arrow/pull/9600#issuecomment-787453495
>
>
> This would be great to have indeed (and start doing some more testing on,
I think ATM we are both case sensitive and case insensitive.
>
> I agree it would be
jorgecarleitao commented on a change in pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#discussion_r584293489
##
File path: rust/arrow/src/array/array_binary.rs
##
@@ -258,6 +258,8 @@ where
}
}
+// calculate actual data_len,
elferherrera commented on pull request #9598:
URL: https://github.com/apache/arrow/pull/9598#issuecomment-787450579
I would agree that a discord channel would be easier to follow than the
mailing list. It would also help new contributors to get familiar and ask
questions that may take a
Dandandan commented on pull request #9600:
URL: https://github.com/apache/arrow/pull/9600#issuecomment-787450447
This would be great to have indeed (and start doing some more testing on, I
think ATM we are both case sensitive and case insensitive.
I agree it would be best to start
jorgecarleitao commented on a change in pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#discussion_r584293489
##
File path: rust/arrow/src/array/array_binary.rs
##
@@ -258,6 +258,8 @@ where
}
}
+// calculate actual data_len,
yordan-pavlov commented on a change in pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#discussion_r584292408
##
File path: rust/arrow/src/array/array_binary.rs
##
@@ -258,6 +258,8 @@ where
}
}
+// calculate actual data_len,
yordan-pavlov commented on a change in pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#discussion_r584291630
##
File path: rust/arrow/src/array/array_string.rs
##
@@ -205,28 +205,30 @@ where
let (_, data_len) = iter.size_hint();
let
alamb commented on pull request #9596:
URL: https://github.com/apache/arrow/pull/9596#issuecomment-787447714
Thanks @sundy-li -- I will try and review this tomorrow sometime
This is an automated message from the Apache Git
jorgecarleitao commented on a change in pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#discussion_r584290973
##
File path: rust/arrow/src/array/array_string.rs
##
@@ -205,28 +205,30 @@ where
let (_, data_len) = iter.size_hint();
let
alamb commented on a change in pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#discussion_r584290701
##
File path: rust/arrow/src/array/array_binary.rs
##
@@ -258,6 +258,8 @@ where
}
}
+// calculate actual data_len, which may
alamb commented on pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#issuecomment-787446758
> I have been doing quite a lot of profiling and benchmarking in the past
few weeks on loading string arrays from parquet files, and yes, going through
an intermediate Vec
alamb closed pull request #9537:
URL: https://github.com/apache/arrow/pull/9537
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb closed pull request #9576:
URL: https://github.com/apache/arrow/pull/9576
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on pull request #9576:
URL: https://github.com/apache/arrow/pull/9576#issuecomment-787444952
The integration test failures look like
https://issues.apache.org/jira/browse/ARROW-11717 (since hopefully fixed)
alamb commented on a change in pull request #9565:
URL: https://github.com/apache/arrow/pull/9565#discussion_r584288331
##
File path: rust/datafusion/src/physical_plan/type_coercion.rs
##
@@ -168,20 +168,35 @@ fn maybe_data_types(
pub fn can_coerce_from(type_into: ,
codecov-io edited a comment on pull request #9594:
URL: https://github.com/apache/arrow/pull/9594#issuecomment-787054968
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9594?src=pr=h1) Report
> Merging
[#9594](https://codecov.io/gh/apache/arrow/pull/9594?src=pr=desc) (d06a866)
into
alamb commented on pull request #9572:
URL: https://github.com/apache/arrow/pull/9572#issuecomment-787443809
Thanks @ritchie46 -- the idea of `AlignedVec` is quite cool (something like
that would likely be useful for us in IOx when we also want to go back / forth
between `Vec` and arrow
alamb commented on pull request #9329:
URL: https://github.com/apache/arrow/pull/9329#issuecomment-787443066
Thanks @nevi-me . Let me know if there is anything I can do to help
This is an automated message from the Apache
alamb commented on pull request #9598:
URL: https://github.com/apache/arrow/pull/9598#issuecomment-787442027
> In the past I've asked something on the mailing list and on a JIRA issue
and did not get any response. Is there at any time something considered as a
chat/ discussions forum like
alamb commented on pull request #9523:
URL: https://github.com/apache/arrow/pull/9523#issuecomment-787441566
@edrevo / @seddonm1 I am about to run out of time this morning for
removing crossbeam. However, I plan to get to it over the next few days
github-actions[bot] commented on pull request #9601:
URL: https://github.com/apache/arrow/pull/9601#issuecomment-787429360
https://issues.apache.org/jira/browse/ARROW-11825
This is an automated message from the Apache Git
Dandandan opened a new pull request #9601:
URL: https://github.com/apache/arrow/pull/9601
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb commented on pull request #9593:
URL: https://github.com/apache/arrow/pull/9593#issuecomment-787429270
Thanks @alamb !
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ritchie46 commented on pull request #9598:
URL: https://github.com/apache/arrow/pull/9598#issuecomment-787427016
I think this is a good idea, if feels mechanical :).
Piggybacking a bit on this on communications in general. I find the level of
entry (asides from PRs quite high). In
nevi-me commented on pull request #9592:
URL: https://github.com/apache/arrow/pull/9592#issuecomment-787419699
> LGTM. I am not very familiar with the codebase, are there integration
tests to verify that the code with the new changes can read the file written by
the previous version and
Dandandan commented on a change in pull request #9573:
URL: https://github.com/apache/arrow/pull/9573#discussion_r584260452
##
File path: rust/rfcs/-template.md
##
@@ -0,0 +1,27 @@
+- Feature Name: (fill me in with a unique ident, `my_awesome_feature`)
Review comment:
nevi-me closed pull request #9534:
URL: https://github.com/apache/arrow/pull/9534
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nevi-me commented on a change in pull request #9592:
URL: https://github.com/apache/arrow/pull/9592#discussion_r584257095
##
File path: rust/parquet/src/schema/types.rs
##
@@ -1035,22 +1082,26 @@ fn to_thrift_helper(schema: , elements:
Vec) {
github-actions[bot] commented on pull request #9600:
URL: https://github.com/apache/arrow/pull/9600#issuecomment-787415485
https://issues.apache.org/jira/browse/ARROW-11822
This is an automated message from the Apache Git
wqc200 opened a new pull request #9600:
URL: https://github.com/apache/arrow/pull/9600
SELECT database() and SELECT DATABASE () are the same and can be queried
normally
This is an automated message from the Apache Git
76 matches
Mail list logo
