Dandandan commented on a change in pull request #9776:
URL: https://github.com/apache/arrow/pull/9776#discussion_r600216623
##
File path: rust/datafusion/tests/sql.rs
##
@@ -1940,6 +1940,56 @@ async fn query_without_from() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async
trxcllnt commented on issue #9752:
URL: https://github.com/apache/arrow/issues/9752#issuecomment-805550385
Last I knew, Typescript was against compiling file extensions into import
statements. Did this change, or are webpack and typescript at odds now?
@westandy does it work if you s
Dandandan commented on a change in pull request #9776:
URL: https://github.com/apache/arrow/pull/9776#discussion_r600195534
##
File path: rust/datafusion/src/sql/planner.rs
##
@@ -103,17 +104,31 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
/// Generate a logic plan
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359762
Benchmark runs are scheduled for baseline =
ee24399c52c4fb704cbb2a69d489792505bece53 and contender =
efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as
Dandandan commented on a change in pull request #9776:
URL: https://github.com/apache/arrow/pull/9776#discussion_r600195534
##
File path: rust/datafusion/src/sql/planner.rs
##
@@ -103,17 +104,31 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
/// Generate a logic plan
github-actions[bot] removed a comment on pull request #9778:
URL: https://github.com/apache/arrow/pull/9778#issuecomment-804789450
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Th
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359888
Benchmark runs are scheduled for baseline =
ee24399c52c4fb704cbb2a69d489792505bece53 and contender =
efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as
github-actions[bot] commented on pull request #9787:
URL: https://github.com/apache/arrow/pull/9787#issuecomment-805515997
Revision: 87bc73ab240671ac09cb4ac50b62d6e73219400c
Submitted crossbow builds: [ursacomputing/crossbow @
actions-232](https://github.com/ursacomputing/crossbow/br
kou commented on pull request #9787:
URL: https://github.com/apache/arrow/pull/9787#issuecomment-805515649
@github-actions crossbow submit -g linux
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359877
Benchmark runs are scheduled for baseline =
ee24399c52c4fb704cbb2a69d489792505bece53 and contender =
efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359862
Benchmark runs are scheduled for baseline =
ee24399c52c4fb704cbb2a69d489792505bece53 and contender =
efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359805
Benchmark runs are scheduled for baseline =
ee24399c52c4fb704cbb2a69d489792505bece53 and contender =
efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as
emkornfield commented on pull request #9751:
URL: https://github.com/apache/arrow/pull/9751#issuecomment-805496501
@lidavidm is it still worth me taking a look or is the rework going to
change things substantially?
--
This is an automated message from the Apache Git Service.
To respond t
github-actions[bot] commented on pull request #9787:
URL: https://github.com/apache/arrow/pull/9787#issuecomment-805491865
Revision: c2551fd911a60b30f6a20e7868a9b4d4315feee1
Submitted crossbow builds: [ursacomputing/crossbow @
actions-231](https://github.com/ursacomputing/crossbow/br
emkornfield commented on pull request #9750:
URL: https://github.com/apache/arrow/pull/9750#issuecomment-805490480
The JIRA for this PR looks like it might map to the wrong issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
kou commented on pull request #9787:
URL: https://github.com/apache/arrow/pull/9787#issuecomment-805486101
@github-actions crossbow submit -g linux
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield commented on pull request #9750:
URL: https://github.com/apache/arrow/pull/9750#issuecomment-805485975
OK, this PR lacks any documentation to that affect, especially around
pattern. Is this meant to emulate sql server or Oracle's to_char?
--
This is an automated message from
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359787
Benchmark runs are scheduled for baseline =
ee24399c52c4fb704cbb2a69d489792505bece53 and contender =
efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r600151615
##
File path: r/tests/testthat/test-compute-sort.R
##
@@ -0,0 +1,157 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributo
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r600151615
##
File path: r/tests/testthat/test-compute-sort.R
##
@@ -0,0 +1,157 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributo
emkornfield closed pull request #9489:
URL: https://github.com/apache/arrow/pull/9489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r600150212
##
File path: r/R/dplyr.R
##
@@ -631,17 +671,85 @@ abandon_ship <- function(call, .data, msg = NULL) {
eval.parent(call, 2)
}
-arrange.arrow_dplyr_qu
emkornfield commented on pull request #9489:
URL: https://github.com/apache/arrow/pull/9489#issuecomment-805472176
+1, going to merge, we can address any items as a followup. @trucnguyenlam
apologies for the delay.
--
This is an automated message from the Apache Git Service.
To respond t
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r600149524
##
File path: r/R/dplyr.R
##
@@ -364,6 +383,7 @@ set_filters <- function(.data, expressions) {
collect.arrow_dplyr_query <- function(x, as_data_frame =
liyafan82 commented on pull request #9769:
URL: https://github.com/apache/arrow/pull/9769#issuecomment-805469834
> @liyafan82 thanks. A few small comments/nits on documentation, and one
question about the API.
@emkornfield Thanks for your comments. I will address them ASAP.
--
Th
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359762
Benchmark runs are scheduled for baseline =
ee24399c52c4fb704cbb2a69d489792505bece53 and contender =
efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as
github-actions[bot] commented on pull request #9787:
URL: https://github.com/apache/arrow/pull/9787#issuecomment-805461400
https://issues.apache.org/jira/browse/ARROW-12070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kou commented on pull request #9787:
URL: https://github.com/apache/arrow/pull/9787#issuecomment-805461353
@github-actions crossbow submit -g linux
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
kou opened a new pull request #9787:
URL: https://github.com/apache/arrow/pull/9787
Users should use Meson.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries abo
emkornfield commented on issue #9737:
URL: https://github.com/apache/arrow/issues/9737#issuecomment-805457038
Closing. Please if there are follow-ups let's discuss on the user@ mailing
list. One nice addition might be some canonical documentation on how to use
the Go API if one doesn't e
emkornfield closed issue #9737:
URL: https://github.com/apache/arrow/issues/9737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
emkornfield commented on issue #9747:
URL: https://github.com/apache/arrow/issues/9747#issuecomment-805456594
CC @nealrichardson
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
emkornfield commented on issue #9752:
URL: https://github.com/apache/arrow/issues/9752#issuecomment-805456446
@westandy typically we like to answer questions on the
[user@](https://arrow.apache.org/docs/developers/contributing.html#join-the-mailing-lists)
mailing list. I'm going to CC som
emkornfield commented on a change in pull request #9769:
URL: https://github.com/apache/arrow/pull/9769#discussion_r600131274
##
File path:
java/compression/src/main/java/org/apache/arrow/compression/Lz4CompressionCodec.java
##
@@ -38,109 +36,39 @@
/**
* Compression codec f
westonpace commented on pull request #9643:
URL: https://github.com/apache/arrow/pull/9643#issuecomment-805454734
Assuming remaining jobs pass (Travis looks like it is backlogged ~12 hours)
or are unrelated, please merge.
--
This is an automated message from the Apache Git Service.
To re
emkornfield commented on a change in pull request #9769:
URL: https://github.com/apache/arrow/pull/9769#discussion_r600129388
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compression/AbstractCompressionCodec.java
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the
emkornfield closed issue #9781:
URL: https://github.com/apache/arrow/issues/9781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
emkornfield commented on issue #9781:
URL: https://github.com/apache/arrow/issues/9781#issuecomment-805451756
Hi @guidocioni,
You could probably read the data into an [arrow
table](https://arrow.apache.org/docs/python/generated/pyarrow.parquet.read_table.html?highlight=read_table#pyarrow
seddonm1 commented on pull request #9428:
URL: https://github.com/apache/arrow/pull/9428#issuecomment-805451302
@sweb yes, i will have a look in the next day or two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r600118690
##
File path: r/R/arrow-datum.R
##
@@ -138,3 +138,16 @@ as.integer.ArrowDatum <- function(x, ...)
as.integer(as.vector(x), ...)
#' @export
as.characte
liyafan82 closed pull request #9744:
URL: https://github.com/apache/arrow/pull/9744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r600111676
##
File path: r/R/dplyr.R
##
@@ -631,17 +671,85 @@ abandon_ship <- function(call, .data, msg = NULL) {
eval.parent(call, 2)
}
-arrange.arrow_dplyr_qu
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r600110895
##
File path: r/R/dplyr.R
##
@@ -631,17 +671,85 @@ abandon_ship <- function(call, .data, msg = NULL) {
eval.parent(call, 2)
}
-arrange.arrow_dplyr_qu
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r600110657
##
File path: r/R/dplyr.R
##
@@ -631,17 +671,85 @@ abandon_ship <- function(call, .data, msg = NULL) {
eval.parent(call, 2)
}
-arrange.arrow_dplyr_qu
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r600109663
##
File path: r/R/dplyr.R
##
@@ -390,6 +414,16 @@ collect.arrow_dplyr_query <- function(x, as_data_frame =
TRUE, ...) {
tab <- RecordBatch$create
liyafan82 commented on pull request #9744:
URL: https://github.com/apache/arrow/pull/9744#issuecomment-805416730
+1. Thanks @zxf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
github-actions[bot] commented on pull request #9786:
URL: https://github.com/apache/arrow/pull/9786#issuecomment-805412779
https://issues.apache.org/jira/browse/ARROW-11693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #9786:
URL: https://github.com/apache/arrow/pull/9786#issuecomment-805400529
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
github-actions[bot] commented on pull request #9773:
URL: https://github.com/apache/arrow/pull/9773#issuecomment-805400295
https://issues.apache.org/jira/browse/ARROW-12028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For qu
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359805
Benchmark runs are scheduled for baseline =
ee24399c52c4fb704cbb2a69d489792505bece53 and contender =
efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For qu
kou commented on a change in pull request #9767:
URL: https://github.com/apache/arrow/pull/9767#discussion_r600063752
##
File path: dev/tasks/crossbow.py
##
@@ -322,7 +322,11 @@ def create_tree(self, files):
def create_commit(self, files, parents=None, message='',
edponce opened a new pull request #9786:
URL: https://github.com/apache/arrow/pull/9786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
kou commented on a change in pull request #9767:
URL: https://github.com/apache/arrow/pull/9767#discussion_r600062036
##
File path: dev/tasks/python-wheels/github.osx.yml
##
@@ -31,88 +43,107 @@ jobs:
- name: Checkout Arrow
run: |
set -ex
-
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For qu
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r600060349
##
File path: r/R/dplyr.R
##
@@ -364,6 +383,7 @@ set_filters <- function(.data, expressions) {
collect.arrow_dplyr_query <- function(x, as_data_frame =
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359787
Benchmark runs are scheduled for baseline =
ee24399c52c4fb704cbb2a69d489792505bece53 and contender =
efcd862d87912e4efd93da3dc124d3b31d5d3e6b. Results will be available as
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For qu
ursabot edited a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For qu
ursabot commented on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries a
ursabot commented on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-805359762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries a
nealrichardson closed pull request #9757:
URL: https://github.com/apache/arrow/pull/9757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
github-actions[bot] commented on pull request #9785:
URL: https://github.com/apache/arrow/pull/9785#issuecomment-805342020
https://issues.apache.org/jira/browse/ARROW-12069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
velvia commented on a change in pull request #9773:
URL: https://github.com/apache/arrow/pull/9773#discussion_r600023805
##
File path: rust/datafusion/src/physical_plan/hash_join.rs
##
@@ -656,42 +656,20 @@ fn equal_rows(
.zip(right_arrays)
.all(|(l, r)| match
velvia commented on a change in pull request #9773:
URL: https://github.com/apache/arrow/pull/9773#discussion_r600023253
##
File path: rust/datafusion/src/scalar.rs
##
@@ -19,6 +19,11 @@
use std::{convert::TryFrom, fmt, iter::repeat, sync::Arc};
+use arrow::array::{
Revie
westonpace commented on a change in pull request #9779:
URL: https://github.com/apache/arrow/pull/9779#discussion_r67226
##
File path: cpp/src/arrow/util/async_generator.h
##
@@ -278,6 +278,147 @@ AsyncGenerator MakeMappedGenerator(AsyncGenerator
source_generator,
retur
ursabot removed a comment on pull request #9272:
URL: https://github.com/apache/arrow/pull/9272#issuecomment-804609269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For q
Dandandan commented on pull request #9773:
URL: https://github.com/apache/arrow/pull/9773#issuecomment-805313128
This looks good @velvia , I added some minor comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
Dandandan commented on a change in pull request #9773:
URL: https://github.com/apache/arrow/pull/9773#discussion_r64193
##
File path: rust/datafusion/src/physical_plan/hash_join.rs
##
@@ -656,42 +656,20 @@ fn equal_rows(
.zip(right_arrays)
.all(|(l, r)| ma
Dandandan commented on a change in pull request #9773:
URL: https://github.com/apache/arrow/pull/9773#discussion_r63841
##
File path: rust/datafusion/src/scalar.rs
##
@@ -19,6 +19,11 @@
use std::{convert::TryFrom, fmt, iter::repeat, sync::Arc};
+use arrow::array::{
Re
Dandandan commented on a change in pull request #9776:
URL: https://github.com/apache/arrow/pull/9776#discussion_r61227
##
File path: rust/datafusion/tests/sql.rs
##
@@ -1940,6 +1940,56 @@ async fn query_without_from() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async
nealrichardson commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r599985192
##
File path: r/R/arrow-datum.R
##
@@ -138,3 +138,16 @@ as.integer.ArrowDatum <- function(x, ...)
as.integer(as.vector(x), ...)
#' @export
as.ch
alamb commented on pull request #9762:
URL: https://github.com/apache/arrow/pull/9762#issuecomment-805304397
Thanks again @returnString ! This is a great feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb closed pull request #9762:
URL: https://github.com/apache/arrow/pull/9762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
alamb commented on pull request #9773:
URL: https://github.com/apache/arrow/pull/9773#issuecomment-805303369
Thanks @velvia -- I plan to review this tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
alamb commented on pull request #9776:
URL: https://github.com/apache/arrow/pull/9776#issuecomment-805303051
Thank you for this @Dandandan ! I plan to review this carefully tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
jorgecarleitao commented on a change in pull request #9776:
URL: https://github.com/apache/arrow/pull/9776#discussion_r54379
##
File path: rust/datafusion/tests/sql.rs
##
@@ -1940,6 +1940,56 @@ async fn query_without_from() -> Result<()> {
Ok(())
}
+#[tokio::test]
+
rodrigojdebem commented on pull request #9750:
URL: https://github.com/apache/arrow/pull/9750#issuecomment-805294095
> Is this a duplicate of: https://github.com/apache/arrow/pull/8158/files?
@emkornfield the idea of `to_char` is to allow a pattern to be passed as
well so the number
kszucs commented on a change in pull request #9767:
URL: https://github.com/apache/arrow/pull/9767#discussion_r599985796
##
File path: dev/tasks/crossbow.py
##
@@ -322,7 +322,11 @@ def create_tree(self, files):
def create_commit(self, files, parents=None, message='',
kszucs commented on a change in pull request #9767:
URL: https://github.com/apache/arrow/pull/9767#discussion_r599982868
##
File path: dev/tasks/crossbow.py
##
@@ -322,7 +322,11 @@ def create_tree(self, files):
def create_commit(self, files, parents=None, message='',
kszucs commented on a change in pull request #9767:
URL: https://github.com/apache/arrow/pull/9767#discussion_r599982093
##
File path: dev/tasks/python-wheels/github.osx.yml
##
@@ -31,88 +43,107 @@ jobs:
- name: Checkout Arrow
run: |
set -ex
-
kszucs commented on a change in pull request #9767:
URL: https://github.com/apache/arrow/pull/9767#discussion_r599981916
##
File path: dev/tasks/python-wheels/github.osx.yml
##
@@ -31,88 +43,107 @@ jobs:
- name: Checkout Arrow
run: |
set -ex
-
frank400 opened a new pull request #9785:
URL: https://github.com/apache/arrow/pull/9785
Implement support to IN expressions at Arrow's decimals field independently
of its precision or scale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
kou commented on a change in pull request #9767:
URL: https://github.com/apache/arrow/pull/9767#discussion_r599966767
##
File path: ci/scripts/python_wheel_macos_build.sh
##
@@ -0,0 +1,135 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r599969084
##
File path: r/R/dplyr.R
##
@@ -631,17 +669,98 @@ abandon_ship <- function(call, .data, msg = NULL) {
eval.parent(call, 2)
}
-arrange.arrow_dplyr_qu
nealrichardson commented on a change in pull request #9757:
URL: https://github.com/apache/arrow/pull/9757#discussion_r599964739
##
File path: r/R/feather.R
##
@@ -178,8 +178,6 @@ read_feather <- function(file, col_select = NULL,
as_data_frame = TRUE, ...) {
#' takes the foll
kou closed pull request #9777:
URL: https://github.com/apache/arrow/pull/9777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please conta
kou commented on pull request #9777:
URL: https://github.com/apache/arrow/pull/9777#issuecomment-805251400
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries a
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r599917166
##
File path: r/R/dplyr.R
##
@@ -390,6 +409,25 @@ collect.arrow_dplyr_query <- function(x, as_data_frame =
TRUE, ...) {
tab <- RecordBatch$create
github-actions[bot] commented on pull request #9784:
URL: https://github.com/apache/arrow/pull/9784#issuecomment-805223986
https://issues.apache.org/jira/browse/ARROW-12067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r599912716
##
File path: r/R/dplyr.R
##
@@ -631,17 +669,98 @@ abandon_ship <- function(call, .data, msg = NULL) {
eval.parent(call, 2)
}
-arrange.arrow_dplyr_qu
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r599912271
##
File path: r/R/expression.R
##
@@ -181,6 +181,20 @@ find_array_refs <- function(x) {
unlist(out)
}
+get_field_name <- function(x, msg = NULL) {
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r599912007
##
File path: r/R/dplyr.R
##
@@ -390,6 +409,25 @@ collect.arrow_dplyr_query <- function(x, as_data_frame =
TRUE, ...) {
tab <- RecordBatch$create
ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r599911766
##
File path: r/R/array.R
##
@@ -131,6 +133,12 @@ Array <- R6Class("Array",
assert_is(i, "Array")
call_function("filter", self, i, options =
lidavidm commented on a change in pull request #9779:
URL: https://github.com/apache/arrow/pull/9779#discussion_r599902529
##
File path: cpp/src/arrow/util/async_generator.h
##
@@ -278,6 +278,147 @@ AsyncGenerator MakeMappedGenerator(AsyncGenerator
source_generator,
return
bkietz closed pull request #9621:
URL: https://github.com/apache/arrow/pull/9621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
bkietz commented on pull request #9621:
URL: https://github.com/apache/arrow/pull/9621#issuecomment-805201203
+1, merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
F
westonpace commented on a change in pull request #9643:
URL: https://github.com/apache/arrow/pull/9643#discussion_r599887016
##
File path: cpp/src/arrow/util/vector.h
##
@@ -81,5 +84,53 @@ std::vector FilterVector(std::vector values,
Predicate&& predicate) {
return values;
github-actions[bot] commented on pull request #9783:
URL: https://github.com/apache/arrow/pull/9783#issuecomment-805190245
https://issues.apache.org/jira/browse/ARROW-12065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
1 - 100 of 162 matches
Mail list logo
