velvia commented on pull request #9773:
URL: https://github.com/apache/arrow/pull/9773#issuecomment-810817972
It seems the Docker build failed but I can't click on or expand on the
details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
NinaPeng commented on a change in pull request #9060:
URL: https://github.com/apache/arrow/pull/9060#discussion_r604632644
##
File path: cpp/src/gandiva/projector.cc
##
@@ -301,7 +348,24 @@ Status Projector::AllocArrayData(const DataTypePtr& type,
int64_t num_records,
}
NinaPeng commented on a change in pull request #9060:
URL: https://github.com/apache/arrow/pull/9060#discussion_r604630536
##
File path: cpp/src/gandiva/field_descriptor.h
##
@@ -58,12 +63,15 @@ class FieldDescriptor {
bool HasDataBufferPtrIdx() const { return data_buffer_
projjal commented on pull request #9060:
URL: https://github.com/apache/arrow/pull/9060#issuecomment-810807116
> > @emkornfield Thanks for your attention. But I have no idea how to add
list type for jni ExtGandivaType. Would you like to give some suggestions?
>
> You need to be able
projjal commented on pull request #9060:
URL: https://github.com/apache/arrow/pull/9060#issuecomment-810803612
> @emkornfield Thanks for your attention. But I have no idea how to add list
type for jni ExtGandivaType. Would you like to give some suggestions?
You need to be able to con
projjal commented on a change in pull request #9060:
URL: https://github.com/apache/arrow/pull/9060#discussion_r603902501
##
File path: cpp/src/gandiva/array_ops.cc
##
@@ -0,0 +1,76 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
github-actions[bot] commented on pull request #9855:
URL: https://github.com/apache/arrow/pull/9855#issuecomment-810788843
https://issues.apache.org/jira/browse/ARROW-11336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #9854:
URL: https://github.com/apache/arrow/pull/9854#issuecomment-810788508
https://issues.apache.org/jira/browse/ARROW-9731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
kou closed pull request #9831:
URL: https://github.com/apache/arrow/pull/9831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please conta
emkornfield commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-810761494
I'll wait until at least Friday and then merge unless anyone objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nevi-me closed pull request #9825:
URL: https://github.com/apache/arrow/pull/9825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
emkornfield commented on a change in pull request #9817:
URL: https://github.com/apache/arrow/pull/9817#discussion_r604589584
##
File path: go/parquet/compress/compress_test.go
##
@@ -0,0 +1,128 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
emkornfield commented on a change in pull request #9817:
URL: https://github.com/apache/arrow/pull/9817#discussion_r604589430
##
File path: go/parquet/compress/compress_test.go
##
@@ -0,0 +1,128 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
emkornfield commented on pull request #9822:
URL: https://github.com/apache/arrow/pull/9822#issuecomment-810754989
> @emkornfield My only concern is performance. If we are going to address it
in ARROW-11901, this PR is ready for merge IMO.
Yes, I think functionality should come first
liyafan82 commented on pull request #9822:
URL: https://github.com/apache/arrow/pull/9822#issuecomment-810754381
> @liyafan82 I opened https://issues.apache.org/jira/browse/ARROW-12163 to
track making compression levels configurable, any other concerns?
@emkornfield My only concern i
emkornfield commented on pull request #9573:
URL: https://github.com/apache/arrow/pull/9573#issuecomment-810754377
Stumbled across this while searching for something else. I think this is a
great idea. From a governance point of view I would suggest the following.
1. Hold a vote on a
emkornfield closed pull request #9836:
URL: https://github.com/apache/arrow/pull/9836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
emkornfield commented on pull request #9817:
URL: https://github.com/apache/arrow/pull/9817#issuecomment-810751389
sorry this week is particularly bad. I will try to review on the
weekend/next week.
--
This is an automated message from the Apache Git Service.
To respond to the message,
emkornfield commented on pull request #9822:
URL: https://github.com/apache/arrow/pull/9822#issuecomment-810746428
@liyafan82 I opened https://issues.apache.org/jira/browse/ARROW-12163 to
track making compression levels configurable, any other concerns?
--
This is an automated message fr
github-actions[bot] commented on pull request #9853:
URL: https://github.com/apache/arrow/pull/9853#issuecomment-810744943
https://issues.apache.org/jira/browse/ARROW-12157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wjones127 commented on pull request #8844:
URL: https://github.com/apache/arrow/pull/8844#issuecomment-810735907
Projjal, that's a good point. The SQL like function is basically a wrapper
around `regexp_like`. I don't know why I didn't see the optimizations should be
the same.
I wil
westonpace commented on a change in pull request #9808:
URL: https://github.com/apache/arrow/pull/9808#discussion_r604572405
##
File path: cpp/src/arrow/util/async_generator_test.cc
##
@@ -79,20 +79,14 @@ class TrackingGenerator {
std::shared_ptr state_;
};
+// Iterator V
westonpace commented on pull request #9842:
URL: https://github.com/apache/arrow/pull/9842#issuecomment-810733114
@jonkeane That second failure I have tracked now under ARROW-12161
@pitrou Future::All, Future::AllCompleted, and Future::Any (not sure if
we've made this yet) are all re
github-actions[bot] commented on pull request #9852:
URL: https://github.com/apache/arrow/pull/9852#issuecomment-810731255
https://issues.apache.org/jira/browse/ARROW-12154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
westonpace opened a new pull request #9859:
URL: https://github.com/apache/arrow/pull/9859
This reverts commit 9e3aa8560a4ffb0298493110d8a7e9e0c699d6b4.
See discussion in https://issues.apache.org/jira/browse/ARROW-12161
--
This is an automated message from the Apache Git Service.
github-actions[bot] commented on pull request #9851:
URL: https://github.com/apache/arrow/pull/9851#issuecomment-810728866
https://issues.apache.org/jira/browse/ARROW-12155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ericwburden opened a new pull request #9858:
URL: https://github.com/apache/arrow/pull/9858
Add an `into_inner()` method to `ipc::writer::StreamWriter`, allowing users
to recover the underlying writer, consuming the StreamWriter. Essentially
exposes `into_inner()` from the BufWriter contai
github-actions[bot] commented on pull request #9850:
URL: https://github.com/apache/arrow/pull/9850#issuecomment-810724551
https://issues.apache.org/jira/browse/ARROW-12153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cyb70289 commented on a change in pull request #9841:
URL: https://github.com/apache/arrow/pull/9841#discussion_r604553475
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -233,6 +235,282 @@ struct DivideChecked {
}
};
+struct Power {
+ template
+
projjal commented on a change in pull request #9700:
URL: https://github.com/apache/arrow/pull/9700#discussion_r604550069
##
File path: cpp/src/gandiva/function_registry_string.cc
##
@@ -100,6 +100,10 @@ std::vector GetStringFunctionRegistry() {
kResultNul
Crystrix commented on a change in pull request #9700:
URL: https://github.com/apache/arrow/pull/9700#discussion_r604547954
##
File path: cpp/src/gandiva/function_registry_string.cc
##
@@ -100,6 +100,10 @@ std::vector GetStringFunctionRegistry() {
kResultNu
cyb70289 commented on a change in pull request #9838:
URL: https://github.com/apache/arrow/pull/9838#discussion_r604543823
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -411,40 +411,104 @@ void TransformMatchSubstring(const uint8_t* pattern,
int64_t patter
github-actions[bot] commented on pull request #9849:
URL: https://github.com/apache/arrow/pull/9849#issuecomment-810699015
https://issues.apache.org/jira/browse/ARROW-12068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cyb70289 commented on pull request #9843:
URL: https://github.com/apache/arrow/pull/9843#issuecomment-810690610
Thanks @dianaclarke
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
cyb70289 closed pull request #9843:
URL: https://github.com/apache/arrow/pull/9843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alexey-milovidov closed pull request #9857:
URL: https://github.com/apache/arrow/pull/9857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
alexey-milovidov commented on pull request #9857:
URL: https://github.com/apache/arrow/pull/9857#issuecomment-810687074
Sorry, opened by mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alexey-milovidov opened a new pull request #9857:
URL: https://github.com/apache/arrow/pull/9857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
kou opened a new pull request #9856:
URL: https://github.com/apache/arrow/pull/9856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
projjal commented on pull request #8844:
URL: https://github.com/apache/arrow/pull/8844#issuecomment-810671294
Hi @wjones127. Looks like creating a base holder class and two derived class
for just these two functions seems overkill to me (I think thats why I closed
the original pr temporar
github-actions[bot] commented on pull request #9848:
URL: https://github.com/apache/arrow/pull/9848#issuecomment-810667462
https://issues.apache.org/jira/browse/ARROW-12089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
projjal commented on pull request #9853:
URL: https://github.com/apache/arrow/pull/9853#issuecomment-810666971
> > @frank400 Could this be a duplicate of #8844? Or is this function
different?
>
> @wjones127, after I saw your PR I also think it is a duplicate, @projjal
can you take a
github-actions[bot] commented on pull request #9847:
URL: https://github.com/apache/arrow/pull/9847#issuecomment-810663606
https://issues.apache.org/jira/browse/ARROW-12108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#issuecomment-810663512
Revision: 85a06c8fa2da77deb7ceb09a9db02304360579c0
Submitted crossbow builds: [ursacomputing/crossbow @
actions-250](https://github.com/ursacomputing/crossbow/br
kou closed pull request #9045:
URL: https://github.com/apache/arrow/pull/9045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please conta
kou commented on pull request #9045:
URL: https://github.com/apache/arrow/pull/9045#issuecomment-810651397
Thanks for confirming this.
I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#issuecomment-810638539
https://issues.apache.org/jira/browse/ARROW-12143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
velvia commented on pull request #9773:
URL: https://github.com/apache/arrow/pull/9773#issuecomment-810622821
@alamb pushed the cargo fmt fix. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
drin commented on pull request #9810:
URL: https://github.com/apache/arrow/pull/9810#issuecomment-810615985
> @drin thanks for the feedback. I can add a snippet about that as well. If
there are other things that were confusing or difficult to figure out, I'd like
to tackle them too.
drin commented on a change in pull request #9810:
URL: https://github.com/apache/arrow/pull/9810#discussion_r604466376
##
File path: cpp/examples/arrow/dataset-documentation-example.cc
##
@@ -217,24 +229,29 @@ std::shared_ptr SelectAndProjectDataset(
auto scan_builder = data
frank400 commented on pull request #9853:
URL: https://github.com/apache/arrow/pull/9853#issuecomment-810612118
> @frank400 Could this be a duplicate of #8844? Or is this function
different?
@wjones127, after I saw your PR I also think it is a duplicate, @projjal can
you take a look
ianmcook opened a new pull request #9855:
URL: https://github.com/apache/arrow/pull/9855
This improves the **Developing on Windows** docs, adding instructions for
Visual Studio 2019 users and documenting how to use vcpkg to install Arrow
dependencies on Windows.
--
This is an automated
lidavidm commented on pull request #9810:
URL: https://github.com/apache/arrow/pull/9810#issuecomment-810608422
@drin thanks for the feedback. I can add a snippet about that as well. If
there are other things that were confusing or difficult to figure out, I'd like
to tackle them too.
--
drin commented on pull request #9810:
URL: https://github.com/apache/arrow/pull/9810#issuecomment-810607005
@lidavidm I'm curious on your thoughts about other things that
`ScannerBuilder`s can be constructed from and whether this is something we
would want to add to these commits, or if we
lidavidm commented on pull request #9854:
URL: https://github.com/apache/arrow/pull/9854#issuecomment-810602431
Depends on ARROW-7001/#9607 so not quite ready yet. @westonpace, I made
commits here to deprecate uses of Scan() in Python/R which you might want to
just cherry-pick into your ow
lidavidm opened a new pull request #9854:
URL: https://github.com/apache/arrow/pull/9854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
kou closed pull request #9845:
URL: https://github.com/apache/arrow/pull/9845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please conta
kou commented on pull request #9845:
URL: https://github.com/apache/arrow/pull/9845#issuecomment-810568929
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries a
wesm commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-810562937
+1 from me on the content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
wjones127 commented on pull request #9853:
URL: https://github.com/apache/arrow/pull/9853#issuecomment-810546496
@frank400 Could this be a duplicate of
https://github.com/apache/arrow/pull/8844? Or is this function different?
--
This is an automated message from the Apache Git Service.
T
pitrou commented on a change in pull request #9843:
URL: https://github.com/apache/arrow/pull/9843#discussion_r604396615
##
File path: dev/archery/archery/tests/test_benchmarks.py
##
@@ -94,10 +94,16 @@ def test_static_runner_from_json():
archery_result['suites'][0]['bench
jpedroantunes commented on a change in pull request #9844:
URL: https://github.com/apache/arrow/pull/9844#discussion_r604392118
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -1246,6 +1246,39 @@ const char* convert_fromUTF8_binary(gdv_int64 context,
const char*
jpedroantunes commented on a change in pull request #9844:
URL: https://github.com/apache/arrow/pull/9844#discussion_r604391508
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -1246,6 +1246,39 @@ const char* convert_fromUTF8_binary(gdv_int64 context,
const char*
nevi-me commented on pull request #9825:
URL: https://github.com/apache/arrow/pull/9825#issuecomment-810522046
@alamb that's brutal
AMD 3900x (the previous bench was on a MBA)
```
write_batch primitive/1024 values
zeroshade commented on a change in pull request #9817:
URL: https://github.com/apache/arrow/pull/9817#discussion_r604351891
##
File path: go/parquet/compress/compress_test.go
##
@@ -0,0 +1,128 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contrib
frank400 opened a new pull request #9853:
URL: https://github.com/apache/arrow/pull/9853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
zeroshade commented on a change in pull request #9817:
URL: https://github.com/apache/arrow/pull/9817#discussion_r604337163
##
File path: go/parquet/compress/compress_test.go
##
@@ -0,0 +1,128 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contrib
zeroshade commented on a change in pull request #9817:
URL: https://github.com/apache/arrow/pull/9817#discussion_r604336715
##
File path: go/parquet/compress/compress.go
##
@@ -0,0 +1,150 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
dianaclarke commented on a change in pull request #9843:
URL: https://github.com/apache/arrow/pull/9843#discussion_r604325602
##
File path: dev/archery/archery/tests/test_benchmarks.py
##
@@ -94,10 +94,16 @@ def test_static_runner_from_json():
archery_result['suites'][0]['
zeroshade commented on a change in pull request #9817:
URL: https://github.com/apache/arrow/pull/9817#discussion_r604325152
##
File path: go/parquet/compress/compress.go
##
@@ -0,0 +1,150 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
zeroshade commented on a change in pull request #9817:
URL: https://github.com/apache/arrow/pull/9817#discussion_r604324653
##
File path: go/parquet/compress/brotli.go
##
@@ -0,0 +1,112 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
pitrou commented on a change in pull request #9848:
URL: https://github.com/apache/arrow/pull/9848#discussion_r604316680
##
File path: docs/source/developers/benchmarks.rst
##
@@ -33,22 +33,23 @@ The benchmark suites can be run with the ``benchmark run``
sub-command.
.. cod
jpedroantunes commented on a change in pull request #9844:
URL: https://github.com/apache/arrow/pull/9844#discussion_r604220433
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -1246,6 +1246,33 @@ const char* convert_fromUTF8_binary(gdv_int64 context,
const char*
jorisvandenbossche commented on a change in pull request #9848:
URL: https://github.com/apache/arrow/pull/9848#discussion_r604311060
##
File path: docs/source/developers/benchmarks.rst
##
@@ -33,22 +33,23 @@ The benchmark suites can be run with the ``benchmark run``
sub-comman
lidavidm closed pull request #9730:
URL: https://github.com/apache/arrow/pull/9730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
lidavidm commented on pull request #9802:
URL: https://github.com/apache/arrow/pull/9802#issuecomment-810456269
This should be good (minus the known flaky integration test). As suggested
I've changed _filesystemdataset_write such that it only needs to handle
datasets now.
--
This is an
MarcoGorelli commented on pull request #9045:
URL: https://github.com/apache/arrow/pull/9045#issuecomment-810455739
Thanks for updating - looks good, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
projjal commented on a change in pull request #9707:
URL: https://github.com/apache/arrow/pull/9707#discussion_r604305110
##
File path: cpp/cmake_modules/FindOpenSSLAlt.cmake
##
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributo
projjal commented on a change in pull request #9844:
URL: https://github.com/apache/arrow/pull/9844#discussion_r604303465
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -1246,6 +1246,39 @@ const char* convert_fromUTF8_binary(gdv_int64 context,
const char* bin_in
projjal commented on a change in pull request #9844:
URL: https://github.com/apache/arrow/pull/9844#discussion_r604301461
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -1246,6 +1246,39 @@ const char* convert_fromUTF8_binary(gdv_int64 context,
const char* bin_in
WilliamWhispell commented on a change in pull request #9817:
URL: https://github.com/apache/arrow/pull/9817#discussion_r602609760
##
File path: go/parquet/compress/brotli.go
##
@@ -0,0 +1,112 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
projjal opened a new pull request #9852:
URL: https://github.com/apache/arrow/pull/9852
Currently when running gandiva in a OS where the OS doesn't support all the
features of the host cpu, specifically vector instructions like AVX, AVX512
which needs OS support (because the OS or the VM r
ianmcook opened a new pull request #9851:
URL: https://github.com/apache/arrow/pull/9851
This throws an error if the user attempts to create a Table with columns of
different lengths. We already had this for RecordBatches but not for Tables.
--
This is an automated message from the Apach
jonkeane commented on pull request #9842:
URL: https://github.com/apache/arrow/pull/9842#issuecomment-810425509
It looks like the test that is hanging now is
https://github.com/apache/arrow/blob/master/r/tests/testthat/test-dataset.R#L1345-L1367
which interestingly is skipped on windows re
jonkeane commented on pull request #9689:
URL: https://github.com/apache/arrow/pull/9689#issuecomment-810420129
I've taken a look at this and I think this is an overall better (temporary?)
solution than wrapping each function call. Absolutely agree that an earlier +
clearer error will be g
wjones127 commented on pull request #9289:
URL: https://github.com/apache/arrow/pull/9289#issuecomment-810417521
Good call on the tests. Looks like we are still getting a segfault. I will
look into that later today.
--
This is an automated message from the Apache Git Service.
To respond
nevi-me commented on pull request #9850:
URL: https://github.com/apache/arrow/pull/9850#issuecomment-810414900
@alamb, I don't know if this will be useful for you at IOx, but it's useful
for https://github.com/delta-io/delta-rs, which needs stats for book-keeping.
CC @xianwill
--
nevi-me opened a new pull request #9850:
URL: https://github.com/apache/arrow/pull/9850
The stats are useful for some writers who need to perform
book-keeping of files writte.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
pitrou commented on pull request #9849:
URL: https://github.com/apache/arrow/pull/9849#issuecomment-810403793
I triggered additional crossbow builds here:
https://github.com/ursacomputing/crossbow/branches/all?query=build-120 and
https://github.com/ursacomputing/crossbow/branches/all?query
pitrou commented on pull request #9849:
URL: https://github.com/apache/arrow/pull/9849#issuecomment-810399428
It looks like AppVeyor will require more debugging unfortunately :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
emkornfield commented on pull request #9763:
URL: https://github.com/apache/arrow/pull/9763#issuecomment-810394311
> I do not know how to test the automation / scripts other than "in
production" but that might be ok for this kind of PR
@kou gave the pointer of testing on my fork abov
pitrou commented on pull request #9842:
URL: https://github.com/apache/arrow/pull/9842#issuecomment-810390072
I was thinking that this would make producing a stream of futures more
difficult, but perhaps that's not the case actually.
--
This is an automated message from the Apache Git Se
jpedroantunes commented on a change in pull request #9844:
URL: https://github.com/apache/arrow/pull/9844#discussion_r604223982
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -1246,6 +1246,33 @@ const char* convert_fromUTF8_binary(gdv_int64 context,
const char*
jpedroantunes commented on a change in pull request #9844:
URL: https://github.com/apache/arrow/pull/9844#discussion_r604221525
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -1246,6 +1246,33 @@ const char* convert_fromUTF8_binary(gdv_int64 context,
const char*
zeroshade commented on pull request #9836:
URL: https://github.com/apache/arrow/pull/9836#issuecomment-810373785
@sbinet @emkornfield @wesm once this is merged, i have a PR ready for adding
compression handling to the go IPC implementation, I'm just waiting for this to
get merged before fi
jpedroantunes commented on a change in pull request #9844:
URL: https://github.com/apache/arrow/pull/9844#discussion_r604220697
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -1246,6 +1246,33 @@ const char* convert_fromUTF8_binary(gdv_int64 context,
const char*
jpedroantunes commented on a change in pull request #9844:
URL: https://github.com/apache/arrow/pull/9844#discussion_r604220433
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -1246,6 +1246,33 @@ const char* convert_fromUTF8_binary(gdv_int64 context,
const char*
pitrou commented on pull request #9849:
URL: https://github.com/apache/arrow/pull/9849#issuecomment-810366088
Triggered a crossbow build here:
https://github.com/ursacomputing/crossbow/branches/all?query=build-119
--
This is an automated message from the Apache Git Service.
To respond to
Dandandan edited a comment on pull request #9826:
URL: https://github.com/apache/arrow/pull/9826#issuecomment-810362925
Merged with master
A small change with some nice performance benefits for common joins, without
(for now at least) creating a custom hashmap datastructure.
`smal
Dandandan commented on pull request #9826:
URL: https://github.com/apache/arrow/pull/9826#issuecomment-810362925
Rebased against master
A small change with some nice performance benefits for common joins, without
(for now at least) creating a custom hashmap datastructure.
`smallve
1 - 100 of 166 matches
Mail list logo
