[GitHub] [arrow-rs] codecov-commenter commented on pull request #6: Allow creating issues.

2021-04-18 Thread GitBox
codecov-commenter commented on pull request #6: URL: https://github.com/apache/arrow-rs/pull/6#issuecomment-822207066 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/6?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [arrow-rs] jorgecarleitao opened a new pull request #6: Allow creating issues.

2021-04-18 Thread GitBox
jorgecarleitao opened a new pull request #6: URL: https://github.com/apache/arrow-rs/pull/6 This allows users to create new issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #11: [DataFusion] Cross join implementation

2021-04-18 Thread GitBox
codecov-commenter edited a comment on pull request #11: URL: https://github.com/apache/arrow-datafusion/pull/11#issuecomment-822195008 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/11?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #12: Allow adding issues.

2021-04-18 Thread GitBox
codecov-commenter commented on pull request #12: URL: https://github.com/apache/arrow-datafusion/pull/12#issuecomment-822200106 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/12?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[GitHub] [arrow-datafusion] github-actions[bot] commented on pull request #12: Allow adding issues.

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #12: URL: https://github.com/apache/arrow-datafusion/pull/12#issuecomment-822196926 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could yo

[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #11: [DataFusion] Cross join implementation

2021-04-18 Thread GitBox
jorgecarleitao commented on pull request #11: URL: https://github.com/apache/arrow-datafusion/pull/11#issuecomment-822196768 Amazing! :D Since this will land on the next release, I suggest that we add / migrate the corresponding JIRA issue here, so that we can map issues <> features,

[GitHub] [arrow-datafusion] jorgecarleitao opened a new pull request #12: Allow adding issues.

2021-04-18 Thread GitBox
jorgecarleitao opened a new pull request #12: URL: https://github.com/apache/arrow-datafusion/pull/12 Also removed contributing, as that requires a re-write. Problem: currently we cannot add issues; only questions. -- This is an automated message from the Apache Git Service. To res

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #11: [DataFusion] Cross join implementation

2021-04-18 Thread GitBox
codecov-commenter commented on pull request #11: URL: https://github.com/apache/arrow-datafusion/pull/11#issuecomment-822195008 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/11?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[GitHub] [arrow-rs] jorgecarleitao merged pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
jorgecarleitao merged pull request #4: URL: https://github.com/apache/arrow-rs/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [arrow-rs] jorgecarleitao merged pull request #5: Made tests run on any change.

2021-04-18 Thread GitBox
jorgecarleitao merged pull request #5: URL: https://github.com/apache/arrow-rs/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [arrow] Dandandan commented on pull request #10092: ARROW-12441: [Rust][DataFusion] Support cartesian join

2021-04-18 Thread GitBox
Dandandan commented on pull request #10092: URL: https://github.com/apache/arrow/pull/10092#issuecomment-822191461 Moved to https://github.com/apache/arrow-datafusion/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] Dandandan closed pull request #10092: ARROW-12441: [Rust][DataFusion] Support cartesian join

2021-04-18 Thread GitBox
Dandandan closed pull request #10092: URL: https://github.com/apache/arrow/pull/10092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [arrow-datafusion] Dandandan opened a new pull request #11: [DataFusion] Cross join implementation

2021-04-18 Thread GitBox
Dandandan opened a new pull request #11: URL: https://github.com/apache/arrow-datafusion/pull/11 This is a first (naive, but probably not that bad) implementation of the cartesian join and CROSS JOIN syntax. The left side gets loaded into memory and the right side is streamed and ge

[GitHub] [arrow-rs] nevi-me commented on a change in pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
nevi-me commented on a change in pull request #4: URL: https://github.com/apache/arrow-rs/pull/4#discussion_r615547078 ## File path: .github/workflows/dev_pr/link.js ## @@ -1,69 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor licen

[GitHub] [arrow] heymind commented on a change in pull request #10066: ARROW-12306: [Rust][datafusion] Read CSV format text from stdin or memory

2021-04-18 Thread GitBox
heymind commented on a change in pull request #10066: URL: https://github.com/apache/arrow/pull/10066#discussion_r615545715 ## File path: rust/datafusion/src/datasource/csv.rs ## @@ -142,3 +143,142 @@ impl TableProvider for CsvFile { self.statistics.clone() } } +

[GitHub] [arrow] heymind commented on a change in pull request #10066: ARROW-12306: [Rust][datafusion] Read CSV format text from stdin or memory

2021-04-18 Thread GitBox
heymind commented on a change in pull request #10066: URL: https://github.com/apache/arrow/pull/10066#discussion_r615542436 ## File path: rust/datafusion/src/physical_plan/csv.rs ## @@ -106,13 +107,71 @@ impl<'a> CsvReadOptions<'a> { } } +/// SourceReader represents wh

[GitHub] [arrow] github-actions[bot] commented on pull request #10096: ARROW-12444: [Rust] Remove rust

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #10096: URL: https://github.com/apache/arrow/pull/10096#issuecomment-822163265 https://issues.apache.org/jira/browse/ARROW-12444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] jorgecarleitao opened a new pull request #10096: ARROW-12444: [Rust] Remove rust

2021-04-18 Thread GitBox
jorgecarleitao opened a new pull request #10096: URL: https://github.com/apache/arrow/pull/10096 Removes rust from this repository and uses git clone to fetch the arrow-rs repo for integration tests. Each commit is an independent change. May require some fiddling until the CI

[GitHub] [arrow-rs] kou commented on a change in pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
kou commented on a change in pull request #4: URL: https://github.com/apache/arrow-rs/pull/4#discussion_r615521445 ## File path: .github/workflows/dev_pr/link.js ## @@ -1,69 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license a

[GitHub] [arrow-rs] jorgecarleitao commented on a change in pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
jorgecarleitao commented on a change in pull request #4: URL: https://github.com/apache/arrow-rs/pull/4#discussion_r615519868 ## File path: .github/workflows/dev_pr/link.js ## @@ -1,69 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributo

[GitHub] [arrow-rs] github-actions[bot] removed a comment on pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
github-actions[bot] removed a comment on pull request #4: URL: https://github.com/apache/arrow-rs/pull/4#issuecomment-822044188 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you

[GitHub] [arrow-rs] jorgecarleitao commented on a change in pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
jorgecarleitao commented on a change in pull request #4: URL: https://github.com/apache/arrow-rs/pull/4#discussion_r615518051 ## File path: .github/workflows/dev_pr/link.js ## @@ -1,69 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributo

[GitHub] [arrow-rs] nevi-me commented on a change in pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
nevi-me commented on a change in pull request #4: URL: https://github.com/apache/arrow-rs/pull/4#discussion_r615517613 ## File path: .github/workflows/dev_pr/link.js ## @@ -1,69 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor licen

[GitHub] [arrow-datafusion] andygrove merged pull request #10: Fix CI

2021-04-18 Thread GitBox
andygrove merged pull request #10: URL: https://github.com/apache/arrow-datafusion/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow-datafusion] andygrove commented on pull request #10: Fix CI

2021-04-18 Thread GitBox
andygrove commented on pull request #10: URL: https://github.com/apache/arrow-datafusion/pull/10#issuecomment-822111423 Rust tests pass. Travis is complaining about C++, Go, and Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #10: Fix CI

2021-04-18 Thread GitBox
codecov-commenter commented on pull request #10: URL: https://github.com/apache/arrow-datafusion/pull/10#issuecomment-822106435 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/10?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[GitHub] [arrow] github-actions[bot] commented on pull request #10095: ARROW-12443: [C++][Gandiva] Implement castVARCHAR function for varbinary input

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #10095: URL: https://github.com/apache/arrow/pull/10095#issuecomment-822100329 https://issues.apache.org/jira/browse/ARROW-12443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] jpedroantunes opened a new pull request #10095: ARROW-12443: [C++][Gandiva] Implement castVARCHAR function for varbinary input

2021-04-18 Thread GitBox
jpedroantunes opened a new pull request #10095: URL: https://github.com/apache/arrow/pull/10095 Implement castVARCHAR function for varbinary input -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] kszucs commented on pull request #10094: [Release] Release 4.0.0rc1

2021-04-18 Thread GitBox
kszucs commented on pull request #10094: URL: https://github.com/apache/arrow/pull/10094#issuecomment-822093002 The packaging builds are running at https://github.com/ursacomputing/crossbow/branches/all?query=4.0.0-rc1 Travis is the bottleneck there, the arm64 builds are going to take 4-

[GitHub] [arrow] github-actions[bot] commented on pull request #10094: [Release] Release 4.0.0rc1

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #10094: URL: https://github.com/apache/arrow/pull/10094#issuecomment-822088816 Revision: 9f0082d27366f2d1985d0b5abbef7f2f07fd7e7e Submitted crossbow builds: [ursacomputing/crossbow @ actions-331](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] kszucs removed a comment on pull request #10094: [Release] Release 4.0.0rc1

2021-04-18 Thread GitBox
kszucs removed a comment on pull request #10094: URL: https://github.com/apache/arrow/pull/10094#issuecomment-822088599 @github-actions crossbow submit --group verify-rc-source --param release=4.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [arrow] kszucs commented on pull request #10094: [Release] Release 4.0.0rc1

2021-04-18 Thread GitBox
kszucs commented on pull request #10094: URL: https://github.com/apache/arrow/pull/10094#issuecomment-822088680 @github-actions crossbow submit --group verify-rc-source --param release=4.0.0 --param rc=1 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [arrow] kszucs commented on pull request #10094: [Release] Release 4.0.0rc1

2021-04-18 Thread GitBox
kszucs commented on pull request #10094: URL: https://github.com/apache/arrow/pull/10094#issuecomment-822088599 @github-actions crossbow submit --group verify-rc-source --param release=4.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [arrow] kszucs closed pull request #10090: [Release] Verify 4.0.0rc0

2021-04-18 Thread GitBox
kszucs closed pull request #10090: URL: https://github.com/apache/arrow/pull/10090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] kszucs commented on pull request #10090: [Release] Verify 4.0.0rc0

2021-04-18 Thread GitBox
kszucs commented on pull request #10090: URL: https://github.com/apache/arrow/pull/10090#issuecomment-822088580 Closing in favor of RC1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [arrow] github-actions[bot] commented on pull request #10094: [Release] Release 4.0.0rc1

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #10094: URL: https://github.com/apache/arrow/pull/10094#issuecomment-822088159 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you ope

[GitHub] [arrow] kszucs opened a new pull request #10094: [Release] Release 4.0.0rc1

2021-04-18 Thread GitBox
kszucs opened a new pull request #10094: URL: https://github.com/apache/arrow/pull/10094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow] kszucs closed pull request #10093: ARROW-12420: [C++/Dataset] Reading null columns as dictionary not longer possible

2021-04-18 Thread GitBox
kszucs closed pull request #10093: URL: https://github.com/apache/arrow/pull/10093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] kszucs edited a comment on pull request #10093: ARROW-12420: [C++/Dataset] Reading null columns as dictionary not longer possible

2021-04-18 Thread GitBox
kszucs edited a comment on pull request #10093: URL: https://github.com/apache/arrow/pull/10093#issuecomment-822068562 I reproduced the problem using a simple cast test from null array to a dictionary array: ```cpp TEST(Cast, FromNullToDictionary) { auto from = std::make_shar

[GitHub] [arrow] kszucs commented on pull request #10093: ARROW-12420: [C++/Dataset] Reading null columns as dictionary not longer possible

2021-04-18 Thread GitBox
kszucs commented on pull request #10093: URL: https://github.com/apache/arrow/pull/10093#issuecomment-822068562 I reproduced the problem using a simple cast test from null array to a dictionary array: ```cpp TEST(Cast, FromNullToDictionary) { auto from = std::make_shared(10);

[GitHub] [arrow] codecov-commenter edited a comment on pull request #10092: ARROW-12441: [Rust][DataFusion] Support cartesian join

2021-04-18 Thread GitBox
codecov-commenter edited a comment on pull request #10092: URL: https://github.com/apache/arrow/pull/10092#issuecomment-822024485 # [Codecov](https://codecov.io/gh/apache/arrow/pull/10092?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [arrow] kszucs commented on a change in pull request #10093: ARROW-12420: [C++/Dataset] Reading null columns as dictionary not longer possible

2021-04-18 Thread GitBox
kszucs commented on a change in pull request #10093: URL: https://github.com/apache/arrow/pull/10093#discussion_r615455214 ## File path: cpp/src/arrow/array/array_dict.cc ## @@ -80,7 +80,6 @@ int64_t DictionaryArray::GetValueIndex(int64_t i) const { DictionaryArray::Dictionary

[GitHub] [arrow-datafusion] andygrove commented on pull request #10: Fix CI

2021-04-18 Thread GitBox
andygrove commented on pull request #10: URL: https://github.com/apache/arrow-datafusion/pull/10#issuecomment-822056091 It looks like I mistakenly added the arrow-testing submodule under `arrow-testing` instead of just `testing` -- This is an automated message from the Apache Git Service

[GitHub] [arrow-datafusion] andygrove commented on pull request #10: Fix CI

2021-04-18 Thread GitBox
andygrove commented on pull request #10: URL: https://github.com/apache/arrow-datafusion/pull/10#issuecomment-822055819 ``` failed to get arrow data dir: the data dir `/Users/runner/work/arrow-datafusion/arrow-datafusion/testing/data` defined by env ARROW_TEST_DATA not found ``` --

[GitHub] [arrow] codecov-commenter edited a comment on pull request #10092: ARROW-12441: [Rust][DataFusion] Support cartesian join

2021-04-18 Thread GitBox
codecov-commenter edited a comment on pull request #10092: URL: https://github.com/apache/arrow/pull/10092#issuecomment-822024485 # [Codecov](https://codecov.io/gh/apache/arrow/pull/10092?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [arrow] kszucs commented on a change in pull request #10093: ARROW-12420: [C++/Dataset] Reading null columns as dictionary not longer possible

2021-04-18 Thread GitBox
kszucs commented on a change in pull request #10093: URL: https://github.com/apache/arrow/pull/10093#discussion_r615430752 ## File path: cpp/src/arrow/array/array_dict.cc ## @@ -80,7 +80,6 @@ int64_t DictionaryArray::GetValueIndex(int64_t i) const { DictionaryArray::Dictionary

[GitHub] [arrow-datafusion] andygrove commented on pull request #10: Fix CI

2021-04-18 Thread GitBox
andygrove commented on pull request #10: URL: https://github.com/apache/arrow-datafusion/pull/10#issuecomment-822051046 And now crates.io seems to be having issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow-datafusion] jorgecarleitao closed pull request #8: Fixes CI

2021-04-18 Thread GitBox
jorgecarleitao closed pull request #8: URL: https://github.com/apache/arrow-datafusion/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servi

[GitHub] [arrow-rs] jorgecarleitao commented on a change in pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
jorgecarleitao commented on a change in pull request #4: URL: https://github.com/apache/arrow-rs/pull/4#discussion_r615445696 ## File path: .github/workflows/dev_pr/link.js ## @@ -1,69 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributo

[GitHub] [arrow-rs] nevi-me commented on a change in pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
nevi-me commented on a change in pull request #4: URL: https://github.com/apache/arrow-rs/pull/4#discussion_r615445424 ## File path: .github/workflows/dev_pr/link.js ## @@ -1,69 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor licen

[GitHub] [arrow-datafusion] github-actions[bot] commented on pull request #10: Fix CI

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #10: URL: https://github.com/apache/arrow-datafusion/pull/10#issuecomment-822050208 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could yo

[GitHub] [arrow-datafusion] andygrove opened a new pull request #10: Fix CI

2021-04-18 Thread GitBox
andygrove opened a new pull request #10: URL: https://github.com/apache/arrow-datafusion/pull/10 Picking up from Jorge's PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-rs] nevi-me commented on a change in pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
nevi-me commented on a change in pull request #4: URL: https://github.com/apache/arrow-rs/pull/4#discussion_r615445424 ## File path: .github/workflows/dev_pr/link.js ## @@ -1,69 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor licen

[GitHub] [arrow-datafusion] andygrove merged pull request #9: MINOR: Add Arrow and Parquet submodules

2021-04-18 Thread GitBox
andygrove merged pull request #9: URL: https://github.com/apache/arrow-datafusion/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow-datafusion] andygrove opened a new pull request #9: MINOR: Add Arrow and Parquet submodules

2021-04-18 Thread GitBox
andygrove opened a new pull request #9: URL: https://github.com/apache/arrow-datafusion/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [arrow-datafusion] andygrove commented on pull request #8: Fixes CI

2021-04-18 Thread GitBox
andygrove commented on pull request #8: URL: https://github.com/apache/arrow-datafusion/pull/8#issuecomment-822049281 We do not have the arrow/parquet submodules on this repo but we can add them. I will do that now so we are unblocked. -- This is an automated message from the Apache Git

[GitHub] [arrow-datafusion] andygrove commented on pull request #5: [Ballista] Fix Ballista IT

2021-04-18 Thread GitBox
andygrove commented on pull request #5: URL: https://github.com/apache/arrow-datafusion/pull/5#issuecomment-822049083 @edrevo fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #8: Fixes CI

2021-04-18 Thread GitBox
jorgecarleitao commented on pull request #8: URL: https://github.com/apache/arrow-datafusion/pull/8#issuecomment-822048525 @alamb @andygrove , I will logout for today; this is the best I was able to achieve. There is an issue with the `ARROW_TEST_DATA` that is not finding the data. I

[GitHub] [arrow-datafusion] github-actions[bot] commented on pull request #8: Fixes CI

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #8: URL: https://github.com/apache/arrow-datafusion/pull/8#issuecomment-822048218 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you

[GitHub] [arrow-datafusion] jorgecarleitao opened a new pull request #8: Fixes CI

2021-04-18 Thread GitBox
jorgecarleitao opened a new pull request #8: URL: https://github.com/apache/arrow-datafusion/pull/8 * Enables RAT checks * Enables Linting * Enables testing Note that the tests are not passing because the submodule with arrow files is not available, and apparently we use th

[GitHub] [arrow-rs] codecov-commenter commented on pull request #5: Made tests run on any change.

2021-04-18 Thread GitBox
codecov-commenter commented on pull request #5: URL: https://github.com/apache/arrow-rs/pull/5#issuecomment-822047636 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/5?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [arrow-rs] github-actions[bot] commented on pull request #5: Made CI run on any change.

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #5: URL: https://github.com/apache/arrow-rs/pull/5#issuecomment-822047025 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an

[GitHub] [arrow-rs] jorgecarleitao opened a new pull request #5: Made CI run on any change.

2021-04-18 Thread GitBox
jorgecarleitao opened a new pull request #5: URL: https://github.com/apache/arrow-rs/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [arrow] codecov-commenter edited a comment on pull request #10092: ARROW-12441: [Rust][DataFusion] Support cartesian join

2021-04-18 Thread GitBox
codecov-commenter edited a comment on pull request #10092: URL: https://github.com/apache/arrow/pull/10092#issuecomment-822024485 # [Codecov](https://codecov.io/gh/apache/arrow/pull/10092?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [arrow-datafusion] jorgecarleitao closed pull request #3: Fixed CI

2021-04-18 Thread GitBox
jorgecarleitao closed pull request #3: URL: https://github.com/apache/arrow-datafusion/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servi

[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #3: Fixed CI

2021-04-18 Thread GitBox
jorgecarleitao commented on pull request #3: URL: https://github.com/apache/arrow-datafusion/pull/3#issuecomment-822045867 I will close this and move it to be PRed from my fork, to start aligning processes. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [arrow-datafusion] jorgecarleitao merged pull request #7: Bumped arrow.

2021-04-18 Thread GitBox
jorgecarleitao merged pull request #7: URL: https://github.com/apache/arrow-datafusion/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servi

[GitHub] [arrow-datafusion] github-actions[bot] commented on pull request #7: Bumped arrow.

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #7: URL: https://github.com/apache/arrow-datafusion/pull/7#issuecomment-822045089 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you

[GitHub] [arrow-datafusion] jorgecarleitao opened a new pull request #7: Bumped arrow.

2021-04-18 Thread GitBox
jorgecarleitao opened a new pull request #7: URL: https://github.com/apache/arrow-datafusion/pull/7 The arrow test utils are still pointing to the old submodules. This fixes this, which is needed for our CI. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [arrow-datafusion] andygrove opened a new issue #6: [Ballista] Consolidate TPC-H benchmarks

2021-04-18 Thread GitBox
andygrove opened a new issue #6: URL: https://github.com/apache/arrow-datafusion/issues/6 There are now two copies of the benchmark crate, one for DataFusion and one for Ballista, and we should be able to combine them now. -- This is an automated message from the Apache Git Service. To r

[GitHub] [arrow-rs] github-actions[bot] commented on pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #4: URL: https://github.com/apache/arrow-rs/pull/4#issuecomment-822044188 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an

[GitHub] [arrow-rs] jorgecarleitao opened a new pull request #4: Removed bot comment about title and JIRA.

2021-04-18 Thread GitBox
jorgecarleitao opened a new pull request #4: URL: https://github.com/apache/arrow-rs/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [arrow] codecov-commenter edited a comment on pull request #10092: ARROW-12441: [Rust][DataFusion] Support cartesian join

2021-04-18 Thread GitBox
codecov-commenter edited a comment on pull request #10092: URL: https://github.com/apache/arrow/pull/10092#issuecomment-822024485 # [Codecov](https://codecov.io/gh/apache/arrow/pull/10092?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [arrow-datafusion] github-actions[bot] commented on pull request #5: [Ballista] Fix Ballista IT

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #5: URL: https://github.com/apache/arrow-datafusion/pull/5#issuecomment-822042394 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you

[GitHub] [arrow-datafusion] andygrove opened a new pull request #5: [Ballista] Fix Ballista IT

2021-04-18 Thread GitBox
andygrove opened a new pull request #5: URL: https://github.com/apache/arrow-datafusion/pull/5 Closes https://github.com/apache/arrow-datafusion/issues/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [arrow-datafusion] andygrove opened a new issue #4: [Ballista] Fix integration test script

2021-04-18 Thread GitBox
andygrove opened a new issue #4: URL: https://github.com/apache/arrow-datafusion/issues/4 Now that Ballista has dependencies on DataFusion in the same repo, the integration test scripts and Dockerfile need updating to add DataFusion source into the docker image. We may want to add B

[GitHub] [arrow-datafusion] github-actions[bot] commented on pull request #3: Fixed CI

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #3: URL: https://github.com/apache/arrow-datafusion/pull/3#issuecomment-822040680 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you

[GitHub] [arrow-datafusion] jorgecarleitao opened a new pull request #3: Fixed CI

2021-04-18 Thread GitBox
jorgecarleitao opened a new pull request #3: URL: https://github.com/apache/arrow-datafusion/pull/3 * Keeps RAT check * Keeps all DataFusion and Ballista CI * Hacks Archery to run from this repo -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [arrow-datafusion] andygrove opened a new issue #2: [Ballista] Ballista should not have separate DataFrame implementation

2021-04-18 Thread GitBox
andygrove opened a new issue #2: URL: https://github.com/apache/arrow-datafusion/issues/2 hen building the Ballista POC it was necessary to implement a new DataFrame API that wrapped the DataFusion API. One issue is that it wasn't possible to override the behavior of the collect met

[GitHub] [arrow-datafusion] andygrove merged pull request #1: MINOR: Set GitHub description and labels

2021-04-18 Thread GitBox
andygrove merged pull request #1: URL: https://github.com/apache/arrow-datafusion/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow-datafusion] andygrove commented on pull request #1: MINOR: Set GitHub description and labels

2021-04-18 Thread GitBox
andygrove commented on pull request #1: URL: https://github.com/apache/arrow-datafusion/pull/1#issuecomment-822039423 @jorgecarleitao @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion] andygrove opened a new pull request #1: MINOR: Set GitHub description and labels

2021-04-18 Thread GitBox
andygrove opened a new pull request #1: URL: https://github.com/apache/arrow-datafusion/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [arrow] github-actions[bot] commented on pull request #10092: ARROW-12441: Support cartesian join

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #10092: URL: https://github.com/apache/arrow/pull/10092#issuecomment-822038739 https://issues.apache.org/jira/browse/ARROW-12441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow-rs] andygrove merged pull request #3: MINOR: fix indent in asf yaml

2021-04-18 Thread GitBox
andygrove merged pull request #3: URL: https://github.com/apache/arrow-rs/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[GitHub] [arrow-rs] andygrove opened a new pull request #3: MINOR: fix indent in asf yaml

2021-04-18 Thread GitBox
andygrove opened a new pull request #3: URL: https://github.com/apache/arrow-rs/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [arrow-rs] jorgecarleitao closed pull request #1: Disabled merge.

2021-04-18 Thread GitBox
jorgecarleitao closed pull request #1: URL: https://github.com/apache/arrow-rs/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [arrow-rs] jorgecarleitao commented on pull request #1: Disabled merge.

2021-04-18 Thread GitBox
jorgecarleitao commented on pull request #1: URL: https://github.com/apache/arrow-rs/pull/1#issuecomment-822036906 #2 took over :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [arrow-rs] jorgecarleitao merged pull request #2: MINOR: Specify GitHub settings

2021-04-18 Thread GitBox
jorgecarleitao merged pull request #2: URL: https://github.com/apache/arrow-rs/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [arrow-rs] github-actions[bot] commented on pull request #2: Specify GitHub settings

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #2: URL: https://github.com/apache/arrow-rs/pull/2#issuecomment-822036592 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an

[GitHub] [arrow-rs] andygrove opened a new pull request #2: Specify GitHub settings

2021-04-18 Thread GitBox
andygrove opened a new pull request #2: URL: https://github.com/apache/arrow-rs/pull/2 Enable GitHub issues and set project description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [arrow-rs] github-actions[bot] commented on pull request #1: Disabled merge.

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #1: URL: https://github.com/apache/arrow-rs/pull/1#issuecomment-822034799 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an

[GitHub] [arrow-rs] jorgecarleitao opened a new pull request #1: Disabled merge.

2021-04-18 Thread GitBox
jorgecarleitao opened a new pull request #1: URL: https://github.com/apache/arrow-rs/pull/1 Let's try a PR about processes and see how this works. Proposal: keep the main branch with a linear history by deactivating the "merge" option of PRs, like apache/arrow has. -- This is

[GitHub] [arrow] kszucs commented on a change in pull request #10093: ARROW-12420: [C++/Dataset] Reading null columns as dictionary not longer possible

2021-04-18 Thread GitBox
kszucs commented on a change in pull request #10093: URL: https://github.com/apache/arrow/pull/10093#discussion_r615430752 ## File path: cpp/src/arrow/array/array_dict.cc ## @@ -80,7 +80,6 @@ int64_t DictionaryArray::GetValueIndex(int64_t i) const { DictionaryArray::Dictionary

[GitHub] [arrow] kszucs opened a new pull request #10093: ARROW-12420: [C++/Dataset] Reading null columns as dictionary not longer possible

2021-04-18 Thread GitBox
kszucs opened a new pull request #10093: URL: https://github.com/apache/arrow/pull/10093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow] github-actions[bot] commented on pull request #10093: ARROW-12420: [C++/Dataset] Reading null columns as dictionary not longer possible

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #10093: URL: https://github.com/apache/arrow/pull/10093#issuecomment-822029949 https://issues.apache.org/jira/browse/ARROW-12420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] codecov-commenter commented on pull request #10092: WIP cartesian join

2021-04-18 Thread GitBox
codecov-commenter commented on pull request #10092: URL: https://github.com/apache/arrow/pull/10092#issuecomment-822024485 # [Codecov](https://codecov.io/gh/apache/arrow/pull/10092?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [arrow] github-actions[bot] commented on pull request #10092: WIP cartesian join

2021-04-18 Thread GitBox
github-actions[bot] commented on pull request #10092: URL: https://github.com/apache/arrow/pull/10092#issuecomment-822016680 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you ope

[GitHub] [arrow] Dandandan opened a new pull request #10092: WIP cartesian join

2021-04-18 Thread GitBox
Dandandan opened a new pull request #10092: URL: https://github.com/apache/arrow/pull/10092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [arrow] kszucs closed pull request #10091: ARROW-12440: [Release][Packaging] Various packaging, release script and release verification script fixes

2021-04-18 Thread GitBox
kszucs closed pull request #10091: URL: https://github.com/apache/arrow/pull/10091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] kszucs commented on pull request #10087: MINOR: [Rust] [Ballista] Ballista now uses relative paths for dependencies

2021-04-18 Thread GitBox
kszucs commented on pull request #10087: URL: https://github.com/apache/arrow/pull/10087#issuecomment-822002761 I'm going to cut a new RC from the master after merging #10091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

  1   2   >