[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] westonpace commented on a change in pull request #10205: ARROW-12004: [C++] Result is annoying

westonpace commented on a change in pull request #10205: URL: https://github.com/apache/arrow/pull/10205#discussion_r631578198 ## File path: cpp/src/arrow/util/future.h ## @@ -56,6 +47,47 @@ struct is_future> : std::true_type {}; template using result_of_t = typename

[GitHub] [arrow] westonpace commented on a change in pull request #10205: ARROW-12004: [C++] Result is annoying

westonpace commented on a change in pull request #10205: URL: https://github.com/apache/arrow/pull/10205#discussion_r631577351 ## File path: cpp/src/arrow/util/future.h ## @@ -322,56 +341,98 @@ class ARROW_MUST_USE_TYPE Future { return impl_->Wait(seconds); } - //

[GitHub] [arrow] westonpace commented on a change in pull request #10205: ARROW-12004: [C++] Result is annoying

westonpace commented on a change in pull request #10205: URL: https://github.com/apache/arrow/pull/10205#discussion_r631576939 ## File path: cpp/src/arrow/util/future.h ## @@ -322,56 +341,98 @@ class ARROW_MUST_USE_TYPE Future { return impl_->Wait(seconds); } - //

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] westonpace commented on pull request #10205: ARROW-12004: [C++] Result is annoying

westonpace commented on pull request #10205: URL: https://github.com/apache/arrow/pull/10205#issuecomment-840311677 Ok, using @bkietz 's suggestions I was able to collapse the two classes back into one. I still have some cleanup to do so this is not ready for review yet. The result is

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow-datafusion] msathis commented on pull request #288: [Datafusion] NOW() function support

msathis commented on pull request #288: URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-840305737 I think we should create another category of functions called `StatefulFunction` as @jorgecarleitao explained above. This seems like a clean solution without any hacks

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] projjal commented on a change in pull request #10059: ARROW-12410: [C++][Gandiva] Implement regexp_replace function on Gandiva

projjal commented on a change in pull request #10059: URL: https://github.com/apache/arrow/pull/10059#discussion_r631561351 ## File path: cpp/src/gandiva/replace_holder.h ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] projjal commented on a change in pull request #10059: ARROW-12410: [C++][Gandiva] Implement regexp_replace function on Gandiva

projjal commented on a change in pull request #10059: URL: https://github.com/apache/arrow/pull/10059#discussion_r631558917 ## File path: cpp/src/gandiva/replace_holder.h ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] projjal commented on pull request #9890: ARROW-12205: [C++][Gandiva] Implement TO_TIME([number] seconds) and TO_TIMESTAMP([number] seconds) function

projjal commented on pull request #9890: URL: https://github.com/apache/arrow/pull/9890#issuecomment-840291914 There is a failing build in the added unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] mathyingzhou commented on a change in pull request #10157: ARROW-9299: [C++][Python] Expose ORC metadata

mathyingzhou commented on a change in pull request #10157: URL: https://github.com/apache/arrow/pull/10157#discussion_r631554343 ## File path: python/pyarrow/_orc.pyx ## @@ -22,16 +22,19 @@ from cython.operator cimport dereference as deref from libcpp.vector cimport vector

[GitHub] [arrow] mathyingzhou commented on a change in pull request #10157: ARROW-9299: [C++][Python] Expose ORC metadata

mathyingzhou commented on a change in pull request #10157: URL: https://github.com/apache/arrow/pull/10157#discussion_r631553536 ## File path: python/pyarrow/orc.py ## @@ -26,11 +26,13 @@ def _is_map(typ): -return (types.is_list(typ) and -

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] anthonylouisbsb commented on pull request #10300: ARROW-12699: [CI][Packaging][Java] Generate a jar compatible with Linux and MacOS for all Arrow components

anthonylouisbsb commented on pull request #10300: URL: https://github.com/apache/arrow/pull/10300#issuecomment-840285843 @kszucs I applied the changes you suggested in the review. Thanks in advance for your help! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #323: add print options and allow timing info to be turned on/off

codecov-commenter commented on pull request #323: URL: https://github.com/apache/arrow-datafusion/pull/323#issuecomment-840282559 #

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow-datafusion] Jimexist commented on pull request #323: add print options and allow timing info to be turned on/off

Jimexist commented on pull request #323: URL: https://github.com/apache/arrow-datafusion/pull/323#issuecomment-840275353 > Thanks @Jimexist this is looking very cool changed to `quiet` -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #323: add print options and allow timing info to be turned on/off

Jimexist commented on a change in pull request #323: URL: https://github.com/apache/arrow-datafusion/pull/323#discussion_r631542670 ## File path: datafusion-cli/src/main.rs ## @@ -72,6 +69,14 @@ pub async fn main() { .validator(is_valid_format)

[GitHub] [arrow] cyb70289 edited a comment on pull request #10274: ARROW-12685: [C++][Compute] Add unary absolute value kernel

cyb70289 edited a comment on pull request #10274: URL: https://github.com/apache/arrow/pull/10274#issuecomment-840269487 Thanks @edponce for deep investigation. From std::abs() [document](https://en.cppreference.com/w/cpp/numeric/math/abs), it is *UB* if input is

[GitHub] [arrow] cyb70289 commented on pull request #10274: ARROW-12685: [C++][Compute] Add unary absolute value kernel

cyb70289 commented on pull request #10274: URL: https://github.com/apache/arrow/pull/10274#issuecomment-840269487 Thanks @edponce for deep investigation. From std::abs() [document](https://en.cppreference.com/w/cpp/numeric/math/abs), it is *UB* if input is `numeic_limit::min()`. So

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] github-actions[bot] commented on pull request #10306: ARROW-12756: [C++] MSVC build fails with latest gtest from vcpkg

github-actions[bot] commented on pull request #10306: URL: https://github.com/apache/arrow/pull/10306#issuecomment-840267321 Revision: db14a1ef4c4bc6d75a9ac493b1a877a32c75f996 Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] ianmcook commented on pull request #10306: ARROW-12756: [C++] MSVC build fails with latest gtest from vcpkg

ianmcook commented on pull request #10306: URL: https://github.com/apache/arrow/pull/10306#issuecomment-840267009 @github-actions crossbow submit test-build-vcpkg-win -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] edponce edited a comment on pull request #10274: ARROW-12685: [C++][Compute] Add unary absolute value kernel

edponce edited a comment on pull request #10274: URL: https://github.com/apache/arrow/pull/10274#issuecomment-840258476 @cyb70289 I noticed that *clang* removes the check of `if (result < 0)` because it seems that during the analysis it has a rule that the result of `std::abs()` is never

[GitHub] [arrow] edponce edited a comment on pull request #10274: ARROW-12685: [C++][Compute] Add unary absolute value kernel

edponce edited a comment on pull request #10274: URL: https://github.com/apache/arrow/pull/10274#issuecomment-840258476 @cyb70289 I noticed that *clang* removes the check of `if (result < 0)` because it seems that during the analysis it has a rule that the result of `std::abs()` is never

[GitHub] [arrow] edponce edited a comment on pull request #10274: ARROW-12685: [C++][Compute] Add unary absolute value kernel

edponce edited a comment on pull request #10274: URL: https://github.com/apache/arrow/pull/10274#issuecomment-840258476 @cyb70289 I noticed that *clang* removes the check of `if (result < 0)` because it seems that during the analysis it has a rule that the result of `std::abs()` is never

[GitHub] [arrow] edponce commented on pull request #10274: ARROW-12685: [C++][Compute] Add unary absolute value kernel

edponce commented on pull request #10274: URL: https://github.com/apache/arrow/pull/10274#issuecomment-840258476 @cyb70289 I noticed that *clang* removes the check of `if (result < 0)` because it seems that during the analysis it has a rule that the result of `abs` is never negative, but

[GitHub] [arrow] ianmcook edited a comment on pull request #10191: ARROW-12731: [R] Use InMemoryDataset for Table/RecordBatch in dplyr code

ianmcook edited a comment on pull request #10191: URL: https://github.com/apache/arrow/pull/10191#issuecomment-840255927 This looks great. The increased dependency on Dataset means we will have to skip many more tests to make `test-r-minimal-build` pass. -- This is an automated

[GitHub] [arrow] ianmcook commented on pull request #10191: ARROW-12731: [R] Use InMemoryDataset for Table/RecordBatch in dplyr code

ianmcook commented on pull request #10191: URL: https://github.com/apache/arrow/pull/10191#issuecomment-840255927 This looks great. The increased dependency on Dataset means we will have to skip many more tests to make {{test-r-minimal-build}} pass. -- This is an automated

[GitHub] [arrow] ianmcook commented on a change in pull request #10191: ARROW-12731: [R] Use InMemoryDataset for Table/RecordBatch in dplyr code

ianmcook commented on a change in pull request #10191: URL: https://github.com/apache/arrow/pull/10191#discussion_r631530324 ## File path: r/R/dplyr.R ## @@ -58,40 +63,36 @@ arrow_dplyr_query <- function(.data) { ) } +make_field_refs <- function(field_names) { +

[GitHub] [arrow] edponce commented on a change in pull request #10274: ARROW-12685: [C++][Compute] Add unary absolute value kernel

edponce commented on a change in pull request #10274: URL: https://github.com/apache/arrow/pull/10274#discussion_r631529736 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -79,22 +79,20 @@ struct AbsoluteValue { template static constexpr

[GitHub] [arrow] cyb70289 closed pull request #10303: ARROW-12530: [C++] Remove Buffer::mutable_data_

cyb70289 closed pull request #10303: URL: https://github.com/apache/arrow/pull/10303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] cyb70289 commented on pull request #10303: ARROW-12530: [C++] Remove Buffer::mutable_data_

cyb70289 commented on pull request #10303: URL: https://github.com/apache/arrow/pull/10303#issuecomment-840242011 Travis CI error not related. Arm64 test succeeded on my local host. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow] guyuqi commented on a change in pull request #9424: ARROW-11502: [C++] Optimize Arrow ByteStreamSplitDecode with Neon

guyuqi commented on a change in pull request #9424: URL: https://github.com/apache/arrow/pull/9424#discussion_r631512360 ## File path: cpp/src/arrow/util/byte_stream_split.h ## @@ -23,25 +23,33 @@ #include #include +#if defined(ARROW_HAVE_NEON) ||

[GitHub] [arrow] cyb70289 commented on a change in pull request #10274: ARROW-12685: [C++][Compute] Add unary absolute value kernel

cyb70289 commented on a change in pull request #10274: URL: https://github.com/apache/arrow/pull/10274#discussion_r631509260 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -79,22 +79,20 @@ struct AbsoluteValue { template static constexpr

[GitHub] [arrow] github-actions[bot] commented on pull request #10306: ARROW-12756: [C++] MSVC build fails with latest gtest from vcpkg

github-actions[bot] commented on pull request #10306: URL: https://github.com/apache/arrow/pull/10306#issuecomment-840224988 Revision: 460a4faaaba0500d3b16add9f2fedefb029e084f Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] ianmcook commented on pull request #10306: ARROW-12756: [C++] MSVC build fails with latest gtest from vcpkg

ianmcook commented on pull request #10306: URL: https://github.com/apache/arrow/pull/10306#issuecomment-840224709 @github-actions crossbow submit test-build-vcpkg-win -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] github-actions[bot] commented on pull request #10308: ARROW-12770: [Plasma][C++][JAVA] Add Metrics API for clients to get share memory usage

github-actions[bot] commented on pull request #10308: URL: https://github.com/apache/arrow/pull/10308#issuecomment-840215015 https://issues.apache.org/jira/browse/ARROW-12770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] jikunshang opened a new pull request #10308: ARROW-12770: [Plasma][C++][JAVA] Add Metrics API for clients to get share memory usage

jikunshang opened a new pull request #10308: URL: https://github.com/apache/arrow/pull/10308 Implement an API for Plasma clients to get share memory usage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

ursabot edited a comment on pull request #10269: URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969 Benchmark runs are scheduled for baseline = 4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender = dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

[GitHub] [arrow] ursabot edited a comment on pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

ursabot edited a comment on pull request #10294: URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409 Benchmark runs are scheduled for baseline = 553f3d8211271e8eb576c9668e53dd5dc53c480a and contender = 23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available

  1   2   3   4   >