codecov-commenter edited a comment on pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-835710437
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/288?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
msathis commented on pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-841036217
I have reverted the last commit & added @alamb approach from #335. Took care
of the review comments as well. @alamb @jorgecarleitao Can you please give
another look at th
msathis commented on a change in pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#discussion_r632307469
##
File path: datafusion/src/physical_plan/functions.rs
##
@@ -3611,17 +3607,19 @@ mod tests {
Ok(())
}
-#[test]
-fn test_c
codecov-commenter commented on pull request #289:
URL: https://github.com/apache/arrow-rs/pull/289#issuecomment-841029744
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/289?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
jorgecarleitao edited a comment on pull request #289:
URL: https://github.com/apache/arrow-rs/pull/289#issuecomment-841022656
The changelog up to today looks as below. I find placing the PRs nice
because they give explicit credit to the contributors, but we can also trim
them.
@ianm
jorgecarleitao commented on pull request #289:
URL: https://github.com/apache/arrow-rs/pull/289#issuecomment-841022656
The changelog up to today looks as below. I find placing the PRs nice
because they give explicit credit to the contributors, but we can also trim
them.
@ianmcook ,
jorgecarleitao opened a new pull request #289:
URL: https://github.com/apache/arrow-rs/pull/289
Closes #274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
github-actions[bot] commented on pull request #10321:
URL: https://github.com/apache/arrow/pull/10321#issuecomment-841020552
https://issues.apache.org/jira/browse/ARROW-12675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
n3world opened a new pull request #10321:
URL: https://github.com/apache/arrow/pull/10321
For serial CSV readers track the absolute row number and report it in errors
encountered during parsing or converting.
I did try to get row numbers for the parallel reader but the only way I
th
codecov-commenter edited a comment on pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-835710437
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/288?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
jorgecarleitao commented on issue #274:
URL: https://github.com/apache/arrow-rs/issues/274#issuecomment-840994782
I will have a take on this one. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
edponce edited a comment on pull request #10274:
URL: https://github.com/apache/arrow/pull/10274#issuecomment-838763550
I named the compute function as `AbsoluteValue` and kernels as
"absolute_value" but this feels like too long a name. Convention across other
libraries is "abs" but Arrow'
edponce commented on a change in pull request #10274:
URL: https://github.com/apache/arrow/pull/10274#discussion_r632247362
##
File path: cpp/src/arrow/util/int_util_internal.h
##
@@ -63,9 +63,9 @@ OPS_WITH_OVERFLOW(DivideWithOverflow, div)
#undef OP_WITH_OVERFLOW
#undef OPS_
cyb70289 commented on a change in pull request #10317:
URL: https://github.com/apache/arrow/pull/10317#discussion_r632245699
##
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##
@@ -91,6 +91,25 @@ TYPED_TEST(TestStringKernels, AsciiLower) {
"
edponce commented on pull request #10317:
URL: https://github.com/apache/arrow/pull/10317#issuecomment-840976553
Learned from @cyb70289 that new kernels need to extend both C++ and Python
documentation:
1. https://github.com/apache/arrow/blob/master/docs/source/cpp/compute.rst
2.
htt
hcoona commented on pull request #10312:
URL: https://github.com/apache/arrow/pull/10312#issuecomment-840973204
Nice to know it. The MR updated for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cyb70289 commented on pull request #10274:
URL: https://github.com/apache/arrow/pull/10274#issuecomment-840965703
Also, would you rebase to fix some CI failures?
https://github.com/apache/arrow/pull/10310
--
This is an automated message from the Apache Git Service.
To respond to the mess
Jimexist commented on a change in pull request #275:
URL: https://github.com/apache/arrow-rs/pull/275#discussion_r632228845
##
File path: arrow/src/compute/kernels/arity.rs
##
@@ -72,3 +73,37 @@ where
let data = into_primitive_array_data::<_, O>(array, buffer);
Primit
cyb70289 commented on a change in pull request #10274:
URL: https://github.com/apache/arrow/pull/10274#discussion_r632209010
##
File path: docs/source/cpp/compute.rst
##
@@ -260,6 +260,10 @@ an ``Invalid`` :class:`Status` when overflow is detected.
+--
github-actions[bot] commented on pull request #10320:
URL: https://github.com/apache/arrow/pull/10320#issuecomment-840930383
https://issues.apache.org/jira/browse/ARROW-12774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
nirandaperera opened a new pull request #10320:
URL: https://github.com/apache/arrow/pull/10320
fixing ARROW-12774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For quer
anthonylouisbsb commented on pull request #10300:
URL: https://github.com/apache/arrow/pull/10300#issuecomment-840929681
@kszucs I applied all changes you suggested!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
anthonylouisbsb commented on a change in pull request #10300:
URL: https://github.com/apache/arrow/pull/10300#discussion_r632198627
##
File path: dev/tasks/jars/build-java.sh
##
@@ -23,12 +23,14 @@ CPP_BUILD_DIR=$GITHUB_WORKSPACE/arrow/dist/
pushd java
# build the entire
anthonylouisbsb commented on a change in pull request #10300:
URL: https://github.com/apache/arrow/pull/10300#discussion_r632198549
##
File path: dev/tasks/jars/check-shared-dependencies.sh
##
@@ -23,36 +23,51 @@ CPP_BUILD_DIR=$GITHUB_WORKSPACE/arrow/dist/
if [[ $OS_NAME ==
kou closed pull request #10319:
URL: https://github.com/apache/arrow/pull/10319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
kou commented on pull request #10319:
URL: https://github.com/apache/arrow/pull/10319#issuecomment-840904722
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For qu
westonpace commented on pull request #10272:
URL: https://github.com/apache/arrow/pull/10272#issuecomment-840899285
I've added the call to invert. I went ahead and added a `memory_pool`
parameter per @&res suggestion on the JIRA. I also verified that we can create
null elements in a `Lis
lidavidm commented on pull request #10319:
URL: https://github.com/apache/arrow/pull/10319#issuecomment-840883095
Title & order fixed, thank you!
I kicked Travis again, though it seems unrelated, and the integration build
should be fixed by #10314.
--
This is an automated message
westonpace commented on pull request #10205:
URL: https://github.com/apache/arrow/pull/10205#issuecomment-840876262
Ok, @bkietz 's tricks **almost** worked. Turns out some older MSVC
compilers can get confused when figuring out overloads based only on the return
value
(https://ci.appveyo
nirandaperera commented on a change in pull request #10317:
URL: https://github.com/apache/arrow/pull/10317#discussion_r632123654
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -266,6 +266,52 @@ void EnsureLookupTablesFilled() {}
#endif // ARROW_WITH_UTF
nirandaperera commented on a change in pull request #10317:
URL: https://github.com/apache/arrow/pull/10317#discussion_r632123654
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -266,6 +266,52 @@ void EnsureLookupTablesFilled() {}
#endif // ARROW_WITH_UTF
alamb commented on a change in pull request #337:
URL: https://github.com/apache/arrow-datafusion/pull/337#discussion_r632120108
##
File path: datafusion/tests/sql.rs
##
@@ -2885,3 +2885,45 @@ async fn test_cast_expressions_error() -> Result<()> {
Ok(())
}
+
+#[tokio::t
westonpace commented on pull request #10289:
URL: https://github.com/apache/arrow/pull/10289#issuecomment-840847789
Per @pitrou 's suggestion I have removed the logic auto-generating field_id
entirely. I also added a python test to ensure things are working full path.
This is ready
zeroshade commented on pull request #10071:
URL: https://github.com/apache/arrow/pull/10071#issuecomment-840831709
The integration test failure i believe has nothing to do with this change as
far as i can tell
--
This is an automated message from the Apache Git Service.
To respond to the
kou commented on pull request #10319:
URL: https://github.com/apache/arrow/pull/10319#issuecomment-840831281
Could you also improve the title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on a change in pull request #10319:
URL: https://github.com/apache/arrow/pull/10319#discussion_r632099902
##
File path: ci/scripts/msys2_setup.sh
##
@@ -34,6 +34,7 @@ case "${target}" in
packages+=(${MINGW_PACKAGE_PREFIX}-gflags)
packages+=(${MINGW_PACKA
github-actions[bot] commented on pull request #10319:
URL: https://github.com/apache/arrow/pull/10319#issuecomment-840819138
https://issues.apache.org/jira/browse/ARROW-12780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
lidavidm opened a new pull request #10319:
URL: https://github.com/apache/arrow/pull/10319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
Dandandan commented on pull request #337:
URL: https://github.com/apache/arrow-datafusion/pull/337#issuecomment-840818860
Looking much better @alamb !!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Dandandan commented on a change in pull request #337:
URL: https://github.com/apache/arrow-datafusion/pull/337#discussion_r632087097
##
File path: datafusion/tests/sql.rs
##
@@ -2885,3 +2885,45 @@ async fn test_cast_expressions_error() -> Result<()> {
Ok(())
}
+
+#[toki
Dandandan commented on a change in pull request #337:
URL: https://github.com/apache/arrow-datafusion/pull/337#discussion_r632087097
##
File path: datafusion/tests/sql.rs
##
@@ -2885,3 +2885,45 @@ async fn test_cast_expressions_error() -> Result<()> {
Ok(())
}
+
+#[toki
Dandandan commented on a change in pull request #337:
URL: https://github.com/apache/arrow-datafusion/pull/337#discussion_r632087097
##
File path: datafusion/tests/sql.rs
##
@@ -2885,3 +2885,45 @@ async fn test_cast_expressions_error() -> Result<()> {
Ok(())
}
+
+#[toki
Dandandan commented on a change in pull request #337:
URL: https://github.com/apache/arrow-datafusion/pull/337#discussion_r632083020
##
File path: datafusion/tests/sql.rs
##
@@ -2885,3 +2885,45 @@ async fn test_cast_expressions_error() -> Result<()> {
Ok(())
}
+
+#[toki
NGA-TRAN commented on a change in pull request #337:
URL: https://github.com/apache/arrow-datafusion/pull/337#discussion_r632084193
##
File path: datafusion/tests/sql.rs
##
@@ -2885,3 +2885,45 @@ async fn test_cast_expressions_error() -> Result<()> {
Ok(())
}
+
+#[tokio
Dandandan commented on a change in pull request #337:
URL: https://github.com/apache/arrow-datafusion/pull/337#discussion_r632083020
##
File path: datafusion/tests/sql.rs
##
@@ -2885,3 +2885,45 @@ async fn test_cast_expressions_error() -> Result<()> {
Ok(())
}
+
+#[toki
NGA-TRAN commented on a change in pull request #337:
URL: https://github.com/apache/arrow-datafusion/pull/337#discussion_r632078747
##
File path: datafusion/tests/sql.rs
##
@@ -2885,3 +2885,45 @@ async fn test_cast_expressions_error() -> Result<()> {
Ok(())
}
+
+#[tokio
kou commented on a change in pull request #10311:
URL: https://github.com/apache/arrow/pull/10311#discussion_r632074335
##
File path: dev/archery/archery/cli.py
##
@@ -789,7 +789,9 @@ def integration(with_all=False, random_seed=12345, **args):
default='-', requir
returnString edited a comment on pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-840800353
> I also am not sure I would call now() "stateful" in the sense that it has
state that changes during the execution of the query. It is more like
"parameteriz
returnString commented on pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-840800353
> I also am not sure I would call now() "stateful" in the sense that it has
state that changes during the execution of the query. It is more like
"parameterized" or
alamb commented on a change in pull request #275:
URL: https://github.com/apache/arrow-rs/pull/275#discussion_r632068820
##
File path: arrow/src/compute/kernels/arity.rs
##
@@ -72,3 +73,37 @@ where
let data = into_primitive_array_data::<_, O>(array, buffer);
Primitive
github-actions[bot] commented on pull request #10318:
URL: https://github.com/apache/arrow/pull/10318#issuecomment-840778565
https://issues.apache.org/jira/browse/ARROW-12050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
lidavidm opened a new pull request #10318:
URL: https://github.com/apache/arrow/pull/10318
This uses a stop token to let interactive users interrupt a long-running
Flight operation. It's not perfect: the operation won't be cancelled until the
server delivers a message, so this doesn't prot
github-actions[bot] commented on pull request #10317:
URL: https://github.com/apache/arrow/pull/10317#issuecomment-840776704
https://issues.apache.org/jira/browse/ARROW-12713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
nirandaperera opened a new pull request #10317:
URL: https://github.com/apache/arrow/pull/10317
This PR adds ascii and utf8 reverse kernels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
domoritz commented on pull request #10277:
URL: https://github.com/apache/arrow/pull/10277#issuecomment-840772814
Test failure is due to https://github.com/apache/arrow/pull/10314.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
alamb edited a comment on pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-840763111
@jorgecarleitao Also, I am not convinced about how valuable a general
purpose `StatefulFunction` will be (though of course it depends on a proposal
that is not yet
alamb commented on pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-840763111
@jorgecarleitao Also, I am not convinced about how valuable a general
purpose `StatefulFunction` will be (though of course it depends on a proposal
that is not yet written
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
alamb edited a comment on pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-840759475
@jorgecarleitao I would like `now()` to be added to datafusion in the next
few weeks -- my usecase is that I want to be able to write queries with
predicates like "
alamb commented on pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-840759475
@jorgecarleitao I would like `now()` to be added to datafusion in the next
few weeks -- my usecase is that I want to be able to write queries with
predicates like "in the
ursabot edited a comment on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969
Benchmark runs are scheduled for baseline =
4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender =
dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available a
alamb closed issue #324:
URL: https://github.com/apache/arrow-datafusion/issues/324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alamb merged pull request #323:
URL: https://github.com/apache/arrow-datafusion/pull/323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
ursabot edited a comment on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969
Benchmark runs are scheduled for baseline =
4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender =
dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available a
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
ursabot edited a comment on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969
Benchmark runs are scheduled for baseline =
4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender =
dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available a
pjmore commented on issue #77:
URL: https://github.com/apache/arrow-datafusion/issues/77#issuecomment-840742157
So I took a look at this and I have two solutions one which I believe always
finds all possible inner joins but runs in N^2 and one that works for this case
and should work for m
ursabot edited a comment on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969
Benchmark runs are scheduled for baseline =
4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender =
dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available a
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
ursabot edited a comment on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969
Benchmark runs are scheduled for baseline =
4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender =
dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available a
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
ianmcook commented on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-840728106
@thisisnic ooh we finally have some benchmark results to look at!:
[ursa-i9-9960x
(mimalloc)](https://conbench.ursa.dev/compare/runs/139601ccb33e49c88e039fcfa1a6d460...1a688615
domoritz commented on pull request #10277:
URL: https://github.com/apache/arrow/pull/10277#issuecomment-840719176
@TheNeuralBit Thank you for the review. I added documentation for
constructing DataFrames from Tables and added a change note to this pull
request. For 4.0, I went through all
ursabot edited a comment on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969
Benchmark runs are scheduled for baseline =
4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender =
dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available a
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
ursabot edited a comment on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969
Benchmark runs are scheduled for baseline =
4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender =
dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available a
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
alamb commented on a change in pull request #337:
URL: https://github.com/apache/arrow-datafusion/pull/337#discussion_r631961359
##
File path: datafusion/src/logical_plan/display.rs
##
@@ -58,8 +52,7 @@ impl<'a, 'b> PlanVisitor for IndentVisitor<'a, 'b> {
if self.inden
alamb opened a new pull request #337:
URL: https://github.com/apache/arrow-datafusion/pull/337
# Which issue does this PR close?
https://github.com/apache/arrow-datafusion/issues/333
# Rationale for this change
EXPLAIN output for physical plans is currently close to useless (in
ianmcook commented on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-840693418
I think Conbench needs some tweaking before it can help us here.
I'll go ahead and resolve the conflicts, wait for checks to pass, and merge
this if there aren't any obje
ursabot edited a comment on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969
Benchmark runs are scheduled for baseline =
4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender =
dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available a
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
ursabot edited a comment on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969
Benchmark runs are scheduled for baseline =
4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender =
dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available a
emkornfield commented on a change in pull request #10071:
URL: https://github.com/apache/arrow/pull/10071#discussion_r631957018
##
File path: go/parquet/schema/logical_types.go
##
@@ -0,0 +1,1089 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
zeroshade commented on a change in pull request #10071:
URL: https://github.com/apache/arrow/pull/10071#discussion_r631954773
##
File path: go/parquet/schema/logical_types.go
##
@@ -0,0 +1,1089 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
ursabot edited a comment on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969
Benchmark runs are scheduled for baseline =
4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender =
dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available a
ursabot edited a comment on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838984969
Benchmark runs are scheduled for baseline =
4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe and contender =
dbe74918019e172f8bdd3a2085f1ec7481fa79f4. Results will be available a
ursabot edited a comment on pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#issuecomment-838739409
Benchmark runs are scheduled for baseline =
553f3d8211271e8eb576c9668e53dd5dc53c480a and contender =
23a46c10f72a55866818e6bf0537719c9a2a61dc. Results will be available a
zeroshade commented on a change in pull request #10071:
URL: https://github.com/apache/arrow/pull/10071#discussion_r631950006
##
File path: go/parquet/schema/logical_types.go
##
@@ -0,0 +1,1089 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
emkornfield commented on a change in pull request #10071:
URL: https://github.com/apache/arrow/pull/10071#discussion_r631940375
##
File path: go/parquet/schema/logical_types.go
##
@@ -0,0 +1,1089 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
romainfrancois commented on pull request #9615:
URL: https://github.com/apache/arrow/pull/9615#issuecomment-840674128
Probably some more testing needed, but I believe strings are now done in
parallel.
The only thing that has to be done upfront is converting to utf8 strings.
Most of
zeroshade commented on a change in pull request #10071:
URL: https://github.com/apache/arrow/pull/10071#discussion_r631936133
##
File path: go/parquet/schema/logical_types.go
##
@@ -0,0 +1,1089 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
zeroshade commented on a change in pull request #10071:
URL: https://github.com/apache/arrow/pull/10071#discussion_r631935011
##
File path: go/parquet/schema/logical_types.go
##
@@ -0,0 +1,1089 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
westonpace commented on pull request #10205:
URL: https://github.com/apache/arrow/pull/10205#issuecomment-840670844
I've cleaned up now and, assuming CI passes, this is ready for another round
of review. Thanks for all the feedback so far.
--
This is an automated message from the Apache
1 - 100 of 244 matches
Mail list logo
