[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #334: Add window expression part 1 - logical and physical planning, structure, to/from proto, and explain, for empty over cl

2021-05-19 Thread GitBox
Dandandan commented on a change in pull request #334: URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r635803983 ## File path: ballista/rust/core/proto/ballista.proto ## @@ -151,6 +153,25 @@ message AggregateExprNode { LogicalExprNode expr = 2; } +enum

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #334: Add window expression part 1 - logical and physical planning, structure, to/from proto, and explain, for empty over cl

2021-05-19 Thread GitBox
Dandandan commented on a change in pull request #334: URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r635802863 ## File path: ballista/rust/core/proto/ballista.proto ## @@ -151,6 +153,25 @@ message AggregateExprNode { LogicalExprNode expr = 2; } +enum

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #334: Add window expression part 1 - logical and physical planning, structure, to/from proto, and explain, for empty over cl

2021-05-19 Thread GitBox
Dandandan commented on a change in pull request #334: URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r635802863 ## File path: ballista/rust/core/proto/ballista.proto ## @@ -151,6 +153,25 @@ message AggregateExprNode { LogicalExprNode expr = 2; } +enum

[GitHub] [arrow] emkornfield commented on a change in pull request #10201: ARROW-11776: [Java][Dataset] Support writing to files within dataset scanner via JNI

2021-05-19 Thread GitBox
emkornfield commented on a change in pull request #10201: URL: https://github.com/apache/arrow/pull/10201#discussion_r635792044 ## File path: cpp/src/jni/dataset/jni_wrapper.cc ## @@ -166,6 +156,126 @@ class DisposableScannerAdaptor { } }; +/// \brief Simple scan task imp

[GitHub] [arrow] emkornfield commented on a change in pull request #10201: ARROW-11776: [Java][Dataset] Support writing to files within dataset scanner via JNI

2021-05-19 Thread GitBox
emkornfield commented on a change in pull request #10201: URL: https://github.com/apache/arrow/pull/10201#discussion_r635791186 ## File path: cpp/src/jni/dataset/jni_util.cc ## @@ -211,32 +250,183 @@ std::vector ToStringVector(JNIEnv* env, jobjectArray& str_array) { return

[GitHub] [arrow] emkornfield commented on a change in pull request #10201: ARROW-11776: [Java][Dataset] Support writing to files within dataset scanner via JNI

2021-05-19 Thread GitBox
emkornfield commented on a change in pull request #10201: URL: https://github.com/apache/arrow/pull/10201#discussion_r635789662 ## File path: cpp/src/jni/dataset/jni_util.cc ## @@ -162,31 +192,40 @@ std::shared_ptr ReservationListenableMemoryPool::get_listen ReservationList

[GitHub] [arrow] emkornfield commented on a change in pull request #10201: ARROW-11776: [Java][Dataset] Support writing to files within dataset scanner via JNI

2021-05-19 Thread GitBox
emkornfield commented on a change in pull request #10201: URL: https://github.com/apache/arrow/pull/10201#discussion_r635788017 ## File path: cpp/src/jni/dataset/jni_util.cc ## @@ -16,36 +16,44 @@ // under the License. #include "jni/dataset/jni_util.h" - +#include "arrow/ip

[GitHub] [arrow] emkornfield commented on a change in pull request #10201: ARROW-11776: [Java][Dataset] Support writing to files within dataset scanner via JNI

2021-05-19 Thread GitBox
emkornfield commented on a change in pull request #10201: URL: https://github.com/apache/arrow/pull/10201#discussion_r635787880 ## File path: cpp/src/jni/dataset/jni_util.cc ## @@ -16,36 +16,44 @@ // under the License. #include "jni/dataset/jni_util.h" - +#include "arrow/ip

[GitHub] [arrow] emkornfield commented on pull request #10308: ARROW-12770: [Plasma][C++][JAVA] Add Metrics API for clients to get share memory usage

2021-05-19 Thread GitBox
emkornfield commented on pull request #10308: URL: https://github.com/apache/arrow/pull/10308#issuecomment-844723885 It looks like this might be failing tests on bigendian machines (see CI). Also can we separate C++ and JNI compoments into two separate issues/PRs. -- This is an automate

[GitHub] [arrow] emkornfield commented on issue #10187: rowIndex is not recalculated when concatenating tables (javascript implementation)

2021-05-19 Thread GitBox
emkornfield commented on issue #10187: URL: https://github.com/apache/arrow/issues/10187#issuecomment-844721791 CC @trxcllnt @TheNeuralBit does this sound like a bug? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] emkornfield closed pull request #9964: ARROW-12310: [Java] ValueVector#getObject should support covariance for complex types

2021-05-19 Thread GitBox
emkornfield closed pull request #9964: URL: https://github.com/apache/arrow/pull/9964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [arrow] emkornfield commented on pull request #9964: ARROW-12310: [Java] ValueVector#getObject should support covariance for complex types

2021-05-19 Thread GitBox
emkornfield commented on pull request #9964: URL: https://github.com/apache/arrow/pull/9964#issuecomment-844720874 Sorry looks good. Will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] emkornfield closed pull request #10071: ARROW-12424: [Go][Parquet] Adding Schema Package for Go Parquet

2021-05-19 Thread GitBox
emkornfield closed pull request #10071: URL: https://github.com/apache/arrow/pull/10071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [arrow] praveenbingo closed pull request #9724: ARROW-11986: [C++][Gandiva] Implement IN expressions for doubles and floats

2021-05-19 Thread GitBox
praveenbingo closed pull request #9724: URL: https://github.com/apache/arrow/pull/9724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [arrow] praveenbingo closed pull request #10218: ARROW-12621: [C++][Gandiva] Add alias to sha1 and sha256 functions

2021-05-19 Thread GitBox
praveenbingo closed pull request #10218: URL: https://github.com/apache/arrow/pull/10218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow] praveenbingo closed pull request #9861: ARROW-12166: [C++][Gandiva] Implements CONVERT_TO(value, type) function

2021-05-19 Thread GitBox
praveenbingo closed pull request #9861: URL: https://github.com/apache/arrow/pull/9861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [arrow] praveenbingo closed pull request #10095: ARROW-12443: [C++][Gandiva] Implement castVARCHAR function for varbinary input

2021-05-19 Thread GitBox
praveenbingo closed pull request #10095: URL: https://github.com/apache/arrow/pull/10095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow] domoritz commented on pull request #10340: ARROW-12800: [JS] Remove text encoder and decoder polyfills

2021-05-19 Thread GitBox
domoritz commented on pull request #10340: URL: https://github.com/apache/arrow/pull/10340#issuecomment-844690061 Done. This should be ready to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] domoritz edited a comment on pull request #10361: ARROW-12832: [JS] Write benchmarks in TypeScript

2021-05-19 Thread GitBox
domoritz edited a comment on pull request #10361: URL: https://github.com/apache/arrow/pull/10361#issuecomment-844678159 * [x] actually load the sources by default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [arrow] github-actions[bot] commented on pull request #10362: ARROW-12833: [JS] Construct perf data in JS

2021-05-19 Thread GitBox
github-actions[bot] commented on pull request #10362: URL: https://github.com/apache/arrow/pull/10362#issuecomment-844688019 https://issues.apache.org/jira/browse/ARROW-12833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] domoritz opened a new pull request #10362: ARROW-12833: [JS] Construct perf data in JS

2021-05-19 Thread GitBox
domoritz opened a new pull request #10362: URL: https://github.com/apache/arrow/pull/10362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] github-actions[bot] commented on pull request #10355: ARROW-12829: [GLib][Ruby] Add support for Apache Arrow Flight

2021-05-19 Thread GitBox
github-actions[bot] commented on pull request #10355: URL: https://github.com/apache/arrow/pull/10355#issuecomment-844678752 Revision: cb827c5eb69e66491bdbbdf8339414556bfd346a Submitted crossbow builds: [ursacomputing/crossbow @ actions-426](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] kou commented on pull request #10355: ARROW-12829: [GLib][Ruby] Add support for Apache Arrow Flight

2021-05-19 Thread GitBox
kou commented on pull request #10355: URL: https://github.com/apache/arrow/pull/10355#issuecomment-844678347 @github-actions crossbow submit -g linux -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] domoritz commented on pull request #10361: ARROW-12832: [JS] Write benchmarks in TypeScript

2021-05-19 Thread GitBox
domoritz commented on pull request #10361: URL: https://github.com/apache/arrow/pull/10361#issuecomment-844678159 * [ ] actually load the sources by default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] ursabot edited a comment on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
ursabot edited a comment on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844625395 Benchmark runs are scheduled for baseline = 3a85ab482c3181f207c68c52a66f240da49e8995 and contender = aa9b15936d54dcf09ee1857e04515ec21698fa93. Results will be available a

[GitHub] [arrow] westonpace commented on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
westonpace commented on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844672916 The EC2 instances where we really want the benchmarks are running out of memory it seems. I was able to get some times from ursa-i9-9960x. Note, it does not line up the ben

[GitHub] [arrow] github-actions[bot] commented on pull request #10361: ARROW-12832: [JS] Write benchmarks in TypeScript

2021-05-19 Thread GitBox
github-actions[bot] commented on pull request #10361: URL: https://github.com/apache/arrow/pull/10361#issuecomment-844659697 https://issues.apache.org/jira/browse/ARROW-12832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] domoritz opened a new pull request #10361: ARROW-12832: [JS] Write benchmarks in TypeScript

2021-05-19 Thread GitBox
domoritz opened a new pull request #10361: URL: https://github.com/apache/arrow/pull/10361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] ursabot edited a comment on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
ursabot edited a comment on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844625395 Benchmark runs are scheduled for baseline = 3a85ab482c3181f207c68c52a66f240da49e8995 and contender = aa9b15936d54dcf09ee1857e04515ec21698fa93. Results will be available a

[GitHub] [arrow] domoritz commented on pull request #10360: ARROW-12808: [JS] Document browser support

2021-05-19 Thread GitBox
domoritz commented on pull request #10360: URL: https://github.com/apache/arrow/pull/10360#issuecomment-844643087 Merge after https://github.com/apache/arrow/pull/10340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] github-actions[bot] commented on pull request #10360: ARROW-12808: [JS] Document browser support

2021-05-19 Thread GitBox
github-actions[bot] commented on pull request #10360: URL: https://github.com/apache/arrow/pull/10360#issuecomment-844641209 https://issues.apache.org/jira/browse/ARROW-12808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] github-actions[bot] commented on pull request #10360: [JS] Document browser support

2021-05-19 Thread GitBox
github-actions[bot] commented on pull request #10360: URL: https://github.com/apache/arrow/pull/10360#issuecomment-844639263 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you ope

[GitHub] [arrow] domoritz opened a new pull request #10360: [JS] Document browser support

2021-05-19 Thread GitBox
domoritz opened a new pull request #10360: URL: https://github.com/apache/arrow/pull/10360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] ursabot edited a comment on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
ursabot edited a comment on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844625395 Benchmark runs are scheduled for baseline = 3a85ab482c3181f207c68c52a66f240da49e8995 and contender = aa9b15936d54dcf09ee1857e04515ec21698fa93. Results will be available a

[GitHub] [arrow] kou commented on pull request #10355: ARROW-12829: [GLib][Ruby] Add support for Apache Arrow Flight

2021-05-19 Thread GitBox
kou commented on pull request #10355: URL: https://github.com/apache/arrow/pull/10355#issuecomment-844632661 OK. Let's try `gaXXX_`. If `gaXXX_` conflicts with other products, we can rethink this. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] kou commented on pull request #9758: ARROW-9054: [C++] Add ScalarAggregateOptions

2021-05-19 Thread GitBox
kou commented on pull request #9758: URL: https://github.com/apache/arrow/pull/9758#issuecomment-844630788 @nealrichardson Could you confirm suggestions from @rok ? Can we merge this with these suggestions? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [arrow] kou closed pull request #10359: ARROW-12831: [CI][macOS] Remove needless Homebrew workaround

2021-05-19 Thread GitBox
kou closed pull request #10359: URL: https://github.com/apache/arrow/pull/10359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] kou commented on pull request #10359: ARROW-12831: [CI][macOS] Remove needless Homebrew workaround

2021-05-19 Thread GitBox
kou commented on pull request #10359: URL: https://github.com/apache/arrow/pull/10359#issuecomment-844629390 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [arrow] ursabot commented on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
ursabot commented on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844625395 Benchmark runs are scheduled for baseline = 3a85ab482c3181f207c68c52a66f240da49e8995 and contender = aa9b15936d54dcf09ee1857e04515ec21698fa93. Results will be available as each

[GitHub] [arrow] kou commented on pull request #10359: ARROW-12831: [CI][macOS] Remove needless Homebrew workaround

2021-05-19 Thread GitBox
kou commented on pull request #10359: URL: https://github.com/apache/arrow/pull/10359#issuecomment-844613722 macOS jobs were timed out on master: * https://github.com/apache/arrow/runs/2603100840 * https://github.com/apache/arrow/runs/2603100814 * https://github.com/apache/arrow

[GitHub] [arrow] westonpace commented on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
westonpace commented on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844625141 @ursabot please benchmark lang=Python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [arrow] kou opened a new pull request #10359: ARROW-12831: [CI][macOS] Remove needless Homebrew workaround

2021-05-19 Thread GitBox
kou opened a new pull request #10359: URL: https://github.com/apache/arrow/pull/10359 This was introduced by #9119 (ARROW-1152) but this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] github-actions[bot] commented on pull request #10359: ARROW-12831: [CI][macOS] Remove needless Homebrew workaround

2021-05-19 Thread GitBox
github-actions[bot] commented on pull request #10359: URL: https://github.com/apache/arrow/pull/10359#issuecomment-844613209 https://issues.apache.org/jira/browse/ARROW-12831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] cyb70289 closed pull request #10274: ARROW-12685: [C++][Compute] Add unary absolute value kernel

2021-05-19 Thread GitBox
cyb70289 closed pull request #10274: URL: https://github.com/apache/arrow/pull/10274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #334: Add window expression part 1 - logical and physical planning, structure, to/from proto, and explain, for empty over cla

2021-05-19 Thread GitBox
Jimexist commented on a change in pull request #334: URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r635676450 ## File path: ballista/rust/core/proto/ballista.proto ## @@ -151,6 +153,25 @@ message AggregateExprNode { LogicalExprNode expr = 2; } +enum

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #334: Add window expression part 1 - logical and physical planning, structure, to/from proto, and explain, for empty over cla

2021-05-19 Thread GitBox
Jimexist commented on a change in pull request #334: URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r635675124 ## File path: ballista/rust/core/proto/ballista.proto ## @@ -151,6 +153,25 @@ message AggregateExprNode { LogicalExprNode expr = 2; } +enum

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #334: Add window expression part 1 - logical and physical planning, structure, to/from proto, and explain, for empty over cla

2021-05-19 Thread GitBox
Jimexist commented on a change in pull request #334: URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r635673607 ## File path: ballista/rust/core/proto/ballista.proto ## @@ -151,6 +153,25 @@ message AggregateExprNode { LogicalExprNode expr = 2; } +enum

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #334: Add window expression part 1 - logical and physical planning, structure, to/from proto, and explain, for empty over cla

2021-05-19 Thread GitBox
Jimexist commented on a change in pull request #334: URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r635672736 ## File path: ballista/rust/core/proto/ballista.proto ## @@ -151,6 +153,25 @@ message AggregateExprNode { LogicalExprNode expr = 2; } +enum

[GitHub] [arrow] ianmcook commented on pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
ianmcook commented on pull request #10356: URL: https://github.com/apache/arrow/pull/10356#issuecomment-844548176 What to do about the options class might be awkward. You could subclass `MatchSubstringOptions`, but I think ultimately we might incorporate an option for case insensitivity in

[GitHub] [arrow] lidavidm commented on pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
lidavidm commented on pull request #10356: URL: https://github.com/apache/arrow/pull/10356#issuecomment-844542476 No, but in that case we'd just not dispatch to that path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] ianmcook commented on pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
ianmcook commented on pull request #10356: URL: https://github.com/apache/arrow/pull/10356#issuecomment-844542150 But can `PlainSubstringMatcher` do case-insensitive matching? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] lidavidm commented on pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
lidavidm commented on pull request #10356: URL: https://github.com/apache/arrow/pull/10356#issuecomment-844540228 We could easily add a flag to toggle insensitivity in RE2 as well. (Would be better than allocating a new string and potentially dealing with Unicode.) -- This is an automate

[GitHub] [arrow] ianmcook commented on pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
ianmcook commented on pull request #10356: URL: https://github.com/apache/arrow/pull/10356#issuecomment-844539780 P.S. case insensitivity can be achieved by using one of the `_upper` or `_lower` kernels, which I think is good enough -- This is an automated message from the Apache Git Ser

[GitHub] [arrow] michalursa commented on pull request #9768: ARROW-12010: [C++][Compute] Improve performance of the hash table used in GroupIdentifier

2021-05-19 Thread GitBox
michalursa commented on pull request #9768: URL: https://github.com/apache/arrow/pull/9768#issuecomment-844533147 > > @michalursa looks like tests are hanging on our [bigendian CI](https://travis-ci.com/github/apache/arrow/jobs/506281680#L2907). Is this quick to address or should we leave

[GitHub] [arrow] lidavidm commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
lidavidm commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635613255 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -494,6 +494,95 @@ const FunctionDoc match_substring_regex_doc( "position.\n"

[GitHub] [arrow] ianmcook commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
ianmcook commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635609498 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -494,6 +494,95 @@ const FunctionDoc match_substring_regex_doc( "position.\n"

[GitHub] [arrow] lidavidm commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
lidavidm commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635602560 ## File path: docs/source/cpp/compute.rst ## @@ -529,28 +529,36 @@ Containment tests +---++

[GitHub] [arrow] ianmcook commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
ianmcook commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635601185 ## File path: docs/source/cpp/compute.rst ## @@ -529,28 +529,36 @@ Containment tests +---++

[GitHub] [arrow] lidavidm commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
lidavidm commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635598720 ## File path: docs/source/cpp/compute.rst ## @@ -529,28 +529,36 @@ Containment tests +---++

[GitHub] [arrow] ianmcook commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
ianmcook commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635595821 ## File path: docs/source/cpp/compute.rst ## @@ -529,28 +529,36 @@ Containment tests +---++

[GitHub] [arrow] augustoasilva commented on a change in pull request #10059: ARROW-12410: [C++][Gandiva] Implement regexp_replace function on Gandiva

2021-05-19 Thread GitBox
augustoasilva commented on a change in pull request #10059: URL: https://github.com/apache/arrow/pull/10059#discussion_r635595413 ## File path: cpp/src/gandiva/replace_holder.h ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [arrow] ianmcook commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
ianmcook commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635594889 ## File path: docs/source/cpp/compute.rst ## @@ -529,28 +529,36 @@ Containment tests +---++

[GitHub] [arrow] lidavidm commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
lidavidm commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635582443 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -494,6 +494,93 @@ const FunctionDoc match_substring_regex_doc( "position.\n"

[GitHub] [arrow] lidavidm commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
lidavidm commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635582104 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -494,6 +494,93 @@ const FunctionDoc match_substring_regex_doc( "position.\n"

[GitHub] [arrow] nealrichardson commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

2021-05-19 Thread GitBox
nealrichardson commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r635572831 ## File path: r/R/table.R ## @@ -175,12 +175,17 @@ Table$create <- function(..., schema = NULL) { return(dplyr::group_by(out, !!!dplyr::groups

[GitHub] [arrow] ianmcook commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
ianmcook commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635580566 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -494,6 +494,93 @@ const FunctionDoc match_substring_regex_doc( "position.\n"

[GitHub] [arrow] ianmcook commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
ianmcook commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635580566 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -494,6 +494,93 @@ const FunctionDoc match_substring_regex_doc( "position.\n"

[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #68: Experimenting with arrow2

2021-05-19 Thread GitBox
jorgecarleitao commented on pull request #68: URL: https://github.com/apache/arrow-datafusion/pull/68#issuecomment-844480669 ``` cargo test --lib ... Finished dev [unoptimized + debuginfo] target(s) ``` 🎉 I temporarily deactivated the predicate pushdown for parquet,

[GitHub] [arrow] ianmcook commented on a change in pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
ianmcook commented on a change in pull request #10356: URL: https://github.com/apache/arrow/pull/10356#discussion_r635579350 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -494,6 +494,93 @@ const FunctionDoc match_substring_regex_doc( "position.\n"

[GitHub] [arrow] nealrichardson commented on pull request #9768: ARROW-12010: [C++][Compute] Improve performance of the hash table used in GroupIdentifier

2021-05-19 Thread GitBox
nealrichardson commented on pull request #9768: URL: https://github.com/apache/arrow/pull/9768#issuecomment-844456233 > @michalursa looks like tests are hanging on our [bigendian CI](https://travis-ci.com/github/apache/arrow/jobs/506281680#L2907). Is this quick to address or should we leav

[GitHub] [arrow-datafusion] Dandandan commented on pull request #365: Refactor: move RowGroupPredicateBuilder into its own module, rename to PruningPredicateBuilder

2021-05-19 Thread GitBox
Dandandan commented on pull request #365: URL: https://github.com/apache/arrow-datafusion/pull/365#issuecomment-84016 I also think this is looking good. I think we might clean things up a bit while touching the code, I added some suggestions. -- This is an automated message from the

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #365: Refactor: move RowGroupPredicateBuilder into its own module, rename to PruningPredicateBuilder

2021-05-19 Thread GitBox
Dandandan commented on a change in pull request #365: URL: https://github.com/apache/arrow-datafusion/pull/365#discussion_r635557126 ## File path: datafusion/src/physical_optimizer/pruning.rs ## @@ -0,0 +1,769 @@ +// Licensed to the Apache Software Foundation (ASF) under one +/

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #365: Refactor: move RowGroupPredicateBuilder into its own module, rename to PruningPredicateBuilder

2021-05-19 Thread GitBox
Dandandan commented on a change in pull request #365: URL: https://github.com/apache/arrow-datafusion/pull/365#discussion_r635554150 ## File path: datafusion/src/physical_optimizer/pruning.rs ## @@ -0,0 +1,769 @@ +// Licensed to the Apache Software Foundation (ASF) under one +/

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #365: Refactor: move RowGroupPredicateBuilder into its own module, rename to PruningPredicateBuilder

2021-05-19 Thread GitBox
Dandandan commented on a change in pull request #365: URL: https://github.com/apache/arrow-datafusion/pull/365#discussion_r635554027 ## File path: datafusion/src/physical_optimizer/pruning.rs ## @@ -0,0 +1,769 @@ +// Licensed to the Apache Software Foundation (ASF) under one +/

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #365: Refactor: move RowGroupPredicateBuilder into its own module, rename to PruningPredicateBuilder

2021-05-19 Thread GitBox
Dandandan commented on a change in pull request #365: URL: https://github.com/apache/arrow-datafusion/pull/365#discussion_r635553323 ## File path: datafusion/src/physical_optimizer/pruning.rs ## @@ -0,0 +1,769 @@ +// Licensed to the Apache Software Foundation (ASF) under one +/

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #365: Refactor: move RowGroupPredicateBuilder into its own module, rename to PruningPredicateBuilder

2021-05-19 Thread GitBox
Dandandan commented on a change in pull request #365: URL: https://github.com/apache/arrow-datafusion/pull/365#discussion_r635552829 ## File path: datafusion/src/physical_optimizer/pruning.rs ## @@ -0,0 +1,769 @@ +// Licensed to the Apache Software Foundation (ASF) under one +/

[GitHub] [arrow-datafusion] alamb commented on pull request #365: Refactor: move RowGroupPredicateBuilder into its own module, rename to PruningPredicateBuilder

2021-05-19 Thread GitBox
alamb commented on pull request #365: URL: https://github.com/apache/arrow-datafusion/pull/365#issuecomment-844432321 FYI @yordan-pavlov and @returnString -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] github-actions[bot] commented on pull request #10345: ARROW-12569: [R] [CI] Run revdep in CI

2021-05-19 Thread GitBox
github-actions[bot] commented on pull request #10345: URL: https://github.com/apache/arrow/pull/10345#issuecomment-844429851 Revision: 63e78da4059a266c6dc7cba8cfe73ef60ed4a4e5 Submitted crossbow builds: [ursacomputing/crossbow @ actions-425](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] jonkeane commented on pull request #10345: ARROW-12569: [R] [CI] Run revdep in CI

2021-05-19 Thread GitBox
jonkeane commented on pull request #10345: URL: https://github.com/apache/arrow/pull/10345#issuecomment-844428125 @github-actions crossbow submit revdep-r-check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] nealrichardson commented on a change in pull request #10334: ARROW-12198: [R] bindings for strptime

2021-05-19 Thread GitBox
nealrichardson commented on a change in pull request #10334: URL: https://github.com/apache/arrow/pull/10334#discussion_r635544090 ## File path: r/R/compute.R ## @@ -286,3 +286,8 @@ cast_options <- function(safe = TRUE, ...) { ) modifyList(opts, list(...)) } + +strptime_

[GitHub] [arrow] lidavidm commented on a change in pull request #10321: ARROW-12675: [C++] CSV parsing report row on which error occurred

2021-05-19 Thread GitBox
lidavidm commented on a change in pull request #10321: URL: https://github.com/apache/arrow/pull/10321#discussion_r635534220 ## File path: cpp/src/arrow/csv/parser_test.cc ## @@ -536,22 +537,42 @@ TEST(BlockParser, QuotesSpecial) { TEST(BlockParser, MismatchingNumColumns) {

[GitHub] [arrow] jduo commented on a change in pull request #9368: [WIP] [POC] Flight SQL

2021-05-19 Thread GitBox
jduo commented on a change in pull request #9368: URL: https://github.com/apache/arrow/pull/9368#discussion_r635534750 ## File path: java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSQLClientUtils.java ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache S

[GitHub] [arrow-rs] sunchao commented on a change in pull request #307: ensure null-counts are written for all-null columns

2021-05-19 Thread GitBox
sunchao commented on a change in pull request #307: URL: https://github.com/apache/arrow-rs/pull/307#discussion_r635532034 ## File path: parquet/src/column/writer.rs ## @@ -607,9 +607,11 @@ impl ColumnWriterImpl { let max_def_level = self.descr.max_def_level();

[GitHub] [arrow] ursabot edited a comment on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
ursabot edited a comment on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844381307 Benchmark runs are scheduled for baseline = aa37d197a63a7efbc0660f9cea2f75cc08c30587 and contender = fb02d17a77900b4012c3c57f865e68cda0a41274. Results will be available a

[GitHub] [arrow-datafusion] Dandandan edited a comment on issue #364: Add Compare to GroupByScalar

2021-05-19 Thread GitBox
Dandandan edited a comment on issue #364: URL: https://github.com/apache/arrow-datafusion/issues/364#issuecomment-844401489 I agree combining them makes a lot of sense :+1: In aggregates I was also stumbling on some strange issues relating to evaluation of scalars while working on

[GitHub] [arrow] ursabot edited a comment on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
ursabot edited a comment on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844381307 Benchmark runs are scheduled for baseline = aa37d197a63a7efbc0660f9cea2f75cc08c30587 and contender = fb02d17a77900b4012c3c57f865e68cda0a41274. Results will be available a

[GitHub] [arrow] github-actions[bot] commented on pull request #10358: ARROW-2665: [C++][Python] Add index() kernel

2021-05-19 Thread GitBox
github-actions[bot] commented on pull request #10358: URL: https://github.com/apache/arrow/pull/10358#issuecomment-844401662 https://issues.apache.org/jira/browse/ARROW-2665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow-datafusion] Dandandan commented on issue #364: Add Compare to GroupByScalar

2021-05-19 Thread GitBox
Dandandan commented on issue #364: URL: https://github.com/apache/arrow-datafusion/issues/364#issuecomment-844401489 I agree combining them makes a lot of sense :+1: In aggregates I was also stumbling on some strange issues relating to evaluation of scalars while working on this:

[GitHub] [arrow] ursabot edited a comment on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
ursabot edited a comment on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844381307 Benchmark runs are scheduled for baseline = aa37d197a63a7efbc0660f9cea2f75cc08c30587 and contender = fb02d17a77900b4012c3c57f865e68cda0a41274. Results will be available a

[GitHub] [arrow] bkietz commented on a change in pull request #10296: ARROW-12724: [C++] Add documentation for authoring compute kernels

2021-05-19 Thread GitBox
bkietz commented on a change in pull request #10296: URL: https://github.com/apache/arrow/pull/10296#discussion_r635520473 ## File path: docs/source/cpp/authoring_compute_functions.rst ## @@ -0,0 +1,421 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or mo

[GitHub] [arrow] ursabot edited a comment on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
ursabot edited a comment on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844381307 Benchmark runs are scheduled for baseline = aa37d197a63a7efbc0660f9cea2f75cc08c30587 and contender = fb02d17a77900b4012c3c57f865e68cda0a41274. Results will be available a

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #334: Add window expression part 1 - logical and physical planning, structure, to/from proto, and explain, for empty over cl

2021-05-19 Thread GitBox
Dandandan commented on a change in pull request #334: URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r635518750 ## File path: ballista/rust/core/proto/ballista.proto ## @@ -151,6 +153,25 @@ message AggregateExprNode { LogicalExprNode expr = 2; } +enum

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #365: Refactor: move RowGroupPredicateBuilder into its own module, rename to PruningPredicateBuilder

2021-05-19 Thread GitBox
codecov-commenter commented on pull request #365: URL: https://github.com/apache/arrow-datafusion/pull/365#issuecomment-844395540 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #366: Change 'breaking change' label to 'api change'

2021-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #366: URL: https://github.com/apache/arrow-datafusion/pull/366#issuecomment-844390334 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+

[GitHub] [arrow] bkietz commented on a change in pull request #10296: ARROW-12724: [C++] Add documentation for authoring compute kernels

2021-05-19 Thread GitBox
bkietz commented on a change in pull request #10296: URL: https://github.com/apache/arrow/pull/10296#discussion_r633591259 ## File path: docs/source/cpp/authoring_compute_functions.rst ## @@ -0,0 +1,421 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or mo

[GitHub] [arrow] lidavidm opened a new pull request #10358: ARROW-2665: [C++][Python] Add index() kernel

2021-05-19 Thread GitBox
lidavidm opened a new pull request #10358: URL: https://github.com/apache/arrow/pull/10358 Add a simple index() kernel. Note that the Python start/end options are handled entirely in Python, not in the kernel itself. Short-circuiting is somewhat implemented: the kernel executo

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #366: Change 'breaking change' label to 'api change'

2021-05-19 Thread GitBox
codecov-commenter commented on pull request #366: URL: https://github.com/apache/arrow-datafusion/pull/366#issuecomment-844390334 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[GitHub] [arrow-datafusion] alamb commented on pull request #334: Add window expression part 1 - logical and physical planning, structure, to/from proto, and explain, for empty over clause only

2021-05-19 Thread GitBox
alamb commented on pull request #334: URL: https://github.com/apache/arrow-datafusion/pull/334#issuecomment-844384440 I will try to review this later today but I may not get to it until tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [arrow] ursabot commented on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
ursabot commented on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844381307 Benchmark runs are scheduled for baseline = aa37d197a63a7efbc0660f9cea2f75cc08c30587 and contender = fb02d17a77900b4012c3c57f865e68cda0a41274. Results will be available as each

[GitHub] [arrow] westonpace commented on pull request #10118: ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

2021-05-19 Thread GitBox
westonpace commented on pull request #10118: URL: https://github.com/apache/arrow/pull/10118#issuecomment-844381092 @ursabot please benchmark lang=Python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

  1   2   >