Dandandan merged pull request #433:
URL: https://github.com/apache/arrow-datafusion/pull/433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
nevi-me merged pull request #373:
URL: https://github.com/apache/arrow-rs/pull/373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
nevi-me merged pull request #374:
URL: https://github.com/apache/arrow-rs/pull/374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
houqp commented on pull request #422:
URL: https://github.com/apache/arrow-datafusion/pull/422#issuecomment-849341833
@alamb @jorgecarleitao @Dandandan I reorganized everything to better align
with the specification model. Could you take another look to see if there is
anything you would l
jorgecarleitao opened a new pull request #433:
URL: https://github.com/apache/arrow-datafusion/pull/433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
jorgecarleitao commented on pull request #432:
URL: https://github.com/apache/arrow-datafusion/pull/432#issuecomment-849319860
Closing in favor of #339 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jorgecarleitao closed pull request #432:
URL: https://github.com/apache/arrow-datafusion/pull/432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
jorgecarleitao closed issue #431:
URL: https://github.com/apache/arrow-datafusion/issues/431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
jorgecarleitao merged pull request #339:
URL: https://github.com/apache/arrow-datafusion/pull/339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
jorgecarleitao closed issue #338:
URL: https://github.com/apache/arrow-datafusion/issues/338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
cyb70289 closed pull request #10375:
URL: https://github.com/apache/arrow/pull/10375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
ianmcook commented on a change in pull request #10327:
URL: https://github.com/apache/arrow/pull/10327#discussion_r640241809
##
File path: r/R/dplyr-functions.R
##
@@ -109,6 +119,55 @@ nse_funcs$as.numeric <- function(x) {
Expression$create("cast", x, options = cast_options(
ianmcook commented on a change in pull request #10327:
URL: https://github.com/apache/arrow/pull/10327#discussion_r640241437
##
File path: r/R/type.R
##
@@ -423,6 +423,24 @@ as_type <- function(type, name = "type") {
type
}
+canonical_type_str <- function(type_str) {
Rev
ianmcook commented on a change in pull request #10327:
URL: https://github.com/apache/arrow/pull/10327#discussion_r640240623
##
File path: r/R/type.R
##
@@ -423,6 +423,24 @@ as_type <- function(type, name = "type") {
type
}
+canonical_type_str <- function(type_str) {
+ #
ianmcook commented on pull request #10375:
URL: https://github.com/apache/arrow/pull/10375#issuecomment-849260492
@cyb70289 No more comments from me, looks good, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cyb70289 commented on pull request #10375:
URL: https://github.com/apache/arrow/pull/10375#issuecomment-849252521
@ianmcook , do you have other comments? Can we merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
stczwd commented on pull request #9147:
URL: https://github.com/apache/arrow/pull/9147#issuecomment-849241823
@emkornfield @lidavidm any more comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
stczwd commented on pull request #9147:
URL: https://github.com/apache/arrow/pull/9147#issuecomment-849241240
sure. I have changed the code with checking -1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
andygrove merged pull request #394:
URL: https://github.com/apache/arrow-datafusion/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
andygrove closed issue #352:
URL: https://github.com/apache/arrow-datafusion/issues/352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
andygrove commented on pull request #394:
URL: https://github.com/apache/arrow-datafusion/pull/394#issuecomment-849224311
```
[2021-05-27T00:55:04Z INFO ballista::context] Connecting to Ballista
scheduler at http://ballista-scheduler:50050
[2021-05-27T00:55:04Z INFO ballista::contex
Jimexist edited a comment on issue #298:
URL:
https://github.com/apache/arrow-datafusion/issues/298#issuecomment-848809874
- [x] https://github.com/apache/arrow-datafusion/pull/375 to add window
function support, streaming, and `row_number`
- [ ] https://github.com/apache/arrow-datafusi
kou commented on pull request #10404:
URL: https://github.com/apache/arrow/pull/10404#issuecomment-849192015
@thisisnic Can we build Apache Arrow C++ without additional C++ flag
(`-latomic`) on Raspberry Pi? If we can't, we should fix it in Apache Arrow C++.
--
This is an automated messa
nealrichardson commented on a change in pull request #10327:
URL: https://github.com/apache/arrow/pull/10327#discussion_r640171712
##
File path: r/R/type.R
##
@@ -423,6 +423,24 @@ as_type <- function(type, name = "type") {
type
}
+canonical_type_str <- function(type_str)
nealrichardson commented on a change in pull request #10381:
URL: https://github.com/apache/arrow/pull/10381#discussion_r640168884
##
File path: r/R/dplyr.R
##
@@ -74,7 +74,13 @@ print.arrow_dplyr_query <- function(x, ...) {
name <- expr$field_name
if (nzchar(name)) {
ianmcook commented on pull request #10373:
URL: https://github.com/apache/arrow/pull/10373#issuecomment-849158080
I ran `R CMD check --as-cran` locally (a) with no C++ library available, and
(b) with a very minimally built C++ library and all the checks passed
--
This is an automated mes
alamb opened a new pull request #374:
URL: https://github.com/apache/arrow-rs/pull/374
Automatic cherry-pick of 7753f416a620b4ea5b6242366f68acbbcf35bc06
* Originally appeared in https://github.com/apache/arrow-rs/pull/351: Only
register Flight.proto with cargo if it exists
--
This
alamb opened a new pull request #373:
URL: https://github.com/apache/arrow-rs/pull/373
Automatic cherry-pick of 4a27a3b3c797e801d919ac30cd432f27f9a3d28c
* Originally appeared in https://github.com/apache/arrow-rs/pull/362: Add
crate badges
--
This is an automated message from the
alamb opened a new pull request #372:
URL: https://github.com/apache/arrow-rs/pull/372
Automatic cherry-pick of e85dc984edf2dbd48c7437ca3bed724d2b3ce386
* Originally appeared in https://github.com/apache/arrow-rs/pull/341: Fix
filter UB and add fast path
--
This is an automated me
alamb commented on pull request #359:
URL: https://github.com/apache/arrow-rs/pull/359#issuecomment-849138585
windows failure is unrelated to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alamb merged pull request #359:
URL: https://github.com/apache/arrow-rs/pull/359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
alamb commented on pull request #358:
URL: https://github.com/apache/arrow-rs/pull/358#issuecomment-849137851
windows failure is unrelated to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alamb merged pull request #358:
URL: https://github.com/apache/arrow-rs/pull/358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
alamb merged pull request #357:
URL: https://github.com/apache/arrow-rs/pull/357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
alamb merged pull request #356:
URL: https://github.com/apache/arrow-rs/pull/356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
alamb commented on pull request #356:
URL: https://github.com/apache/arrow-rs/pull/356#issuecomment-849137186
windows failure is unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
alamb merged pull request #355:
URL: https://github.com/apache/arrow-rs/pull/355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
alamb commented on issue #292:
URL: https://github.com/apache/arrow-rs/issues/292#issuecomment-849136330
👍 Let's give this PR per backport a try for a while and see how it goes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
github-actions[bot] commented on pull request #10373:
URL: https://github.com/apache/arrow/pull/10373#issuecomment-849135293
Revision: 8df7c5166be1872cb7efee27ae4cbfc995f11412
Submitted crossbow builds: [ursacomputing/crossbow @
actions-442](https://github.com/ursacomputing/crossbow/
ianmcook commented on pull request #10373:
URL: https://github.com/apache/arrow/pull/10373#issuecomment-849134906
@github-actions crossbow submit test-r-minimal-build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
ianmcook commented on pull request #10373:
URL: https://github.com/apache/arrow/pull/10373#issuecomment-849134704
If we're doing this, let's go ahead and do it for `\donttest{}` too. I just
pushed a commit doing that (8df7c51).
--
This is an automated message from the Apache Git Service.
ianmcook commented on a change in pull request #10373:
URL: https://github.com/apache/arrow/pull/10373#discussion_r640135181
##
File path: r/R/filesystem.R
##
@@ -476,15 +476,13 @@ SubTreeFileSystem$create <- function(base_path, base_fs =
NULL) {
#' copying but may help accom
codecov-commenter commented on pull request #426:
URL: https://github.com/apache/arrow-datafusion/pull/426#issuecomment-849131065
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/426?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment
codecov-commenter edited a comment on pull request #394:
URL: https://github.com/apache/arrow-datafusion/pull/394#issuecomment-846541650
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
jorgecarleitao commented on issue #292:
URL: https://github.com/apache/arrow-rs/issues/292#issuecomment-849123373
Sounds good 👍 . One idea would be to have a single PR with all the
cherry-picks, so that we only have to review one PR. We could then merge then
without squashing; no strong fe
codecov-commenter commented on pull request #429:
URL: https://github.com/apache/arrow-datafusion/pull/429#issuecomment-849123108
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment
alamb commented on issue #292:
URL: https://github.com/apache/arrow-rs/issues/292#issuecomment-849121083
@jorgecarleitao , upon more thought I plan to keep doing PRs for the
following reason:
1. It is a natural place to run the CI tests to make sure there are no
logical conflicts
2.
alamb commented on a change in pull request #404:
URL: https://github.com/apache/arrow-datafusion/pull/404#discussion_r640106466
##
File path: datafusion/src/physical_plan/json.rs
##
@@ -0,0 +1,468 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more co
ianmcook commented on a change in pull request #10373:
URL: https://github.com/apache/arrow/pull/10373#discussion_r640117471
##
File path: r/R/filesystem.R
##
@@ -476,15 +476,13 @@ SubTreeFileSystem$create <- function(base_path, base_fs =
NULL) {
#' copying but may help accom
jgoday commented on a change in pull request #394:
URL: https://github.com/apache/arrow-datafusion/pull/394#discussion_r640117097
##
File path: ballista/rust/client/src/context.rs
##
@@ -198,14 +200,21 @@ impl BallistaContext {
DataFusionError::Internal("Receiv
andygrove commented on a change in pull request #394:
URL: https://github.com/apache/arrow-datafusion/pull/394#discussion_r640115121
##
File path: ballista/rust/client/src/context.rs
##
@@ -198,14 +200,21 @@ impl BallistaContext {
DataFusionError::Internal("Rec
codecov-commenter edited a comment on pull request #425:
URL: https://github.com/apache/arrow-datafusion/pull/425#issuecomment-847826098
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/425?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
jgoday commented on pull request #394:
URL: https://github.com/apache/arrow-datafusion/pull/394#issuecomment-849102785
> > @andygrove I have changed the condition to call info/trace to check the
job's prev status.
> > Should we trace all loop iterations or just info! when the status has
ianmcook edited a comment on pull request #10373:
URL: https://github.com/apache/arrow/pull/10373#issuecomment-849100677
@thisisnic could you please add a note in `r/vignettes/developing.Rmd`
instructing folks who want to contribute to the package to install the
development version of roxy
ianmcook commented on pull request #10373:
URL: https://github.com/apache/arrow/pull/10373#issuecomment-849100677
@thisisnic could you please add a note in `r/vignettes/developing.Rmd`
instructing folks who want to contribute to the package to install roxygen2
from GitHub using `remotes::i
andygrove commented on pull request #394:
URL: https://github.com/apache/arrow-datafusion/pull/394#issuecomment-849096396
> @andygrove I have changed the condition to call info/trace to check the
job's prev status.
> Should we trace all loop iterations or just info! when the status has
alamb closed pull request #380:
URL: https://github.com/apache/arrow-datafusion/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
alamb commented on pull request #380:
URL: https://github.com/apache/arrow-datafusion/pull/380#issuecomment-849096443
https://github.com/apache/arrow-datafusion/pull/426 appears to be the more
populate option; Closing in favor of that one
--
This is an automated message from the Apache G
alamb commented on pull request #425:
URL: https://github.com/apache/arrow-datafusion/pull/425#issuecomment-849095725
Thanks @Jimexist -- this looks nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
codecov-commenter edited a comment on pull request #394:
URL: https://github.com/apache/arrow-datafusion/pull/394#issuecomment-846541650
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
alamb commented on pull request #425:
URL: https://github.com/apache/arrow-datafusion/pull/425#issuecomment-849094910
The windows failure is unrelated
```
error: could not copy file from
'C:\Users\runneradmin\.cargo\bin\rustup-init.exe' to
'C:\Users\runneradmin\.cargo\bin\rus
alamb merged pull request #414:
URL: https://github.com/apache/arrow-datafusion/pull/414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
alamb commented on pull request #379:
URL: https://github.com/apache/arrow-datafusion/pull/379#issuecomment-849093913
This PR appears to need some rebasing / test fixing love:
https://github.com/apache/arrow-datafusion/pull/379/checks?check_run_id=2674096854
```
--
nevi-me merged pull request #363:
URL: https://github.com/apache/arrow-rs/pull/363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
nevi-me merged pull request #351:
URL: https://github.com/apache/arrow-rs/pull/351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
nevi-me closed issue #350:
URL: https://github.com/apache/arrow-rs/issues/350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please conta
alamb commented on pull request #403:
URL: https://github.com/apache/arrow-datafusion/pull/403#issuecomment-849091594
@Jimexist I plan to review this PR later today or tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nevi-me closed issue #361:
URL: https://github.com/apache/arrow-rs/issues/361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please conta
nevi-me merged pull request #362:
URL: https://github.com/apache/arrow-rs/pull/362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alamb commented on issue #345:
URL: https://github.com/apache/arrow-rs/issues/345#issuecomment-849086836
> Is it possible that there is a memory leak in bit_length_test_string and
match_single_group?
I don't know but it sounds like it is worth more investigation
> Should we d
alamb commented on pull request #422:
URL: https://github.com/apache/arrow-datafusion/pull/422#issuecomment-849084973
Looks like we just need a RAT (apache copyright statement) to get a clean CI
run and merge it. Perhaps we can add some section to the developer's guide once
implemented wit
alamb commented on pull request #422:
URL: https://github.com/apache/arrow-datafusion/pull/422#issuecomment-849084170
Looks like we just need a RAT (apache copyright statement) to get a clean CI
run and merge it. Perhaps we can add some section to the developer's guide once
implemented wit
jgoday commented on pull request #394:
URL: https://github.com/apache/arrow-datafusion/pull/394#issuecomment-849083697
@andygrove I have changed the condition to call info/trace to check the
job's prev status.
Should we trace all loop iterations or just info! when the status has
changed
alamb commented on pull request #341:
URL: https://github.com/apache/arrow-rs/pull/341#issuecomment-849082802
Thanks @ritchie46 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
alamb merged pull request #341:
URL: https://github.com/apache/arrow-rs/pull/341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
jorgecarleitao commented on issue #345:
URL: https://github.com/apache/arrow-rs/issues/345#issuecomment-849082680
Just to understand, the memory consumption is only when running the test via
MIRI, right?
--
This is an automated message from the Apache Git Service.
To respond to the messa
alamb commented on pull request #360:
URL: https://github.com/apache/arrow-rs/pull/360#issuecomment-849081399
I think @roee88 has found the root cause:
https://github.com/apache/arrow-rs/issues/345#issuecomment-849055081 👍
--
This is an automated message from the Apache Git Service.
To
alamb commented on issue #345:
URL: https://github.com/apache/arrow-rs/issues/345#issuecomment-849080451
Thank you @roee88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alamb merged pull request #375:
URL: https://github.com/apache/arrow-datafusion/pull/375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
jorgecarleitao closed issue #368:
URL: https://github.com/apache/arrow-rs/issues/368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
jorgecarleitao merged pull request #369:
URL: https://github.com/apache/arrow-rs/pull/369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
jorgecarleitao merged pull request #360:
URL: https://github.com/apache/arrow-rs/pull/360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
westonpace commented on pull request #10404:
URL: https://github.com/apache/arrow/pull/10404#issuecomment-849076053
Maybe CC @kou @kszucs ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
westonpace commented on pull request #10404:
URL: https://github.com/apache/arrow/pull/10404#issuecomment-849075175
While this is cool (thanks for creating this) it seems to me that it might
be more appropriate to put this check into the C++ layer. That's where we
express other runtime de
Dandandan opened a new issue #371:
URL: https://github.com/apache/arrow-rs/issues/371
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
A clear and concise description of what the problem is. Ex. I'm always
frustrated when [...]
ianmcook commented on a change in pull request #10327:
URL: https://github.com/apache/arrow/pull/10327#discussion_r640059959
##
File path: r/R/dplyr-functions.R
##
@@ -58,7 +58,16 @@ nse_funcs$cast <- function(x, target_type, safe = TRUE, ...)
{
}
nse_funcs$is <- function(
roee88 commented on issue #345:
URL: https://github.com/apache/arrow-rs/issues/345#issuecomment-849055081
I think that the issue description here is wrong and this is expected for
test_time32second_invalid_neg.
I did a quick memory usage check and identifier the following:
1. bit_
Dandandan commented on pull request #432:
URL: https://github.com/apache/arrow-datafusion/pull/432#issuecomment-849054115
He @jorgecarleitao
Looks good, I already did the same in
https://github.com/apache/arrow-datafusion/pull/339 😂
--
This is an automated message from the Apache
codecov-commenter commented on pull request #432:
URL: https://github.com/apache/arrow-datafusion/pull/432#issuecomment-849049756
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/432?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment
westonpace commented on a change in pull request #10289:
URL: https://github.com/apache/arrow/pull/10289#discussion_r640051142
##
File path: cpp/src/parquet/schema_test.cc
##
@@ -171,17 +167,16 @@ TEST_F(TestPrimitiveNode, Attrs) {
}
TEST_F(TestPrimitiveNode, FromParquet) {
westonpace commented on a change in pull request #10289:
URL: https://github.com/apache/arrow/pull/10289#discussion_r640049553
##
File path: cpp/src/parquet/arrow/arrow_schema_test.cc
##
@@ -1157,6 +1160,94 @@ TEST_F(TestConvertArrowSchema, ParquetFlatDecimals) {
ASSERT_NO_F
westonpace commented on a change in pull request #10289:
URL: https://github.com/apache/arrow/pull/10289#discussion_r640049553
##
File path: cpp/src/parquet/arrow/arrow_schema_test.cc
##
@@ -1157,6 +1160,94 @@ TEST_F(TestConvertArrowSchema, ParquetFlatDecimals) {
ASSERT_NO_F
nirandaperera commented on pull request #10410:
URL: https://github.com/apache/arrow/pull/10410#issuecomment-849044674
@bkietz I think the bitmap ops approach is simpler than the bitmap visitor
approach. WDYT?
bitmap ops -
https://github.com/apache/arrow/blob/8c0e8d9749f171da3826d9b
westonpace commented on a change in pull request #10289:
URL: https://github.com/apache/arrow/pull/10289#discussion_r640045424
##
File path: cpp/src/parquet/schema.h
##
@@ -268,7 +268,7 @@ class PARQUET_EXPORT GroupNode : public Node {
public:
// The field_id here is the d
n3world commented on a change in pull request #10321:
URL: https://github.com/apache/arrow/pull/10321#discussion_r640039477
##
File path: cpp/src/arrow/csv/parser.h
##
@@ -63,19 +63,24 @@ class ARROW_EXPORT DataBatch {
uint32_t num_bytes() const { return parsed_size_; }
pitrou commented on a change in pull request #10321:
URL: https://github.com/apache/arrow/pull/10321#discussion_r640038839
##
File path: python/pyarrow/tests/test_csv.py
##
@@ -52,18 +52,20 @@ def generate_col_names():
yield first + second
-def make_random_csv(
n3world commented on a change in pull request #10321:
URL: https://github.com/apache/arrow/pull/10321#discussion_r640037240
##
File path: python/pyarrow/tests/test_csv.py
##
@@ -52,18 +52,20 @@ def generate_col_names():
yield first + second
-def make_random_csv
jorgecarleitao opened a new pull request #432:
URL: https://github.com/apache/arrow-datafusion/pull/432
Closes #431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For que
jorgecarleitao opened a new issue #431:
URL: https://github.com/apache/arrow-datafusion/issues/431
There is some small simplifications possible (PR to follow)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
lidavidm commented on pull request #10369:
URL: https://github.com/apache/arrow/pull/10369#issuecomment-849028711
> > That said I don't think it's too big a deal for us.
>
> It depends what you mean. The fact that `ß` and `ss` don't match is a bit
of a bummer for German text, for exa
1 - 100 of 172 matches
Mail list logo
