Jimexist commented on a change in pull request #589:
URL: https://github.com/apache/arrow-datafusion/pull/589#discussion_r654865677
##
File path: dev/docker/ballista-base.dockerfile
##
@@ -23,7 +23,7 @@
# Base image extends debian:buster-slim
-FROM rust:1.51.0-buster AS bu
github-actions[bot] commented on pull request #10560:
URL: https://github.com/apache/arrow/pull/10560#issuecomment-864469114
Revision: 31fc14eeb7ca55e24fdf6fc01f506e5988a30c7d
Submitted crossbow builds: [ursacomputing/crossbow @
actions-504](https://github.com/ursacomputing/crossbow/
jonkeane commented on pull request #10560:
URL: https://github.com/apache/arrow/pull/10560#issuecomment-864469026
@github-actions crossbow submit test-r-linux-valgrind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
0x0L opened a new pull request #10562:
URL: https://github.com/apache/arrow/pull/10562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
github-actions[bot] commented on pull request #10562:
URL: https://github.com/apache/arrow/pull/10562#issuecomment-864466953
https://issues.apache.org/jira/browse/ARROW-13129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
github-actions[bot] commented on pull request #10561:
URL: https://github.com/apache/arrow/pull/10561#issuecomment-864466399
https://issues.apache.org/jira/browse/ARROW-13128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
0x0L opened a new pull request #10561:
URL: https://github.com/apache/arrow/pull/10561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
nirandaperera commented on a change in pull request #10487:
URL: https://github.com/apache/arrow/pull/10487#discussion_r654838986
##
File path: cpp/src/arrow/compute/kernels/scalar_if_else.cc
##
@@ -72,18 +72,6 @@ Status PromoteNullsVisitor(KernelContext* ctx, const Datum&
con
github-actions[bot] commented on pull request #10560:
URL: https://github.com/apache/arrow/pull/10560#issuecomment-86588
Revision: a057f126683485806e0e090e1d7f0b12800125d2
Submitted crossbow builds: [ursacomputing/crossbow @
actions-503](https://github.com/ursacomputing/crossbow/
jonkeane closed pull request #10554:
URL: https://github.com/apache/arrow/pull/10554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
jonkeane commented on pull request #10554:
URL: https://github.com/apache/arrow/pull/10554#issuecomment-86537
LGTM, I'll look into the valgrind error that looks like it's from these
tests next week. Thank you for catching this so quickly!
--
This is an automated message from the Apac
github-actions[bot] commented on pull request #10560:
URL: https://github.com/apache/arrow/pull/10560#issuecomment-86507
https://issues.apache.org/jira/browse/ARROW-13127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
jonkeane commented on pull request #10560:
URL: https://github.com/apache/arrow/pull/10560#issuecomment-86513
@github-actions crossbow submit test-r-linux-valgrind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
jonkeane opened a new pull request #10560:
URL: https://github.com/apache/arrow/pull/10560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
nevi-me merged pull request #472:
URL: https://github.com/apache/arrow-rs/pull/472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alippai commented on issue #591:
URL:
https://github.com/apache/arrow-datafusion/issues/591#issuecomment-864427112
Eg. spark has these:
--
This is an automated message fr
alippai opened a new issue #591:
URL: https://github.com/apache/arrow-datafusion/issues/591
Maybe some other topics should be considered as well.
Context:
--
This i
alippai opened a new issue #473:
URL: https://github.com/apache/arrow-rs/issues/473
Maybe some other topics should be considered as well.
Context:
--
This is an automat
codecov-commenter edited a comment on pull request #453:
URL: https://github.com/apache/arrow-rs/pull/453#issuecomment-860252582
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/453?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
codecov-commenter edited a comment on pull request #468:
URL: https://github.com/apache/arrow-rs/pull/468#issuecomment-864404231
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
nevi-me merged pull request #471:
URL: https://github.com/apache/arrow-rs/pull/471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
codecov-commenter edited a comment on pull request #472:
URL: https://github.com/apache/arrow-rs/pull/472#issuecomment-864405178
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/472?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
codecov-commenter edited a comment on pull request #471:
URL: https://github.com/apache/arrow-rs/pull/471#issuecomment-864404332
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/471?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
codecov-commenter edited a comment on pull request #468:
URL: https://github.com/apache/arrow-rs/pull/468#issuecomment-864404231
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
codecov-commenter edited a comment on pull request #464:
URL: https://github.com/apache/arrow-rs/pull/464#issuecomment-864397722
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/464?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
codecov-commenter edited a comment on pull request #466:
URL: https://github.com/apache/arrow-rs/pull/466#issuecomment-864398754
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
codecov-commenter edited a comment on pull request #453:
URL: https://github.com/apache/arrow-rs/pull/453#issuecomment-860252582
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/453?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
codecov-commenter edited a comment on pull request #465:
URL: https://github.com/apache/arrow-rs/pull/465#issuecomment-864397987
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/465?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
Dandandan commented on pull request #469:
URL: https://github.com/apache/arrow-rs/pull/469#issuecomment-864421001
Closed by #470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Dandandan closed pull request #469:
URL: https://github.com/apache/arrow-rs/pull/469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
nevi-me commented on pull request #470:
URL: https://github.com/apache/arrow-rs/pull/470#issuecomment-864421005
Thanks, you beat me to this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Dandandan closed issue #467:
URL: https://github.com/apache/arrow-rs/issues/467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
Dandandan merged pull request #470:
URL: https://github.com/apache/arrow-rs/pull/470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
gangliao commented on pull request #321:
URL: https://github.com/apache/arrow-rs/pull/321#issuecomment-864415722
Yes. @alamb Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gangliao closed pull request #321:
URL: https://github.com/apache/arrow-rs/pull/321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
Jimexist edited a comment on pull request #469:
URL: https://github.com/apache/arrow-rs/pull/469#issuecomment-864407054
> I started on getting clippy CI running again but ran out of time this
morning. Will finish up tomorrow if no one beats me to it
😄 I got the similar fix in https:/
codecov-commenter edited a comment on pull request #453:
URL: https://github.com/apache/arrow-rs/pull/453#issuecomment-860252582
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/453?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
github-actions[bot] commented on pull request #10554:
URL: https://github.com/apache/arrow/pull/10554#issuecomment-864407301
Revision: c81764c8e23c8ca00b0c538a6b3fc6c42f336b68
Submitted crossbow builds: [ursacomputing/crossbow @
actions-502](https://github.com/ursacomputing/crossbow/
jonkeane commented on pull request #10554:
URL: https://github.com/apache/arrow/pull/10554#issuecomment-864407186
@github-actions crossbow submit test-r-linux-valgrind
I don't think this will fix it, but trying just in case it magically does.
--
This is an automated message from th
Jimexist commented on pull request #469:
URL: https://github.com/apache/arrow-rs/pull/469#issuecomment-864407054
😄 I got the similar fix in https://github.com/apache/arrow-rs/pull/470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alippai commented on a change in pull request #453:
URL: https://github.com/apache/arrow-rs/pull/453#discussion_r654796610
##
File path: arrow/src/ffi.rs
##
@@ -271,12 +271,54 @@ fn to_field(schema: &FFI_ArrowSchema) -> Result {
.collect::>>()?;
Da
alippai commented on a change in pull request #453:
URL: https://github.com/apache/arrow-rs/pull/453#discussion_r654795387
##
File path: arrow/src/ffi.rs
##
@@ -271,12 +271,54 @@ fn to_field(schema: &FFI_ArrowSchema) -> Result {
.collect::>>()?;
Da
codecov-commenter commented on pull request #472:
URL: https://github.com/apache/arrow-rs/pull/472#issuecomment-864405178
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/472?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
codecov-commenter commented on pull request #470:
URL: https://github.com/apache/arrow-rs/pull/470#issuecomment-864404631
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
codecov-commenter commented on pull request #471:
URL: https://github.com/apache/arrow-rs/pull/471#issuecomment-864404332
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/471?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
codecov-commenter commented on pull request #468:
URL: https://github.com/apache/arrow-rs/pull/468#issuecomment-864404231
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
Jimexist commented on pull request #471:
URL: https://github.com/apache/arrow-rs/pull/471#issuecomment-864403986
need to merge https://github.com/apache/arrow-rs/pull/470 first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Jimexist opened a new pull request #472:
URL: https://github.com/apache/arrow-rs/pull/472
# Which issue does this PR close?
Closes #.
# Rationale for this change
remove stale comment and update unit tests
# What changes are included in this PR?
# A
Dandandan commented on pull request #468:
URL: https://github.com/apache/arrow-rs/pull/468#issuecomment-864402804
@alamb this should be merged to master to be able to test the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Jimexist opened a new pull request #471:
URL: https://github.com/apache/arrow-rs/pull/471
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
Jimexist opened a new pull request #470:
URL: https://github.com/apache/arrow-rs/pull/470
# Which issue does this PR close?
fix clippy warnings for rust 1.53
Closes #.
# Rationale for this change
# What changes are included in this PR?
# A
codecov-commenter commented on pull request #469:
URL: https://github.com/apache/arrow-rs/pull/469#issuecomment-864401920
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/469?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
alippai commented on pull request #439:
URL: https://github.com/apache/arrow-rs/pull/439#issuecomment-864401873
> @jorgecarleitao what do you think about implementing `arrow <-> pyarrow`
interoperability directly in the `arrow-rs` repository and use that from the
datafusion bindings?
jorgecarleitao commented on a change in pull request #453:
URL: https://github.com/apache/arrow-rs/pull/453#discussion_r654790603
##
File path: arrow/src/ffi.rs
##
@@ -271,12 +271,54 @@ fn to_field(schema: &FFI_ArrowSchema) -> Result {
.collect::>>()?;
alamb opened a new pull request #469:
URL: https://github.com/apache/arrow-rs/pull/469
# Which issue does this PR close?
Closes https://github.com/apache/arrow-rs/issues/467
I started on getting clippy CI running again but ran out of time this
morning. Will finish up tomorrow
codecov-commenter commented on pull request #466:
URL: https://github.com/apache/arrow-rs/pull/466#issuecomment-864398754
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
Dandandan opened a new pull request #468:
URL: https://github.com/apache/arrow-rs/pull/468
# Which issue does this PR close?
Closes #462
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing chang
codecov-commenter edited a comment on pull request #465:
URL: https://github.com/apache/arrow-rs/pull/465#issuecomment-864397987
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/465?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
codecov-commenter edited a comment on pull request #464:
URL: https://github.com/apache/arrow-rs/pull/464#issuecomment-864397722
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/464?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
codecov-commenter commented on pull request #465:
URL: https://github.com/apache/arrow-rs/pull/465#issuecomment-864397987
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/465?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
Dandandan commented on a change in pull request #569:
URL: https://github.com/apache/arrow-datafusion/pull/569#discussion_r654788741
##
File path: datafusion/benches/window_query_sql.rs
##
@@ -0,0 +1,166 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or m
codecov-commenter commented on pull request #464:
URL: https://github.com/apache/arrow-rs/pull/464#issuecomment-864397722
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/464?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A
alamb opened a new issue #467:
URL: https://github.com/apache/arrow-rs/issues/467
**Describe the bug**
Rust 1.53 was released with improved (aka more stringent) clippy resulting
in some new clippy CI failures:
Example run:
https://github.com/apache/arrow-rs/runs/2864727407
alamb opened a new pull request #466:
URL: https://github.com/apache/arrow-rs/pull/466
Tweak docs as I do this process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
alamb opened a new pull request #465:
URL: https://github.com/apache/arrow-rs/pull/465
Manual Cherry pick of fb451125 from
https://github.com/apache/arrow-rs/pull/406
I didn't bring the changes to benches as that caused a conflict
FYI @alippai
--
This is an automated message f
alamb opened a new pull request #464:
URL: https://github.com/apache/arrow-rs/pull/464
Automatic cherry-pick of 0f55b82
* Originally appeared in https://github.com/apache/arrow-rs/pull/388:
window::shift to work for all array types
--
This is an automated message from the Apache G
alamb edited a comment on pull request #321:
URL: https://github.com/apache/arrow-rs/pull/321#issuecomment-864395624
@gangliao are you satisfied with @jorgecarleitao 's suggestion
https://github.com/apache/arrow-rs/pull/321#issuecomment-843729878 ? Shall we
close this PR?
--
This is an
alamb commented on pull request #321:
URL: https://github.com/apache/arrow-rs/pull/321#issuecomment-864395624
@gangliao are you satisfied with @jorgecarleitao 's suggestion
https://github.com/apache/arrow-rs/pull/321#issuecomment-843729878 ? Shall we
close this PR
--
This is an automat
alamb merged pull request #448:
URL: https://github.com/apache/arrow-rs/pull/448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
alamb closed issue #447:
URL: https://github.com/apache/arrow-rs/issues/447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
alamb commented on pull request #448:
URL: https://github.com/apache/arrow-rs/pull/448#issuecomment-864395352
I finally got a chance to re-run the tests
Using 2^14 = 16384
```
critcmp master bool-partition
group bool-partition mas
Jimexist commented on pull request #558:
URL: https://github.com/apache/arrow-datafusion/pull/558#issuecomment-864393165
> Looks great again! - 2 comments about tests for being a bit more future
proof
fixed, about repartition i'll handle that in #569 but so far i'm seeing
regression
Jimexist commented on a change in pull request #558:
URL: https://github.com/apache/arrow-datafusion/pull/558#discussion_r654784583
##
File path: datafusion/src/execution/context.rs
##
@@ -1355,6 +1355,90 @@ mod tests {
Ok(())
}
+#[tokio::test]
+async fn
alamb merged pull request #457:
URL: https://github.com/apache/arrow-rs/pull/457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
alamb commented on pull request #457:
URL: https://github.com/apache/arrow-rs/pull/457#issuecomment-864391834
Whoops -- not sure why I closed (rather than merging) this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
alamb merged pull request #567:
URL: https://github.com/apache/arrow-datafusion/pull/567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
alamb commented on pull request #567:
URL: https://github.com/apache/arrow-datafusion/pull/567#issuecomment-864391436
Thanks @velvia -- this looks great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb closed issue #355:
URL: https://github.com/apache/arrow-datafusion/issues/355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alamb commented on a change in pull request #567:
URL: https://github.com/apache/arrow-datafusion/pull/567#discussion_r654782968
##
File path: docs/user-guide/src/sql/datafusion-functions.md
##
@@ -0,0 +1,86 @@
+
+
+# Datafusion-Specific Functions
+
+These SQL functions are spe
alamb commented on issue #460:
URL: https://github.com/apache/arrow-rs/issues/460#issuecomment-864390227
@b41sh yes please! I will assign it to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Dandandan commented on a change in pull request #558:
URL: https://github.com/apache/arrow-datafusion/pull/558#discussion_r654776646
##
File path: datafusion/src/physical_plan/expressions/nth_value.rs
##
@@ -135,8 +135,12 @@ impl BuiltInWindowFunctionExpr for NthValue {
Dandandan commented on a change in pull request #558:
URL: https://github.com/apache/arrow-datafusion/pull/558#discussion_r654776435
##
File path: datafusion/src/execution/context.rs
##
@@ -1355,6 +1355,90 @@ mod tests {
Ok(())
}
+#[tokio::test]
+async f
Dandandan commented on a change in pull request #558:
URL: https://github.com/apache/arrow-datafusion/pull/558#discussion_r654776385
##
File path: datafusion/src/execution/context.rs
##
@@ -1355,6 +1355,90 @@ mod tests {
Ok(())
}
+#[tokio::test]
+async f
Jimexist commented on pull request #558:
URL: https://github.com/apache/arrow-datafusion/pull/558#issuecomment-864375798
@Dandandan this is fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
84 matches
Mail list logo
