[GitHub] [arrow] isichei commented on a change in pull request #10575: ARROW-13086: [Python] Expose Parquet ArrowReaderProperties::coerce_int96_timestamp_unit_

2021-06-22 Thread GitBox
isichei commented on a change in pull request #10575: URL: https://github.com/apache/arrow/pull/10575#discussion_r656811035 ## File path: python/pyarrow/parquet.py ## @@ -213,15 +213,23 @@ class ParquetFile: Coalesce and issue file reads in parallel to improve performa

[GitHub] [arrow] github-actions[bot] commented on pull request #10575: ARROW-13086: [Python] Expose Parquet ArrowReaderProperties::coerce_int96_timestamp_unit_

2021-06-22 Thread GitBox
github-actions[bot] commented on pull request #10575: URL: https://github.com/apache/arrow/pull/10575#issuecomment-866580221 https://issues.apache.org/jira/browse/ARROW-13086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] isichei opened a new pull request #10575: ARROW-13086: [Python] Expose Parquet ArrowReaderProperties::coerce_int96_timestamp_unit_

2021-06-22 Thread GitBox
isichei opened a new pull request #10575: URL: https://github.com/apache/arrow/pull/10575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #571: Collapse sort into window expr and do sort within logical phase

2021-06-22 Thread GitBox
houqp commented on a change in pull request #571: URL: https://github.com/apache/arrow-datafusion/pull/571#discussion_r656791849 ## File path: datafusion/src/physical_plan/planner.rs ## @@ -283,7 +322,7 @@ impl DefaultPhysicalPlanner { Ok(Arc::new(WindowAggExec

[GitHub] [arrow-rs] Dandandan commented on a change in pull request #492: concatenating single element array shortcut

2021-06-22 Thread GitBox
Dandandan commented on a change in pull request #492: URL: https://github.com/apache/arrow-rs/pull/492#discussion_r656789000 ## File path: arrow/src/compute/kernels/concat.rs ## @@ -57,6 +57,9 @@ pub fn concat(arrays: &[&Array]) -> Result { return Err(ArrowError::Compu

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #605: fix join column handling logic for `On` and `Using` constraints

2021-06-22 Thread GitBox
houqp commented on a change in pull request #605: URL: https://github.com/apache/arrow-datafusion/pull/605#discussion_r656785924 ## File path: datafusion/src/physical_plan/hash_utils.rs ## @@ -21,25 +21,9 @@ use crate::error::{DataFusionError, Result}; use arrow::datatypes::{F

[GitHub] [arrow-datafusion] houqp opened a new pull request #605: fix join column handling logic for `On` and `Using` constraints

2021-06-22 Thread GitBox
houqp opened a new pull request #605: URL: https://github.com/apache/arrow-datafusion/pull/605 # Which issue does this PR close? Follow up for https://github.com/apache/arrow-datafusion/pull/55#pullrequestreview-683118433. Closes #601. Also fixed a bug where `index_

[GitHub] [arrow-rs] codecov-commenter commented on pull request #492: concatenating single element array shortcut

2021-06-22 Thread GitBox
codecov-commenter commented on pull request #492: URL: https://github.com/apache/arrow-rs/pull/492#issuecomment-866546109 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/492?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [arrow-rs] Jimexist commented on a change in pull request #490: Implement function slice for RecordBatch

2021-06-22 Thread GitBox
Jimexist commented on a change in pull request #490: URL: https://github.com/apache/arrow-rs/pull/490#discussion_r656770815 ## File path: arrow/src/record_batch.rs ## @@ -426,6 +441,29 @@ mod tests { assert_eq!(5, record_batch.column(1).data().len()); } +#[t

[GitHub] [arrow-rs] Jimexist commented on a change in pull request #490: Implement function slice for RecordBatch

2021-06-22 Thread GitBox
Jimexist commented on a change in pull request #490: URL: https://github.com/apache/arrow-rs/pull/490#discussion_r656770581 ## File path: arrow/src/record_batch.rs ## @@ -244,6 +244,21 @@ impl RecordBatch { &self.columns[..] } +/// Return a new RecordBatch w

[GitHub] [arrow-rs] Jimexist opened a new pull request #492: concatenating single element array shortcut

2021-06-22 Thread GitBox
Jimexist opened a new pull request #492: URL: https://github.com/apache/arrow-rs/pull/492 # Which issue does this PR close? concatenating single element array shortcut Closes #. # Rationale for this change no need to any work when the given array is single element

[GitHub] [arrow] westonpace commented on issue #10488: Passing back and forth from Python and C++ with Pyarrow C++ extension and pybind11.

2021-06-22 Thread GitBox
westonpace commented on issue #10488: URL: https://github.com/apache/arrow/issues/10488#issuecomment-866495014 @frmnboi If you can make a github repo that compiles and exhibits the error I'd be willing to help you debug the issue. -- This is an automated message from the Apache Git Servi

[GitHub] [arrow] kou commented on a change in pull request #10571: ARROW-8459: [Dev][Archery] Use a more recent cmake-format

2021-06-22 Thread GitBox
kou commented on a change in pull request #10571: URL: https://github.com/apache/arrow/pull/10571#discussion_r656722722 ## File path: .pre-commit-config.yaml ## @@ -29,13 +29,6 @@ repos: entry: bash -c "git archive HEAD --prefix=apache-arrow/ --output=arrow-src.tar &&

[GitHub] [arrow] kou commented on a change in pull request #10571: ARROW-8459: [Dev][Archery] Use a more recent cmake-format

2021-06-22 Thread GitBox
kou commented on a change in pull request #10571: URL: https://github.com/apache/arrow/pull/10571#discussion_r656721780 ## File path: dev/archery/archery/utils/lint.py ## @@ -90,20 +91,75 @@ def cpp_linter(src, build_dir, clang_format=True, cpplint=True, class CMakeFormat

[GitHub] [arrow-datafusion] artorias1024 opened a new issue #604: cannot find function `bitwise_bin_op_simd_helper` in this scope

2021-06-22 Thread GitBox
artorias1024 opened a new issue #604: URL: https://github.com/apache/arrow-datafusion/issues/604 **Describe the bug** When I running the DataFusion Benchmarks and enable eatures `simd` ``` artorias@artorias-ThinkPad-X1-Carbon-Gen-8:~/workspace-vscode/arrow-datafusion/benchmarks$ c

[GitHub] [arrow] frmnboi commented on issue #10488: Passing back and forth from Python and C++ with Pyarrow C++ extension and pybind11.

2021-06-22 Thread GitBox
frmnboi commented on issue #10488: URL: https://github.com/apache/arrow/issues/10488#issuecomment-866449647 To give an update, I've tried this on a second, intel-based computer and wasn't able to get it to run without segfaulting. As far as debugging the code goes, it claims to success

[GitHub] [arrow-datafusion] Jimexist commented on pull request #569: Use repartition in window functions to speed up

2021-06-22 Thread GitBox
Jimexist commented on pull request #569: URL: https://github.com/apache/arrow-datafusion/pull/569#issuecomment-866448201 > Nice, almost 5 times improvement for some queries! > > But do those have to do with the changes wrt sort or with regards to partition by? I don't expect t

[GitHub] [arrow] lidavidm commented on pull request #10305: ARROW-12730: [MATLAB] Update featherreadmex and featherwritemex to build against latest Arrow C++ APIs

2021-06-22 Thread GitBox
lidavidm commented on pull request #10305: URL: https://github.com/apache/arrow/pull/10305#issuecomment-866407546 Hey, sorry for the delay (again) - I can try to review this once I get a chance, but you may also want to poke the mailing list (d...@arrow.apache.org) to see if someone else i

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #474: Doctest for GenericListArray.

2021-06-22 Thread GitBox
codecov-commenter edited a comment on pull request #474: URL: https://github.com/apache/arrow-rs/pull/474#issuecomment-864520421 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/474?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [arrow-datafusion] alamb commented on pull request #571: Collapse sort into window expr and do sort within logical phase

2021-06-22 Thread GitBox
alamb commented on pull request #571: URL: https://github.com/apache/arrow-datafusion/pull/571#issuecomment-866384884 I am sorry I am behind on reviews in DataFusion -- I plan to work through the backlog tomorrow -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow-datafusion] alamb merged pull request #577: Support modulus op

2021-06-22 Thread GitBox
alamb merged pull request #577: URL: https://github.com/apache/arrow-datafusion/pull/577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow] ursabot edited a comment on pull request #10487: ARROW-13010: [C++][Compute] Support outputting to slices from kleene kernels

2021-06-22 Thread GitBox
ursabot edited a comment on pull request #10487: URL: https://github.com/apache/arrow/pull/10487#issuecomment-866299978 Benchmark runs are scheduled for baseline = c913aa3ad7b36b2eaccd4dc2cf0bc35ab893bb4a and contender = bcce18e5d4d83f0831de71b363ad91470376084c. Results will be available a

[GitHub] [arrow] lidavidm closed pull request #10573: ARROW-10440: [C++][Dataset] Visit FileWriters before Finish

2021-06-22 Thread GitBox
lidavidm closed pull request #10573: URL: https://github.com/apache/arrow/pull/10573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [arrow-datafusion] jorgecarleitao commented on issue #600: Allow User Defined Aggregates to return multiple values / structs

2021-06-22 Thread GitBox
jorgecarleitao commented on issue #600: URL: https://github.com/apache/arrow-datafusion/issues/600#issuecomment-866337998 Perfect. I created #602 and #603 . 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow-datafusion] jorgecarleitao opened a new issue #603: Add support for getter for StructArray

2021-06-22 Thread GitBox
jorgecarleitao opened a new issue #603: URL: https://github.com/apache/arrow-datafusion/issues/603 Given a `StructArray` column `a` with a field `b`, I would like to be able to run ``` SELECT a.b from t ``` returning the array associated with field `b` in the array `a`

[GitHub] [arrow-datafusion] jorgecarleitao opened a new issue #602: Add support for StructArray to `ScalarValue`

2021-06-22 Thread GitBox
jorgecarleitao opened a new issue #602: URL: https://github.com/apache/arrow-datafusion/issues/602 Enabling DataFusion to support `StructArray` for some of its scalar operations. Note that this may be difficult to support in Ballista due to how scalar values are currently represente

[GitHub] [arrow] ursabot edited a comment on pull request #10487: ARROW-13010: [C++][Compute] Support outputting to slices from kleene kernels

2021-06-22 Thread GitBox
ursabot edited a comment on pull request #10487: URL: https://github.com/apache/arrow/pull/10487#issuecomment-866299978 Benchmark runs are scheduled for baseline = c913aa3ad7b36b2eaccd4dc2cf0bc35ab893bb4a and contender = bcce18e5d4d83f0831de71b363ad91470376084c. Results will be available a

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #488: Update rand, proc-macro and zstd dependencies

2021-06-22 Thread GitBox
codecov-commenter edited a comment on pull request #488: URL: https://github.com/apache/arrow-rs/pull/488#issuecomment-865898976 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/488?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [arrow] ursabot edited a comment on pull request #10487: ARROW-13010: [C++][Compute] Support outputting to slices from kleene kernels

2021-06-22 Thread GitBox
ursabot edited a comment on pull request #10487: URL: https://github.com/apache/arrow/pull/10487#issuecomment-866299978 Benchmark runs are scheduled for baseline = c913aa3ad7b36b2eaccd4dc2cf0bc35ab893bb4a and contender = bcce18e5d4d83f0831de71b363ad91470376084c. Results will be available a

[GitHub] [arrow] nealrichardson commented on a change in pull request #10507: ARROW-13022: [R] bindings for lubridate's year, isoyear, quarter, month, day, wday, yday, isoweek, hour, minute, and secon

2021-06-22 Thread GitBox
nealrichardson commented on a change in pull request #10507: URL: https://github.com/apache/arrow/pull/10507#discussion_r656553130 ## File path: r/tests/testthat/test-dplyr-lubridate.R ## @@ -0,0 +1,174 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [arrow] nirandaperera commented on pull request #10487: ARROW-13010: [C++][Compute] Support outputting to slices from kleene kernels

2021-06-22 Thread GitBox
nirandaperera commented on pull request #10487: URL: https://github.com/apache/arrow/pull/10487#issuecomment-866302771 @ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-scalar-boolean-benchmark -- This is an automated message from the Apache Git Service. To respon

[GitHub] [arrow] ursabot commented on pull request #10487: ARROW-13010: [C++][Compute] Support outputting to slices from kleene kernels

2021-06-22 Thread GitBox
ursabot commented on pull request #10487: URL: https://github.com/apache/arrow/pull/10487#issuecomment-866299978 Benchmark runs are scheduled for baseline = c913aa3ad7b36b2eaccd4dc2cf0bc35ab893bb4a and contender = bcce18e5d4d83f0831de71b363ad91470376084c. Results will be available as each

[GitHub] [arrow] nirandaperera commented on pull request #10487: ARROW-13010: [C++][Compute] Support outputting to slices from kleene kernels

2021-06-22 Thread GitBox
nirandaperera commented on pull request #10487: URL: https://github.com/apache/arrow/pull/10487#issuecomment-866299350 @ursabot please benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow] edponce commented on a change in pull request #10395: ARROW-12861: [C++][Compute] Add sign function kernels

2021-06-22 Thread GitBox
edponce commented on a change in pull request #10395: URL: https://github.com/apache/arrow/pull/10395#discussion_r656530353 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -454,6 +456,48 @@ struct PowerChecked { } }; +struct Sign { + template ::val

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #10507: ARROW-13022: [R] bindings for lubridate's year, isoyear, quarter, month, day, wday, yday, isoweek, hour, minute, and s

2021-06-22 Thread GitBox
jorisvandenbossche commented on a change in pull request #10507: URL: https://github.com/apache/arrow/pull/10507#discussion_r656528973 ## File path: r/tests/testthat/test-dplyr-lubridate.R ## @@ -0,0 +1,174 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [arrow] edponce commented on a change in pull request #10395: ARROW-12861: [C++][Compute] Add sign function kernels

2021-06-22 Thread GitBox
edponce commented on a change in pull request #10395: URL: https://github.com/apache/arrow/pull/10395#discussion_r656525276 ## File path: cpp/src/arrow/compute/api_scalar.cc ## @@ -50,6 +50,11 @@ namespace compute { SCALAR_ARITHMETIC_UNARY(AbsoluteValue, "abs", "abs_checked")

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #488: Update rand, proc-macro and zstd dependencies

2021-06-22 Thread GitBox
codecov-commenter edited a comment on pull request #488: URL: https://github.com/apache/arrow-rs/pull/488#issuecomment-865898976 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/488?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [arrow] lidavidm commented on pull request #10511: ARROW-13025: [C++][Python] Add FunctionOptions::Equals/ToString/Serialize

2021-06-22 Thread GitBox
lidavidm commented on pull request #10511: URL: https://github.com/apache/arrow/pull/10511#issuecomment-866268714 Alright, I've pushed half a stab at this - I'm going to pick up ARROW-11932 so I can write a generic serialization for `vector` (where `T` itself is serializable to Scalar). We

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #569: Use repartition in window functions to speed up

2021-06-22 Thread GitBox
Dandandan commented on a change in pull request #569: URL: https://github.com/apache/arrow-datafusion/pull/569#discussion_r656508927 ## File path: datafusion/src/physical_plan/windows.rs ## @@ -412,11 +412,14 @@ impl ExecutionPlan for WindowAggExec { /// Get the output p

[GitHub] [arrow] blackary commented on pull request #10104: ARROW-12472: [Python] Properly convert paths to strings (using __fspath__)

2021-06-22 Thread GitBox
blackary commented on pull request #10104: URL: https://github.com/apache/arrow/pull/10104#issuecomment-866259853 Makes sense, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [arrow-datafusion] Dandandan commented on pull request #569: Use repartition in window functions to speed up

2021-06-22 Thread GitBox
Dandandan commented on pull request #569: URL: https://github.com/apache/arrow-datafusion/pull/569#issuecomment-866257274 Nice, almost 5 times improvement for some queries! But do those have to do with the changes wrt sort or with regards to partition by? -- This is an automated m

[GitHub] [arrow-datafusion] alamb commented on issue #600: Allow User Defined Aggregates to return multiple values / structs

2021-06-22 Thread GitBox
alamb commented on issue #600: URL: https://github.com/apache/arrow-datafusion/issues/600#issuecomment-866254025 > Would you be ok for you if we add two issues, one for supporting structs on ScalarValues, the other for supporting accessing struct fields by name on SQL as a replacement for

[GitHub] [arrow] lidavidm commented on pull request #10573: ARROW-10440: [C++][Dataset] Visit FileWriters before Finish

2021-06-22 Thread GitBox
lidavidm commented on pull request #10573: URL: https://github.com/apache/arrow/pull/10573#issuecomment-866251436 Thanks Weston. I'll merge here on green (minus the known failures). -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [arrow-datafusion] jorgecarleitao commented on issue #600: Allow User Defined Aggregates to return multiple values / structs

2021-06-22 Thread GitBox
jorgecarleitao commented on issue #600: URL: https://github.com/apache/arrow-datafusion/issues/600#issuecomment-866246437 it makes a lot of sense. Would you be ok for you if we add two issues, one for supporting structs on ScalarValues, the other for supporting accessing struct fiel

[GitHub] [arrow] westonpace commented on pull request #10573: ARROW-10440: [C++][Dataset] Visit FileWriters before Finish

2021-06-22 Thread GitBox
westonpace commented on pull request #10573: URL: https://github.com/apache/arrow/pull/10573#issuecomment-866243687 Let's leave ARROW-12364 open for the python bindings. I should be able to get to it this week. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [arrow-datafusion] alamb commented on issue #600: Allow User Defined Aggregates to return multiple values / structs

2021-06-22 Thread GitBox
alamb commented on issue #600: URL: https://github.com/apache/arrow-datafusion/issues/600#issuecomment-866240917 > Would supporting structs for ScalarValues solve this nicely? I think so @jorgecarleitao - what is also needed is some way in SQL to refer to the structs So like

[GitHub] [arrow] pitrou commented on a change in pull request #10574: ARROW-12790: [C++] Improve HadoopFileSystem conformance

2021-06-22 Thread GitBox
pitrou commented on a change in pull request #10574: URL: https://github.com/apache/arrow/pull/10574#discussion_r656488996 ## File path: cpp/src/arrow/filesystem/hdfs.cc ## @@ -134,21 +140,39 @@ class HadoopFileSystem::Impl { } std::vector results; +// Fetch wor

[GitHub] [arrow-datafusion] alamb commented on pull request #55: Support qualified columns in queries

2021-06-22 Thread GitBox
alamb commented on pull request #55: URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-866238181 I filed a ticket to track some follow on work: https://github.com/apache/arrow-datafusion/issues/601 -- This is an automated message from the Apache Git Service. To respon

[GitHub] [arrow-datafusion] alamb edited a comment on issue #601: Panic while running join datatypes/schema.rs:165:10

2021-06-22 Thread GitBox
alamb edited a comment on issue #601: URL: https://github.com/apache/arrow-datafusion/issues/601#issuecomment-866237550 Interestingly, it seems like f2.bar is causing some issues: ``` > select f1.bar from foo as f1 JOIN foo as f2 ON f1.bar = f2.bar; +-+ | bar | +-

[GitHub] [arrow-datafusion] alamb commented on issue #601: Panic while running join datatypes/schema.rs:165:10

2021-06-22 Thread GitBox
alamb commented on issue #601: URL: https://github.com/apache/arrow-datafusion/issues/601#issuecomment-866237550 Interestingly, it seems like f2.bar is causing some issues: ``` > select f1.bar from foo as f1 JOIN foo as f2 ON f1.bar = f2.bar; +-+ | bar | +-+ |

[GitHub] [arrow-datafusion] alamb opened a new issue #601: Panic while running join datatypes/schema.rs:165:10

2021-06-22 Thread GitBox
alamb opened a new issue #601: URL: https://github.com/apache/arrow-datafusion/issues/601 **Describe the bug** > select * from foo as f1 JOIN foo as f2 ON f1.bar = f2.bar; thread 'main' panicked at 'index out of bounds: the len is 1 but the index is 1', /Users/alamb/.cargo/regist

[GitHub] [arrow] lidavidm commented on a change in pull request #10574: ARROW-12790: [C++] Improve HadoopFileSystem conformance

2021-06-22 Thread GitBox
lidavidm commented on a change in pull request #10574: URL: https://github.com/apache/arrow/pull/10574#discussion_r656469358 ## File path: cpp/src/arrow/filesystem/test_util.cc ## @@ -453,9 +453,11 @@ void GenericFileSystemTest::TestMoveDir(FileSystem* fs) { AssertAllFiles(f

[GitHub] [arrow-datafusion] jorgecarleitao commented on issue #600: Allow User Defined Aggregates to return multiple values / structs

2021-06-22 Thread GitBox
jorgecarleitao commented on issue #600: URL: https://github.com/apache/arrow-datafusion/issues/600#issuecomment-866233559 When I implemented todays' aggs, I Initially though about multiple return values, and then concluded that the Struct is sufficient and desirable. What I like about the

[GitHub] [arrow] pitrou commented on pull request #10574: ARROW-12790: [C++] Improve HadoopFileSystem conformance

2021-06-22 Thread GitBox
pitrou commented on pull request #10574: URL: https://github.com/apache/arrow/pull/10574#issuecomment-866229901 Crossbow builds submitted at https://github.com/ursacomputing/crossbow/branches/all?query=build-364 -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #55: Support qualified columns in queries

2021-06-22 Thread GitBox
jorgecarleitao commented on pull request #55: URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-866228974 Thank you @houqp for this excellent PR, together with the .md docs. They set a really important foundation to the query's semantics 💯 -- This is an automated messa

[GitHub] [arrow-datafusion] alamb commented on pull request #55: Support qualified columns in queries

2021-06-22 Thread GitBox
alamb commented on pull request #55: URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-866222968 Thanks for the epic work @houqp -- this is really great to see -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [arrow] pitrou closed pull request #10566: ARROW-13135: [C++] Fix Status propagation from Parquet exception

2021-06-22 Thread GitBox
pitrou closed pull request #10566: URL: https://github.com/apache/arrow/pull/10566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] pitrou commented on a change in pull request #10395: ARROW-12861: [C++][Compute] Add sign function kernels

2021-06-22 Thread GitBox
pitrou commented on a change in pull request #10395: URL: https://github.com/apache/arrow/pull/10395#discussion_r656470969 ## File path: cpp/src/arrow/compute/api_scalar.cc ## @@ -50,6 +50,11 @@ namespace compute { SCALAR_ARITHMETIC_UNARY(AbsoluteValue, "abs", "abs_checked")

[GitHub] [arrow-datafusion] houqp commented on pull request #55: Support qualified columns in queries

2021-06-22 Thread GitBox
houqp commented on pull request #55: URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-866221029 Thank you all for the reviews! When I initially started working on this, I thought it would only take me two weekends, lol. I will send the join semantic change diff as a fol

[GitHub] [arrow] pitrou commented on pull request #10566: ARROW-13135: [C++] Fix Status propagation from Parquet exception

2021-06-22 Thread GitBox
pitrou commented on pull request #10566: URL: https://github.com/apache/arrow/pull/10566#issuecomment-866220429 CI failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [arrow] edponce commented on a change in pull request #10395: ARROW-12861: [C++][Compute] Add sign function kernels

2021-06-22 Thread GitBox
edponce commented on a change in pull request #10395: URL: https://github.com/apache/arrow/pull/10395#discussion_r656468614 ## File path: cpp/src/arrow/compute/api_scalar.cc ## @@ -50,6 +50,11 @@ namespace compute { SCALAR_ARITHMETIC_UNARY(AbsoluteValue, "abs", "abs_checked")

[GitHub] [arrow] pitrou commented on pull request #10574: ARROW-12790: [C++] Improve HadoopFileSystem conformance

2021-06-22 Thread GitBox
pitrou commented on pull request #10574: URL: https://github.com/apache/arrow/pull/10574#issuecomment-866220006 @github-actions crossbow submit test-conda-python-3.7-hdfs-3.2.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] pitrou commented on pull request #10574: ARROW-12790: [C++] Improve HadoopFileSystem conformance

2021-06-22 Thread GitBox
pitrou commented on pull request #10574: URL: https://github.com/apache/arrow/pull/10574#issuecomment-866219885 @github-actions crossbow submit test-conda-python-3.7-hdfs-2.9.2 test-conda-python-3.7-hdfs-3.21 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] pitrou commented on pull request #10574: ARROW-12790: [C++] Improve HadoopFileSystem conformance

2021-06-22 Thread GitBox
pitrou commented on pull request #10574: URL: https://github.com/apache/arrow/pull/10574#issuecomment-866217633 @github-actions crossbow submit test-*hdfs* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-datafusion] Dandandan commented on pull request #55: Support qualified columns in queries

2021-06-22 Thread GitBox
Dandandan commented on pull request #55: URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-866217530 Woohoo 🎉 🎉🎉🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [arrow] github-actions[bot] commented on pull request #10574: ARROW-12790: [C++] Improve HadoopFileSystem conformance

2021-06-22 Thread GitBox
github-actions[bot] commented on pull request #10574: URL: https://github.com/apache/arrow/pull/10574#issuecomment-866215494 https://issues.apache.org/jira/browse/ARROW-12790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] pitrou opened a new pull request #10574: ARROW-12790: [C++] Improve HadoopFileSystem conformance

2021-06-22 Thread GitBox
pitrou opened a new pull request #10574: URL: https://github.com/apache/arrow/pull/10574 * Ensure the HadoopFileSystem meets most requirements from the FileSystem API. * Implement HadoopFileSystem::CopyFile. * Enable generic filesystem tests for HadoopFileSystem. * Add generic file

[GitHub] [arrow-datafusion] alamb closed issue #56: Support column qualifer in queries

2021-06-22 Thread GitBox
alamb closed issue #56: URL: https://github.com/apache/arrow-datafusion/issues/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [arrow-datafusion] alamb closed issue #57: Support JOIN table alias

2021-06-22 Thread GitBox
alamb closed issue #57: URL: https://github.com/apache/arrow-datafusion/issues/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [arrow-datafusion] alamb closed issue #311: When joining two tables, get Error: Plan("Schema contains duplicate unqualified field name \'xxx\'")

2021-06-22 Thread GitBox
alamb closed issue #311: URL: https://github.com/apache/arrow-datafusion/issues/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow-datafusion] alamb merged pull request #55: Support qualified columns in queries

2021-06-22 Thread GitBox
alamb merged pull request #55: URL: https://github.com/apache/arrow-datafusion/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [arrow-datafusion] alamb commented on pull request #55: Support qualified columns in queries

2021-06-22 Thread GitBox
alamb commented on pull request #55: URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-866215121 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow-rs] alamb commented on a change in pull request #474: Doctest for GenericListArray.

2021-06-22 Thread GitBox
alamb commented on a change in pull request #474: URL: https://github.com/apache/arrow-rs/pull/474#discussion_r656455542 ## File path: arrow/src/array/array_list.rs ## @@ -50,6 +50,9 @@ impl OffsetSizeTrait for i64 { } } +/// Generic struct for a primitive Array +/// +/

[GitHub] [arrow] edponce commented on a change in pull request #10395: ARROW-12861: [C++][Compute] Add sign function kernels

2021-06-22 Thread GitBox
edponce commented on a change in pull request #10395: URL: https://github.com/apache/arrow/pull/10395#discussion_r656452847 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc ## @@ -149,7 +173,23 @@ template class TestUnaryArithmeticUnsigned : public TestUn

[GitHub] [arrow] edponce commented on a change in pull request #10395: ARROW-12861: [C++][Compute] Add sign function kernels

2021-06-22 Thread GitBox
edponce commented on a change in pull request #10395: URL: https://github.com/apache/arrow/pull/10395#discussion_r656451863 ## File path: cpp/src/arrow/compute/api_scalar.cc ## @@ -50,6 +50,11 @@ namespace compute { SCALAR_ARITHMETIC_UNARY(AbsoluteValue, "abs", "abs_checked")

[GitHub] [arrow] nealrichardson commented on a change in pull request #10507: ARROW-13022: [R] bindings for lubridate's year, isoyear, quarter, month, day, wday, yday, isoweek, hour, minute, and secon

2021-06-22 Thread GitBox
nealrichardson commented on a change in pull request #10507: URL: https://github.com/apache/arrow/pull/10507#discussion_r656451946 ## File path: r/tests/testthat/test-dplyr-lubridate.R ## @@ -0,0 +1,174 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [arrow] nealrichardson commented on a change in pull request #10507: ARROW-13022: [R] bindings for lubridate's year, isoyear, quarter, month, day, wday, yday, isoweek, hour, minute, and secon

2021-06-22 Thread GitBox
nealrichardson commented on a change in pull request #10507: URL: https://github.com/apache/arrow/pull/10507#discussion_r656451510 ## File path: r/tests/testthat/test-dplyr-lubridate.R ## @@ -0,0 +1,174 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [arrow] nealrichardson commented on a change in pull request #10507: ARROW-13022: [R] bindings for lubridate's year, isoyear, quarter, month, day, wday, yday, isoweek, hour, minute, and secon

2021-06-22 Thread GitBox
nealrichardson commented on a change in pull request #10507: URL: https://github.com/apache/arrow/pull/10507#discussion_r656451343 ## File path: r/tests/testthat/test-dplyr-lubridate.R ## @@ -0,0 +1,174 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [arrow] nealrichardson commented on a change in pull request #10507: ARROW-13022: [R] bindings for lubridate's year, isoyear, quarter, month, day, wday, yday, isoweek, hour, minute, and secon

2021-06-22 Thread GitBox
nealrichardson commented on a change in pull request #10507: URL: https://github.com/apache/arrow/pull/10507#discussion_r656449850 ## File path: r/R/expression.R ## @@ -29,8 +29,17 @@ # stringr spellings of those "str_length" = "utf8_length", "str_to_lower" = "utf8_low

[GitHub] [arrow] nealrichardson commented on a change in pull request #10507: ARROW-13022: [R] bindings for lubridate's year, isoyear, quarter, month, day, wday, yday, isoweek, hour, minute, and secon

2021-06-22 Thread GitBox
nealrichardson commented on a change in pull request #10507: URL: https://github.com/apache/arrow/pull/10507#discussion_r656449431 ## File path: r/R/dplyr-functions.R ## @@ -442,3 +442,74 @@ nse_funcs$strptime <- function(x, format = "%Y-%m-%d %H:%M:%S", tz = NULL, unit E

[GitHub] [arrow] nealrichardson commented on a change in pull request #10507: ARROW-13022: [R] bindings for lubridate's year, isoyear, quarter, month, day, wday, yday, isoweek, hour, minute, and secon

2021-06-22 Thread GitBox
nealrichardson commented on a change in pull request #10507: URL: https://github.com/apache/arrow/pull/10507#discussion_r656449141 ## File path: r/R/dplyr-functions.R ## @@ -442,3 +442,74 @@ nse_funcs$strptime <- function(x, format = "%Y-%m-%d %H:%M:%S", tz = NULL, unit E

[GitHub] [arrow] nealrichardson commented on a change in pull request #10507: ARROW-13022: [R] bindings for lubridate's year, isoyear, quarter, month, day, wday, yday, isoweek, hour, minute, and secon

2021-06-22 Thread GitBox
nealrichardson commented on a change in pull request #10507: URL: https://github.com/apache/arrow/pull/10507#discussion_r656448695 ## File path: r/R/dplyr-functions.R ## @@ -442,3 +442,74 @@ nse_funcs$strptime <- function(x, format = "%Y-%m-%d %H:%M:%S", tz = NULL, unit E

[GitHub] [arrow] nealrichardson commented on a change in pull request #10507: ARROW-13022: [R] bindings for lubridate's year, isoyear, quarter, month, day, wday, yday, isoweek, hour, minute, and secon

2021-06-22 Thread GitBox
nealrichardson commented on a change in pull request #10507: URL: https://github.com/apache/arrow/pull/10507#discussion_r656447630 ## File path: r/R/dplyr-functions.R ## @@ -442,3 +442,37 @@ nse_funcs$strptime <- function(x, format = "%Y-%m-%d %H:%M:%S", tz = NULL, unit E

[GitHub] [arrow-datafusion] alamb opened a new issue #600: Allow User Defined Aggregates to return multiple values / structs

2021-06-22 Thread GitBox
alamb opened a new issue #600: URL: https://github.com/apache/arrow-datafusion/issues/600 # Usecase I want to implement a user defined aggregate function that produces more than one column ( logical values) Specifically I am trying to implement the InfluxDB 'selector' functions `

[GitHub] [arrow] github-actions[bot] commented on pull request #10573: ARROW-10440: [C++][Dataset] Visit FileWriters before Finish

2021-06-22 Thread GitBox
github-actions[bot] commented on pull request #10573: URL: https://github.com/apache/arrow/pull/10573#issuecomment-866187741 https://issues.apache.org/jira/browse/ARROW-10440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] bkietz opened a new pull request #10573: ARROW-10440: [C++][Dataset] Visit FileWriters before Finish

2021-06-22 Thread GitBox
bkietz opened a new pull request #10573: URL: https://github.com/apache/arrow/pull/10573 This enables collection of paths written to during writing of a FileSystemDataset -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow-rs] b41sh commented on a change in pull request #490: Implement function slice for RecordBatch

2021-06-22 Thread GitBox
b41sh commented on a change in pull request #490: URL: https://github.com/apache/arrow-rs/pull/490#discussion_r656403180 ## File path: arrow/src/record_batch.rs ## @@ -244,6 +244,18 @@ impl RecordBatch { &self.columns[..] } +/// Return a new RecordBatch wher

[GitHub] [arrow-rs] b41sh commented on a change in pull request #490: Implement function slice for RecordBatch

2021-06-22 Thread GitBox
b41sh commented on a change in pull request #490: URL: https://github.com/apache/arrow-rs/pull/490#discussion_r656393219 ## File path: arrow/src/record_batch.rs ## @@ -244,6 +244,18 @@ impl RecordBatch { &self.columns[..] } +/// Return a new RecordBatch wher

[GitHub] [arrow-rs] nevi-me commented on a change in pull request #377: simplify interactions with arrow flight APIs

2021-06-22 Thread GitBox
nevi-me commented on a change in pull request #377: URL: https://github.com/apache/arrow-rs/pull/377#discussion_r654833725 ## File path: arrow-flight/src/utils.rs ## @@ -164,4 +73,40 @@ pub fn flight_data_to_arrow_batch( })? } -// TODO: add more explicit conversion

[GitHub] [arrow-rs] nevi-me commented on a change in pull request #490: Implement function slice for RecordBatch

2021-06-22 Thread GitBox
nevi-me commented on a change in pull request #490: URL: https://github.com/apache/arrow-rs/pull/490#discussion_r656390969 ## File path: arrow/src/record_batch.rs ## @@ -244,6 +244,18 @@ impl RecordBatch { &self.columns[..] } +/// Return a new RecordBatch wh

[GitHub] [arrow-rs] jorgecarleitao commented on a change in pull request #490: Implement function slice for RecordBatch

2021-06-22 Thread GitBox
jorgecarleitao commented on a change in pull request #490: URL: https://github.com/apache/arrow-rs/pull/490#discussion_r656382277 ## File path: arrow/src/record_batch.rs ## @@ -244,6 +244,18 @@ impl RecordBatch { &self.columns[..] } +/// Return a new RecordB

[GitHub] [arrow-rs] nevi-me opened a new pull request #491: [DRAFT] Minimal MapArray support

2021-06-22 Thread GitBox
nevi-me opened a new pull request #491: URL: https://github.com/apache/arrow-rs/pull/491 # Which issue does this PR close? Related #395 . # Rationale for this change To add support for the map array :) # What changes are included in this PR? This adds mini

[GitHub] [arrow-rs] b41sh opened a new pull request #490: Implement function slice for RecordBatch

2021-06-22 Thread GitBox
b41sh opened a new pull request #490: URL: https://github.com/apache/arrow-rs/pull/490 # Which issue does this PR close? Closes #460 # Rationale for this change `slice` can be used to handle part of `RecordBatch` # What changes are included in this P

[GitHub] [arrow] westonpace commented on pull request #10104: ARROW-12472: [Python] Properly convert paths to strings (using __fspath__)

2021-06-22 Thread GitBox
westonpace commented on pull request #10104: URL: https://github.com/apache/arrow/pull/10104#issuecomment-866122199 Yes. Patch releases are focused on regressions / major errors. 4.0.1 was created by cherry-picking select commits on top of 4.0.0 which did not include this fix. This chan

[GitHub] [arrow] kszucs commented on a change in pull request #10572: ARROW-6513: [CI] Rename conda requirements files to have txt extension instead of yml

2021-06-22 Thread GitBox
kszucs commented on a change in pull request #10572: URL: https://github.com/apache/arrow/pull/10572#discussion_r656363881 ## File path: .github/workflows/python.yml ## @@ -140,12 +140,6 @@ jobs: - name: Fetch Submodules and Tags shell: bash run: ci/scr

[GitHub] [arrow] github-actions[bot] commented on pull request #10572: ARROW-6513: [CI] Rename conda requirements files to have txt extension instead of yml

2021-06-22 Thread GitBox
github-actions[bot] commented on pull request #10572: URL: https://github.com/apache/arrow/pull/10572#issuecomment-866113411 https://issues.apache.org/jira/browse/ARROW-6513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] kszucs opened a new pull request #10572: ARROW-6513: [CI] Rename conda requirements files to have txt extension instead of yml

2021-06-22 Thread GitBox
kszucs opened a new pull request #10572: URL: https://github.com/apache/arrow/pull/10572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [arrow] kszucs closed pull request #10556: ARROW-12983: [C++][Python][R] Properly overflow to chunked array in Python-to-Arrow conversion

2021-06-22 Thread GitBox
kszucs closed pull request #10556: URL: https://github.com/apache/arrow/pull/10556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] kszucs commented on pull request #10556: ARROW-12983: [C++][Python][R] Properly overflow to chunked array in Python-to-Arrow conversion

2021-06-22 Thread GitBox
kszucs commented on pull request #10556: URL: https://github.com/apache/arrow/pull/10556#issuecomment-866103992 The build failures are unrelated, merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] kszucs closed pull request #10570: ARROW-13140: [C++/Python] Upgrade libthrift pin in the nightlies

2021-06-22 Thread GitBox
kszucs closed pull request #10570: URL: https://github.com/apache/arrow/pull/10570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

  1   2   3   >