Jimexist commented on pull request #622:
URL: https://github.com/apache/arrow-datafusion/pull/622#issuecomment-868956823
if we are okay with dup names then i guess just keeping the function name
would be enough
--
This is an automated message from the Apache Git Service.
To respond to th
Jimexist commented on pull request #622:
URL: https://github.com/apache/arrow-datafusion/pull/622#issuecomment-868956556
Postgres is totally okay with dup names in the projection phase:
```
[postgres] # select max(c1) over (), max(c1) over (), max(c1) over
(partition by c1) from t
Jimexist edited a comment on pull request #622:
URL: https://github.com/apache/arrow-datafusion/pull/622#issuecomment-868956435
> should we update physical column name as well for better readability in
the query output?
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/
Jimexist commented on pull request #622:
URL: https://github.com/apache/arrow-datafusion/pull/622#issuecomment-868956435
> should we update physical column name as well for better readability in
the query output?
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physica
Dandandan commented on a change in pull request #599:
URL: https://github.com/apache/arrow-datafusion/pull/599#discussion_r659125692
##
File path: .github/workflows/audit.yml
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributo
houqp commented on pull request #622:
URL: https://github.com/apache/arrow-datafusion/pull/622#issuecomment-868953367
should we update physical column name as well for better readability in the
query output?
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physical_pla
kou commented on pull request #10404:
URL: https://github.com/apache/arrow/pull/10404#issuecomment-868951528
Can we see the build error log without this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kou closed pull request #10305:
URL: https://github.com/apache/arrow/pull/10305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
kou commented on a change in pull request #10305:
URL: https://github.com/apache/arrow/pull/10305#discussion_r659122423
##
File path: matlab/src/feather_reader.cc
##
@@ -177,32 +182,32 @@ Status FeatherReader::Open(const std::string& filename,
*feather_reader = std::shared_p
Jimexist opened a new pull request #622:
URL: https://github.com/apache/arrow-datafusion/pull/622
# Which issue does this PR close?
Closes #621
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
Jimexist opened a new issue #621:
URL: https://github.com/apache/arrow-datafusion/issues/621
**Describe the bug**
given window functions on the same col with same function but different
partition by and order by, the schema is failing due to conflict.
**To Reproduce**
Steps
Jimexist commented on pull request #610:
URL: https://github.com/apache/arrow-datafusion/pull/610#issuecomment-868940370
> If we really want to make this backwards compatible, we could use `impl
Into` as the argument type, see #615.
thanks for the suggestion. unless it's a goal, i'd
edponce commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r659082281
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -454,6 +456,159 @@ struct PowerChecked {
}
};
+using RoundState = internal::O
emkornfield edited a comment on pull request #10603:
URL: https://github.com/apache/arrow/pull/10603#issuecomment-868881296
@zeroshade do you have thoughts here? Being able to pass in an external
schema is useful in some contexts.
Would it be workable to have the following logic:
emkornfield commented on pull request #10603:
URL: https://github.com/apache/arrow/pull/10603#issuecomment-868881296
@zeroshade do you have thoughts here? Being able to pass in an external
schema is useful in some contexts.
Would it be workable to have the following logic:
```
shollyman edited a comment on pull request #10603:
URL: https://github.com/apache/arrow/pull/10603#issuecomment-868867445
The issue seems to be the change of expectations. The internal/arrdata
writes schema messages, but validation also passes in an external schema (which
is being used fo
github-actions[bot] commented on pull request #10604:
URL: https://github.com/apache/arrow/pull/10604#issuecomment-868878483
https://issues.apache.org/jira/browse/ARROW-13190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
anthonylouisbsb commented on pull request #10604:
URL: https://github.com/apache/arrow/pull/10604#issuecomment-868878502
@augustoasilva, please, could you review the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
anthonylouisbsb opened a new pull request #10604:
URL: https://github.com/apache/arrow/pull/10604
The current behavior of the INITCAP function is to turn the first character
of each word uppercase and remains the other as is.
The desired behavior is to turn the first letter uppercase
Dandandan opened a new pull request #620:
URL: https://github.com/apache/arrow-datafusion/pull/620
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
shollyman commented on pull request #10603:
URL: https://github.com/apache/arrow/pull/10603#issuecomment-868867445
And now I try to work out arrow testing. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
github-actions[bot] commented on pull request #10603:
URL: https://github.com/apache/arrow/pull/10603#issuecomment-868866471
https://issues.apache.org/jira/browse/ARROW-13191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
shollyman opened a new pull request #10603:
URL: https://github.com/apache/arrow/pull/10603
This slightly changes the newReader to accept passed in schema as
I believe is the intent.
It also removes the existing behavior where the newReader uses a passed
in schema merely for com
ianmcook closed pull request #10563:
URL: https://github.com/apache/arrow/pull/10563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
westonpace commented on pull request #10602:
URL: https://github.com/apache/arrow/pull/10602#issuecomment-868823151
Ok, I think I got it this time. It turned out to be a little trickier.
AsyncGenerator was using AddCallback instead of Then and there are no
sequencing guarantees with AddC
github-actions[bot] commented on pull request #10593:
URL: https://github.com/apache/arrow/pull/10593#issuecomment-868820973
Revision: a0f18640e86ccd4f0ef4a55ece186dc614bc7559
Submitted crossbow builds: [ursacomputing/crossbow @
actions-511](https://github.com/ursacomputing/crossbow/
nealrichardson commented on pull request #10593:
URL: https://github.com/apache/arrow/pull/10593#issuecomment-868820557
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
nealrichardson commented on pull request #10404:
URL: https://github.com/apache/arrow/pull/10404#issuecomment-868820032
@kou @westonpace any objection to merging the R-only fix for this and
ticketing a C++ followup to do it right? Or can one of you push a fix to cmake
that does this the wa
lidavidm commented on a change in pull request #9368:
URL: https://github.com/apache/arrow/pull/9368#discussion_r658934729
##
File path: format/FlightSQL.proto
##
@@ -0,0 +1,337 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor licens
github-actions[bot] commented on pull request #10602:
URL: https://github.com/apache/arrow/pull/10602#issuecomment-868728119
https://issues.apache.org/jira/browse/ARROW-13173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
westonpace opened a new pull request #10602:
URL: https://github.com/apache/arrow/pull/10602
As @cyb70289 pointed out the test was dependent on timing and when running
on a slow CI machine it could lead to failure. I changed the test to use
condition variables instead of sleeps so that it
lidavidm edited a comment on pull request #10557:
URL: https://github.com/apache/arrow/pull/10557#issuecomment-868726123
Note there's some code here for fixed-width types that duplicates what's in
ARROW-9430/#10412. They should probably get unified.
--
This is an automated message from t
lidavidm commented on pull request #10412:
URL: https://github.com/apache/arrow/pull/10412#issuecomment-868726398
Note there's some code here for handling fixed-width types that now
duplicates what's in ARROW-13064/#10557. We should probably unify those at some
point (after one or the othe
lidavidm commented on pull request #10557:
URL: https://github.com/apache/arrow/pull/10557#issuecomment-868726123
Note there's some code here for fixed-width types that duplicates what's in
ARROW-9430. They should probably get unified.
--
This is an automated message from the Apache Git
kylepbit commented on a change in pull request #9368:
URL: https://github.com/apache/arrow/pull/9368#discussion_r658923471
##
File path: format/FlightSQL.proto
##
@@ -0,0 +1,337 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor licens
houqp commented on a change in pull request #619:
URL: https://github.com/apache/arrow-datafusion/pull/619#discussion_r658910893
##
File path: datafusion/src/optimizer/projection_push_down.rs
##
@@ -75,9 +78,12 @@ fn get_projected_schema(
//
// we discard non-existing
houqp commented on a change in pull request #619:
URL: https://github.com/apache/arrow-datafusion/pull/619#discussion_r658910893
##
File path: datafusion/src/optimizer/projection_push_down.rs
##
@@ -75,9 +78,12 @@ fn get_projected_schema(
//
// we discard non-existing
houqp commented on a change in pull request #619:
URL: https://github.com/apache/arrow-datafusion/pull/619#discussion_r658910893
##
File path: datafusion/src/optimizer/projection_push_down.rs
##
@@ -75,9 +78,12 @@ fn get_projected_schema(
//
// we discard non-existing
houqp commented on a change in pull request #619:
URL: https://github.com/apache/arrow-datafusion/pull/619#discussion_r658910526
##
File path: datafusion/src/optimizer/projection_push_down.rs
##
@@ -75,9 +78,12 @@ fn get_projected_schema(
//
// we discard non-existing
kylepbit commented on pull request #9368:
URL: https://github.com/apache/arrow/pull/9368#issuecomment-868694053
@lidavidm - that would be the goal. Am working to get this finalized,
restrictions are just on time that can be made available.
--
This is an automated message from the Apache
nevi-me closed issue #460:
URL: https://github.com/apache/arrow-rs/issues/460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@a
nevi-me merged pull request #490:
URL: https://github.com/apache/arrow-rs/pull/490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
anthonylouisbsb edited a comment on pull request #10195:
URL: https://github.com/apache/arrow/pull/10195#issuecomment-866789693
@jpedroantunes please, after @jvictorhuguenin applies the corrections,
could you review it, please?
--
This is an automated message from the Apache Git Service
thisisnic commented on pull request #10588:
URL: https://github.com/apache/arrow/pull/10588#issuecomment-868679514
> Meanwhile it looks like
[ARROW-13157](https://issues.apache.org/jira/browse/ARROW-13157) has a PR, so
if we wait a few days for that to get merged, then we can remove the sk
ianmcook commented on pull request #10588:
URL: https://github.com/apache/arrow/pull/10588#issuecomment-868670505
Meanwhile it looks like ARROW-13157 has a PR, so if we wait a few days for
that to get merged, then we can remove the skipped test in this PR before we
merge it.
--
This is
ianmcook commented on a change in pull request #10588:
URL: https://github.com/apache/arrow/pull/10588#discussion_r658876327
##
File path: r/tests/testthat/test-dplyr-string-functions.R
##
@@ -725,6 +725,29 @@ test_that("errors in strptime", {
)
})
+test_that("arrow_find_
thisisnic commented on pull request #10588:
URL: https://github.com/apache/arrow/pull/10588#issuecomment-868666882
Sounds like a plan!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
ianmcook commented on pull request #10588:
URL: https://github.com/apache/arrow/pull/10588#issuecomment-868666454
>So, is the plan to merge this as-is, and then look at creating bindings for
`str_locate` once the other tickets are implemented?
Yes, if that sounds 👍 to you
--
This
lidavidm commented on pull request #9368:
URL: https://github.com/apache/arrow/pull/9368#issuecomment-868657093
Thanks for picking this up again. Note the 5.0.0 timeline is soon-ish. It
looks like we are nearing consensus on most issues raised so it would be
helpful to see an updated docum
lidavidm commented on a change in pull request #9368:
URL: https://github.com/apache/arrow/pull/9368#discussion_r658861293
##
File path: format/FlightSQL.proto
##
@@ -0,0 +1,337 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor licens
thisisnic commented on pull request #10588:
URL: https://github.com/apache/arrow/pull/10588#issuecomment-868649192
@jonkeane @ianmcook I agree with what you both say here, that all makes
sense. So, is the plan to merge this as-is, and then look at creating bindings
for `str_locate` once t
alamb commented on issue #617:
URL:
https://github.com/apache/arrow-datafusion/issues/617#issuecomment-868645886
https://github.com/apache/arrow-datafusion/pull/619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb commented on pull request #619:
URL: https://github.com/apache/arrow-datafusion/pull/619#issuecomment-868645653
FYI @houqp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
alamb commented on a change in pull request #619:
URL: https://github.com/apache/arrow-datafusion/pull/619#discussion_r658863004
##
File path: datafusion/src/optimizer/projection_push_down.rs
##
@@ -75,9 +78,12 @@ fn get_projected_schema(
//
// we discard non-existing
alamb commented on a change in pull request #619:
URL: https://github.com/apache/arrow-datafusion/pull/619#discussion_r658862205
##
File path: datafusion/src/optimizer/projection_push_down.rs
##
@@ -75,9 +78,12 @@ fn get_projected_schema(
//
// we discard non-existing
alamb opened a new pull request #619:
URL: https://github.com/apache/arrow-datafusion/pull/619
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/617 but I am still
not sure if this is a bug or not (explained below)
# Rationale for this
jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658859592
##
File path: r/src/r_to_arrow.cpp
##
@@ -1089,6 +1096,7 @@ class RStructConverter : public
StructConverter {
auto fields = this->struct_type_->f
jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658857664
##
File path: r/tests/testthat/test-metadata.R
##
@@ -205,3 +205,47 @@ test_that("metadata of list elements (ARROW-10386)", {
expect_identical(attr(as
jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658854104
##
File path: r/tests/testthat/test-json.R
##
@@ -208,7 +208,7 @@ test_that("Can read json file with nested columns
(ARROW-5503)", {
expect_equal(str
alamb commented on issue #617:
URL:
https://github.com/apache/arrow-datafusion/issues/617#issuecomment-868611882
Here is a reproducer (in projection_push_down.rs) -- it can also be found on
https://github.com/alamb/arrow-datafusion/tree/alamb/repro_projection_pruning
```rust
jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658853111
##
File path: r/tests/testthat/test-Array.R
##
@@ -839,3 +840,23 @@ test_that("Array to C-interface", {
delete_arrow_schema(schema_ptr)
delete_arro
jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658853111
##
File path: r/tests/testthat/test-Array.R
##
@@ -839,3 +840,23 @@ test_that("Array to C-interface", {
delete_arrow_schema(schema_ptr)
delete_arro
jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658852266
##
File path: r/tests/testthat/latin1.R
##
@@ -35,12 +35,12 @@ expect_identical(Encoding(levels(df[[2]])), "latin1")
# Array
expect_identical(as.vector
jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658850721
##
File path: r/src/type_infer.cpp
##
@@ -133,8 +133,14 @@ static inline std::shared_ptr
InferArrowTypeFromDataFrame(
template <>
std::shared_ptr In
jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658849841
##
File path: r/R/metadata.R
##
@@ -56,7 +56,21 @@ apply_arrow_r_metadata <- function(x, r_metadata) {
if (is.data.frame(x)) {
if (length(nam
jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658849273
##
File path: r/src/array_to_vector.cpp
##
@@ -723,9 +723,13 @@ class Converter_Struct : public Converter {
auto colnames = arrow::r::to_r_strings(
jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658846244
##
File path: r/R/metadata.R
##
@@ -56,7 +56,21 @@ apply_arrow_r_metadata <- function(x, r_metadata) {
if (is.data.frame(x)) {
if (length(nam
ianmcook commented on a change in pull request #10563:
URL: https://github.com/apache/arrow/pull/10563#discussion_r658842787
##
File path: r/tests/testthat/test-dplyr.R
##
@@ -800,6 +808,21 @@ test_that("type checks with is_*()", {
)
})
+test_that("type checks on expressi
jonkeane commented on pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#issuecomment-868570390
@github-actions autotune
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sgilmore10 commented on a change in pull request #10305:
URL: https://github.com/apache/arrow/pull/10305#discussion_r658827138
##
File path: matlab/src/feather_reader.cc
##
@@ -177,32 +182,32 @@ Status FeatherReader::Open(const std::string& filename,
*feather_reader = std::s
sgilmore10 commented on a change in pull request #10305:
URL: https://github.com/apache/arrow/pull/10305#discussion_r658819952
##
File path: matlab/src/feather_reader.cc
##
@@ -52,11 +57,12 @@ mxArray* ReadNumericVariableData(const
std::shared_ptr& column) {
mxArray* variab
lidavidm commented on a change in pull request #10579:
URL: https://github.com/apache/arrow/pull/10579#discussion_r658801294
##
File path: cpp/src/arrow/array/builder_base.h
##
@@ -116,6 +116,10 @@ class ARROW_EXPORT ArrayBuilder {
/// This method is useful when appending nu
rok edited a comment on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868522762
> However, we don't need to know all of these in advance, right?
Indeed. Even the ones I listed above should be implemented just-in-time with
their respective kernels I
rok commented on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868522762
> However, we don't need to know all of these in advance, right?
Indeed. Even the ones I listed above should be implemented just-in-time with
their respective kernels IMO. So
sgilmore10 commented on a change in pull request #10305:
URL: https://github.com/apache/arrow/pull/10305#discussion_r658785123
##
File path: matlab/src/feather_reader.cc
##
@@ -177,32 +182,32 @@ Status FeatherReader::Open(const std::string& filename,
*feather_reader = std::s
sgilmore10 commented on a change in pull request #10305:
URL: https://github.com/apache/arrow/pull/10305#discussion_r658778342
##
File path: matlab/CMakeLists.txt
##
@@ -29,22 +30,51 @@ if(EXISTS "${CPP_CMAKE_MODULES}")
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CPP_CMAKE_
nastra commented on pull request #10600:
URL: https://github.com/apache/arrow/pull/10600#issuecomment-868511078
@emkornfield is this something that you could potentially review/commit?
thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the messa
ianmcook closed pull request #10559:
URL: https://github.com/apache/arrow/pull/10559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
lidavidm commented on a change in pull request #10544:
URL: https://github.com/apache/arrow/pull/10544#discussion_r658740181
##
File path: docs/source/cpp/compute.rst
##
@@ -312,6 +312,40 @@ precision of `divide` is at least the sum of precisions of
both operands with
enough
lidavidm commented on a change in pull request #10544:
URL: https://github.com/apache/arrow/pull/10544#discussion_r658740109
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -454,6 +462,200 @@ struct PowerChecked {
}
};
+struct Sin {
+ template
+
thisisnic edited a comment on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868468794
> > About the actual options in this PR: that seems like a good start, but I
don't think all those options would be needed in a single Options struct? For
example, the
lidavidm commented on a change in pull request #10544:
URL: https://github.com/apache/arrow/pull/10544#discussion_r658739906
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -454,6 +462,200 @@ struct PowerChecked {
}
};
+struct Sin {
+ template
+
lidavidm commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r658733636
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -454,6 +456,159 @@ struct PowerChecked {
}
};
+using RoundState = internal::
lidavidm commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r658733299
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -454,6 +456,159 @@ struct PowerChecked {
}
};
+using RoundState = internal::
thisisnic commented on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868468794
> > About the actual options in this PR: that seems like a good start, but I
don't think all those options would be needed in a single Options struct? For
example, the ambiguo
github-actions[bot] commented on pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#issuecomment-868467415
https://issues.apache.org/jira/browse/ARROW-13149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
jonkeane opened a new pull request #10601:
URL: https://github.com/apache/arrow/pull/10601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
rok commented on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868449124
> Pandas actually has a different method (the one you link is an attribute
that has been there for a long time, so but pandas added an additional method
so it could have arguments)
jorisvandenbossche commented on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868441918
> I was wondering about locale as well. Would it be a good idea to be able
to set an arbitrary locale in some cases? [Pandas appears not to offer this
option](https:/
pitrou commented on pull request #10583:
URL: https://github.com/apache/arrow/pull/10583#issuecomment-868429468
TODO: perhaps add Spaced tests and specialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
edponce commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r658690788
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -454,6 +456,159 @@ struct PowerChecked {
}
};
+using RoundState = internal::O
edponce commented on pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#issuecomment-868420891
@bkietz @jorisvandenbossche Need feedback on this PR. Specifically, the
rounding options provided and kernel implementations.
--
This is an automated message from the Apache G
rok commented on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868419790
> Again, I'd like input from others on this (I am not experienced in this
and may be missing something!), but my initial thoughts are that if we do
choose to extract the day of week
thisisnic commented on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868407701
> > * `fiscal_start` - this is an argument to `quarter` which indicates the
starting month of a fiscal year - I think this would be useful to implement
>
> Is this just
boaz-codota commented on pull request #342:
URL: https://github.com/apache/arrow-datafusion/pull/342#issuecomment-868400691
@alamb tried to refactor the code now, noticed that there is no `get_bit`
equivalent of `set_bit` in `BooleanBufferBuilder` and calling `finish` to make
receive a `Bu
rok edited a comment on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868398341
Hey @thisisnic! Thanks for the input :).
> * `fiscal_start` - this is an argument to `quarter` which indicates the
starting month of a fiscal year - I think this would
rok commented on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868398341
Hey @thisisnic! Thanks for the input :).
> * `fiscal_start` - this is an argument to `quarter` which indicates the
starting month of a fiscal year - I think this would be usef
yjshen edited a comment on issue #616:
URL:
https://github.com/apache/arrow-datafusion/issues/616#issuecomment-868364661
To make a digression, after searching on the Internet for a period of time,
I found no suitable Rust HDFS client library that can be used directly for my
use case. ☹️
yjshen commented on issue #616:
URL:
https://github.com/apache/arrow-datafusion/issues/616#issuecomment-868364661
To make a digression, after searching on the Internet for a period of time,
I found no suitable Rust HDFS client library that can be used directly for my
use case. ☹️
- [h
thisisnic edited a comment on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868358466
> Is this missing an option we will need in the near future? Should we
remove something.
> @jorisvandenbossche @thisisnic
Thanks for this! I've taken a look at
1 - 100 of 107 matches
Mail list logo
