liyafan82 commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r705017358
##
File path: java/ffi/src/main/java/org/apache/arrow/ffi/NativeUtil.java
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
github-actions[bot] commented on pull request #4:
URL: https://github.com/apache/arrow/pull/4#issuecomment-915807714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on pull request #4:
URL: https://github.com/apache/arrow/pull/4#issuecomment-915807386
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes).
Could you ope
zhjwpku opened a new pull request #4:
URL: https://github.com/apache/arrow/pull/4
Signed-off-by: Junwang Zhao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
liyafan82 commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r705007376
##
File path: java/ffi/src/main/java/org/apache/arrow/ffi/ArrowArray.java
##
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
liyafan82 commented on pull request #11069:
URL: https://github.com/apache/arrow/pull/11069#issuecomment-915796571
> The `code-coverage` profile is not enabled by default, so there should be
no performance impact. When enabled, the impact seems negligeable except for
the algorithm module w
roee88 commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r704991017
##
File path: java/ffi/src/main/java/org/apache/arrow/ffi/FFIReferenceManager.java
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation
houqp edited a comment on pull request #873:
URL: https://github.com/apache/arrow-datafusion/pull/873#issuecomment-915768704
@kszucs I took a quick look at the
`physical_plan::sort_preserving_merge::tests::test_async` error, it is caused
by the arrow-rs upgrade. I haven't had the time to t
houqp commented on pull request #873:
URL: https://github.com/apache/arrow-datafusion/pull/873#issuecomment-915768704
@kszucs I took a quick look at the
`physical_plan::sort_preserving_merge::tests::test_async` error, it is caused
by the arrow-rs upgrade. I haven't had the time to root cau
thisisnic commented on a change in pull request #67:
URL: https://github.com/apache/arrow-cookbook/pull/67#discussion_r704956492
##
File path: r/content/specify_data_types_and_schemas.Rmd
##
@@ -0,0 +1,205 @@
+# Defining Data Types
+
+As discussed in previous chapters, Arrow au
edponce closed pull request #11082:
URL: https://github.com/apache/arrow/pull/11082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubsc
westonpace edited a comment on pull request #11084:
URL: https://github.com/apache/arrow/pull/11084#issuecomment-915681730
I've moved this back to ready for review. AsyncTaskGroup is similar but not
the same as the TaskGroups. SerialTaskGroup and ThreadedTaskGroup take care of
scheduling
aocsa commented on a change in pull request #11019:
URL: https://github.com/apache/arrow/pull/11019#discussion_r704911579
##
File path: cpp/src/arrow/compute/kernels/vector_topk_benchmark.cc
##
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+//
aocsa commented on a change in pull request #11019:
URL: https://github.com/apache/arrow/pull/11019#discussion_r704909876
##
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##
@@ -1778,6 +1799,697 @@ class SortIndicesMetaFunction : public MetaFunction {
}
};
+// -
github-actions[bot] commented on pull request #3:
URL: https://github.com/apache/arrow/pull/3#issuecomment-915714980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
edponce opened a new pull request #3:
URL: https://github.com/apache/arrow/pull/3
This PR adds explicit output values to the sign function for the unsigned
integer kernel. This makes the kernel more readable and consistent with the
other sign kernels.
--
This is an automated mes
houqp commented on pull request #981:
URL: https://github.com/apache/arrow-datafusion/pull/981#issuecomment-915691867
@mmuru looks like you pulled in unrelated commits after the merge, you may
want to do a fresh checkout of current master and cherry-pick your own commits
to fix that.
westonpace commented on pull request #11084:
URL: https://github.com/apache/arrow/pull/11084#issuecomment-915681730
I've moved this back to ready for review. AsyncTaskGroup is similar but not
the same as the TaskGroups. SerialTaskGroup and ThreadedTaskGroup take care of
scheduling the ta
westonpace commented on a change in pull request #11084:
URL: https://github.com/apache/arrow/pull/11084#discussion_r704875386
##
File path: cpp/src/arrow/util/async_util.h
##
@@ -0,0 +1,132 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
westonpace commented on a change in pull request #11084:
URL: https://github.com/apache/arrow/pull/11084#discussion_r704875302
##
File path: cpp/src/arrow/util/async_util_test.cc
##
@@ -0,0 +1,150 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more con
westonpace commented on a change in pull request #11084:
URL: https://github.com/apache/arrow/pull/11084#discussion_r704875172
##
File path: cpp/src/arrow/util/async_util_test.cc
##
@@ -0,0 +1,150 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more con
edponce commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r704874792
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -852,24 +854,232 @@ struct LogbChecked {
}
};
+struct RoundUtil {
+ template
edponce commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r704874792
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -852,24 +854,232 @@ struct LogbChecked {
}
};
+struct RoundUtil {
+ template
kou commented on pull request #2:
URL: https://github.com/apache/arrow/pull/2#issuecomment-915670466
I confirmed that this works well on
https://github.com/kou/arrow/pull/10#issuecomment-915661313 :
https://github.com/kou/arrow/runs/3550837829?check_suite_focus=true#step:6:80
-
github-actions[bot] commented on pull request #2:
URL: https://github.com/apache/arrow/pull/2#issuecomment-915669766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kou opened a new pull request #2:
URL: https://github.com/apache/arrow/pull/2
This is a follow-up of #10571 / ARROW-8459 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
westonpace edited a comment on pull request #11106:
URL: https://github.com/apache/arrow/pull/11106#issuecomment-915663195
CC @jorisvandenbossche
Also, I noticed another potential con: we do mention UUID in the pyarrow
extension type examples. If uuid was accepted that might weaken
westonpace commented on pull request #11106:
URL: https://github.com/apache/arrow/pull/11106#issuecomment-915663195
CC @jorisvandenbossche
Also, I noticed another potential con: we do mention UUID in the pyarrow
extension type examples. If uuid was accepted that might weaken that e
kou commented on pull request #10913:
URL: https://github.com/apache/arrow/pull/10913#issuecomment-915649272
@github-actions autotune
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kou commented on a change in pull request #10913:
URL: https://github.com/apache/arrow/pull/10913#discussion_r704756414
##
File path: .github/workflows/cpp.yml
##
@@ -60,11 +60,15 @@ jobs:
image:
- conda-cpp
- ubuntu-cpp-sanitizer
+ - ubu
aucahuasi commented on pull request #11075:
URL: https://github.com/apache/arrow/pull/11075#issuecomment-915641892
> Note the TestNonexistentTimezone test is also failing on Linux.
Thanks, fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message
jonkeane commented on a change in pull request #11109:
URL: https://github.com/apache/arrow/pull/11109#discussion_r704812737
##
File path: r/tools/nixlibs.R
##
@@ -423,13 +423,14 @@ cmake_version <- function(cmd = "cmake") {
)
}
-turn_off_thirdparty_features <- function(e
ursabot edited a comment on pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#issuecomment-915497363
Benchmark runs are scheduled for baseline =
e9eeff1c92976467a0ee57c43097d5f1eb704da3 and contender =
9dd8b6abc34fee2e0eb069556d80e34270cca334. Results will be available a
ursabot edited a comment on pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#issuecomment-915497363
Benchmark runs are scheduled for baseline =
e9eeff1c92976467a0ee57c43097d5f1eb704da3 and contender =
9dd8b6abc34fee2e0eb069556d80e34270cca334. Results will be available a
jacques-n closed pull request #10979:
URL: https://github.com/apache/arrow/pull/10979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
jacques-n commented on pull request #10979:
URL: https://github.com/apache/arrow/pull/10979#issuecomment-915527257
Closing this in favor of collaborating on a cross-project approach at
[substrait.io](https://substrait.io)
--
This is an automated message from the Apache Git Service.
To re
github-actions[bot] commented on pull request #1:
URL: https://github.com/apache/arrow/pull/1#issuecomment-915507539
https://issues.apache.org/jira/browse/ARROW-13882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
lidavidm opened a new pull request #1:
URL: https://github.com/apache/arrow/pull/1
This adds support for non-nested types to both, except for
MonthDayNanoInterval (which is not really sortable). hash_min_max additionally
lacks binary/string-like types as they require a different ap
ursabot edited a comment on pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#issuecomment-915497363
Benchmark runs are scheduled for baseline =
e9eeff1c92976467a0ee57c43097d5f1eb704da3 and contender =
9dd8b6abc34fee2e0eb069556d80e34270cca334. Results will be available a
mmuru commented on a change in pull request #981:
URL: https://github.com/apache/arrow-datafusion/pull/981#discussion_r704700902
##
File path: python/src/context.rs
##
@@ -95,6 +95,29 @@ impl ExecutionContext {
))
}
+fn register_memtable(
Review comment:
ursabot commented on pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#issuecomment-915497363
Benchmark runs are scheduled for baseline =
e9eeff1c92976467a0ee57c43097d5f1eb704da3 and contender =
9dd8b6abc34fee2e0eb069556d80e34270cca334. Results will be available as each
pitrou commented on pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#issuecomment-915496852
@ursabot please benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
wmalpica commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r704684918
##
File path: cpp/src/arrow/util/value_parsing.h
##
@@ -273,6 +273,36 @@ inline bool ParseUnsigned(const char* s, size_t length,
uint64_t* out) {
#unde
wmalpica commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r704684765
##
File path: cpp/src/arrow/util/value_parsing.h
##
@@ -281,6 +311,20 @@ struct StringToUnsignedIntConverterMixin {
if (ARROW_PREDICT_FALSE(length =
pitrou commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r704684606
##
File path: java/ffi/src/main/java/org/apache/arrow/ffi/ArrowSchema.java
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
wmalpica commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r704684555
##
File path: cpp/src/arrow/util/value_parsing.h
##
@@ -281,6 +311,20 @@ struct StringToUnsignedIntConverterMixin {
if (ARROW_PREDICT_FALSE(length =
roee88 commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r704682436
##
File path: java/ffi/src/main/java/org/apache/arrow/ffi/ArrowSchema.java
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
roee88 commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r704666905
##
File path:
java/ffi/src/main/java/org/apache/arrow/ffi/FFIDictionaryProvider.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundatio
pitrou commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r704665838
##
File path: java/ffi/README.md
##
@@ -0,0 +1,48 @@
+
+
+# Java FFI (C Data Interface)
+
+## Setup Build Environment
+
+install:
+ - Java 8 or later
+ - M
pitrou commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r704665277
##
File path: java/ffi/src/main/java/org/apache/arrow/ffi/ArrowSchema.java
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
edponce commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r704651704
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -852,24 +854,232 @@ struct LogbChecked {
}
};
+struct RoundUtil {
+ template
roee88 commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r704647631
##
File path: java/ffi/README.md
##
@@ -0,0 +1,48 @@
+
+
+# Java FFI (C Data Interface)
+
+## Setup Build Environment
+
+install:
+ - Java 8 or later
+ - M
roee88 commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r704643127
##
File path: java/ffi/src/main/java/org/apache/arrow/ffi/ArrowSchema.java
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
roee88 commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r704642213
##
File path: java/ffi/src/main/java/org/apache/arrow/ffi/ArrowArray.java
##
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
roee88 commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r704639986
##
File path: java/ffi/pom.xml
##
@@ -0,0 +1,75 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
laurentgo commented on pull request #11069:
URL: https://github.com/apache/arrow/pull/11069#issuecomment-915410567
The `code-coverage` profile is not enabled by default, so there should be no
performance impact. When enabled, the impact seems negligeable except for the
algorithm module whi
zeroshade commented on a change in pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#discussion_r704607978
##
File path: go/arrow/cdata/cdata_testframework.c
##
@@ -0,0 +1,88 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review comment:
zeroshade commented on a change in pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#discussion_r704607831
##
File path: go/arrow/cdata/utils.h
##
@@ -0,0 +1,56 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
zeroshade edited a comment on pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#issuecomment-915407136
@pitrou I'm updating the comments on the exported Import functions in
`interface.go` so that they explicitly state that `ArrowSchemaRelease` will be
called on the passe
zeroshade commented on pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#issuecomment-915407136
@pitrou I'm updating the comments on the exported Import functions in
`interface.go` so that they explicitly state that `ArrowSchemaRelease` will be
called on the passed in sc
rdettai edited a comment on pull request #965:
URL: https://github.com/apache/arrow-datafusion/pull/965#issuecomment-911505188
TODO:
- [x] move the `statistics()` function to the `ExecutionPlan` trait and
provide naive implementations
- [x] re-implement the aggregate_statistics CBO
matthewmturner commented on a change in pull request #745:
URL: https://github.com/apache/arrow-rs/pull/745#discussion_r704605006
##
File path: arrow/src/compute/kernels/length.rs
##
@@ -243,18 +242,13 @@ mod tests {
/// Tests with an offset
#[test]
fn length_off
bjchambers commented on issue #744:
URL: https://github.com/apache/arrow-rs/issues/744#issuecomment-915404299
Hmm... probably a copy-paste error when updating/adding the tests. Could you
comment on the PR and I'll update/resolve when I get a chance?
--
This is an automated message from t
matthewmturner commented on issue #744:
URL: https://github.com/apache/arrow-rs/issues/744#issuecomment-915402900
@bjchambers out of curiousity - do you know why the `length_offsets` test
uses `bit_length` function instead of `length`?
--
This is an automated message from the Apache Git
pitrou commented on a change in pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#discussion_r704593234
##
File path: go/arrow/cdata/test/test_export_to_cgo.py
##
@@ -0,0 +1,95 @@
+#!/usr/bin/env python3
+#
+# Licensed to the Apache Software Foundation (ASF)
jonkeane merged pull request #0:
URL: https://github.com/apache/arrow/pull/0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
pitrou commented on a change in pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#discussion_r704593234
##
File path: go/arrow/cdata/test/test_export_to_cgo.py
##
@@ -0,0 +1,95 @@
+#!/usr/bin/env python3
+#
+# Licensed to the Apache Software Foundation (ASF)
pitrou commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r704585027
##
File path: cpp/src/arrow/util/value_parsing.h
##
@@ -273,6 +273,36 @@ inline bool ParseUnsigned(const char* s, size_t length,
uint64_t* out) {
#undef
matthewmturner commented on issue #744:
URL: https://github.com/apache/arrow-rs/issues/744#issuecomment-915392925
@bjchambers ah missed the linked pull. thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
zeroshade commented on a change in pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#discussion_r704589908
##
File path: go/arrow/cdata/test/test_export_to_cgo.py
##
@@ -0,0 +1,95 @@
+#!/usr/bin/env python3
+#
+# Licensed to the Apache Software Foundation (AS
bjchambers commented on issue #744:
URL: https://github.com/apache/arrow-rs/issues/744#issuecomment-915392040
@matthewmturner I think it should be addressed by #745.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
zeroshade commented on a change in pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#discussion_r704588182
##
File path: go/arrow/cdata/cdata_testframework.c
##
@@ -0,0 +1,88 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review comment:
matthewmturner commented on issue #744:
URL: https://github.com/apache/arrow-rs/issues/744#issuecomment-915390378
@bjchambers i can try looking into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
zeroshade commented on a change in pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#discussion_r704581505
##
File path: go/arrow/cdata/utils.h
##
@@ -0,0 +1,56 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
pitrou commented on a change in pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#discussion_r704570974
##
File path: go/arrow/cdata/test/test_export_to_cgo.py
##
@@ -0,0 +1,95 @@
+#!/usr/bin/env python3
+#
+# Licensed to the Apache Software Foundation (ASF)
pitrou commented on pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#issuecomment-915370012
@zeroshade I pushed some changes to improve the Python tests and try to fix
some allocation issues. Can you double-check them?
--
This is an automated message from the Apache G
pitrou commented on a change in pull request #11037:
URL: https://github.com/apache/arrow/pull/11037#discussion_r704471195
##
File path: go/arrow/cdata/utils.h
##
@@ -0,0 +1,56 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
jorgecarleitao edited a comment on pull request #749:
URL: https://github.com/apache/arrow-rs/pull/749#issuecomment-915363789
No, checks pass, it should be good to go.
Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to th
jorgecarleitao commented on pull request #749:
URL: https://github.com/apache/arrow-rs/pull/749#issuecomment-915363789
No, checks pass, it should be good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
matthewmturner commented on pull request #749:
URL: https://github.com/apache/arrow-rs/pull/749#issuecomment-915362968
The errors were actually just because i needed to add the submodules.
I see you already approved - do you still need me to check if `bitmap.len`
is used anywhere?
wmalpica commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r704552613
##
File path: cpp/src/arrow/util/value_parsing.h
##
@@ -273,6 +273,96 @@ inline bool ParseUnsigned(const char* s, size_t length,
uint64_t* out) {
#unde
wmalpica commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r704552175
##
File path: cpp/src/arrow/util/value_parsing.h
##
@@ -281,6 +371,19 @@ struct StringToUnsignedIntConverterMixin {
if (ARROW_PREDICT_FALSE(length =
wmalpica commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r704551941
##
File path: cpp/src/arrow/util/value_parsing.h
##
@@ -336,6 +439,21 @@ struct StringToSignedIntConverterMixin {
return false;
}
}
wmalpica commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r704551768
##
File path: cpp/src/arrow/util/value_parsing.h
##
@@ -281,6 +371,19 @@ struct StringToUnsignedIntConverterMixin {
if (ARROW_PREDICT_FALSE(length =
wmalpica commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r704548956
##
File path: cpp/src/arrow/util/value_parsing_test.cc
##
@@ -138,6 +146,14 @@ TEST(StringConversion, ToUInt8) {
AssertConversionFails("-");
Assert
jorgecarleitao commented on pull request #749:
URL: https://github.com/apache/arrow-rs/pull/749#issuecomment-915354496
Looks a good start. I think that every `bitmap.len()` out there needs to be
divided by 8 now, since this is a backward-incompatible change.
--
This is an automated messa
lidavidm commented on a change in pull request #10913:
URL: https://github.com/apache/arrow/pull/10913#discussion_r704542364
##
File path: cpp/src/skyhook/protocol/skyhook_protocol.h
##
@@ -0,0 +1,116 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
nealrichardson closed pull request #11079:
URL: https://github.com/apache/arrow/pull/11079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-
github-actions[bot] commented on pull request #11109:
URL: https://github.com/apache/arrow/pull/11109#issuecomment-915343562
https://issues.apache.org/jira/browse/ARROW-11885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
edponce commented on a change in pull request #10349:
URL: https://github.com/apache/arrow/pull/10349#discussion_r704536187
##
File path: cpp/src/arrow/compute/api_scalar.cc
##
@@ -175,6 +219,42 @@
ElementWiseAggregateOptions::ElementWiseAggregateOptions(bool skip_nulls)
nealrichardson opened a new pull request #11109:
URL: https://github.com/apache/arrow/pull/11109
This was made trivial to do by ARROW-12981. Also includes ARROW-13586.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
matthewmturner commented on pull request #749:
URL: https://github.com/apache/arrow-rs/pull/749#issuecomment-915342047
@jorgecarleitao FYI. I did what i thought was the simplest update by simply
multiplying bytes by 8 and updating `Bitmap` tests.
when running all `arrow-rs` tests
matthewmturner opened a new pull request #749:
URL: https://github.com/apache/arrow-rs/pull/749
# Which issue does this PR close?
Closes #730
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing
rdettai edited a comment on pull request #965:
URL: https://github.com/apache/arrow-datafusion/pull/965#issuecomment-911505188
TODO:
- [x] move the `statistics()` function to the `ExecutionPlan` trait and
provide naive implementations
- [x] re-implement the aggregate_statistics CBO
ianmcook commented on a change in pull request #11079:
URL: https://github.com/apache/arrow/pull/11079#discussion_r704517649
##
File path: r/R/compute.R
##
@@ -120,15 +120,15 @@ max.ArrowDatum <- function(..., na.rm = FALSE) {
scalar_aggregate("min_max", ..., na.rm = na.rm)$
lidavidm commented on a change in pull request #11068:
URL: https://github.com/apache/arrow/pull/11068#discussion_r704512287
##
File path: cpp/src/arrow/compute/exec/aggregate_node.cc
##
@@ -225,6 +236,23 @@ class ScalarAggregateNode : public ExecNode {
Future<> finished()
felipeblazing commented on a change in pull request #11068:
URL: https://github.com/apache/arrow/pull/11068#discussion_r704502506
##
File path: cpp/src/arrow/compute/exec/aggregate_node.cc
##
@@ -225,6 +236,23 @@ class ScalarAggregateNode : public ExecNode {
Future<> finis
rdettai edited a comment on pull request #965:
URL: https://github.com/apache/arrow-datafusion/pull/965#issuecomment-911505188
TODO:
- [x] move the `statistics()` function to the `ExecutionPlan` trait and
provide naive implementations
- [x] re-implement the aggregate_statistics CBO
rdettai edited a comment on pull request #965:
URL: https://github.com/apache/arrow-datafusion/pull/965#issuecomment-911505188
TODO:
- [x] move the `statistics()` function to the `ExecutionPlan` trait and
provide naive implementations
- [x] re-implement the aggregate_statistics CBO
JayjeetAtGithub commented on a change in pull request #10913:
URL: https://github.com/apache/arrow/pull/10913#discussion_r704482173
##
File path: ci/scripts/integration_skyhook.sh
##
@@ -0,0 +1,133 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) u
1 - 100 of 143 matches
Mail list logo
