[GitHub] [arrow-datafusion] houqp commented on a change in pull request #68: Experimenting with arrow2

2021-09-10 Thread GitBox
houqp commented on a change in pull request #68: URL: https://github.com/apache/arrow-datafusion/pull/68#discussion_r706567452 ## File path: datafusion/src/scalar.rs ## @@ -64,7 +70,10 @@ pub enum ScalarValue { /// large binary LargeBinary(Option>), /// list of n

[GitHub] [arrow-datafusion] jorgecarleitao commented on a change in pull request #68: Experimenting with arrow2

2021-09-10 Thread GitBox
jorgecarleitao commented on a change in pull request #68: URL: https://github.com/apache/arrow-datafusion/pull/68#discussion_r706566011 ## File path: datafusion/src/scalar.rs ## @@ -64,7 +70,10 @@ pub enum ScalarValue { /// large binary LargeBinary(Option>), ///

[GitHub] [arrow-datafusion] jorgecarleitao commented on a change in pull request #68: Experimenting with arrow2

2021-09-10 Thread GitBox
jorgecarleitao commented on a change in pull request #68: URL: https://github.com/apache/arrow-datafusion/pull/68#discussion_r706565686 ## File path: datafusion/src/scalar.rs ## @@ -64,7 +70,10 @@ pub enum ScalarValue { /// large binary LargeBinary(Option>), ///

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #68: Experimenting with arrow2

2021-09-10 Thread GitBox
houqp commented on a change in pull request #68: URL: https://github.com/apache/arrow-datafusion/pull/68#discussion_r706565176 ## File path: datafusion/src/scalar.rs ## @@ -64,7 +70,10 @@ pub enum ScalarValue { /// large binary LargeBinary(Option>), /// list of n

[GitHub] [arrow-rs] codecov-commenter commented on pull request #769: Fix riscv64 target_arch

2021-09-10 Thread GitBox
codecov-commenter commented on pull request #769: URL: https://github.com/apache/arrow-rs/pull/769#issuecomment-917341933 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [arrow] github-actions[bot] commented on pull request #11136: ARROW-13685: [C++] Cannot write dataset to S3FileSystem if bucket already exists

2021-09-10 Thread GitBox
github-actions[bot] commented on pull request #11136: URL: https://github.com/apache/arrow/pull/11136#issuecomment-917330704 https://issues.apache.org/jira/browse/ARROW-13685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] westonpace opened a new pull request #11136: ARROW-13685: [C++] Cannot write dataset to S3FileSystem if bucket already exists

2021-09-10 Thread GitBox
westonpace opened a new pull request #11136: URL: https://github.com/apache/arrow/pull/11136 I still need to add a regression test. I've been able to test by configuring my server with minio client. I think it'd probably be easiest to create a crossbow test for this situation. Current s

[GitHub] [arrow] github-actions[bot] commented on pull request #11135: ARROW-13976: [C++] Add path to libjvm.so in ARM CPU

2021-09-10 Thread GitBox
github-actions[bot] commented on pull request #11135: URL: https://github.com/apache/arrow/pull/11135#issuecomment-917327013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] wuzhuoming opened a new pull request #11135: ARROW-13976: [C++] Add path to libjvm.so in ARM CPU

2021-09-10 Thread GitBox
wuzhuoming opened a new pull request #11135: URL: https://github.com/apache/arrow/pull/11135 resolve issue ARROW-13976, add path in hdfs_internal.cc to find libjvm.so in ARM CPU. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [arrow-rs] matthewmturner commented on issue #696: Add documentation examples for `regexp_match` kernels

2021-09-10 Thread GitBox
matthewmturner commented on issue #696: URL: https://github.com/apache/arrow-rs/issues/696#issuecomment-917324963 @seddonm1 sure, will give it a shot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706543733 ## File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc ## @@ -50,13 +50,14 @@ class BaseTestStringKernels : public ::testing::Test { Check

[GitHub] [arrow] fatCatGm opened a new issue #11134: unsupported system page size

2021-09-10 Thread GitBox
fatCatGm opened a new issue #11134: URL: https://github.com/apache/arrow/issues/11134 enviroment:arm64 aarch64 python: anaconda2 python3.7 when i use this command(import pyarrow ) and i get a error(unsupported system page size) How to solve this problem? ![image](https://us

[GitHub] [arrow-rs] seddonm1 commented on issue #696: Add documentation examples for `regexp_match` kernels

2021-09-10 Thread GitBox
seddonm1 commented on issue #696: URL: https://github.com/apache/arrow-rs/issues/696#issuecomment-917309048 @alamb Sorry I didn't do this one. It does appear there may be a defect. @matthewmturner are you able to reproduce the behaviour to verify that it behaves differently to Postgr

[GitHub] [arrow] paleolimbot commented on pull request #11133: ARROW-13626: [R] Bindings for log base b

2021-09-10 Thread GitBox
paleolimbot commented on pull request #11133: URL: https://github.com/apache/arrow/pull/11133#issuecomment-917306807 Fixed the base with length != 1 issue, although I think my error message could be better since base with length != 1 *is* supported, just not as a non-expression. Reprex sum

[GitHub] [arrow-cookbook] westonpace commented on a change in pull request #70: Adding anonymous flag to s3

2021-09-10 Thread GitBox
westonpace commented on a change in pull request #70: URL: https://github.com/apache/arrow-cookbook/pull/70#discussion_r706521842 ## File path: python/source/io.rst ## @@ -419,7 +422,8 @@ by ``month`` using .. testcode:: -dataset = ds.dataset("s3://ursa-labs-taxi-data/

[GitHub] [arrow-cookbook] westonpace merged pull request #70: Adding anonymous flag to s3

2021-09-10 Thread GitBox
westonpace merged pull request #70: URL: https://github.com/apache/arrow-cookbook/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [arrow] augustoasilva commented on a change in pull request #11054: ARROW-13830: [C++][Gandiva] Implement CHR Hive functions on Gandiva

2021-09-10 Thread GitBox
augustoasilva commented on a change in pull request #11054: URL: https://github.com/apache/arrow/pull/11054#discussion_r706509013 ## File path: cpp/src/gandiva/precompiled/string_ops_test.cc ## @@ -53,6 +53,37 @@ TEST(TestStringOps, TestAscii) { EXPECT_EQ(ascii_utf8("999", 3

[GitHub] [arrow] augustoasilva commented on a change in pull request #11054: ARROW-13830: [C++][Gandiva] Implement CHR Hive functions on Gandiva

2021-09-10 Thread GitBox
augustoasilva commented on a change in pull request #11054: URL: https://github.com/apache/arrow/pull/11054#discussion_r706508948 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -1361,6 +1361,26 @@ gdv_int32 ascii_utf8(const char* data, gdv_int32 data_len) { r

[GitHub] [arrow] lidavidm commented on a change in pull request #11130: ARROW-12087: [C++] Allow sorting durations, timestamps with timezones

2021-09-10 Thread GitBox
lidavidm commented on a change in pull request #11130: URL: https://github.com/apache/arrow/pull/11130#discussion_r706503907 ## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ## @@ -651,6 +651,11 @@ void AddSortingKernels(VectorKernel base, VectorFunction* func) {

[GitHub] [arrow] westonpace commented on a change in pull request #11130: ARROW-12087: [C++] Allow sorting durations, timestamps with timezones

2021-09-10 Thread GitBox
westonpace commented on a change in pull request #11130: URL: https://github.com/apache/arrow/pull/11130#discussion_r706492186 ## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ## @@ -651,6 +651,11 @@ void AddSortingKernels(VectorKernel base, VectorFunction* func) {

[GitHub] [arrow] lidavidm commented on a change in pull request #11130: ARROW-12087: [C++] Allow sorting durations, timestamps with timezones

2021-09-10 Thread GitBox
lidavidm commented on a change in pull request #11130: URL: https://github.com/apache/arrow/pull/11130#discussion_r706487944 ## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ## @@ -651,6 +651,11 @@ void AddSortingKernels(VectorKernel base, VectorFunction* func) {

[GitHub] [arrow-rs] felixonmars opened a new pull request #769: Fix riscv64 target_arch

2021-09-10 Thread GitBox
felixonmars opened a new pull request #769: URL: https://github.com/apache/arrow-rs/pull/769 This should be defined for riscv64 instead, as `riscv` doesn't match it. I have no idea for riscv32 though. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [arrow] westonpace commented on a change in pull request #11130: ARROW-12087: [C++] Allow sorting durations, timestamps with timezones

2021-09-10 Thread GitBox
westonpace commented on a change in pull request #11130: URL: https://github.com/apache/arrow/pull/11130#discussion_r706477733 ## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ## @@ -651,6 +651,11 @@ void AddSortingKernels(VectorKernel base, VectorFunction* func) {

[GitHub] [arrow] lidavidm commented on a change in pull request #11129: ARROW-13966: [C++] Support decimals in comparisons

2021-09-10 Thread GitBox
lidavidm commented on a change in pull request #11129: URL: https://github.com/apache/arrow/pull/11129#discussion_r706476234 ## File path: docs/source/cpp/compute.rst ## @@ -542,16 +542,17 @@ cast to the :ref:`common numeric type ` before comparison), or two inputs of Binary-

[GitHub] [arrow] westonpace commented on a change in pull request #11129: ARROW-13966: [C++] Support decimals in comparisons

2021-09-10 Thread GitBox
westonpace commented on a change in pull request #11129: URL: https://github.com/apache/arrow/pull/11129#discussion_r706469558 ## File path: docs/source/cpp/compute.rst ## @@ -542,16 +542,17 @@ cast to the :ref:`common numeric type ` before comparison), or two inputs of Binar

[GitHub] [arrow-rs] matthewmturner commented on pull request #750: Added PartialEq to RecordBatch

2021-09-10 Thread GitBox
matthewmturner commented on pull request #750: URL: https://github.com/apache/arrow-rs/pull/750#issuecomment-917203268 @alamb @nevi-me i rebased and CI clears now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706461838 ## File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc ## @@ -557,6 +558,36 @@ TYPED_TEST(TestStringKernels, Utf8Title) { R"([null, "",

[GitHub] [arrow] nealrichardson commented on a change in pull request #11133: ARROW-13626: [R] Bindings for log base b

2021-09-10 Thread GitBox
nealrichardson commented on a change in pull request #11133: URL: https://github.com/apache/arrow/pull/11133#discussion_r706460650 ## File path: r/R/dplyr-functions.R ## @@ -694,6 +694,10 @@ nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start = getOption }

[GitHub] [arrow] aocsa commented on pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
aocsa commented on pull request #11132: URL: https://github.com/apache/arrow/pull/11132#issuecomment-917192327 Thanks @edponce, @lidavidm I updated with minor fixes addressing your comments. I think it is ready for merging. -- This is an automated message from the Apache Git Se

[GitHub] [arrow] aocsa commented on a change in pull request #11019: ARROW-1565: [C++] Implement TopK/BottomK

2021-09-10 Thread GitBox
aocsa commented on a change in pull request #11019: URL: https://github.com/apache/arrow/pull/11019#discussion_r706452208 ## File path: cpp/src/arrow/compute/api_vector.h ## @@ -252,6 +292,21 @@ ARROW_EXPORT Result> NthToIndices(const Array& values, int64_t n,

[GitHub] [arrow-cookbook] westonpace commented on a change in pull request #67: [R] - Schemas recipes

2021-09-10 Thread GitBox
westonpace commented on a change in pull request #67: URL: https://github.com/apache/arrow-cookbook/pull/67#discussion_r706449434 ## File path: r/content/specify_data_types_and_schemas.Rmd ## @@ -0,0 +1,279 @@ +# Defining Data Types + +As discussed in previous chapters, Arrow a

[GitHub] [arrow] aocsa commented on a change in pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
aocsa commented on a change in pull request #11132: URL: https://github.com/apache/arrow/pull/11132#discussion_r706449722 ## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ## @@ -1855,19 +1854,25 @@ class ArraySelecter : public TypeVisitor { ctx_(ctx),

[GitHub] [arrow] aocsa commented on a change in pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
aocsa commented on a change in pull request #11132: URL: https://github.com/apache/arrow/pull/11132#discussion_r706448942 ## File path: cpp/src/arrow/compute/kernels/select_k_test.cc ## @@ -42,7 +42,7 @@ using internal::checked_pointer_cast; namespace compute { template -c

[GitHub] [arrow] paleolimbot commented on pull request #11133: ARROW-13626: [R] Bindings for log base b

2021-09-10 Thread GitBox
paleolimbot commented on pull request #11133: URL: https://github.com/apache/arrow/pull/11133#issuecomment-917180825 Sure! I should be 'paleolimbot' in ASF Jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706440025 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -2357,6 +2584,79 @@ void AddSplit(FunctionRegistry* registry) { #endif } +template

[GitHub] [arrow] paleolimbot commented on a change in pull request #11133: ARROW-13626: [R] Bindings for log base b

2021-09-10 Thread GitBox
paleolimbot commented on a change in pull request #11133: URL: https://github.com/apache/arrow/pull/11133#discussion_r706440071 ## File path: r/tests/testthat/test-dplyr.R ## @@ -1035,10 +1035,20 @@ test_that("log functions", { df ) - expect_error( -nse_funcs$log

[GitHub] [arrow] paleolimbot commented on a change in pull request #11133: ARROW-13626: [R] Bindings for log base b

2021-09-10 Thread GitBox
paleolimbot commented on a change in pull request #11133: URL: https://github.com/apache/arrow/pull/11133#discussion_r706438885 ## File path: r/R/dplyr-functions.R ## @@ -694,6 +694,10 @@ nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start = getOption } ns

[GitHub] [arrow-rs] codecov-commenter commented on pull request #750: Added PartialEq to RecordBatch

2021-09-10 Thread GitBox
codecov-commenter commented on pull request #750: URL: https://github.com/apache/arrow-rs/pull/750#issuecomment-917173391 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/750?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706434526 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -2357,6 +2584,79 @@ void AddSplit(FunctionRegistry* registry) { #endif } +template

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706434101 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -2357,6 +2584,79 @@ void AddSplit(FunctionRegistry* registry) { #endif } +template

[GitHub] [arrow] nealrichardson commented on a change in pull request #11133: ARROW-13626: [R] Bindings for log base b

2021-09-10 Thread GitBox
nealrichardson commented on a change in pull request #11133: URL: https://github.com/apache/arrow/pull/11133#discussion_r706430015 ## File path: r/R/dplyr-functions.R ## @@ -694,6 +694,10 @@ nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start = getOption }

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706358970 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -2357,6 +2584,79 @@ void AddSplit(FunctionRegistry* registry) { #endif } +template

[GitHub] [arrow-datafusion] houqp commented on pull request #965: Move CBOs and Statistics to physical plan

2021-09-10 Thread GitBox
houqp commented on pull request #965: URL: https://github.com/apache/arrow-datafusion/pull/965#issuecomment-917160508 @rdettai there are some merge conflicts that need to be resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow-datafusion] houqp commented on pull request #950: ObjectStore API to read from remote storage systems

2021-09-10 Thread GitBox
houqp commented on pull request #950: URL: https://github.com/apache/arrow-datafusion/pull/950#issuecomment-917154017 Amazing work on laying out a solid foundation for IO abstraction in datafusion @yjshen ! -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [arrow] edponce edited a comment on pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
edponce edited a comment on pull request #11132: URL: https://github.com/apache/arrow/pull/11132#issuecomment-917145967 LGTM. Thanks for working on this @aocsa! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] edponce commented on pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
edponce commented on pull request #11132: URL: https://github.com/apache/arrow/pull/11132#issuecomment-917145967 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [arrow-datafusion] andygrove commented on pull request #965: Move CBOs and Statistics to physical plan

2021-09-10 Thread GitBox
andygrove commented on pull request #965: URL: https://github.com/apache/arrow-datafusion/pull/965#issuecomment-917139349 I am happy to see CBO moving to the physical plan. I don't have time to do a meaningful review on this PR unfortunately but I would be happy to help with testing/debugg

[GitHub] [arrow] edponce commented on a change in pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11132: URL: https://github.com/apache/arrow/pull/11132#discussion_r706401092 ## File path: cpp/src/arrow/compute/kernels/select_k_test.cc ## @@ -42,7 +42,7 @@ using internal::checked_pointer_cast; namespace compute { template

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #965: Move CBOs and Statistics to physical plan

2021-09-10 Thread GitBox
alamb commented on a change in pull request #965: URL: https://github.com/apache/arrow-datafusion/pull/965#discussion_r706399612 ## File path: datafusion/src/physical_plan/parquet.rs ## @@ -390,6 +387,10 @@ impl ExecutionPlan for ParquetExec { fn metrics(&self) -> Option {

[GitHub] [arrow] lidavidm commented on a change in pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
lidavidm commented on a change in pull request #11132: URL: https://github.com/apache/arrow/pull/11132#discussion_r706393975 ## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ## @@ -2344,22 +2343,10 @@ class SelectKUnstableMetaFunction : public MetaFunction { }

[GitHub] [arrow] edponce commented on a change in pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11132: URL: https://github.com/apache/arrow/pull/11132#discussion_r706375290 ## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ## @@ -1855,19 +1854,25 @@ class ArraySelecter : public TypeVisitor { ctx_(ctx),

[GitHub] [arrow-datafusion] yjshen commented on pull request #950: ObjectStore API to read from remote storage systems

2021-09-10 Thread GitBox
yjshen commented on pull request #950: URL: https://github.com/apache/arrow-datafusion/pull/950#issuecomment-917119367 Thanks again for all the guidance and help @houqp @rdettai @alamb 🎉 . -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] n3world commented on a change in pull request #10790: ARROW-12673: [C++] Add callback to handle incorrect column counts

2021-09-10 Thread GitBox
n3world commented on a change in pull request #10790: URL: https://github.com/apache/arrow/pull/10790#discussion_r706383355 ## File path: cpp/src/arrow/csv/parser.cc ## @@ -324,9 +324,29 @@ class BlockParserImpl { if (*(end - 1) == '\r') { --end; }

[GitHub] [arrow] lidavidm commented on a change in pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
lidavidm commented on a change in pull request #11132: URL: https://github.com/apache/arrow/pull/11132#discussion_r706371043 ## File path: cpp/src/arrow/compute/kernels/select_k_test.cc ## @@ -63,14 +63,9 @@ Result> SelectK(const Datum& values, int64_t k) { } } -template

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #971: Improve operator display

2021-09-10 Thread GitBox
alamb commented on a change in pull request #971: URL: https://github.com/apache/arrow-datafusion/pull/971#discussion_r706364143 ## File path: datafusion/src/sql/planner.rs ## @@ -2343,8 +2347,8 @@ mod tests { GROUP BY first_name HAVING M

[GitHub] [arrow-rs] alamb merged pull request #768: Cherry pick Use latest nightly in CI to Fix CI for SIMD to active_release

2021-09-10 Thread GitBox
alamb merged pull request #768: URL: https://github.com/apache/arrow-rs/pull/768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr..

[GitHub] [arrow-rs] alamb closed pull request #765: test change to trigger CI

2021-09-10 Thread GitBox
alamb closed pull request #765: URL: https://github.com/apache/arrow-rs/pull/765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr..

[GitHub] [arrow] github-actions[bot] commented on pull request #11133: ARROW-13626: [R] Bindings for log base b

2021-09-10 Thread GitBox
github-actions[bot] commented on pull request #11133: URL: https://github.com/apache/arrow/pull/11133#issuecomment-917091125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] paleolimbot opened a new pull request #11133: ARROW-13626: [R] Bindings for log base b

2021-09-10 Thread GitBox
paleolimbot opened a new pull request #11133: URL: https://github.com/apache/arrow/pull/11133 Implements `log(x, base = (something other than 2, e, or 10))`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [arrow-datafusion] alamb commented on pull request #910: Avro Table Provider

2021-09-10 Thread GitBox
alamb commented on pull request #910: URL: https://github.com/apache/arrow-datafusion/pull/910#issuecomment-917090793 > If no decision is made here, we could defer the clippy changes until they land on stable We have included the clippy change related to naming on master under the a

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #910: Avro Table Provider

2021-09-10 Thread GitBox
alamb commented on a change in pull request #910: URL: https://github.com/apache/arrow-datafusion/pull/910#discussion_r706361582 ## File path: datafusion/src/physical_plan/mod.rs ## @@ -570,6 +570,7 @@ pub trait Accumulator: Send + Sync + Debug { pub mod aggregates; pub mod a

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706358970 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -2357,6 +2584,79 @@ void AddSplit(FunctionRegistry* registry) { #endif } +template

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706358970 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -2357,6 +2584,79 @@ void AddSplit(FunctionRegistry* registry) { #endif } +template

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706358970 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -2357,6 +2584,79 @@ void AddSplit(FunctionRegistry* registry) { #endif } +template

[GitHub] [arrow-cookbook] drabastomek commented on a change in pull request #70: Adding anonymous flag to s3

2021-09-10 Thread GitBox
drabastomek commented on a change in pull request #70: URL: https://github.com/apache/arrow-cookbook/pull/70#discussion_r706358042 ## File path: python/source/io.rst ## @@ -419,7 +422,8 @@ by ``month`` using .. testcode:: -dataset = ds.dataset("s3://ursa-labs-taxi-data

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #910: Avro Table Provider

2021-09-10 Thread GitBox
alamb commented on a change in pull request #910: URL: https://github.com/apache/arrow-datafusion/pull/910#discussion_r706354917 ## File path: datafusion/src/avro_to_arrow/mod.rs ## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706354519 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -2357,6 +2584,79 @@ void AddSplit(FunctionRegistry* registry) { #endif } +template

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706353661 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -417,6 +419,231 @@ struct StringTransformExecWithState } }; +struct StringBinaryT

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706352758 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -417,6 +419,231 @@ struct StringTransformExecWithState } }; +struct StringBinaryT

[GitHub] [arrow-datafusion] rdettai commented on issue #904: Optimize `count(col)` using table statistics

2021-09-10 Thread GitBox
rdettai commented on issue #904: URL: https://github.com/apache/arrow-datafusion/issues/904#issuecomment-917073935 Exactly! You can already take a try at it from my PR. But you would take the risk that if it does not get merged the work has to be done again on the `OptimizerRule` version

[GitHub] [arrow-rs] alamb opened a new pull request #768: Cherry pick Use latest nightly in CI to Fix CI for SIMD to active_release

2021-09-10 Thread GitBox
alamb opened a new pull request #768: URL: https://github.com/apache/arrow-rs/pull/768 Automatic cherry-pick of 2f78c7a * Originally appeared in https://github.com/apache/arrow-rs/pull/767: Use latest nightly in CI to Fix CI for SIMD -- This is an automated message from the Apach

[GitHub] [arrow-rs] alamb merged pull request #767: Use latest nightly in CI to Fix CI for SIMD

2021-09-10 Thread GitBox
alamb merged pull request #767: URL: https://github.com/apache/arrow-rs/pull/767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr..

[GitHub] [arrow-rs] alamb closed issue #766: Rust / Test SIMD Ci test failing when compiling using packed_simd

2021-09-10 Thread GitBox
alamb closed issue #766: URL: https://github.com/apache/arrow-rs/issues/766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arr

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706345457 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -417,6 +419,231 @@ struct StringTransformExecWithState } }; +struct StringBinaryT

[GitHub] [arrow-rs] matthewmturner commented on issue #208: flight_data_from_arrow_batch sends too much data

2021-09-10 Thread GitBox
matthewmturner commented on issue #208: URL: https://github.com/apache/arrow-rs/issues/208#issuecomment-917069278 @alamb I think im restating the obvious and what has already been said, but i want to make sure i understand whats happening so i made a small sample. ``` use arrow::a

[GitHub] [arrow-datafusion] alamb closed issue #616: Add support for reading distributed datasets

2021-09-10 Thread GitBox
alamb closed issue #616: URL: https://github.com/apache/arrow-datafusion/issues/616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [arrow-datafusion] alamb merged pull request #950: ObjectStore API to read from remote storage systems

2021-09-10 Thread GitBox
alamb merged pull request #950: URL: https://github.com/apache/arrow-datafusion/pull/950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-un

[GitHub] [arrow-datafusion] alamb commented on pull request #950: ObjectStore API to read from remote storage systems

2021-09-10 Thread GitBox
alamb commented on pull request #950: URL: https://github.com/apache/arrow-datafusion/pull/950#issuecomment-917065741 We have resolved the python CI failure on master so I am going to merge this PR in as is. Thanks again @yjshen -- This is an automated message from the Apache Git Servic

[GitHub] [arrow-datafusion] alamb commented on pull request #950: ObjectStore API to read from remote storage systems

2021-09-10 Thread GitBox
alamb commented on pull request #950: URL: https://github.com/apache/arrow-datafusion/pull/950#issuecomment-917062432 > @alamb What's your opinion on the current list_file and list_dir API? I think it looks good 👍 -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow-rs] alamb commented on pull request #767: Use latest nightly in CI to Fix CI for SIMD

2021-09-10 Thread GitBox
alamb commented on pull request #767: URL: https://github.com/apache/arrow-rs/pull/767#issuecomment-917053852 FYI @nevi-me and @matthewmturner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow-rs] codecov-commenter commented on pull request #767: Use latest nightly in CI to Fix CI for SIMD

2021-09-10 Thread GitBox
codecov-commenter commented on pull request #767: URL: https://github.com/apache/arrow-rs/pull/767#issuecomment-917053692 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [arrow] aocsa commented on pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
aocsa commented on pull request #11132: URL: https://github.com/apache/arrow/pull/11132#issuecomment-917053129 Thanks @edponce, I addressed your feedback comments. Let me know if anything else needs to be taken care of to merge these minor updates. cc @lidavidm -- This is an automate

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706327671 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -417,6 +419,231 @@ struct StringTransformExecWithState } }; +struct StringBinaryT

[GitHub] [arrow] github-actions[bot] commented on pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
github-actions[bot] commented on pull request #11132: URL: https://github.com/apache/arrow/pull/11132#issuecomment-917050628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] aocsa opened a new pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

2021-09-10 Thread GitBox
aocsa opened a new pull request #11132: URL: https://github.com/apache/arrow/pull/11132 There are some follow-up reviews for topK/bottomK kernel (ARROW-1565) that were requested after PR was closed. This issue is to resolve them. -- This is an automated message from the Apache Gi

[GitHub] [arrow] edponce commented on a change in pull request #11023: ARROW-12712: [C++] String repeat kernel

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11023: URL: https://github.com/apache/arrow/pull/11023#discussion_r706327065 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -417,6 +419,231 @@ struct StringTransformExecWithState } }; +struct StringBinaryT

[GitHub] [arrow] edponce commented on pull request #10349: ARROW-12744: [C++][Compute] Add rounding kernel

2021-09-10 Thread GitBox
edponce commented on pull request #10349: URL: https://github.com/apache/arrow/pull/10349#issuecomment-917048763 Are there any additional comments/reviews? cc @pitrou @bkietz @jorisvandenbossche -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [arrow] aocsa commented on a change in pull request #11019: ARROW-1565: [C++] Implement TopK/BottomK

2021-09-10 Thread GitBox
aocsa commented on a change in pull request #11019: URL: https://github.com/apache/arrow/pull/11019#discussion_r706325596 ## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ## @@ -1778,6 +1798,621 @@ class SortIndicesMetaFunction : public MetaFunction { } }; +// -

[GitHub] [arrow] edponce commented on a change in pull request #11019: ARROW-1565: [C++] Implement TopK/BottomK

2021-09-10 Thread GitBox
edponce commented on a change in pull request #11019: URL: https://github.com/apache/arrow/pull/11019#discussion_r706323155 ## File path: cpp/src/arrow/compute/api_vector.h ## @@ -252,6 +292,21 @@ ARROW_EXPORT Result> NthToIndices(const Array& values, int64_t n,

[GitHub] [arrow-rs] jorgecarleitao opened a new pull request #767: Fixed CI for SIMD

2021-09-10 Thread GitBox
jorgecarleitao opened a new pull request #767: URL: https://github.com/apache/arrow-rs/pull/767 Close #766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [arrow-rs] alamb commented on issue #766: Rust / Test SIMD Ci test failing when compiling using packed_simd

2021-09-10 Thread GitBox
alamb commented on issue #766: URL: https://github.com/apache/arrow-rs/issues/766#issuecomment-917035082 Seems like it is the same as https://github.com/rust-lang/packed_simd/issues/330 (linked to the one you linked @jorgecarleitao ) -- thanks for the pointer -- This is an automated mes

[GitHub] [arrow-rs] codecov-commenter commented on pull request #765: test change to trigger CI

2021-09-10 Thread GitBox
codecov-commenter commented on pull request #765: URL: https://github.com/apache/arrow-rs/pull/765#issuecomment-917034966 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/765?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [arrow-cookbook] thisisnic opened a new pull request #71: Use as.data.frame instead of dplyr::collect

2021-09-10 Thread GitBox
thisisnic opened a new pull request #71: URL: https://github.com/apache/arrow-cookbook/pull/71 As per #40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [arrow-rs] jorgecarleitao commented on issue #766: Rust / Test SIMD Ci test failing when compiling using packed_simd

2021-09-10 Thread GitBox
jorgecarleitao commented on issue #766: URL: https://github.com/apache/arrow-rs/issues/766#issuecomment-917032594 sorry for the noise; this is actually another one(!) I will need to investigate when I get a computer (if someone else does not beat me to it ^_^) -- This is an automated mes

[GitHub] [arrow-rs] jorgecarleitao commented on issue #766: Rust / Test SIMD Ci test failing when compiling using packed_simd

2021-09-10 Thread GitBox
jorgecarleitao commented on issue #766: URL: https://github.com/apache/arrow-rs/issues/766#issuecomment-917030133 I do not have a dev env with me here, freeze nightly to `nightly-2021-08-30` and relax the version to `0.3` as in here: https://github.com/jorgecarleitao/arrow2/pull/364/files.

[GitHub] [arrow-rs] alamb commented on pull request #750: Added PartialEq to RecordBatch

2021-09-10 Thread GitBox
alamb commented on pull request #750: URL: https://github.com/apache/arrow-rs/pull/750#issuecomment-917025311 Filed https://github.com/apache/arrow-rs/pull/765 to track packed simd failure -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow-rs] alamb merged pull request #764: Update versions and readme for 5.4.0 release

2021-09-10 Thread GitBox
alamb merged pull request #764: URL: https://github.com/apache/arrow-rs/pull/764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr..

[GitHub] [arrow-rs] alamb opened a new issue #766: Rust / Test SIMD Ci test failing when compiling using packed_simd

2021-09-10 Thread GitBox
alamb opened a new issue #766: URL: https://github.com/apache/arrow-rs/issues/766 **Describe the bug** Rust / Test SIMD Ci test began failing on active_release (and I suspect that it would fail on master as well) @nevi-me suggests https://github.com/apache/arrow-rs/pull/750#issu

[GitHub] [arrow] aocsa commented on a change in pull request #11019: ARROW-1565: [C++] Implement TopK/BottomK

2021-09-10 Thread GitBox
aocsa commented on a change in pull request #11019: URL: https://github.com/apache/arrow/pull/11019#discussion_r706303388 ## File path: cpp/src/arrow/compute/kernels/select_k_test.cc ## @@ -0,0 +1,736 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] aocsa commented on a change in pull request #11019: ARROW-1565: [C++] Implement TopK/BottomK

2021-09-10 Thread GitBox
aocsa commented on a change in pull request #11019: URL: https://github.com/apache/arrow/pull/11019#discussion_r706302093 ## File path: cpp/src/arrow/compute/kernels/select_k_test.cc ## @@ -0,0 +1,736 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

  1   2   >