[GitHub] [arrow] kou closed pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
kou closed pull request #11297: URL: https://github.com/apache/arrow/pull/11297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow] kou commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
kou commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932866383 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [arrow] kou closed pull request #11275: ARROW-14178: [C++] Boost download location has moved

2021-10-02 Thread GitBox
kou closed pull request #11275: URL: https://github.com/apache/arrow/pull/11275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow] github-actions[bot] commented on pull request #11300: ARROW-14207: [C++] Add missing dependencies for bundled Boost targets

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11300: URL: https://github.com/apache/arrow/pull/11300#issuecomment-932860041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] kou opened a new pull request #11300: ARROW-14207: [C++] Add missing dependencies for bundled Boost targets

2021-10-02 Thread GitBox
kou opened a new pull request #11300: URL: https://github.com/apache/arrow/pull/11300 They are needed for building libarrow_bundled_dependencies.a. We may build libarrow_bundled_dependencies.a before bundled Boost targets are built without them. -- This is an automated message from th

[GitHub] [arrow] github-actions[bot] commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932857660 Revision: 0076497a914705ff8033af155385f5b983fba40b Submitted crossbow builds: [ursacomputing/crossbow @ actions-877](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] kou commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
kou commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932857585 @github-actions crossbow submit debian-* ubuntu-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [arrow] github-actions[bot] commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932851210 Revision: 0076497a914705ff8033af155385f5b983fba40b Submitted crossbow builds: [ursacomputing/crossbow @ actions-876](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] kou commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
kou commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932851147 @github-actions crossbow submit debian-*-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] coryan commented on a change in pull request #11268: ARROW-8147: [C++] add GCS library to ThirdpartyToolchain

2021-10-02 Thread GitBox
coryan commented on a change in pull request #11268: URL: https://github.com/apache/arrow/pull/11268#discussion_r720744306 ## File path: cpp/cmake_modules/ThirdpartyToolchain.cmake ## @@ -3470,6 +3498,203 @@ if(ARROW_WITH_GRPC) endif() endif() +# -

[GitHub] [arrow] coryan commented on a change in pull request #11268: ARROW-8147: [C++] add GCS library to ThirdpartyToolchain

2021-10-02 Thread GitBox
coryan commented on a change in pull request #11268: URL: https://github.com/apache/arrow/pull/11268#discussion_r720744303 ## File path: cpp/cmake_modules/ThirdpartyToolchain.cmake ## @@ -3470,6 +3498,199 @@ if(ARROW_WITH_GRPC) endif() endif() +# -

[GitHub] [arrow-datafusion] novemberkilo commented on issue #958: Add support for parsing timestamps from CSV files

2021-10-02 Thread GitBox
novemberkilo commented on issue #958: URL: https://github.com/apache/arrow-datafusion/issues/958#issuecomment-932829960 I would like to pick this up. Please assign to me as appropriate // @alamb -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [arrow] kou closed pull request #11295: ARROW-14180: [Packaging] Add support for AlmaLinux 8

2021-10-02 Thread GitBox
kou closed pull request #11295: URL: https://github.com/apache/arrow/pull/11295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow] kou commented on pull request #11295: ARROW-14180: [Packaging] Add support for AlmaLinux 8

2021-10-02 Thread GitBox
kou commented on pull request #11295: URL: https://github.com/apache/arrow/pull/11295#issuecomment-932824414 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [arrow] github-actions[bot] commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932823108 Revision: 3c1290174bd6c70803c8acf658fb936ca5d1a981 Submitted crossbow builds: [ursacomputing/crossbow @ actions-875](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] kou commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
kou commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932823003 @github-actions crossbow submit debian-* ubuntu-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [arrow] aucahuasi commented on a change in pull request #11257: ARROW-14035: [C++][Python][R] Implement count distinct kernel

2021-10-02 Thread GitBox
aucahuasi commented on a change in pull request #11257: URL: https://github.com/apache/arrow/pull/11257#discussion_r720728325 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -121,6 +122,168 @@ Result> CountInit(KernelContext*, static_cast(*args.opti

[GitHub] [arrow] JayjeetAtGithub commented on a change in pull request #10913: ARROW-13607: [C++] Add Skyhook to Arrow

2021-10-02 Thread GitBox
JayjeetAtGithub commented on a change in pull request #10913: URL: https://github.com/apache/arrow/pull/10913#discussion_r720727019 ## File path: cpp/src/skyhook/client/file_skyhook.h ## @@ -0,0 +1,100 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

[GitHub] [arrow] github-actions[bot] commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932815272 Revision: a85831848137aa0d03d91eb205298ae5d113499a Submitted crossbow builds: [ursacomputing/crossbow @ actions-874](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] kou commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
kou commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932815146 @github-actions crossbow submit debian-* ubuntu-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [arrow-datafusion] pjmore commented on pull request #1066: WIP: Extended Tokomak optimizer

2021-10-02 Thread GitBox
pjmore commented on pull request #1066: URL: https://github.com/apache/arrow-datafusion/pull/1066#issuecomment-932813749 @alamb Sounds good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [arrow] github-actions[bot] commented on pull request #11295: ARROW-14180: [Packaging] Add support for AlmaLinux 8

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11295: URL: https://github.com/apache/arrow/pull/11295#issuecomment-932812975 Revision: 60f6e8080d40059a48e8ec3fde556bddc8f676a3 Submitted crossbow builds: [ursacomputing/crossbow @ actions-873](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] kou commented on pull request #11295: ARROW-14180: [Packaging] Add support for AlmaLinux 8

2021-10-02 Thread GitBox
kou commented on pull request #11295: URL: https://github.com/apache/arrow/pull/11295#issuecomment-932812881 @github-actions crossbow submit almalinux-*-arm64 centos-*-arm64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] kou commented on a change in pull request #11268: ARROW-8147: [C++] add GCS library to ThirdpartyToolchain

2021-10-02 Thread GitBox
kou commented on a change in pull request #11268: URL: https://github.com/apache/arrow/pull/11268#discussion_r720719413 ## File path: cpp/cmake_modules/ThirdpartyToolchain.cmake ## @@ -3470,6 +3498,203 @@ if(ARROW_WITH_GRPC) endif() endif() +#

[GitHub] [arrow] kou commented on pull request #11298: ARROW-14205: [C++] Add unicode normalization to scalar string

2021-10-02 Thread GitBox
kou commented on pull request #11298: URL: https://github.com/apache/arrow/pull/11298#issuecomment-932805055 @kevingurney Could you confirm the MATLAB test failure? https://github.com/apache/arrow/pull/11298/checks?check_run_id=3776114858#step:7:9 It seems that MATLAB's license issue

[GitHub] [arrow] github-actions[bot] commented on pull request #11299: ARROW-14206: [Go][CI] Fix build on s390x and ARM

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11299: URL: https://github.com/apache/arrow/pull/11299#issuecomment-932802063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] github-actions[bot] commented on pull request #11295: ARROW-14180: [Packaging] Add support for AlmaLinux 8

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11295: URL: https://github.com/apache/arrow/pull/11295#issuecomment-932801099 Revision: 8107b68ec1e668114920ce10260dfeb22b2a2d49 Submitted crossbow builds: [ursacomputing/crossbow @ actions-872](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] kou commented on pull request #11295: ARROW-14180: [Packaging] Add support for AlmaLinux 8

2021-10-02 Thread GitBox
kou commented on pull request #11295: URL: https://github.com/apache/arrow/pull/11295#issuecomment-932800951 @github-actions crossbow submit almalinux-* centos-* amazon-linux-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] edponce commented on pull request #11298: ARROW-14205: [C++]Add unicode normalization to scalar string

2021-10-02 Thread GitBox
edponce commented on pull request #11298: URL: https://github.com/apache/arrow/pull/11298#issuecomment-932800313 Kernels and tests that make use of `utf8proc.h` need to be guarded with `#ifdef ARROW_WITH_UTF8PROC`. I suggest that you move the normalization kernels alongside the other UTF8

[GitHub] [arrow] edponce commented on a change in pull request #11298: ARROW-14205: [C++]Add unicode normalization to scalar string

2021-10-02 Thread GitBox
edponce commented on a change in pull request #11298: URL: https://github.com/apache/arrow/pull/11298#discussion_r720712933 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -592,6 +592,70 @@ struct Utf8ReverseTransform : public StringTransformBase { template

[GitHub] [arrow] edponce commented on a change in pull request #11298: ARROW-14205: [C++]Add unicode normalization to scalar string

2021-10-02 Thread GitBox
edponce commented on a change in pull request #11298: URL: https://github.com/apache/arrow/pull/11298#discussion_r720712341 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -4299,6 +4390,10 @@ void RegisterScalarStringAscii(FunctionRegistry* registry) {

[GitHub] [arrow] edponce commented on a change in pull request #11298: ARROW-14205: [C++]Add unicode normalization to scalar string

2021-10-02 Thread GitBox
edponce commented on a change in pull request #11298: URL: https://github.com/apache/arrow/pull/11298#discussion_r720711626 ## File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc ## @@ -449,6 +449,30 @@ TYPED_TEST(TestStringKernels, Utf8Reverse) { ASSERT_TRUE(res

[GitHub] [arrow] edponce commented on a change in pull request #11233: ARROW-13879: [C++] Mixed support for binary types in regex functions

2021-10-02 Thread GitBox
edponce commented on a change in pull request #11233: URL: https://github.com/apache/arrow/pull/11233#discussion_r720710853 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) { { aut

[GitHub] [arrow] aucahuasi commented on a change in pull request #11257: ARROW-14035: [C++][Python][R] Implement count distinct kernel

2021-10-02 Thread GitBox
aucahuasi commented on a change in pull request #11257: URL: https://github.com/apache/arrow/pull/11257#discussion_r720709247 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -121,6 +122,168 @@ Result> CountInit(KernelContext*, static_cast(*args.opti

[GitHub] [arrow] aucahuasi commented on a change in pull request #11257: ARROW-14035: [C++][Python][R] Implement count distinct kernel

2021-10-02 Thread GitBox
aucahuasi commented on a change in pull request #11257: URL: https://github.com/apache/arrow/pull/11257#discussion_r720707311 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -121,6 +122,168 @@ Result> CountInit(KernelContext*, static_cast(*args.opti

[GitHub] [arrow] kiszk commented on a change in pull request #10350: ARROW-12814: [C++][Gandiva] Implements ABS, FLOOR, PI, SQRT, SIGN, LSHIFT, RSHIFT, CEIL, TRUNC, LN and LOG2 functions

2021-10-02 Thread GitBox
kiszk commented on a change in pull request #10350: URL: https://github.com/apache/arrow/pull/10350#discussion_r720702352 ## File path: cpp/src/gandiva/function_registry_math_ops.cc ## @@ -16,6 +16,7 @@ // under the License. #include "gandiva/function_registry_math_ops.h" +

[GitHub] [arrow] lidavidm commented on a change in pull request #11233: ARROW-13879: [C++] Mixed support for binary types in regex functions

2021-10-02 Thread GitBox
lidavidm commented on a change in pull request #11233: URL: https://github.com/apache/arrow/pull/11233#discussion_r720699550 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) { { au

[GitHub] [arrow] kiszk edited a comment on pull request #11293: ARROW-14198: [Java] Upgrade netty, grpc, and boringssl dependencies

2021-10-02 Thread GitBox
kiszk edited a comment on pull request #11293: URL: https://github.com/apache/arrow/pull/11293#issuecomment-932779453 grpc: 1.30.2 -> 1.41.0 boringssl: 2.0.31 -> 2.0.43 netty: 4.1.48 -> 4.1.68 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [arrow] lidavidm commented on a change in pull request #11233: ARROW-13879: [C++] Mixed support for binary types in regex functions

2021-10-02 Thread GitBox
lidavidm commented on a change in pull request #11233: URL: https://github.com/apache/arrow/pull/11233#discussion_r720699208 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) { { au

[GitHub] [arrow] edponce commented on a change in pull request #11233: ARROW-13879: [C++] Mixed support for binary types in regex functions

2021-10-02 Thread GitBox
edponce commented on a change in pull request #11233: URL: https://github.com/apache/arrow/pull/11233#discussion_r720699135 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) { { aut

[GitHub] [arrow] kiszk commented on pull request #11293: ARROW-14198: [Java] Upgrade netty, grpc, and boringssl dependencies

2021-10-02 Thread GitBox
kiszk commented on pull request #11293: URL: https://github.com/apache/arrow/pull/11293#issuecomment-932779453 gprc: 1.30.2 -> 1.41.0 boringssl: 2.0.31 -> 2.0.43 netty: 4.1.48 -> 4.1.68 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [arrow] edponce commented on a change in pull request #11233: ARROW-13879: [C++] Mixed support for binary types in regex functions

2021-10-02 Thread GitBox
edponce commented on a change in pull request #11233: URL: https://github.com/apache/arrow/pull/11233#discussion_r720698511 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) { { aut

[GitHub] [arrow] edponce commented on a change in pull request #11233: ARROW-13879: [C++] Mixed support for binary types in regex functions

2021-10-02 Thread GitBox
edponce commented on a change in pull request #11233: URL: https://github.com/apache/arrow/pull/11233#discussion_r720698511 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) { { aut

[GitHub] [arrow] aucahuasi commented on a change in pull request #11257: ARROW-14035: [C++][Python][R] Implement count distinct kernel

2021-10-02 Thread GitBox
aucahuasi commented on a change in pull request #11257: URL: https://github.com/apache/arrow/pull/11257#discussion_r720698022 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -121,6 +122,168 @@ Result> CountInit(KernelContext*, static_cast(*args.opti

[GitHub] [arrow] edponce closed pull request #11296: ARROW-14204: [C++] Fails to compile Arrow without RE2 due to missing ifdef guard in MatchLike

2021-10-02 Thread GitBox
edponce closed pull request #11296: URL: https://github.com/apache/arrow/pull/11296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [arrow] edponce commented on a change in pull request #11296: ARROW-14204: [C++] Fails to compile Arrow without RE2 due to missing ifdef guard in MatchLike

2021-10-02 Thread GitBox
edponce commented on a change in pull request #11296: URL: https://github.com/apache/arrow/pull/11296#discussion_r720695894 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1084,34 +1084,38 @@ struct MatchLike { Status status; std::string pattern;

[GitHub] [arrow-cookbook] thisisnic commented on a change in pull request #78: ARROW-13732: [Doc][Cookbook] Manipulating and analyze Arrow data with dplyr verbs - R

2021-10-02 Thread GitBox
thisisnic commented on a change in pull request #78: URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720693775 ## File path: r/content/_bookdown.yml ## @@ -4,10 +4,5 @@ new_session: FALSE clean: ["_book/*"] output_dir: _book edit: https://github.com/apache/

[GitHub] [arrow] cyb70289 commented on a change in pull request #11231: ARROW-14127: [C++][Docs] Example of using compute function and output

2021-10-02 Thread GitBox
cyb70289 commented on a change in pull request #11231: URL: https://github.com/apache/arrow/pull/11231#discussion_r720686604 ## File path: cpp/examples/arrow/compute_and_write_csv_example.cc ## @@ -0,0 +1,140 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow-cookbook] thisisnic commented on a change in pull request #78: ARROW-13732: [Doc][Cookbook] Manipulating and analyze Arrow data with dplyr verbs - R

2021-10-02 Thread GitBox
thisisnic commented on a change in pull request #78: URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720686494 ## File path: r/content/tables.Rmd ## @@ -0,0 +1,251 @@ +# Manipulating Data - Tables + +__What you should know before you begin__ + +When you call d

[GitHub] [arrow-cookbook] thisisnic commented on a change in pull request #78: ARROW-13732: [Doc][Cookbook] Manipulating and analyze Arrow data with dplyr verbs - R

2021-10-02 Thread GitBox
thisisnic commented on a change in pull request #78: URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720685622 ## File path: r/content/tables.Rmd ## @@ -0,0 +1,251 @@ +# Manipulating Data - Tables + +__What you should know before you begin__ + +When you call d

[GitHub] [arrow-cookbook] thisisnic commented on a change in pull request #78: ARROW-13732: [Doc][Cookbook] Manipulating and analyze Arrow data with dplyr verbs - R

2021-10-02 Thread GitBox
thisisnic commented on a change in pull request #78: URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720685461 ## File path: r/content/tables.Rmd ## @@ -0,0 +1,251 @@ +# Manipulating Data - Tables + +__What you should know before you begin__ + +When you call d

[GitHub] [arrow-cookbook] thisisnic commented on a change in pull request #78: ARROW-13732: [Doc][Cookbook] Manipulating and analyze Arrow data with dplyr verbs - R

2021-10-02 Thread GitBox
thisisnic commented on a change in pull request #78: URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720685439 ## File path: r/content/tables.Rmd ## @@ -0,0 +1,251 @@ +# Manipulating Data - Tables + +__What you should know before you begin__ + +When you call d

[GitHub] [arrow-cookbook] thisisnic commented on a change in pull request #78: ARROW-13732: [Doc][Cookbook] Manipulating and analyze Arrow data with dplyr verbs - R

2021-10-02 Thread GitBox
thisisnic commented on a change in pull request #78: URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720685283 ## File path: r/content/tables.Rmd ## @@ -0,0 +1,251 @@ +# Manipulating Data - Tables + +__What you should know before you begin__ + +When you call d

[GitHub] [arrow-cookbook] thisisnic commented on a change in pull request #78: ARROW-13732: [Doc][Cookbook] Manipulating and analyze Arrow data with dplyr verbs - R

2021-10-02 Thread GitBox
thisisnic commented on a change in pull request #78: URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720684830 ## File path: r/content/_bookdown.yml ## @@ -4,10 +4,5 @@ new_session: FALSE clean: ["_book/*"] output_dir: _book edit: https://github.com/apache/

[GitHub] [arrow] lidavidm commented on a change in pull request #11233: ARROW-13879: [C++] Mixed support for binary types in regex functions

2021-10-02 Thread GitBox
lidavidm commented on a change in pull request #11233: URL: https://github.com/apache/arrow/pull/11233#discussion_r720674546 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) { { au

[GitHub] [arrow] lidavidm commented on a change in pull request #11257: ARROW-14035: [C++][Python][R] Implement count distinct kernel

2021-10-02 Thread GitBox
lidavidm commented on a change in pull request #11257: URL: https://github.com/apache/arrow/pull/11257#discussion_r720674048 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -121,6 +122,84 @@ Result> CountInit(KernelContext*, static_cast(*args.option

[GitHub] [arrow-rs] alamb commented on pull request #810: Validate arguments to ArrayData::new and null bit buffer and buffers (WIP)

2021-10-02 Thread GitBox
alamb commented on pull request #810: URL: https://github.com/apache/arrow-rs/pull/810#issuecomment-932738590 @pitrou suggests looking at https://github.com/apache/arrow/blob/master/cpp/src/arrow/array/validate.h and https://github.com/apache/arrow/blob/master/cpp/src/arrow/array/vali

[GitHub] [arrow-datafusion] praveentiru commented on issue #879: [Help] - Floating point operations with Integer columns

2021-10-02 Thread GitBox
praveentiru commented on issue #879: URL: https://github.com/apache/arrow-datafusion/issues/879#issuecomment-932736766 @alamb My bad. Service level = 1/Missed Ratio. I have edited the question to replace Service Level with Missed Ratio. -- This is an automated message from the Apache Gi

[GitHub] [arrow-datafusion] xudong963 commented on issue #1064: UNION ALL bug: thread 'main' panicked at 'index out of bounds: the len is 1 but the index is 1', ./src/datatypes/schema.rs:165:10

2021-10-02 Thread GitBox
xudong963 commented on issue #1064: URL: https://github.com/apache/arrow-datafusion/issues/1064#issuecomment-932735738 Please assign it to me. I am doing https://github.com/apache/arrow-datafusion/pull/1029 and https://github.com/apache/arrow-datafusion/issues/1049 which could help me s

[GitHub] [arrow] github-actions[bot] commented on pull request #11295: ARROW-14180: [Packaging] Add support for AlmaLinux 8

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11295: URL: https://github.com/apache/arrow/pull/11295#issuecomment-932730855 Revision: dfde142b8b4b859c623cf49947e5d4a05a253423 Submitted crossbow builds: [ursacomputing/crossbow @ actions-871](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] kou commented on pull request #11295: ARROW-14180: [Packaging] Add support for AlmaLinux 8

2021-10-02 Thread GitBox
kou commented on pull request #11295: URL: https://github.com/apache/arrow/pull/11295#issuecomment-932730743 @github-actions crossbow submit almalinux-* centos-* amazon-linux-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-datafusion] alamb commented on issue #890: Release Datafusion 5.1.0

2021-10-02 Thread GitBox
alamb commented on issue #890: URL: https://github.com/apache/arrow-datafusion/issues/890#issuecomment-932728250 > sounds good, I think think I can try help push #873 to the finish line after you have arrow 6 released. It sounds like we are aiming to release arrow 6.0 in 2 weeks or

[GitHub] [arrow-datafusion] alamb commented on issue #667: good first PR: implement percent_rank and cume_dist built-in window functions

2021-10-02 Thread GitBox
alamb commented on issue #667: URL: https://github.com/apache/arrow-datafusion/issues/667#issuecomment-932728131 The idea is to add `cume_dist` and `percent_rank` as described in postgres (and elsewhere) https://www.postgresql.org/docs/10/functions-window.html -- This is

[GitHub] [arrow-datafusion] alamb commented on issue #672: good first PR: add SQL metrics to window function expressions

2021-10-02 Thread GitBox
alamb commented on issue #672: URL: https://github.com/apache/arrow-datafusion/issues/672#issuecomment-932727915 added in https://github.com/apache/arrow-datafusion/pull/1018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow-datafusion] alamb closed issue #672: good first PR: add SQL metrics to window function expressions

2021-10-02 Thread GitBox
alamb closed issue #672: URL: https://github.com/apache/arrow-datafusion/issues/672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [arrow-datafusion] alamb commented on issue #850: Optimize hash_aggregate when there are no null group keys

2021-10-02 Thread GitBox
alamb commented on issue #850: URL: https://github.com/apache/arrow-datafusion/issues/850#issuecomment-932727745 I think given the experience of @novemberkilo on this issue, we can conclude this is not an easy issue (and maybe not worth doing at all) so removing the label -- This is a

[GitHub] [arrow-datafusion] alamb commented on issue #879: [Help] - Floating point operations with Integer columns

2021-10-02 Thread GitBox
alamb commented on issue #879: URL: https://github.com/apache/arrow-datafusion/issues/879#issuecomment-932727559 Sorry for the late response > Service Level column comes out as integer with all zeros. I am not sure I understand the question -- there is no `Service Level` colu

[GitHub] [arrow-datafusion] alamb commented on issue #928: Generate Tokio Runtime in ExecutionContext

2021-10-02 Thread GitBox
alamb commented on issue #928: URL: https://github.com/apache/arrow-datafusion/issues/928#issuecomment-932727267 In case anyone is interested: https://docs.rs/tokio/1.12.0/tokio/#cpu-bound-tasks-and-blocking-code Is upgraded to say that using a separate tokio executor is not a bad i

[GitHub] [arrow-datafusion] alamb commented on issue #957: Inconsistent cast behavior

2021-10-02 Thread GitBox
alamb commented on issue #957: URL: https://github.com/apache/arrow-datafusion/issues/957#issuecomment-932727063 I think this would involve writing some tests and updating the coercion rules in https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physical_plan/expressions

[GitHub] [arrow-datafusion] alamb commented on issue #958: Add support for parsing timestamps from CSV files

2021-10-02 Thread GitBox
alamb commented on issue #958: URL: https://github.com/apache/arrow-datafusion/issues/958#issuecomment-932726750 Arrow contains the code to parse a string --> timestamp correctly here: https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/cast_utils.rs#L69 This ti

[GitHub] [arrow-datafusion] alamb commented on issue #1064: UNION ALL bug: thread 'main' panicked at 'index out of bounds: the len is 1 but the index is 1', ./src/datatypes/schema.rs:165:10

2021-10-02 Thread GitBox
alamb commented on issue #1064: URL: https://github.com/apache/arrow-datafusion/issues/1064#issuecomment-932726329 This one looks like it might be a good one for someone who wants to understand schemas and column references -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #11298: ARROW-14205: [C++]Add unicode normalization to scalar string

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11298: URL: https://github.com/apache/arrow/pull/11298#issuecomment-932724960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] kou commented on a change in pull request #11296: ARROW-14204: [C++] Fails to compile Arrow without RE2 due to missing ifdef guard in MatchLike

2021-10-02 Thread GitBox
kou commented on a change in pull request #11296: URL: https://github.com/apache/arrow/pull/11296#discussion_r720649820 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1084,34 +1084,38 @@ struct MatchLike { Status status; std::string pattern; -

[GitHub] [arrow] kou commented on a change in pull request #11296: ARROW-14204: [C++] Fails to compile Arrow without RE2 due to missing ifdef guard in MatchLike

2021-10-02 Thread GitBox
kou commented on a change in pull request #11296: URL: https://github.com/apache/arrow/pull/11296#discussion_r720649820 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1084,34 +1084,38 @@ struct MatchLike { Status status; std::string pattern; -

[GitHub] [arrow] Neltherion commented on issue #11239: Any replacements for `pa.serialize()` and `pa.deserialize()` ?

2021-10-02 Thread GitBox
Neltherion commented on issue #11239: URL: https://github.com/apache/arrow/issues/11239#issuecomment-932711211 Unfortunately benchmarking it over the network and considering the two sides would be trickier to pull. Can you answer my question about sending the pickled data: `If

[GitHub] [arrow] github-actions[bot] commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932708704 Revision: c374ebd7c93994258dde9d96051192bd607029e0 Submitted crossbow builds: [ursacomputing/crossbow @ actions-870](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] kou commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
kou commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932708526 @github-actions crossbow submit debian-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #11297: ARROW-13633: [Packaging][Debian] Add support for bookworm

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11297: URL: https://github.com/apache/arrow/pull/11297#issuecomment-932708471 https://issues.apache.org/jira/browse/ARROW-13633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow-datafusion] houqp commented on issue #890: Release Datafusion 5.1.0

2021-10-02 Thread GitBox
houqp commented on issue #890: URL: https://github.com/apache/arrow-datafusion/issues/890#issuecomment-932705996 sounds good, I think think I can try help push https://github.com/apache/arrow-datafusion/pull/873 to the finish line after you have arrow 6 released. -- This is an automate

[GitHub] [arrow-datafusion] houqp closed issue #1056: ARROW2: implement failable string cast

2021-10-02 Thread GitBox
houqp closed issue #1056: URL: https://github.com/apache/arrow-datafusion/issues/1056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] houqp commented on issue #1061: ARROW2: support avro

2021-10-02 Thread GitBox
houqp commented on issue #1061: URL: https://github.com/apache/arrow-datafusion/issues/1061#issuecomment-932702203 @Igosuki if you are interested in taking on this work, please coordinate with @jorgecarleitao . -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [arrow-datafusion] houqp commented on issue #1061: ARROW2: support avro

2021-10-02 Thread GitBox
houqp commented on issue #1061: URL: https://github.com/apache/arrow-datafusion/issues/1061#issuecomment-932701908 This is something else, we need to port your avro implementation to https://github.com/jorgecarleitao/arrow2/tree/main/src/io/avro for #68 ;) -- This is an automated messag

[GitHub] [arrow-datafusion] Igosuki commented on issue #1061: ARROW2: support avro

2021-10-02 Thread GitBox
Igosuki commented on issue #1061: URL: https://github.com/apache/arrow-datafusion/issues/1061#issuecomment-932697739 Is this about the dict issue or is it something else ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #11296: ARROW-14204: [C++] Fails to compile Arrow without RE2 due to missing ifdef guard in MatchLike

2021-10-02 Thread GitBox
github-actions[bot] commented on pull request #11296: URL: https://github.com/apache/arrow/pull/11296#issuecomment-932697270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] edponce opened a new pull request #11296: ARROW-14204: [C++] Fails to compile Arrow without RE2 due to missing ifdef guard in MatchLike

2021-10-02 Thread GitBox
edponce opened a new pull request #11296: URL: https://github.com/apache/arrow/pull/11296 Restructures cascading if-elses in MatchLike string kernel and adds ARROW_WITH_RE2 guard to statements invoking RegexSubstringMatcher. -- This is an automated message from the Apache Git Service. To