kou closed pull request #11297:
URL: https://github.com/apache/arrow/pull/11297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
kou commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932866383
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
kou closed pull request #11275:
URL: https://github.com/apache/arrow/pull/11275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
github-actions[bot] commented on pull request #11300:
URL: https://github.com/apache/arrow/pull/11300#issuecomment-932860041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kou opened a new pull request #11300:
URL: https://github.com/apache/arrow/pull/11300
They are needed for building libarrow_bundled_dependencies.a. We may build
libarrow_bundled_dependencies.a
before bundled Boost targets are built without them.
--
This is an automated message from th
github-actions[bot] commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932857660
Revision: 0076497a914705ff8033af155385f5b983fba40b
Submitted crossbow builds: [ursacomputing/crossbow @
actions-877](https://github.com/ursacomputing/crossbow/
kou commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932857585
@github-actions crossbow submit debian-* ubuntu-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
github-actions[bot] commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932851210
Revision: 0076497a914705ff8033af155385f5b983fba40b
Submitted crossbow builds: [ursacomputing/crossbow @
actions-876](https://github.com/ursacomputing/crossbow/
kou commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932851147
@github-actions crossbow submit debian-*-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
coryan commented on a change in pull request #11268:
URL: https://github.com/apache/arrow/pull/11268#discussion_r720744306
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -3470,6 +3498,203 @@ if(ARROW_WITH_GRPC)
endif()
endif()
+# -
coryan commented on a change in pull request #11268:
URL: https://github.com/apache/arrow/pull/11268#discussion_r720744303
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -3470,6 +3498,199 @@ if(ARROW_WITH_GRPC)
endif()
endif()
+# -
novemberkilo commented on issue #958:
URL:
https://github.com/apache/arrow-datafusion/issues/958#issuecomment-932829960
I would like to pick this up. Please assign to me as appropriate // @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
kou closed pull request #11295:
URL: https://github.com/apache/arrow/pull/11295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
kou commented on pull request #11295:
URL: https://github.com/apache/arrow/pull/11295#issuecomment-932824414
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
github-actions[bot] commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932823108
Revision: 3c1290174bd6c70803c8acf658fb936ca5d1a981
Submitted crossbow builds: [ursacomputing/crossbow @
actions-875](https://github.com/ursacomputing/crossbow/
kou commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932823003
@github-actions crossbow submit debian-* ubuntu-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
aucahuasi commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720728325
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -121,6 +122,168 @@ Result>
CountInit(KernelContext*,
static_cast(*args.opti
JayjeetAtGithub commented on a change in pull request #10913:
URL: https://github.com/apache/arrow/pull/10913#discussion_r720727019
##
File path: cpp/src/skyhook/client/file_skyhook.h
##
@@ -0,0 +1,100 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mor
github-actions[bot] commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932815272
Revision: a85831848137aa0d03d91eb205298ae5d113499a
Submitted crossbow builds: [ursacomputing/crossbow @
actions-874](https://github.com/ursacomputing/crossbow/
kou commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932815146
@github-actions crossbow submit debian-* ubuntu-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
pjmore commented on pull request #1066:
URL: https://github.com/apache/arrow-datafusion/pull/1066#issuecomment-932813749
@alamb Sounds good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
github-actions[bot] commented on pull request #11295:
URL: https://github.com/apache/arrow/pull/11295#issuecomment-932812975
Revision: 60f6e8080d40059a48e8ec3fde556bddc8f676a3
Submitted crossbow builds: [ursacomputing/crossbow @
actions-873](https://github.com/ursacomputing/crossbow/
kou commented on pull request #11295:
URL: https://github.com/apache/arrow/pull/11295#issuecomment-932812881
@github-actions crossbow submit almalinux-*-arm64 centos-*-arm64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kou commented on a change in pull request #11268:
URL: https://github.com/apache/arrow/pull/11268#discussion_r720719413
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -3470,6 +3498,203 @@ if(ARROW_WITH_GRPC)
endif()
endif()
+#
kou commented on pull request #11298:
URL: https://github.com/apache/arrow/pull/11298#issuecomment-932805055
@kevingurney Could you confirm the MATLAB test failure?
https://github.com/apache/arrow/pull/11298/checks?check_run_id=3776114858#step:7:9
It seems that MATLAB's license issue
github-actions[bot] commented on pull request #11299:
URL: https://github.com/apache/arrow/pull/11299#issuecomment-932802063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on pull request #11295:
URL: https://github.com/apache/arrow/pull/11295#issuecomment-932801099
Revision: 8107b68ec1e668114920ce10260dfeb22b2a2d49
Submitted crossbow builds: [ursacomputing/crossbow @
actions-872](https://github.com/ursacomputing/crossbow/
kou commented on pull request #11295:
URL: https://github.com/apache/arrow/pull/11295#issuecomment-932800951
@github-actions crossbow submit almalinux-* centos-* amazon-linux-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
edponce commented on pull request #11298:
URL: https://github.com/apache/arrow/pull/11298#issuecomment-932800313
Kernels and tests that make use of `utf8proc.h` need to be guarded with
`#ifdef ARROW_WITH_UTF8PROC`. I suggest that you move the normalization kernels
alongside the other UTF8
edponce commented on a change in pull request #11298:
URL: https://github.com/apache/arrow/pull/11298#discussion_r720712933
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -592,6 +592,70 @@ struct Utf8ReverseTransform : public StringTransformBase {
template
edponce commented on a change in pull request #11298:
URL: https://github.com/apache/arrow/pull/11298#discussion_r720712341
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -4299,6 +4390,10 @@ void RegisterScalarStringAscii(FunctionRegistry*
registry) {
edponce commented on a change in pull request #11298:
URL: https://github.com/apache/arrow/pull/11298#discussion_r720711626
##
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##
@@ -449,6 +449,30 @@ TYPED_TEST(TestStringKernels, Utf8Reverse) {
ASSERT_TRUE(res
edponce commented on a change in pull request #11233:
URL: https://github.com/apache/arrow/pull/11233#discussion_r720710853
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) {
{
aut
aucahuasi commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720709247
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -121,6 +122,168 @@ Result>
CountInit(KernelContext*,
static_cast(*args.opti
aucahuasi commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720707311
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -121,6 +122,168 @@ Result>
CountInit(KernelContext*,
static_cast(*args.opti
kiszk commented on a change in pull request #10350:
URL: https://github.com/apache/arrow/pull/10350#discussion_r720702352
##
File path: cpp/src/gandiva/function_registry_math_ops.cc
##
@@ -16,6 +16,7 @@
// under the License.
#include "gandiva/function_registry_math_ops.h"
+
lidavidm commented on a change in pull request #11233:
URL: https://github.com/apache/arrow/pull/11233#discussion_r720699550
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) {
{
au
kiszk edited a comment on pull request #11293:
URL: https://github.com/apache/arrow/pull/11293#issuecomment-932779453
grpc: 1.30.2 -> 1.41.0
boringssl: 2.0.31 -> 2.0.43
netty: 4.1.48 -> 4.1.68
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
lidavidm commented on a change in pull request #11233:
URL: https://github.com/apache/arrow/pull/11233#discussion_r720699208
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) {
{
au
edponce commented on a change in pull request #11233:
URL: https://github.com/apache/arrow/pull/11233#discussion_r720699135
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) {
{
aut
kiszk commented on pull request #11293:
URL: https://github.com/apache/arrow/pull/11293#issuecomment-932779453
gprc: 1.30.2 -> 1.41.0
boringssl: 2.0.31 -> 2.0.43
netty: 4.1.48 -> 4.1.68
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
edponce commented on a change in pull request #11233:
URL: https://github.com/apache/arrow/pull/11233#discussion_r720698511
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) {
{
aut
edponce commented on a change in pull request #11233:
URL: https://github.com/apache/arrow/pull/11233#discussion_r720698511
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) {
{
aut
aucahuasi commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720698022
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -121,6 +122,168 @@ Result>
CountInit(KernelContext*,
static_cast(*args.opti
edponce closed pull request #11296:
URL: https://github.com/apache/arrow/pull/11296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubsc
edponce commented on a change in pull request #11296:
URL: https://github.com/apache/arrow/pull/11296#discussion_r720695894
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1084,34 +1084,38 @@ struct MatchLike {
Status status;
std::string pattern;
thisisnic commented on a change in pull request #78:
URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720693775
##
File path: r/content/_bookdown.yml
##
@@ -4,10 +4,5 @@ new_session: FALSE
clean: ["_book/*"]
output_dir: _book
edit: https://github.com/apache/
cyb70289 commented on a change in pull request #11231:
URL: https://github.com/apache/arrow/pull/11231#discussion_r720686604
##
File path: cpp/examples/arrow/compute_and_write_csv_example.cc
##
@@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+//
thisisnic commented on a change in pull request #78:
URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720686494
##
File path: r/content/tables.Rmd
##
@@ -0,0 +1,251 @@
+# Manipulating Data - Tables
+
+__What you should know before you begin__
+
+When you call d
thisisnic commented on a change in pull request #78:
URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720685622
##
File path: r/content/tables.Rmd
##
@@ -0,0 +1,251 @@
+# Manipulating Data - Tables
+
+__What you should know before you begin__
+
+When you call d
thisisnic commented on a change in pull request #78:
URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720685461
##
File path: r/content/tables.Rmd
##
@@ -0,0 +1,251 @@
+# Manipulating Data - Tables
+
+__What you should know before you begin__
+
+When you call d
thisisnic commented on a change in pull request #78:
URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720685439
##
File path: r/content/tables.Rmd
##
@@ -0,0 +1,251 @@
+# Manipulating Data - Tables
+
+__What you should know before you begin__
+
+When you call d
thisisnic commented on a change in pull request #78:
URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720685283
##
File path: r/content/tables.Rmd
##
@@ -0,0 +1,251 @@
+# Manipulating Data - Tables
+
+__What you should know before you begin__
+
+When you call d
thisisnic commented on a change in pull request #78:
URL: https://github.com/apache/arrow-cookbook/pull/78#discussion_r720684830
##
File path: r/content/_bookdown.yml
##
@@ -4,10 +4,5 @@ new_session: FALSE
clean: ["_book/*"]
output_dir: _book
edit: https://github.com/apache/
lidavidm commented on a change in pull request #11233:
URL: https://github.com/apache/arrow/pull/11233#discussion_r720674546
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1132,52 +1132,51 @@ void AddMatchSubstring(FunctionRegistry* registry) {
{
au
lidavidm commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720674048
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -121,6 +122,84 @@ Result>
CountInit(KernelContext*,
static_cast(*args.option
alamb commented on pull request #810:
URL: https://github.com/apache/arrow-rs/pull/810#issuecomment-932738590
@pitrou suggests looking at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/array/validate.h
and
https://github.com/apache/arrow/blob/master/cpp/src/arrow/array/vali
praveentiru commented on issue #879:
URL:
https://github.com/apache/arrow-datafusion/issues/879#issuecomment-932736766
@alamb My bad. Service level = 1/Missed Ratio. I have edited the question to
replace Service Level with Missed Ratio.
--
This is an automated message from the Apache Gi
xudong963 commented on issue #1064:
URL:
https://github.com/apache/arrow-datafusion/issues/1064#issuecomment-932735738
Please assign it to me. I am doing
https://github.com/apache/arrow-datafusion/pull/1029 and
https://github.com/apache/arrow-datafusion/issues/1049 which could help me
s
github-actions[bot] commented on pull request #11295:
URL: https://github.com/apache/arrow/pull/11295#issuecomment-932730855
Revision: dfde142b8b4b859c623cf49947e5d4a05a253423
Submitted crossbow builds: [ursacomputing/crossbow @
actions-871](https://github.com/ursacomputing/crossbow/
kou commented on pull request #11295:
URL: https://github.com/apache/arrow/pull/11295#issuecomment-932730743
@github-actions crossbow submit almalinux-* centos-* amazon-linux-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
alamb commented on issue #890:
URL:
https://github.com/apache/arrow-datafusion/issues/890#issuecomment-932728250
> sounds good, I think think I can try help push #873 to the finish line
after you have arrow 6 released.
It sounds like we are aiming to release arrow 6.0 in 2 weeks or
alamb commented on issue #667:
URL:
https://github.com/apache/arrow-datafusion/issues/667#issuecomment-932728131
The idea is to add `cume_dist` and `percent_rank` as described in postgres
(and elsewhere)
https://www.postgresql.org/docs/10/functions-window.html
--
This is
alamb commented on issue #672:
URL:
https://github.com/apache/arrow-datafusion/issues/672#issuecomment-932727915
added in https://github.com/apache/arrow-datafusion/pull/1018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
alamb closed issue #672:
URL: https://github.com/apache/arrow-datafusion/issues/672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubsc
alamb commented on issue #850:
URL:
https://github.com/apache/arrow-datafusion/issues/850#issuecomment-932727745
I think given the experience of @novemberkilo on this issue, we can
conclude this is not an easy issue (and maybe not worth doing at all) so
removing the label
--
This is a
alamb commented on issue #879:
URL:
https://github.com/apache/arrow-datafusion/issues/879#issuecomment-932727559
Sorry for the late response
> Service Level column comes out as integer with all zeros.
I am not sure I understand the question -- there is no `Service Level`
colu
alamb commented on issue #928:
URL:
https://github.com/apache/arrow-datafusion/issues/928#issuecomment-932727267
In case anyone is interested:
https://docs.rs/tokio/1.12.0/tokio/#cpu-bound-tasks-and-blocking-code
Is upgraded to say that using a separate tokio executor is not a bad i
alamb commented on issue #957:
URL:
https://github.com/apache/arrow-datafusion/issues/957#issuecomment-932727063
I think this would involve writing some tests and updating the coercion
rules in
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physical_plan/expressions
alamb commented on issue #958:
URL:
https://github.com/apache/arrow-datafusion/issues/958#issuecomment-932726750
Arrow contains the code to parse a string --> timestamp correctly here:
https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/cast_utils.rs#L69
This ti
alamb commented on issue #1064:
URL:
https://github.com/apache/arrow-datafusion/issues/1064#issuecomment-932726329
This one looks like it might be a good one for someone who wants to
understand schemas and column references
--
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #11298:
URL: https://github.com/apache/arrow/pull/11298#issuecomment-932724960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kou commented on a change in pull request #11296:
URL: https://github.com/apache/arrow/pull/11296#discussion_r720649820
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1084,34 +1084,38 @@ struct MatchLike {
Status status;
std::string pattern;
-
kou commented on a change in pull request #11296:
URL: https://github.com/apache/arrow/pull/11296#discussion_r720649820
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1084,34 +1084,38 @@ struct MatchLike {
Status status;
std::string pattern;
-
Neltherion commented on issue #11239:
URL: https://github.com/apache/arrow/issues/11239#issuecomment-932711211
Unfortunately benchmarking it over the network and considering the two sides
would be trickier to pull.
Can you answer my question about sending the pickled data:
`If
github-actions[bot] commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932708704
Revision: c374ebd7c93994258dde9d96051192bd607029e0
Submitted crossbow builds: [ursacomputing/crossbow @
actions-870](https://github.com/ursacomputing/crossbow/
kou commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932708526
@github-actions crossbow submit debian-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on pull request #11297:
URL: https://github.com/apache/arrow/pull/11297#issuecomment-932708471
https://issues.apache.org/jira/browse/ARROW-13633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
houqp commented on issue #890:
URL:
https://github.com/apache/arrow-datafusion/issues/890#issuecomment-932705996
sounds good, I think think I can try help push
https://github.com/apache/arrow-datafusion/pull/873 to the finish line after
you have arrow 6 released.
--
This is an automate
houqp closed issue #1056:
URL: https://github.com/apache/arrow-datafusion/issues/1056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
houqp commented on issue #1061:
URL:
https://github.com/apache/arrow-datafusion/issues/1061#issuecomment-932702203
@Igosuki if you are interested in taking on this work, please coordinate
with @jorgecarleitao .
--
This is an automated message from the Apache Git Service.
To respond to t
houqp commented on issue #1061:
URL:
https://github.com/apache/arrow-datafusion/issues/1061#issuecomment-932701908
This is something else, we need to port your avro implementation to
https://github.com/jorgecarleitao/arrow2/tree/main/src/io/avro for #68 ;)
--
This is an automated messag
Igosuki commented on issue #1061:
URL:
https://github.com/apache/arrow-datafusion/issues/1061#issuecomment-932697739
Is this about the dict issue or is it something else ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #11296:
URL: https://github.com/apache/arrow/pull/11296#issuecomment-932697270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
edponce opened a new pull request #11296:
URL: https://github.com/apache/arrow/pull/11296
Restructures cascading if-elses in MatchLike string kernel and adds
ARROW_WITH_RE2 guard to statements invoking RegexSubstringMatcher.
--
This is an automated message from the Apache Git Service.
To
85 matches
Mail list logo