emkornfield commented on pull request #11302:
URL: https://github.com/apache/arrow/pull/11302#issuecomment-933193094
CC @tswast @jorisvandenbossche
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on pull request #11302:
URL: https://github.com/apache/arrow/pull/11302#issuecomment-933192894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
emkornfield opened a new pull request #11302:
URL: https://github.com/apache/arrow/pull/11302
- Refactored ObjectWriter helpers from arrow_to_pandas, so they can be
used for plain python types as well (generalized the lowest level so
it can work on both PyObject** and an adapter fo
houqp commented on a change in pull request #1066:
URL: https://github.com/apache/arrow-datafusion/pull/1066#discussion_r721055690
##
File path: datafusion/src/physical_plan/expressions/cast.rs
##
@@ -95,6 +95,24 @@ impl PhysicalExpr for CastExpr {
}
}
+impl CastExpr {
bkmgit commented on a change in pull request #11231:
URL: https://github.com/apache/arrow/pull/11231#discussion_r721051096
##
File path: cpp/examples/arrow/compute_and_write_csv_example.cc
##
@@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// o
praveentiru commented on issue #879:
URL:
https://github.com/apache/arrow-datafusion/issues/879#issuecomment-933126461
@houqp I am working in Rust directly. I will try the code from @alamb and
get back. I could not investigate over weekend.
--
This is an automated message from the Apach
rok commented on a change in pull request #11301:
URL: https://github.com/apache/arrow/pull/11301#discussion_r720937398
##
File path: r/tests/testthat/test-dplyr-funcs-string.R
##
@@ -757,9 +757,10 @@ test_that("strftime", {
times <- tibble(
datetime = c(lubridate::ym
asfgit closed pull request #11299:
URL: https://github.com/apache/arrow/pull/11299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
houqp commented on a change in pull request #1068:
URL: https://github.com/apache/arrow-datafusion/pull/1068#discussion_r720900472
##
File path: datafusion/src/execution/dataframe_impl.rs
##
@@ -214,6 +215,20 @@ impl DataFrame for DataFrameImpl {
.build()?;
aucahuasi commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720901022
##
File path: docs/source/cpp/compute.rst
##
@@ -199,6 +199,8 @@ the input to a single output value.
++---+--+
kou commented on a change in pull request #11268:
URL: https://github.com/apache/arrow/pull/11268#discussion_r720887779
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -3470,6 +3500,201 @@ if(ARROW_WITH_GRPC)
endif()
endif()
+#
ianmcook commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720871811
##
File path: docs/source/cpp/compute.rst
##
@@ -199,6 +199,8 @@ the input to a single output value.
++---+--+-
ianmcook commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720871811
##
File path: docs/source/cpp/compute.rst
##
@@ -199,6 +199,8 @@ the input to a single output value.
++---+--+-
houqp commented on pull request #1067:
URL: https://github.com/apache/arrow-datafusion/pull/1067#issuecomment-933018902
>
https://github.com/apache/arrow-datafusion/blob/master/benchmarks/src/bin/tpch.rs#L1092
is ok and get a plan, the plan is correct?
Yes, i think the logical plan
github-actions[bot] commented on pull request #11301:
URL: https://github.com/apache/arrow/pull/11301#issuecomment-933017956
https://issues.apache.org/jira/browse/ARROW-14200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
aucahuasi commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720876642
##
File path: r/tests/testthat/test-dplyr-summarize.R
##
@@ -227,6 +228,19 @@ test_that("Group by n_distinct() on dataset", {
collect(),
tbl
ianmcook commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720873549
##
File path: r/tests/testthat/test-dplyr-summarize.R
##
@@ -227,6 +228,19 @@ test_that("Group by n_distinct() on dataset", {
collect(),
tbl
ianmcook commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720873549
##
File path: r/tests/testthat/test-dplyr-summarize.R
##
@@ -227,6 +228,19 @@ test_that("Group by n_distinct() on dataset", {
collect(),
tbl
ianmcook commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720871811
##
File path: docs/source/cpp/compute.rst
##
@@ -199,6 +199,8 @@ the input to a single output value.
++---+--+-
ianmcook edited a comment on pull request #11266:
URL: https://github.com/apache/arrow/pull/11266#issuecomment-933005516
I opened ARROW-14208 to fix the issue that's causing
**test-build-vcpkg-win** to fail
--
This is an automated message from the Apache Git Service.
To respond to the me
ianmcook commented on pull request #11266:
URL: https://github.com/apache/arrow/pull/11266#issuecomment-933005516
I opened ARROW-14208 to fix the issue that's causing *test-build-vcpkg-win*
to fail
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
houqp commented on issue #879:
URL:
https://github.com/apache/arrow-datafusion/issues/879#issuecomment-93338
@praveentiru did you install your python binding from source? if not, it
might be really out of date.
--
This is an automated message from the Apache Git Service.
To respond
Dandandan commented on pull request #1068:
URL: https://github.com/apache/arrow-datafusion/pull/1068#issuecomment-932998850
This looks good @xudong963 thank you!
One suggestion I have is to also test the `UNION DISTINCT` syntax, to make
sure it's supported and has the same result as
Dandandan commented on a change in pull request #1068:
URL: https://github.com/apache/arrow-datafusion/pull/1068#discussion_r720865004
##
File path: datafusion/src/sql/planner.rs
##
@@ -3440,7 +3453,7 @@ mod tests {
let sql = "SELECT order_id from orders EXCEPT SELECT
Dandandan commented on a change in pull request #1068:
URL: https://github.com/apache/arrow-datafusion/pull/1068#discussion_r720864937
##
File path: datafusion/src/sql/planner.rs
##
@@ -170,8 +170,21 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let rig
xudong963 closed pull request #1029:
URL: https://github.com/apache/arrow-datafusion/pull/1029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: git
xudong963 commented on pull request #1029:
URL: https://github.com/apache/arrow-datafusion/pull/1029#issuecomment-932967244
Close the PR, the new is https://github.com/apache/arrow-datafusion/pull/1068
--
This is an automated message from the Apache Git Service.
To respond to the message,
xudong963 commented on pull request #1068:
URL: https://github.com/apache/arrow-datafusion/pull/1068#issuecomment-932966981
Use the way mentioned by @Dandandan @alamb, `UNION` is easy to implement!
Thanks again, PTAL @Dandandan @alamb @houqp
--
This is an automated message from the Apac
xudong963 opened a new pull request #1068:
URL: https://github.com/apache/arrow-datafusion/pull/1068
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/998
# Rationale for this change
# What changes are included in this PR?
okadakk commented on a change in pull request #11298:
URL: https://github.com/apache/arrow/pull/11298#discussion_r720815471
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -4299,6 +4390,10 @@ void RegisterScalarStringAscii(FunctionRegistry*
registry) {
alamb commented on issue #879:
URL:
https://github.com/apache/arrow-datafusion/issues/879#issuecomment-932901002
@praveentiru I don't normally use the dataframe API (and for your case, the
SQL interface might work better).
But in any event, I tried to reproduce the problem you are h
xudong963 edited a comment on pull request #1067:
URL: https://github.com/apache/arrow-datafusion/pull/1067#issuecomment-932890819
Though the PR fix the bug mentioned by the issue, there are still some bugs.
I am confused and need help.
When I ran the `cargo test`, I found there were fou
xudong963 edited a comment on pull request #1067:
URL: https://github.com/apache/arrow-datafusion/pull/1067#issuecomment-932890819
Though the PR fix the bug mentioned by the issue, there are still some bugs.
I am confused and need help.
When I ran the `cargo test`, I found there were fou
xudong963 edited a comment on pull request #1067:
URL: https://github.com/apache/arrow-datafusion/pull/1067#issuecomment-932890819
Though the PR fix the bug mentioned by the issue, there are still some bugs.
I am confused and need help.
When I ran the `cargo test`, I found there were fou
xudong963 edited a comment on pull request #1067:
URL: https://github.com/apache/arrow-datafusion/pull/1067#issuecomment-932890819
Though the PR fix the bug mentioned by the issue, there are still some bugs.
I am confused and need help.
When I ran the `cargo test`, I found there were fou
xudong963 edited a comment on pull request #1067:
URL: https://github.com/apache/arrow-datafusion/pull/1067#issuecomment-932890819
Though the PR fix the bug mentioned by the issue, there are still some bugs.
I am confused and need help.
When I ran the `cargo test`, I found there were fou
xudong963 commented on pull request #1067:
URL: https://github.com/apache/arrow-datafusion/pull/1067#issuecomment-932890819
Though the PR fix the bug mentioned by the issue, there are still some bugs.
I am confused and need help.
When I ran the `cargo test`, I found there were four tests
xudong963 commented on pull request #1067:
URL: https://github.com/apache/arrow-datafusion/pull/1067#issuecomment-932887430
```
> CREATE EXTERNAL TABLE customer STORED AS CSV LOCATION
'/Users/bytedance/arrow-datafusion/datafusion/tests/customer.csv';
0 rows in set. Query took 0.014 se
xudong963 opened a new pull request #1067:
URL: https://github.com/apache/arrow-datafusion/pull/1067
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/1049
# Rationale for this change
# What changes are included in this PR?
39 matches
Mail list logo
