[GitHub] [arrow] ursabot edited a comment on pull request #11259: ARROW-12563: [C++][Gandiva] Add add_months and datediff functions for string

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11259: URL: https://github.com/apache/arrow/pull/11259#issuecomment-948306839 Benchmark runs are scheduled for baseline = f893fa224637c2610a00d6e5e2d4e9f4ad764995 and contender = 3da66003ab2543c231fdf6551c2eb886f9a7e68f. 3da66003ab2543c231fdf6551c

[GitHub] [arrow] ursabot edited a comment on pull request #11436: ARROW-14345: [C++] Implement streaming reads

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11436: URL: https://github.com/apache/arrow/pull/11436#issuecomment-947933699 Benchmark runs are scheduled for baseline = 4ac62d5527e5f1635764a62986589d694605d1d8 and contender = a8e1c81249aa2477fd0623e3cfd9d50ba2eba4fd. a8e1c81249aa2477fd0623e3cf

[GitHub] [arrow] ursabot commented on pull request #11259: ARROW-12563: [C++][Gandiva] Add add_months and datediff functions for string

2021-10-20 Thread GitBox
ursabot commented on pull request #11259: URL: https://github.com/apache/arrow/pull/11259#issuecomment-948306839 Benchmark runs are scheduled for baseline = f893fa224637c2610a00d6e5e2d4e9f4ad764995 and contender = 3da66003ab2543c231fdf6551c2eb886f9a7e68f. 3da66003ab2543c231fdf6551c2eb886f

[GitHub] [arrow] praveenbingo closed pull request #11259: ARROW-12563: [C++][Gandiva] Add add_months and datediff functions for string

2021-10-20 Thread GitBox
praveenbingo closed pull request #11259: URL: https://github.com/apache/arrow/pull/11259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-un

[GitHub] [arrow-datafusion] xudong963 commented on issue #1147: WindowFunction works with SQL but not with DataFrame

2021-10-20 Thread GitBox
xudong963 commented on issue #1147: URL: https://github.com/apache/arrow-datafusion/issues/1147#issuecomment-948290955 Hi, @Jimexist, are you fixing it? If not, I think I can help fix it. I'm getting familiar with the code of window functions. -- This is an automated message from the Ap

[GitHub] [arrow] github-actions[bot] commented on pull request #11493: ARROW-14404: [Release][APT] Skip arm64 Debian GNU/Linux bookwarm verification

2021-10-20 Thread GitBox
github-actions[bot] commented on pull request #11493: URL: https://github.com/apache/arrow/pull/11493#issuecomment-948273161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] kou opened a new pull request #11493: ARROW-14404: [Release][APT] Skip arm64 Debian GNU/Linux bookwarm verification

2021-10-20 Thread GitBox
kou opened a new pull request #11493: URL: https://github.com/apache/arrow/pull/11493 qemu-user-static in Ubuntu 20.04 has a crash bug for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] ursabot edited a comment on pull request #11477: ARROW-14393: [C++] GTest linking errors during the source release verification

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11477: URL: https://github.com/apache/arrow/pull/11477#issuecomment-947748554 Benchmark runs are scheduled for baseline = 80ecf334c563d5b8c5ccb45e06cde2ae90e10633 and contender = 4ac62d5527e5f1635764a62986589d694605d1d8. 4ac62d5527e5f1635764a62986

[GitHub] [arrow-datafusion] Jimexist merged pull request #1152: python `lit` function to support bool and byte vec

2021-10-20 Thread GitBox
Jimexist merged pull request #1152: URL: https://github.com/apache/arrow-datafusion/pull/1152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gith

[GitHub] [arrow] ursabot edited a comment on pull request #11489: ARROW-14401: [C++] Fix bundled crc32c's include path

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11489: URL: https://github.com/apache/arrow/pull/11489#issuecomment-948253346 Benchmark runs are scheduled for baseline = 6f478d036b400428462929839a2eab2043f7761d and contender = f893fa224637c2610a00d6e5e2d4e9f4ad764995. f893fa224637c2610a00d6e5e2

[GitHub] [arrow] ursabot commented on pull request #11489: ARROW-14401: [C++] Fix bundled crc32c's include path

2021-10-20 Thread GitBox
ursabot commented on pull request #11489: URL: https://github.com/apache/arrow/pull/11489#issuecomment-948253346 Benchmark runs are scheduled for baseline = 6f478d036b400428462929839a2eab2043f7761d and contender = f893fa224637c2610a00d6e5e2d4e9f4ad764995. f893fa224637c2610a00d6e5e2d4e9f4a

[GitHub] [arrow] kou closed pull request #11489: ARROW-14401: [C++] Fix bundled crc32c's include path

2021-10-20 Thread GitBox
kou closed pull request #11489: URL: https://github.com/apache/arrow/pull/11489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow-datafusion] houqp commented on pull request #1152: python `lit` function to support bool and byte vec

2021-10-20 Thread GitBox
houqp commented on pull request #1152: URL: https://github.com/apache/arrow-datafusion/pull/1152#issuecomment-948249722 nice tip @pjmore , definitely looks much cleaner :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] github-actions[bot] commented on pull request #11487: [Release] Release 6.0.0 RC1 [WIP]

2021-10-20 Thread GitBox
github-actions[bot] commented on pull request #11487: URL: https://github.com/apache/arrow/pull/11487#issuecomment-948245090 Revision: 5a6f5919e68d1c0f2672c9c711858e5cbe0944cf Submitted crossbow builds: [ursacomputing/crossbow @ actions-1023](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] kou commented on pull request #11487: [Release] Release 6.0.0 RC1 [WIP]

2021-10-20 Thread GitBox
kou commented on pull request #11487: URL: https://github.com/apache/arrow/pull/11487#issuecomment-948244767 @github-actions crossbow submit --group verify-rc-binaries --param release=6.0.0 --param rc=1 -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [arrow] kou commented on pull request #11492: ARROW-14402: [Release][Yum] Specify gpg path explicitly

2021-10-20 Thread GitBox
kou commented on pull request #11492: URL: https://github.com/apache/arrow/pull/11492#issuecomment-948243650 @kszucs I've uploaded AlmaLinux, Amazon Linux and CentOS packages with this change. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] github-actions[bot] commented on pull request #11492: ARROW-14402: [Release][Yum] Specify gpg path explicitly

2021-10-20 Thread GitBox
github-actions[bot] commented on pull request #11492: URL: https://github.com/apache/arrow/pull/11492#issuecomment-948243267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] kou opened a new pull request #11492: ARROW-14402: [Release][Yum] Specify gpg path explicitly

2021-10-20 Thread GitBox
kou opened a new pull request #11492: URL: https://github.com/apache/arrow/pull/11492 The default gpg path is /usr/bin/gpg2 but it doesn't exist. We should use /usr/bin/gpg. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] ursabot edited a comment on pull request #11483: MINOR: [R] Fix sed for cross-OS compatibility

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11483: URL: https://github.com/apache/arrow/pull/11483#issuecomment-947723218 Benchmark runs are scheduled for baseline = ae943c3dc5b30487109cb415ff1e64db12d9a906 and contender = b2e1285334a7d927008014f2eff746e19fc9a892. b2e1285334a7d927008014f2ef

[GitHub] [arrow] ursabot edited a comment on pull request #11478: ARROW-14397: [C++] Fix valgrind error in test utility

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11478: URL: https://github.com/apache/arrow/pull/11478#issuecomment-947747660 Benchmark runs are scheduled for baseline = 77da17ba0bf0e488ad53a58b4fc6a0f5b1d5ff2b and contender = 80ecf334c563d5b8c5ccb45e06cde2ae90e10633. 80ecf334c563d5b8c5ccb45e06

[GitHub] [arrow-datafusion] Jimexist commented on pull request #1152: python `lit` function to support bool and byte vec

2021-10-20 Thread GitBox
Jimexist commented on pull request #1152: URL: https://github.com/apache/arrow-datafusion/pull/1152#issuecomment-948224918 > An alternative to manually trying to extract values is to create an enum with the allowed rust types and derive FromPyObject for it. I added in implementation for Li

[GitHub] [arrow] r0b3rt24 opened a new issue #11491: apache arrow c++: Ways to invalidate data

2021-10-20 Thread GitBox
r0b3rt24 opened a new issue #11491: URL: https://github.com/apache/arrow/issues/11491 To whom this may concern, I'm working on a research project where I need to delete several rows from an arrow array. Since the arrow does not support update/delete, I wonder if it's possible for me

[GitHub] [arrow] ursabot edited a comment on pull request #11451: ARROW-13436: [Python][Doc] Clarify what should be expected if read_table is passed an empty list of columns

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11451: URL: https://github.com/apache/arrow/pull/11451#issuecomment-947704766 Benchmark runs are scheduled for baseline = 65e69ac2c610f7c3501490608038af99ca6cef80 and contender = ae943c3dc5b30487109cb415ff1e64db12d9a906. ae943c3dc5b30487109cb415ff

[GitHub] [arrow] github-actions[bot] commented on pull request #11487: [Release] Release 6.0.0 RC1 [WIP]

2021-10-20 Thread GitBox
github-actions[bot] commented on pull request #11487: URL: https://github.com/apache/arrow/pull/11487#issuecomment-948179226 Revision: 5a6f5919e68d1c0f2672c9c711858e5cbe0944cf Submitted crossbow builds: [ursacomputing/crossbow @ actions-1022](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] kszucs commented on pull request #11487: [Release] Release 6.0.0 RC1 [WIP]

2021-10-20 Thread GitBox
kszucs commented on pull request #11487: URL: https://github.com/apache/arrow/pull/11487#issuecomment-948178904 @github-actions crossbow submit --group verify-rc-wheels --param release=6.0.0 --param rc=1 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [arrow] niyue commented on pull request #11486: ARROW-12683 [C++] Enable fine-grained I/O (coalescing) in IPC reader

2021-10-20 Thread GitBox
niyue commented on pull request #11486: URL: https://github.com/apache/arrow/pull/11486#issuecomment-948164361 @emkornfield I pushed a new commit trying to fix the issue reported by CI, but it seems the new running CI job failed because CI failed to download "MinIO.exe" (probably a tempora

[GitHub] [arrow] ursabot edited a comment on pull request #11483: MINOR: [R] Fix sed for cross-OS compatibility

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11483: URL: https://github.com/apache/arrow/pull/11483#issuecomment-947723218 Benchmark runs are scheduled for baseline = ae943c3dc5b30487109cb415ff1e64db12d9a906 and contender = b2e1285334a7d927008014f2eff746e19fc9a892. b2e1285334a7d927008014f2ef

[GitHub] [arrow] ursabot edited a comment on pull request #11475: ARROW-13317: [Python] Improve documentation on what 'use_threads' does in 'read_feather'

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11475: URL: https://github.com/apache/arrow/pull/11475#issuecomment-947672449 Benchmark runs are scheduled for baseline = eb3c1bd8e14acf96b2fa77b34cc51e8b3e18c03d and contender = 65e69ac2c610f7c3501490608038af99ca6cef80. 65e69ac2c610f7c35014906080

[GitHub] [arrow] github-actions[bot] commented on pull request #11490: [Packaging][Crossbow] Option for skipping artifact pattern validation

2021-10-20 Thread GitBox
github-actions[bot] commented on pull request #11490: URL: https://github.com/apache/arrow/pull/11490#issuecomment-948094050 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you ope

[GitHub] [arrow] ursabot edited a comment on pull request #11451: ARROW-13436: [Python][Doc] Clarify what should be expected if read_table is passed an empty list of columns

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11451: URL: https://github.com/apache/arrow/pull/11451#issuecomment-947704766 Benchmark runs are scheduled for baseline = 65e69ac2c610f7c3501490608038af99ca6cef80 and contender = ae943c3dc5b30487109cb415ff1e64db12d9a906. ae943c3dc5b30487109cb415ff

[GitHub] [arrow] niyue commented on pull request #11486: ARROW-12683 [C++] Enable fine-grained I/O (coalescing) in IPC reader

2021-10-20 Thread GitBox
niyue commented on pull request #11486: URL: https://github.com/apache/arrow/pull/11486#issuecomment-948074127 > @niyue Thanks for the PR. it looks like the CI is likely highlighting real issues with the PR, would you mind fixing those? Sure. Let me try it out. -- This is an autom

[GitHub] [arrow] lidavidm commented on a change in pull request #11358: ARROW-12820: [C++] Support zone offset in ISO8601, strptime parser

2021-10-20 Thread GitBox
lidavidm commented on a change in pull request #11358: URL: https://github.com/apache/arrow/pull/11358#discussion_r733180686 ## File path: docs/source/cpp/csv.rst ## @@ -190,6 +190,70 @@ dictionary-encoded string-like array. It switches to a plain string-like array when the

[GitHub] [arrow] github-actions[bot] commented on pull request #11486: ARROW-12683 [C++] Enable fine-grained I/O (coalescing) in IPC reader

2021-10-20 Thread GitBox
github-actions[bot] commented on pull request #11486: URL: https://github.com/apache/arrow/pull/11486#issuecomment-948073161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] ursabot edited a comment on pull request #11474: ARROW-14392: [C++] Bundled gRPC misses bundled Abseil include path

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11474: URL: https://github.com/apache/arrow/pull/11474#issuecomment-947671528 Benchmark runs are scheduled for baseline = 29892ba5c556072c8ed86b156d2a18d560b2ebff and contender = eb3c1bd8e14acf96b2fa77b34cc51e8b3e18c03d. eb3c1bd8e14acf96b2fa77b34c

[GitHub] [arrow] westonpace commented on a change in pull request #11358: ARROW-12820: [C++] Support zone offset in ISO8601, strptime parser

2021-10-20 Thread GitBox
westonpace commented on a change in pull request #11358: URL: https://github.com/apache/arrow/pull/11358#discussion_r733175188 ## File path: docs/source/cpp/csv.rst ## @@ -190,6 +190,70 @@ dictionary-encoded string-like array. It switches to a plain string-like array when th

[GitHub] [arrow] lidavidm commented on a change in pull request #11358: ARROW-12820: [C++] Support zone offset in ISO8601, strptime parser

2021-10-20 Thread GitBox
lidavidm commented on a change in pull request #11358: URL: https://github.com/apache/arrow/pull/11358#discussion_r733156807 ## File path: docs/source/cpp/csv.rst ## @@ -190,6 +190,70 @@ dictionary-encoded string-like array. It switches to a plain string-like array when the

[GitHub] [arrow] omjavaid commented on a change in pull request #11383: ARROW-9688: [C++][Python] Enable building c++ library and pyarrow package for win/arm64 build

2021-10-20 Thread GitBox
omjavaid commented on a change in pull request #11383: URL: https://github.com/apache/arrow/pull/11383#discussion_r733154445 ## File path: cpp/cmake_modules/ThirdpartyToolchain.cmake ## @@ -903,7 +903,13 @@ if(ARROW_USE_UBSAN) set(ARROW_USE_NATIVE_INT128 FALSE) else() in

[GitHub] [arrow] westonpace commented on a change in pull request #11358: ARROW-12820: [C++] Support zone offset in ISO8601, strptime parser

2021-10-20 Thread GitBox
westonpace commented on a change in pull request #11358: URL: https://github.com/apache/arrow/pull/11358#discussion_r733153909 ## File path: docs/source/cpp/csv.rst ## @@ -190,6 +190,70 @@ dictionary-encoded string-like array. It switches to a plain string-like array when th

[GitHub] [arrow] omjavaid commented on a change in pull request #11383: ARROW-9688: [C++][Python] Enable building c++ library and pyarrow package for win/arm64 build

2021-10-20 Thread GitBox
omjavaid commented on a change in pull request #11383: URL: https://github.com/apache/arrow/pull/11383#discussion_r733150756 ## File path: cpp/cmake_modules/ThirdpartyToolchain.cmake ## @@ -903,7 +903,13 @@ if(ARROW_USE_UBSAN) set(ARROW_USE_NATIVE_INT128 FALSE) else() in

[GitHub] [arrow] github-actions[bot] commented on pull request #11489: ARROW-14401: [C++] Fix bundled crc32c's include path

2021-10-20 Thread GitBox
github-actions[bot] commented on pull request #11489: URL: https://github.com/apache/arrow/pull/11489#issuecomment-948026023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] ursabot edited a comment on pull request #11485: ARROW-14396: [R][Doc] Remove relic note in write_dataset that columns cannot be renamed

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11485: URL: https://github.com/apache/arrow/pull/11485#issuecomment-948010426 Benchmark runs are scheduled for baseline = 9841dc864c62115d68706750b86ced5e142804f6 and contender = 6f478d036b400428462929839a2eab2043f7761d. 6f478d036b400428462929839a

[GitHub] [arrow] ursabot edited a comment on pull request #11475: ARROW-13317: [Python] Improve documentation on what 'use_threads' does in 'read_feather'

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11475: URL: https://github.com/apache/arrow/pull/11475#issuecomment-947672449 Benchmark runs are scheduled for baseline = eb3c1bd8e14acf96b2fa77b34cc51e8b3e18c03d and contender = 65e69ac2c610f7c3501490608038af99ca6cef80. 65e69ac2c610f7c35014906080

[GitHub] [arrow] ursabot commented on pull request #11485: ARROW-14396: [R][Doc] Remove relic note in write_dataset that columns cannot be renamed

2021-10-20 Thread GitBox
ursabot commented on pull request #11485: URL: https://github.com/apache/arrow/pull/11485#issuecomment-948010426 Benchmark runs are scheduled for baseline = 9841dc864c62115d68706750b86ced5e142804f6 and contender = 6f478d036b400428462929839a2eab2043f7761d. 6f478d036b400428462929839a2eab204

[GitHub] [arrow] nealrichardson closed pull request #11485: ARROW-14396: [R][Doc] Remove relic note in write_dataset that columns cannot be renamed

2021-10-20 Thread GitBox
nealrichardson closed pull request #11485: URL: https://github.com/apache/arrow/pull/11485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow] ursabot edited a comment on pull request #11434: ARROW-14004: [Python][Doc] Document nullable dtypes handling and usage of types_mapper in to_pandas conversion

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11434: URL: https://github.com/apache/arrow/pull/11434#issuecomment-947625259 Benchmark runs are scheduled for baseline = 54bacf9d9cf2f17693222520810bf4c28e09f766 and contender = 29892ba5c556072c8ed86b156d2a18d560b2ebff. 29892ba5c556072c8ed86b156d

[GitHub] [arrow] coryan commented on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

2021-10-20 Thread GitBox
coryan commented on pull request #11406: URL: https://github.com/apache/arrow/pull/11406#issuecomment-947965746 Is there something else I need to do here or can we merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [arrow-datafusion] alamb closed pull request #1145: WIP: Alternate implementation of partial evaluation / generalized constant folding

2021-10-20 Thread GitBox
alamb closed pull request #1145: URL: https://github.com/apache/arrow-datafusion/pull/1145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb commented on pull request #1145: WIP: Alternate implementation of partial evaluation / generalized constant folding

2021-10-20 Thread GitBox
alamb commented on pull request #1145: URL: https://github.com/apache/arrow-datafusion/pull/1145#issuecomment-947964437 I plan to "productionize" this approach in https://github.com/apache/arrow-datafusion/pull/1153, so closing this PR -- This is an automated message from the Apache Git

[GitHub] [arrow-datafusion] alamb opened a new pull request #1153: Generic constant expression evaluation (WIP)

2021-10-20 Thread GitBox
alamb opened a new pull request #1153: URL: https://github.com/apache/arrow-datafusion/pull/1153 Work in progress PR to add generalized constant folding # Which issue does this PR close? Closes #1070. # Rationale for this change See #1070 Note there is also pr

[GitHub] [arrow] ursabot commented on pull request #11488: ARROW-14400: [Go] Equals and ApproxEquals for Tables and Chunked Arrays

2021-10-20 Thread GitBox
ursabot commented on pull request #11488: URL: https://github.com/apache/arrow/pull/11488#issuecomment-947957935 Benchmark runs are scheduled for baseline = a8e1c81249aa2477fd0623e3cfd9d50ba2eba4fd and contender = 9841dc864c62115d68706750b86ced5e142804f6. 9841dc864c62115d68706750b86ced5e1

[GitHub] [arrow] asfgit closed pull request #11488: ARROW-14400: [Go] Equals and ApproxEquals for Tables and Chunked Arrays

2021-10-20 Thread GitBox
asfgit closed pull request #11488: URL: https://github.com/apache/arrow/pull/11488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] save-buffer edited a comment on pull request #11455: ARROW-13668: [Python] Add `write_batch` and `write` methods to `ParquetWriter`

2021-10-20 Thread GitBox
save-buffer edited a comment on pull request #11455: URL: https://github.com/apache/arrow/pull/11455#issuecomment-947952582 Thanks for the feedback! I think I've addressed everything so far. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [arrow] save-buffer commented on pull request #11455: ARROW-13668: [Python] Add `write_batch` and `write` methods to `ParquetWriter`

2021-10-20 Thread GitBox
save-buffer commented on pull request #11455: URL: https://github.com/apache/arrow/pull/11455#issuecomment-947952582 Thanks for the feed back! I think I've addressed everything so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [arrow-datafusion] houqp commented on issue #970: Execute LogicalPlan on DBMS directly

2021-10-20 Thread GitBox
houqp commented on issue #970: URL: https://github.com/apache/arrow-datafusion/issues/970#issuecomment-947946521 Thanks @alamb for adding the diagrams, really helps to visualize the idea :) > We might even be able to do it without any changes to the TableProvider as of now. Q

[GitHub] [arrow] ursabot edited a comment on pull request #11474: ARROW-14392: [C++] Bundled gRPC misses bundled Abseil include path

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11474: URL: https://github.com/apache/arrow/pull/11474#issuecomment-947671528 Benchmark runs are scheduled for baseline = 29892ba5c556072c8ed86b156d2a18d560b2ebff and contender = eb3c1bd8e14acf96b2fa77b34cc51e8b3e18c03d. eb3c1bd8e14acf96b2fa77b34c

[GitHub] [arrow] ursabot commented on pull request #11436: ARROW-14345: [C++] Implement streaming reads

2021-10-20 Thread GitBox
ursabot commented on pull request #11436: URL: https://github.com/apache/arrow/pull/11436#issuecomment-947933699 Benchmark runs are scheduled for baseline = 4ac62d5527e5f1635764a62986589d694605d1d8 and contender = a8e1c81249aa2477fd0623e3cfd9d50ba2eba4fd. a8e1c81249aa2477fd0623e3cfd9d50ba

[GitHub] [arrow] github-actions[bot] commented on pull request #10913: ARROW-13607: [C++] Add Skyhook to Arrow

2021-10-20 Thread GitBox
github-actions[bot] commented on pull request #10913: URL: https://github.com/apache/arrow/pull/10913#issuecomment-947938991 Revision: 8b56654f7cdab03df04c8e55a304c9f0586bab7d Submitted crossbow builds: [ursacomputing/crossbow @ actions-1021](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] kou commented on pull request #10913: ARROW-13607: [C++] Add Skyhook to Arrow

2021-10-20 Thread GitBox
kou commented on pull request #10913: URL: https://github.com/apache/arrow/pull/10913#issuecomment-947938155 @github-actions crossbow submit -g nightly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] emkornfield closed pull request #11436: ARROW-14345: [C++] Implement streaming reads

2021-10-20 Thread GitBox
emkornfield closed pull request #11436: URL: https://github.com/apache/arrow/pull/11436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-uns

[GitHub] [arrow] emkornfield commented on pull request #11436: ARROW-14345: [C++] Implement streaming reads

2021-10-20 Thread GitBox
emkornfield commented on pull request #11436: URL: https://github.com/apache/arrow/pull/11436#issuecomment-947932147 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [arrow] emkornfield commented on pull request #11486: Support reading arrow IPC file with fine grained IO

2021-10-20 Thread GitBox
emkornfield commented on pull request #11486: URL: https://github.com/apache/arrow/pull/11486#issuecomment-947926969 @niyue Thanks for the PR. it looks like the CI is likely highlighting real issues with the PR, would you mind fixing those? -- This is an automated message from the Apache

[GitHub] [arrow] ursabot edited a comment on pull request #11445: ARROW-10094: [Python][Doc] Document missing pandas to arrow conversions

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11445: URL: https://github.com/apache/arrow/pull/11445#issuecomment-947602824 Benchmark runs are scheduled for baseline = 98b0e99f0f242e764e839c4723f7061db39f8e9e and contender = 54bacf9d9cf2f17693222520810bf4c28e09f766. 54bacf9d9cf2f1769322252081

[GitHub] [arrow-datafusion] alamb commented on pull request #1145: WIP: Alternate implementation of partial evaluation / generalized constant folding

2021-10-20 Thread GitBox
alamb commented on pull request #1145: URL: https://github.com/apache/arrow-datafusion/pull/1145#issuecomment-947895222 This turns out to be something that will help IOx so I am going to keep hacking on it In case anyone else is interested, we have some rewrite passes that may end u

[GitHub] [arrow-datafusion] houqp edited a comment on issue #970: Execute LogicalPlan on DBMS directly

2021-10-20 Thread GitBox
houqp edited a comment on issue #970: URL: https://github.com/apache/arrow-datafusion/issues/970#issuecomment-947443126 I think with some extension to our existing table provider abstraction, this kind of cross table compute push down could be achieved within our logical or physical plan

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1152: python `lit` function to support bool and byte vec

2021-10-20 Thread GitBox
houqp commented on a change in pull request #1152: URL: https://github.com/apache/arrow-datafusion/pull/1152#discussion_r733001957 ## File path: python/src/functions.rs ## @@ -39,15 +39,19 @@ fn col(name: &str) -> expression::Expression { #[pyfunction] #[pyo3(text_signature =

[GitHub] [arrow] coryan commented on pull request #11436: ARROW-14345: [C++] Implement streaming reads

2021-10-20 Thread GitBox
coryan commented on pull request #11436: URL: https://github.com/apache/arrow/pull/11436#issuecomment-947866384 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [arrow] ursabot edited a comment on pull request #11434: ARROW-14004: [Python][Doc] Document nullable dtypes handling and usage of types_mapper in to_pandas conversion

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11434: URL: https://github.com/apache/arrow/pull/11434#issuecomment-947625259 Benchmark runs are scheduled for baseline = 54bacf9d9cf2f17693222520810bf4c28e09f766 and contender = 29892ba5c556072c8ed86b156d2a18d560b2ebff. 29892ba5c556072c8ed86b156d

[GitHub] [arrow] lidavidm commented on pull request #11358: ARROW-12820: [C++] Support zone offset in ISO8601, strptime parser

2021-10-20 Thread GitBox
lidavidm commented on pull request #11358: URL: https://github.com/apache/arrow/pull/11358#issuecomment-947853522 Casts are fixed, now to go update the CSV parser as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1152: python `lit` function to support bool and byte vec

2021-10-20 Thread GitBox
xudong963 commented on a change in pull request #1152: URL: https://github.com/apache/arrow-datafusion/pull/1152#discussion_r732947424 ## File path: python/src/functions.rs ## @@ -39,15 +39,19 @@ fn col(name: &str) -> expression::Expression { #[pyfunction] #[pyo3(text_signatu

[GitHub] [arrow] ursabot edited a comment on pull request #11457: ARROW-13784: [Python] Table.from_arrays should raise an error when array is empty but names is not

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11457: URL: https://github.com/apache/arrow/pull/11457#issuecomment-947425711 Benchmark runs are scheduled for baseline = c8f882cc84f5f54a11dc9bfbd97da8050bddac0e and contender = 98b0e99f0f242e764e839c4723f7061db39f8e9e. 98b0e99f0f242e764e839c4723

[GitHub] [arrow] save-buffer commented on a change in pull request #11455: ARROW-13668: [Python] Add `write_batch` and `write` methods to `ParquetWriter`

2021-10-20 Thread GitBox
save-buffer commented on a change in pull request #11455: URL: https://github.com/apache/arrow/pull/11455#discussion_r732940494 ## File path: python/pyarrow/parquet.py ## @@ -687,7 +687,43 @@ def __exit__(self, *args, **kwargs): # return false since we want to propagat

[GitHub] [arrow] github-actions[bot] commented on pull request #11488: ARROW-14400: [Go] Equals and ApproxEquals for Tables and Chunked Arrays

2021-10-20 Thread GitBox
github-actions[bot] commented on pull request #11488: URL: https://github.com/apache/arrow/pull/11488#issuecomment-947810540 https://issues.apache.org/jira/browse/ARROW-14400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow-datafusion] Jimexist opened a new pull request #1152: python `lit` function to support bool and byte vec

2021-10-20 Thread GitBox
Jimexist opened a new pull request #1152: URL: https://github.com/apache/arrow-datafusion/pull/1152 # Which issue does this PR close? Closes # # Rationale for this change python `lit` function to support bool and byte vec # What changes are included in this PR?

[GitHub] [arrow] github-actions[bot] commented on pull request #11487: [Release] Release 6.0.0 RC1 [WIP]

2021-10-20 Thread GitBox
github-actions[bot] commented on pull request #11487: URL: https://github.com/apache/arrow/pull/11487#issuecomment-947798453 Revision: 5a6f5919e68d1c0f2672c9c711858e5cbe0944cf Submitted crossbow builds: [ursacomputing/crossbow @ actions-1020](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] github-actions[bot] removed a comment on pull request #11487: [Release] Release 6.0.0 RC1 [WIP]

2021-10-20 Thread GitBox
github-actions[bot] removed a comment on pull request #11487: URL: https://github.com/apache/arrow/pull/11487#issuecomment-947796810 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could

[GitHub] [arrow] kszucs commented on pull request #11470: [Release] Verify 6.0.0 RC0 [WIP]

2021-10-20 Thread GitBox
kszucs commented on pull request #11470: URL: https://github.com/apache/arrow/pull/11470#issuecomment-947798171 Closing in favor of #11487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [arrow] kszucs closed pull request #11470: [Release] Verify 6.0.0 RC0 [WIP]

2021-10-20 Thread GitBox
kszucs closed pull request #11470: URL: https://github.com/apache/arrow/pull/11470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] kszucs commented on pull request #11487: [Release] Release 6.0.0 RC1 [WIP]

2021-10-20 Thread GitBox
kszucs commented on pull request #11487: URL: https://github.com/apache/arrow/pull/11487#issuecomment-947797576 @github-actions crossbow submit --group verify-rc-source --param release=6.0.0 --param rc=1 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [arrow] github-actions[bot] commented on pull request #11487: [Release] Release 6.0.0 RC1 [WIP]

2021-10-20 Thread GitBox
github-actions[bot] commented on pull request #11487: URL: https://github.com/apache/arrow/pull/11487#issuecomment-947796810 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you ope

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1143: Add output_partitions_size for CoalescePartitionsExec

2021-10-20 Thread GitBox
xudong963 commented on pull request #1143: URL: https://github.com/apache/arrow-datafusion/pull/1143#issuecomment-947779821 So I'll continue to implement `CoalescePartitionsExec` separate with `RepartitionExec`. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] lidavidm commented on pull request #11358: ARROW-12820: [C++] Support zone offset in ISO8601, strptime parser

2021-10-20 Thread GitBox
lidavidm commented on pull request #11358: URL: https://github.com/apache/arrow/pull/11358#issuecomment-947776004 Ah, we probably then want an option (for both cast/CSV parsing), much like the assume_timezone kernel, that controls what to do with ambiguous or nonexistent local times.

[GitHub] [arrow] ursabot edited a comment on pull request #11445: ARROW-10094: [Python][Doc] Document missing pandas to arrow conversions

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11445: URL: https://github.com/apache/arrow/pull/11445#issuecomment-947602824 Benchmark runs are scheduled for baseline = 98b0e99f0f242e764e839c4723f7061db39f8e9e and contender = 54bacf9d9cf2f17693222520810bf4c28e09f766. 54bacf9d9cf2f1769322252081

[GitHub] [arrow] AlenkaF commented on a change in pull request #11447: ARROW-11238: [Python] Make SubTreeFileSystem print method more informative

2021-10-20 Thread GitBox
AlenkaF commented on a change in pull request #11447: URL: https://github.com/apache/arrow/pull/11447#discussion_r732887063 ## File path: python/pyarrow/_fs.pyx ## @@ -833,6 +833,10 @@ cdef class SubTreeFileSystem(FileSystem): FileSystem.init(self, wrapped) se

[GitHub] [arrow] ursabot edited a comment on pull request #11477: ARROW-14393: [C++] GTest linking errors during the source release verification

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11477: URL: https://github.com/apache/arrow/pull/11477#issuecomment-947748554 Benchmark runs are scheduled for baseline = 80ecf334c563d5b8c5ccb45e06cde2ae90e10633 and contender = 4ac62d5527e5f1635764a62986589d694605d1d8. 4ac62d5527e5f1635764a62986

[GitHub] [arrow] lidavidm commented on pull request #11358: ARROW-12820: [C++] Support zone offset in ISO8601, strptime parser

2021-10-20 Thread GitBox
lidavidm commented on pull request #11358: URL: https://github.com/apache/arrow/pull/11358#issuecomment-947764880 This is what happens on this branch: ``` >>> pa.array(["2021-01-01 09:00:00"]).cast(pa.timestamp("s")) [ 2021-01-01 09:00:00 ] >>> pa.array(["2021-01-

[GitHub] [arrow] ursabot edited a comment on pull request #11478: ARROW-14397: [C++] Fix valgrind error in test utility

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11478: URL: https://github.com/apache/arrow/pull/11478#issuecomment-947747660 Benchmark runs are scheduled for baseline = 77da17ba0bf0e488ad53a58b4fc6a0f5b1d5ff2b and contender = 80ecf334c563d5b8c5ccb45e06cde2ae90e10633. 80ecf334c563d5b8c5ccb45e06

[GitHub] [arrow-datafusion] Jimexist commented on issue #1147: WindowFunction works with SQL but not with DataFrame

2021-10-20 Thread GitBox
Jimexist commented on issue #1147: URL: https://github.com/apache/arrow-datafusion/issues/1147#issuecomment-947752395 yes i can confirm it was because in https://github.com/apache/arrow-datafusion/blob/4b577f374ce0922f61608be25d8d91c59a65c2cf/datafusion/src/execution/dataframe_impl.rs#L77-

[GitHub] [arrow] ursabot commented on pull request #11477: ARROW-14393: [C++] GTest linking errors during the source release verification

2021-10-20 Thread GitBox
ursabot commented on pull request #11477: URL: https://github.com/apache/arrow/pull/11477#issuecomment-947748554 Benchmark runs are scheduled for baseline = 80ecf334c563d5b8c5ccb45e06cde2ae90e10633 and contender = 4ac62d5527e5f1635764a62986589d694605d1d8. 4ac62d5527e5f1635764a62986589d694

[GitHub] [arrow] ursabot commented on pull request #11478: ARROW-14397: [C++] Fix valgrind error in test utility

2021-10-20 Thread GitBox
ursabot commented on pull request #11478: URL: https://github.com/apache/arrow/pull/11478#issuecomment-947747660 Benchmark runs are scheduled for baseline = 77da17ba0bf0e488ad53a58b4fc6a0f5b1d5ff2b and contender = 80ecf334c563d5b8c5ccb45e06cde2ae90e10633. 80ecf334c563d5b8c5ccb45e06cde2ae9

[GitHub] [arrow] kszucs closed pull request #11477: ARROW-14393: [C++] GTest linking errors during the source release verification

2021-10-20 Thread GitBox
kszucs closed pull request #11477: URL: https://github.com/apache/arrow/pull/11477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] kszucs closed pull request #11478: ARROW-14397: [C++] Fix valgrind error in test utility

2021-10-20 Thread GitBox
kszucs closed pull request #11478: URL: https://github.com/apache/arrow/pull/11478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-datafusion] rdettai commented on pull request #1138: Multiple files per partitions for CSV Avro Json

2021-10-20 Thread GitBox
rdettai commented on pull request #1138: URL: https://github.com/apache/arrow-datafusion/pull/1138#issuecomment-947733378 thanks for the review Andrew! ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] ursabot edited a comment on pull request #11483: MINOR: [R] Fix sed for cross-OS compatibility

2021-10-20 Thread GitBox
ursabot edited a comment on pull request #11483: URL: https://github.com/apache/arrow/pull/11483#issuecomment-947723218 Benchmark runs are scheduled for baseline = ae943c3dc5b30487109cb415ff1e64db12d9a906 and contender = b2e1285334a7d927008014f2eff746e19fc9a892. b2e1285334a7d927008014f2ef

[GitHub] [arrow] niyue commented on a change in pull request #11486: Support reading arrow IPC file with fine grained IO

2021-10-20 Thread GitBox
niyue commented on a change in pull request #11486: URL: https://github.com/apache/arrow/pull/11486#discussion_r732846743 ## File path: cpp/src/arrow/ipc/reader.cc ## @@ -1529,7 +1569,6 @@ class StreamDecoder::StreamDecoderImpl : public MessageDecoderListener { } Statu

[GitHub] [arrow] niyue commented on a change in pull request #11486: Support reading arrow IPC file with fine grained IO

2021-10-20 Thread GitBox
niyue commented on a change in pull request #11486: URL: https://github.com/apache/arrow/pull/11486#discussion_r732845782 ## File path: cpp/src/arrow/ipc/reader.cc ## @@ -1070,7 +1096,19 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader { read_dictionari

[GitHub] [arrow] niyue commented on a change in pull request #11486: Support reading arrow IPC file with fine grained IO

2021-10-20 Thread GitBox
niyue commented on a change in pull request #11486: URL: https://github.com/apache/arrow/pull/11486#discussion_r732844808 ## File path: cpp/src/arrow/ipc/reader.cc ## @@ -1061,6 +1062,31 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader { return internal::

[GitHub] [arrow] niyue commented on a change in pull request #11486: Support reading arrow IPC file with fine grained IO

2021-10-20 Thread GitBox
niyue commented on a change in pull request #11486: URL: https://github.com/apache/arrow/pull/11486#discussion_r732840770 ## File path: cpp/src/arrow/ipc/message.cc ## @@ -308,8 +337,16 @@ Result> ReadMessage(int64_t offset, int32_t metadata_le "

[GitHub] [arrow] niyue commented on a change in pull request #11486: Support reading arrow IPC file with fine grained IO

2021-10-20 Thread GitBox
niyue commented on a change in pull request #11486: URL: https://github.com/apache/arrow/pull/11486#discussion_r732839467 ## File path: cpp/src/arrow/ipc/message.cc ## @@ -279,8 +279,37 @@ std::string FormatMessageType(MessageType type) { return "unknown"; } +Status ReadF

[GitHub] [arrow] kszucs merged pull request #11480: MINOR: [Docs] Uncomment the docs about file visitor when writing Datasets

2021-10-20 Thread GitBox
kszucs merged pull request #11480: URL: https://github.com/apache/arrow/pull/11480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] ursabot commented on pull request #11483: MINOR: [R] Fix sed for cross-OS compatibility

2021-10-20 Thread GitBox
ursabot commented on pull request #11483: URL: https://github.com/apache/arrow/pull/11483#issuecomment-947723218 Benchmark runs are scheduled for baseline = ae943c3dc5b30487109cb415ff1e64db12d9a906 and contender = b2e1285334a7d927008014f2eff746e19fc9a892. b2e1285334a7d927008014f2eff746e19

  1   2   3   >