[GitHub] [arrow] ElenaHenderson edited a comment on pull request #11496: ARROW-14406: [CI] Skip failing test on dask-master nightly build

2021-10-21 Thread GitBox
ElenaHenderson edited a comment on pull request #11496: URL: https://github.com/apache/arrow/pull/11496#issuecomment-949165311 Benchmark runs are scheduled for baseline = 0ce5b0d8af1b62a9518760a4f6a333c8b931998a and contender = 47f9176bd2b3c799ba417e0cf5a342f2f0c3e72b. 47f9176bd2b3c799ba4

[GitHub] [arrow-rs] xudong963 commented on a change in pull request #844: Implement boolean equality kernels

2021-10-21 Thread GitBox
xudong963 commented on a change in pull request #844: URL: https://github.com/apache/arrow-rs/pull/844#discussion_r734269930 ## File path: arrow/src/compute/kernels/comparison.rs ## @@ -623,6 +624,107 @@ pub fn eq_utf8_scalar( compare_op_scalar!(left, right, |a, b| a == b)

[GitHub] [arrow] AlenkaF commented on a change in pull request #11505: MINOR: [Docs][Python] Proposed changes for building pyarrow docs

2021-10-21 Thread GitBox
AlenkaF commented on a change in pull request #11505: URL: https://github.com/apache/arrow/pull/11505#discussion_r734268335 ## File path: docs/source/developers/cpp/building.rst ## @@ -121,9 +121,23 @@ argument is omitted then a release build will be produced. .. note:: -

[GitHub] [arrow] edponce commented on a change in pull request #11233: ARROW-13879: [C++] Mixed support for binary types in regex functions

2021-10-21 Thread GitBox
edponce commented on a change in pull request #11233: URL: https://github.com/apache/arrow/pull/11233#discussion_r734246320 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1235,52 +1267,53 @@ void AddMatchSubstring(FunctionRegistry* registry) { { aut

[GitHub] [arrow] ElenaHenderson edited a comment on pull request #11499: ARROW-14410: [Python][Packaging] Use numpy 1.21.3 to build python 3.10 wheels for macOS and windows

2021-10-21 Thread GitBox
ElenaHenderson edited a comment on pull request #11499: URL: https://github.com/apache/arrow/pull/11499#issuecomment-949165327 Benchmark runs are scheduled for baseline = 65c13132143ac183e3d01a7b41292cac2f33afd1 and contender = 721aa019aa0cb3b6a15aa358a53f39e2c5c541ae. 721aa019aa0cb3b6a15

[GitHub] [arrow] emkornfield commented on a change in pull request #11146: ARROW-13984: [Go][Parquet] file handling for go parquet, just the readers

2021-10-21 Thread GitBox
emkornfield commented on a change in pull request #11146: URL: https://github.com/apache/arrow/pull/11146#discussion_r734243758 ## File path: go/parquet/internal/bmi/bmi.go ## @@ -254,7 +254,7 @@ func extractBitsGo(bitmap, selectBitmap uint64) uint64 { for selectBitmap

[GitHub] [arrow] emkornfield commented on a change in pull request #11146: ARROW-13984: [Go][Parquet] file handling for go parquet, just the readers

2021-10-21 Thread GitBox
emkornfield commented on a change in pull request #11146: URL: https://github.com/apache/arrow/pull/11146#discussion_r734240013 ## File path: go/parquet/file/page_reader.go ## @@ -0,0 +1,616 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [arrow] emkornfield commented on a change in pull request #11146: ARROW-13984: [Go][Parquet] file handling for go parquet, just the readers

2021-10-21 Thread GitBox
emkornfield commented on a change in pull request #11146: URL: https://github.com/apache/arrow/pull/11146#discussion_r734239799 ## File path: go/parquet/file/page_reader.go ## @@ -0,0 +1,616 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [arrow] emkornfield commented on a change in pull request #11146: ARROW-13984: [Go][Parquet] file handling for go parquet, just the readers

2021-10-21 Thread GitBox
emkornfield commented on a change in pull request #11146: URL: https://github.com/apache/arrow/pull/11146#discussion_r734235844 ## File path: go/parquet/file/page_reader.go ## @@ -0,0 +1,616 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [arrow] emkornfield commented on a change in pull request #11146: ARROW-13984: [Go][Parquet] file handling for go parquet, just the readers

2021-10-21 Thread GitBox
emkornfield commented on a change in pull request #11146: URL: https://github.com/apache/arrow/pull/11146#discussion_r734235464 ## File path: go/parquet/file/page_reader.go ## @@ -0,0 +1,616 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [arrow] emkornfield commented on a change in pull request #11146: ARROW-13984: [Go][Parquet] file handling for go parquet, just the readers

2021-10-21 Thread GitBox
emkornfield commented on a change in pull request #11146: URL: https://github.com/apache/arrow/pull/11146#discussion_r734235367 ## File path: go/parquet/file/page_reader.go ## @@ -0,0 +1,616 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [arrow] emkornfield commented on a change in pull request #11146: ARROW-13984: [Go][Parquet] file handling for go parquet, just the readers

2021-10-21 Thread GitBox
emkornfield commented on a change in pull request #11146: URL: https://github.com/apache/arrow/pull/11146#discussion_r734234388 ## File path: go/parquet/file/level_conversion_test.go ## @@ -0,0 +1,194 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] emkornfield commented on a change in pull request #11146: ARROW-13984: [Go][Parquet] file handling for go parquet, just the readers

2021-10-21 Thread GitBox
emkornfield commented on a change in pull request #11146: URL: https://github.com/apache/arrow/pull/11146#discussion_r734233420 ## File path: go/parquet/file/level_conversion.go ## @@ -0,0 +1,274 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [arrow] ElenaHenderson edited a comment on pull request #11493: ARROW-14404: [Release][APT] Skip arm64 Debian GNU/Linux bookwarm verification

2021-10-21 Thread GitBox
ElenaHenderson edited a comment on pull request #11493: URL: https://github.com/apache/arrow/pull/11493#issuecomment-949165303 Benchmark runs are scheduled for baseline = 80f3433a04ab209ba38514578fd458a7e83a0aef and contender = 0ce5b0d8af1b62a9518760a4f6a333c8b931998a. 0ce5b0d8af1b62a9518

[GitHub] [arrow] emkornfield commented on a change in pull request #11146: ARROW-13984: [Go][Parquet] file handling for go parquet, just the readers

2021-10-21 Thread GitBox
emkornfield commented on a change in pull request #11146: URL: https://github.com/apache/arrow/pull/11146#discussion_r734230184 ## File path: go/parquet/file/level_conversion.go ## @@ -0,0 +1,274 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [arrow-datafusion] houqp closed issue #1157: Operation name not included in internal errors -- Internal("Data type Boolean not supported for binary operation on dyn arrays")

2021-10-21 Thread GitBox
houqp closed issue #1157: URL: https://github.com/apache/arrow-datafusion/issues/1157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] houqp merged pull request #1158: Improve error messages when operations are not supported

2021-10-21 Thread GitBox
houqp merged pull request #1158: URL: https://github.com/apache/arrow-datafusion/pull/1158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow] emkornfield commented on a change in pull request #11146: ARROW-13984: [Go][Parquet] file handling for go parquet, just the readers

2021-10-21 Thread GitBox
emkornfield commented on a change in pull request #11146: URL: https://github.com/apache/arrow/pull/11146#discussion_r734223970 ## File path: go/parquet/file/column_reader.go ## @@ -0,0 +1,485 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

[GitHub] [arrow-rs] Dandandan edited a comment on pull request #844: Implement boolean equality kernels

2021-10-21 Thread GitBox
Dandandan edited a comment on pull request #844: URL: https://github.com/apache/arrow-rs/pull/844#issuecomment-949023884 Also some new (good, unrelated) clippy error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] ElenaHenderson edited a comment on pull request #11503: ARROW-14417: [R] Joins ignore projection on left dataset

2021-10-21 Thread GitBox
ElenaHenderson edited a comment on pull request #11503: URL: https://github.com/apache/arrow/pull/11503#issuecomment-949165321 Benchmark runs are scheduled for baseline = 31b6d11c8ee9745b08c73a24ddaee2802f9a9426 and contender = 65c13132143ac183e3d01a7b41292cac2f33afd1. 65c13132143ac183e3d

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1143: Add output_partitions_size for CoalescePartitionsExec

2021-10-21 Thread GitBox
xudong963 commented on pull request #1143: URL: https://github.com/apache/arrow-datafusion/pull/1143#issuecomment-949242657 > Is this PR ready to merge? Or do you plan more work on it @xudong963 ? I plan to do more on it in the coming weekend😄 -- This is an automated message from t

[GitHub] [arrow] ElenaHenderson edited a comment on pull request #11492: ARROW-14402: [Release][Yum] Specify gpg path explicitly

2021-10-21 Thread GitBox
ElenaHenderson edited a comment on pull request #11492: URL: https://github.com/apache/arrow/pull/11492#issuecomment-949165363 Benchmark runs are scheduled for baseline = 5f895939474e22c1d185456d362d0146bbbd26f0 and contender = 80f3433a04ab209ba38514578fd458a7e83a0aef. 80f3433a04ab209ba38

[GitHub] [arrow] kou commented on pull request #11511: [Release] Verify release 6.0.0 RC3 [WIP]

2021-10-21 Thread GitBox
kou commented on pull request #11511: URL: https://github.com/apache/arrow/pull/11511#issuecomment-949232104 #11516 is for the verify-rc-binaries-apt-amd64 failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #11516: ARROW-14433: [Release][APT] Skip arm64 Ubuntu 21.04 verification

2021-10-21 Thread GitBox
github-actions[bot] commented on pull request #11516: URL: https://github.com/apache/arrow/pull/11516#issuecomment-949225312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] kou opened a new pull request #11516: ARROW-14433: [Release][APT] Skip arm64 Ubuntu 21.04 verification

2021-10-21 Thread GitBox
kou opened a new pull request #11516: URL: https://github.com/apache/arrow/pull/11516 qemu-user-static in Ubuntu 20.04 has a crash bug for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] ElenaHenderson edited a comment on pull request #11498: ARROW-14409: [Packaging][Python] Update the manylinux platform tags

2021-10-21 Thread GitBox
ElenaHenderson edited a comment on pull request #11498: URL: https://github.com/apache/arrow/pull/11498#issuecomment-949165316 Benchmark runs are scheduled for baseline = eee80f1fcb948d345456ecee80a3f65f103e3299 and contender = 31b6d11c8ee9745b08c73a24ddaee2802f9a9426. 31b6d11c8ee9745b08c

[GitHub] [arrow] ElenaHenderson edited a comment on pull request #11436: ARROW-14345: [C++] Implement streaming reads

2021-10-21 Thread GitBox
ElenaHenderson edited a comment on pull request #11436: URL: https://github.com/apache/arrow/pull/11436#issuecomment-949165346 Benchmark runs are scheduled for baseline = 4ac62d5527e5f1635764a62986589d694605d1d8 and contender = a8e1c81249aa2477fd0623e3cfd9d50ba2eba4fd. a8e1c81249aa2477fd0

[GitHub] [arrow] ElenaHenderson edited a comment on pull request #11488: ARROW-14400: [Go] Equals and ApproxEquals for Tables and Chunked Arrays

2021-10-21 Thread GitBox
ElenaHenderson edited a comment on pull request #11488: URL: https://github.com/apache/arrow/pull/11488#issuecomment-949165296 Benchmark runs are scheduled for baseline = a8e1c81249aa2477fd0623e3cfd9d50ba2eba4fd and contender = 9841dc864c62115d68706750b86ced5e142804f6. 9841dc864c62115d687

[GitHub] [arrow] ElenaHenderson edited a comment on pull request #11263: ARROW-12846: [Release] Reduce download/upload bandwidth for APT/Yum repositories

2021-10-21 Thread GitBox
ElenaHenderson edited a comment on pull request #11263: URL: https://github.com/apache/arrow/pull/11263#issuecomment-949165240 Benchmark runs are scheduled for baseline = b868090f0f65a2a66bb9c3d7c0f68c5af1a4dff0 and contender = 444cdac7d24968d5607495111e30330971be12b6. 444cdac7d24968d5607

[GitHub] [arrow] ElenaHenderson edited a comment on pull request #11032: ARROW-13465: [R] to_arrow() from duckdb

2021-10-21 Thread GitBox
ElenaHenderson edited a comment on pull request #11032: URL: https://github.com/apache/arrow/pull/11032#issuecomment-949165261 Benchmark runs are scheduled for baseline = 0059d6113ac1ab0db13733ea99ef0987c0a598a2 and contender = b868090f0f65a2a66bb9c3d7c0f68c5af1a4dff0. b868090f0f65a2a66bb

[GitHub] [arrow] ElenaHenderson commented on pull request #11436: ARROW-14345: [C++] Implement streaming reads

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11436: URL: https://github.com/apache/arrow/pull/11436#issuecomment-949165346 Benchmark runs are scheduled for baseline = 4ac62d5527e5f1635764a62986589d694605d1d8 and contender = a8e1c81249aa2477fd0623e3cfd9d50ba2eba4fd. a8e1c81249aa2477fd0623e3cf

[GitHub] [arrow] ElenaHenderson commented on pull request #11503: ARROW-14417: [R] Joins ignore projection on left dataset

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11503: URL: https://github.com/apache/arrow/pull/11503#issuecomment-949165321 Benchmark runs are scheduled for baseline = 31b6d11c8ee9745b08c73a24ddaee2802f9a9426 and contender = 65c13132143ac183e3d01a7b41292cac2f33afd1. 65c13132143ac183e3d01a7b41

[GitHub] [arrow] ElenaHenderson commented on pull request #11498: ARROW-14409: [Packaging][Python] Update the manylinux platform tags

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11498: URL: https://github.com/apache/arrow/pull/11498#issuecomment-949165316 Benchmark runs are scheduled for baseline = eee80f1fcb948d345456ecee80a3f65f103e3299 and contender = 31b6d11c8ee9745b08c73a24ddaee2802f9a9426. 31b6d11c8ee9745b08c73a24dd

[GitHub] [arrow] ElenaHenderson commented on pull request #11488: ARROW-14400: [Go] Equals and ApproxEquals for Tables and Chunked Arrays

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11488: URL: https://github.com/apache/arrow/pull/11488#issuecomment-949165296 Benchmark runs are scheduled for baseline = a8e1c81249aa2477fd0623e3cfd9d50ba2eba4fd and contender = 9841dc864c62115d68706750b86ced5e142804f6. 9841dc864c62115d68706750b8

[GitHub] [arrow] ElenaHenderson commented on pull request #11508: ARROW-14423: [Python] Fix version constraints in pyproject.toml

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11508: URL: https://github.com/apache/arrow/pull/11508#issuecomment-949165349 Benchmark runs are scheduled for baseline = 721aa019aa0cb3b6a15aa358a53f39e2c5c541ae and contender = 3347be7cba0782ff469042eea9bc3c81ea4178be. 3347be7cba0782ff469042eea9

[GitHub] [arrow] ElenaHenderson commented on pull request #11493: ARROW-14404: [Release][APT] Skip arm64 Debian GNU/Linux bookwarm verification

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11493: URL: https://github.com/apache/arrow/pull/11493#issuecomment-949165303 Benchmark runs are scheduled for baseline = 80f3433a04ab209ba38514578fd458a7e83a0aef and contender = 0ce5b0d8af1b62a9518760a4f6a333c8b931998a. 0ce5b0d8af1b62a9518760a4f6

[GitHub] [arrow] ElenaHenderson commented on pull request #11496: ARROW-14406: [CI] Skip failing test on dask-master nightly build

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11496: URL: https://github.com/apache/arrow/pull/11496#issuecomment-949165311 Benchmark runs are scheduled for baseline = 0ce5b0d8af1b62a9518760a4f6a333c8b931998a and contender = 47f9176bd2b3c799ba417e0cf5a342f2f0c3e72b. 47f9176bd2b3c799ba417e0cf5

[GitHub] [arrow] ElenaHenderson commented on pull request #11510: ARROW-14424: [Packaging][Python] Disable windows wheel testing for python 3.6

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11510: URL: https://github.com/apache/arrow/pull/11510#issuecomment-949165369 Benchmark runs are scheduled for baseline = 3347be7cba0782ff469042eea9bc3c81ea4178be and contender = bbb3106274b0dfd10b8f28ea5ffeabe072845411. bbb3106274b0dfd10b8f28ea5f

[GitHub] [arrow] ElenaHenderson commented on pull request #11499: ARROW-14410: [Python][Packaging] Use numpy 1.21.3 to build python 3.10 wheels for macOS and windows

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11499: URL: https://github.com/apache/arrow/pull/11499#issuecomment-949165327 Benchmark runs are scheduled for baseline = 65c13132143ac183e3d01a7b41292cac2f33afd1 and contender = 721aa019aa0cb3b6a15aa358a53f39e2c5c541ae. 721aa019aa0cb3b6a15aa358a5

[GitHub] [arrow] ElenaHenderson commented on pull request #11492: ARROW-14402: [Release][Yum] Specify gpg path explicitly

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11492: URL: https://github.com/apache/arrow/pull/11492#issuecomment-949165363 Benchmark runs are scheduled for baseline = 5f895939474e22c1d185456d362d0146bbbd26f0 and contender = 80f3433a04ab209ba38514578fd458a7e83a0aef. 80f3433a04ab209ba38514578f

[GitHub] [arrow] ElenaHenderson commented on pull request #11263: ARROW-12846: [Release] Reduce download/upload bandwidth for APT/Yum repositories

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11263: URL: https://github.com/apache/arrow/pull/11263#issuecomment-949165240 Benchmark runs are scheduled for baseline = b868090f0f65a2a66bb9c3d7c0f68c5af1a4dff0 and contender = 444cdac7d24968d5607495111e30330971be12b6. 444cdac7d24968d5607495111e

[GitHub] [arrow] ElenaHenderson commented on pull request #11490: ARROW-14408: [Packaging][Crossbow] Option for skipping artifact pattern validation

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11490: URL: https://github.com/apache/arrow/pull/11490#issuecomment-949165280 Benchmark runs are scheduled for baseline = 47f9176bd2b3c799ba417e0cf5a342f2f0c3e72b and contender = eee80f1fcb948d345456ecee80a3f65f103e3299. eee80f1fcb948d345456ecee80

[GitHub] [arrow] ElenaHenderson commented on pull request #11032: ARROW-13465: [R] to_arrow() from duckdb

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11032: URL: https://github.com/apache/arrow/pull/11032#issuecomment-949165261 Benchmark runs are scheduled for baseline = 0059d6113ac1ab0db13733ea99ef0987c0a598a2 and contender = b868090f0f65a2a66bb9c3d7c0f68c5af1a4dff0. b868090f0f65a2a66bb9c3d7c0

[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-10-21 Thread GitBox
ElenaHenderson removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-949161368 test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-949161368 test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9272: [WIP] Benchmark placebo

2021-10-21 Thread GitBox
ElenaHenderson removed a comment on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-949152498 test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-949152498 test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-datafusion] houqp commented on issue #970: Execute LogicalPlan on DBMS directly

2021-10-21 Thread GitBox
houqp commented on issue #970: URL: https://github.com/apache/arrow-datafusion/issues/970#issuecomment-949147706 > My concern with making additional changes to TableProvider is that it is fairly complicated already, so trying to encapsulate complexity elsewhere in the system might be a go

[GitHub] [arrow] westonpace commented on issue #11491: apache arrow c++: Ways to invalidate data

2021-10-21 Thread GitBox
westonpace commented on issue #11491: URL: https://github.com/apache/arrow/issues/11491#issuecomment-949134966 > Thank you for your response! I'm particularly interested in the third option. Would you mind showing me some hint about how that is done? Do you mean the compute functions

[GitHub] [arrow] westonpace commented on issue #11491: apache arrow c++: Ways to invalidate data

2021-10-21 Thread GitBox
westonpace commented on issue #11491: URL: https://github.com/apache/arrow/issues/11491#issuecomment-949118472 Ah, it seems you can do `array->data()->SetNullCount(new_null_count);` but you will be responsible for doing the math to compute the new null count. If the null count is wrong th

[GitHub] [arrow] westonpace commented on issue #11491: apache arrow c++: Ways to invalidate data

2021-10-21 Thread GitBox
westonpace commented on issue #11491: URL: https://github.com/apache/arrow/issues/11491#issuecomment-949114696 > I wonder if there is an API in Apache Arrow, or an ad-hoc solution, to change this validity map after the construction of arrow::Array so that this will invalidate some elements

[GitHub] [arrow] kou commented on pull request #11512: MINOR: [Release] Fix debian:bookwarm typo in the release verification script

2021-10-21 Thread GitBox
kou commented on pull request #11512: URL: https://github.com/apache/arrow/pull/11512#issuecomment-949113435 Oh... Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [arrow] ElenaHenderson commented on pull request #11496: ARROW-14406: [CI] Skip failing test on dask-master nightly build

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11496: URL: https://github.com/apache/arrow/pull/11496#issuecomment-949106349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [arrow] ElenaHenderson commented on pull request #11490: ARROW-14408: [Packaging][Crossbow] Option for skipping artifact pattern validation

2021-10-21 Thread GitBox
ElenaHenderson commented on pull request #11490: URL: https://github.com/apache/arrow/pull/11490#issuecomment-949106294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [arrow] OscarTHZhang commented on issue #11491: apache arrow c++: Ways to invalidate data

2021-10-21 Thread GitBox
OscarTHZhang commented on issue #11491: URL: https://github.com/apache/arrow/issues/11491#issuecomment-949096886 I came across this example: http://arrow.apache.org/docs/cpp/arrays.html#performance ```c++ arrow::Int64Builder builder; // Make place for 8 values in total builder.

[GitHub] [arrow] westonpace commented on issue #11500: pyarrow: read_feather failed when using pandas.Index as `columns` parameter

2021-10-21 Thread GitBox
westonpace commented on issue #11500: URL: https://github.com/apache/arrow/issues/11500#issuecomment-949095282 Technically the sequence protocol does not define equality. The problem seems to originate from the line `sorted(set(columns)) == columns`. We are relying on `list == sequence =

[GitHub] [arrow] kszucs merged pull request #11513: MINOR: [Release] Force reinstall manylinux2014 wheel after the manylinux2010 one during the verification

2021-10-21 Thread GitBox
kszucs merged pull request #11513: URL: https://github.com/apache/arrow/pull/11513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] r0b3rt24 commented on issue #11491: apache arrow c++: Ways to invalidate data

2021-10-21 Thread GitBox
r0b3rt24 commented on issue #11491: URL: https://github.com/apache/arrow/issues/11491#issuecomment-949086156 > So a few options jump to mind. I think my answer would sort of depend on what you plan to do with the array after you've deleted the rows. Also, what language are you working with

[GitHub] [arrow] github-actions[bot] commented on pull request #11515: ARROW-14431: [C++][Gandiva] Implement AES ENCRYPT and AES DECRYPT functions

2021-10-21 Thread GitBox
github-actions[bot] commented on pull request #11515: URL: https://github.com/apache/arrow/pull/11515#issuecomment-949085886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] augustoasilva opened a new pull request #11515: ARROW-14431: [C++][Gandiva] Implement AES ENCRYPT and AES DECRYPT functions

2021-10-21 Thread GitBox
augustoasilva opened a new pull request #11515: URL: https://github.com/apache/arrow/pull/11515 Encrypt, or decrypt, input using AES. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] westonpace edited a comment on issue #11491: apache arrow c++: Ways to invalidate data

2021-10-21 Thread GitBox
westonpace edited a comment on issue #11491: URL: https://github.com/apache/arrow/issues/11491#issuecomment-949082960 So a few options jump to mind. I think my answer would sort of depend on what you plan to do with the array after you've deleted the rows. Also, what language are you wor

[GitHub] [arrow] westonpace commented on issue #11491: apache arrow c++: Ways to invalidate data

2021-10-21 Thread GitBox
westonpace commented on issue #11491: URL: https://github.com/apache/arrow/issues/11491#issuecomment-949082960 So a few options jump to mind. I think my answer would sort of depend on what you plan to do with the array after you've deleted the rows. Also, what language are you working wi

[GitHub] [arrow-datafusion] kszucs edited a comment on pull request #873: Rework the python bindings using conversion traits from arrow-rs

2021-10-21 Thread GitBox
kszucs edited a comment on pull request #873: URL: https://github.com/apache/arrow-datafusion/pull/873#issuecomment-949080513 @houqp sorry, I was busy with the (other) 6.0 release. I'll try to rebase it (hopefully) tomorrow. -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow-datafusion] kszucs commented on pull request #873: Rework the python bindings using conversion traits from arrow-rs

2021-10-21 Thread GitBox
kszucs commented on pull request #873: URL: https://github.com/apache/arrow-datafusion/pull/873#issuecomment-949080513 @houqp sorry, I was busy with the 6.0 release. I'll try to rebase it (hopefully) tomorrow. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] kszucs merged pull request #11512: MINOR: [Release] Fix debian:bookwarm typo in the release verification script

2021-10-21 Thread GitBox
kszucs merged pull request #11512: URL: https://github.com/apache/arrow/pull/11512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] github-actions[bot] commented on pull request #11514: ARROW-14430: [Go] Basic Expression, Field Reference and Datum handling

2021-10-21 Thread GitBox
github-actions[bot] commented on pull request #11514: URL: https://github.com/apache/arrow/pull/11514#issuecomment-949074577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] zeroshade opened a new pull request #11514: ARROW-14430: [Go] Basic Expression, Field Reference and Datum handling

2021-10-21 Thread GitBox
zeroshade opened a new pull request #11514: URL: https://github.com/apache/arrow/pull/11514 This is for preparation of connecting to the Compute API, building out the support for Datums, Field Referencing and Field Paths, and Expression handling. -- This is an automated message from the

[GitHub] [arrow] github-actions[bot] commented on pull request #11511: [Release] Verify release 6.0.0 RC3 [WIP]

2021-10-21 Thread GitBox
github-actions[bot] commented on pull request #11511: URL: https://github.com/apache/arrow/pull/11511#issuecomment-949073390 Revision: 34fc62d67419838e46a21a6afa9962fbc312549f Submitted crossbow builds: [ursacomputing/crossbow @ actions-1042](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] kszucs commented on pull request #11511: [Release] Verify release 6.0.0 RC3 [WIP]

2021-10-21 Thread GitBox
kszucs commented on pull request #11511: URL: https://github.com/apache/arrow/pull/11511#issuecomment-949072964 @github-actions crossbow submit verify-rc-wheels-linux-amd64 --param release=6.0.0 --param rc=3 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [arrow] github-actions[bot] commented on pull request #11511: [Release] Verify release 6.0.0 RC3 [WIP]

2021-10-21 Thread GitBox
github-actions[bot] commented on pull request #11511: URL: https://github.com/apache/arrow/pull/11511#issuecomment-949069537 Revision: c061142ad18d825a7bce732cf027d7f71a0fbe52 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1041](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] kszucs commented on pull request #11511: [Release] Verify release 6.0.0 RC3 [WIP]

2021-10-21 Thread GitBox
kszucs commented on pull request #11511: URL: https://github.com/apache/arrow/pull/11511#issuecomment-949069141 @github-actions crossbow submit verify-rc-binaries-apt-amd64 --param release=6.0.0 --param rc=3 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [arrow] kszucs removed a comment on pull request #11511: [Release] Verify release 6.0.0 RC3 [WIP]

2021-10-21 Thread GitBox
kszucs removed a comment on pull request #11511: URL: https://github.com/apache/arrow/pull/11511#issuecomment-949068905 @github-actions crossbow submit verify-rc-binaries-apt-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [arrow] kszucs commented on pull request #11511: [Release] Verify release 6.0.0 RC3 [WIP]

2021-10-21 Thread GitBox
kszucs commented on pull request #11511: URL: https://github.com/apache/arrow/pull/11511#issuecomment-949068905 @github-actions crossbow submit verify-rc-binaries-apt-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] augustoasilva commented on a change in pull request #11193: ARROW-14048: [C++][Gandiva] Cache only object code in memory instead of entire module

2021-10-21 Thread GitBox
augustoasilva commented on a change in pull request #11193: URL: https://github.com/apache/arrow/pull/11193#discussion_r734102208 ## File path: cpp/src/gandiva/projector.cc ## @@ -174,13 +93,11 @@ Status Projector::Make(SchemaPtr schema, const ExpressionVector& exprs, ARR

[GitHub] [arrow] augustoasilva commented on a change in pull request #11193: ARROW-14048: [C++][Gandiva] Cache only object code in memory instead of entire module

2021-10-21 Thread GitBox
augustoasilva commented on a change in pull request #11193: URL: https://github.com/apache/arrow/pull/11193#discussion_r734101093 ## File path: cpp/src/gandiva/gandiva_object_cache.h ## @@ -0,0 +1,84 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] westonpace commented on a change in pull request #11233: ARROW-13879: [C++] Mixed support for binary types in regex functions

2021-10-21 Thread GitBox
westonpace commented on a change in pull request #11233: URL: https://github.com/apache/arrow/pull/11233#discussion_r734096663 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1303,21 +1336,22 @@ struct FindSubstring { struct FindSubstringRegex { std::uni

[GitHub] [arrow] augustoasilva commented on a change in pull request #11193: ARROW-14048: [C++][Gandiva] Cache only object code in memory instead of entire module

2021-10-21 Thread GitBox
augustoasilva commented on a change in pull request #11193: URL: https://github.com/apache/arrow/pull/11193#discussion_r734100866 ## File path: cpp/src/gandiva/projector.cc ## @@ -174,13 +93,11 @@ Status Projector::Make(SchemaPtr schema, const ExpressionVector& exprs, ARR

[GitHub] [arrow] thisisnic commented on pull request #11506: ARROW-14416: [R] Fix package installation on the Raspberry Pi

2021-10-21 Thread GitBox
thisisnic commented on pull request #11506: URL: https://github.com/apache/arrow/pull/11506#issuecomment-949050627 Thanks @westonpace, that's really helpful context! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] github-actions[bot] commented on pull request #11511: [Release] Verify release 6.0.0 RC3 [WIP]

2021-10-21 Thread GitBox
github-actions[bot] commented on pull request #11511: URL: https://github.com/apache/arrow/pull/11511#issuecomment-949048598 Revision: 5a5f4ce326194750422ef6f053469ed1912ce69f Submitted crossbow builds: [ursacomputing/crossbow @ actions-1040](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] wojciech-sneller commented on issue #11509: Reading parquet files with the Go library

2021-10-21 Thread GitBox
wojciech-sneller commented on issue #11509: URL: https://github.com/apache/arrow/issues/11509#issuecomment-949048190 Thank you for the answer, I'll check the branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] kszucs commented on pull request #11511: [Release] Verify release 6.0.0 RC3 [WIP]

2021-10-21 Thread GitBox
kszucs commented on pull request #11511: URL: https://github.com/apache/arrow/pull/11511#issuecomment-949048176 @github-actions crossbow submit --group verify-rc-binaries --group verify-rc-wheels --param release=6.0.0 --param rc=3 -- This is an automated message from the Apache Git Servi

[GitHub] [arrow] westonpace commented on pull request #11506: ARROW-14416: [R] Fix package installation on the Raspberry Pi

2021-10-21 Thread GitBox
westonpace commented on pull request #11506: URL: https://github.com/apache/arrow/pull/11506#issuecomment-949047972 We do have CI for ARM. Raspberry Pi uses an Armv8-A processor. The Travis CI runs on Armv8.2-A. So it is pretty close. This bug wasn't caught because the glibc on raspber

[GitHub] [arrow] westonpace commented on a change in pull request #11505: MINOR: [Docs][Python] Proposed changes for building pyarrow docs

2021-10-21 Thread GitBox
westonpace commented on a change in pull request #11505: URL: https://github.com/apache/arrow/pull/11505#discussion_r734077844 ## File path: docs/source/developers/python.rst ## @@ -106,8 +108,8 @@ Building on Linux and MacOS System Requirements --- -On macO

[GitHub] [arrow] emkornfield commented on pull request #11146: ARROW-13984: [Go][Parquet] file handling for go parquet, just the readers

2021-10-21 Thread GitBox
emkornfield commented on pull request #11146: URL: https://github.com/apache/arrow/pull/11146#issuecomment-949037800 sorry for the delay will aim to take a pass tonight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] westonpace commented on a change in pull request #11505: MINOR: [Docs][Python] Proposed changes for building pyarrow docs

2021-10-21 Thread GitBox
westonpace commented on a change in pull request #11505: URL: https://github.com/apache/arrow/pull/11505#discussion_r734075744 ## File path: docs/source/developers/cpp/building.rst ## @@ -121,9 +121,23 @@ argument is omitted then a release build will be produced. .. note::

[GitHub] [arrow] zeroshade commented on issue #11509: Reading parquet files with the Go library

2021-10-21 Thread GitBox
zeroshade commented on issue #11509: URL: https://github.com/apache/arrow/issues/11509#issuecomment-949031668 @WojciechMula The file readers are actually currently in the PR #11146 and haven't been merged yet. In your module if you run `go mod edit -replace github.com/apache/arrow/go/parqu

[GitHub] [arrow-rs] Dandandan commented on pull request #844: Implement boolean equality kernels

2021-10-21 Thread GitBox
Dandandan commented on pull request #844: URL: https://github.com/apache/arrow-rs/pull/844#issuecomment-949023884 Also some new (good) clippy error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] thisisnic edited a comment on pull request #11506: ARROW-14416: [R] Fix package installation on the Raspberry Pi

2021-10-21 Thread GitBox
thisisnic edited a comment on pull request #11506: URL: https://github.com/apache/arrow/pull/11506#issuecomment-949014520 > BTW Is there a CI available for raspberry? There is not. Last time I checked it wasn't possible for technical reasons I don't fully recall or understand, sorry

[GitHub] [arrow] thisisnic edited a comment on pull request #11506: ARROW-14416: [R] Fix package installation on the Raspberry Pi

2021-10-21 Thread GitBox
thisisnic edited a comment on pull request #11506: URL: https://github.com/apache/arrow/pull/11506#issuecomment-949014520 > BTW Is there a CI available for raspberry? There is not. Last time I checked it wasn't possible for technical reasons I don't fully recall or understand, sorry

[GitHub] [arrow-rs] Dandandan commented on issue #842: Add boolean equality and inequality kernels

2021-10-21 Thread GitBox
Dandandan commented on issue #842: URL: https://github.com/apache/arrow-rs/issues/842#issuecomment-949016939 > > Seems to me we can/should implement this with bitwise operations, i.e. !(x ^ y) > > I assume you mean calculate more than one element of each array at a time (like do it

[GitHub] [arrow] thisisnic commented on pull request #11506: ARROW-14416: [R] Fix package installation on the Raspberry Pi

2021-10-21 Thread GitBox
thisisnic commented on pull request #11506: URL: https://github.com/apache/arrow/pull/11506#issuecomment-949014520 > BTW Is there a CI available for raspberry? There is not. Last time I checked it wasn't possible for technical reasons I don't fully recall or understand, sorry. --

[GitHub] [arrow] kszucs commented on pull request #11506: ARROW-14416: [R] Fix package installation on the Raspberry Pi

2021-10-21 Thread GitBox
kszucs commented on pull request #11506: URL: https://github.com/apache/arrow/pull/11506#issuecomment-949011311 BTW Is there a CI available for raspberry? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-rs] Dandandan commented on pull request #844: Implement boolean equality kernels

2021-10-21 Thread GitBox
Dandandan commented on pull request #844: URL: https://github.com/apache/arrow-rs/pull/844#issuecomment-949010556 We have some formatting differences in some tests it seems from a rust version upgrade (?). -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [arrow] thisisnic edited a comment on pull request #11506: ARROW-14416: [R] Fix package installation on the Raspberry Pi

2021-10-21 Thread GitBox
thisisnic edited a comment on pull request #11506: URL: https://github.com/apache/arrow/pull/11506#issuecomment-949010254 @kszucs I'd absolutely love to if it's tested on time, but it has not been tested yet as I need to manually send the package over to the R4Pi team to see if it works as

[GitHub] [arrow] thisisnic commented on pull request #11506: ARROW-14416: [R] Fix package installation on the Raspberry Pi

2021-10-21 Thread GitBox
thisisnic commented on pull request #11506: URL: https://github.com/apache/arrow/pull/11506#issuecomment-949010254 @kszucs I'd absolutely love to if it's tested on time, but it has not been tested yet as I need to manually send the package over to the R4Pi team to see if it works as I don'

[GitHub] [arrow-rs] Dandandan commented on a change in pull request #844: Implement boolean equality kernels

2021-10-21 Thread GitBox
Dandandan commented on a change in pull request #844: URL: https://github.com/apache/arrow-rs/pull/844#discussion_r734048068 ## File path: arrow/src/compute/kernels/comparison.rs ## @@ -623,6 +624,107 @@ pub fn eq_utf8_scalar( compare_op_scalar!(left, right, |a, b| a == b)

[GitHub] [arrow-rs] Dandandan commented on a change in pull request #844: Implement boolean equality kernels

2021-10-21 Thread GitBox
Dandandan commented on a change in pull request #844: URL: https://github.com/apache/arrow-rs/pull/844#discussion_r734046485 ## File path: arrow/src/compute/kernels/comparison.rs ## @@ -623,6 +624,107 @@ pub fn eq_utf8_scalar( compare_op_scalar!(left, right, |a, b| a == b)

[GitHub] [arrow-rs] Dandandan opened a new pull request #844: Implement boolean equality kernels

2021-10-21 Thread GitBox
Dandandan opened a new pull request #844: URL: https://github.com/apache/arrow-rs/pull/844 # Which issue does this PR close? Closes #842 # Rationale for this change Implementing (fast) equality kernels for booleans. # What changes are included in this PR? I

[GitHub] [arrow] edponce commented on a change in pull request #11505: MINOR: [Docs][Python] Proposed changes for building pyarrow docs

2021-10-21 Thread GitBox
edponce commented on a change in pull request #11505: URL: https://github.com/apache/arrow/pull/11505#discussion_r734036143 ## File path: docs/source/developers/cpp/building.rst ## @@ -121,9 +121,23 @@ argument is omitted then a release build will be produced. .. note:: -

[GitHub] [arrow] ursabot edited a comment on pull request #11436: ARROW-14345: [C++] Implement streaming reads

2021-10-21 Thread GitBox
ursabot edited a comment on pull request #11436: URL: https://github.com/apache/arrow/pull/11436#issuecomment-947933699 Benchmark runs are scheduled for baseline = 4ac62d5527e5f1635764a62986589d694605d1d8 and contender = a8e1c81249aa2477fd0623e3cfd9d50ba2eba4fd. a8e1c81249aa2477fd0623e3cf

  1   2   3   4   >