cyb70289 commented on pull request #11524:
URL: https://github.com/apache/arrow/pull/11524#issuecomment-954477426
Thanks @lidavidm , the test program is working fine on my side.
One last issue is that grpc reflection is broken on ubuntu.
grpcurl fails with `server does not support
emkornfield commented on pull request #11570:
URL: https://github.com/apache/arrow/pull/11570#issuecomment-954474900
So we will need to make this broad change on every release? I'm not an
expert enough in go to know if this is wise. At the very least for such a
large change, we should pr
ursabot edited a comment on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-954152078
Benchmark runs are scheduled for baseline =
faafc51840143635eb06957ccbb8d3669aa30c1d and contender =
2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf.
2ae84e8e90a7c0d8cd37df07d6
ursabot edited a comment on pull request #11440:
URL: https://github.com/apache/arrow/pull/11440#issuecomment-953983626
Benchmark runs are scheduled for baseline =
f2c9d20d96377226d44c9f429d52b99f48b2969c and contender =
b09914ea0baea59cbb00f70d2fe438eb21ad6d18.
b09914ea0baea59cbb00f70d2f
houqp commented on a change in pull request #873:
URL: https://github.com/apache/arrow-datafusion/pull/873#discussion_r738950355
##
File path: python/src/dataframe.rs
##
@@ -15,174 +15,94 @@
// specific language governing permissions and limitations
// under the License.
-u
houqp commented on a change in pull request #873:
URL: https://github.com/apache/arrow-datafusion/pull/873#discussion_r738949791
##
File path: python/src/lib.rs
##
@@ -17,42 +17,45 @@
use pyo3::prelude::*;
+mod catalog;
mod context;
mod dataframe;
mod errors;
mod expre
ursabot edited a comment on pull request #11440:
URL: https://github.com/apache/arrow/pull/11440#issuecomment-953983626
Benchmark runs are scheduled for baseline =
f2c9d20d96377226d44c9f429d52b99f48b2969c and contender =
b09914ea0baea59cbb00f70d2fe438eb21ad6d18.
b09914ea0baea59cbb00f70d2f
ursabot edited a comment on pull request #11568:
URL: https://github.com/apache/arrow/pull/11568#issuecomment-953998565
Benchmark runs are scheduled for baseline =
9ebc594e959c9a88ede0f5672e8614b41d8f77d4 and contender =
34fcb3847efe8f2d153bd3893d868f72b4e8a55b.
34fcb3847efe8f2d153bd3893d
ursabot edited a comment on pull request #11568:
URL: https://github.com/apache/arrow/pull/11568#issuecomment-953998565
Benchmark runs are scheduled for baseline =
9ebc594e959c9a88ede0f5672e8614b41d8f77d4 and contender =
34fcb3847efe8f2d153bd3893d868f72b4e8a55b.
34fcb3847efe8f2d153bd3893d
ursabot edited a comment on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-954152078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
ursabot edited a comment on pull request #11539:
URL: https://github.com/apache/arrow/pull/11539#issuecomment-954042044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
ursabot edited a comment on pull request #11403:
URL: https://github.com/apache/arrow/pull/11403#issuecomment-953995413
Benchmark runs are scheduled for baseline =
b09914ea0baea59cbb00f70d2fe438eb21ad6d18 and contender =
9ebc594e959c9a88ede0f5672e8614b41d8f77d4.
9ebc594e959c9a88ede0f5672e
ursabot edited a comment on pull request #11403:
URL: https://github.com/apache/arrow/pull/11403#issuecomment-953995413
Benchmark runs are scheduled for baseline =
b09914ea0baea59cbb00f70d2fe438eb21ad6d18 and contender =
9ebc594e959c9a88ede0f5672e8614b41d8f77d4.
9ebc594e959c9a88ede0f5672e
ursabot edited a comment on pull request #11440:
URL: https://github.com/apache/arrow/pull/11440#issuecomment-953983626
Benchmark runs are scheduled for baseline =
f2c9d20d96377226d44c9f429d52b99f48b2969c and contender =
b09914ea0baea59cbb00f70d2fe438eb21ad6d18.
b09914ea0baea59cbb00f70d2f
saethlin commented on pull request #878:
URL: https://github.com/apache/arrow-rs/pull/878#issuecomment-954433889
This should also close https://github.com/apache/arrow-rs/issues/614
Also I have no idea what's going on with the miri run in CI. I've never seen
that error before 😔
--
ursabot edited a comment on pull request #11539:
URL: https://github.com/apache/arrow/pull/11539#issuecomment-954042044
Benchmark runs are scheduled for baseline =
34fcb3847efe8f2d153bd3893d868f72b4e8a55b and contender =
faafc51840143635eb06957ccbb8d3669aa30c1d.
faafc51840143635eb06957ccb
ursabot edited a comment on pull request #11526:
URL: https://github.com/apache/arrow/pull/11526#issuecomment-953836620
Benchmark runs are scheduled for baseline =
aa34c4fbbc43c311fb16b23af8a7493fa86045f1 and contender =
f2c9d20d96377226d44c9f429d52b99f48b2969c.
f2c9d20d96377226d44c9f429d
niyue edited a comment on pull request #11486:
URL: https://github.com/apache/arrow/pull/11486#issuecomment-954339392
@westonpace
> I would like a unit test showing that a RecordBatchFileReader truly does
not read the entire file
Sure. Let me see how I can add more tests for it.
ursabot edited a comment on pull request #11568:
URL: https://github.com/apache/arrow/pull/11568#issuecomment-953998565
Benchmark runs are scheduled for baseline =
9ebc594e959c9a88ede0f5672e8614b41d8f77d4 and contender =
34fcb3847efe8f2d153bd3893d868f72b4e8a55b.
34fcb3847efe8f2d153bd3893d
westonpace commented on pull request #11486:
URL: https://github.com/apache/arrow/pull/11486#issuecomment-954355732
> ArrayLoader involves quite a lot arrow structures, and I am not familiar
with some of them, so I try to follow current organization to make it work so
far.
Ok. That
ursabot edited a comment on pull request #11561:
URL: https://github.com/apache/arrow/pull/11561#issuecomment-953724842
Benchmark runs are scheduled for baseline =
905cb784e257a5fd621ebbf176c6c6f9acd94ba4 and contender =
aa34c4fbbc43c311fb16b23af8a7493fa86045f1.
aa34c4fbbc43c311fb16b23af8
niyue commented on pull request #11486:
URL: https://github.com/apache/arrow/pull/11486#issuecomment-954340112
@lidavidm
> we will want a unit test to ensure the bytes read is as expected
Sure. I will look into it how more unit tests can be added.
> Additionally, another ca
niyue edited a comment on pull request #11486:
URL: https://github.com/apache/arrow/pull/11486#issuecomment-954339392
@westonpace
> I would like a unit test showing that a RecordBatchFileReader truly does
not read the entire file
Sure. Let me see how I can add more tests for it.
niyue commented on pull request #11486:
URL: https://github.com/apache/arrow/pull/11486#issuecomment-954339392
@westonpace
> I would like a unit test showing that a RecordBatchFileReader truly does
not read the entire file
Sure. Let me see how I can add more tests for it.
> M
zeroshade edited a comment on pull request #11570:
URL: https://github.com/apache/arrow/pull/11570#issuecomment-954334003
@kou the philosophy for go is that major version upgrades are only ever done
for breaking changes, if it's not a breaking change then it shouldn't be a
major version up
zeroshade edited a comment on pull request #11570:
URL: https://github.com/apache/arrow/pull/11570#issuecomment-954334003
@kou the philosophy for go is that major version upgrades are only ever done
for breaking changes, if it's not a breaking change then it shouldn't be a
major version up
zeroshade edited a comment on pull request #11570:
URL: https://github.com/apache/arrow/pull/11570#issuecomment-954334003
@kou the philosophy for go is that major version upgrades are only ever done
for breaking changes, if it's not a breaking change then it shouldn't be a
major version up
zeroshade commented on pull request #11570:
URL: https://github.com/apache/arrow/pull/11570#issuecomment-954334003
@kou the philosophy for go is that major version upgrades are only ever done
for breaking changes, if it's not a breaking change then it shouldn't be a
major version upgrade.
ursabot edited a comment on pull request #11403:
URL: https://github.com/apache/arrow/pull/11403#issuecomment-953995413
Benchmark runs are scheduled for baseline =
b09914ea0baea59cbb00f70d2fe438eb21ad6d18 and contender =
9ebc594e959c9a88ede0f5672e8614b41d8f77d4.
9ebc594e959c9a88ede0f5672e
saethlin opened a new pull request #878:
URL: https://github.com/apache/arrow-rs/pull/878
# Which issue does this PR close?
Closes https://github.com/apache/arrow-rs/issues/877.
# What changes are included in this PR?
This fixes the UB in the parquet `bit_util` modules by explic
saethlin opened a new issue #877:
URL: https://github.com/apache/arrow-rs/issues/877
**Describe the bug**
The parquet `bit_packing` module does misaligned reads through a raw
pointer, and `murmur_hash2_64a` constructs a misaligned reference. It's unclear
to me if these qualify as securi
kou commented on pull request #11570:
URL: https://github.com/apache/arrow/pull/11570#issuecomment-954319935
I'm sorry but I'm not familiar with Go. (@emkornfield are you familiar with
Go?)
I'm not sure whether this change is backward incompatible change or not.
Could you tell me
ursabot edited a comment on pull request #11560:
URL: https://github.com/apache/arrow/pull/11560#issuecomment-953724832
Benchmark runs are scheduled for baseline =
08ed9ad9706052c4ff7898f1860cd5ef044db0ae and contender =
905cb784e257a5fd621ebbf176c6c6f9acd94ba4.
905cb784e257a5fd621ebbf176
ursabot edited a comment on pull request #11440:
URL: https://github.com/apache/arrow/pull/11440#issuecomment-953983626
Benchmark runs are scheduled for baseline =
f2c9d20d96377226d44c9f429d52b99f48b2969c and contender =
b09914ea0baea59cbb00f70d2fe438eb21ad6d18.
b09914ea0baea59cbb00f70d2f
zeroshade commented on pull request #11570:
URL: https://github.com/apache/arrow/pull/11570#issuecomment-954268795
@kou i've updated this PR to switch the arrow and parquet packages from
being two separate modules to a single module with two packages. This means
that they can more easily b
zeroshade commented on a change in pull request #11570:
URL: https://github.com/apache/arrow/pull/11570#discussion_r738807666
##
File path: go/parquet/writer_properties.go
##
@@ -18,7 +18,7 @@ package parquet
import (
"github.com/apache/arrow/go/arrow/memory"
Review
ursabot edited a comment on pull request #11563:
URL: https://github.com/apache/arrow/pull/11563#issuecomment-953722900
Benchmark runs are scheduled for baseline =
0f3e36e6b8d2d583dd7089c9e290de56981de1db and contender =
08ed9ad9706052c4ff7898f1860cd5ef044db0ae.
08ed9ad9706052c4ff7898f186
lidavidm commented on a change in pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#discussion_r738781330
##
File path: cpp/src/arrow/flight/flight-sql/CMakeLists.txt
##
@@ -0,0 +1,116 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mor
ursabot edited a comment on pull request #11526:
URL: https://github.com/apache/arrow/pull/11526#issuecomment-953836620
Benchmark runs are scheduled for baseline =
aa34c4fbbc43c311fb16b23af8a7493fa86045f1 and contender =
f2c9d20d96377226d44c9f429d52b99f48b2969c.
f2c9d20d96377226d44c9f429d
kou commented on a change in pull request #11570:
URL: https://github.com/apache/arrow/pull/11570#discussion_r738779545
##
File path: go/parquet/writer_properties.go
##
@@ -18,7 +18,7 @@ package parquet
import (
"github.com/apache/arrow/go/arrow/memory"
Review comme
lidavidm commented on pull request #11541:
URL: https://github.com/apache/arrow/pull/11541#issuecomment-954220825
@jorisvandenbossche sorry for the ping, any other comments here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
lidavidm commented on pull request #11486:
URL: https://github.com/apache/arrow/pull/11486#issuecomment-954218790
Broadly I'm in agreement. I like the approach here but it does seem we will
want to 'fuse' some of the layers to get the best implementation. The
duplication with the asynchron
rafael-telles commented on pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#issuecomment-954214713
That's OK! Now that we addresses most of the other comments I will try to
solve this too. Thank you so much!
--
This is an automated message from the Apache Git Service.
lidavidm commented on a change in pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#discussion_r738772484
##
File path: cpp/src/arrow/flight/flight-sql/CMakeLists.txt
##
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mor
westonpace commented on pull request #11486:
URL: https://github.com/apache/arrow/pull/11486#issuecomment-954213912
@lidavidm Thoughts on the above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rafael-telles commented on a change in pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#discussion_r738771833
##
File path: cpp/src/arrow/flight/flight-sql/CMakeLists.txt
##
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# o
rafael-telles commented on a change in pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#discussion_r738770207
##
File path: cpp/src/arrow/flight/flight-sql/client.h
##
@@ -0,0 +1,260 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
rdettai commented on a change in pull request #1141:
URL: https://github.com/apache/arrow-datafusion/pull/1141#discussion_r738768467
##
File path: ballista/rust/core/src/serde/physical_plan/to_proto.rs
##
@@ -722,3 +675,32 @@ impl From<&Statistics> for protobuf::Statistics {
rdettai commented on a change in pull request #1141:
URL: https://github.com/apache/arrow-datafusion/pull/1141#discussion_r738766844
##
File path: ballista/rust/core/src/serde/physical_plan/to_proto.rs
##
@@ -244,90 +246,29 @@ impl TryInto for Arc {
))),
lidavidm commented on a change in pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#discussion_r738766458
##
File path: cpp/src/arrow/flight/flight-sql/CMakeLists.txt
##
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mor
alamb commented on a change in pull request #1141:
URL: https://github.com/apache/arrow-datafusion/pull/1141#discussion_r738724739
##
File path: ballista/rust/core/proto/ballista.proto
##
@@ -613,33 +614,28 @@ message ScanLimit {
uint32 limit = 1;
}
-message ParquetScanEx
JrJuscelino commented on a change in pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#discussion_r738764984
##
File path: cpp/src/arrow/flight/flight-sql/CMakeLists.txt
##
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
ursabot edited a comment on pull request #11383:
URL: https://github.com/apache/arrow/pull/11383#issuecomment-953517310
Benchmark runs are scheduled for baseline =
61a22124eb86737fee96f1a8b485b3ad5cff8d31 and contender =
0f3e36e6b8d2d583dd7089c9e290de56981de1db.
0f3e36e6b8d2d583dd7089c9e2
github-actions[bot] commented on pull request #11571:
URL: https://github.com/apache/arrow/pull/11571#issuecomment-954204316
https://issues.apache.org/jira/browse/ARROW-14476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
jeszyb opened a new pull request #11571:
URL: https://github.com/apache/arrow/pull/11571
This also handles ARROW-14366 by adding a comment if the requesting user is
not yet a contributor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
lidavidm commented on pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#issuecomment-954191248
Yes - sorry, I've been tied up this week but will get back to this ASAP.
Thanks for addressing things. I also want to look at the Protobuf issue still.
--
This is an automate
rafael-telles commented on a change in pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#discussion_r738758362
##
File path: cpp/src/arrow/flight/flight-sql/test_app_cli.cc
##
@@ -0,0 +1,200 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+/
lidavidm commented on a change in pull request #10260:
URL: https://github.com/apache/arrow/pull/10260#discussion_r738754458
##
File path: cpp/src/arrow/util/tracing_internal.cc
##
@@ -0,0 +1,252 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
zeroshade commented on a change in pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#discussion_r738752305
##
File path: go/parquet/writer_properties.go
##
@@ -18,7 +18,7 @@ package parquet
import (
"github.com/apache/arrow/go/arrow/memory"
Review
cpcloud commented on a change in pull request #10260:
URL: https://github.com/apache/arrow/pull/10260#discussion_r738744932
##
File path: cpp/src/arrow/util/tracing_internal.cc
##
@@ -0,0 +1,252 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
cpcloud commented on a change in pull request #10260:
URL: https://github.com/apache/arrow/pull/10260#discussion_r738742092
##
File path: cpp/src/arrow/util/tracing_internal.cc
##
@@ -0,0 +1,252 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
xudong963 commented on issue #1195:
URL:
https://github.com/apache/arrow-datafusion/issues/1195#issuecomment-954171747
> One can run datafusion queries without SQL (using the DataFrame API
directly, for example
Sorry, I always forget we have DF API😅. After waking up, I'll update the
rafael-telles commented on a change in pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#discussion_r738735887
##
File path: cpp/src/arrow/flight/flight-sql/client_impl.h
##
@@ -0,0 +1,463 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+//
rafael-telles commented on pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#issuecomment-954166065
Hey @lidavidm , we managed to remove the templating on client! Can you
please take a look?
Still need to fix the protobuf issue
--
This is an automated message fr
kou commented on a change in pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#discussion_r738730835
##
File path: go/parquet/writer_properties.go
##
@@ -18,7 +18,7 @@ package parquet
import (
"github.com/apache/arrow/go/arrow/memory"
Review comme
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954164579
@kou that said, if the 6.0.1 release points the updated `release-6.0.0`
branch which will have the updated `go.mod` files, then we can just ignore the
`v6.0.0` tags and remove
ursabot edited a comment on pull request #11561:
URL: https://github.com/apache/arrow/pull/11561#issuecomment-953724842
Benchmark runs are scheduled for baseline =
905cb784e257a5fd621ebbf176c6c6f9acd94ba4 and contender =
aa34c4fbbc43c311fb16b23af8a7493fa86045f1.
aa34c4fbbc43c311fb16b23af8
lidavidm commented on a change in pull request #10260:
URL: https://github.com/apache/arrow/pull/10260#discussion_r738724692
##
File path: cpp/src/arrow/util/tracing_internal.cc
##
@@ -0,0 +1,252 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
ursabot edited a comment on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-954152078
Benchmark runs are scheduled for baseline =
faafc51840143635eb06957ccbb8d3669aa30c1d and contender =
2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf.
2ae84e8e90a7c0d8cd37df07d6
alamb commented on issue #1195:
URL:
https://github.com/apache/arrow-datafusion/issues/1195#issuecomment-954158228
One can run datafusion queries without SQL (using the DataFrame API
directly, for example) so I think we definitely need to add it in
https://github.com/apache/arrow-datafusi
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954156625
@kou i've created https://github.com/apache/arrow/pull/11570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
github-actions[bot] commented on pull request #11570:
URL: https://github.com/apache/arrow/pull/11570#issuecomment-954156360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954155027
https://github.com/apache/arrow/tree/go/arrow%2Fv6 and
https://github.com/apache/arrow/tree/go/parquet%2Fv6 will need to point to a
commit which will contain the updated go.m
kou commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954152637
> (will that also update the go/arrow/v6 tag and go/parquet/v6 tag? or will
that need to be done manually afterwards?)
Do these tags mean https://github.com/apache/arrow/tree/
ursabot commented on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-954152078
Benchmark runs are scheduled for baseline =
faafc51840143635eb06957ccbb8d3669aa30c1d and contender =
2ae84e8e90a7c0d8cd37df07d69e982dcfd16eaf.
2ae84e8e90a7c0d8cd37df07d69e982dc
lidavidm closed pull request #11536:
URL: https://github.com/apache/arrow/pull/11536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
lidavidm commented on pull request #11536:
URL: https://github.com/apache/arrow/pull/11536#issuecomment-954151352
Thanks for catching that and filing the JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
alamb merged pull request #1137:
URL: https://github.com/apache/arrow-datafusion/pull/1137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-
alamb commented on a change in pull request #1006:
URL: https://github.com/apache/arrow-datafusion/pull/1006#discussion_r738699587
##
File path: datafusion/src/physical_plan/expressions/get_indexed_field.rs
##
@@ -0,0 +1,103 @@
+// Licensed to the Apache Software Foundation (AS
lidavidm commented on a change in pull request #11524:
URL: https://github.com/apache/arrow/pull/11524#discussion_r738706628
##
File path: cpp/examples/arrow/flight_grpc_example.cc
##
@@ -0,0 +1,100 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954148087
@kou That would be correct i believe and sounds good to me. I'll make the
JIRA card for that PR against release-6.0.0 (will that also update the
go/arrow/v6 tag and go/parquet
lidavidm commented on a change in pull request #11524:
URL: https://github.com/apache/arrow/pull/11524#discussion_r738704269
##
File path: cpp/examples/arrow/CMakeLists.txt
##
@@ -15,30 +15,80 @@
# specific language governing permissions and limitations
# under the License.
kou commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954146869
Can I clarify this? Are the followings right?
* v6.0.1 needs `/v6` suffix
* We should automate `/vX` suffix update on release.
* master should use `/v7` suffix.
If
zeroshade commented on a change in pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#discussion_r738703107
##
File path: go/parquet/writer_properties.go
##
@@ -18,7 +18,7 @@ package parquet
import (
"github.com/apache/arrow/go/arrow/memory"
Review
kou commented on a change in pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#discussion_r738693412
##
File path: go/parquet/writer_properties.go
##
@@ -18,7 +18,7 @@ package parquet
import (
"github.com/apache/arrow/go/arrow/memory"
Review comme
github-actions[bot] commented on pull request #11569:
URL: https://github.com/apache/arrow/pull/11569#issuecomment-954138737
Revision: 7f69cf410b42194a7fffb4687835a08c4bf3c3f0
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1059](https://github.com/ursacomputing/crossbow
kou commented on pull request #11569:
URL: https://github.com/apache/arrow/pull/11569#issuecomment-954138076
@github-actions crossbow submit -g nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dianaclarke closed pull request #11540:
URL: https://github.com/apache/arrow/pull/11540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-uns
westonpace commented on a change in pull request #11023:
URL: https://github.com/apache/arrow/pull/11023#discussion_r738333645
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -402,16 +401,16 @@ struct StringTransformExecBase {
if (!input.is_valid) {
kszucs commented on a change in pull request #11567:
URL: https://github.com/apache/arrow/pull/11567#discussion_r738663202
##
File path: docker-compose.yml
##
@@ -1088,6 +1088,7 @@ services:
/bin/bash -c "
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
alamb edited a comment on issue #1196:
URL:
https://github.com/apache/arrow-datafusion/issues/1196#issuecomment-95401
> @alamb Hi, I'd like to have a try to fix this issue. In order to remove
the all match arm, Sort and Wildcard need be implemented as well. Do you want
to include thos
alamb commented on issue #1196:
URL:
https://github.com/apache/arrow-datafusion/issues/1196#issuecomment-95401
> @alamb Hi, I'd like to have a try to fix this issue. In order to remove
the all match arm, Sort and Wildcard need be implemented as well. Do you want
to include those in th
ursabot edited a comment on pull request #11520:
URL: https://github.com/apache/arrow/pull/11520#issuecomment-953416616
Benchmark runs are scheduled for baseline =
61be0519c6b60bc2576a3b6049e00c7d7627f07d and contender =
61a22124eb86737fee96f1a8b485b3ad5cff8d31.
61a22124eb86737fee96f1a8b4
ursabot edited a comment on pull request #11560:
URL: https://github.com/apache/arrow/pull/11560#issuecomment-953724832
Benchmark runs are scheduled for baseline =
08ed9ad9706052c4ff7898f1860cd5ef044db0ae and contender =
905cb784e257a5fd621ebbf176c6c6f9acd94ba4.
905cb784e257a5fd621ebbf176
ursabot edited a comment on pull request #11539:
URL: https://github.com/apache/arrow/pull/11539#issuecomment-954042044
Benchmark runs are scheduled for baseline =
34fcb3847efe8f2d153bd3893d868f72b4e8a55b and contender =
faafc51840143635eb06957ccbb8d3669aa30c1d.
faafc51840143635eb06957ccb
ursabot commented on pull request #11539:
URL: https://github.com/apache/arrow/pull/11539#issuecomment-954042044
Benchmark runs are scheduled for baseline =
34fcb3847efe8f2d153bd3893d868f72b4e8a55b and contender =
faafc51840143635eb06957ccbb8d3669aa30c1d.
faafc51840143635eb06957ccbb8d3669
thisisnic closed pull request #11539:
URL: https://github.com/apache/arrow/pull/11539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
kszucs commented on a change in pull request #873:
URL: https://github.com/apache/arrow-datafusion/pull/873#discussion_r738590818
##
File path: python/src/lib.rs
##
@@ -17,42 +17,45 @@
use pyo3::prelude::*;
+mod catalog;
mod context;
mod dataframe;
mod errors;
mod expr
kszucs commented on a change in pull request #873:
URL: https://github.com/apache/arrow-datafusion/pull/873#discussion_r738590818
##
File path: python/src/lib.rs
##
@@ -17,42 +17,45 @@
use pyo3::prelude::*;
+mod catalog;
mod context;
mod dataframe;
mod errors;
mod expr
kszucs commented on a change in pull request #873:
URL: https://github.com/apache/arrow-datafusion/pull/873#discussion_r738589948
##
File path: python/src/functions.rs
##
@@ -15,232 +15,210 @@
// specific language governing permissions and limitations
// under the License.
1 - 100 of 234 matches
Mail list logo
