[GitHub] [arrow] thisisnic commented on a change in pull request #11901: ARROW-14849: [R] Update messaging in installation scripts

2021-12-08 Thread GitBox
thisisnic commented on a change in pull request #11901: URL: https://github.com/apache/arrow/pull/11901#discussion_r765509452 ## File path: r/tools/nixlibs.R ## @@ -600,12 +600,15 @@ if (!file.exists(paste0(dst_dir, "/include/arrow/api.h"))) { # (2) Find source and build

[GitHub] [arrow] ursabot edited a comment on pull request #11515: ARROW-14431: [C++][Gandiva] Implement AES ENCRYPT and AES DECRYPT functions

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11515: URL: https://github.com/apache/arrow/pull/11515#issuecomment-988703977 Benchmark runs are scheduled for baseline = b3dbe32771a4c954d42310234ce21e382fae1232 and contender = b31dd5148e0e0b5c7a9417e83a08949e9d4b. b31dd5148e0e0b5c7a9417

[GitHub] [arrow] bkmgit commented on a change in pull request #11562: ARROW-14446: [Docs][Release] Update documentation on verification of release candidates

2021-12-08 Thread GitBox
bkmgit commented on a change in pull request #11562: URL: https://github.com/apache/arrow/pull/11562#discussion_r765476787 ## File path: dev/tasks/verify-rc/github.Almalinux.amd64.yml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

[GitHub] [arrow] kou commented on a change in pull request #11562: ARROW-14446: [Docs][Release] Update documentation on verification of release candidates

2021-12-08 Thread GitBox
kou commented on a change in pull request #11562: URL: https://github.com/apache/arrow/pull/11562#discussion_r765471791 ## File path: dev/tasks/verify-rc/github.Almalinux.amd64.yml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [arrow] bkmgit commented on pull request #11562: ARROW-14446: [Docs][Release] Update documentation on verification of release candidates

2021-12-08 Thread GitBox
bkmgit commented on pull request #11562: URL: https://github.com/apache/arrow/pull/11562#issuecomment-989557426 @kou Thanks. Change applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] ursabot edited a comment on pull request #7732: ARROW-13208: [Python][CI] Create a build for validating python docstrings

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #7732: URL: https://github.com/apache/arrow/pull/7732#issuecomment-988710987 Benchmark runs are scheduled for baseline = b31dd5148e0e0b5c7a9417e83a08949e9d4b and contender = 2bffb82a0da704510b25cacd3ecec819f752fb59. 2bffb82a0da704510b25cacd3ece

[GitHub] [arrow-datafusion] houqp edited a comment on pull request #1378: Metadata is kept in projections for non-derived columns

2021-12-08 Thread GitBox
houqp edited a comment on pull request #1378: URL: https://github.com/apache/arrow-datafusion/pull/1378#issuecomment-989553584 you can go into the testing folder, checkout the current commit tracked in master (https://github.com/apache/arrow-testing/tree/a8f7be380531758eb7962542a5eb020d879

[GitHub] [arrow-datafusion] houqp commented on pull request #1378: Metadata is kept in projections for non-derived columns

2021-12-08 Thread GitBox
houqp commented on pull request #1378: URL: https://github.com/apache/arrow-datafusion/pull/1378#issuecomment-989553584 you can go into the testing folder, checkout the current commit tracked in master (https://github.com/apache/arrow-testing/tree/a8f7be380531758eb7962542a5eb020d8795aa20),

[GitHub] [arrow] github-actions[bot] commented on pull request #11911: ARROW-15019: [Python] Add bindings for new dataset writing options

2021-12-08 Thread GitBox
github-actions[bot] commented on pull request #11911: URL: https://github.com/apache/arrow/pull/11911#issuecomment-989551417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] vibhatha opened a new pull request #11911: ARROW-15019: [Python] Add bindings for new dataset writing options

2021-12-08 Thread GitBox
vibhatha opened a new pull request #11911: URL: https://github.com/apache/arrow/pull/11911 Adding `max_open_files` and `max_rows_per_files` to python bindings of dataset API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] bkmgit commented on pull request #11910: ARROW-13762: [CPP] Make BinaryBuilder preserves the type parameter

2021-12-08 Thread GitBox
bkmgit commented on pull request #11910: URL: https://github.com/apache/arrow/pull/11910#issuecomment-989546789 Thanks for your pull request. Please change the title to: - ARROW-13762: [C++] Make BinaryBuilder preserve the type parameter -- This is an automated message from the Apache

[GitHub] [arrow] iajoiner commented on a change in pull request #9702: ARROW-11297: [C++][Python] Add ORC writer options

2021-12-08 Thread GitBox
iajoiner commented on a change in pull request #9702: URL: https://github.com/apache/arrow/pull/9702#discussion_r765455014 ## File path: python/pyarrow/orc.py ## @@ -54,9 +54,25 @@ def nrows(self): return self.reader.nrows() @property -def nstripes(self): -

[GitHub] [arrow] iajoiner commented on a change in pull request #9702: ARROW-11297: [C++][Python] Add ORC writer options

2021-12-08 Thread GitBox
iajoiner commented on a change in pull request #9702: URL: https://github.com/apache/arrow/pull/9702#discussion_r765454602 ## File path: python/pyarrow/_orc.pyx ## @@ -39,6 +39,206 @@ from pyarrow.lib cimport (check_status, _Weakrefable, from pyarrow.lib import tobytes +cd

[GitHub] [arrow] AlvinJ15 commented on pull request #11853: ARROW-1699: [C++] forward, backward fill kernel functions

2021-12-08 Thread GitBox
AlvinJ15 commented on pull request #11853: URL: https://github.com/apache/arrow/pull/11853#issuecomment-989538380 @lidavidm all comments were solved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] ursabot edited a comment on pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11840: URL: https://github.com/apache/arrow/pull/11840#issuecomment-988681874 Benchmark runs are scheduled for baseline = a400652507540b690f774f5e162c118d91594a50 and contender = b3dbe32771a4c954d42310234ce21e382fae1232. b3dbe32771a4c954d42310234c

[GitHub] [arrow] cyb70289 commented on pull request #11896: ARROW-15005: [C++] Improve csv parser with Neon

2021-12-08 Thread GitBox
cyb70289 commented on pull request #11896: URL: https://github.com/apache/arrow/pull/11896#issuecomment-989535529 New benchmark result after templating special options. Neoverse N1, clang-12 ``` -- Non-regression

[GitHub] [arrow] cyb70289 commented on a change in pull request #11896: ARROW-15005: [C++] Improve csv parser with Neon

2021-12-08 Thread GitBox
cyb70289 commented on a change in pull request #11896: URL: https://github.com/apache/arrow/pull/11896#discussion_r765449177 ## File path: cpp/src/arrow/csv/parser.cc ## @@ -184,6 +184,31 @@ class SSE42Filter { const BulkFilterType filter_; }; +#elif defined ARROW_HAVE_NE

[GitHub] [arrow] coryan commented on a change in pull request #11888: ARROW-14980: [C++] GCS tests use PYTHON environment variable

2021-12-08 Thread GitBox
coryan commented on a change in pull request #11888: URL: https://github.com/apache/arrow/pull/11888#discussion_r765431174 ## File path: cpp/src/arrow/filesystem/gcsfs_test.cc ## @@ -78,11 +78,24 @@ class GcsIntegrationTest : public ::testing::Test { // Initialize a PRNG w

[GitHub] [arrow] ursabot edited a comment on pull request #11515: ARROW-14431: [C++][Gandiva] Implement AES ENCRYPT and AES DECRYPT functions

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11515: URL: https://github.com/apache/arrow/pull/11515#issuecomment-988703977 Benchmark runs are scheduled for baseline = b3dbe32771a4c954d42310234ce21e382fae1232 and contender = b31dd5148e0e0b5c7a9417e83a08949e9d4b. b31dd5148e0e0b5c7a9417

[GitHub] [arrow] github-actions[bot] commented on pull request #11910: ARROW-13762: [CPP] Make BinaryBuilder preserves the type parameter

2021-12-08 Thread GitBox
github-actions[bot] commented on pull request #11910: URL: https://github.com/apache/arrow/pull/11910#issuecomment-989503637 https://issues.apache.org/jira/browse/ARROW-13762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] supunkamburugamuve opened a new pull request #11910: ARROW-13762: [CPP] Make BinaryBuilder preserves the type parameter

2021-12-08 Thread GitBox
supunkamburugamuve opened a new pull request #11910: URL: https://github.com/apache/arrow/pull/11910 This pull request preserves the passed-in type parameter to the BinaryBuilders. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [arrow] emkornfield commented on pull request #11538: ARROW-13986: [Go][Parquet] Add File Writers and tests

2021-12-08 Thread GitBox
emkornfield commented on pull request #11538: URL: https://github.com/apache/arrow/pull/11538#issuecomment-989500372 Sorry things have been more hectic then I would have liked recently, will try to get to this soon. Thank you for your patience. -- This is an automated message from the A

[GitHub] [arrow] ursabot edited a comment on pull request #11880: ARROW-15002: [Python] Fix hypothesis strategy for interval types

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11880: URL: https://github.com/apache/arrow/pull/11880#issuecomment-98811 Benchmark runs are scheduled for baseline = 04ed72d185cc8695e170ff3dd0aa86dc07444c8a and contender = a400652507540b690f774f5e162c118d91594a50. a400652507540b690f774f5e16

[GitHub] [arrow] ursabot edited a comment on pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11840: URL: https://github.com/apache/arrow/pull/11840#issuecomment-988681874 Benchmark runs are scheduled for baseline = a400652507540b690f774f5e162c118d91594a50 and contender = b3dbe32771a4c954d42310234ce21e382fae1232. b3dbe32771a4c954d42310234c

[GitHub] [arrow] bkietz commented on a change in pull request #11887: ARROW-15012: [C++] fixes for msvc environment

2021-12-08 Thread GitBox
bkietz commented on a change in pull request #11887: URL: https://github.com/apache/arrow/pull/11887#discussion_r765387997 ## File path: cpp/src/arrow/util/macros.h ## @@ -97,6 +97,17 @@ #endif // ifndef NULLPTR +//

[GitHub] [arrow] bkietz commented on a change in pull request #11887: ARROW-15012: [C++] fixes for msvc environment

2021-12-08 Thread GitBox
bkietz commented on a change in pull request #11887: URL: https://github.com/apache/arrow/pull/11887#discussion_r765387997 ## File path: cpp/src/arrow/util/macros.h ## @@ -97,6 +97,17 @@ #endif // ifndef NULLPTR +//

[GitHub] [arrow] ursabot edited a comment on pull request #11865: ARROW-14976: [Dev][Archery] Fail early if no benchmark found

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11865: URL: https://github.com/apache/arrow/pull/11865#issuecomment-989433563 Benchmark runs are scheduled for baseline = 9d200f5a4466e0ae2731abbf2949fa5e118bb056 and contender = f0110cf26af3cc8f4bcb94da7fafd01974bbbfd2. f0110cf26af3cc8f4bcb94da7f

[GitHub] [arrow] github-actions[bot] removed a comment on pull request #11887: ARROW-15012: [C++] fixes for msvc environment

2021-12-08 Thread GitBox
github-actions[bot] removed a comment on pull request #11887: URL: https://github.com/apache/arrow/pull/11887#issuecomment-988197628 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could

[GitHub] [arrow] rip-nsk commented on a change in pull request #11887: ARROW-15012: [C++] fixes for msvc environment

2021-12-08 Thread GitBox
rip-nsk commented on a change in pull request #11887: URL: https://github.com/apache/arrow/pull/11887#discussion_r765383955 ## File path: cpp/src/arrow/util/variant.h ## @@ -144,11 +144,11 @@ struct VariantImpl> : VariantStorage { void copy_to(...) const {} template -

[GitHub] [arrow] rip-nsk commented on a change in pull request #11887: ARROW-15012: [C++] fixes for msvc environment

2021-12-08 Thread GitBox
rip-nsk commented on a change in pull request #11887: URL: https://github.com/apache/arrow/pull/11887#discussion_r765383454 ## File path: cpp/src/arrow/util/launder.h ## @@ -22,7 +22,7 @@ namespace arrow { namespace internal { -#if __cplusplus >= 201703L +#ifdef __cpp_lib_l

[GitHub] [arrow] ursabot edited a comment on pull request #11881: ARROW-14850: [R] Update ARROW_DEPENDENCY_SOURCE to default to AUTO

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11881: URL: https://github.com/apache/arrow/pull/11881#issuecomment-988659068 Benchmark runs are scheduled for baseline = 392a25f44395e9591d871ebb910c1185bda781dd and contender = 04ed72d185cc8695e170ff3dd0aa86dc07444c8a. 04ed72d185cc8695e170ff3dd0

[GitHub] [arrow] rip-nsk commented on a change in pull request #11887: ARROW-15012: [C++] fixes for msvc environment

2021-12-08 Thread GitBox
rip-nsk commented on a change in pull request #11887: URL: https://github.com/apache/arrow/pull/11887#discussion_r765380261 ## File path: cpp/src/arrow/util/macros.h ## @@ -97,6 +97,17 @@ #endif // ifndef NULLPTR +// ---

[GitHub] [arrow] cyb70289 commented on a change in pull request #11896: ARROW-15005: [C++] Improve csv parser with Neon

2021-12-08 Thread GitBox
cyb70289 commented on a change in pull request #11896: URL: https://github.com/apache/arrow/pull/11896#discussion_r765379957 ## File path: cpp/src/arrow/csv/parser.cc ## @@ -184,6 +184,31 @@ class SSE42Filter { const BulkFilterType filter_; }; +#elif defined ARROW_HAVE_NE

[GitHub] [arrow] ursabot commented on pull request #11865: ARROW-14976: [Dev][Archery] Fail early if no benchmark found

2021-12-08 Thread GitBox
ursabot commented on pull request #11865: URL: https://github.com/apache/arrow/pull/11865#issuecomment-989433563 Benchmark runs are scheduled for baseline = 9d200f5a4466e0ae2731abbf2949fa5e118bb056 and contender = f0110cf26af3cc8f4bcb94da7fafd01974bbbfd2. f0110cf26af3cc8f4bcb94da7fafd0197

[GitHub] [arrow] cyb70289 closed pull request #11865: ARROW-14976: [Dev][Archery] Fail early if no benchmark found

2021-12-08 Thread GitBox
cyb70289 closed pull request #11865: URL: https://github.com/apache/arrow/pull/11865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] ursabot edited a comment on pull request #11880: ARROW-15002: [Python] Fix hypothesis strategy for interval types

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11880: URL: https://github.com/apache/arrow/pull/11880#issuecomment-98811 Benchmark runs are scheduled for baseline = 04ed72d185cc8695e170ff3dd0aa86dc07444c8a and contender = a400652507540b690f774f5e162c118d91594a50. a400652507540b690f774f5e16

[GitHub] [arrow-datafusion] hntd187 commented on a change in pull request #1419: Ordering by index in select expression

2021-12-08 Thread GitBox
hntd187 commented on a change in pull request #1419: URL: https://github.com/apache/arrow-datafusion/pull/1419#discussion_r765367408 ## File path: datafusion/src/sql/planner.rs ## @@ -2959,6 +2990,36 @@ mod tests { quick_test(sql, expected); } +#[test] +

[GitHub] [arrow-datafusion] liukun4515 commented on a change in pull request #1419: Ordering by index in select expression

2021-12-08 Thread GitBox
liukun4515 commented on a change in pull request #1419: URL: https://github.com/apache/arrow-datafusion/pull/1419#discussion_r765360688 ## File path: datafusion/src/sql/planner.rs ## @@ -2959,6 +2990,36 @@ mod tests { quick_test(sql, expected); } +#[test] +

[GitHub] [arrow-datafusion] liukun4515 commented on a change in pull request #1419: Ordering by index in select expression

2021-12-08 Thread GitBox
liukun4515 commented on a change in pull request #1419: URL: https://github.com/apache/arrow-datafusion/pull/1419#discussion_r765358455 ## File path: datafusion/src/sql/planner.rs ## @@ -2959,6 +2990,36 @@ mod tests { quick_test(sql, expected); } +#[test] +

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1419: Ordering by index in select expression

2021-12-08 Thread GitBox
xudong963 commented on pull request #1419: URL: https://github.com/apache/arrow-datafusion/pull/1419#issuecomment-989343252 Thanks @hntd187 , I'll review the ticket later today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] github-actions[bot] commented on pull request #11909: ARROW-15038: [Packaging][CentOS] Drop support for CentOS 8

2021-12-08 Thread GitBox
github-actions[bot] commented on pull request #11909: URL: https://github.com/apache/arrow/pull/11909#issuecomment-989339333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] kou opened a new pull request #11909: ARROW-15038: [Packaging][CentOS] Drop support for CentOS 8

2021-12-08 Thread GitBox
kou opened a new pull request #11909: URL: https://github.com/apache/arrow/pull/11909 Because it'll reach EOL at 2021-12. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [arrow] ursabot edited a comment on pull request #11735: ARROW-14749: [Python][Release] Set release verification script to use target source instead of current source directory

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11735: URL: https://github.com/apache/arrow/pull/11735#issuecomment-988582885 Benchmark runs are scheduled for baseline = 3f179ca3dc23c657c3c867df22b637219f2d9a3d and contender = 392a25f44395e9591d871ebb910c1185bda781dd. 392a25f44395e9591d871ebb91

[GitHub] [arrow] paleolimbot commented on a change in pull request #11904: ARROW-15010: [R] Create a function registry for our NSE funcs

2021-12-08 Thread GitBox
paleolimbot commented on a change in pull request #11904: URL: https://github.com/apache/arrow/pull/11904#discussion_r765334261 ## File path: r/R/dplyr-funcs-string.R ## @@ -0,0 +1,492 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

[GitHub] [arrow] ursabot edited a comment on pull request #11881: ARROW-14850: [R] Update ARROW_DEPENDENCY_SOURCE to default to AUTO

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11881: URL: https://github.com/apache/arrow/pull/11881#issuecomment-988659068 Benchmark runs are scheduled for baseline = 392a25f44395e9591d871ebb910c1185bda781dd and contender = 04ed72d185cc8695e170ff3dd0aa86dc07444c8a. 04ed72d185cc8695e170ff3dd0

[GitHub] [arrow] paleolimbot commented on a change in pull request #11904: ARROW-15010: [R] Create a function registry for our NSE funcs

2021-12-08 Thread GitBox
paleolimbot commented on a change in pull request #11904: URL: https://github.com/apache/arrow/pull/11904#discussion_r765330660 ## File path: r/R/dplyr-funcs.R ## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agre

[GitHub] [arrow] paleolimbot commented on a change in pull request #11904: ARROW-15010: [R] Create a function registry for our NSE funcs

2021-12-08 Thread GitBox
paleolimbot commented on a change in pull request #11904: URL: https://github.com/apache/arrow/pull/11904#discussion_r765329678 ## File path: r/R/dplyr-funcs.R ## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agre

[GitHub] [arrow] kou commented on a change in pull request #11562: ARROW-14446: [Docs][Release] Update documentation on verification of release candidates

2021-12-08 Thread GitBox
kou commented on a change in pull request #11562: URL: https://github.com/apache/arrow/pull/11562#discussion_r765327347 ## File path: dev/tasks/verify-rc/github.Almalinux.amd64.yml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [arrow] zixi-bwang commented on pull request #11874: ARROW-15037: [C#] A Real-time memory-based data analytics example

2021-12-08 Thread GitBox
zixi-bwang commented on pull request #11874: URL: https://github.com/apache/arrow/pull/11874#issuecomment-989303855 > One quick question/suggestion: Can you add a small `README` to the example explaining what it is showing? Describe the scenario, etc. Hi @eerhardt, I added the readme

[GitHub] [arrow] github-actions[bot] commented on pull request #11874: ARROW-15037: [C#] A Real-time memory-based data analytics example

2021-12-08 Thread GitBox
github-actions[bot] commented on pull request #11874: URL: https://github.com/apache/arrow/pull/11874#issuecomment-989303372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] lidavidm commented on pull request #11906: WIP: [C++] Demonstrate C++ OTel instrumentation

2021-12-08 Thread GitBox
lidavidm commented on pull request #11906: URL: https://github.com/apache/arrow/pull/11906#issuecomment-989293166 Ok, I think we can hook up logging JSON to stdout/stderr then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] ursabot edited a comment on pull request #11893: MINOR: [R] Small addition to disable extraneous duckdb building

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11893: URL: https://github.com/apache/arrow/pull/11893#issuecomment-989285751 Benchmark runs are scheduled for baseline = 7fb1a7203121d26c5f0e163ea007dbbe50fd6d3b and contender = 9d200f5a4466e0ae2731abbf2949fa5e118bb056. 9d200f5a4466e0ae2731abbf29

[GitHub] [arrow] jonkeane commented on pull request #11906: WIP: [C++] Demonstrate C++ OTel instrumentation

2021-12-08 Thread GitBox
jonkeane commented on pull request #11906: URL: https://github.com/apache/arrow/pull/11906#issuecomment-989287140 FWIW, stdout might be the easiest lift to get this into conbench (well one I merge https://github.com/ursacomputing/arrowbench/pull/43 we can have conbench consume the stdout f

[GitHub] [arrow] ursabot commented on pull request #11893: MINOR: [R] Small addition to disable extraneous duckdb building

2021-12-08 Thread GitBox
ursabot commented on pull request #11893: URL: https://github.com/apache/arrow/pull/11893#issuecomment-989285751 Benchmark runs are scheduled for baseline = 7fb1a7203121d26c5f0e163ea007dbbe50fd6d3b and contender = 9d200f5a4466e0ae2731abbf2949fa5e118bb056. 9d200f5a4466e0ae2731abbf2949fa5e1

[GitHub] [arrow] lidavidm commented on pull request #11906: WIP: [C++] Demonstrate C++ OTel instrumentation

2021-12-08 Thread GitBox
lidavidm commented on pull request #11906: URL: https://github.com/apache/arrow/pull/11906#issuecomment-989284780 We could enable the built-in stdout logger, though that logs in a format that's very not-amenable to parsing. We could also restore the JSON logger from the original PR, though

[GitHub] [arrow] jonkeane closed pull request #11893: MINOR: [R] Small addition to disable extraneous duckdb building

2021-12-08 Thread GitBox
jonkeane closed pull request #11893: URL: https://github.com/apache/arrow/pull/11893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] ursabot edited a comment on pull request #11861: ARROW-14986: [Release][Docs] Use artifact built by Crossbow

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11861: URL: https://github.com/apache/arrow/pull/11861#issuecomment-988479624 Benchmark runs are scheduled for baseline = d3763a3d5b3a23eb3eb7e1eeb496e24b76683043 and contender = 3f179ca3dc23c657c3c867df22b637219f2d9a3d. 3f179ca3dc23c657c3c867df22

[GitHub] [arrow] westonpace commented on pull request #11906: WIP: [C++] Demonstrate C++ OTel instrumentation

2021-12-08 Thread GitBox
westonpace commented on pull request #11906: URL: https://github.com/apache/arrow/pull/11906#issuecomment-989271720 Asking users to run a separate docker container to get logs feels a bit heavyweight, especially for Windows. I do get that this is more flexible but how much more work would

[GitHub] [arrow] jonkeane commented on a change in pull request #11904: ARROW-15010: [R] Create a function registry for our NSE funcs

2021-12-08 Thread GitBox
jonkeane commented on a change in pull request #11904: URL: https://github.com/apache/arrow/pull/11904#discussion_r765279384 ## File path: r/R/dplyr-funcs-string.R ## @@ -0,0 +1,492 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [arrow] dragosmg commented on pull request #11805: ARROW-14844 [R] Implement `decimal256()`

2021-12-08 Thread GitBox
dragosmg commented on pull request #11805: URL: https://github.com/apache/arrow/pull/11805#issuecomment-989269756 This is outdated. Work on `decimal256()` is taking place in a different PR - https://github.com/apache/arrow/pull/11898 -- This is an automated message from the Apache Git S

[GitHub] [arrow-datafusion] hntd187 commented on pull request #1378: Metadata is kept in projections for non-derived columns

2021-12-08 Thread GitBox
hntd187 commented on pull request #1378: URL: https://github.com/apache/arrow-datafusion/pull/1378#issuecomment-989269348 @alamb I think whatever I did messing up the pin on the test dependencies caused the tests to fail. I don't know how I did it in the first place to be honest, would you

[GitHub] [arrow] dragosmg closed pull request #11805: ARROW-14844 [R] Implement `decimal256()`

2021-12-08 Thread GitBox
dragosmg closed pull request #11805: URL: https://github.com/apache/arrow/pull/11805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] ursabot edited a comment on pull request #11735: ARROW-14749: [Python][Release] Set release verification script to use target source instead of current source directory

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11735: URL: https://github.com/apache/arrow/pull/11735#issuecomment-988582885 Benchmark runs are scheduled for baseline = 3f179ca3dc23c657c3c867df22b637219f2d9a3d and contender = 392a25f44395e9591d871ebb910c1185bda781dd. 392a25f44395e9591d871ebb91

[GitHub] [arrow] ursabot edited a comment on pull request #11793: ARROW-13950: [C++] min_element_wise/max_element_wise missing support for some types

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11793: URL: https://github.com/apache/arrow/pull/11793#issuecomment-989205442 Benchmark runs are scheduled for baseline = 62db4b6a2545da29279ee5c138b5f531067d802a and contender = 7fb1a7203121d26c5f0e163ea007dbbe50fd6d3b. 7fb1a7203121d26c5f0e163ea0

[GitHub] [arrow-rs] lquerel commented on issue #506: "Optimize" Dictionary contents in DictionaryArray / `concat_batches`

2021-12-08 Thread GitBox
lquerel commented on issue #506: URL: https://github.com/apache/arrow-rs/issues/506#issuecomment-989216649 Another issue with the existing implementation is the DictionaryKeyOverflowError error that is returned in situations where it is reasonably not expected. For example like in this sce

[GitHub] [arrow] kou commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build

2021-12-08 Thread GitBox
kou commented on a change in pull request #11889: URL: https://github.com/apache/arrow/pull/11889#discussion_r765264031 ## File path: cpp/src/arrow/ArrowConfig.cmake.in ## @@ -87,6 +87,10 @@ if(NOT (TARGET arrow_shared OR TARGET arrow_static)) set_target_properties(

[GitHub] [arrow-datafusion] Dandandan commented on issue #1422: Send time metric in

2021-12-08 Thread GitBox
Dandandan commented on issue #1422: URL: https://github.com/apache/arrow-datafusion/issues/1422#issuecomment-989207886 Closed by #1421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [arrow-datafusion] Dandandan closed issue #1422: Send time metric in

2021-12-08 Thread GitBox
Dandandan closed issue #1422: URL: https://github.com/apache/arrow-datafusion/issues/1422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [arrow] ursabot commented on pull request #11793: ARROW-13950: [C++] min_element_wise/max_element_wise missing support for some types

2021-12-08 Thread GitBox
ursabot commented on pull request #11793: URL: https://github.com/apache/arrow/pull/11793#issuecomment-989205442 Benchmark runs are scheduled for baseline = 62db4b6a2545da29279ee5c138b5f531067d802a and contender = 7fb1a7203121d26c5f0e163ea007dbbe50fd6d3b. 7fb1a7203121d26c5f0e163ea007dbbe5

[GitHub] [arrow] bkietz closed pull request #11793: ARROW-13950: [C++] min_element_wise/max_element_wise missing support for some types

2021-12-08 Thread GitBox
bkietz closed pull request #11793: URL: https://github.com/apache/arrow/pull/11793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-datafusion] alamb merged pull request #1421: [Minor] Fix `send_time` metric for hash-repartition

2021-12-08 Thread GitBox
alamb merged pull request #1421: URL: https://github.com/apache/arrow-datafusion/pull/1421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow] lidavidm commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build

2021-12-08 Thread GitBox
lidavidm commented on a change in pull request #11889: URL: https://github.com/apache/arrow/pull/11889#discussion_r765244471 ## File path: cpp/src/arrow/ArrowConfig.cmake.in ## @@ -87,6 +87,10 @@ if(NOT (TARGET arrow_shared OR TARGET arrow_static)) set_target_properties(

[GitHub] [arrow] asuhan commented on pull request #11793: ARROW-13950: [C++] min_element_wise/max_element_wise missing support for some types

2021-12-08 Thread GitBox
asuhan commented on pull request #11793: URL: https://github.com/apache/arrow/pull/11793#issuecomment-989193250 Thank you for the review! I don't have write access to the repository, so I'll leave the merge to someone who has. -- This is an automated message from the Apache Git Service.

[GitHub] [arrow] martindurant commented on pull request #10978: PARQUET-492: [C++][Parquet] Basic support for reading DELTA_BYTE_ARRAY data.

2021-12-08 Thread GitBox
martindurant commented on pull request #10978: URL: https://github.com/apache/arrow/pull/10978#issuecomment-989192764 Got it, thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] pitrou commented on pull request #10978: PARQUET-492: [C++][Parquet] Basic support for reading DELTA_BYTE_ARRAY data.

2021-12-08 Thread GitBox
pitrou commented on pull request #10978: URL: https://github.com/apache/arrow/pull/10978#issuecomment-989191805 I have no idea if @shanhuuang intends to implement `DELTA_LENGTH_BYTE_ARRAY`. Also, they are only implemented on the read side (I don't know if writing will be done, nor when).

[GitHub] [arrow] ursabot edited a comment on pull request #11892: ARROW-14644: [C++][R] open_dataset doesn't ignore BOM in csv file

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11892: URL: https://github.com/apache/arrow/pull/11892#issuecomment-989185185 Benchmark runs are scheduled for baseline = 001f47eb05f722d8e34b123e6673eeb8be836965 and contender = 62db4b6a2545da29279ee5c138b5f531067d802a. 62db4b6a2545da29279ee5c138

[GitHub] [arrow] martindurant commented on pull request #10978: PARQUET-492: [C++][Parquet] Basic support for reading DELTA_BYTE_ARRAY data.

2021-12-08 Thread GitBox
martindurant commented on pull request #10978: URL: https://github.com/apache/arrow/pull/10978#issuecomment-989189668 OK, thanks @pitrou . Will all three DELTA_ codecs be in the next release? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [arrow] pitrou commented on pull request #10978: PARQUET-492: [C++][Parquet] Basic support for reading DELTA_BYTE_ARRAY data.

2021-12-08 Thread GitBox
pitrou commented on pull request #10978: URL: https://github.com/apache/arrow/pull/10978#issuecomment-989189014 It is [on git master](https://github.com/apache/arrow/blob/master/docs/source/cpp/parquet.rst#encodings), but unfortunately only docs for the released versions are published onli

[GitHub] [arrow] martindurant commented on pull request #10978: PARQUET-492: [C++][Parquet] Basic support for reading DELTA_BYTE_ARRAY data.

2021-12-08 Thread GitBox
martindurant commented on pull request #10978: URL: https://github.com/apache/arrow/pull/10978#issuecomment-989187887 Can the list of supported codecs at https://arrow.apache.org/docs/cpp/parquet.html#encodings be updated? -- This is an automated message from the Apache Git Service. To r

[GitHub] [arrow] kou commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build

2021-12-08 Thread GitBox
kou commented on a change in pull request #11889: URL: https://github.com/apache/arrow/pull/11889#discussion_r765229149 ## File path: cpp/src/arrow/ArrowConfig.cmake.in ## @@ -87,6 +87,10 @@ if(NOT (TARGET arrow_shared OR TARGET arrow_static)) set_target_properties(

[GitHub] [arrow] ursabot commented on pull request #11892: ARROW-14644: [C++][R] open_dataset doesn't ignore BOM in csv file

2021-12-08 Thread GitBox
ursabot commented on pull request #11892: URL: https://github.com/apache/arrow/pull/11892#issuecomment-989185185 Benchmark runs are scheduled for baseline = 001f47eb05f722d8e34b123e6673eeb8be836965 and contender = 62db4b6a2545da29279ee5c138b5f531067d802a. 62db4b6a2545da29279ee5c138b5f5310

[GitHub] [arrow] jonkeane closed pull request #11892: ARROW-14644: [C++][R] open_dataset doesn't ignore BOM in csv file

2021-12-08 Thread GitBox
jonkeane closed pull request #11892: URL: https://github.com/apache/arrow/pull/11892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] kszucs commented on pull request #11900: ARROW-14977: [Python] Add a "made-up" feature for the guide tutorial

2021-12-08 Thread GitBox
kszucs commented on pull request #11900: URL: https://github.com/apache/arrow/pull/11900#issuecomment-989182504 I think we can locate already merged commits for the three separate cases and translate/simplify those to a material suitable for tutorials. Cc @jorisvandenbossche -- This is

[GitHub] [arrow-datafusion] Dandandan opened a new issue #1422: Send time metric in

2021-12-08 Thread GitBox
Dandandan opened a new issue #1422: URL: https://github.com/apache/arrow-datafusion/issues/1422 **Describe the bug** In hash repartition, time is wrongly attributed to the `repart_time` instead of `send_time` metric **To Reproduce** ``` create table t as select 1 x;

[GitHub] [arrow] ursabot edited a comment on pull request #11521: ARROW-13398: [R] Update install.Rmd vignette

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11521: URL: https://github.com/apache/arrow/pull/11521#issuecomment-988479617 Benchmark runs are scheduled for baseline = b9ac245afef081339093cd1930153d6b18b0479d and contender = d3763a3d5b3a23eb3eb7e1eeb496e24b76683043. d3763a3d5b3a23eb3eb7e1eeb4

[GitHub] [arrow] kou commented on pull request #11821: ARROW-13841: [Doc] Document the different subcomponents that make up the CI and how they fit together [WIP]

2021-12-08 Thread GitBox
kou commented on pull request #11821: URL: https://github.com/apache/arrow/pull/11821#issuecomment-989173637 @kszucs OK. Should we work on it pull request? Or should we use a follow-up pull request for it? -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [arrow] ursabot edited a comment on pull request #11861: ARROW-14986: [Release][Docs] Use artifact built by Crossbow

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11861: URL: https://github.com/apache/arrow/pull/11861#issuecomment-988479624 Benchmark runs are scheduled for baseline = d3763a3d5b3a23eb3eb7e1eeb496e24b76683043 and contender = 3f179ca3dc23c657c3c867df22b637219f2d9a3d. 3f179ca3dc23c657c3c867df22

[GitHub] [arrow] github-actions[bot] commented on pull request #11908: ARROW-15030: [C++] CSV writer test failures

2021-12-08 Thread GitBox
github-actions[bot] commented on pull request #11908: URL: https://github.com/apache/arrow/pull/11908#issuecomment-989159361 https://issues.apache.org/jira/browse/ARROW-15030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow-datafusion] Dandandan opened a new pull request #1421: [Minor] Fix `send_time` metric for hash-repartition

2021-12-08 Thread GitBox
Dandandan opened a new pull request #1421: URL: https://github.com/apache/arrow-datafusion/pull/1421 # Which issue does this PR close? n/a. # Rationale for this change Improves/fixes output of hash repartition metric. # What changes are included i

[GitHub] [arrow-rs] matthewmturner commented on a change in pull request #984: Add comparison kernels for DictionaryArray

2021-12-08 Thread GitBox
matthewmturner commented on a change in pull request #984: URL: https://github.com/apache/arrow-rs/pull/984#discussion_r765201351 ## File path: arrow/src/compute/kernels/comparison.rs ## @@ -1200,6 +1257,29 @@ where return compare_op_scalar!(left, right, |a, b| a == b); }

[GitHub] [arrow-rs] matthewmturner commented on a change in pull request #984: Add comparison kernels for DictionaryArray

2021-12-08 Thread GitBox
matthewmturner commented on a change in pull request #984: URL: https://github.com/apache/arrow-rs/pull/984#discussion_r765200445 ## File path: arrow/src/compute/kernels/comparison.rs ## @@ -200,6 +201,54 @@ macro_rules! compare_op_scalar_primitive { }}; } +macro_rules!

[GitHub] [arrow] ursabot edited a comment on pull request #11907: ARROW-15031: [C++] Fix crash on invalid Parquet file (OSS-Fuzz)

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11907: URL: https://github.com/apache/arrow/pull/11907#issuecomment-989137999 Benchmark runs are scheduled for baseline = c2a89e688cf7a501ec1295a0dca5adefc4d2ce46 and contender = 001f47eb05f722d8e34b123e6673eeb8be836965. 001f47eb05f722d8e34b123e66

[GitHub] [arrow] ursabot commented on pull request #11907: ARROW-15031: [C++] Fix crash on invalid Parquet file (OSS-Fuzz)

2021-12-08 Thread GitBox
ursabot commented on pull request #11907: URL: https://github.com/apache/arrow/pull/11907#issuecomment-989137999 Benchmark runs are scheduled for baseline = c2a89e688cf7a501ec1295a0dca5adefc4d2ce46 and contender = 001f47eb05f722d8e34b123e6673eeb8be836965. 001f47eb05f722d8e34b123e6673eeb8b

[GitHub] [arrow] pitrou closed pull request #11907: ARROW-15031: [C++] Fix crash on invalid Parquet file (OSS-Fuzz)

2021-12-08 Thread GitBox
pitrou closed pull request #11907: URL: https://github.com/apache/arrow/pull/11907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-datafusion] alamb commented on pull request #1212: add untyped null

2021-12-08 Thread GitBox
alamb commented on pull request #1212: URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-989135548 I had effectively changed `Expr::Scalar` to report its type as `DataType::Null` its interior `ScalarValue::is_null()` returned true. That seemed fairly promising but I go

[GitHub] [arrow] pitrou edited a comment on pull request #11688: ARROW-14625: [Python][CI] Enable Python test on s390x

2021-12-08 Thread GitBox
pitrou edited a comment on pull request #11688: URL: https://github.com/apache/arrow/pull/11688#issuecomment-989134184 Hmm, there's something weird here. First `oldest-supported-numpy` version 0.13 is downloaded, then version 0.12 is selected... https://app.travis-ci.com/github/pitrou/ar

[GitHub] [arrow] pitrou commented on pull request #11688: ARROW-14625: [Python][CI] Enable Python test on s390x

2021-12-08 Thread GitBox
pitrou commented on pull request #11688: URL: https://github.com/apache/arrow/pull/11688#issuecomment-989134184 Hmm, there's something weird here. First `oldest-supported-numpy` version 0.13, then version 0.12 is selected... https://app.travis-ci.com/github/pitrou/arrow/jobs/551380321#L2

[GitHub] [arrow-rs] alamb edited a comment on issue #983: Remove scientific notation when converting floats to strings.

2021-12-08 Thread GitBox
alamb edited a comment on issue #983: URL: https://github.com/apache/arrow-rs/issues/983#issuecomment-989132112 Instead of calling `c.1.to_string()` perhaps you could use something like this (untested): ```rust match c.1 { Field::Float(f) => format!("{}", f), // or however el

[GitHub] [arrow-rs] alamb commented on issue #983: Remove scientific notation when converting floats to strings.

2021-12-08 Thread GitBox
alamb commented on issue #983: URL: https://github.com/apache/arrow-rs/issues/983#issuecomment-989132112 Instead of calling `c.1.to_string()` perhaps you could use something like this (untested): ```rust match c { Field::Float(f) => format!("{}", f), // or however else you wa

[GitHub] [arrow] ursabot edited a comment on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error

2021-12-08 Thread GitBox
ursabot edited a comment on pull request #11875: URL: https://github.com/apache/arrow/pull/11875#issuecomment-989117713 Benchmark runs are scheduled for baseline = cba23c4633f63fbbb7bde9345fa18330953c9f27 and contender = c2a89e688cf7a501ec1295a0dca5adefc4d2ce46. c2a89e688cf7a501ec1295a0dc

  1   2   3   4   >