[GitHub] [arrow] cyb70289 commented on a change in pull request #12408: ARROW-15604: [C++][CI] Sporadic ThreadSanitizer failure with OpenTracing

2022-02-11 Thread GitBox
cyb70289 commented on a change in pull request #12408: URL: https://github.com/apache/arrow/pull/12408#discussion_r805132951 ## File path: docker-compose.yml ## @@ -773,8 +773,6 @@ services: shm_size: *shm-size environment: <<: *ccache - # Bundled build of

[GitHub] [arrow] cyb70289 commented on a change in pull request #12408: ARROW-15604: [C++][CI] Sporadic ThreadSanitizer failure with OpenTracing

2022-02-11 Thread GitBox
cyb70289 commented on a change in pull request #12408: URL: https://github.com/apache/arrow/pull/12408#discussion_r805132924 ## File path: cpp/src/arrow/util/tracing_internal.cc ## @@ -176,8 +176,23 @@ otel::trace::TracerProvider* GetTracerProvider() { static nostd::shared_p

[GitHub] [arrow] ursabot edited a comment on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12372: URL: https://github.com/apache/arrow/pull/12372#issuecomment-1035502274 Benchmark runs are scheduled for baseline = cce55b46395ee351835dbb2864772bfa7ba0eb9c and contender = 54f6c03285943f041fff004b3a4e8692a8e40b3e. 54f6c03285943f041fff004b3

[GitHub] [arrow] ursabot edited a comment on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12373: URL: https://github.com/apache/arrow/pull/12373#issuecomment-1035489332 Benchmark runs are scheduled for baseline = af33dd1157eb8d7d9bfac25ebf61445b793b7943 and contender = cce55b46395ee351835dbb2864772bfa7ba0eb9c. cce55b46395ee351835dbb286

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1301: Json formatted datetime parsing

2022-02-11 Thread GitBox
codecov-commenter commented on pull request #1301: URL: https://github.com/apache/arrow-rs/pull/1301#issuecomment-1036987553 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow] github-actions[bot] commented on pull request #12408: ARROW-15604: [C++][CI] Sporadic ThreadSanitizer failure with OpenTracing

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12408: URL: https://github.com/apache/arrow/pull/12408#issuecomment-1036969736 https://issues.apache.org/jira/browse/ARROW-15604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] westonpace opened a new pull request #12408: ARROW-15604: [C++][CI] Sporadic ThreadSanitizer failure with OpenTracing

2022-02-11 Thread GitBox
westonpace opened a new pull request #12408: URL: https://github.com/apache/arrow/pull/12408 The particular cause of the failure was: ``` void InputReceived(ExecNode* input, ExecBatch batch) override { EVENT(span_, "InputReceived", {{"batch.length", batch.length}});

[GitHub] [arrow-datafusion] matthewmturner edited a comment on issue #1587: Release of DataFusion: 7.0.0

2022-02-11 Thread GitBox
matthewmturner edited a comment on issue #1587: URL: https://github.com/apache/arrow-datafusion/issues/1587#issuecomment-1036942349 @Jimexist That's a really good point - I have found it helpful as well. But couldn't we do something like the below in `cargo.toml` from the `datafusion-cli`

[GitHub] [arrow-datafusion] matthewmturner edited a comment on issue #1587: Release of DataFusion: 7.0.0

2022-02-11 Thread GitBox
matthewmturner edited a comment on issue #1587: URL: https://github.com/apache/arrow-datafusion/issues/1587#issuecomment-1036942349 @Jimexist That's a really good point - I have found it helpful as well. But couldn't we do something like the below in `cargo.toml` from the datafusion-cli r

[GitHub] [arrow-datafusion] HaoYang670 commented on a change in pull request #1811: Fixup some doc warnings

2022-02-11 Thread GitBox
HaoYang670 commented on a change in pull request #1811: URL: https://github.com/apache/arrow-datafusion/pull/1811#discussion_r805105778 ## File path: datafusion-common/src/dfschema.rs ## @@ -402,8 +402,8 @@ impl Display for DFSchema { } } -/// Provides schema informatio

[GitHub] [arrow] ursabot edited a comment on pull request #12381: ARROW-14096: [C++] add(time, duration) -> time kernel

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12381: URL: https://github.com/apache/arrow/pull/12381#issuecomment-1034915311 Benchmark runs are scheduled for baseline = c0bae8daea2ace51c64f6db38cfb3d04c5bed657 and contender = af33dd1157eb8d7d9bfac25ebf61445b793b7943. af33dd1157eb8d7d9bfac25eb

[GitHub] [arrow-datafusion] matthewmturner commented on issue #1587: Release of DataFusion: 7.0.0

2022-02-11 Thread GitBox
matthewmturner commented on issue #1587: URL: https://github.com/apache/arrow-datafusion/issues/1587#issuecomment-1036942349 @Jimexist That's a really good point - I have found it helpful as well. But couldn't we do something like the below in 'cargo.toml' from the datafusion-cli repo to

[GitHub] [arrow-datafusion] Jimexist commented on issue #1587: Release of DataFusion: 7.0.0

2022-02-11 Thread GitBox
Jimexist commented on issue #1587: URL: https://github.com/apache/arrow-datafusion/issues/1587#issuecomment-1036933915 Making ballista dependency optional seems okay. Having a cli in repo helps a lot with debugging in my opinion -- This is an automated message from the Apache Git Ser

[GitHub] [arrow] ursabot edited a comment on pull request #12354: ARROW-15600: [C++][FlightRPC] Add minimal Flight SQL query example

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12354: URL: https://github.com/apache/arrow/pull/12354#issuecomment-1034451660 Benchmark runs are scheduled for baseline = 647371b504df166860bd33346dcbd962c85e046f and contender = c0bae8daea2ace51c64f6db38cfb3d04c5bed657. c0bae8daea2ace51c64f6db38

[GitHub] [arrow] ursabot edited a comment on pull request #12379: ARROW-15215: [C++] Consolidate kernel data-copy utilities between replace_with_mask, case_when, coalesce, choose, fill_null_forward, f

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12379: URL: https://github.com/apache/arrow/pull/12379#issuecomment-1036700366 Benchmark runs are scheduled for baseline = d59dbbc36c7950e58332d081d47c2d43ea898215 and contender = c26fa8f553495d49b6b6b72ee813b315f6e866de. Results will be available

[GitHub] [arrow] jonkeane commented on a change in pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch

2022-02-11 Thread GitBox
jonkeane commented on a change in pull request #12366: URL: https://github.com/apache/arrow/pull/12366#discussion_r805068787 ## File path: dev/tasks/r/azure.linux.yml ## @@ -19,6 +19,12 @@ jobs: pool: vmImage: ubuntu-latest timeoutInMinutes: 360 +{% if env

[GitHub] [arrow] github-actions[bot] commented on pull request #12406: ARROW-15667: [R] Test development build with ARROW_BUILD_STATIC=OFF

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12406: URL: https://github.com/apache/arrow/pull/12406#issuecomment-1036754706 Revision: c154b42fc8301158a336ca26bc137c88cb17eb57 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1621](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] wjones127 commented on pull request #12406: ARROW-15667: [R] Test development build with ARROW_BUILD_STATIC=OFF

2022-02-11 Thread GitBox
wjones127 commented on pull request #12406: URL: https://github.com/apache/arrow/pull/12406#issuecomment-1036753119 @github-actions crossbow submit test-r-devdocs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [arrow] github-actions[bot] commented on pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12366: URL: https://github.com/apache/arrow/pull/12366#issuecomment-1036726243 Revision: 964469c3cc5ae87b099c74e47069342a3cbc92f0 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1620](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] jonkeane commented on pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch

2022-02-11 Thread GitBox
jonkeane commented on pull request #12366: URL: https://github.com/apache/arrow/pull/12366#issuecomment-1036724608 @github-actions crossbow submit test-r-dev-duckdb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] jonkeane commented on a change in pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch

2022-02-11 Thread GitBox
jonkeane commented on a change in pull request #12366: URL: https://github.com/apache/arrow/pull/12366#discussion_r805060077 ## File path: docker-compose.yml ## @@ -1154,6 +1154,7 @@ services: gcc_version: ${GCC_VERSION} tz: ${TZ} r_prune_deps: ${R_PR

[GitHub] [arrow] jonkeane commented on a change in pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch

2022-02-11 Thread GitBox
jonkeane commented on a change in pull request #12366: URL: https://github.com/apache/arrow/pull/12366#discussion_r805055742 ## File path: docker-compose.yml ## @@ -1154,6 +1154,7 @@ services: gcc_version: ${GCC_VERSION} tz: ${TZ} r_prune_deps: ${R_PR

[GitHub] [arrow] jonkeane commented on a change in pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch

2022-02-11 Thread GitBox
jonkeane commented on a change in pull request #12366: URL: https://github.com/apache/arrow/pull/12366#discussion_r805054978 ## File path: .env ## @@ -76,6 +76,7 @@ ARROW_R_DEV=TRUE R_IMAGE=ubuntu-gcc-release R_ORG=rhub R_PRUNE_DEPS=FALSE +R_DUCKDB_DEV=FALSE Review comment:

[GitHub] [arrow] jonkeane commented on a change in pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch

2022-02-11 Thread GitBox
jonkeane commented on a change in pull request #12366: URL: https://github.com/apache/arrow/pull/12366#discussion_r805054978 ## File path: .env ## @@ -76,6 +76,7 @@ ARROW_R_DEV=TRUE R_IMAGE=ubuntu-gcc-release R_ORG=rhub R_PRUNE_DEPS=FALSE +R_DUCKDB_DEV=FALSE Review comment:

[GitHub] [arrow-julia] quinnj commented on issue #281: NTuple with custom type and compression

2022-02-11 Thread GitBox
quinnj commented on issue #281: URL: https://github.com/apache/arrow-julia/issues/281#issuecomment-1036702371 Sorry for the slow response; thanks for the report. Could you post the exact error you're seeing? Could you also explain what exactly you mean by > I also noticed that the A

[GitHub] [arrow] ursabot commented on pull request #12379: ARROW-15215: [C++] Consolidate kernel data-copy utilities between replace_with_mask, case_when, coalesce, choose, fill_null_forward, fill_nul

2022-02-11 Thread GitBox
ursabot commented on pull request #12379: URL: https://github.com/apache/arrow/pull/12379#issuecomment-1036700366 Benchmark runs are scheduled for baseline = d59dbbc36c7950e58332d081d47c2d43ea898215 and contender = c26fa8f553495d49b6b6b72ee813b315f6e866de. Results will be available as each

[GitHub] [arrow] lidavidm commented on pull request #12379: ARROW-15215: [C++] Consolidate kernel data-copy utilities between replace_with_mask, case_when, coalesce, choose, fill_null_forward, fill_nu

2022-02-11 Thread GitBox
lidavidm commented on pull request #12379: URL: https://github.com/apache/arrow/pull/12379#issuecomment-1036700334 @ursabot please benchmark lang=C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] lidavidm commented on a change in pull request #12379: ARROW-15215: [C++] Consolidate kernel data-copy utilities between replace_with_mask, case_when, coalesce, choose, fill_null_forw

2022-02-11 Thread GitBox
lidavidm commented on a change in pull request #12379: URL: https://github.com/apache/arrow/pull/12379#discussion_r805051436 ## File path: cpp/src/arrow/compute/kernels/copy_data_internal.h ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow-rs] ScottSyms edited a comment on issue #1302: module 'data_type' is private in Rust Parquet 8.0.0

2022-02-11 Thread GitBox
ScottSyms edited a comment on issue #1302: URL: https://github.com/apache/arrow-rs/issues/1302#issuecomment-1036692748 Executing some code from stack overflow which works with the Rust parquet crate versions earlier than 8.0.0. The error generated by the **use parquet::data_type::ByteArra

[GitHub] [arrow-rs] ScottSyms commented on issue #1302: module 'data_type' is private in Rust Parquet 8.0.0

2022-02-11 Thread GitBox
ScottSyms commented on issue #1302: URL: https://github.com/apache/arrow-rs/issues/1302#issuecomment-1036692748 Executing some code from stack overflow which works with the Rust parquet crate before 8.0.0. The error generated by the use parquet::data_type::ByteArray suggests the data_type

[GitHub] [arrow-julia] quinnj commented on issue #282: Allow constructing an Arrow stream/file from columnar data with no column names

2022-02-11 Thread GitBox
quinnj commented on issue #282: URL: https://github.com/apache/arrow-julia/issues/282#issuecomment-1036687958 Hmmm, yeah, this shouldn't be too bad to support. I think the easiest approach would be to hook into the Tables.jl interface for this. We could create a pseudo-table type like:

[GitHub] [arrow-rs] ScottSyms opened a new issue #1302: module 'data_type' is private in Rust Parquet 8.0.0

2022-02-11 Thread GitBox
ScottSyms opened a new issue #1302: URL: https://github.com/apache/arrow-rs/issues/1302 **Describe the bug** A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior: **Expected behavior** A clear and concise description of w

[GitHub] [arrow] JabariBooker commented on a change in pull request #12379: ARROW-15215: [C++] Consolidate kernel data-copy utilities between replace_with_mask, case_when, coalesce, choose, fill_null_

2022-02-11 Thread GitBox
JabariBooker commented on a change in pull request #12379: URL: https://github.com/apache/arrow/pull/12379#discussion_r805036864 ## File path: cpp/src/arrow/compute/kernels/copy_data_internal.h ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] github-actions[bot] commented on pull request #12407: ARROW-15398: [Integration-tests] Made integration tests be built in parallel and increase cache hit

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12407: URL: https://github.com/apache/arrow/pull/12407#issuecomment-1036659539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] jorgecarleitao opened a new pull request #12407: ARROW-15398: [Integration-tests] Made integration tests be built in parallel and increase cache hit

2022-02-11 Thread GitBox
jorgecarleitao opened a new pull request #12407: URL: https://github.com/apache/arrow/pull/12407 This is a draft PR to gauge interest in splitting the build of integration tests into separate stages, so that a change in a language does not trigger a rebuild in all of them. The idea

[GitHub] [arrow] ursabot edited a comment on pull request #12248: ARROW-1888: [C++] Implement Struct Casts

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12248: URL: https://github.com/apache/arrow/pull/12248#issuecomment-1036261383 Benchmark runs are scheduled for baseline = 90a6f1149a58a6c0b1c5061bd0e67be3e17618a1 and contender = 3b9462a4ffc9f1d20ffc4ba578adec0f0ed8ffbd. 3b9462a4ffc9f1d20ffc4ba57

[GitHub] [arrow] lidavidm commented on a change in pull request #12379: ARROW-15215: [C++] Consolidate kernel data-copy utilities between replace_with_mask, case_when, coalesce, choose, fill_null_forw

2022-02-11 Thread GitBox
lidavidm commented on a change in pull request #12379: URL: https://github.com/apache/arrow/pull/12379#discussion_r805014226 ## File path: cpp/src/arrow/compute/kernels/copy_data_internal.h ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] lidavidm commented on a change in pull request #12379: ARROW-15215: [C++] Consolidate kernel data-copy utilities between replace_with_mask, case_when, coalesce, choose, fill_null_forw

2022-02-11 Thread GitBox
lidavidm commented on a change in pull request #12379: URL: https://github.com/apache/arrow/pull/12379#discussion_r805012510 ## File path: cpp/src/arrow/compute/kernels/copy_data_internal.h ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] github-actions[bot] commented on pull request #12406: ARROW-15667: [R] Test development build with ARROW_BUILD_STATIC=OFF

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12406: URL: https://github.com/apache/arrow/pull/12406#issuecomment-1036631497 Revision: 74f826596c8c9cc1a2b81825233a267c1b956b01 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1619](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] wjones127 commented on pull request #12406: ARROW-15667: [R] Test development build with ARROW_BUILD_STATIC=OFF

2022-02-11 Thread GitBox
wjones127 commented on pull request #12406: URL: https://github.com/apache/arrow/pull/12406#issuecomment-1036630766 @github-actions crossbow submit test-r-devdocs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [arrow] github-actions[bot] commented on pull request #12406: ARROW-15667: [R] Test development build with ARROW_BUILD_STATIC=OFF

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12406: URL: https://github.com/apache/arrow/pull/12406#issuecomment-1036630605 https://issues.apache.org/jira/browse/ARROW-15667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] ursabot edited a comment on pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12302: URL: https://github.com/apache/arrow/pull/12302#issuecomment-1034447214 Benchmark runs are scheduled for baseline = e4f658761ffec9a69fe1b3ab5e2b01b27a87493c and contender = 647371b504df166860bd33346dcbd962c85e046f. 647371b504df166860bd33346

[GitHub] [arrow-datafusion] matthewmturner commented on issue #1587: Release of DataFusion: 7.0.0

2022-02-11 Thread GitBox
matthewmturner commented on issue #1587: URL: https://github.com/apache/arrow-datafusion/issues/1587#issuecomment-1036571491 I had thought about moving `datafusion-cli` to datafusion-contrib as well. This does seem generally aligned with moving things out of the `datafusion` repo that ar

[GitHub] [arrow] JabariBooker commented on a change in pull request #12379: ARROW-15215: [C++] Consolidate kernel data-copy utilities between replace_with_mask, case_when, coalesce, choose, fill_null_

2022-02-11 Thread GitBox
JabariBooker commented on a change in pull request #12379: URL: https://github.com/apache/arrow/pull/12379#discussion_r804963653 ## File path: cpp/src/arrow/compute/kernels/copy_data.h ## @@ -0,0 +1,159 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

[GitHub] [arrow-datafusion] alamb commented on issue #1587: Release of DataFusion: 7.0.0

2022-02-11 Thread GitBox
alamb commented on issue #1587: URL: https://github.com/apache/arrow-datafusion/issues/1587#issuecomment-1036567915 I tested publishing `7.0.0-alpha` to crates.io using https://github.com/alamb/arrow-datafusion/tree/alamb/test_publish then going into each crate like this: `c

[GitHub] [arrow-datafusion] matthewmturner commented on pull request #1808: Ensure most of links in docs are correct

2022-02-11 Thread GitBox
matthewmturner commented on pull request #1808: URL: https://github.com/apache/arrow-datafusion/pull/1808#issuecomment-1036555394 thx @HaoYang670 :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow-datafusion] alamb commented on issue #1587: Release of DataFusion: 7.0.0

2022-02-11 Thread GitBox
alamb commented on issue #1587: URL: https://github.com/apache/arrow-datafusion/issues/1587#issuecomment-1036549488 I am going to do a dry run today of publishing datafusion to crates.io (will use an 0.1.xx version to test) -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1811: Fixup some doc warnings

2022-02-11 Thread GitBox
alamb commented on a change in pull request #1811: URL: https://github.com/apache/arrow-datafusion/pull/1811#discussion_r804947819 ## File path: datafusion/src/logical_plan/expr_simplier.rs ## @@ -23,8 +23,10 @@ use crate::execution::context::ExecutionProps; use crate::optimiz

[GitHub] [arrow] ursabot edited a comment on pull request #12393: ARROW-15551: [C++][FlightRPC] Update gRPC TLS options detection for 1.43

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12393: URL: https://github.com/apache/arrow/pull/12393#issuecomment-1036242823 Benchmark runs are scheduled for baseline = 6b65ab29012ac96f0a4e914a280426b7c61e3185 and contender = 90a6f1149a58a6c0b1c5061bd0e67be3e17618a1. 90a6f1149a58a6c0b1c5061bd

[GitHub] [arrow-datafusion] alamb opened a new pull request #1811: Fixup some doc warnings

2022-02-11 Thread GitBox
alamb opened a new pull request #1811: URL: https://github.com/apache/arrow-datafusion/pull/1811 # Which issue does this PR close? follow on to the great work from @HaoYang670 in https://github.com/apache/arrow-datafusion/pull/1808 re: https://github.com/apache/arrow-dataf

[GitHub] [arrow-datafusion] alamb commented on pull request #1808: Ensure most of links in docs are correct

2022-02-11 Thread GitBox
alamb commented on pull request #1808: URL: https://github.com/apache/arrow-datafusion/pull/1808#issuecomment-1036546995 I took a crack at the last warnings here: https://github.com/apache/arrow-datafusion/pull/1811 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow-datafusion] alamb edited a comment on pull request #1807: Update CHANGELOG.md, update release scripts

2022-02-11 Thread GitBox
alamb edited a comment on pull request #1807: URL: https://github.com/apache/arrow-datafusion/pull/1807#issuecomment-1036531280 > I'm interested in learning a bit more about the lifecycle of issues / tags / releases. > once i understand better maybe i could help to get things in order f

[GitHub] [arrow-datafusion] alamb commented on pull request #1807: Update CHANGELOG.md, update release scripts

2022-02-11 Thread GitBox
alamb commented on pull request #1807: URL: https://github.com/apache/arrow-datafusion/pull/1807#issuecomment-1036531280 > I'm interested in learning a bit more about the lifecycle of issues / tags / releases. > once i understand better maybe i could help to get things in order for the

[GitHub] [arrow] ursabot edited a comment on pull request #12248: ARROW-1888: [C++] Implement Struct Casts

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12248: URL: https://github.com/apache/arrow/pull/12248#issuecomment-1036261383 Benchmark runs are scheduled for baseline = 90a6f1149a58a6c0b1c5061bd0e67be3e17618a1 and contender = 3b9462a4ffc9f1d20ffc4ba578adec0f0ed8ffbd. 3b9462a4ffc9f1d20ffc4ba57

[GitHub] [arrow] nealrichardson commented on a change in pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch

2022-02-11 Thread GitBox
nealrichardson commented on a change in pull request #12366: URL: https://github.com/apache/arrow/pull/12366#discussion_r804923776 ## File path: .env ## @@ -76,6 +76,7 @@ ARROW_R_DEV=TRUE R_IMAGE=ubuntu-gcc-release R_ORG=rhub R_PRUNE_DEPS=FALSE +R_DUCKDB_DEV=FALSE Review co

[GitHub] [arrow] jonkeane closed pull request #10167: ARROW-12542: [R] SF columns in datasets with filters [WIP]

2022-02-11 Thread GitBox
jonkeane closed pull request #10167: URL: https://github.com/apache/arrow/pull/10167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow-datafusion] dependabot[bot] commented on pull request #1804: Update sqlparser requirement from 0.13 to 0.14

2022-02-11 Thread GitBox
dependabot[bot] commented on pull request #1804: URL: https://github.com/apache/arrow-datafusion/pull/1804#issuecomment-1036509855 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major

[GitHub] [arrow-datafusion] alamb closed pull request #1804: Update sqlparser requirement from 0.13 to 0.14

2022-02-11 Thread GitBox
alamb closed pull request #1804: URL: https://github.com/apache/arrow-datafusion/pull/1804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb commented on pull request #1796: Update to sqlparser 0.14

2022-02-11 Thread GitBox
alamb commented on pull request #1796: URL: https://github.com/apache/arrow-datafusion/pull/1796#issuecomment-1036509780 Thanks @xudong963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow-datafusion] alamb merged pull request #1796: Update to sqlparser 0.14

2022-02-11 Thread GitBox
alamb merged pull request #1796: URL: https://github.com/apache/arrow-datafusion/pull/1796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow] jonkeane commented on a change in pull request #12339: ARROW-14908: [C++][R] Dataset hash join segfaults on Windows

2022-02-11 Thread GitBox
jonkeane commented on a change in pull request #12339: URL: https://github.com/apache/arrow/pull/12339#discussion_r804911698 ## File path: r/tests/testthat/test-dplyr-join.R ## @@ -249,3 +249,24 @@ test_that("arrow dplyr query correctly filters then joins", { ) ) }) +

[GitHub] [arrow-rs] sum12 opened a new pull request #1301: Json formatted datetime parsing

2022-02-11 Thread GitBox
sum12 opened a new pull request #1301: URL: https://github.com/apache/arrow-rs/pull/1301 # Which issue does this PR close? # Rationale for this change # What changes are included in this PR? The PR reuses the csv parser implementation for date64

[GitHub] [arrow] ursabot edited a comment on pull request #12389: ARROW-13204: [MATLAB] Update documentation for the MATLAB Interface to reflect latest CMake build system changes

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12389: URL: https://github.com/apache/arrow/pull/12389#issuecomment-1034428886 Benchmark runs are scheduled for baseline = 401746bede014cf3d06a88930c282755f151a93b and contender = e4f658761ffec9a69fe1b3ab5e2b01b27a87493c. e4f658761ffec9a69fe1b3ab5

[GitHub] [arrow] github-actions[bot] commented on pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12366: URL: https://github.com/apache/arrow/pull/12366#issuecomment-1036447347 Revision: 3e998258c941dda0a1f1ef97193b79560bf3debe Submitted crossbow builds: [ursacomputing/crossbow @ actions-1618](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] jonkeane commented on pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch

2022-02-11 Thread GitBox
jonkeane commented on pull request #12366: URL: https://github.com/apache/arrow/pull/12366#issuecomment-1036446317 @github-actions crossbow submit test-r-dev-duckdb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] ursabot edited a comment on pull request #12395: ARROW-15653: [R][CI] Fix tests of bundled cpp source

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12395: URL: https://github.com/apache/arrow/pull/12395#issuecomment-1036224834 Benchmark runs are scheduled for baseline = d4b690a29c92768c67a937529c1656b3c2403902 and contender = 6b65ab29012ac96f0a4e914a280426b7c61e3185. 6b65ab29012ac96f0a4e914a2

[GitHub] [arrow] jonkeane removed a comment on pull request #12364: ARROW-15606: [CI] [R] Add brew build that exercises the R package

2022-02-11 Thread GitBox
jonkeane removed a comment on pull request #12364: URL: https://github.com/apache/arrow/pull/12364#issuecomment-1036292423 @github-actions crossbow submit homebrew-r-brew homebrew-cpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] github-actions[bot] removed a comment on pull request #12364: ARROW-15606: [CI] [R] Add brew build that exercises the R package

2022-02-11 Thread GitBox
github-actions[bot] removed a comment on pull request #12364: URL: https://github.com/apache/arrow/pull/12364#issuecomment-1036294095 Revision: 7e0c9480afc65077ef191d8babd2078c3253f35d Submitted crossbow builds: [ursacomputing/crossbow @ actions-1615](https://github.com/ursacomputing

[GitHub] [arrow] ursabot edited a comment on pull request #12393: ARROW-15551: [C++][FlightRPC] Update gRPC TLS options detection for 1.43

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12393: URL: https://github.com/apache/arrow/pull/12393#issuecomment-1036242823 Benchmark runs are scheduled for baseline = 6b65ab29012ac96f0a4e914a280426b7c61e3185 and contender = 90a6f1149a58a6c0b1c5061bd0e67be3e17618a1. 90a6f1149a58a6c0b1c5061bd

[GitHub] [arrow] github-actions[bot] commented on pull request #12364: ARROW-15606: [CI] [R] Add brew build that exercises the R package

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12364: URL: https://github.com/apache/arrow/pull/12364#issuecomment-1036401785 Revision: 7e0c9480afc65077ef191d8babd2078c3253f35d Submitted crossbow builds: [ursacomputing/crossbow @ actions-1617](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] jonkeane commented on pull request #12364: ARROW-15606: [CI] [R] Add brew build that exercises the R package

2022-02-11 Thread GitBox
jonkeane commented on pull request #12364: URL: https://github.com/apache/arrow/pull/12364#issuecomment-1036400403 @github-actions crossbow submit homebrew-r-brew homebrew-cpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] github-actions[bot] commented on pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12366: URL: https://github.com/apache/arrow/pull/12366#issuecomment-1036397554 Revision: 42452ae6b49280354c2401a5e3dac11f2637572b Submitted crossbow builds: [ursacomputing/crossbow @ actions-1616](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] jonkeane commented on pull request #12366: ARROW-15468: [R] [CI] A crossbow job that tests against DuckDB's dev branch [WIP]

2022-02-11 Thread GitBox
jonkeane commented on pull request #12366: URL: https://github.com/apache/arrow/pull/12366#issuecomment-1036396372 @github-actions crossbow submit test-r-dev-duckdb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] soma-cepel commented on issue #12376: Error loading native libraries: java.io.FileNotFoundException: libarrow_dataset_jni.dylib

2022-02-11 Thread GitBox
soma-cepel commented on issue #12376: URL: https://github.com/apache/arrow/issues/12376#issuecomment-1036363893 hi @davisusanibar, I removed all files in Maven's local cache using `rm -rf ~/.m2/repository/org/apache/arrow` and then built again. Now the `~/.m2/repository/org/apache/arrow/ar

[GitHub] [arrow] soma-cepel closed issue #12376: Error loading native libraries: java.io.FileNotFoundException: libarrow_dataset_jni.dylib

2022-02-11 Thread GitBox
soma-cepel closed issue #12376: URL: https://github.com/apache/arrow/issues/12376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [arrow] lidavidm commented on a change in pull request #12379: ARROW-15215: [C++] Consolidate kernel data-copy utilities between replace_with_mask, case_when, coalesce, choose, fill_null_forw

2022-02-11 Thread GitBox
lidavidm commented on a change in pull request #12379: URL: https://github.com/apache/arrow/pull/12379#discussion_r804776997 ## File path: cpp/src/arrow/compute/kernels/copy_data.h ## @@ -0,0 +1,159 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review comme

[GitHub] [arrow] ursabot edited a comment on pull request #12394: ARROW-15648: [C++][Gandiva] Fix the size of the Gandiva cache

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12394: URL: https://github.com/apache/arrow/pull/12394#issuecomment-1035917555 Benchmark runs are scheduled for baseline = fa699117091917f0992225aff4e8d4c08910162a and contender = d4b690a29c92768c67a937529c1656b3c2403902. d4b690a29c92768c67a937529

[GitHub] [arrow] ursabot edited a comment on pull request #12110: ARROW-15212: [C++] Handle suffix argument in joins

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12110: URL: https://github.com/apache/arrow/pull/12110#issuecomment-1034391503 Benchmark runs are scheduled for baseline = 2dfc60c1c921147d9032dd3694e256e1f20bfecd and contender = 401746bede014cf3d06a88930c282755f151a93b. 401746bede014cf3d06a88930

[GitHub] [arrow] ursabot edited a comment on pull request #12395: ARROW-15653: [R][CI] Fix tests of bundled cpp source

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12395: URL: https://github.com/apache/arrow/pull/12395#issuecomment-1036224834 Benchmark runs are scheduled for baseline = d4b690a29c92768c67a937529c1656b3c2403902 and contender = 6b65ab29012ac96f0a4e914a280426b7c61e3185. 6b65ab29012ac96f0a4e914a2

[GitHub] [arrow] nealrichardson commented on a change in pull request #11971: ARROW-15040: [R] Enable write_csv_arrow to take a Dataset or arrow_dplyr_query as input

2022-02-11 Thread GitBox
nealrichardson commented on a change in pull request #11971: URL: https://github.com/apache/arrow/pull/11971#discussion_r804751670 ## File path: r/R/csv.R ## @@ -699,15 +699,21 @@ write_csv_arrow <- function(x, if (is.null(write_options)) { write_options <- readr_to_csv

[GitHub] [arrow] github-actions[bot] commented on pull request #12364: ARROW-15606: [CI] [R] Add brew build that exercises the R package

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12364: URL: https://github.com/apache/arrow/pull/12364#issuecomment-1036294095 Revision: 7e0c9480afc65077ef191d8babd2078c3253f35d Submitted crossbow builds: [ursacomputing/crossbow @ actions-1615](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] jonkeane commented on pull request #12364: ARROW-15606: [CI] [R] Add brew build that exercises the R package

2022-02-11 Thread GitBox
jonkeane commented on pull request #12364: URL: https://github.com/apache/arrow/pull/12364#issuecomment-1036292423 @github-actions crossbow submit homebrew-r-brew homebrew-cpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow-datafusion] matthewmturner commented on pull request #1807: Update CHANGELOG.md, update release scripts

2022-02-11 Thread GitBox
matthewmturner commented on pull request #1807: URL: https://github.com/apache/arrow-datafusion/pull/1807#issuecomment-1036289253 I'm interested in learning a bit more about the lifecycle of issues / tags / releases. @houqp @alamb could you provide a little more info? i didnt see

[GitHub] [arrow] thisisnic commented on a change in pull request #12403: ARROW-15353: [Doc][Guide] Intro into CI topic and link to the existing docs

2022-02-11 Thread GitBox
thisisnic commented on a change in pull request #12403: URL: https://github.com/apache/arrow/pull/12403#discussion_r804710625 ## File path: docs/source/developers/guide/step_by_step/pr_and_github.rst ## @@ -127,6 +127,49 @@ If all is set, you can make the pull request! a

[GitHub] [arrow] thisisnic commented on a change in pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean

2022-02-11 Thread GitBox
thisisnic commented on a change in pull request #12401: URL: https://github.com/apache/arrow/pull/12401#discussion_r804707466 ## File path: docs/source/developers/guide/step_by_step/building.rst ## @@ -155,6 +155,22 @@ Building other Arrow libraries `R developer docs

[GitHub] [arrow] thisisnic commented on a change in pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean

2022-02-11 Thread GitBox
thisisnic commented on a change in pull request #12401: URL: https://github.com/apache/arrow/pull/12401#discussion_r804706379 ## File path: docs/source/developers/guide/step_by_step/building.rst ## @@ -155,6 +155,22 @@ Building other Arrow libraries `R developer docs

[GitHub] [arrow] ursabot edited a comment on pull request #12248: ARROW-1888: [C++] Implement Struct Casts

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12248: URL: https://github.com/apache/arrow/pull/12248#issuecomment-1036261383 Benchmark runs are scheduled for baseline = 90a6f1149a58a6c0b1c5061bd0e67be3e17618a1 and contender = 3b9462a4ffc9f1d20ffc4ba578adec0f0ed8ffbd. 3b9462a4ffc9f1d20ffc4ba57

[GitHub] [arrow] ursabot commented on pull request #12248: ARROW-1888: [C++] Implement Struct Casts

2022-02-11 Thread GitBox
ursabot commented on pull request #12248: URL: https://github.com/apache/arrow/pull/12248#issuecomment-1036261383 Benchmark runs are scheduled for baseline = 90a6f1149a58a6c0b1c5061bd0e67be3e17618a1 and contender = 3b9462a4ffc9f1d20ffc4ba578adec0f0ed8ffbd. 3b9462a4ffc9f1d20ffc4ba578adec0f

[GitHub] [arrow] lidavidm closed pull request #12248: ARROW-1888: [C++] Implement Struct Casts

2022-02-11 Thread GitBox
lidavidm closed pull request #12248: URL: https://github.com/apache/arrow/pull/12248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] dragosmg commented on a change in pull request #12353: ARROW-14471: [R] Implement lubridate's date/time parsing functions

2022-02-11 Thread GitBox
dragosmg commented on a change in pull request #12353: URL: https://github.com/apache/arrow/pull/12353#discussion_r804685267 ## File path: r/R/dplyr-funcs-datetime.R ## @@ -148,4 +148,56 @@ register_bindings_datetime <- function() { !call_binding("am", x) }) + regist

[GitHub] [arrow] ursabot edited a comment on pull request #12393: ARROW-15551: [C++][FlightRPC] Update gRPC TLS options detection for 1.43

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12393: URL: https://github.com/apache/arrow/pull/12393#issuecomment-1036242823 Benchmark runs are scheduled for baseline = 6b65ab29012ac96f0a4e914a280426b7c61e3185 and contender = 90a6f1149a58a6c0b1c5061bd0e67be3e17618a1. 90a6f1149a58a6c0b1c5061bd

[GitHub] [arrow] lidavidm commented on a change in pull request #12368: ARROW-13993: [C++] [Compute] Add hash_one aggregate function

2022-02-11 Thread GitBox
lidavidm commented on a change in pull request #12368: URL: https://github.com/apache/arrow/pull/12368#discussion_r804679025 ## File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc ## @@ -2460,6 +2460,476 @@ TEST(GroupBy, Distinct) { } } +TEST(GroupBy, One) { +

[GitHub] [arrow] lidavidm commented on a change in pull request #12368: ARROW-13993: [C++] [Compute] Add hash_one aggregate function

2022-02-11 Thread GitBox
lidavidm commented on a change in pull request #12368: URL: https://github.com/apache/arrow/pull/12368#discussion_r804677914 ## File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc ## @@ -2460,6 +2460,476 @@ TEST(GroupBy, Distinct) { } } +TEST(GroupBy, One) { +

[GitHub] [arrow] github-actions[bot] commented on pull request #12405: ARROW-15663: [Gandiva][C++] Add TRUNC function

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12405: URL: https://github.com/apache/arrow/pull/12405#issuecomment-1036244432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] ursabot commented on pull request #12393: ARROW-15551: [C++][FlightRPC] Update gRPC TLS options detection for 1.43

2022-02-11 Thread GitBox
ursabot commented on pull request #12393: URL: https://github.com/apache/arrow/pull/12393#issuecomment-1036242823 Benchmark runs are scheduled for baseline = 6b65ab29012ac96f0a4e914a280426b7c61e3185 and contender = 90a6f1149a58a6c0b1c5061bd0e67be3e17618a1. 90a6f1149a58a6c0b1c5061bd0e67be3

[GitHub] [arrow] ursabot edited a comment on pull request #12395: ARROW-15653: [R][CI] Fix tests of bundled cpp source

2022-02-11 Thread GitBox
ursabot edited a comment on pull request #12395: URL: https://github.com/apache/arrow/pull/12395#issuecomment-1036224834 Benchmark runs are scheduled for baseline = d4b690a29c92768c67a937529c1656b3c2403902 and contender = 6b65ab29012ac96f0a4e914a280426b7c61e3185. 6b65ab29012ac96f0a4e914a2

[GitHub] [arrow] lidavidm closed pull request #12393: ARROW-15551: [C++][FlightRPC] Update gRPC TLS options detection for 1.43

2022-02-11 Thread GitBox
lidavidm closed pull request #12393: URL: https://github.com/apache/arrow/pull/12393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] lidavidm commented on pull request #12393: ARROW-15551: [C++][FlightRPC] Update gRPC TLS options detection for 1.43

2022-02-11 Thread GitBox
lidavidm commented on pull request #12393: URL: https://github.com/apache/arrow/pull/12393#issuecomment-1036231474 Thanks, I filed ARROW-15662 to track the upgrade (#11889 might be important there given Abseil issues) -- This is an automated message from the Apache Git Service. To respon

[GitHub] [arrow] github-actions[bot] commented on pull request #12404: ARROW-15661: [Gandiva][C++] Add mask_hash function

2022-02-11 Thread GitBox
github-actions[bot] commented on pull request #12404: URL: https://github.com/apache/arrow/pull/12404#issuecomment-1036226177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] ursabot commented on pull request #12395: ARROW-15653: [R][CI] Fix tests of bundled cpp source

2022-02-11 Thread GitBox
ursabot commented on pull request #12395: URL: https://github.com/apache/arrow/pull/12395#issuecomment-1036224834 Benchmark runs are scheduled for baseline = d4b690a29c92768c67a937529c1656b3c2403902 and contender = 6b65ab29012ac96f0a4e914a280426b7c61e3185. 6b65ab29012ac96f0a4e914a280426b7

  1   2   >