[GitHub] [arrow] kou closed pull request #12457: ARROW-15709: [C++] Compilation of ARROW_ENGINE fails if doing an "inline" build

2022-02-24 Thread GitBox
kou closed pull request #12457: URL: https://github.com/apache/arrow/pull/12457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow-datafusion] Ted-Jiang opened a new pull request #1883: Separate cpu-bound (query-execution) and IO-bound(heartbeat) to …

2022-02-24 Thread GitBox
Ted-Jiang opened a new pull request #1883: URL: https://github.com/apache/arrow-datafusion/pull/1883 …diff tokio runtime in ballista_executor Closes #1770. # Rationale for this change # What changes are included in this PR? No # Are there a

[GitHub] [arrow] kou commented on a change in pull request #12457: ARROW-15709: [C++] Compilation of ARROW_ENGINE fails if doing an "inline" build

2022-02-24 Thread GitBox
kou commented on a change in pull request #12457: URL: https://github.com/apache/arrow/pull/12457#discussion_r814542951 ## File path: cpp/cmake_modules/BuildUtils.cmake ## @@ -375,6 +375,14 @@ function(ADD_ARROW_LIB LIB_NAME) LINK_PRIVATE

[GitHub] [arrow] eelxpeng commented on pull request #12055: ARROW-11989: [C++][Python] Improve ChunkedArray's complexity for the access of elements

2022-02-24 Thread GitBox
eelxpeng commented on pull request #12055: URL: https://github.com/apache/arrow/pull/12055#issuecomment-1050592948 @edponce @pitrou Are you able to complete this pr soon? This issue is bothering us significantly. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] guyuqi commented on pull request #12502: ARROW-15742: [Go] Implement 'bitmap_neon' with Arm64 GoLang Assembly

2022-02-24 Thread GitBox
guyuqi commented on pull request #12502: URL: https://github.com/apache/arrow/pull/12502#issuecomment-1050584614 @zeroshade Fixed related issues in 3rd commit. `TestDefLevelsToBitmap `passed on both x86 and Arm64. In `/arrow/go/parquet/file`: ``` ARM_ENABLE_EXT=NEON go test

[GitHub] [arrow-datafusion] gaojun2048 opened a new issue #1882: UDF/UDAF plugin

2022-02-24 Thread GitBox
gaojun2048 opened a new issue #1882: URL: https://github.com/apache/arrow-datafusion/issues/1882 Now we cannot use UDF and UDAF in ballista because ballista cannot know how to serialize and deserialize UDF / UDAF. We are using Trino. Referring to the practice of Trino, we can realize the

[GitHub] [arrow-datafusion] gaojun2048 opened a new pull request #1881: add udf/udaf plugin

2022-02-24 Thread GitBox
gaojun2048 opened a new pull request #1881: URL: https://github.com/apache/arrow-datafusion/pull/1881 Now we cannot use UDF and UDAF in ballista because ballista cannot know how to serialize and deserialize UDF / UDAF. We are using Trino. Referring to the practice of Trino, we can realiz

[GitHub] [arrow] ursabot edited a comment on pull request #12398: ARROW-15440: [Go] Implement 'unpack_bool' with Arm64 GoLang Assembly

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12398: URL: https://github.com/apache/arrow/pull/12398#issuecomment-1050054321 Benchmark runs are scheduled for baseline = 356dba43f0019c89b02be98d983bcddf2db5f586 and contender = ff9293007129f7dd16435c696e988832ab08170f. ff9293007129f7dd16435c696

[GitHub] [arrow-datafusion] Dandandan commented on pull request #1500: Add support for PartitionBy functionality

2022-02-24 Thread GitBox
Dandandan commented on pull request #1500: URL: https://github.com/apache/arrow-datafusion/pull/1500#issuecomment-1050572054 > I can help take a look into this next week and answer some of your questions if @Dandandan is busy with other things Thanks @houqp ! -- This is an automa

[GitHub] [arrow-datafusion] houqp commented on pull request #1500: Add support for PartitionBy functionality

2022-02-24 Thread GitBox
houqp commented on pull request #1500: URL: https://github.com/apache/arrow-datafusion/pull/1500#issuecomment-1050570899 I can help take a look into this next week and answer some of your questions if @Dandandan is busy with other things -- This is an automated message from the Apache G

[GitHub] [arrow-datafusion] andrei-ionescu opened a new pull request #1500: Add support for PartitionBy functionality

2022-02-24 Thread GitBox
andrei-ionescu opened a new pull request #1500: URL: https://github.com/apache/arrow-datafusion/pull/1500 # Which issue does this PR close? Closes #1404. # Rationale for this change DataFusion lacks support for partition by operation. The most used example is" g

[GitHub] [arrow] ursabot edited a comment on pull request #12507: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12507: URL: https://github.com/apache/arrow/pull/12507#issuecomment-1050157638 Benchmark runs are scheduled for baseline = 9df9bad7d1c37971dab03361df155ce1709fe622 and contender = a26506c8ce2496de6ed68f48972d53f78e19a962. a26506c8ce2496de6ed68f489

[GitHub] [arrow] github-actions[bot] commented on pull request #12406: ARROW-15667: [R] Test development build with ARROW_BUILD_STATIC=OFF

2022-02-24 Thread GitBox
github-actions[bot] commented on pull request #12406: URL: https://github.com/apache/arrow/pull/12406#issuecomment-1050561017 Revision: 8ede3e5fb43f7153bcc512a4185a8705c900a9dd Submitted crossbow builds: [ursacomputing/crossbow @ actions-1680](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] wjones127 commented on pull request #12406: ARROW-15667: [R] Test development build with ARROW_BUILD_STATIC=OFF

2022-02-24 Thread GitBox
wjones127 commented on pull request #12406: URL: https://github.com/apache/arrow/pull/12406#issuecomment-1050560581 @github-actions crossbow submit test-r-devdocs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [arrow] ursabot edited a comment on pull request #12507: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12507: URL: https://github.com/apache/arrow/pull/12507#issuecomment-1050157638 Benchmark runs are scheduled for baseline = 9df9bad7d1c37971dab03361df155ce1709fe622 and contender = a26506c8ce2496de6ed68f48972d53f78e19a962. a26506c8ce2496de6ed68f489

[GitHub] [arrow] github-actions[bot] commented on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_start when rounding to multiple of week

2022-02-24 Thread GitBox
github-actions[bot] commented on pull request #12515: URL: https://github.com/apache/arrow/pull/12515#issuecomment-1050554952 https://issues.apache.org/jira/browse/ARROW-15680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] rok opened a new pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_start when rounding to multiple of week

2022-02-24 Thread GitBox
rok opened a new pull request #12515: URL: https://github.com/apache/arrow/pull/12515 This is to resolve [ARROW-15680](https://issues.apache.org/jira/browse/ARROW-15680). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] AlenkaF commented on pull request #12505: ARROW-15291: [C++][Python] Segfault in StructArray.to_numpy and to_pandas if it contains an ExtensionArray

2022-02-24 Thread GitBox
AlenkaF commented on pull request #12505: URL: https://github.com/apache/arrow/pull/12505#issuecomment-1050549538 @jorisvandenbossche the error seems unrelated, I think it is ready for another round of review. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] iajoiner commented on pull request #11779: ARROW-13231: [Doc] Add ORC documentation

2022-02-24 Thread GitBox
iajoiner commented on pull request #11779: URL: https://github.com/apache/arrow/pull/11779#issuecomment-1050538103 @jorisvandenbossche @pitrou This is the first time I have ever written user guides. Could you guys please check whether there is stuff that is seriously wrong? I will iron ou

[GitHub] [arrow] cyb70289 commented on a change in pull request #12465: ARROW-15282: [C++][FlightRPC] Split data methods from the underlying transport

2022-02-24 Thread GitBox
cyb70289 commented on a change in pull request #12465: URL: https://github.com/apache/arrow/pull/12465#discussion_r814468755 ## File path: cpp/src/arrow/flight/transport_server_impl.cc ## @@ -0,0 +1,320 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

[GitHub] [arrow] ursabot edited a comment on pull request #12508: MINOR: [R] lint in test_duckdb

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12508: URL: https://github.com/apache/arrow/pull/12508#issuecomment-1050142125 Benchmark runs are scheduled for baseline = efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1 and contender = 9df9bad7d1c37971dab03361df155ce1709fe622. 9df9bad7d1c37971dab03361d

[GitHub] [arrow] ursabot edited a comment on pull request #12453: ARROW-15715: [Go] ipc trim value offsets on arrays

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12453: URL: https://github.com/apache/arrow/pull/12453#issuecomment-1050054310 Benchmark runs are scheduled for baseline = 82f8ee3f5fbfc7f4a90479c744c7f658b854dc9f and contender = 356dba43f0019c89b02be98d983bcddf2db5f586. 356dba43f0019c89b02be98d9

[GitHub] [arrow] ursabot edited a comment on pull request #12508: MINOR: [R] lint in test_duckdb

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12508: URL: https://github.com/apache/arrow/pull/12508#issuecomment-1050142125 Benchmark runs are scheduled for baseline = efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1 and contender = 9df9bad7d1c37971dab03361df155ce1709fe622. 9df9bad7d1c37971dab03361d

[GitHub] [arrow-rs] HaoYang670 commented on pull request #1361: Refactor `RecordBatch::validate_new_batch`

2022-02-24 Thread GitBox
HaoYang670 commented on pull request #1361: URL: https://github.com/apache/arrow-rs/pull/1361#issuecomment-1050497354 Rebuild after #1362 is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [arrow-datafusion] houqp commented on issue #1880: `cargo clippy` fails on the `master` branch

2022-02-24 Thread GitBox
houqp commented on issue #1880: URL: https://github.com/apache/arrow-datafusion/issues/1880#issuecomment-1050493692 This happens on almost every rust release :D @HaoYang670 please feel free to send a PR to fix those warnings. -- This is an automated message from the Apache Git Service.

[GitHub] [arrow] github-actions[bot] commented on pull request #12514: ARROW-15784: [C++][Python] Removing flag enable_parallel_column_conversion which is no longer used

2022-02-24 Thread GitBox
github-actions[bot] commented on pull request #12514: URL: https://github.com/apache/arrow/pull/12514#issuecomment-1050478829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] cyb70289 commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
cyb70289 commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r81011 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -81,7 +81,15 @@ RecordBatchIterator RecordBatchSliceIterator(const RecordBatch& batch, // Counts the

[GitHub] [arrow-datafusion] HaoYang670 commented on issue #1880: `cargo clippy` fails on the `master` branch

2022-02-24 Thread GitBox
HaoYang670 commented on issue #1880: URL: https://github.com/apache/arrow-datafusion/issues/1880#issuecomment-1050472901 @houqp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [arrow-datafusion] HaoYang670 opened a new issue #1880: `cargo clippy` fails on the `master` branch

2022-02-24 Thread GitBox
HaoYang670 opened a new issue #1880: URL: https://github.com/apache/arrow-datafusion/issues/1880 **Describe the bug** After update `rustup` to the ;latest version `rustc 1.59.0`, running `cargo clippy` on master branch fails. **To Reproduce** 1. update rustup to the latest vers

[GitHub] [arrow-rs] HaoYang670 opened a new issue #1362: `cargo clippy` fails on the `master` branch

2022-02-24 Thread GitBox
HaoYang670 opened a new issue #1362: URL: https://github.com/apache/arrow-rs/issues/1362 **Describe the bug** After update `rustup` to the ;latest version `rustc 1.59.0`, running `cargo clippy` on master branch fails. **To Reproduce** 1. update rustup to the latest version ` ru

[GitHub] [arrow-datafusion] JasonLi-cn opened a new issue #1879: CoalesceBatchesStream poll_next_inner function bug

2022-02-24 Thread GitBox
JasonLi-cn opened a new issue #1879: URL: https://github.com/apache/arrow-datafusion/issues/1879 **Describe the bug** SQL: select * from table where col1 = 'datafusion' limit 10; Some files are still being read after the result is returned。 Because: [https://github.com/apach

[GitHub] [arrow] ursabot edited a comment on pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12503: URL: https://github.com/apache/arrow/pull/12503#issuecomment-1050116628 Benchmark runs are scheduled for baseline = ae1ce197306eecd5b887577784eb204f3488a688 and contender = efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1. efbc1cd5fad6c1a5dbe8189c8

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1361: Refactor `RecordBatch::validate_new_batch`

2022-02-24 Thread GitBox
codecov-commenter commented on pull request #1361: URL: https://github.com/apache/arrow-rs/pull/1361#issuecomment-1050451175 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1361?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow] ursabot edited a comment on pull request #12503: ARROW-15772: [Go][Flight] Server Basic Auth Middleware/Interceptor wrongly base64 decode

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12503: URL: https://github.com/apache/arrow/pull/12503#issuecomment-1050116628 Benchmark runs are scheduled for baseline = ae1ce197306eecd5b887577784eb204f3488a688 and contender = efbc1cd5fad6c1a5dbe8189c82b293f8e1f9b6b1. efbc1cd5fad6c1a5dbe8189c8

[GitHub] [arrow-rs] HaoYang670 commented on pull request #1361: Refactor `RecordBatch::validate_new_batch`

2022-02-24 Thread GitBox
HaoYang670 commented on pull request #1361: URL: https://github.com/apache/arrow-rs/pull/1361#issuecomment-1050445770 # Performance run `cargo bench -- json_list_primitive_to_record_batch` ## Before ```bash json_list_primitive_to_record_batch

[GitHub] [arrow] cyb70289 commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
cyb70289 commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r814420890 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -328,6 +359,31 @@ class QuotedColumnPopulator : public ColumnPopulator { } private: + // Returns

[GitHub] [arrow-rs] HaoYang670 opened a new pull request #1361: Refactor `RecordBatch::validate_new_batch`

2022-02-24 Thread GitBox
HaoYang670 opened a new pull request #1361: URL: https://github.com/apache/arrow-rs/pull/1361 # Which issue does this PR close? Closes #1350. # Rationale for this change There is some repetitive code in the function `validate_new_batch`, which are not easy to maintain. We rewri

[GitHub] [arrow] cyb70289 commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
cyb70289 commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r814418677 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -328,6 +359,31 @@ class QuotedColumnPopulator : public ColumnPopulator { } private: + // Returns

[GitHub] [arrow] ursabot edited a comment on pull request #12421: ARROW-5248: [Python] support zoneinfo / dateutil timezones

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12421: URL: https://github.com/apache/arrow/pull/12421#issuecomment-1050017150 Benchmark runs are scheduled for baseline = 094c5ba186cddd69d4aa83de5ed2b62d4ed07081 and contender = 82f8ee3f5fbfc7f4a90479c744c7f658b854dc9f. 82f8ee3f5fbfc7f4a90479c74

[GitHub] [arrow] cyb70289 commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
cyb70289 commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r814405967 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -265,24 +279,41 @@ class QuotedColumnPopulator : public ColumnPopulator { Status UpdateRowLengths(in

[GitHub] [arrow] github-actions[bot] commented on pull request #12513: ARROW-15782 [C++] Fix Findre2Alt.cmake to check RE2_ROOT variable first

2022-02-24 Thread GitBox
github-actions[bot] commented on pull request #12513: URL: https://github.com/apache/arrow/pull/12513#issuecomment-1050413688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] ursabot edited a comment on pull request #12091: ARROW-14798: [C++][Python][R] Add container window to PrettyPrintOptions

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12091: URL: https://github.com/apache/arrow/pull/12091#issuecomment-1050090463 Benchmark runs are scheduled for baseline = ff9293007129f7dd16435c696e988832ab08170f and contender = ae1ce197306eecd5b887577784eb204f3488a688. ae1ce197306eecd5b88757778

[GitHub] [arrow-cookbook] lidavidm merged pull request #153: [C++] gRPC settings and custom endpoint examples

2022-02-24 Thread GitBox
lidavidm merged pull request #153: URL: https://github.com/apache/arrow-cookbook/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [arrow-cookbook] lidavidm closed issue #106: [C++] Add annotated gRPC + Flight service example

2022-02-24 Thread GitBox
lidavidm closed issue #106: URL: https://github.com/apache/arrow-cookbook/issues/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] ursabot edited a comment on pull request #12439: ARROW-15697: [R] Add logo and meta tags to pkgdown site

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12439: URL: https://github.com/apache/arrow/pull/12439#issuecomment-1050362891 Benchmark runs are scheduled for baseline = fffdca2b9bf0245d5022b30eafcea6e3f1b57894 and contender = acfd1d2f8c8d51b409bdceb0565d3fdb9cb6be0a. acfd1d2f8c8d51b409bdceb05

[GitHub] [arrow] github-actions[bot] commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled

2022-02-24 Thread GitBox
github-actions[bot] commented on pull request #12422: URL: https://github.com/apache/arrow/pull/12422#issuecomment-1050369625 Revision: 20ca138cc08d0a2833ed98b37a51d07f23f3dd51 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1679](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] jonkeane commented on pull request #12422: [WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled

2022-02-24 Thread GitBox
jonkeane commented on pull request #12422: URL: https://github.com/apache/arrow/pull/12422#issuecomment-1050369040 @github-actions crossbow submit test-r-minsizerel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #12512: Minor: [C++] Allow MinSizeRel builds

2022-02-24 Thread GitBox
github-actions[bot] commented on pull request #12512: URL: https://github.com/apache/arrow/pull/12512#issuecomment-1050363577 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you op

[GitHub] [arrow] jonkeane opened a new pull request #12512: Minor: Allow MinSizeRel builds

2022-02-24 Thread GitBox
jonkeane opened a new pull request #12512: URL: https://github.com/apache/arrow/pull/12512 This is pulling a few changes from #12422 that are useful, even if we can't yet add a crossbow job for it. cc @pitrou -- This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] ursabot commented on pull request #12439: ARROW-15697: [R] Add logo and meta tags to pkgdown site

2022-02-24 Thread GitBox
ursabot commented on pull request #12439: URL: https://github.com/apache/arrow/pull/12439#issuecomment-1050362891 Benchmark runs are scheduled for baseline = fffdca2b9bf0245d5022b30eafcea6e3f1b57894 and contender = acfd1d2f8c8d51b409bdceb0565d3fdb9cb6be0a. acfd1d2f8c8d51b409bdceb0565d3fdb

[GitHub] [arrow] jonkeane closed pull request #12439: ARROW-15697: [R] Add logo and meta tags to pkgdown site

2022-02-24 Thread GitBox
jonkeane closed pull request #12439: URL: https://github.com/apache/arrow/pull/12439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow-cookbook] lidavidm commented on a change in pull request #153: [C++] gRPC settings and custom endpoint examples

2022-02-24 Thread GitBox
lidavidm commented on a change in pull request #153: URL: https://github.com/apache/arrow-cookbook/pull/153#discussion_r814355176 ## File path: cpp/source/flight.rst ## @@ -83,3 +83,72 @@ Finally, we'll stop our server: .. recipe:: ../code/flight.cc ParquetStorageService::St

[GitHub] [arrow-cookbook] wjones127 commented on a change in pull request #153: [C++] gRPC settings and custom endpoint examples

2022-02-24 Thread GitBox
wjones127 commented on a change in pull request #153: URL: https://github.com/apache/arrow-cookbook/pull/153#discussion_r814355218 ## File path: cpp/code/flight.cc ## @@ -291,4 +307,99 @@ arrow::Status TestPutGetDelete() { return arrow::Status::OK(); } +arrow::Status Test

[GitHub] [arrow-cookbook] wjones127 commented on a change in pull request #153: [C++] gRPC settings and custom endpoint examples

2022-02-24 Thread GitBox
wjones127 commented on a change in pull request #153: URL: https://github.com/apache/arrow-cookbook/pull/153#discussion_r814354812 ## File path: cpp/code/CMakeLists.txt ## @@ -13,12 +13,21 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang") set(CMAKE_CXX_CLANG_TIDY "clang-tidy"

[GitHub] [arrow] jonkeane commented on a change in pull request #12433: ARROW-14808 [R] Implement bindings for `lubridate::date()`

2022-02-24 Thread GitBox
jonkeane commented on a change in pull request #12433: URL: https://github.com/apache/arrow/pull/12433#discussion_r814346290 ## File path: r/R/dplyr-funcs-type.R ## @@ -76,6 +76,13 @@ register_bindings_type_cast <- function() { register_binding("as.numeric", function(x) {

[GitHub] [arrow] ursabot edited a comment on pull request #12267: ARROW-15258: [C++] Easy options to create a source node from a table

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12267: URL: https://github.com/apache/arrow/pull/12267#issuecomment-1050340033 Benchmark runs are scheduled for baseline = a26506c8ce2496de6ed68f48972d53f78e19a962 and contender = fffdca2b9bf0245d5022b30eafcea6e3f1b57894. fffdca2b9bf0245d5022b30ea

[GitHub] [arrow] jonkeane commented on a change in pull request #12319: ARROW-14199 [R] bindings for format (where possible)

2022-02-24 Thread GitBox
jonkeane commented on a change in pull request #12319: URL: https://github.com/apache/arrow/pull/12319#discussion_r814342940 ## File path: r/R/dplyr-funcs-datetime.R ## @@ -140,3 +140,25 @@ register_bindings_datetime <- function() { (year %% 4 == 0) & ((year %% 100 != 0) |

[GitHub] [arrow] ursabot commented on pull request #12267: ARROW-15258: [C++] Easy options to create a source node from a table

2022-02-24 Thread GitBox
ursabot commented on pull request #12267: URL: https://github.com/apache/arrow/pull/12267#issuecomment-1050340033 Benchmark runs are scheduled for baseline = a26506c8ce2496de6ed68f48972d53f78e19a962 and contender = fffdca2b9bf0245d5022b30eafcea6e3f1b57894. fffdca2b9bf0245d5022b30eafcea6e3

[GitHub] [arrow] wjones127 commented on issue #12496: [Flight][Go] Support for metadata requests

2022-02-24 Thread GitBox
wjones127 commented on issue #12496: URL: https://github.com/apache/arrow/issues/12496#issuecomment-1050340069 @stoffeastrom Those are for FlightSQL, which is built on top of Flight RPC. FlightSQL is brand new to the Java and C++ implementations, and isn't implemented in Go yet. -- This

[GitHub] [arrow] ursabot edited a comment on pull request #12500: ARROW-15770: [CI] Not all python tests are running on CI jobs

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12500: URL: https://github.com/apache/arrow/pull/12500#issuecomment-1049658013 Benchmark runs are scheduled for baseline = 7c7abadd79d9f7ce530c8caae7c36e3c39425e2d and contender = 094c5ba186cddd69d4aa83de5ed2b62d4ed07081. 094c5ba186cddd69d4aa83de5

[GitHub] [arrow] westonpace closed pull request #12267: ARROW-15258: [C++] Easy options to create a source node from a table

2022-02-24 Thread GitBox
westonpace closed pull request #12267: URL: https://github.com/apache/arrow/pull/12267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsu

[GitHub] [arrow] jvanstraten commented on a change in pull request #12457: ARROW-15709: [C++] Compilation of ARROW_ENGINE fails if doing an "inline" build

2022-02-24 Thread GitBox
jvanstraten commented on a change in pull request #12457: URL: https://github.com/apache/arrow/pull/12457#discussion_r814318664 ## File path: cpp/cmake_modules/BuildUtils.cmake ## @@ -375,6 +375,14 @@ function(ADD_ARROW_LIB LIB_NAME) LINK_PRIVATE

[GitHub] [arrow] jvanstraten commented on a change in pull request #12457: ARROW-15709: [C++] Compilation of ARROW_ENGINE fails if doing an "inline" build

2022-02-24 Thread GitBox
jvanstraten commented on a change in pull request #12457: URL: https://github.com/apache/arrow/pull/12457#discussion_r814318345 ## File path: cpp/cmake_modules/BuildUtils.cmake ## @@ -375,6 +375,14 @@ function(ADD_ARROW_LIB LIB_NAME) LINK_PRIVATE

[GitHub] [arrow] jvanstraten commented on a change in pull request #12457: ARROW-15709: [C++] Compilation of ARROW_ENGINE fails if doing an "inline" build

2022-02-24 Thread GitBox
jvanstraten commented on a change in pull request #12457: URL: https://github.com/apache/arrow/pull/12457#discussion_r814317387 ## File path: cpp/cmake_modules/ThirdpartyToolchain.cmake ## @@ -1605,6 +1623,87 @@ if(ARROW_WITH_PROTOBUF) message(STATUS "Found protobuf headers:

[GitHub] [arrow] ursabot edited a comment on pull request #12398: ARROW-15440: [Go] Implement 'unpack_bool' with Arm64 GoLang Assembly

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12398: URL: https://github.com/apache/arrow/pull/12398#issuecomment-1050054321 Benchmark runs are scheduled for baseline = 356dba43f0019c89b02be98d983bcddf2db5f586 and contender = ff9293007129f7dd16435c696e988832ab08170f. ff9293007129f7dd16435c696

[GitHub] [arrow] emkornfield commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r814309331 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -265,24 +279,41 @@ class QuotedColumnPopulator : public ColumnPopulator { Status UpdateRowLengths

[GitHub] [arrow] emkornfield commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r814308037 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -170,11 +178,17 @@ class UnquotedColumnPopulator : public ColumnPopulator { RETURN_NOT_OK(Check

[GitHub] [arrow] emkornfield commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r814307720 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -328,6 +359,31 @@ class QuotedColumnPopulator : public ColumnPopulator { } private: + // Retur

[GitHub] [arrow] emkornfield commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r814305971 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -328,6 +359,31 @@ class QuotedColumnPopulator : public ColumnPopulator { } private: + // Retur

[GitHub] [arrow] emkornfield commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r814302649 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -81,7 +81,15 @@ RecordBatchIterator RecordBatchSliceIterator(const RecordBatch& batch, // Counts t

[GitHub] [arrow] emkornfield commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r814301794 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -328,6 +359,31 @@ class QuotedColumnPopulator : public ColumnPopulator { } private: + // Retur

[GitHub] [arrow] emkornfield commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r814301794 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -328,6 +359,31 @@ class QuotedColumnPopulator : public ColumnPopulator { } private: + // Retur

[GitHub] [arrow] emkornfield commented on a change in pull request #12504: ARROW-15763: [C++] Improve CSV writer

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #12504: URL: https://github.com/apache/arrow/pull/12504#discussion_r814297936 ## File path: cpp/src/arrow/csv/writer.cc ## @@ -328,6 +359,31 @@ class QuotedColumnPopulator : public ColumnPopulator { } private: + // Retur

[GitHub] [arrow] lidavidm commented on pull request #12509: ARROW-15781: [Python] Release GIL in ensure_complete_metadata

2022-02-24 Thread GitBox
lidavidm commented on pull request #12509: URL: https://github.com/apache/arrow/pull/12509#issuecomment-1050274094 Got it. We do have [nightly packages](https://arrow.apache.org/docs/dev/python/install.html#installing-nightly-packages) for conda/pip so you can test a little sooner than tha

[GitHub] [arrow-datafusion] matthewmturner commented on pull request #1878: Update datafusion-cli allocator

2022-02-24 Thread GitBox
matthewmturner commented on pull request #1878: URL: https://github.com/apache/arrow-datafusion/pull/1878#issuecomment-1050269187 @Dandandan @houqp FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow-datafusion] matthewmturner opened a new pull request #1878: Update datafusion-cli allocator

2022-02-24 Thread GitBox
matthewmturner opened a new pull request #1878: URL: https://github.com/apache/arrow-datafusion/pull/1878 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing c

[GitHub] [arrow-julia] codecov-commenter edited a comment on pull request #290: Add release scripts

2022-02-24 Thread GitBox
codecov-commenter edited a comment on pull request #290: URL: https://github.com/apache/arrow-julia/pull/290#issuecomment-1049509633 # [Codecov](https://codecov.io/gh/apache/arrow-julia/pull/290?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[GitHub] [arrow] rok commented on a change in pull request #12507: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`

2022-02-24 Thread GitBox
rok commented on a change in pull request #12507: URL: https://github.com/apache/arrow/pull/12507#discussion_r814265295 ## File path: python/pyarrow/tests/test_compute.py ## @@ -2032,6 +2032,11 @@ def _check_temporal_rounding(ts, values, unit): expected = ts.dt.round(f

[GitHub] [arrow] github-actions[bot] commented on pull request #12511: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`. Follow-up

2022-02-24 Thread GitBox
github-actions[bot] commented on pull request #12511: URL: https://github.com/apache/arrow/pull/12511#issuecomment-1050256162 https://issues.apache.org/jira/browse/ARROW-15748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] rok opened a new pull request #12511: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`. Follow-up

2022-02-24 Thread GitBox
rok opened a new pull request #12511: URL: https://github.com/apache/arrow/pull/12511 This is a follow-up to https://github.com/apache/arrow/pull/12507 to address @jorisvandenbossche's [comment](https://github.com/apache/arrow/pull/12507#pullrequestreview-892910661). -- This is an autom

[GitHub] [arrow] escobargabriel closed pull request #12510: Fix to Date, Time and Timestamp types.

2022-02-24 Thread GitBox
escobargabriel closed pull request #12510: URL: https://github.com/apache/arrow/pull/12510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow] ericl commented on pull request #12509: ARROW-15781: [Python] Release GIL in ensure_complete_metadata

2022-02-24 Thread GitBox
ericl commented on pull request #12509: URL: https://github.com/apache/arrow/pull/12509#issuecomment-1050248549 I ran into some trouble building pyarrow, but the above test case looks great :+1: Looking forwards to trying it out in the next release. -- This is an automated message from

[GitHub] [arrow] github-actions[bot] commented on pull request #12510: Fix to Date, Time and Timestamp types.

2022-02-24 Thread GitBox
github-actions[bot] commented on pull request #12510: URL: https://github.com/apache/arrow/pull/12510#issuecomment-1050247746 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you op

[GitHub] [arrow] escobargabriel opened a new pull request #12510: Fix to Date, Time and Timestamp types.

2022-02-24 Thread GitBox
escobargabriel opened a new pull request #12510: URL: https://github.com/apache/arrow/pull/12510 Make these types return a SQL exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [arrow-datafusion] andrei-ionescu commented on pull request #1500: Add support for PartitionBy functionality

2022-02-24 Thread GitBox
andrei-ionescu commented on pull request #1500: URL: https://github.com/apache/arrow-datafusion/pull/1500#issuecomment-1050238261 @alamb, @houqp: I don't know why this PR was considered stalled and closed when the last comment was mine and this PR is waiting feedback from your side. I don

[GitHub] [arrow-julia] kou commented on a change in pull request #290: Add release scripts

2022-02-24 Thread GitBox
kou commented on a change in pull request #290: URL: https://github.com/apache/arrow-julia/pull/290#discussion_r814245966 ## File path: dev/release/README.md ## @@ -0,0 +1,98 @@ + + +# Release + +## Overview + + 1. Test the revision to be released + 2. Increment version numbe

[GitHub] [arrow] stoffeastrom commented on issue #12496: [Flight][Go] Support for metadata requests

2022-02-24 Thread GitBox
stoffeastrom commented on issue #12496: URL: https://github.com/apache/arrow/issues/12496#issuecomment-1050235527 I was trying to find these ```yaml CommandGetCatalogs: list catalogs in a database. CommandGetCrossReference: list foreign key columns that reference a particular o

[GitHub] [arrow-julia] ericphanson commented on a change in pull request #290: Add release scripts

2022-02-24 Thread GitBox
ericphanson commented on a change in pull request #290: URL: https://github.com/apache/arrow-julia/pull/290#discussion_r814241162 ## File path: dev/release/README.md ## @@ -0,0 +1,98 @@ + + +# Release + +## Overview + + 1. Test the revision to be released + 2. Increment versi

[GitHub] [arrow] ursabot edited a comment on pull request #12426: ARROW-15672: [C++] Enable CSV writer to control the field delimiter

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12426: URL: https://github.com/apache/arrow/pull/12426#issuecomment-1049424643 Benchmark runs are scheduled for baseline = effed6bb7c226cf4895b7e6804d70f71b861c06a and contender = 7c7abadd79d9f7ce530c8caae7c36e3c39425e2d. 7c7abadd79d9f7ce530c8caae

[GitHub] [arrow] ursabot edited a comment on pull request #12453: ARROW-15715: [Go] ipc trim value offsets on arrays

2022-02-24 Thread GitBox
ursabot edited a comment on pull request #12453: URL: https://github.com/apache/arrow/pull/12453#issuecomment-1050054310 Benchmark runs are scheduled for baseline = 82f8ee3f5fbfc7f4a90479c744c7f658b854dc9f and contender = 356dba43f0019c89b02be98d983bcddf2db5f586. 356dba43f0019c89b02be98d9

[GitHub] [arrow-julia] kou commented on a change in pull request #290: Add release scripts

2022-02-24 Thread GitBox
kou commented on a change in pull request #290: URL: https://github.com/apache/arrow-julia/pull/290#discussion_r814228861 ## File path: dev/release/README.md ## @@ -0,0 +1,94 @@ + + +# Release + +## Overview + + 1. Test the revision to be released + 2. Increment version numbe

[GitHub] [arrow] emkornfield commented on a change in pull request #11982: ARROW-15313: [C++][Java][FlightRPC] Implement type info method to flight-sql

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #11982: URL: https://github.com/apache/arrow/pull/11982#discussion_r814228599 ## File path: java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java ## @@ -433,6 +483,52 @@ private static V

[GitHub] [arrow] emkornfield commented on a change in pull request #11982: ARROW-15313: [C++][Java][FlightRPC] Implement type info method to flight-sql

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #11982: URL: https://github.com/apache/arrow/pull/11982#discussion_r814228110 ## File path: java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java ## @@ -433,6 +483,52 @@ private static V

[GitHub] [arrow] emkornfield commented on a change in pull request #11982: ARROW-15313: [C++][Java][FlightRPC] Implement type info method to flight-sql

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #11982: URL: https://github.com/apache/arrow/pull/11982#discussion_r814227031 ## File path: java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java ## @@ -375,29 +388,66 @@ private static

[GitHub] [arrow] emkornfield commented on a change in pull request #11982: ARROW-15313: [C++][Java][FlightRPC] Implement type info method to flight-sql

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #11982: URL: https://github.com/apache/arrow/pull/11982#discussion_r814226648 ## File path: java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java ## @@ -375,29 +388,66 @@ private static

[GitHub] [arrow] emkornfield commented on a change in pull request #11982: ARROW-15313: [C++][Java][FlightRPC] Implement type info method to flight-sql

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #11982: URL: https://github.com/apache/arrow/pull/11982#discussion_r814221275 ## File path: format/FlightSql.proto ## @@ -867,6 +867,185 @@ enum SqlSupportsConvert { SQL_CONVERT_VARCHAR = 19; } +/** + * It is an attribute

[GitHub] [arrow] emkornfield commented on a change in pull request #11982: ARROW-15313: [C++][Java][FlightRPC] Implement type info method to flight-sql

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #11982: URL: https://github.com/apache/arrow/pull/11982#discussion_r814220203 ## File path: format/FlightSql.proto ## @@ -867,6 +867,188 @@ enum SqlSupportsConvert { SQL_CONVERT_VARCHAR = 19; } +/** + * It is an attribute

[GitHub] [arrow] emkornfield commented on a change in pull request #11982: ARROW-15313: [C++][Java][FlightRPC] Implement type info method to flight-sql

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #11982: URL: https://github.com/apache/arrow/pull/11982#discussion_r814219931 ## File path: format/FlightSql.proto ## @@ -867,6 +867,185 @@ enum SqlSupportsConvert { SQL_CONVERT_VARCHAR = 19; } +/** + * It is an attribute

[GitHub] [arrow] emkornfield commented on a change in pull request #11982: ARROW-15313: [C++][Java][FlightRPC] Implement type info method to flight-sql

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #11982: URL: https://github.com/apache/arrow/pull/11982#discussion_r814219379 ## File path: format/FlightSql.proto ## @@ -867,6 +867,188 @@ enum SqlSupportsConvert { SQL_CONVERT_VARCHAR = 19; } +/** + * It is an attribute

[GitHub] [arrow] emkornfield commented on a change in pull request #11982: ARROW-15313: [C++][Java][FlightRPC] Implement type info method to flight-sql

2022-02-24 Thread GitBox
emkornfield commented on a change in pull request #11982: URL: https://github.com/apache/arrow/pull/11982#discussion_r814219216 ## File path: format/FlightSql.proto ## @@ -867,6 +867,188 @@ enum SqlSupportsConvert { SQL_CONVERT_VARCHAR = 19; } +/** + * It is an attribute

  1   2   3   >