[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #2008: Support more ScalarFunction in Ballista

2022-03-14 Thread GitBox
yjshen commented on a change in pull request #2008: URL: https://github.com/apache/arrow-datafusion/pull/2008#discussion_r826624259 ## File path: datafusion-proto/src/from_proto.rs ## @@ -992,32 +1017,86 @@ impl TryFrom<&protobuf::LogicalExprNode> for Expr {

[GitHub] [arrow-datafusion] yjshen commented on pull request #1998: Merge dataframe and dataframe imp

2022-03-14 Thread GitBox
yjshen commented on pull request #1998: URL: https://github.com/apache/arrow-datafusion/pull/1998#issuecomment-1067616969 Thanks @vchag @xudong963 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow-datafusion] yjshen closed issue #1962: Merge Dataframe trait and DataframeImpl into Dataframe struct

2022-03-14 Thread GitBox
yjshen closed issue #1962: URL: https://github.com/apache/arrow-datafusion/issues/1962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsu

[GitHub] [arrow-datafusion] yjshen merged pull request #1998: Merge dataframe and dataframe imp

2022-03-14 Thread GitBox
yjshen merged pull request #1998: URL: https://github.com/apache/arrow-datafusion/pull/1998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github

[GitHub] [arrow-datafusion] xudong963 commented on issue #2014: Cannot run examples of ballista

2022-03-14 Thread GitBox
xudong963 commented on issue #2014: URL: https://github.com/apache/arrow-datafusion/issues/2014#issuecomment-1067612251 Have you ever run `export ARROW_TEST_DATA=$(pwd)/testing/data/`? https://github.com/apache/arrow-datafusion/blob/master/CONTRIBUTING.md#bootstrap-environment -- Th

[GitHub] [arrow-rs] viirya commented on a change in pull request #1444: Add Full UnionArray validation

2022-03-14 Thread GitBox
viirya commented on a change in pull request #1444: URL: https://github.com/apache/arrow-rs/pull/1444#discussion_r826613832 ## File path: arrow/src/array/data.rs ## @@ -1117,6 +1119,44 @@ impl ArrayData { ) } +/// Ensures that for each union element, the off

[GitHub] [arrow-rs] viirya commented on a change in pull request #1432: Replace Arc with Box in ArrowArray for FFI structs

2022-03-14 Thread GitBox
viirya commented on a change in pull request #1432: URL: https://github.com/apache/arrow-rs/pull/1432#discussion_r826611252 ## File path: arrow/src/array/array.rs ## @@ -629,7 +629,9 @@ pub unsafe fn make_array_from_raw( schema: *const ffi::FFI_ArrowSchema, ) -> Result {

[GitHub] [arrow] ursabot edited a comment on pull request #12600: ARROW-15900: [C++] Support Substrait reading of a Feather-format local file

2022-03-14 Thread GitBox
ursabot edited a comment on pull request #12600: URL: https://github.com/apache/arrow/pull/12600#issuecomment-1067259148 Benchmark runs are scheduled for baseline = 0b19a68b0aa8eee46ea653a3ce98854d956dafc0 and contender = 73bb8ea0c770fda92f1231b471565ff6592a7386. 73bb8ea0c770fda92f1231b47

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1446: Fix generate_interval_case in integration test

2022-03-14 Thread GitBox
codecov-commenter commented on pull request #1446: URL: https://github.com/apache/arrow-rs/pull/1446#issuecomment-1067600965 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow-rs] sunchao commented on a change in pull request #1432: Replace Arc with Box in ArrowArray for FFI structs

2022-03-14 Thread GitBox
sunchao commented on a change in pull request #1432: URL: https://github.com/apache/arrow-rs/pull/1432#discussion_r826608711 ## File path: arrow/src/array/array.rs ## @@ -629,7 +629,9 @@ pub unsafe fn make_array_from_raw( schema: *const ffi::FFI_ArrowSchema, ) -> Result {

[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

2022-03-14 Thread GitBox
viirya edited a comment on issue #1404: URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726 Working list: * generate_decimal128_case (fixed: #1439) * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few poin

[GitHub] [arrow-rs] viirya commented on issue #1404: Triage remaining integration test failures with other Arrow implementations

2022-03-14 Thread GitBox
viirya commented on issue #1404: URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067596367 I will work on above list one by one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

2022-03-14 Thread GitBox
viirya edited a comment on issue #1404: URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726 Working list: * generate_decimal128_case (fixed: #1439) * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet) * generate

[GitHub] [arrow-datafusion] doki23 opened a new issue #2014: Cannot run examples of ballista

2022-03-14 Thread GitBox
doki23 opened a new issue #2014: URL: https://github.com/apache/arrow-datafusion/issues/2014 **Describe the bug** A clear and concise description of what the bug is. When I try to run ballista-examples/src/bin/ballista-sql.rs, I got an error: > thread 'main' panicked at 'failed

[GitHub] [arrow-rs] viirya commented on issue #1404: Triage remaining integration test failures with other Arrow implementations

2022-03-14 Thread GitBox
viirya commented on issue #1404: URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726 * generate_map_case * -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [arrow] vibhatha commented on a change in pull request #12112: ARROW-15183: [Python][Docs] Add Missing Dataset Write Options

2022-03-14 Thread GitBox
vibhatha commented on a change in pull request #12112: URL: https://github.com/apache/arrow/pull/12112#discussion_r826599846 ## File path: docs/source/python/dataset.rst ## @@ -613,6 +613,60 @@ guidelines apply. Row groups can provide parallelism when reading and allow data b

[GitHub] [arrow] vibhatha commented on a change in pull request #12112: ARROW-15183: [Python][Docs] Add Missing Dataset Write Options

2022-03-14 Thread GitBox
vibhatha commented on a change in pull request #12112: URL: https://github.com/apache/arrow/pull/12112#discussion_r826595344 ## File path: docs/source/python/dataset.rst ## @@ -613,6 +613,60 @@ guidelines apply. Row groups can provide parallelism when reading and allow data b

[GitHub] [arrow] ursabot edited a comment on pull request #12614: ARROW-15924: [Ruby] Add support for #values of MonthDayNanoInterval type

2022-03-14 Thread GitBox
ursabot edited a comment on pull request #12614: URL: https://github.com/apache/arrow/pull/12614#issuecomment-1067440025 Benchmark runs are scheduled for baseline = 73bb8ea0c770fda92f1231b471565ff6592a7386 and contender = 884d2b873c2103b247aa3cd38e38be20079b0890. 884d2b873c2103b247aa3cd38

[GitHub] [arrow] vibhatha commented on a change in pull request #12112: ARROW-15183: [Python][Docs] Add Missing Dataset Write Options

2022-03-14 Thread GitBox
vibhatha commented on a change in pull request #12112: URL: https://github.com/apache/arrow/pull/12112#discussion_r826587938 ## File path: docs/source/python/dataset.rst ## @@ -613,6 +613,60 @@ guidelines apply. Row groups can provide parallelism when reading and allow data b

[GitHub] [arrow] michalursa commented on pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on pull request #12067: URL: https://github.com/apache/arrow/pull/12067#issuecomment-1067565134 I merged https://github.com/michalursa/arrow/compare/ARROW-15239-bloom-filter...westonpace:experiment/simplify-vector-hash-test?expand=1 into the hash test code (key_hash_te

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826581622 ## File path: cpp/src/arrow/compute/exec/partition_util.cc ## @@ -0,0 +1,91 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

[GitHub] [arrow] vibhatha commented on a change in pull request #12113: ARROW-14679: [R] [C++] Handle suffix argument in joins

2022-03-14 Thread GitBox
vibhatha commented on a change in pull request #12113: URL: https://github.com/apache/arrow/pull/12113#discussion_r826566930 ## File path: r/tests/testthat/test-dplyr-join.R ## @@ -248,6 +247,26 @@ test_that("arrow dplyr query correctly filters then joins", { ) }) +test_

[GitHub] [arrow] vibhatha commented on a change in pull request #12113: ARROW-14679: [R] [C++] Handle suffix argument in joins

2022-03-14 Thread GitBox
vibhatha commented on a change in pull request #12113: URL: https://github.com/apache/arrow/pull/12113#discussion_r826566647 ## File path: r/tests/testthat/test-dplyr-join.R ## @@ -248,6 +247,26 @@ test_that("arrow dplyr query correctly filters then joins", { ) }) +test_

[GitHub] [arrow] save-buffer commented on pull request #12537: ARROW-3998: [C++] Add TPC-H Generator

2022-03-14 Thread GitBox
save-buffer commented on pull request #12537: URL: https://github.com/apache/arrow/pull/12537#issuecomment-1067544853 Seems to be all green except for the JNI one which seems to be failing for everyone right now -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [arrow] sanjibansg commented on a change in pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader

2022-03-14 Thread GitBox
sanjibansg commented on a change in pull request #12621: URL: https://github.com/apache/arrow/pull/12621#discussion_r826564450 ## File path: cpp/src/arrow/table.cc ## @@ -601,6 +602,19 @@ TableBatchReader::TableBatchReader(const Table& table) } } +TableBatchReader::TableB

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826560084 ## File path: cpp/src/arrow/compute/exec/partition_util.h ## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826558839 ## File path: cpp/src/arrow/compute/exec/bloom_filter_test.cc ## @@ -0,0 +1,484 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826555718 ## File path: cpp/src/arrow/compute/exec/bloom_filter.h ## @@ -0,0 +1,313 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826551404 ## File path: cpp/src/arrow/compute/exec/bloom_filter.h ## @@ -0,0 +1,313 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] ursabot edited a comment on pull request #12608: ARROW-15869: [C++] Fix Valgrind failure (uninitialized value)

2022-03-14 Thread GitBox
ursabot edited a comment on pull request #12608: URL: https://github.com/apache/arrow/pull/12608#issuecomment-1067162941 Benchmark runs are scheduled for baseline = 56b06bbe90e279dd4000736bd1e7d14d7b0558ca and contender = 0b19a68b0aa8eee46ea653a3ce98854d956dafc0. 0b19a68b0aa8eee46ea653a3c

[GitHub] [arrow] ursabot edited a comment on pull request #12600: ARROW-15900: [C++] Support Substrait reading of a Feather-format local file

2022-03-14 Thread GitBox
ursabot edited a comment on pull request #12600: URL: https://github.com/apache/arrow/pull/12600#issuecomment-1067259148 Benchmark runs are scheduled for baseline = 0b19a68b0aa8eee46ea653a3ce98854d956dafc0 and contender = 73bb8ea0c770fda92f1231b471565ff6592a7386. 73bb8ea0c770fda92f1231b47

[GitHub] [arrow-rs] viirya commented on a change in pull request #1432: Replace Arc with Box in ArrowArray for FFI structs

2022-03-14 Thread GitBox
viirya commented on a change in pull request #1432: URL: https://github.com/apache/arrow-rs/pull/1432#discussion_r826550474 ## File path: arrow/src/array/array.rs ## @@ -629,7 +629,9 @@ pub unsafe fn make_array_from_raw( schema: *const ffi::FFI_ArrowSchema, ) -> Result {

[GitHub] [arrow-rs] viirya commented on a change in pull request #1432: Replace Arc with Box in ArrowArray for FFI structs

2022-03-14 Thread GitBox
viirya commented on a change in pull request #1432: URL: https://github.com/apache/arrow-rs/pull/1432#discussion_r826550474 ## File path: arrow/src/array/array.rs ## @@ -629,7 +629,9 @@ pub unsafe fn make_array_from_raw( schema: *const ffi::FFI_ArrowSchema, ) -> Result {

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826550602 ## File path: cpp/src/arrow/compute/exec/partition_util.h ## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

[GitHub] [arrow-rs] viirya commented on a change in pull request #1432: Replace Arc with Box in ArrowArray for FFI structs

2022-03-14 Thread GitBox
viirya commented on a change in pull request #1432: URL: https://github.com/apache/arrow-rs/pull/1432#discussion_r826550474 ## File path: arrow/src/array/array.rs ## @@ -629,7 +629,9 @@ pub unsafe fn make_array_from_raw( schema: *const ffi::FFI_ArrowSchema, ) -> Result {

[GitHub] [arrow-rs] viirya commented on pull request #1446: Fix generate_interval_case in integration test

2022-03-14 Thread GitBox
viirya commented on pull request #1446: URL: https://github.com/apache/arrow-rs/pull/1446#issuecomment-1067522077 There are some test failures. I will take look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] cyb70289 commented on a change in pull request #12628: ARROW-15932: [C++][FlightRPC] Add more tests to the common Flight suite

2022-03-14 Thread GitBox
cyb70289 commented on a change in pull request #12628: URL: https://github.com/apache/arrow/pull/12628#discussion_r826547105 ## File path: cpp/src/arrow/flight/transport/grpc/grpc_client.cc ## @@ -316,7 +311,6 @@ class FinishableDataStream : public internal::ClientDataStream {

[GitHub] [arrow-rs] viirya commented on issue #1445: Fix generate_interval_case integration test failure

2022-03-14 Thread GitBox
viirya commented on issue #1445: URL: https://github.com/apache/arrow-rs/issues/1445#issuecomment-1067518482 Sure. Where should I put them? In #1404? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow-rs] viirya commented on pull request #1412: `filter` kernel should work with UnionArray

2022-03-14 Thread GitBox
viirya commented on pull request #1412: URL: https://github.com/apache/arrow-rs/pull/1412#issuecomment-1067518002 Thank you @alamb ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-rs] liukun4515 commented on issue #1445: Fix generate_interval_case integration test failure

2022-03-14 Thread GitBox
liukun4515 commented on issue #1445: URL: https://github.com/apache/arrow-rs/issues/1445#issuecomment-1067515317 @viirya Can you list the plan or missing item for IT in #1404 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-rs] viirya opened a new pull request #1446: Fix generate_interval_case in integration test

2022-03-14 Thread GitBox
viirya opened a new pull request #1446: URL: https://github.com/apache/arrow-rs/pull/1446 # Which issue does this PR close? Closes #1445. # Rationale for this change # What changes are included in this PR? # Are there any user-facing chan

[GitHub] [arrow-rs] viirya opened a new issue #1445: Fix generate_interval_case integration test failure

2022-03-14 Thread GitBox
viirya opened a new issue #1445: URL: https://github.com/apache/arrow-rs/issues/1445 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** This ticket is for `generate_interval_case` case in integration test. **Describe the s

[GitHub] [arrow] westonpace commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-03-14 Thread GitBox
westonpace commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r826520649 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -146,6 +210,19 @@ opentelemetry::trace::StartSpanOptions SpanOptionsWithParent( ret

[GitHub] [arrow] okadakk opened a new pull request #12631: ARROW-15925: [Ruby] Add support for #raw_records of MonthDayNanoInterval type

2022-03-14 Thread GitBox
okadakk opened a new pull request #12631: URL: https://github.com/apache/arrow/pull/12631 Implement #raw_records method of month day nano interval type to red arrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #12631: ARROW-15925: [Ruby] Add support for #raw_records of MonthDayNanoInterval type

2022-03-14 Thread GitBox
github-actions[bot] commented on pull request #12631: URL: https://github.com/apache/arrow/pull/12631#issuecomment-1067507244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] ursabot edited a comment on pull request #12614: ARROW-15924: [Ruby] Add support for #values of MonthDayNanoInterval type

2022-03-14 Thread GitBox
ursabot edited a comment on pull request #12614: URL: https://github.com/apache/arrow/pull/12614#issuecomment-1067440025 Benchmark runs are scheduled for baseline = 73bb8ea0c770fda92f1231b471565ff6592a7386 and contender = 884d2b873c2103b247aa3cd38e38be20079b0890. 884d2b873c2103b247aa3cd38

[GitHub] [arrow-datafusion] bobtins commented on issue #1877: Improved schema and catalog support from SQL

2022-03-14 Thread GitBox
bobtins commented on issue #1877: URL: https://github.com/apache/arrow-datafusion/issues/1877#issuecomment-1067484158 In this example, it seemed like parsing the table refs wasn't working: ``` ❯ CREATE TABLE sch.tbl AS VALUES (1,2,3); 0 rows in set. Query took 0.032 seconds. ❯ s

[GitHub] [arrow-datafusion] yjshen commented on pull request #1975: Avoid an Arc::clone per row in benchmark

2022-03-14 Thread GitBox
yjshen commented on pull request #1975: URL: https://github.com/apache/arrow-datafusion/pull/1975#issuecomment-1067481669 After searching and discussing with @houqp, it seems complicated to make `cranelift` to [inline rust function into JIT code](https://bytecodealliance.zulipchat.com/#na

[GitHub] [arrow] westonpace commented on a change in pull request #12625: ARROW-15587: [C++] Add support for all options specified by substrait::ReadRel::LocalFiles::FileOrFiles

2022-03-14 Thread GitBox
westonpace commented on a change in pull request #12625: URL: https://github.com/apache/arrow/pull/12625#discussion_r826506842 ## File path: cpp/src/arrow/dataset/discovery.cc ## @@ -134,8 +135,30 @@ Result> FileSystemDatasetFactory::Make( Result> FileSystemDatasetFactory::Ma

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826509632 ## File path: cpp/src/arrow/compute/exec/bloom_filter_avx2.cc ## @@ -0,0 +1,136 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826509575 ## File path: cpp/src/arrow/compute/exec/bloom_filter_avx2.cc ## @@ -0,0 +1,136 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow] vibhatha commented on a change in pull request #12113: ARROW-14679: [R] [C++] Handle suffix argument in joins

2022-03-14 Thread GitBox
vibhatha commented on a change in pull request #12113: URL: https://github.com/apache/arrow/pull/12113#discussion_r826508644 ## File path: r/R/query-engine.R ## @@ -166,14 +165,18 @@ ExecPlan <- R6Class("ExecPlan", # (as when we've done collapse() and not projected aft

[GitHub] [arrow] vibhatha commented on a change in pull request #12113: ARROW-14679: [R] [C++] Handle suffix argument in joins

2022-03-14 Thread GitBox
vibhatha commented on a change in pull request #12113: URL: https://github.com/apache/arrow/pull/12113#discussion_r826508187 ## File path: r/R/query-engine.R ## @@ -166,14 +165,18 @@ ExecPlan <- R6Class("ExecPlan", # (as when we've done collapse() and not projected aft

[GitHub] [arrow] vibhatha commented on a change in pull request #12113: ARROW-14679: [R] [C++] Handle suffix argument in joins

2022-03-14 Thread GitBox
vibhatha commented on a change in pull request #12113: URL: https://github.com/apache/arrow/pull/12113#discussion_r826508187 ## File path: r/R/query-engine.R ## @@ -166,14 +165,18 @@ ExecPlan <- R6Class("ExecPlan", # (as when we've done collapse() and not projected aft

[GitHub] [arrow-rs] sunchao commented on a change in pull request #1432: Replace Arc with Box in ArrowArray for FFI structs

2022-03-14 Thread GitBox
sunchao commented on a change in pull request #1432: URL: https://github.com/apache/arrow-rs/pull/1432#discussion_r826506993 ## File path: arrow/src/array/array.rs ## @@ -629,7 +629,9 @@ pub unsafe fn make_array_from_raw( schema: *const ffi::FFI_ArrowSchema, ) -> Result {

[GitHub] [arrow-datafusion] yjshen commented on pull request #2013: Substitute HDFS objectstore plugin

2022-03-14 Thread GitBox
yjshen commented on pull request #2013: URL: https://github.com/apache/arrow-datafusion/pull/2013#issuecomment-1067470184 Let's wait for @yahoNanJing to update the repo and transfer it to `datafusion-contrib` org. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [arrow-datafusion] yjshen closed pull request #2013: Substitute HDFS objectstore plugin

2022-03-14 Thread GitBox
yjshen closed pull request #2013: URL: https://github.com/apache/arrow-datafusion/pull/2013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github

[GitHub] [arrow] kou commented on pull request #12617: ARROW-15916: [Packaging][RPM] Add support for CentOS Stream 8

2022-03-14 Thread GitBox
kou commented on pull request #12617: URL: https://github.com/apache/arrow/pull/12617#issuecomment-1067463342 It seems that we can't use `verify-rc-binaries-{apt,yum}-linux-amd64` on master. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [arrow] ursabot edited a comment on pull request #12614: ARROW-15924: [Ruby] Add support for #values of MonthDayNanoInterval type

2022-03-14 Thread GitBox
ursabot edited a comment on pull request #12614: URL: https://github.com/apache/arrow/pull/12614#issuecomment-1067440025 Benchmark runs are scheduled for baseline = 73bb8ea0c770fda92f1231b471565ff6592a7386 and contender = 884d2b873c2103b247aa3cd38e38be20079b0890. 884d2b873c2103b247aa3cd38

[GitHub] [arrow] ursabot edited a comment on pull request #12608: ARROW-15869: [C++] Fix Valgrind failure (uninitialized value)

2022-03-14 Thread GitBox
ursabot edited a comment on pull request #12608: URL: https://github.com/apache/arrow/pull/12608#issuecomment-1067162941 Benchmark runs are scheduled for baseline = 56b06bbe90e279dd4000736bd1e7d14d7b0558ca and contender = 0b19a68b0aa8eee46ea653a3ce98854d956dafc0. 0b19a68b0aa8eee46ea653a3c

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826485814 ## File path: cpp/src/arrow/compute/exec/key_hash.h ## @@ -32,76 +32,161 @@ namespace compute { // Implementations are based on xxh3 32-bit algorithm

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826485235 ## File path: cpp/src/arrow/compute/exec/vector_hash_test.cc ## @@ -0,0 +1,287 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826484859 ## File path: cpp/src/arrow/compute/exec/key_hash.h ## @@ -32,76 +32,165 @@ namespace compute { // Implementations are based on xxh3 32-bit algorithm

[GitHub] [arrow] ursabot edited a comment on pull request #12600: ARROW-15900: [C++] Support Substrait reading of a Feather-format local file

2022-03-14 Thread GitBox
ursabot edited a comment on pull request #12600: URL: https://github.com/apache/arrow/pull/12600#issuecomment-1067259148 Benchmark runs are scheduled for baseline = 0b19a68b0aa8eee46ea653a3ce98854d956dafc0 and contender = 73bb8ea0c770fda92f1231b471565ff6592a7386. 73bb8ea0c770fda92f1231b47

[GitHub] [arrow] ursabot edited a comment on pull request #12608: ARROW-15869: [C++] Fix Valgrind failure (uninitialized value)

2022-03-14 Thread GitBox
ursabot edited a comment on pull request #12608: URL: https://github.com/apache/arrow/pull/12608#issuecomment-1067162941 Benchmark runs are scheduled for baseline = 56b06bbe90e279dd4000736bd1e7d14d7b0558ca and contender = 0b19a68b0aa8eee46ea653a3ce98854d956dafc0. 0b19a68b0aa8eee46ea653a3c

[GitHub] [arrow] ursabot commented on pull request #12614: ARROW-15924: [Ruby] Add support for #values of MonthDayNanoInterval type

2022-03-14 Thread GitBox
ursabot commented on pull request #12614: URL: https://github.com/apache/arrow/pull/12614#issuecomment-1067440025 Benchmark runs are scheduled for baseline = 73bb8ea0c770fda92f1231b471565ff6592a7386 and contender = 884d2b873c2103b247aa3cd38e38be20079b0890. 884d2b873c2103b247aa3cd38e38be20

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826483161 ## File path: cpp/src/arrow/compute/exec/vector_hash_test.cc ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Foundation (ASF) under one Revie

[GitHub] [arrow] kou closed pull request #12614: ARROW-15924: [Ruby] Add support for #values of MonthDayNanoInterval type

2022-03-14 Thread GitBox
kou closed pull request #12614: URL: https://github.com/apache/arrow/pull/12614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826480218 ## File path: cpp/src/arrow/compute/exec/vector_hash_test.cc ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] okadakk commented on a change in pull request #12614: ARROW-15924: [Ruby] Add support for #values of MonthDayNanoInterval type

2022-03-14 Thread GitBox
okadakk commented on a change in pull request #12614: URL: https://github.com/apache/arrow/pull/12614#discussion_r826479856 ## File path: ruby/red-arrow/ext/arrow/converters.hpp ## @@ -761,8 +773,6 @@ namespace red_arrow { VISIT(Time32) VISIT(Time64) VISIT(Timest

[GitHub] [arrow] westonpace commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
westonpace commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826402410 ## File path: cpp/src/arrow/compute/exec/bloom_filter_test.cc ## @@ -0,0 +1,484 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826473427 ## File path: cpp/src/arrow/compute/exec/vector_hash_test.cc ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] michalursa commented on a change in pull request #12067: ARROW-15239: [C++][Compute] Adding Bloom filter implementation

2022-03-14 Thread GitBox
michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826472267 ## File path: cpp/src/arrow/compute/exec/vector_hash_test.cc ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow-rs] viirya commented on pull request #1384: Add FFI for Arrow C Stream Interface

2022-03-14 Thread GitBox
viirya commented on pull request #1384: URL: https://github.com/apache/arrow-rs/pull/1384#issuecomment-1067410858 No problem! Thank you @sunchao ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] github-actions[bot] commented on pull request #12630: ARROW-15934: Expose write_batch_size in python.

2022-03-14 Thread GitBox
github-actions[bot] commented on pull request #12630: URL: https://github.com/apache/arrow/pull/12630#issuecomment-1067394244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] tachyonwill opened a new pull request #12630: ARROW-15934: Expose write_batch_size in python.

2022-03-14 Thread GitBox
tachyonwill opened a new pull request #12630: URL: https://github.com/apache/arrow/pull/12630 Already exposed in C++. Useful when dealing columns of large strings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [arrow] davisusanibar commented on a change in pull request #12603: ARROW-15573: [Java][Doc] Apache Arrow memory management

2022-03-14 Thread GitBox
davisusanibar commented on a change in pull request #12603: URL: https://github.com/apache/arrow/pull/12603#discussion_r826443988 ## File path: docs/source/java/memory.rst ## @@ -0,0 +1,82 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor

[GitHub] [arrow] davisusanibar commented on a change in pull request #12603: ARROW-15573: [Java][Doc] Apache Arrow memory management

2022-03-14 Thread GitBox
davisusanibar commented on a change in pull request #12603: URL: https://github.com/apache/arrow/pull/12603#discussion_r826443891 ## File path: docs/source/java/memory.rst ## @@ -0,0 +1,82 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor

[GitHub] [arrow] davisusanibar commented on a change in pull request #12603: ARROW-15573: [Java][Doc] Apache Arrow memory management

2022-03-14 Thread GitBox
davisusanibar commented on a change in pull request #12603: URL: https://github.com/apache/arrow/pull/12603#discussion_r826443285 ## File path: docs/source/java/memory.rst ## @@ -0,0 +1,82 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor

[GitHub] [arrow] davisusanibar commented on a change in pull request #12603: ARROW-15573: [Java][Doc] Apache Arrow memory management

2022-03-14 Thread GitBox
davisusanibar commented on a change in pull request #12603: URL: https://github.com/apache/arrow/pull/12603#discussion_r826443178 ## File path: docs/source/java/memory.rst ## @@ -0,0 +1,82 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor

[GitHub] [arrow] davisusanibar commented on a change in pull request #12603: ARROW-15573: [Java][Doc] Apache Arrow memory management

2022-03-14 Thread GitBox
davisusanibar commented on a change in pull request #12603: URL: https://github.com/apache/arrow/pull/12603#discussion_r826442783 ## File path: docs/source/java/memory.rst ## @@ -0,0 +1,82 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor

[GitHub] [arrow] davisusanibar commented on a change in pull request #12603: ARROW-15573: [Java][Doc] Apache Arrow memory management

2022-03-14 Thread GitBox
davisusanibar commented on a change in pull request #12603: URL: https://github.com/apache/arrow/pull/12603#discussion_r826442618 ## File path: docs/source/java/memory.rst ## @@ -0,0 +1,82 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor

[GitHub] [arrow] davisusanibar commented on a change in pull request #12603: ARROW-15573: [Java][Doc] Apache Arrow memory management

2022-03-14 Thread GitBox
davisusanibar commented on a change in pull request #12603: URL: https://github.com/apache/arrow/pull/12603#discussion_r826442524 ## File path: docs/source/java/memory.rst ## @@ -0,0 +1,82 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor

[GitHub] [arrow] davisusanibar commented on a change in pull request #12603: ARROW-15573: [Java][Doc] Apache Arrow memory management

2022-03-14 Thread GitBox
davisusanibar commented on a change in pull request #12603: URL: https://github.com/apache/arrow/pull/12603#discussion_r826442304 ## File path: docs/source/java/memory.rst ## @@ -0,0 +1,82 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor

[GitHub] [arrow] ursabot edited a comment on pull request #12600: ARROW-15900: [C++] Support Substrait reading of a Feather-format local file

2022-03-14 Thread GitBox
ursabot edited a comment on pull request #12600: URL: https://github.com/apache/arrow/pull/12600#issuecomment-1067259148 Benchmark runs are scheduled for baseline = 0b19a68b0aa8eee46ea653a3ce98854d956dafc0 and contender = 73bb8ea0c770fda92f1231b471565ff6592a7386. 73bb8ea0c770fda92f1231b47

[GitHub] [arrow] github-actions[bot] commented on pull request #12629: ARROW-15627: [R] Fix union dataset unify schema

2022-03-14 Thread GitBox
github-actions[bot] commented on pull request #12629: URL: https://github.com/apache/arrow/pull/12629#issuecomment-1067366114 https://issues.apache.org/jira/browse/ARROW-15627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] wjones127 opened a new pull request #12629: ARROW-15627: [R] Fix union dataset unify schema

2022-03-14 Thread GitBox
wjones127 opened a new pull request #12629: URL: https://github.com/apache/arrow/pull/12629 The C++ `Dataset->ReplaceSchema()` method returns a new dataset, but we were calling it as if it mutated the original object. I'm moving this to a new method and adding a test for this behavior.

[GitHub] [arrow] edponce commented on a change in pull request #12055: ARROW-11989: [C++][Python] Improve ChunkedArray's complexity for the access of elements

2022-03-14 Thread GitBox
edponce commented on a change in pull request #12055: URL: https://github.com/apache/arrow/pull/12055#discussion_r826380405 ## File path: cpp/src/arrow/chunk_resolver.cc ## @@ -0,0 +1,84 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

[GitHub] [arrow-rs] sunchao commented on pull request #1384: Add FFI for Arrow C Stream Interface

2022-03-14 Thread GitBox
sunchao commented on pull request #1384: URL: https://github.com/apache/arrow-rs/pull/1384#issuecomment-1067360050 Will take another look soon. Sorry for the delay @viirya ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow-datafusion] vchag commented on pull request #1998: Merge dataframe and dataframe imp

2022-03-14 Thread GitBox
vchag commented on pull request #1998: URL: https://github.com/apache/arrow-datafusion/pull/1998#issuecomment-1067333014 > > `datafusion-examples/examples/custom_datasource.rs` isn't present in > > datafusion-examples. > > It exists in master https://user-images.githubusercontent.

[GitHub] [arrow] pitrou commented on pull request #12604: ARROW-15898: [CI] Clean old conda nightlies more thoroughly

2022-03-14 Thread GitBox
pitrou commented on pull request #12604: URL: https://github.com/apache/arrow/pull/12604#issuecomment-1067338959 These files are several months old, so yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] kou commented on pull request #12604: ARROW-15898: [CI] Clean old conda nightlies more thoroughly

2022-03-14 Thread GitBox
kou commented on pull request #12604: URL: https://github.com/apache/arrow/pull/12604#issuecomment-1067328025 All `parquet-cpp` files are deleted: https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=21446&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4c

[GitHub] [arrow-julia] simsurace commented on issue #303: Question on `Date` encoding

2022-03-14 Thread GitBox
simsurace commented on issue #303: URL: https://github.com/apache/arrow-julia/issues/303#issuecomment-1067325809 We just did an experiment. When we write the following arrow file from Julia ``` arrow_dt = [convert(Arrow.Date{Arrow.Flatbuf.DateUnits.DAY, Int32}, Date(2022) + Day(i-1))

[GitHub] [arrow-datafusion] alamb commented on pull request #1959: Add Create Schema functionality in SQL

2022-03-14 Thread GitBox
alamb commented on pull request #1959: URL: https://github.com/apache/arrow-datafusion/pull/1959#issuecomment-1067325547 > @alamb do you have preference on whether to leave this PR as is or if i can also add CREATE CATALOG on here? I suggest we do it in a follow on PR to keep this o

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1444: Add Full UnionArray validation

2022-03-14 Thread GitBox
codecov-commenter commented on pull request #1444: URL: https://github.com/apache/arrow-rs/pull/1444#issuecomment-1067322901 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1444?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow-rs] alamb opened a new pull request #1444: Add Full UnionArray validation

2022-03-14 Thread GitBox
alamb opened a new pull request #1444: URL: https://github.com/apache/arrow-rs/pull/1444 Draft (need to write tests and file a ticket) # Which issue does this PR close? To be filed Closes #. # Rationale for this change While reviewing https://github.com/apache/

[GitHub] [arrow] kou commented on pull request #12617: ARROW-15916: [Packaging][RPM] Add support for CentOS Stream 8

2022-03-14 Thread GitBox
kou commented on pull request #12617: URL: https://github.com/apache/arrow/pull/12617#issuecomment-1067314598 @github-actions crossbow submit -g linux verify-rc-binaries-apt* verify-rc-binaries-yum* -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [arrow] edponce commented on a change in pull request #12055: ARROW-11989: [C++][Python] Improve ChunkedArray's complexity for the access of elements

2022-03-14 Thread GitBox
edponce commented on a change in pull request #12055: URL: https://github.com/apache/arrow/pull/12055#discussion_r826394545 ## File path: cpp/src/arrow/chunk_resolver.cc ## @@ -0,0 +1,84 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

[GitHub] [arrow] github-actions[bot] commented on pull request #12617: ARROW-15916: [Packaging][RPM] Add support for CentOS Stream 8

2022-03-14 Thread GitBox
github-actions[bot] commented on pull request #12617: URL: https://github.com/apache/arrow/pull/12617#issuecomment-1067315679 Revision: 29a1c69b3b8adbfaedf985c27e6a3da78b73747a Submitted crossbow builds: [ursacomputing/crossbow @ actions-1767](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] edponce commented on a change in pull request #12055: ARROW-11989: [C++][Python] Improve ChunkedArray's complexity for the access of elements

2022-03-14 Thread GitBox
edponce commented on a change in pull request #12055: URL: https://github.com/apache/arrow/pull/12055#discussion_r826380405 ## File path: cpp/src/arrow/chunk_resolver.cc ## @@ -0,0 +1,84 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

  1   2   3   >