[GitHub] [arrow] lccnl opened a new issue #12761: [Python] replace_with_mask seg faults

2022-03-30 Thread GitBox
lccnl opened a new issue #12761: URL: https://github.com/apache/arrow/issues/12761 Hello, there is currently an open issue in Jira, [ARROW-15928](https://issues.apache.org/jira/browse/ARROW-15928), reporting a seg faults with chunked arrays when the method `compute.replace_with_mask` is

[GitHub] [arrow] vibhatha commented on pull request #12590: ARROW-15639 [C++][Python] UDF Scalar Function Implementation

2022-03-30 Thread GitBox
vibhatha commented on pull request #12590: URL: https://github.com/apache/arrow/pull/12590#issuecomment-1084163268 @pitrou regarding this: https://github.com/apache/arrow/pull/12590#discussion_r837509180 Ah I see your point. But a few things about this. Aren't we are going to

[GitHub] [arrow-datafusion] jiangzhx edited a comment on issue #2044: wrong result when operation parquet

2022-03-30 Thread GitBox
jiangzhx edited a comment on issue #2044: URL: https://github.com/apache/arrow-datafusion/issues/2044#issuecomment-1084142721 confused print_row_with_parquet testcase get right result pickup_datetime:2009-01-04 02:52:00 +00:00 print_row_with_datafusion get wrong

[GitHub] [arrow] ursabot edited a comment on pull request #12746: MINOR: [C++] Fix deprecation warning

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12746: URL: https://github.com/apache/arrow/pull/12746#issuecomment-1082832083 Benchmark runs are scheduled for baseline = 756f2b7249d00a64bc9efcbbce75445dda6a9008 and contender = 0deefd1838bf4706232b90b72da010698010f7b6. 0deefd1838bf4706232b90b72

[GitHub] [arrow] ursabot edited a comment on pull request #12537: ARROW-3998: [C++] Add TPC-H Generator

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12537: URL: https://github.com/apache/arrow/pull/12537#issuecomment-1082832095 Benchmark runs are scheduled for baseline = 0deefd1838bf4706232b90b72da010698010f7b6 and contender = 50fab73da58c9f76fbe675d661e56087e2f5fb52. 50fab73da58c9f76fbe675d66

[GitHub] [arrow] ursabot edited a comment on pull request #12729: ARROW-14279: [Docs] Initial attempt at describing structure of PyArrow library

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12729: URL: https://github.com/apache/arrow/pull/12729#issuecomment-1082893955 Benchmark runs are scheduled for baseline = 50fab73da58c9f76fbe675d661e56087e2f5fb52 and contender = c515a6924f6002a70f1046b1642629867bacabd2. c515a6924f6002a70f1046b16

[GitHub] [arrow-datafusion] jiangzhx edited a comment on issue #2044: wrong result when operation parquet

2022-03-30 Thread GitBox
jiangzhx edited a comment on issue #2044: URL: https://github.com/apache/arrow-datafusion/issues/2044#issuecomment-1084142721 confused print_row_with_parquet testcase get right result pickup_datetime:2009-01-04 02:52:00 +00:00 print_row_with_datafusion get wrong

[GitHub] [arrow-datafusion] jiangzhx commented on issue #2044: wrong result when operation parquet

2022-03-30 Thread GitBox
jiangzhx commented on issue #2044: URL: https://github.com/apache/arrow-datafusion/issues/2044#issuecomment-1084142721 confused print_row_with_parquet testcase get right result pickup_datetime:2009-01-04 02:52:00 +00:00 print_row_with_datafusion get wrong result

[GitHub] [arrow] vibhatha commented on a change in pull request #12590: ARROW-15639 [C++][Python] UDF Scalar Function Implementation

2022-03-30 Thread GitBox
vibhatha commented on a change in pull request #12590: URL: https://github.com/apache/arrow/pull/12590#discussion_r839213447 ## File path: cpp/examples/arrow/udf_example.cc ## @@ -0,0 +1,253 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [arrow] vibhatha commented on a change in pull request #12590: ARROW-15639 [C++][Python] UDF Scalar Function Implementation

2022-03-30 Thread GitBox
vibhatha commented on a change in pull request #12590: URL: https://github.com/apache/arrow/pull/12590#discussion_r839213300 ## File path: cpp/examples/arrow/udf_example.cc ## @@ -0,0 +1,253 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #2111: Introduce datafusion-objectstore-hdfs as optional features in the datafusion core

2022-03-30 Thread GitBox
houqp commented on a change in pull request #2111: URL: https://github.com/apache/arrow-datafusion/pull/2111#discussion_r839211034 ## File path: datafusion/core/Cargo.toml ## @@ -60,9 +62,10 @@ async-trait = "0.1.41" avro-rs = { version = "0.13", features = ["snappy"], optiona

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #2111: Introduce datafusion-objectstore-hdfs as optional features in the datafusion core

2022-03-30 Thread GitBox
houqp commented on a change in pull request #2111: URL: https://github.com/apache/arrow-datafusion/pull/2111#discussion_r839211034 ## File path: datafusion/core/Cargo.toml ## @@ -60,9 +62,10 @@ async-trait = "0.1.41" avro-rs = { version = "0.13", features = ["snappy"], optiona

[GitHub] [arrow-datafusion] yahoNanJing commented on a change in pull request #2111: Introduce datafusion-objectstore-hdfs as optional features in the datafusion core

2022-03-30 Thread GitBox
yahoNanJing commented on a change in pull request #2111: URL: https://github.com/apache/arrow-datafusion/pull/2111#discussion_r839208250 ## File path: datafusion/core/Cargo.toml ## @@ -60,9 +62,10 @@ async-trait = "0.1.41" avro-rs = { version = "0.13", features = ["snappy"], o

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #2111: Introduce datafusion-objectstore-hdfs as optional features in the datafusion core

2022-03-30 Thread GitBox
houqp commented on a change in pull request #2111: URL: https://github.com/apache/arrow-datafusion/pull/2111#discussion_r839193390 ## File path: datafusion/core/Cargo.toml ## @@ -60,9 +62,10 @@ async-trait = "0.1.41" avro-rs = { version = "0.13", features = ["snappy"], optiona

[GitHub] [arrow-datafusion] jiangzhx commented on issue #2044: wrong result when operation parquet

2022-03-30 Thread GitBox
jiangzhx commented on issue #2044: URL: https://github.com/apache/arrow-datafusion/issues/2044#issuecomment-1084095786 > @alitrack, the issue may be caused by "ARROW:schema" key-value pair in .parquet metadata - it contains schema which treats pickup/dropoff_datatime fields as Timestamp(N

[GitHub] [arrow] vibhatha commented on a change in pull request #12590: ARROW-15639 [C++][Python] UDF Scalar Function Implementation

2022-03-30 Thread GitBox
vibhatha commented on a change in pull request #12590: URL: https://github.com/apache/arrow/pull/12590#discussion_r839186689 ## File path: cpp/examples/arrow/CMakeLists.txt ## @@ -133,4 +133,11 @@ if(ARROW_PARQUET AND ARROW_DATASET) add_arrow_example(join_example EXTRA_LIN

[GitHub] [arrow-datafusion] houqp commented on pull request #2124: JIT-compille DataFusion expression with column name

2022-03-30 Thread GitBox
houqp commented on pull request #2124: URL: https://github.com/apache/arrow-datafusion/pull/2124#issuecomment-1084085956 I think we are good as long as we don't invoke rust functions from the JIT'd code. I am curious if cranelift will be smart enough to auto vectorize the loop though :)

[GitHub] [arrow] github-actions[bot] commented on pull request #12760: ARROW-16078: Upgrade bundled zlib to 1.2.12

2022-03-30 Thread GitBox
github-actions[bot] commented on pull request #12760: URL: https://github.com/apache/arrow/pull/12760#issuecomment-1084082592 https://issues.apache.org/jira/browse/ARROW-16078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] cyb70289 opened a new pull request #12760: ARROW-16078: Upgrade bundled zlib to 1.2.12

2022-03-30 Thread GitBox
cyb70289 opened a new pull request #12760: URL: https://github.com/apache/arrow/pull/12760 https://nvd.nist.gov/vuln/detail/CVE-2018-25032 zlib before 1.2.12 may cause memory corruption -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [arrow] ursabot edited a comment on pull request #12746: MINOR: [C++] Fix deprecation warning

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12746: URL: https://github.com/apache/arrow/pull/12746#issuecomment-1082832083 Benchmark runs are scheduled for baseline = 756f2b7249d00a64bc9efcbbce75445dda6a9008 and contender = 0deefd1838bf4706232b90b72da010698010f7b6. 0deefd1838bf4706232b90b72

[GitHub] [arrow] ursabot edited a comment on pull request #12537: ARROW-3998: [C++] Add TPC-H Generator

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12537: URL: https://github.com/apache/arrow/pull/12537#issuecomment-1082832095 Benchmark runs are scheduled for baseline = 0deefd1838bf4706232b90b72da010698010f7b6 and contender = 50fab73da58c9f76fbe675d661e56087e2f5fb52. 50fab73da58c9f76fbe675d66

[GitHub] [arrow] ursabot edited a comment on pull request #12729: ARROW-14279: [Docs] Initial attempt at describing structure of PyArrow library

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12729: URL: https://github.com/apache/arrow/pull/12729#issuecomment-1082893955 Benchmark runs are scheduled for baseline = 50fab73da58c9f76fbe675d661e56087e2f5fb52 and contender = c515a6924f6002a70f1046b1642629867bacabd2. c515a6924f6002a70f1046b16

[GitHub] [arrow] ursabot edited a comment on pull request #12730: ARROW-16044: [Julia] Remove from apache/arrow

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12730: URL: https://github.com/apache/arrow/pull/12730#issuecomment-1081290089 Benchmark runs are scheduled for baseline = f4cc59313043493628b39fe757e2796fc74ac42f and contender = 556ee23e539015bd414dc8df46a3b7a0c7404381. 556ee23e539015bd414dc8df4

[GitHub] [arrow] ursabot edited a comment on pull request #12740: ARROW-15970: [R] [CI] Re-enable DuckDB dev tests

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12740: URL: https://github.com/apache/arrow/pull/12740#issuecomment-1081239714 Benchmark runs are scheduled for baseline = bd6453cee7aa2ce7772e8a28447d45e65a5c1ff5 and contender = dbea4ffde6afba8eba7cd26c78b270ed1a5178a9. dbea4ffde6afba8eba7cd26c7

[GitHub] [arrow] ursabot edited a comment on pull request #12741: ARROW-16052: [R] undefined global function %>%

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12741: URL: https://github.com/apache/arrow/pull/12741#issuecomment-1081239721 Benchmark runs are scheduled for baseline = dbea4ffde6afba8eba7cd26c78b270ed1a5178a9 and contender = f4cc59313043493628b39fe757e2796fc74ac42f. f4cc59313043493628b39fe75

[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12720: URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592 Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbc

[GitHub] [arrow] ursabot edited a comment on pull request #12746: MINOR: [C++] Fix deprecation warning

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12746: URL: https://github.com/apache/arrow/pull/12746#issuecomment-1082832083 Benchmark runs are scheduled for baseline = 756f2b7249d00a64bc9efcbbce75445dda6a9008 and contender = 0deefd1838bf4706232b90b72da010698010f7b6. 0deefd1838bf4706232b90b72

[GitHub] [arrow] ursabot edited a comment on pull request #12537: ARROW-3998: [C++] Add TPC-H Generator

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12537: URL: https://github.com/apache/arrow/pull/12537#issuecomment-1082832095 Benchmark runs are scheduled for baseline = 0deefd1838bf4706232b90b72da010698010f7b6 and contender = 50fab73da58c9f76fbe675d661e56087e2f5fb52. 50fab73da58c9f76fbe675d66

[GitHub] [arrow] ursabot edited a comment on pull request #12560: ARROW-15281: [C++] Implement ability to retrieve fragment filename

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12560: URL: https://github.com/apache/arrow/pull/12560#issuecomment-1084041375 Benchmark runs are scheduled for baseline = 600288e3f31dc5a7817f69ff59b5b69510d23e8a and contender = 3eb1bac0b54a7f883986a1af7cbdf6f3607b1052. 3eb1bac0b54a7f883986a1af7

[GitHub] [arrow] ursabot commented on pull request #12560: ARROW-15281: [C++] Implement ability to retrieve fragment filename

2022-03-30 Thread GitBox
ursabot commented on pull request #12560: URL: https://github.com/apache/arrow/pull/12560#issuecomment-1084041375 Benchmark runs are scheduled for baseline = 600288e3f31dc5a7817f69ff59b5b69510d23e8a and contender = 3eb1bac0b54a7f883986a1af7cbdf6f3607b1052. 3eb1bac0b54a7f883986a1af7cbdf6f3

[GitHub] [arrow] westonpace closed pull request #12560: ARROW-15281: [C++] Implement ability to retrieve fragment filename

2022-03-30 Thread GitBox
westonpace closed pull request #12560: URL: https://github.com/apache/arrow/pull/12560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsu

[GitHub] [arrow] westonpace commented on pull request #12560: ARROW-15281: [C++] Implement ability to retrieve fragment filename

2022-03-30 Thread GitBox
westonpace commented on pull request #12560: URL: https://github.com/apache/arrow/pull/12560#issuecomment-1084037317 Failure in hash-join-node-test is unrelated, but interesting. I've added it to ARROW-15221. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] westonpace commented on a change in pull request #12560: ARROW-15281: [C++] Implement ability to retrieve fragment filename

2022-03-30 Thread GitBox
westonpace commented on a change in pull request #12560: URL: https://github.com/apache/arrow/pull/12560#discussion_r839137322 ## File path: python/pyarrow/_dataset.pyx ## @@ -240,14 +240,22 @@ cdef class Dataset(_Weakrefable): columns : list of str, default None

[GitHub] [arrow] ursabot edited a comment on pull request #12746: MINOR: [C++] Fix deprecation warning

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12746: URL: https://github.com/apache/arrow/pull/12746#issuecomment-1082832083 Benchmark runs are scheduled for baseline = 756f2b7249d00a64bc9efcbbce75445dda6a9008 and contender = 0deefd1838bf4706232b90b72da010698010f7b6. 0deefd1838bf4706232b90b72

[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12720: URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592 Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbc

[GitHub] [arrow] ursabot edited a comment on pull request #12537: ARROW-3998: [C++] Add TPC-H Generator

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12537: URL: https://github.com/apache/arrow/pull/12537#issuecomment-1082832095 Benchmark runs are scheduled for baseline = 0deefd1838bf4706232b90b72da010698010f7b6 and contender = 50fab73da58c9f76fbe675d661e56087e2f5fb52. 50fab73da58c9f76fbe675d66

[GitHub] [arrow] cyb70289 commented on a change in pull request #12442: ARROW-15706: [C++][FlightRPC] Implement a UCX transport

2022-03-30 Thread GitBox
cyb70289 commented on a change in pull request #12442: URL: https://github.com/apache/arrow/pull/12442#discussion_r839118292 ## File path: cpp/src/arrow/flight/transport/ucx/util_internal.cc ## @@ -0,0 +1,289 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12720: URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592 Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbc

[GitHub] [arrow] ursabot edited a comment on pull request #12746: MINOR: [C++] Fix deprecation warning

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12746: URL: https://github.com/apache/arrow/pull/12746#issuecomment-1082832083 Benchmark runs are scheduled for baseline = 756f2b7249d00a64bc9efcbbce75445dda6a9008 and contender = 0deefd1838bf4706232b90b72da010698010f7b6. 0deefd1838bf4706232b90b72

[GitHub] [arrow] ursabot edited a comment on pull request #12728: ARROW-16042: [GO] Fix header file preprocessor issues

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12728: URL: https://github.com/apache/arrow/pull/12728#issuecomment-1082511579 Benchmark runs are scheduled for baseline = 6f10dab8a2204e1fa39c851e3ccc1f17d48b275e and contender = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c. ac58b8d5e5f424e2f81da680d

[GitHub] [arrow] ursabot edited a comment on pull request #12740: ARROW-15970: [R] [CI] Re-enable DuckDB dev tests

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12740: URL: https://github.com/apache/arrow/pull/12740#issuecomment-1081239714 Benchmark runs are scheduled for baseline = bd6453cee7aa2ce7772e8a28447d45e65a5c1ff5 and contender = dbea4ffde6afba8eba7cd26c78b270ed1a5178a9. dbea4ffde6afba8eba7cd26c7

[GitHub] [arrow] ursabot edited a comment on pull request #12735: ARROW-16049: [C++][FlightRPC] Fix Flight SQL's ColumnMetadata constructor visibility

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12735: URL: https://github.com/apache/arrow/pull/12735#issuecomment-1081228742 Benchmark runs are scheduled for baseline = b781710d950f61912c707d899f4f8750f4e149b0 and contender = bd6453cee7aa2ce7772e8a28447d45e65a5c1ff5. bd6453cee7aa2ce7772e8a284

[GitHub] [arrow] ursabot edited a comment on pull request #12741: ARROW-16052: [R] undefined global function %>%

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12741: URL: https://github.com/apache/arrow/pull/12741#issuecomment-1081239721 Benchmark runs are scheduled for baseline = dbea4ffde6afba8eba7cd26c78b270ed1a5178a9 and contender = f4cc59313043493628b39fe757e2796fc74ac42f. f4cc59313043493628b39fe75

[GitHub] [arrow-datafusion] yahoNanJing commented on a change in pull request #2111: Introduce datafusion-objectstore-hdfs as optional features in the datafusion core

2022-03-30 Thread GitBox
yahoNanJing commented on a change in pull request #2111: URL: https://github.com/apache/arrow-datafusion/pull/2111#discussion_r839110416 ## File path: datafusion/core/Cargo.toml ## @@ -60,9 +62,10 @@ async-trait = "0.1.41" avro-rs = { version = "0.13", features = ["snappy"], o

[GitHub] [arrow-datafusion] doki23 edited a comment on pull request #2128: MINOR: fix concat_ws corner bug

2022-03-30 Thread GitBox
doki23 edited a comment on pull request #2128: URL: https://github.com/apache/arrow-datafusion/pull/2128#issuecomment-1083964337 How about ```rust let mut owned_string = Vec::with_capacity(args.len()-1); for arg_index in 1..args.len() { let arg = &args[arg_index];

[GitHub] [arrow-datafusion] doki23 edited a comment on pull request #2128: MINOR: fix concat_ws corner bug

2022-03-30 Thread GitBox
doki23 edited a comment on pull request #2128: URL: https://github.com/apache/arrow-datafusion/pull/2128#issuecomment-1083964337 How about ```rust let mut owned_string = Vec::with_capacity(args.len()-1); for arg_index in 1..args.len() { let arg = &args[arg_index];

[GitHub] [arrow-datafusion] doki23 edited a comment on pull request #2128: MINOR: fix concat_ws corner bug

2022-03-30 Thread GitBox
doki23 edited a comment on pull request #2128: URL: https://github.com/apache/arrow-datafusion/pull/2128#issuecomment-1083964337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [arrow-datafusion] yjshen merged pull request #2127: Minor add clarifying comment in parquet

2022-03-30 Thread GitBox
yjshen merged pull request #2127: URL: https://github.com/apache/arrow-datafusion/pull/2127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github

[GitHub] [arrow-datafusion] doki23 edited a comment on pull request #2128: MINOR: fix concat_ws corner bug

2022-03-30 Thread GitBox
doki23 edited a comment on pull request #2128: URL: https://github.com/apache/arrow-datafusion/pull/2128#issuecomment-1083964337 How about ```rust let mut owned_string = Vec::with_capacity(args.len()-1); for arg_index in 1..args.len() { let arg = &args[arg_index];

[GitHub] [arrow-datafusion] doki23 edited a comment on pull request #2128: MINOR: fix concat_ws corner bug

2022-03-30 Thread GitBox
doki23 edited a comment on pull request #2128: URL: https://github.com/apache/arrow-datafusion/pull/2128#issuecomment-1083964337 How about ```rust let mut owned_string = Vec::with_capacity(args.len()-1); for arg_index in 1..args.len() { let arg = &args[arg_index];

[GitHub] [arrow-datafusion] doki23 edited a comment on pull request #2128: MINOR: fix concat_ws corner bug

2022-03-30 Thread GitBox
doki23 edited a comment on pull request #2128: URL: https://github.com/apache/arrow-datafusion/pull/2128#issuecomment-1083964337 How about ```rust let mut owned_string = Vec::with_capacity(args.len()-1); for arg_index in 1..args.len() { let arg = &args[arg_index];

[GitHub] [arrow-datafusion] doki23 edited a comment on pull request #2128: MINOR: fix concat_ws corner bug

2022-03-30 Thread GitBox
doki23 edited a comment on pull request #2128: URL: https://github.com/apache/arrow-datafusion/pull/2128#issuecomment-1083964337 How about ``` let mut owned_string = Vec::with_capacity(args.len()-1); for arg_index in 1..args.len() { let arg = &args[arg_index];

[GitHub] [arrow-datafusion] doki23 commented on pull request #2128: MINOR: fix concat_ws corner bug

2022-03-30 Thread GitBox
doki23 commented on pull request #2128: URL: https://github.com/apache/arrow-datafusion/pull/2128#issuecomment-1083964337 How about ``` let mut owned_string = Vec::with_capacity(args.len()); for arg_index in 1..args.len() { let arg = &args[arg_index]; if !arg.

[GitHub] [arrow-datafusion] jychen7 edited a comment on issue #2109: Almost 100x slowdown on 0.7.0 with CSV file

2022-03-30 Thread GitBox
jychen7 edited a comment on issue #2109: URL: https://github.com/apache/arrow-datafusion/issues/2109#issuecomment-1083882640 interesting, from the `master` branch as of now, the default `1000` is set in `CsvReadOptions` and should be passed when converted `CsvReadOptions` to `ListingOptio

[GitHub] [arrow-datafusion] jychen7 edited a comment on issue #2109: Almost 100x slowdown on 0.7.0 with CSV file

2022-03-30 Thread GitBox
jychen7 edited a comment on issue #2109: URL: https://github.com/apache/arrow-datafusion/issues/2109#issuecomment-1083923099 I agree we can set default const `1000` at `CsvFormat` and use it across the code base, to align with other file format, we probably should set it for JSON as well?

[GitHub] [arrow-datafusion] jychen7 edited a comment on issue #2109: Almost 100x slowdown on 0.7.0 with CSV file

2022-03-30 Thread GitBox
jychen7 edited a comment on issue #2109: URL: https://github.com/apache/arrow-datafusion/issues/2109#issuecomment-1083923099 I agree we can set default const `1000` at `CsvFormat` and use it across the code base, we probably should set it for JSON as well? https://github.com/apache

[GitHub] [arrow] paleolimbot commented on a change in pull request #12751: ARROW-15989: [R] rbind & cbind for Table & RecordBatch

2022-03-30 Thread GitBox
paleolimbot commented on a change in pull request #12751: URL: https://github.com/apache/arrow/pull/12751#discussion_r839090211 ## File path: r/R/record-batch.R ## @@ -189,3 +189,36 @@ record_batch <- RecordBatch$create #' @export names.RecordBatch <- function(x) x$names()

[GitHub] [arrow-datafusion] jychen7 edited a comment on issue #2109: Almost 100x slowdown on 0.7.0 with CSV file

2022-03-30 Thread GitBox
jychen7 edited a comment on issue #2109: URL: https://github.com/apache/arrow-datafusion/issues/2109#issuecomment-1083882640 interesting, from the `master` branch as of now, the default `1000` is set in `CsvReadOptions` and should be passed when converted `CsvReadOptions` to `ListingOptio

[GitHub] [arrow-datafusion] jychen7 commented on issue #2109: Almost 100x slowdown on 0.7.0 with CSV file

2022-03-30 Thread GitBox
jychen7 commented on issue #2109: URL: https://github.com/apache/arrow-datafusion/issues/2109#issuecomment-1083923099 I agree we can set default const `1000` at `CsvFormat` and use it across the code base https://github.com/apache/arrow-datafusion/blob/c43b9ab9922ccbaaf6fe6f27e3d312019

[GitHub] [arrow-datafusion] jychen7 edited a comment on issue #2109: Almost 100x slowdown on 0.7.0 with CSV file

2022-03-30 Thread GitBox
jychen7 edited a comment on issue #2109: URL: https://github.com/apache/arrow-datafusion/issues/2109#issuecomment-1083882640 interesting, from the `master` branch as of now, the default `1000` is set in `CsvReadOptions` and should be passed when converted `CsvReadOptions` to `ListingOptio

[GitHub] [arrow-rs] sunchao commented on pull request #1384: Add FFI for Arrow C Stream Interface

2022-03-30 Thread GitBox
sunchao commented on pull request #1384: URL: https://github.com/apache/arrow-rs/pull/1384#issuecomment-1083909608 Merged, thanks @viirya ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow-rs] sunchao closed issue #1348: FFI for Arrow C Stream Interface

2022-03-30 Thread GitBox
sunchao closed issue #1348: URL: https://github.com/apache/arrow-rs/issues/1348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow-rs] sunchao merged pull request #1384: Add FFI for Arrow C Stream Interface

2022-03-30 Thread GitBox
sunchao merged pull request #1384: URL: https://github.com/apache/arrow-rs/pull/1384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] github-actions[bot] commented on pull request #12758: [Gandiva][C++] Fix castINTERVALDAY and castINTERVALYEAR

2022-03-30 Thread GitBox
github-actions[bot] commented on pull request #12758: URL: https://github.com/apache/arrow/pull/12758#issuecomment-1083905752 Revision: e278c2d3825e9698b1c9560aaabc1f7b79ea528f Submitted crossbow builds: [ursacomputing/crossbow @ actions-1806](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] Johnnathanalmeida commented on pull request #12758: [Gandiva][C++] Fix castINTERVALDAY and castINTERVALYEAR

2022-03-30 Thread GitBox
Johnnathanalmeida commented on pull request #12758: URL: https://github.com/apache/arrow/pull/12758#issuecomment-1083903716 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12720: URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592 Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbc

[GitHub] [arrow] ursabot edited a comment on pull request #12746: MINOR: [C++] Fix deprecation warning

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12746: URL: https://github.com/apache/arrow/pull/12746#issuecomment-1082832083 Benchmark runs are scheduled for baseline = 756f2b7249d00a64bc9efcbbce75445dda6a9008 and contender = 0deefd1838bf4706232b90b72da010698010f7b6. 0deefd1838bf4706232b90b72

[GitHub] [arrow] ursabot edited a comment on pull request #12728: ARROW-16042: [GO] Fix header file preprocessor issues

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12728: URL: https://github.com/apache/arrow/pull/12728#issuecomment-1082511579 Benchmark runs are scheduled for baseline = 6f10dab8a2204e1fa39c851e3ccc1f17d48b275e and contender = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c. ac58b8d5e5f424e2f81da680d

[GitHub] [arrow] github-actions[bot] commented on pull request #12759: WIP: DO NOT MERGE: Apache Arrow 2022-04 board report

2022-03-30 Thread GitBox
github-actions[bot] commented on pull request #12759: URL: https://github.com/apache/arrow/pull/12759#issuecomment-1083893305 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you op

[GitHub] [arrow] kou opened a new pull request #12759: WIP: DO NOT MERGE: Apache Arrow 2022-04 board report

2022-03-30 Thread GitBox
kou opened a new pull request #12759: URL: https://github.com/apache/arrow/pull/12759 This is a draft of Apache Arrow 2022-04 board report. Committers can push directly to this branch. Others can left suggestions. This is never merged to apache/arrow. This will be reported by http

[GitHub] [arrow-datafusion] jychen7 edited a comment on issue #2109: Almost 100x slowdown on 0.7.0 with CSV file

2022-03-30 Thread GitBox
jychen7 edited a comment on issue #2109: URL: https://github.com/apache/arrow-datafusion/issues/2109#issuecomment-1083882640 interesting, from the `master` branch as of now, the default `1000` is set in `CsvReadOptions` https://github.com/apache/arrow-datafusion/blob/c43b9ab9922ccbaaf6

[GitHub] [arrow-datafusion] jychen7 commented on issue #2109: Almost 100x slowdown on 0.7.0 with CSV file

2022-03-30 Thread GitBox
jychen7 commented on issue #2109: URL: https://github.com/apache/arrow-datafusion/issues/2109#issuecomment-1083882640 interesting, from the `master` branch as of now, the default `1000` is set in `CsvReadOptions` https://github.com/apache/arrow-datafusion/blob/c43b9ab9922ccbaaf6fe6f27e

[GitHub] [arrow-rs] viirya commented on pull request #1384: Add FFI for Arrow C Stream Interface

2022-03-30 Thread GitBox
viirya commented on pull request #1384: URL: https://github.com/apache/arrow-rs/pull/1384#issuecomment-1083867581 Thanks @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [arrow] ursabot edited a comment on pull request #12700: ARROW-15656: [C++] [R] Make valgrind builds slightly quicker

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12700: URL: https://github.com/apache/arrow/pull/12700#issuecomment-1082456979 Benchmark runs are scheduled for baseline = b56c0d8e765b06733afb4fe07879413de759c458 and contender = 6f10dab8a2204e1fa39c851e3ccc1f17d48b275e. 6f10dab8a2204e1fa39c851e3

[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12720: URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592 Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbc

[GitHub] [arrow] ursabot edited a comment on pull request #12728: ARROW-16042: [GO] Fix header file preprocessor issues

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12728: URL: https://github.com/apache/arrow/pull/12728#issuecomment-1082511579 Benchmark runs are scheduled for baseline = 6f10dab8a2204e1fa39c851e3ccc1f17d48b275e and contender = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c. ac58b8d5e5f424e2f81da680d

[GitHub] [arrow] rok edited a comment on pull request #12657: ARROW-14821: [R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date

2022-03-30 Thread GitBox
rok edited a comment on pull request #12657: URL: https://github.com/apache/arrow/pull/12657#issuecomment-1083555420 @djnavarro do you think this will cover requirements on R side? I've tried to use R to create the test data where possible and do sanity checks but I'm slowly developing t

[GitHub] [arrow] rok commented on a change in pull request #12154: ARROW-14821: [R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date

2022-03-30 Thread GitBox
rok commented on a change in pull request #12154: URL: https://github.com/apache/arrow/pull/12154#discussion_r839061083 ## File path: r/src/compute.cpp ## @@ -521,6 +521,20 @@ std::shared_ptr make_compute_options( return out; } + if (func_name == "round_temporal" ||

[GitHub] [arrow] djnavarro commented on a change in pull request #12154: ARROW-14821: [R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date

2022-03-30 Thread GitBox
djnavarro commented on a change in pull request #12154: URL: https://github.com/apache/arrow/pull/12154#discussion_r839048142 ## File path: r/src/compute.cpp ## @@ -521,6 +521,20 @@ std::shared_ptr make_compute_options( return out; } + if (func_name == "round_tempor

[GitHub] [arrow] ursabot edited a comment on pull request #12733: MINOR: [CI] Improve conda-clean output on error

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12733: URL: https://github.com/apache/arrow/pull/12733#issuecomment-1081604542 Benchmark runs are scheduled for baseline = 77e2a113362e8b623f685d851ae98eb7358f5166 and contender = 5cedd25efdced48fb809d7eef6729c4db4a9879d. 5cedd25efdced48fb809d7eef

[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12713: URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521 Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851

[GitHub] [arrow] ursabot edited a comment on pull request #12740: ARROW-15970: [R] [CI] Re-enable DuckDB dev tests

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12740: URL: https://github.com/apache/arrow/pull/12740#issuecomment-1081239714 Benchmark runs are scheduled for baseline = bd6453cee7aa2ce7772e8a28447d45e65a5c1ff5 and contender = dbea4ffde6afba8eba7cd26c78b270ed1a5178a9. dbea4ffde6afba8eba7cd26c7

[GitHub] [arrow] ursabot edited a comment on pull request #12735: ARROW-16049: [C++][FlightRPC] Fix Flight SQL's ColumnMetadata constructor visibility

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12735: URL: https://github.com/apache/arrow/pull/12735#issuecomment-1081228742 Benchmark runs are scheduled for baseline = b781710d950f61912c707d899f4f8750f4e149b0 and contender = bd6453cee7aa2ce7772e8a28447d45e65a5c1ff5. bd6453cee7aa2ce7772e8a284

[GitHub] [arrow] djnavarro commented on a change in pull request #12154: ARROW-14821: [R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date

2022-03-30 Thread GitBox
djnavarro commented on a change in pull request #12154: URL: https://github.com/apache/arrow/pull/12154#discussion_r839044931 ## File path: r/src/compute.cpp ## @@ -521,6 +521,20 @@ std::shared_ptr make_compute_options( return out; } + if (func_name == "round_tempor

[GitHub] [arrow] djnavarro commented on a change in pull request #12154: ARROW-14821: [R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date

2022-03-30 Thread GitBox
djnavarro commented on a change in pull request #12154: URL: https://github.com/apache/arrow/pull/12154#discussion_r839044851 ## File path: r/src/compute.cpp ## @@ -521,6 +521,20 @@ std::shared_ptr make_compute_options( return out; } + if (func_name == "round_tempor

[GitHub] [arrow] djnavarro commented on a change in pull request #12154: ARROW-14821: [R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date

2022-03-30 Thread GitBox
djnavarro commented on a change in pull request #12154: URL: https://github.com/apache/arrow/pull/12154#discussion_r839044292 ## File path: r/src/compute.cpp ## @@ -521,6 +521,20 @@ std::shared_ptr make_compute_options( return out; } + if (func_name == "round_tempor

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #1384: Add FFI for Arrow C Stream Interface

2022-03-30 Thread GitBox
codecov-commenter edited a comment on pull request #1384: URL: https://github.com/apache/arrow-rs/pull/1384#issuecomment-1060071149 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [arrow-rs] viirya commented on a change in pull request #1384: Add FFI for Arrow C Stream Interface

2022-03-30 Thread GitBox
viirya commented on a change in pull request #1384: URL: https://github.com/apache/arrow-rs/pull/1384#discussion_r839037905 ## File path: arrow/src/ffi_stream.rs ## @@ -0,0 +1,555 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

[GitHub] [arrow] ursabot edited a comment on pull request #12700: ARROW-15656: [C++] [R] Make valgrind builds slightly quicker

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12700: URL: https://github.com/apache/arrow/pull/12700#issuecomment-1082456979 Benchmark runs are scheduled for baseline = b56c0d8e765b06733afb4fe07879413de759c458 and contender = 6f10dab8a2204e1fa39c851e3ccc1f17d48b275e. 6f10dab8a2204e1fa39c851e3

[GitHub] [arrow] ursabot edited a comment on pull request #12728: ARROW-16042: [GO] Fix header file preprocessor issues

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12728: URL: https://github.com/apache/arrow/pull/12728#issuecomment-1082511579 Benchmark runs are scheduled for baseline = 6f10dab8a2204e1fa39c851e3ccc1f17d48b275e and contender = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c. ac58b8d5e5f424e2f81da680d

[GitHub] [arrow] ursabot edited a comment on pull request #12720: ARROW-15994: [C++] Back out taskify changes

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12720: URL: https://github.com/apache/arrow/pull/12720#issuecomment-1082511592 Benchmark runs are scheduled for baseline = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c and contender = 756f2b7249d00a64bc9efcbbce75445dda6a9008. 756f2b7249d00a64bc9efcbbc

[GitHub] [arrow] ursabot edited a comment on pull request #12712: ARROW-16026: [C++] Add support for the serial executor to expose an async generator as an iterable

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12712: URL: https://github.com/apache/arrow/pull/12712#issuecomment-1082145892 Benchmark runs are scheduled for baseline = d7fbf5260433dee08ae219e8aec34169cd610652 and contender = b56c0d8e765b06733afb4fe07879413de759c458. b56c0d8e765b06733afb4fe07

[GitHub] [arrow] ursabot edited a comment on pull request #12700: ARROW-15656: [C++] [R] Make valgrind builds slightly quicker

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12700: URL: https://github.com/apache/arrow/pull/12700#issuecomment-1082456979 Benchmark runs are scheduled for baseline = b56c0d8e765b06733afb4fe07879413de759c458 and contender = 6f10dab8a2204e1fa39c851e3ccc1f17d48b275e. 6f10dab8a2204e1fa39c851e3

[GitHub] [arrow] ursabot edited a comment on pull request #12730: ARROW-16044: [Julia] Remove from apache/arrow

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12730: URL: https://github.com/apache/arrow/pull/12730#issuecomment-1081290089 Benchmark runs are scheduled for baseline = f4cc59313043493628b39fe757e2796fc74ac42f and contender = 556ee23e539015bd414dc8df46a3b7a0c7404381. 556ee23e539015bd414dc8df4

[GitHub] [arrow] ursabot edited a comment on pull request #12713: ARROW-15611: [C++] Migrate arrow::ipc::internal::json::ArrayFromJSON to Result<>

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12713: URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521 Benchmark runs are scheduled for baseline = 556ee23e539015bd414dc8df46a3b7a0c7404381 and contender = 77e2a113362e8b623f685d851ae98eb7358f5166. 77e2a113362e8b623f685d851

[GitHub] [arrow] ursabot edited a comment on pull request #12728: ARROW-16042: [GO] Fix header file preprocessor issues

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12728: URL: https://github.com/apache/arrow/pull/12728#issuecomment-1082511579 Benchmark runs are scheduled for baseline = 6f10dab8a2204e1fa39c851e3ccc1f17d48b275e and contender = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c. ac58b8d5e5f424e2f81da680d

[GitHub] [arrow] ursabot edited a comment on pull request #12740: ARROW-15970: [R] [CI] Re-enable DuckDB dev tests

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12740: URL: https://github.com/apache/arrow/pull/12740#issuecomment-1081239714 Benchmark runs are scheduled for baseline = bd6453cee7aa2ce7772e8a28447d45e65a5c1ff5 and contender = dbea4ffde6afba8eba7cd26c78b270ed1a5178a9. dbea4ffde6afba8eba7cd26c7

[GitHub] [arrow] ursabot edited a comment on pull request #12735: ARROW-16049: [C++][FlightRPC] Fix Flight SQL's ColumnMetadata constructor visibility

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12735: URL: https://github.com/apache/arrow/pull/12735#issuecomment-1081228742 Benchmark runs are scheduled for baseline = b781710d950f61912c707d899f4f8750f4e149b0 and contender = bd6453cee7aa2ce7772e8a28447d45e65a5c1ff5. bd6453cee7aa2ce7772e8a284

[GitHub] [arrow] ursabot edited a comment on pull request #12741: ARROW-16052: [R] undefined global function %>%

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12741: URL: https://github.com/apache/arrow/pull/12741#issuecomment-1081239721 Benchmark runs are scheduled for baseline = dbea4ffde6afba8eba7cd26c78b270ed1a5178a9 and contender = f4cc59313043493628b39fe757e2796fc74ac42f. f4cc59313043493628b39fe75

[GitHub] [arrow] ursabot edited a comment on pull request #12756: ARROW-16068: [C++][FlightRPC] Migrate remaining flight API to use Result<>

2022-03-30 Thread GitBox
ursabot edited a comment on pull request #12756: URL: https://github.com/apache/arrow/pull/12756#issuecomment-1083465222 Benchmark runs are scheduled for baseline = ea4ab77a25c1df59d1d4f79b23d5bced841f7ba3 and contender = 600288e3f31dc5a7817f69ff59b5b69510d23e8a. 600288e3f31dc5a7817f69ff5

  1   2   3   4   5   >