pitrou commented on PR #12931:
URL: https://github.com/apache/arrow/pull/12931#issuecomment-1106064353
Ok, so should there be a dedicated test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou commented on code in PR #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r855810851
##
cpp/src/arrow/python/common.h:
##
@@ -180,6 +180,9 @@ class ARROW_PYTHON_EXPORT OwnedRefNoGIL : public OwnedRef {
explicit OwnedRefNoGIL(PyObject* obj) : OwnedRef(o
github-actions[bot] commented on PR #12945:
URL: https://github.com/apache/arrow/pull/12945#issuecomment-1106063019
https://issues.apache.org/jira/browse/ARROW-16219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
pitrou commented on PR #12945:
URL: https://github.com/apache/arrow/pull/12945#issuecomment-1106060292
One problem is that AFAICT a git command is implicitly issued by
setuptools_scm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kou commented on PR #12931:
URL: https://github.com/apache/arrow/pull/12931#issuecomment-1106056246
> this looks quite empty, are you planning to add support for GcsOptions?
I'll add do it eventually but it's usable without this by #12763 (or #12932).
> Or are people expected to
AlenkaF commented on PR #12855:
URL: https://github.com/apache/arrow/pull/12855#issuecomment-1106045587
Errors do not seem to be related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
github-actions[bot] commented on PR #12951:
URL: https://github.com/apache/arrow/pull/12951#issuecomment-1106027515
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue
ursabot commented on PR #12815:
URL: https://github.com/apache/arrow/pull/12815#issuecomment-1106004466
Benchmark runs are scheduled for baseline =
f2d12138f410d37c343109a59a35619b821ea870 and contender =
7dd8a4bd62879416eca189fe6d9e0023e4936d87.
7dd8a4bd62879416eca189fe6d9e0023e4936d87 is
github-actions[bot] commented on PR #12893:
URL: https://github.com/apache/arrow/pull/12893#issuecomment-110595
Revision: a00d8f7d1890d29919b6ebd316a47ab5d33489c4
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1902](https://github.com/ursacomputing/crossbow/branches/
vibhatha commented on code in PR #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r855757290
##
python/pyarrow/tests/test_udf.py:
##
@@ -0,0 +1,458 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
AlenkaF commented on code in PR #12855:
URL: https://github.com/apache/arrow/pull/12855#discussion_r855756291
##
r/tests/testthat/test-dplyr-funcs-datetime.R:
##
@@ -1303,6 +1303,74 @@ test_that("dminutes, dhours, ddays, dweeks, dmonths,
dyears", {
tibble(),
ignore_at
westonpace commented on code in PR #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r855755678
##
python/pyarrow/tests/test_udf.py:
##
@@ -0,0 +1,458 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. Se
assignUser commented on PR #12893:
URL: https://github.com/apache/arrow/pull/12893#issuecomment-1105987880
@github-actions crossbow submit wheel-windows-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
westonpace commented on PR #12944:
URL: https://github.com/apache/arrow/pull/12944#issuecomment-1105985148
CC @michalursa Valgrind started timing out on the hash-join-node-test. The
root cause for the newly emerged failure may have been the addition of the
bloom filter tests or it may have
westonpace closed pull request #12843: ARROW-16148: [C++] TPC-H generator
cleanup
URL: https://github.com/apache/arrow/pull/12843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
vibhatha commented on code in PR #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r855750535
##
python/pyarrow/tests/test_udf.py:
##
@@ -0,0 +1,458 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855748314
##
cpp/src/arrow/compute/exec/options.h:
##
@@ -129,17 +129,86 @@ class ARROW_EXPORT AggregateNodeOptions : public
ExecNodeOptions {
std::vector keys;
};
+cons
westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855748930
##
cpp/src/arrow/compute/exec/sink_node.cc:
##
@@ -46,31 +46,81 @@ using internal::checked_cast;
namespace compute {
namespace {
+class BackpressureResevoir : pub
westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855748874
##
cpp/src/arrow/compute/exec/sink_node.cc:
##
@@ -103,6 +157,28 @@ class SinkNode : public ExecNode {
Future<> finished() override { return finished_; }
+ vo
westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855748683
##
cpp/src/arrow/compute/exec/sink_node.cc:
##
@@ -46,31 +46,81 @@ using internal::checked_cast;
namespace compute {
namespace {
+class BackpressureResevoir : pub
westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855748314
##
cpp/src/arrow/compute/exec/options.h:
##
@@ -129,17 +129,86 @@ class ARROW_EXPORT AggregateNodeOptions : public
ExecNodeOptions {
std::vector keys;
};
+cons
westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855748416
##
cpp/src/arrow/compute/exec/options.h:
##
@@ -129,17 +129,86 @@ class ARROW_EXPORT AggregateNodeOptions : public
ExecNodeOptions {
std::vector keys;
};
+cons
westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855744214
##
cpp/src/arrow/compute/exec/options.h:
##
@@ -129,17 +129,86 @@ class ARROW_EXPORT AggregateNodeOptions : public
ExecNodeOptions {
std::vector keys;
};
+cons
westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855743738
##
cpp/src/arrow/compute/exec/sink_node.cc:
##
@@ -46,31 +46,81 @@ using internal::checked_cast;
namespace compute {
namespace {
+class BackpressureResevoir : pub
yjshen merged PR #2242:
URL: https://github.com/apache/arrow-datafusion/pull/2242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arr
yjshen closed issue #141: Implement Sort-Merge Join
URL: https://github.com/apache/arrow-datafusion/issues/141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
kou commented on PR #12945:
URL: https://github.com/apache/arrow/pull/12945#issuecomment-1105969897
Can we add `-c safe.directory=...` to `git` command lines in
`cpp/cmake_modules/DefineOptions.cmake` and `python/setup.py` instead of adding
`git config --global`?
--
This is an automated
westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855738848
##
cpp/src/arrow/compute/exec/options.h:
##
@@ -129,17 +129,86 @@ class ARROW_EXPORT AggregateNodeOptions : public
ExecNodeOptions {
std::vector keys;
};
+cons
westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855737474
##
cpp/src/arrow/compute/exec/hash_join_node.cc:
##
@@ -593,9 +593,13 @@ class HashJoinNode : public ExecNode {
return Status::OK();
}
- void PauseProducin
westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855737474
##
cpp/src/arrow/compute/exec/hash_join_node.cc:
##
@@ -593,9 +593,13 @@ class HashJoinNode : public ExecNode {
return Status::OK();
}
- void PauseProducin
westonpace commented on PR #12323:
URL: https://github.com/apache/arrow/pull/12323#issuecomment-1105960742
Got it, makes sense. Thanks for the info. Let's stick with what you have
then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
westonpace commented on code in PR #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r855734135
##
python/pyarrow/tests/test_udf.py:
##
@@ -0,0 +1,458 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. Se
westonpace commented on PR #12928:
URL: https://github.com/apache/arrow/pull/12928#issuecomment-1105955726
I played around with this a bit more. I can reproduce it locally by
building with SSE4_2:
```
cmake .. -DARROW_PARQUET=ON -DARROW_SIMD_LEVEL=SSE4_2
-DARROW_RUNTIME_SIMD_LEVE
rok commented on code in PR #12865:
URL: https://github.com/apache/arrow/pull/12865#discussion_r855730494
##
cpp/src/arrow/vendored/datetime/tz.h:
##
@@ -294,6 +294,40 @@ struct zoned_traits
{
};
+class OffsetZone {
Review Comment:
Moved. The code in the file is adapted
ursabot commented on PR #12804:
URL: https://github.com/apache/arrow/pull/12804#issuecomment-1105936878
Benchmark runs are scheduled for baseline =
f3047a605c7c3b874bbf9530efd728c16242bea8 and contender =
f2d12138f410d37c343109a59a35619b821ea870.
f2d12138f410d37c343109a59a35619b821ea870 is
HaoChen-ch closed issue #12942: [c++][substrait]Couldn't find a file named
expression.pb
URL: https://github.com/apache/arrow/issues/12942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
HaoChen-ch commented on issue #12942:
URL: https://github.com/apache/arrow/issues/12942#issuecomment-1105927532
Thanks very much for the reply.I get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
edponce commented on PR #12096:
URL: https://github.com/apache/arrow/pull/12096#issuecomment-1105904838
@jorisvandenbossche @pitrou I would appreciate your review on this PR when
you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
AlvinJ15 commented on code in PR #12702:
URL: https://github.com/apache/arrow/pull/12702#discussion_r855692962
##
r/src/arrowExports.cpp:
##
@@ -5088,12 +5088,12 @@ return Rf_ScalarLogical(
);
}
static const R_CallMethodDef CallEntries[] = {
- { "_arrow_availabl
andygrove merged PR #2313:
URL: https://github.com/apache/arrow-datafusion/pull/2313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove merged PR #2310:
URL: https://github.com/apache/arrow-datafusion/pull/2310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove closed issue #2306: CrossJoin Evaluates In ExecutionPlan::execute
URL: https://github.com/apache/arrow-datafusion/issues/2306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
rok commented on PR #12657:
URL: https://github.com/apache/arrow/pull/12657#issuecomment-1105880035
CI issues seem unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ursabot commented on PR #12920:
URL: https://github.com/apache/arrow/pull/12920#issuecomment-1105834346
Benchmark runs are scheduled for baseline =
c38a32ef59e2f12c111614838bd3014d0adc6a91 and contender =
f3047a605c7c3b874bbf9530efd728c16242bea8.
f3047a605c7c3b874bbf9530efd728c16242bea8 is
westonpace commented on issue #12942:
URL: https://github.com/apache/arrow/issues/12942#issuecomment-1105830108
However, Arrow does not yet have a fully compliant consumer of Substrait IR.
That is a work in-progress. For example:
https://issues.apache.org/jira/browse/ARROW-16036?jql=Proje
westonpace commented on issue #12942:
URL: https://github.com/apache/arrow/issues/12942#issuecomment-1105829402
If you are referring to the flatbuffers-based serializer
(`ir_consumer.h`/`ir_consumer.cc`) then I'm pretty sure this has been
discontinued in favor of Substrait.
So you sh
westonpace commented on code in PR #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r855641281
##
cpp/src/arrow/python/common.h:
##
@@ -180,6 +180,9 @@ class ARROW_PYTHON_EXPORT OwnedRefNoGIL : public OwnedRef {
explicit OwnedRefNoGIL(PyObject* obj) : OwnedR
westonpace commented on code in PR #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r855641281
##
cpp/src/arrow/python/common.h:
##
@@ -180,6 +180,9 @@ class ARROW_PYTHON_EXPORT OwnedRefNoGIL : public OwnedRef {
explicit OwnedRefNoGIL(PyObject* obj) : OwnedR
zeroshade closed pull request #12876: ARROW-16187: [Go][Parquet] Properly
utilize BufferedStream and buffer size when reading
URL: https://github.com/apache/arrow/pull/12876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
sunchao commented on issue #1554:
URL: https://github.com/apache/arrow-rs/issues/1554#issuecomment-1105824993
+1. I think the new proposal looks cleaner. Also +1 on changing to CamelCase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nealrichardson closed pull request #12946: MINOR: [R][CI] Guard against missing
reticulate
URL: https://github.com/apache/arrow/pull/12946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
jvanstraten commented on PR #12916:
URL: https://github.com/apache/arrow/pull/12916#issuecomment-1105800137
> A single file shouldn't have different URIs referring to it.
I guess I was mainly thinking from the validator's perspective, where a URI
is just something it resolves to a YAM
jonkeane closed pull request #11666: ARROW-14638: [C++][R] Unknown C compiler /
ccache on Arch Linux
URL: https://github.com/apache/arrow/pull/11666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jonkeane commented on PR #11666:
URL: https://github.com/apache/arrow/pull/11666#issuecomment-1105794854
The Go failures are unrelated (and on master), the other failures are also
unrelated (and possibly intermittent given it's brew installing git?)
--
This is an automated message from th
wjones127 commented on PR #12751:
URL: https://github.com/apache/arrow/pull/12751#issuecomment-1105785422
FYI, on second thought, I'd rather do the integration work with the S3
generics in a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the messa
matthewmturner commented on PR #2279:
URL:
https://github.com/apache/arrow-datafusion/pull/2279#issuecomment-1105776419
@alamb I actually hadn't even made it to the point of implementing that yet
- just wanted to see if conceptually you thought that was the right approach.
Wasn't expecting
zeroshade closed pull request #12926: ARROW-15950: [Go] Lift BitSetRunReader to
internal/bitutils package
URL: https://github.com/apache/arrow/pull/12926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alamb commented on PR #2279:
URL:
https://github.com/apache/arrow-datafusion/pull/2279#issuecomment-1105773160
Thanks @matthewmturner -- I'll try and give it a look tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
lidavidm commented on code in PR #12702:
URL: https://github.com/apache/arrow/pull/12702#discussion_r855594616
##
r/src/arrowExports.cpp:
##
@@ -5088,12 +5088,12 @@ return Rf_ScalarLogical(
);
}
static const R_CallMethodDef CallEntries[] = {
- { "_arrow_availabl
github-actions[bot] commented on PR #12950:
URL: https://github.com/apache/arrow/pull/12950#issuecomment-1105751337
https://issues.apache.org/jira/browse/ARROW-15312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
westonpace commented on code in PR #12915:
URL: https://github.com/apache/arrow/pull/12915#discussion_r855584263
##
cpp/CMakeLists.txt:
##
@@ -353,7 +353,7 @@ if(ARROW_CUDA
set(ARROW_IPC ON)
endif()
-if(ARROW_ENGINE)
+if(ARROW_SUBSTRAIT)
Review Comment:
Yes. In the fu
github-actions[bot] commented on PR #12948:
URL: https://github.com/apache/arrow/pull/12948#issuecomment-1105746578
https://issues.apache.org/jira/browse/ARROW-11415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
andygrove opened a new pull request, #2313:
URL: https://github.com/apache/arrow-datafusion/pull/2313
# Which issue does this PR close?
N/A
# Rationale for this change
This is just some minor cleanup following on from the refactoring in
https://github.com/ap
github-actions[bot] commented on PR #12946:
URL: https://github.com/apache/arrow/pull/12946#issuecomment-1105733581
Revision: 1d580f5a2704b881174a5a95fdf8926bc0a563d7
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1901](https://github.com/ursacomputing/crossbow/branches/
tustvold commented on code in PR #2310:
URL: https://github.com/apache/arrow-datafusion/pull/2310#discussion_r855571115
##
datafusion/core/src/physical_plan/cross_join.rs:
##
@@ -352,14 +364,46 @@ impl Stream for CrossJoinStream {
mut self: std::pin::Pin<&mut Self>,
andygrove merged PR #2311:
URL: https://github.com/apache/arrow-datafusion/pull/2311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove closed issue #2309: Move CASE/WHEN expression code to datafusion-expr
crate
URL: https://github.com/apache/arrow-datafusion/issues/2309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tustvold merged PR #2312:
URL: https://github.com/apache/arrow-datafusion/pull/2312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@a
tustvold closed issue #1939: SortExec No Longer Streams Correctly
URL: https://github.com/apache/arrow-datafusion/issues/1939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
westonpace commented on PR #12916:
URL: https://github.com/apache/arrow/pull/12916#issuecomment-1105722249
> Right now it only specifies the types, but Substrait currently doesn't
specify a way for YAML files to refer to each other, so unless support for that
is added
I'm assuming we
github-actions[bot] commented on PR #12944:
URL: https://github.com/apache/arrow/pull/12944#issuecomment-1105718393
Revision: a281ad8542fb35aa418bc2eefc8f63a2ef64b8cb
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1900](https://github.com/ursacomputing/crossbow/branches/
nealrichardson commented on code in PR #12751:
URL: https://github.com/apache/arrow/pull/12751#discussion_r855560829
##
r/tests/testthat/test-Table.R:
##
@@ -518,6 +518,147 @@ test_that("Table$create() no recycling with tibbles", {
)
})
+test_that("Tables can be combined w
nealrichardson commented on code in PR #12751:
URL: https://github.com/apache/arrow/pull/12751#discussion_r855560200
##
r/R/table.R:
##
@@ -149,6 +149,83 @@ Table$create <- function(..., schema = NULL) {
#' @export
names.Table <- function(x) x$ColumnNames()
+#' Concatenate o
ursabot commented on PR #12934:
URL: https://github.com/apache/arrow/pull/12934#issuecomment-1105710975
Benchmark runs are scheduled for baseline =
b8be05b73a826f2d989389e69252e2f4c8501d68 and contender =
c38a32ef59e2f12c111614838bd3014d0adc6a91.
c38a32ef59e2f12c111614838bd3014d0adc6a91 is
nealrichardson commented on code in PR #12751:
URL: https://github.com/apache/arrow/pull/12751#discussion_r83711
##
r/R/table.R:
##
@@ -149,6 +149,87 @@ Table$create <- function(..., schema = NULL) {
#' @export
names.Table <- function(x) x$ColumnNames()
+#' Concatenate o
pitrou commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1105700884
Ok, this still doesn't pass CI everywhere, so I think we're probably going
to postpone this to 9.0.0:
https://app.travis-ci.com/github/ursacomputing/crossbow/builds/249704738#L4712
kszucs commented on PR #12893:
URL: https://github.com/apache/arrow/pull/12893#issuecomment-1105696396
Than you can submit the windows wheel builds using `@github-actions crossbow
submit wheel-windows-*` comment.
--
This is an automated message from the Apache Git Service.
To respond to t
kszucs commented on PR #12893:
URL: https://github.com/apache/arrow/pull/12893#issuecomment-1105694970
@assignUser can you trigger the windows image builds for the vcpkg version
now that https://github.com/ursacomputing/crossbow/pull/14 has been merged?
--
This is an automated message fro
github-actions[bot] commented on PR #12947:
URL: https://github.com/apache/arrow/pull/12947#issuecomment-1105689319
```
Failed to push updated references, potentially because of credential issues:
['refs/heads/actions-1899-github-test-conda-python-3.7-kartothek-latest',
'refs/tags/action
github-actions[bot] commented on PR #12323:
URL: https://github.com/apache/arrow/pull/12323#issuecomment-1105689164
Revision: 76ae1ab0aca93aeb5f2f05736752d4ec4ce9a16c
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1899](https://github.com/ursacomputing/crossbow/branches/
github-actions[bot] commented on PR #12947:
URL: https://github.com/apache/arrow/pull/12947#issuecomment-1105688557
https://issues.apache.org/jira/browse/ARROW-16262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
domoritz commented on code in PR #12938:
URL: https://github.com/apache/arrow/pull/12938#discussion_r855538937
##
docs/source/status.rst:
##
@@ -20,8 +20,9 @@ Implementation Status
=
The following tables summarize the features available in the various off
domoritz commented on code in PR #12938:
URL: https://github.com/apache/arrow/pull/12938#discussion_r855538937
##
docs/source/status.rst:
##
@@ -20,8 +20,9 @@ Implementation Status
=
The following tables summarize the features available in the various off
davisusanibar commented on code in PR #12941:
URL: https://github.com/apache/arrow/pull/12941#discussion_r855533449
##
java/pom.xml:
##
@@ -736,6 +738,7 @@
See https://github.com/jbosstools/m2e-apt/issues/62 for details
-->
+1.8
Review Comment
davisusanibar commented on code in PR #12941:
URL: https://github.com/apache/arrow/pull/12941#discussion_r855533265
##
java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java:
##
@@ -77,6 +77,7 @@
/**
* Flight client with Flight SQL semantics.
edponce commented on PR #5:
URL: https://github.com/apache/arrow/pull/5#issuecomment-1105677889
@kszucs Do not mark this PR as stale. I had stopped working on it bc I had
trouble figuring out how to output a StructArray from compute kernel, but I
have a pretty good understanding now
davisusanibar commented on code in PR #12941:
URL: https://github.com/apache/arrow/pull/12941#discussion_r855533095
##
java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestClientMiddleware.java:
##
@@ -246,9 +246,11 @@ public FlightClientMiddleware onCallStarted(Cal
davisusanibar commented on code in PR #12941:
URL: https://github.com/apache/arrow/pull/12941#discussion_r855532845
##
java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java:
##
@@ -346,7 +345,7 @@ public FlightInfo getExportedKeys(final TableRef t
wjones127 commented on code in PR #12751:
URL: https://github.com/apache/arrow/pull/12751#discussion_r855532669
##
r/R/table.R:
##
@@ -149,6 +149,83 @@ Table$create <- function(..., schema = NULL) {
#' @export
names.Table <- function(x) x$ColumnNames()
+#' Concatenate one or
lidavidm commented on code in PR #12941:
URL: https://github.com/apache/arrow/pull/12941#discussion_r855531121
##
java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java:
##
@@ -346,7 +345,7 @@ public FlightInfo getExportedKeys(final TableRef tableR
davisusanibar commented on code in PR #12941:
URL: https://github.com/apache/arrow/pull/12941#discussion_r855528794
##
java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java:
##
@@ -346,7 +345,7 @@ public FlightInfo getExportedKeys(final TableRef t
alamb commented on PR #2312:
URL:
https://github.com/apache/arrow-datafusion/pull/2312#issuecomment-1105669402
> It's really just a trick to ensure a given field is consistently either s
TIL
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
tustvold commented on code in PR #2310:
URL: https://github.com/apache/arrow-datafusion/pull/2310#discussion_r855526070
##
datafusion/core/src/physical_plan/cross_join.rs:
##
@@ -352,14 +364,46 @@ impl Stream for CrossJoinStream {
mut self: std::pin::Pin<&mut Self>,
jonkeane commented on PR #11666:
URL: https://github.com/apache/arrow/pull/11666#issuecomment-1105666086
Ok, I've confirmed this works with a crossbow build at:
https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=23739&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=6c939d
lidavidm commented on code in PR #12941:
URL: https://github.com/apache/arrow/pull/12941#discussion_r855524920
##
java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java:
##
@@ -346,7 +345,7 @@ public FlightInfo getExportedKeys(final TableRef tableR
jonkeane opened a new pull request, #12950:
URL: https://github.com/apache/arrow/pull/12950
The real fix was in https://github.com/apache/arrow/pull/12891
([ARROW-12659](https://issues.apache.org/jira/browse/ARROW-12659)) but this
adds integration tests from the ticket to confirm this works
davisusanibar commented on code in PR #12941:
URL: https://github.com/apache/arrow/pull/12941#discussion_r855522488
##
java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java:
##
@@ -346,7 +345,7 @@ public FlightInfo getExportedKeys(final TableRef t
wjones127 commented on code in PR #12751:
URL: https://github.com/apache/arrow/pull/12751#discussion_r855522429
##
r/R/table.R:
##
@@ -149,6 +149,83 @@ Table$create <- function(..., schema = NULL) {
#' @export
names.Table <- function(x) x$ColumnNames()
+#' Concatenate one or
lidavidm commented on code in PR #12891:
URL: https://github.com/apache/arrow/pull/12891#discussion_r855521687
##
cpp/src/arrow/util/vector.h:
##
@@ -78,8 +78,8 @@ std::vector ReplaceVectorElement(const std::vector&
values, size_t index,
template
std::vector FilterVector(s
lidavidm opened a new pull request, #12949:
URL: https://github.com/apache/arrow/pull/12949
Quick follow up to #12891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
1 - 100 of 419 matches
Mail list logo
