rtpsw commented on code in PR #13252:
URL: https://github.com/apache/arrow/pull/13252#discussion_r888658433
##
cpp/src/arrow/compute/registry_test.cc:
##
@@ -85,5 +95,137 @@ TEST_F(TestRegistry, Basics) {
ASSERT_EQ(func, f2);
}
+INSTANTIATE_TEST_SUITE_P(
+TestRegistry,
viirya commented on code in PR #1767:
URL: https://github.com/apache/arrow-rs/pull/1767#discussion_r888650741
##
arrow/src/array/data.rs:
##
@@ -999,6 +999,27 @@ impl ArrayData {
pub fn validate_dictionary_offset(&self) -> Result<()> {
match &self.data_type {
+
jorisvandenbossche commented on code in PR #12868:
URL: https://github.com/apache/arrow/pull/12868#discussion_r888649138
##
docs/source/format/Glossary.rst:
##
@@ -0,0 +1,207 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreem
jorisvandenbossche commented on code in PR #12868:
URL: https://github.com/apache/arrow/pull/12868#discussion_r888648624
##
docs/source/format/Glossary.rst:
##
@@ -0,0 +1,202 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreem
jorisvandenbossche merged PR #13306:
URL: https://github.com/apache/arrow/pull/13306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
viirya commented on PR #1767:
URL: https://github.com/apache/arrow-rs/pull/1767#issuecomment-1145624525
> Generally it sounds good to me. But in the test, we are not using the
builder directly. The builder is called by more higher API when reading
JSON/Arrow files into Arrays. So seems we n
AssHero commented on issue #2653:
URL:
https://github.com/apache/arrow-datafusion/issues/2653#issuecomment-1145623700
I think the merge request #2671 already fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
viirya commented on PR #1767:
URL: https://github.com/apache/arrow-rs/pull/1767#issuecomment-1145613279
> I think this would avoid having to add #[cfg(not(feature =
"force_validate"))]
Oh, BTW, adding `#[cfg(not(feature = "force_validate"))]` to several tests
is for the added check i
github-actions[bot] commented on PR #13244:
URL: https://github.com/apache/arrow/pull/13244#issuecomment-1145591555
Revision: 1803f59ff1ffae29f181ae53445aa6fb543d1324
Submitted crossbow builds: [ursacomputing/crossbow @
actions-056e6bc9c5](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #13244:
URL: https://github.com/apache/arrow/pull/13244#issuecomment-1145591017
@github-actions crossbow submit java-jars wheel-macos-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rtpsw commented on code in PR #13252:
URL: https://github.com/apache/arrow/pull/13252#discussion_r888612056
##
cpp/src/arrow/compute/registry_test.cc:
##
@@ -27,37 +27,44 @@
#include "arrow/status.h"
#include "arrow/testing/gtest_util.h"
#include "arrow/util/macros.h"
+#inclu
github-actions[bot] commented on PR #13244:
URL: https://github.com/apache/arrow/pull/13244#issuecomment-1145587404
```
No such command 'java-jars'.
The Archery job run can be found at:
https://github.com/apache/arrow/actions/runs/2432582465
```
--
This is an automated message fr
kou commented on PR #13244:
URL: https://github.com/apache/arrow/pull/13244#issuecomment-1145587175
@github-actions crossbow java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #13307:
URL: https://github.com/apache/arrow/pull/13307#issuecomment-1145585645
Revision: d9c6e6e4e89a55ba53a5c6d2998fffb77d4facbc
Submitted crossbow builds: [ursacomputing/crossbow @
actions-5d03c61214](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #13307:
URL: https://github.com/apache/arrow/pull/13307#issuecomment-1145585273
@github-actions crossbow submit almalinux-* amazon-linux-* centos-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
github-actions[bot] commented on PR #13307:
URL: https://github.com/apache/arrow/pull/13307#issuecomment-1145585173
https://issues.apache.org/jira/browse/ARROW-16745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-actions[bot] commented on PR #13157:
URL: https://github.com/apache/arrow/pull/13157#issuecomment-1145577037
Revision: 9d64c2cb7aa7c3e0fa93f7729c2e28c4694345d3
Submitted crossbow builds: [ursacomputing/crossbow @
actions-aab9db08d5](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #13157:
URL: https://github.com/apache/arrow/pull/13157#issuecomment-1145576548
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
REASY commented on PR #13157:
URL: https://github.com/apache/arrow/pull/13157#issuecomment-1145559147
The last failure is due to timeout, timeout is defined here:
https://github.com/REASY/arrow/actions/runs/2431985384/workflow#L259-L270
,error:
https://github.com/REASY/arrow/runs/671905194
rok commented on PR #12528:
URL: https://github.com/apache/arrow/pull/12528#issuecomment-1145552268
I've rebased and refactored a bit because of #12657. Logic around DST jumps
is almost ready.
I've also introduced a flag (sigh)
`RoundTemporalOptions.preserve_wall_time_order` that fla
westonpace commented on code in PR #13218:
URL: https://github.com/apache/arrow/pull/13218#discussion_r888574094
##
cpp/src/arrow/compute/row/row_internal.h:
##
@@ -0,0 +1,244 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
westonpace commented on code in PR #13218:
URL: https://github.com/apache/arrow/pull/13218#discussion_r888574179
##
cpp/src/arrow/compute/row/row_internal.h:
##
@@ -0,0 +1,244 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
westonpace commented on code in PR #13218:
URL: https://github.com/apache/arrow/pull/13218#discussion_r888573870
##
cpp/src/arrow/compute/row/row_internal.h:
##
@@ -0,0 +1,244 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
westonpace commented on code in PR #13218:
URL: https://github.com/apache/arrow/pull/13218#discussion_r888571930
##
cpp/src/arrow/compute/row/row_internal.h:
##
@@ -0,0 +1,244 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
westonpace commented on code in PR #13218:
URL: https://github.com/apache/arrow/pull/13218#discussion_r888571835
##
cpp/src/arrow/compute/light_array.h:
##
@@ -31,6 +33,18 @@
namespace arrow {
namespace compute {
+/// \brief Context needed by various execution engine operati
westonpace commented on code in PR #13218:
URL: https://github.com/apache/arrow/pull/13218#discussion_r888571708
##
cpp/src/arrow/compute/api_aggregate.h:
##
@@ -482,6 +404,21 @@ struct ARROW_EXPORT Aggregate {
const FunctionOptions* options;
};
+Result> GetKernels(
Revie
westonpace commented on code in PR #13218:
URL: https://github.com/apache/arrow/pull/13218#discussion_r888564544
##
cpp/src/arrow/compute/row/row_internal.h:
##
@@ -0,0 +1,244 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
westonpace commented on code in PR #13218:
URL: https://github.com/apache/arrow/pull/13218#discussion_r888563914
##
cpp/src/arrow/compute/row/encode_internal.h:
##
@@ -0,0 +1,323 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
westonpace commented on code in PR #13218:
URL: https://github.com/apache/arrow/pull/13218#discussion_r888562981
##
cpp/src/arrow/compute/exec/key_hash.h:
##
@@ -45,8 +45,8 @@ class ARROW_EXPORT Hashing32 {
friend void TestBloomSmall(BloomFilterBuildStrategy, int64_t, int, bo
kou commented on PR #13293:
URL: https://github.com/apache/arrow/pull/13293#issuecomment-1145518011
It seems there are more warnings. e.g.:
https://github.com/apache/arrow/runs/6707180740?check_suite_focus=true#step:7:1074
```text
In file included from
D:/a/arrow/arrow/buil
kou commented on PR #13293:
URL: https://github.com/apache/arrow/pull/13293#issuecomment-1145518012
It seems there are more warnings. e.g.:
https://github.com/apache/arrow/runs/6707180740?check_suite_focus=true#step:7:1074
```text
In file included from
D:/a/arrow/arrow/buil
github-actions[bot] commented on PR #13244:
URL: https://github.com/apache/arrow/pull/13244#issuecomment-1145515411
Revision: 160ec959af76ed6ef6073ac00fa5fe1e7d49db18
Submitted crossbow builds: [ursacomputing/crossbow @
actions-082fa4d9b1](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #13244:
URL: https://github.com/apache/arrow/pull/13244#issuecomment-1145514928
@github-actions crossbow submit wheel-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
vibhatha commented on PR #13306:
URL: https://github.com/apache/arrow/pull/13306#issuecomment-1145510497
cc @jorisvandenbossche could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
westonpace commented on code in PR #13252:
URL: https://github.com/apache/arrow/pull/13252#discussion_r888518121
##
cpp/src/arrow/compute/registry.cc:
##
@@ -34,7 +34,20 @@ namespace compute {
class FunctionRegistry::FunctionRegistryImpl {
public:
- Status AddFunction(std:
vibhatha opened a new pull request, #13306:
URL: https://github.com/apache/arrow/pull/13306
Adding minor doc change to include a click-able link to
`TableSinkNodeOptions` in ACERO docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou commented on PR #12914:
URL: https://github.com/apache/arrow/pull/12914#issuecomment-1145499057
Could you enable it in `.github/workflows/cpp.yml` (Linux, macOS and
Windows) and `ci/docker/ubuntu-*-cpp.dockerfile`?
--
This is an automated message from the Apache Git Service.
To respon
kou commented on PR #13283:
URL: https://github.com/apache/arrow/pull/13283#issuecomment-1145482723
I confirmed this.
* For merging: +1
* For `archery release changelog add`: It works with invalid token. It seems
that it works with anonymous access. How about removing the authentic
github-actions[bot] commented on PR #13244:
URL: https://github.com/apache/arrow/pull/13244#issuecomment-1145474913
Revision: d100b397e9fbc7bf359688146c1e1a74a2980717
Submitted crossbow builds: [ursacomputing/crossbow @
actions-9de9fb80c7](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #13244:
URL: https://github.com/apache/arrow/pull/13244#issuecomment-1145471724
@github-actions crossbow submit wheel-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
andygrove commented on PR #2549:
URL:
https://github.com/apache/arrow-datafusion/pull/2549#issuecomment-1145471022
I reviewed the logical plan, SQL parsing, and optimizer changes and LGTM. I
did not review the execution part.
It might make reviews easier for future work like this to
andygrove commented on code in PR #2549:
URL: https://github.com/apache/arrow-datafusion/pull/2549#discussion_r888513961
##
datafusion/expr/src/expr.rs:
##
@@ -99,6 +99,15 @@ pub enum Expr {
/// Right-hand side of the expression
right: Box,
},
+/// A b
andygrove opened a new pull request, #2687:
URL: https://github.com/apache/arrow-datafusion/pull/2687
# Which issue does this PR close?
N/A
# Rationale for this change
The `datafusion` label is redundant now that the repo only contains
DataFusion
# Wh
assignUser commented on PR #13266:
URL: https://github.com/apache/arrow/pull/13266#issuecomment-1145455359
@nealrichardson
[here](https://github.com/assignUser/test-repo-a/runs/6717997492?check_suite_focus=true#step:9)
is a successful run of the (now much simpler) `r_nightly` repo creation
westonpace commented on PR #13150:
URL: https://github.com/apache/arrow/pull/13150#issuecomment-1145455086
> @westonpace should we take the Aggregate out from internal namespace?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
kou commented on PR #13292:
URL: https://github.com/apache/arrow/pull/13292#issuecomment-1145454438
> I've started a discussion for removing `cpp/src/arrow/dbi/hiveserver2/`:
> [C++] Can we remove cpp/src/arrow/dbi/hiveserver2?
https://lists.apache.org/thread/70qv1q9krx7ztk35tzxq8jp11vq5b
kou commented on PR #13292:
URL: https://github.com/apache/arrow/pull/13292#issuecomment-1145453731
> There's some compatibility code lying around (look for
PARQUET_THRIFT_USE_BOOST and FORCE_BOOST_SMART_PTR), we should probably remove
it as well.
Good catch!
I've removed them bec
vibhatha commented on PR #13150:
URL: https://github.com/apache/arrow/pull/13150#issuecomment-1145439126
@westonpace should we take the `Aggregate` out from `internal` namespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
vibhatha commented on PR #13150:
URL: https://github.com/apache/arrow/pull/13150#issuecomment-1145438671
@nealrichardson I think it resolved the CI issue. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kou commented on PR #13292:
URL: https://github.com/apache/arrow/pull/13292#issuecomment-1145437619
I've started a discussion for removing `cpp/src/arrow/dbi/hiveserver2/`:
[C++] Can we remove cpp/src/arrow/dbi/hiveserver2?
https://lists.apache.org/thread/70qv1q9krx7ztk35tzxq8jp11vq5b5zt
kou merged PR #13295:
URL: https://github.com/apache/arrow/pull/13295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou merged PR #13299:
URL: https://github.com/apache/arrow/pull/13299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
ursabot commented on PR #13207:
URL: https://github.com/apache/arrow/pull/13207#issuecomment-1145417215
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/29bb4d905f884364817467d3a55eb0dd...8c595bcdbbdd43f1ad3a5fb9cb23a43d/)
ursabot commented on PR #13207:
URL: https://github.com/apache/arrow/pull/13207#issuecomment-1145417106
Benchmark runs are scheduled for baseline =
2ffc10a43b2b9a397bfeba993993172082f9722b and contender =
bc4a82fd5b65d90e97b773ca728442f369eb9951.
bc4a82fd5b65d90e97b773ca728442f369eb9951 is
ElenaHenderson commented on PR #13305:
URL: https://github.com/apache/arrow/pull/13305#issuecomment-1145416379
@domoritz
Would you be available to review this PR?
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
github-actions[bot] commented on PR #13305:
URL: https://github.com/apache/arrow/pull/13305#issuecomment-114541
https://issues.apache.org/jira/browse/ARROW-16744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
andygrove opened a new pull request, #2686:
URL: https://github.com/apache/arrow-datafusion/pull/2686
# Which issue does this PR close?
N/A
Builds on https://github.com/apache/arrow-datafusion/pull/2682
# Rationale for this change
This is the final par
andygrove merged PR #2685:
URL: https://github.com/apache/arrow-datafusion/pull/2685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove commented on code in PR #2685:
URL: https://github.com/apache/arrow-datafusion/pull/2685#discussion_r888430499
##
dev/release/README.md:
##
@@ -229,6 +210,10 @@ The vote will be open for at least 72 hours.
[ ] +0
[ ] -1 Do not release this as Apache Arrow DataFusion
andygrove closed issue #2679: Proposal: remove automated ballista CI checks
from DataFusion
URL: https://github.com/apache/arrow-datafusion/issues/2679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
andygrove merged PR #2684:
URL: https://github.com/apache/arrow-datafusion/pull/2684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
alamb commented on code in PR #2685:
URL: https://github.com/apache/arrow-datafusion/pull/2685#discussion_r888421826
##
dev/release/README.md:
##
@@ -229,6 +210,10 @@ The vote will be open for at least 72 hours.
[ ] +0
[ ] -1 Do not release this as Apache Arrow DataFusion 5.1.
alamb merged PR #2674:
URL: https://github.com/apache/arrow-datafusion/pull/2674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
alamb closed issue #2673: Optimization pass `AggregateStatistics` changes type
of output from `Int64` to `UInt64`
URL: https://github.com/apache/arrow-datafusion/issues/2673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
iChauster commented on code in PR #13302:
URL: https://github.com/apache/arrow/pull/13302#discussion_r888402428
##
cpp/src/arrow/compute/kernels/scalar_temporal_benchmark.cc:
##
@@ -214,5 +240,19 @@ BENCHMARK_TEMPLATE(BenchmarkStrptime,
non_zoned)->Apply(SetArgs);
BENCHMARK_TE
lidavidm commented on issue #13300:
URL: https://github.com/apache/arrow/issues/13300#issuecomment-1145328381
That happened in a proprietary system and it's been a few years, but yeah -
the basics are as I've described above:
- Flight links a copy of gRPC
- grpcio statically links
codecov-commenter commented on PR #2685:
URL:
https://github.com/apache/arrow-datafusion/pull/2685#issuecomment-1145323079
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2685?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_
ursabot commented on PR #13289:
URL: https://github.com/apache/arrow/pull/13289#issuecomment-1145322259
Benchmark runs are scheduled for baseline =
8295bdc2e86e657c59724c3e56da474e5414cb39 and contender =
2ffc10a43b2b9a397bfeba993993172082f9722b.
2ffc10a43b2b9a397bfeba993993172082f9722b is
westonpace merged PR #13232:
URL: https://github.com/apache/arrow/pull/13232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.ap
github-actions[bot] commented on PR #13304:
URL: https://github.com/apache/arrow/pull/13304#issuecomment-1145309568
:warning: Ticket **has not been started in JIRA**, please click 'Start
Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
github-actions[bot] commented on PR #13304:
URL: https://github.com/apache/arrow/pull/13304#issuecomment-1145309539
https://issues.apache.org/jira/browse/ARROW-16743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
westonpace commented on PR #13304:
URL: https://github.com/apache/arrow/pull/13304#issuecomment-1145309537
For an example of the compiler skipping a side-effect:
https://godbolt.org/z/bMnnEh4Gn
--
This is an automated message from the Apache Git Service.
To respond to the message, please
marsupialtail commented on issue #13300:
URL: https://github.com/apache/arrow/issues/13300#issuecomment-1145306944
I think the Ray people might be interested in hearing about this interplay,
I will link this issue on their side as well.
--
This is an automated message from the Apache Git
marsupialtail closed issue #13300: Best practices to use Arrow Flight Server
URL: https://github.com/apache/arrow/issues/13300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
marsupialtail commented on issue #13300:
URL: https://github.com/apache/arrow/issues/13300#issuecomment-1145306228
Yes. The solution, is to run the Arrow Flight Server in its own process
apart from Ray to avoid this issue.
Once I started doing that I haven't seen it fail yet.
--
T
kou commented on code in PR #13299:
URL: https://github.com/apache/arrow/pull/13299#discussion_r888382083
##
ci/scripts/install_minio.sh:
##
@@ -51,15 +51,21 @@ fi
arch=${archs[$arch]}
platform=${platforms[$platform]}
+# Use specific versions for minio server and client to a
andygrove opened a new pull request, #2685:
URL: https://github.com/apache/arrow-datafusion/pull/2685
# Which issue does this PR close?
N/A
# Rationale for this change
Prep for next release
# What changes are included in this PR?
- Update sc
github-actions[bot] commented on PR #13295:
URL: https://github.com/apache/arrow/pull/13295#issuecomment-1145299654
Revision: a234e0cdf6aa41e51cd98938e89a5d669f82ce70
Submitted crossbow builds: [ursacomputing/crossbow @
actions-9dd1d916af](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #13295:
URL: https://github.com/apache/arrow/pull/13295#issuecomment-1145298678
@github-actions crossbow submit test-fedora-35-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kou commented on code in PR #13295:
URL: https://github.com/apache/arrow/pull/13295#discussion_r888375769
##
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##
@@ -1880,14 +1880,16 @@ if(ARROW_MIMALLOC)
endif()
set(MIMALLOC_PREFIX
"${CMAKE_CURRENT_BINARY_DIR}/mimalloc_ep/s
thinkharderdev commented on issue #2679:
URL:
https://github.com/apache/arrow-datafusion/issues/2679#issuecomment-1145296693
Seems reasonable. It does create a sort of cyclic dependency :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
kou merged PR #13294:
URL: https://github.com/apache/arrow/pull/13294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
ianmcook merged PR #13303:
URL: https://github.com/apache/arrow/pull/13303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apac
alamb commented on code in PR #2680:
URL: https://github.com/apache/arrow-datafusion/pull/2680#discussion_r888365223
##
datafusion/sql/src/utils.rs:
##
@@ -447,24 +447,16 @@ pub(crate) fn make_decimal_type(
precision: Option,
scale: Option,
) -> Result {
-match (p
iamsmkr commented on issue #218:
URL: https://github.com/apache/arrow-cookbook/issues/218#issuecomment-1145280274
@lidavidm Works just fine! Many thanks for your prompt fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
rtpsw commented on code in PR #13232:
URL: https://github.com/apache/arrow/pull/13232#discussion_r888354635
##
cpp/src/arrow/engine/substrait/extension_set.cc:
##
@@ -204,152 +204,259 @@ const int* GetIndex(const KeyToIndex& key_to_index,
const Key& key) {
return &it->second
codecov-commenter commented on PR #2674:
URL:
https://github.com/apache/arrow-datafusion/pull/2674#issuecomment-1145267720
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2674?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_
github-actions[bot] commented on PR #13303:
URL: https://github.com/apache/arrow/pull/13303#issuecomment-1145264540
https://issues.apache.org/jira/browse/ARROW-16742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rtpsw commented on code in PR #13232:
URL: https://github.com/apache/arrow/pull/13232#discussion_r888339714
##
cpp/src/arrow/engine/substrait/extension_set.cc:
##
@@ -204,152 +204,259 @@ const int* GetIndex(const KeyToIndex& key_to_index,
const Key& key) {
return &it->second
andygrove merged PR #2675:
URL: https://github.com/apache/arrow-datafusion/pull/2675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove closed issue #2599: Move logical optimizer rules out of the core
datafusion crate
URL: https://github.com/apache/arrow-datafusion/issues/2599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
alamb commented on issue #2679:
URL:
https://github.com/apache/arrow-datafusion/issues/2679#issuecomment-1145222032
Also @ovr in IOx, we have found that by using the extension mechanisms in
DataFusion (user defined Exprs, User Defined Plan Nodes, etc) we have been able
to add IOx specific
lidavidm commented on issue #13300:
URL: https://github.com/apache/arrow/issues/13300#issuecomment-1145221562
So even if you make sure they are the same version, you can still run into
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
lidavidm commented on issue #13300:
URL: https://github.com/apache/arrow/issues/13300#issuecomment-1145221383
I suppose it's actually backwards. Flight uses gRPC, but:
`import pyarrow.flight` -> loads `libarrow_flight.so` -> loads
`libgrpc++.so` -> loads `libgrpc.so`
but `import gr
westonpace commented on code in PR #13232:
URL: https://github.com/apache/arrow/pull/13232#discussion_r888299274
##
cpp/src/arrow/engine/substrait/extension_set.h:
##
@@ -103,6 +106,19 @@ constexpr util::string_view kArrowExtTypesUri =
/// Note: Function support is currently ve
assignUser commented on code in PR #13266:
URL: https://github.com/apache/arrow/pull/13266#discussion_r888298697
##
dev/tasks/tasks.yml:
##
@@ -931,15 +931,15 @@ tasks:
ci: github
template: r/github.packages.yml
artifacts:
- - r-libarrow-windows-arrow-[0-9\.]
marsupialtail commented on issue #13300:
URL: https://github.com/apache/arrow/issues/13300#issuecomment-1145219665
Yeah I guess both Ray and Flight use gRPC and I should try to make sure they
are the same version...
What do you mean by there is a gRPC "embedded into Flight"?
--
This is
alamb commented on code in PR #2674:
URL: https://github.com/apache/arrow-datafusion/pull/2674#discussion_r888298254
##
datafusion/core/src/physical_optimizer/aggregate_statistics.rs:
##
@@ -291,65 +296,132 @@ mod tests {
}
/// Checks that the count optimization was
westonpace commented on code in PR #13232:
URL: https://github.com/apache/arrow/pull/13232#discussion_r888298157
##
cpp/src/arrow/engine/substrait/extension_set.cc:
##
@@ -204,152 +204,259 @@ const int* GetIndex(const KeyToIndex& key_to_index,
const Key& key) {
return &it->s
westonpace commented on code in PR #13232:
URL: https://github.com/apache/arrow/pull/13232#discussion_r888297879
##
cpp/src/arrow/engine/substrait/extension_set.cc:
##
@@ -204,152 +204,259 @@ const int* GetIndex(const KeyToIndex& key_to_index,
const Key& key) {
return &it->s
1 - 100 of 328 matches
Mail list logo
