alexandreyc commented on code in PR #13370:
URL: https://github.com/apache/arrow/pull/13370#discussion_r895099393
##
cpp/examples/arrow/row_wise_conversion_example.cc:
##
@@ -97,7 +97,7 @@ arrow::Result>
VectorToColumnarTable(
ARROW_RETURN_NOT_OK(id_builder.Finish(&id_array)
vibhatha commented on PR #13344:
URL: https://github.com/apache/arrow/pull/13344#issuecomment-1153054825
cc @nealrichardson made some changes to R library, appreciate your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
vibhatha commented on code in PR #13370:
URL: https://github.com/apache/arrow/pull/13370#discussion_r895087790
##
cpp/examples/arrow/row_wise_conversion_example.cc:
##
@@ -97,7 +97,7 @@ arrow::Result>
VectorToColumnarTable(
ARROW_RETURN_NOT_OK(id_builder.Finish(&id_array));
vibhatha commented on PR #13344:
URL: https://github.com/apache/arrow/pull/13344#issuecomment-1153044022
@kou need help with the C GLib changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
vibhatha commented on PR #13150:
URL: https://github.com/apache/arrow/pull/13150#issuecomment-1153038879
@westonpace s3 test case is failing. I assume it’s flaky? Saw it frequently
in recent CIs.
@nealrichardson still get the issue in one CI.
```
Error: Error: Not lint fre
emkornfield commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1153021230
These seem unrelated to this PR? If so I can open up JIRA to track
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
wesm commented on PR #13364:
URL: https://github.com/apache/arrow/pull/13364#issuecomment-1153019310
I'm working on some incidental cleanups that I ran into fixing the Python
UDF code paths. I'll push the closer-to-CI-green branch with the changes (e.g.
removing `VisitArrayDataInline`) some
github-actions[bot] commented on PR #13371:
URL: https://github.com/apache/arrow/pull/13371#issuecomment-1153005039
Revision: bf8d7321230b995495096e175a18e45b0a332832
Submitted crossbow builds: [ursacomputing/crossbow @
actions-ab7820d7cd](https://github.com/ursacomputing/crossbow/bra
kou opened a new pull request, #13371:
URL: https://github.com/apache/arrow/pull/13371
This is a follow-up of ARROW-16745/#13307.
If we use 3 or more jobs to build RPM, memory on Travis CI is
exhausted. It causes the "No output has been received in the last
10m0s, this potentiall
github-actions[bot] commented on PR #13371:
URL: https://github.com/apache/arrow/pull/13371#issuecomment-1153004692
https://issues.apache.org/jira/browse/ARROW-16815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-actions[bot] commented on PR #13371:
URL: https://github.com/apache/arrow/pull/13371#issuecomment-1153004696
:warning: Ticket **has not been started in JIRA**, please click 'Start
Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
kou commented on PR #13371:
URL: https://github.com/apache/arrow/pull/13371#issuecomment-1153004915
@github-actions crossbow submit almalinux-* centos-* amazon-linux-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
kou commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1153002196
We need to fix `wheel-*-cp37-*` failures such as
`wheel-manylinux2014-cp37-amd64`:
https://github.com/ursacomputing/crossbow/runs/6842267198?check_suite_focus=true
```text
==
github-actions[bot] commented on PR #13244:
URL: https://github.com/apache/arrow/pull/13244#issuecomment-1153001622
Revision: df43a5dd2962edad5be5c16c0769980ee5649149
Submitted crossbow builds: [ursacomputing/crossbow @
actions-f3484325d2](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #13244:
URL: https://github.com/apache/arrow/pull/13244#issuecomment-1153001495
@github-actions crossbow submit wheel-windows-cp38-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895067365
##
cpp/src/arrow/util/bitmap.h:
##
@@ -53,27 +53,36 @@ class ARROW_EXPORT Bitmap : public
util::ToStringOstreamable,
Bitmap() = default;
- Bitmap(std::shared_ptr b
wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895067323
##
cpp/src/arrow/scalar.h:
##
@@ -129,6 +135,9 @@ namespace internal {
struct ARROW_EXPORT PrimitiveScalarBase : public Scalar {
using Scalar::Scalar;
+ /// \brief G
wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895067171
##
cpp/src/arrow/array/data.cc:
##
@@ -128,6 +131,143 @@ int64_t ArrayData::GetNullCount() const {
return precomputed;
}
+// -
wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895066967
##
cpp/src/arrow/compute/kernels/codegen_internal.h:
##
@@ -397,14 +400,198 @@ struct BoxScalar {
static void Box(T val, Scalar* out) { checked_cast(out)->value
= val;
wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895066814
##
cpp/src/arrow/type.h:
##
@@ -126,7 +126,8 @@ struct ARROW_EXPORT DataTypeLayout {
///
/// Simple datatypes may be entirely described by their Type::type id, but
/// c
wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895066801
##
cpp/src/arrow/util/bit_block_counter.h:
##
@@ -490,26 +493,34 @@ static void VisitBitBlocksVoid(const
std::shared_ptr& bitmap_buf, int64_
}
template
-static Status
kou merged PR #13360:
URL: https://github.com/apache/arrow/pull/13360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou merged PR #13346:
URL: https://github.com/apache/arrow/pull/13346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895059737
##
cpp/src/arrow/util/bitmap.h:
##
@@ -53,27 +53,36 @@ class ARROW_EXPORT Bitmap : public
util::ToStringOstreamable,
Bitmap() = default;
- Bitmap(std::shared_ptr b
wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895059600
##
cpp/src/arrow/array/data.h:
##
@@ -242,6 +245,127 @@ struct ARROW_EXPORT ArrayData {
std::shared_ptr dictionary;
};
+/// \brief A non-owning Buffer reference
+stru
tustvold merged PR #1827:
URL: https://github.com/apache/arrow-rs/pull/1827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apa
emkornfield commented on code in PR #12775:
URL: https://github.com/apache/arrow/pull/12775#discussion_r895048272
##
cpp/examples/arrow/rapidjson_row_converter.cc:
##
@@ -0,0 +1,590 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
emkornfield commented on code in PR #12775:
URL: https://github.com/apache/arrow/pull/12775#discussion_r895048076
##
cpp/examples/arrow/rapidjson_row_converter.cc:
##
@@ -0,0 +1,590 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
emkornfield commented on code in PR #12775:
URL: https://github.com/apache/arrow/pull/12775#discussion_r895047946
##
c_glib/arrow-glib/table-builder.cpp:
##
@@ -155,11 +155,10 @@ garrow_record_batch_builder_new(GArrowSchema *schema,
GError **error)
{
auto arrow_schema = gar
viirya commented on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1152960201
As we enable almost all test cases except for `generate_decimal256_case`
which we have an issue #131 tracking it, maybe we can close this.
cc @alamb
--
This is an automated
viirya commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1152960117
Thank you @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tustvold opened a new issue, #1851:
URL: https://github.com/apache/arrow-rs/issues/1851
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
A while back I implemented an optimized string dictionary builder for
[IOx](https://github
codecov-commenter commented on PR #2722:
URL:
https://github.com/apache/arrow-datafusion/pull/2722#issuecomment-1152953789
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2722?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_
tustvold opened a new issue, #1850:
URL: https://github.com/apache/arrow-rs/issues/1850
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
`BufferBuilder` is effectively a `Vec` that can be
converted to `Buffer` without needing t
andygrove merged PR #2688:
URL: https://github.com/apache/arrow-datafusion/pull/2688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
tustvold opened a new issue, #1849:
URL: https://github.com/apache/arrow-rs/issues/1849
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
The existence of the custom `ScalarBuffer` in the parquet crate is primarily
because I was
andygrove opened a new pull request, #2722:
URL: https://github.com/apache/arrow-datafusion/pull/2722
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/2720
# Rationale for this change
Query engines such as Ballista re
codecov-commenter commented on PR #2716:
URL:
https://github.com/apache/arrow-datafusion/pull/2716#issuecomment-1152921401
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2716?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_
alamb commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1152896737
Thanks again @viirya -- this is a major step forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb merged PR #13219:
URL: https://github.com/apache/arrow/pull/13219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.
alamb commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1152896191
Following the process in https://github.com/apache/arrow/tree/master/dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
alamb commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1152895907
Looking into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
alamb commented on issue #1808:
URL: https://github.com/apache/arrow-rs/issues/1808#issuecomment-1152895665
Here is a draft blog post about arrow/parquet :
https://github.com/apache/arrow-site/pull/220
--
This is an automated message from the Apache Git Service.
To respond to the message,
codecov-commenter commented on PR #1839:
URL: https://github.com/apache/arrow-rs/pull/1839#issuecomment-1152890889
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S
codecov-commenter commented on PR #2713:
URL:
https://github.com/apache/arrow-datafusion/pull/2713#issuecomment-1152890726
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2713?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_
github-actions[bot] commented on PR #13370:
URL: https://github.com/apache/arrow/pull/13370#issuecomment-1152889681
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue
nl5887 commented on code in PR #1839:
URL: https://github.com/apache/arrow-rs/pull/1839#discussion_r895000936
##
arrow/src/compute/kernels/concat.rs:
##
@@ -62,7 +62,7 @@ pub fn concat(arrays: &[&dyn Array]) -> Result {
if arrays
.iter()
-.any(|array| arr
waynexia commented on code in PR #2713:
URL: https://github.com/apache/arrow-datafusion/pull/2713#discussion_r895000577
##
datafusion/core/src/physical_plan/planner.rs:
##
@@ -292,10 +293,10 @@ pub trait ExtensionPlanner {
/// Returns `None` when the planner does not know h
tustvold closed issue #1800: Speed up `substring_by_char`
URL: https://github.com/apache/arrow-rs/issues/1800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
tustvold merged PR #1832:
URL: https://github.com/apache/arrow-rs/pull/1832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apa
HaoYang670 commented on code in PR #1832:
URL: https://github.com/apache/arrow-rs/pull/1832#discussion_r894998113
##
arrow/src/compute/kernels/substring.rs:
##
@@ -182,24 +182,66 @@ pub fn substring_by_char(
start: i64,
length: Option,
) -> Result> {
-Ok(array
-
github-actions[bot] commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152884668
Revision: 0f1f1dad068e77279bfa0da99ff264541626aa5b
Submitted crossbow builds: [ursacomputing/crossbow @
actions-8c3920b06e](https://github.com/ursacomputing/crossbow/bra
pitrou commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152884521
@github-actions crossbow submit -g nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
github-actions[bot] commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152883979
Revision: 0f1f1dad068e77279bfa0da99ff264541626aa5b
Submitted crossbow builds: [ursacomputing/crossbow @
actions-041204a60b](https://github.com/ursacomputing/crossbow/bra
pitrou commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152883861
@github-actions crossbow submit wheel-macos-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
pitrou commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152883604
Ok, the situation on our macOS wheel builds is a bit horrible, but it's
pointless to try to improve it here, so I'll revert the last two commits.
--
This is an automated message from the
github-actions[bot] commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152882423
Revision: 922e4ef23400b7c7f1940ff1d2b06146e4ac4909
Submitted crossbow builds: [ursacomputing/crossbow @
actions-2176483478](https://github.com/ursacomputing/crossbow/bra
pitrou commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152882303
@github-actions crossbow submit wheel-macos-big-sur*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
HaoYang670 commented on code in PR #1832:
URL: https://github.com/apache/arrow-rs/pull/1832#discussion_r894995613
##
arrow/src/compute/kernels/substring.rs:
##
@@ -182,24 +182,66 @@ pub fn substring_by_char(
start: i64,
length: Option,
) -> Result> {
-Ok(array
-
pitrou commented on code in PR #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r894995481
##
dev/tasks/python-wheels/github.osx.arm64.yml:
##
@@ -134,6 +134,8 @@ jobs:
$PYTHON -m venv test-arm64-env
source test-arm64-env/bin/activate
github-actions[bot] commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152881327
Revision: 5726837c8cd62ea9f27ec802807297aa37c791d2
Submitted crossbow builds: [ursacomputing/crossbow @
actions-69a77093c0](https://github.com/ursacomputing/crossbow/bra
pitrou commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152881241
@github-actions crossbow submit wheel-macos-big-sur*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152881168
```
Unable to match any tasks for `wheel-macos-bigsur*`
The Archery job run can be found at:
https://github.com/apache/arrow/actions/runs/2479330931
```
--
This is
pitrou commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152881054
@github-actions crossbow submit wheel-macos-bigsur*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
tustvold commented on code in PR #1832:
URL: https://github.com/apache/arrow-rs/pull/1832#discussion_r894994725
##
arrow/src/compute/kernels/substring.rs:
##
@@ -182,24 +182,66 @@ pub fn substring_by_char(
start: i64,
length: Option,
) -> Result> {
-Ok(array
-
tustvold commented on code in PR #1832:
URL: https://github.com/apache/arrow-rs/pull/1832#discussion_r894994725
##
arrow/src/compute/kernels/substring.rs:
##
@@ -182,24 +182,66 @@ pub fn substring_by_char(
start: i64,
length: Option,
) -> Result> {
-Ok(array
-
pitrou commented on PR #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1152878185
No, the macOS s3fs failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
HaoYang670 commented on code in PR #1832:
URL: https://github.com/apache/arrow-rs/pull/1832#discussion_r894990187
##
arrow/src/compute/kernels/substring.rs:
##
@@ -182,24 +182,66 @@ pub fn substring_by_char(
start: i64,
length: Option,
) -> Result> {
-Ok(array
-
tustvold closed issue #1835: Add `quarter` support in `temporal`
URL: https://github.com/apache/arrow-rs/issues/1835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
tustvold merged PR #1836:
URL: https://github.com/apache/arrow-rs/pull/1836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apa
tustvold commented on code in PR #1832:
URL: https://github.com/apache/arrow-rs/pull/1832#discussion_r894988645
##
arrow/src/compute/kernels/substring.rs:
##
@@ -182,24 +182,66 @@ pub fn substring_by_char(
start: i64,
length: Option,
) -> Result> {
-Ok(array
-
AssHero commented on PR #2721:
URL:
https://github.com/apache/arrow-datafusion/pull/2721#issuecomment-1152872254
Hi @alamb , as discussed before, more common used data types, such as
Date32/Date64/Decimal/Dictionary(integer/unsigned integer, Utf8) are supported
in hash join.
--
This
AssHero opened a new pull request, #2721:
URL: https://github.com/apache/arrow-datafusion/pull/2721
# Which issue does this PR close?
Closes #2145
# Rationale for this change
More data types are supported in hash join. such as
Date32、Date64、Decimal、Dictionary(_, Utf8)
viirya commented on code in PR #1839:
URL: https://github.com/apache/arrow-rs/pull/1839#discussion_r894987393
##
arrow/src/compute/kernels/concat.rs:
##
@@ -62,7 +62,7 @@ pub fn concat(arrays: &[&dyn Array]) -> Result {
if arrays
.iter()
-.any(|array| arr
74 matches
Mail list logo
