[GitHub] [arrow-rs] viirya commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder

2022-06-13 Thread GitBox
viirya commented on code in PR #1871: URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r896426518 ## arrow/src/util/decimal.rs: ## @@ -0,0 +1,148 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NO

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder

2022-06-13 Thread GitBox
viirya commented on code in PR #1871: URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r896426518 ## arrow/src/util/decimal.rs: ## @@ -0,0 +1,148 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NO

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder

2022-06-13 Thread GitBox
codecov-commenter commented on PR #1871: URL: https://github.com/apache/arrow-rs/pull/1871#issuecomment-1154757340 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [arrow-datafusion] mingmwang commented on issue #1972: DataFusion Optimizer framework discussion

2022-06-13 Thread GitBox
mingmwang commented on issue #1972: URL: https://github.com/apache/arrow-datafusion/issues/1972#issuecomment-1154749123 Nice discussion! I see many people raised the points to build the volcano/cascades style planner for DataFusion, either on Egg or to build from scratch. To implemen

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder

2022-06-13 Thread GitBox
viirya commented on code in PR #1871: URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r896400715 ## arrow/src/util/decimal.rs: ## @@ -0,0 +1,148 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NO

[GitHub] [arrow] wjones127 commented on a diff in pull request #12775: ARROW-16006: [C++] Row conversion helpers and example

2022-06-13 Thread GitBox
wjones127 commented on code in PR #12775: URL: https://github.com/apache/arrow/pull/12775#discussion_r896399905 ## cpp/examples/arrow/rapidjson_row_converter.cc: ## @@ -0,0 +1,590 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

[GitHub] [arrow-rs] viirya opened a new pull request, #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder

2022-06-13 Thread GitBox
viirya opened a new pull request, #1871: URL: https://github.com/apache/arrow-rs/pull/1871 # Which issue does this PR close? Closes #1870. # Rationale for this change # What changes are included in this PR? # Are there any user-facing chan

[GitHub] [arrow-rs] viirya opened a new issue, #1870: Add Decimal128 API and use it in DecimalArray and DecimalBuilder

2022-06-13 Thread GitBox
viirya opened a new issue, #1870: URL: https://github.com/apache/arrow-rs/issues/1870 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Part of #131. Currently we directly use i128 in decimal related APIs, for example Dec

[GitHub] [arrow] github-actions[bot] commented on pull request #13371: ARROW-16815: [Packaging][RPM] Don't use too many parallel jobs

2022-06-13 Thread GitBox
github-actions[bot] commented on PR #13371: URL: https://github.com/apache/arrow/pull/13371#issuecomment-1154726650 Revision: d5aa1d781334242606f564e266e8de0c6029eaa9 Submitted crossbow builds: [ursacomputing/crossbow @ actions-86055eb4d2](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] kou commented on pull request #13371: ARROW-16815: [Packaging][RPM] Don't use too many parallel jobs

2022-06-13 Thread GitBox
kou commented on PR #13371: URL: https://github.com/apache/arrow/pull/13371#issuecomment-1154725762 @github-actions crossbow submit almalinux-* centos-* amazon-linux-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow-ballista] dependabot[bot] commented on pull request #70: Update arrow requirement from 15.0.0 to 16.0.0

2022-06-13 Thread GitBox
dependabot[bot] commented on PR #70: URL: https://github.com/apache/arrow-ballista/pull/70#issuecomment-1154711395 The following labels could not be found: `auto-dependencies`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow-ballista] dependabot[bot] opened a new pull request, #70: Update arrow requirement from 15.0.0 to 16.0.0

2022-06-13 Thread GitBox
dependabot[bot] opened a new pull request, #70: URL: https://github.com/apache/arrow-ballista/pull/70 Updates the requirements on [arrow](https://github.com/apache/arrow-rs) to permit the latest version. Changelog Sourced from https://github.com/apache/arrow-rs/blob/master/CHANGELO

[GitHub] [arrow-ballista] dependabot[bot] commented on pull request #69: Update arrow-flight requirement from 15.0.0 to 16.0.0

2022-06-13 Thread GitBox
dependabot[bot] commented on PR #69: URL: https://github.com/apache/arrow-ballista/pull/69#issuecomment-1154710733 The following labels could not be found: `auto-dependencies`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow-ballista] dependabot[bot] opened a new pull request, #69: Update arrow-flight requirement from 15.0.0 to 16.0.0

2022-06-13 Thread GitBox
dependabot[bot] opened a new pull request, #69: URL: https://github.com/apache/arrow-ballista/pull/69 Updates the requirements on [arrow-flight](https://github.com/apache/arrow-rs) to permit the latest version. Changelog Sourced from https://github.com/apache/arrow-rs/blob/master/C

[GitHub] [arrow] eerhardt merged pull request #13279: ARROW-16660: [C#] Add support for Time32Array and Time64Array

2022-06-13 Thread GitBox
eerhardt merged PR #13279: URL: https://github.com/apache/arrow/pull/13279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

[GitHub] [arrow-datafusion] andygrove closed pull request #2728: Deprecate `datafusion::logical_plan` module

2022-06-13 Thread GitBox
andygrove closed pull request #2728: Deprecate `datafusion::logical_plan` module URL: https://github.com/apache/arrow-datafusion/pull/2728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-ballista] andygrove commented on pull request #66: Update to datafusion 9.0.0

2022-06-13 Thread GitBox
andygrove commented on PR #66: URL: https://github.com/apache/arrow-ballista/pull/66#issuecomment-1154662650 Unfortunately we cannot use DF 9.0.0 due to a breaking API change. I created https://github.com/apache/arrow-ballista/pull/68 to upgrade to the latest version which has the fix the t

[GitHub] [arrow-ballista] andygrove opened a new pull request, #68: Use latest DataFusion

2022-06-13 Thread GitBox
andygrove opened a new pull request, #68: URL: https://github.com/apache/arrow-ballista/pull/68 # Which issue does this PR close? N/A # Rationale for this change Stay up to date # What changes are included in this PR? Bump DF version

[GitHub] [arrow] github-actions[bot] commented on pull request #13218: ARROW-16590: [C++] Consolidate files dealing with row-major storage

2022-06-13 Thread GitBox
github-actions[bot] commented on PR #13218: URL: https://github.com/apache/arrow/pull/13218#issuecomment-1154658694 https://issues.apache.org/jira/browse/ARROW-16590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] wesm merged pull request #13218: ARROW-16590: [C++] Consolidate files dealing with row-major storage

2022-06-13 Thread GitBox
wesm merged PR #13218: URL: https://github.com/apache/arrow/pull/13218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.o

[GitHub] [arrow-datafusion] AssHero commented on pull request #2721: more data types are supported in hash join

2022-06-13 Thread GitBox
AssHero commented on PR #2721: URL: https://github.com/apache/arrow-datafusion/pull/2721#issuecomment-1154648956 > Please let me know if I can provide some info you need🧐 Do you have any ideas about the test failure? I can not reproduce that case. -- This is an automated message fr

[GitHub] [arrow-ballista] yahoNanJing commented on pull request #59: Support for multi-scheduler deployments

2022-06-13 Thread GitBox
yahoNanJing commented on PR #59: URL: https://github.com/apache/arrow-ballista/pull/59#issuecomment-1154642089 Hi @thinkharderdev, just left a few comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] rishabh-rana commented on pull request #13279: ARROW-16660: [C#] Add support for Time32Array and Time64Array

2022-06-13 Thread GitBox
rishabh-rana commented on PR #13279: URL: https://github.com/apache/arrow/pull/13279#issuecomment-1154641991 @eerhardt Thank you for your review! All good to merge now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow-datafusion] Ted-Jiang commented on pull request #2726: [Minor] add debug info in optimizer.rs

2022-06-13 Thread GitBox
Ted-Jiang commented on PR #2726: URL: https://github.com/apache/arrow-datafusion/pull/2726#issuecomment-1154638607 > Thanks @Ted-Jiang > > You probably know it, but you can also use `EXPLAIN VERBOSE` to see the output of the plans after each pass > > For example: > > ``

[GitHub] [arrow-datafusion] Ted-Jiang commented on issue #2725: Filter push down need consider alias columns

2022-06-13 Thread GitBox
Ted-Jiang commented on issue #2725: URL: https://github.com/apache/arrow-datafusion/issues/2725#issuecomment-1154631256 > If I read your conclusion corrctly, I think you are saying that the filter added by the filter pushdown rule is remapping the names somehow. Specifically, you are propo

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #2728: Deprecate `datafusion::logical_plan` module

2022-06-13 Thread GitBox
codecov-commenter commented on PR #2728: URL: https://github.com/apache/arrow-datafusion/pull/2728#issuecomment-1154630207 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2728?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow] avertleyb commented on a diff in pull request #13376: ARROW-16778: [C++] Fix build/unit test issues in msvc/win32

2022-06-13 Thread GitBox
avertleyb commented on code in PR #13376: URL: https://github.com/apache/arrow/pull/13376#discussion_r896300314 ## cpp/src/arrow/util/bit_util.h: ## @@ -67,7 +67,14 @@ static constexpr uint8_t kBytePopcount[] = { 5, 4, 5, 5, 6, 3, 4, 4, 5, 4, 5, 5, 6, 4, 5, 5, 6, 5, 6, 6, 7

[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2728: Deprecate `datafusion::logical_plan` module

2022-06-13 Thread GitBox
andygrove opened a new pull request, #2728: URL: https://github.com/apache/arrow-datafusion/pull/2728 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing change

[GitHub] [arrow] kou merged pull request #13374: ARROW-16623: [GLib] Add GArrowQuantileOptions

2022-06-13 Thread GitBox
kou merged PR #13374: URL: https://github.com/apache/arrow/pull/13374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow] kou commented on pull request #13374: ARROW-16623: [GLib] Add GArrowQuantileOptions

2022-06-13 Thread GitBox
kou commented on PR #13374: URL: https://github.com/apache/arrow/pull/13374#issuecomment-1154584199 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [arrow-datafusion] kou commented on issue #1114: Ruby bindings

2022-06-13 Thread GitBox
kou commented on issue #1114: URL: https://github.com/apache/arrow-datafusion/issues/1114#issuecomment-1154572691 @andygrove Could you create https://github.com/datafusion-contrib/datafusion-ruby and give me admin permission? We can implement Ruby bindings based on https://github.com/data

[GitHub] [arrow-ballista] andygrove commented on pull request #67: Feature return task error on panic

2022-06-13 Thread GitBox
andygrove commented on PR #67: URL: https://github.com/apache/arrow-ballista/pull/67#issuecomment-1154569407 @nl5887 Do you have examples of panics that this fixes? Can we fix the root cause by using `Result` instead of calling `panic!` or `unimplemented!`? -- This is an automated message

[GitHub] [arrow] github-actions[bot] commented on pull request #13371: ARROW-16815: [Packaging][RPM] Don't use too many parallel jobs

2022-06-13 Thread GitBox
github-actions[bot] commented on PR #13371: URL: https://github.com/apache/arrow/pull/13371#issuecomment-1154569182 Revision: e2dedd560fec0e74100fd33aa4bbc387ae12048b Submitted crossbow builds: [ursacomputing/crossbow @ actions-2595c22265](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] kou commented on pull request #13371: ARROW-16815: [Packaging][RPM] Don't use too many parallel jobs

2022-06-13 Thread GitBox
kou commented on PR #13371: URL: https://github.com/apache/arrow/pull/13371#issuecomment-1154568558 @github-actions crossbow submit almalinux-* centos-* amazon-linux-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow-datafusion] andygrove merged pull request #2715: fix: check redundant fields while building projection plan

2022-06-13 Thread GitBox
andygrove merged PR #2715: URL: https://github.com/apache/arrow-datafusion/pull/2715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow-datafusion] andygrove closed issue #2712: Common Subexpression Eliminiation pass errors if run twice on some plans: Schema contains duplicate unqualified field name 'IsNull-Column-sys.

2022-06-13 Thread GitBox
andygrove closed issue #2712: Common Subexpression Eliminiation pass errors if run twice on some plans: Schema contains duplicate unqualified field name 'IsNull-Column-sys.host' URL: https://github.com/apache/arrow-datafusion/issues/2712 -- This is an automated message from the Apache Git Se

[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2727: MINOR: Fix release order

2022-06-13 Thread GitBox
andygrove opened a new pull request, #2727: URL: https://github.com/apache/arrow-datafusion/pull/2727 # Which issue does this PR close? N/A # Rationale for this change The instructions for releasing the crates was incorrect # What changes are included

[GitHub] [arrow-rs] nevi-me commented on issue #1858: Huge amount of llvm code generated by comparison kernels, potentially slowing compile times

2022-06-13 Thread GitBox
nevi-me commented on issue #1858: URL: https://github.com/apache/arrow-rs/issues/1858#issuecomment-1154517263 Comparison from the last time this work was done https://github.com/apache/arrow-rs/pull/715#issuecomment-917619317 -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow-rs] viirya commented on pull request #1848: Add PyArrow integration test for C Stream Interface

2022-06-13 Thread GitBox
viirya commented on PR #1848: URL: https://github.com/apache/arrow-rs/pull/1848#issuecomment-1154506626 Thanks @sunchao ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [arrow-rs] viirya closed issue #1847: PyArrow intergation test for C Stream Interface

2022-06-13 Thread GitBox
viirya closed issue #1847: PyArrow intergation test for C Stream Interface URL: https://github.com/apache/arrow-rs/issues/1847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [arrow-rs] viirya merged pull request #1848: Add PyArrow integration test for C Stream Interface

2022-06-13 Thread GitBox
viirya merged PR #1848: URL: https://github.com/apache/arrow-rs/pull/1848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apach

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1865: Expose BitSliceIterator and BitIndexIterator (#1864)

2022-06-13 Thread GitBox
codecov-commenter commented on PR #1865: URL: https://github.com/apache/arrow-rs/pull/1865#issuecomment-1154480873 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1865?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1866: Mark typed buffer APIs safe (#996) (#1027)

2022-06-13 Thread GitBox
codecov-commenter commented on PR #1866: URL: https://github.com/apache/arrow-rs/pull/1866#issuecomment-1154477386 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1866?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [arrow-rs] tustvold merged pull request #1869: Update vendored gRPC

2022-06-13 Thread GitBox
tustvold merged PR #1869: URL: https://github.com/apache/arrow-rs/pull/1869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[GitHub] [arrow] kou commented on a diff in pull request #13376: ARROW-16778: [C++] Fix build/unit test issues in msvc/win32

2022-06-13 Thread GitBox
kou commented on code in PR #13376: URL: https://github.com/apache/arrow/pull/13376#discussion_r896152027 ## cpp/src/arrow/util/bit_util.h: ## @@ -67,7 +67,14 @@ static constexpr uint8_t kBytePopcount[] = { 5, 4, 5, 5, 6, 3, 4, 4, 5, 4, 5, 5, 6, 4, 5, 5, 6, 5, 6, 6, 7, 3, 4

[GitHub] [arrow-rs] tustvold closed issue #1862: Exclude some long-running tests from miri

2022-06-13 Thread GitBox
tustvold closed issue #1862: Exclude some long-running tests from miri URL: https://github.com/apache/arrow-rs/issues/1862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [arrow-rs] tustvold merged pull request #1863: Exclude some long-running tests when running under miri

2022-06-13 Thread GitBox
tustvold merged PR #1863: URL: https://github.com/apache/arrow-rs/pull/1863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[GitHub] [arrow] rtpsw commented on a diff in pull request #13375: ARROW-16823: [C++] Arrow Substrait enhancements for UDF

2022-06-13 Thread GitBox
rtpsw commented on code in PR #13375: URL: https://github.com/apache/arrow/pull/13375#discussion_r896138388 ## cpp/src/arrow/engine/substrait/serde.cc: ## @@ -58,12 +58,53 @@ Result DeserializeRelation(const Buffer& buf, return FromProto(rel, ext_set); } -Result> Deserial

[GitHub] [arrow-rs] jhorstmann commented on a diff in pull request #1866: Mark typed buffer APIs safe (#996) (#1027)

2022-06-13 Thread GitBox
jhorstmann commented on code in PR #1866: URL: https://github.com/apache/arrow-rs/pull/1866#discussion_r896126605 ## arrow/src/buffer/immutable.rs: ## @@ -181,19 +181,14 @@ impl Buffer { /// View buffer as typed slice. /// -/// # Safety +/// # Panics ///

[GitHub] [arrow] kou commented on pull request #13244: ARROW-12626: [C++] Support toolchain xsimd, update toolchain version to version 8.1.0

2022-06-13 Thread GitBox
kou commented on PR #13244: URL: https://github.com/apache/arrow/pull/13244#issuecomment-1154423528 `docker build` didn't use pulled images as cache as @kszucs said. I added the following workflow as a workaround (see the description of this pull request for details, I've updated):

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1866: Mark typed buffer APIs safe (#996) (#1027)

2022-06-13 Thread GitBox
tustvold commented on code in PR #1866: URL: https://github.com/apache/arrow-rs/pull/1866#discussion_r896113066 ## arrow/src/buffer/immutable.rs: ## @@ -181,19 +181,14 @@ impl Buffer { /// View buffer as typed slice. /// -/// # Safety +/// # Panics /// -

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1866: Mark typed buffer APIs safe (#996) (#1027)

2022-06-13 Thread GitBox
tustvold commented on code in PR #1866: URL: https://github.com/apache/arrow-rs/pull/1866#discussion_r896113066 ## arrow/src/buffer/immutable.rs: ## @@ -181,19 +181,14 @@ impl Buffer { /// View buffer as typed slice. /// -/// # Safety +/// # Panics /// -

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1866: Mark typed buffer APIs safe (#996) (#1027)

2022-06-13 Thread GitBox
tustvold commented on code in PR #1866: URL: https://github.com/apache/arrow-rs/pull/1866#discussion_r896113066 ## arrow/src/buffer/immutable.rs: ## @@ -181,19 +181,14 @@ impl Buffer { /// View buffer as typed slice. /// -/// # Safety +/// # Panics /// -

[GitHub] [arrow] iChauster commented on a diff in pull request #13028: ARROW-16083: [C++] Implement AsofJoin execution node

2022-06-13 Thread GitBox
iChauster commented on code in PR #13028: URL: https://github.com/apache/arrow/pull/13028#discussion_r896110522 ## cpp/src/arrow/compute/exec/asof_join_node.cc: ## @@ -0,0 +1,806 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

[GitHub] [arrow] github-actions[bot] commented on pull request #13376: ARROW-16778: [cpp] Fixing build/unit test issues in msvc/win32 (ARROW-16778)

2022-06-13 Thread GitBox
github-actions[bot] commented on PR #13376: URL: https://github.com/apache/arrow/pull/13376#issuecomment-1154394087 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] github-actions[bot] commented on pull request #13376: ARROW-16778: [cpp] Fixing build/unit test issues in msvc/win32 (ARROW-16778)

2022-06-13 Thread GitBox
github-actions[bot] commented on PR #13376: URL: https://github.com/apache/arrow/pull/13376#issuecomment-1154394062 https://issues.apache.org/jira/browse/ARROW-16778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow-rs] alamb commented on a diff in pull request #1866: Mark typed buffer APIs safe (#996) (#1027)

2022-06-13 Thread GitBox
alamb commented on code in PR #1866: URL: https://github.com/apache/arrow-rs/pull/1866#discussion_r896100716 ## arrow/src/buffer/immutable.rs: ## @@ -181,19 +181,14 @@ impl Buffer { /// View buffer as typed slice. /// -/// # Safety +/// # Panics /// -

[GitHub] [arrow-datafusion] alamb commented on issue #1327: implement grouping sets, cubes, and rollups

2022-06-13 Thread GitBox
alamb commented on issue #1327: URL: https://github.com/apache/arrow-datafusion/issues/1327#issuecomment-1154387746 FYI @thinkharderdev bashed this out in https://github.com/apache/arrow-datafusion/pull/2716 πŸ₯‡ -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [arrow-datafusion] alamb commented on issue #2725: Filter push down need consider alias columns

2022-06-13 Thread GitBox
alamb commented on issue #2725: URL: https://github.com/apache/arrow-datafusion/issues/2725#issuecomment-1154384486 Hi @Ted-Jiang If I read your conclusion corrctly, I think you are saying that the filter added by the filter pushdown rule is remapping the names somehow. Specifically

[GitHub] [arrow-rs] MazterQyou commented on a diff in pull request #1846: Add `nilike` support in `comparison`

2022-06-13 Thread GitBox
MazterQyou commented on code in PR #1846: URL: https://github.com/apache/arrow-rs/pull/1846#discussion_r896095995 ## arrow/src/compute/kernels/comparison.rs: ## @@ -548,6 +548,89 @@ pub fn ilike_utf8_scalar( Ok(BooleanArray::from(data)) } +/// Perform SQL `left NOT ILIKE

[GitHub] [arrow] wesm commented on a diff in pull request #13218: ARROW-16590: [C++] Consolidate files dealing with row-major storage

2022-06-13 Thread GitBox
wesm commented on code in PR #13218: URL: https://github.com/apache/arrow/pull/13218#discussion_r896088311 ## cpp/src/arrow/compute/row/row_internal.h: ## @@ -0,0 +1,250 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow] wesm commented on a diff in pull request #13218: ARROW-16590: [C++] Consolidate files dealing with row-major storage

2022-06-13 Thread GitBox
wesm commented on code in PR #13218: URL: https://github.com/apache/arrow/pull/13218#discussion_r896084320 ## cpp/src/arrow/compute/row/row_internal.h: ## @@ -0,0 +1,250 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-datafusion] alamb merged pull request #2716: Support for GROUPING SETS/CUBE/ROLLUP

2022-06-13 Thread GitBox
alamb merged PR #2716: URL: https://github.com/apache/arrow-datafusion/pull/2716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow-datafusion] alamb closed issue #1327: implement grouping sets, cubes, and rollups

2022-06-13 Thread GitBox
alamb closed issue #1327: implement grouping sets, cubes, and rollups URL: https://github.com/apache/arrow-datafusion/issues/1327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-datafusion] alamb commented on pull request #2716: Support for GROUPING SETS/CUBE/ROLLUP

2022-06-13 Thread GitBox
alamb commented on PR #2716: URL: https://github.com/apache/arrow-datafusion/pull/2716#issuecomment-1154368725 Looks great to me -- thanks again for all the work @thinkharderdev πŸŽ‰ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [arrow] github-actions[bot] commented on pull request #13376: Fixing build/unit test issues in msvc/win32 (ARROW-16778)

2022-06-13 Thread GitBox
github-actions[bot] commented on PR #13376: URL: https://github.com/apache/arrow/pull/13376#issuecomment-1154366224 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2718: Upgrade to arrow `16.0.0`

2022-06-13 Thread GitBox
alamb commented on code in PR #2718: URL: https://github.com/apache/arrow-datafusion/pull/2718#discussion_r896076556 ## datafusion/core/src/physical_plan/planner.rs: ## @@ -1544,20 +1540,22 @@ mod tests { .build()?; let execution_plan = plan(&logical_plan).

[GitHub] [arrow-rs] tustvold merged pull request #1868: Pin clap to 3.1 to get CI moving (#1867)

2022-06-13 Thread GitBox
tustvold merged PR #1868: URL: https://github.com/apache/arrow-rs/pull/1868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1863: Exclude some long-running tests when running under miri

2022-06-13 Thread GitBox
codecov-commenter commented on PR #1863: URL: https://github.com/apache/arrow-rs/pull/1863#issuecomment-1154260033 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1863?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [arrow-rs] nevi-me merged pull request #1859: Omit validity buffer in PrimitiveArray::from_iter when all values are valid

2022-06-13 Thread GitBox
nevi-me merged PR #1859: URL: https://github.com/apache/arrow-rs/pull/1859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

[GitHub] [arrow-rs] nevi-me closed issue #1856: PrimitiveArray::from_iter should omit validity buffer if all values are valid

2022-06-13 Thread GitBox
nevi-me closed issue #1856: PrimitiveArray::from_iter should omit validity buffer if all values are valid URL: https://github.com/apache/arrow-rs/issues/1856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [arrow-rs] jhorstmann commented on pull request #1863: Exclude some long-running tests when running under miri

2022-06-13 Thread GitBox
jhorstmann commented on PR #1863: URL: https://github.com/apache/arrow-rs/pull/1863#issuecomment-1154245280 Disabling stacked-borrow checking is not perfect, but probably better to run miri with one less check than not running it at all. The check using a lot of cpu and memory is a known pr

[GitHub] [arrow-ballista] thinkharderdev commented on pull request #59: Support for multi-scheduler deployments

2022-06-13 Thread GitBox
thinkharderdev commented on PR #59: URL: https://github.com/apache/arrow-ballista/pull/59#issuecomment-1154240883 @yahoNanJing Made a small change in the event loop. It will now eagerly attempt to schedule additional pending tasks for a job on update. I think this should address your point

[GitHub] [arrow] ursabot commented on pull request #13357: ARROW-16813: [Go][Parquet] fix go parquet dictionary encoding writer property

2022-06-13 Thread GitBox
ursabot commented on PR #13357: URL: https://github.com/apache/arrow/pull/13357#issuecomment-1154227721 ['Python', 'R'] benchmarks have high level of regressions. [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2d43fcebf510411f9ef33f0341b63fca...843eadbe9ebf4bd7a23850d37a70db8e/)

[GitHub] [arrow] ursabot commented on pull request #13357: ARROW-16813: [Go][Parquet] fix go parquet dictionary encoding writer property

2022-06-13 Thread GitBox
ursabot commented on PR #13357: URL: https://github.com/apache/arrow/pull/13357#issuecomment-1154227585 Benchmark runs are scheduled for baseline = a53f2bda5dfa50f2d1dbfd9d7fbc98d8c9725564 and contender = c5a74802b8e02ba882ff09393b8e1afd9d28270f. c5a74802b8e02ba882ff09393b8e1afd9d28270f is

[GitHub] [arrow-rs] tustvold commented on issue #1867: Clap Deprecations

2022-06-13 Thread GitBox
tustvold commented on issue #1867: URL: https://github.com/apache/arrow-rs/issues/1867#issuecomment-1154211295 I've run out of time to work on this, but #1868 should get the pipes moving again -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1869: Update vendored gRPC

2022-06-13 Thread GitBox
codecov-commenter commented on PR #1869: URL: https://github.com/apache/arrow-rs/pull/1869#issuecomment-1154210706 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [arrow-rs] tustvold commented on pull request #1866: Mark typed buffer APIs safe (#996) (#1027)

2022-06-13 Thread GitBox
tustvold commented on PR #1866: URL: https://github.com/apache/arrow-rs/pull/1866#issuecomment-1154210410 Clippy fix in #1868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1868: Pin clap to 3.1 (#1867)

2022-06-13 Thread GitBox
codecov-commenter commented on PR #1868: URL: https://github.com/apache/arrow-rs/pull/1868#issuecomment-1154202292 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1868?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [arrow-rs] viirya commented on issue #131: Implement support for Decimal with 256 bits of precision.

2022-06-13 Thread GitBox
viirya commented on issue #131: URL: https://github.com/apache/arrow-rs/issues/131#issuecomment-1154197732 I think you mean to make Decimal128 to be compatible with i128 so it won't break existing user code? It makes sense to me. -- This is an automated message from the Apache Git

[GitHub] [arrow-rs] tustvold opened a new pull request, #1869: Update vendored gRPC

2022-06-13 Thread GitBox
tustvold opened a new pull request, #1869: URL: https://github.com/apache/arrow-rs/pull/1869 Running ``` rm Cargo.lock cargo check ``` Results in the following changes to the generated files. It also generates an empty protobuf file which appears to relate to https://

[GitHub] [arrow-rs] tustvold opened a new pull request, #1868: Pin clap to 3.1 (#1867)

2022-06-13 Thread GitBox
tustvold opened a new pull request, #1868: URL: https://github.com/apache/arrow-rs/pull/1868 # Which issue does this PR close? Part of #1867 # Rationale for this change This gets the pipes moving again, whilst working on trying to understand what has been changed...

[GitHub] [arrow-rs] MazterQyou commented on a diff in pull request #1846: Add `nilike` support in `comparison`

2022-06-13 Thread GitBox
MazterQyou commented on code in PR #1846: URL: https://github.com/apache/arrow-rs/pull/1846#discussion_r895954685 ## arrow/src/compute/kernels/comparison.rs: ## @@ -548,6 +548,89 @@ pub fn ilike_utf8_scalar( Ok(BooleanArray::from(data)) } +/// Perform SQL `left NOT ILIKE

[GitHub] [arrow-rs] tustvold opened a new issue, #1867: Clap Deprecations

2022-06-13 Thread GitBox
tustvold opened a new issue, #1867: URL: https://github.com/apache/arrow-rs/issues/1867 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** The most recent clap release deprecated some functionality which is causing clippy to fail

[GitHub] [arrow-datafusion] j-a-m-l commented on issue #1114: Ruby bindings

2022-06-13 Thread GitBox
j-a-m-l commented on issue #1114: URL: https://github.com/apache/arrow-datafusion/issues/1114#issuecomment-1154163105 Just to clarify: I can't be involved in this binding, since my current employer is not interested and I don't have enough free time to do it. -- This is an automated mess

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1866: Mark typed buffer APIs safe (#996) (#1027)

2022-06-13 Thread GitBox
tustvold commented on code in PR #1866: URL: https://github.com/apache/arrow-rs/pull/1866#discussion_r895931569 ## arrow/src/buffer/mutable.rs: ## @@ -299,7 +296,7 @@ impl MutableBuffer { /// assert_eq!(buffer.len(), 8) // u32 has 4 bytes /// ``` #[inline] -pu

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1866: Mark typed buffer APIs safe (#996) (#1027)

2022-06-13 Thread GitBox
tustvold commented on code in PR #1866: URL: https://github.com/apache/arrow-rs/pull/1866#discussion_r895935063 ## parquet/src/arrow/arrow_writer/mod.rs: ## @@ -576,7 +576,7 @@ macro_rules! def_get_binary_array_fn { fn $name(array: &$ty) -> Vec { let mut by

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1866: Mark typed buffer APIs safe (#996) (#1027)

2022-06-13 Thread GitBox
tustvold commented on code in PR #1866: URL: https://github.com/apache/arrow-rs/pull/1866#discussion_r895931569 ## arrow/src/buffer/mutable.rs: ## @@ -299,7 +296,7 @@ impl MutableBuffer { /// assert_eq!(buffer.len(), 8) // u32 has 4 bytes /// ``` #[inline] -pu

[GitHub] [arrow] vibhatha commented on a diff in pull request #13375: ARROW-16823: [C++] Arrow Substrait enhancements for UDF

2022-06-13 Thread GitBox
vibhatha commented on code in PR #13375: URL: https://github.com/apache/arrow/pull/13375#discussion_r895930793 ## cpp/src/arrow/engine/substrait/serde.cc: ## @@ -58,12 +58,53 @@ Result DeserializeRelation(const Buffer& buf, return FromProto(rel, ext_set); } -Result> Deser

[GitHub] [arrow-rs] tustvold opened a new pull request, #1866: Mark typed buffer APIs safe (#996) (#1027)

2022-06-13 Thread GitBox
tustvold opened a new pull request, #1866: URL: https://github.com/apache/arrow-rs/pull/1866 # Which issue does this PR close? Closes #996 Closes #1027 # Rationale for this change These APIs were originally marked unsafe because `ArrowNativeType` could be implemente

[GitHub] [arrow] dominicbarnes commented on pull request #13322: ARROW-16759: [Go] update testify to get security patch for gopkg.in/yaml.v3 (v7)

2022-06-13 Thread GitBox
dominicbarnes commented on PR #13322: URL: https://github.com/apache/arrow/pull/13322#issuecomment-1154147685 @zeroshade thanks for getting this merged! How can I help getting the fix backported? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [arrow] assignUser commented on pull request #13244: ARROW-12626: [C++] Support toolchain xsimd, update toolchain version to version 8.1.0

2022-06-13 Thread GitBox
assignUser commented on PR #13244: URL: https://github.com/apache/arrow/pull/13244#issuecomment-1154145310 2h 51min vs 1h πŸ₯³ πŸš€ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [arrow] vibhatha commented on a diff in pull request #13375: ARROW-16823: [C++] Arrow Substrait enhancements for UDF

2022-06-13 Thread GitBox
vibhatha commented on code in PR #13375: URL: https://github.com/apache/arrow/pull/13375#discussion_r895922931 ## cpp/src/arrow/engine/substrait/plan_internal.cc: ## @@ -92,6 +92,9 @@ Status AddExtensionSetToPlan(const ExtensionSet& ext_set, substrait::Plan* plan) Result Get

[GitHub] [arrow] emkornfield commented on a diff in pull request #12775: ARROW-16006: [C++] Row conversion helpers and example

2022-06-13 Thread GitBox
emkornfield commented on code in PR #12775: URL: https://github.com/apache/arrow/pull/12775#discussion_r895891829 ## cpp/examples/arrow/rapidjson_row_converter.cc: ## @@ -0,0 +1,590 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

[GitHub] [arrow] wesm merged pull request #13364: ARROW-16756: [C++] Introduce non-owning ArraySpan, ExecSpan data structures and refactor ScalarKernels to use them

2022-06-13 Thread GitBox
wesm merged PR #13364: URL: https://github.com/apache/arrow/pull/13364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.o

[GitHub] [arrow] wesm commented on pull request #13364: ARROW-16756: [C++] Introduce non-owning ArraySpan, ExecSpan data structures and refactor ScalarKernels to use them

2022-06-13 Thread GitBox
wesm commented on PR #13364: URL: https://github.com/apache/arrow/pull/13364#issuecomment-1154109376 I started working on refactoring the remaining kernels -- any further review/comments here I will address in follow up PRs or you can add new issues linked to the parent issue ARROW-16755

[GitHub] [arrow] emkornfield commented on a diff in pull request #12775: ARROW-16006: [C++] Row conversion helpers and example

2022-06-13 Thread GitBox
emkornfield commented on code in PR #12775: URL: https://github.com/apache/arrow/pull/12775#discussion_r895888362 ## cpp/examples/arrow/rapidjson_row_converter.cc: ## @@ -0,0 +1,590 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

[GitHub] [arrow] rtpsw commented on a diff in pull request #13375: ARROW-16823: [C++] Arrow Substrait enhancements for UDF

2022-06-13 Thread GitBox
rtpsw commented on code in PR #13375: URL: https://github.com/apache/arrow/pull/13375#discussion_r89586 ## cpp/src/arrow/engine/substrait/plan_internal.cc: ## @@ -92,6 +92,9 @@ Status AddExtensionSetToPlan(const ExtensionSet& ext_set, substrait::Plan* plan) Result GetExt

[GitHub] [arrow-ballista] thinkharderdev commented on pull request #59: Support for multi-scheduler deployments

2022-06-13 Thread GitBox
thinkharderdev commented on PR #59: URL: https://github.com/apache/arrow-ballista/pull/59#issuecomment-1154063171 > Hi @thinkharderdev, > > > On this point I disagree. High availability is one goal of this work but another is horizontal scalability. The work involved in physical plann

[GitHub] [arrow] vibhatha commented on a diff in pull request #13375: ARROW-16823: [C++] Arrow Substrait enhancements for UDF

2022-06-13 Thread GitBox
vibhatha commented on code in PR #13375: URL: https://github.com/apache/arrow/pull/13375#discussion_r895853513 ## cpp/src/arrow/engine/substrait/plan_internal.cc: ## @@ -92,6 +92,9 @@ Status AddExtensionSetToPlan(const ExtensionSet& ext_set, substrait::Plan* plan) Result Get

  1   2   >