[GitHub] [arrow-datafusion] liukun4515 commented on issue #2759: InList Expr: expr and list values must can be convert to a same data type

2022-06-21 Thread GitBox
liukun4515 commented on issue #2759: URL: https://github.com/apache/arrow-datafusion/issues/2759#issuecomment-1162711534 If we want to use the NULL in the list expr. The data type of NULL is `NULL`, like that `expr: Literal { value: Int32(NULL) }` -- This is an automated message from

[GitHub] [arrow-datafusion] liukun4515 commented on issue #2759: InList Expr: expr and list values must can be convert to a same data type

2022-06-21 Thread GitBox
liukun4515 commented on issue #2759: URL: https://github.com/apache/arrow-datafusion/issues/2759#issuecomment-1162708027 In the datafusion, we can convert NULL value of the NULL type to any other NULL value of data type. For example: Convert NULL(NULL) to INT32(NULL) or FLOAT(NULL); ❯

[GitHub] [arrow] vibhatha commented on a diff in pull request #13412: ARROW-16865: [C++][Python] Implement cumulative product, max, and min compute functions

2022-06-21 Thread GitBox
vibhatha commented on code in PR #13412: URL: https://github.com/apache/arrow/pull/13412#discussion_r903325423 ## cpp/src/arrow/compute/api_vector.cc: ## @@ -383,6 +401,14 @@ Result CumulativeSum(const Datum& values, const CumulativeSumOptions& opt return CallFunction(func_n

[GitHub] [arrow] kou commented on a diff in pull request #13308: ARROW-16666: [Docs][Release] Update release guide to specify new workflow and feature freeze

2022-06-21 Thread GitBox
kou commented on code in PR #13308: URL: https://github.com/apache/arrow/pull/13308#discussion_r903317882 ## docs/source/developers/release.rst: ## @@ -130,23 +181,28 @@ These are the different steps that are required to create a release candidate. # after you complete the

[GitHub] [arrow] vibhatha commented on a diff in pull request #13412: ARROW-16865: [C++][Python] Implement cumulative product, max, and min compute functions

2022-06-21 Thread GitBox
vibhatha commented on code in PR #13412: URL: https://github.com/apache/arrow/pull/13412#discussion_r903323818 ## cpp/src/arrow/compute/api_vector.cc: ## @@ -383,6 +401,14 @@ Result CumulativeSum(const Datum& values, const CumulativeSumOptions& opt return CallFunction(func_n

[GitHub] [arrow] vibhatha commented on a diff in pull request #13412: ARROW-16865: [C++][Python] Implement cumulative product, max, and min compute functions

2022-06-21 Thread GitBox
vibhatha commented on code in PR #13412: URL: https://github.com/apache/arrow/pull/13412#discussion_r903323137 ## cpp/src/arrow/compute/api_vector.cc: ## @@ -383,6 +401,14 @@ Result CumulativeSum(const Datum& values, const CumulativeSumOptions& opt return CallFunction(func_n

[GitHub] [arrow] kou merged pull request #13407: ARROW-16869: [CI][C++][Homebrew] Build Apache Arrow with C++17

2022-06-21 Thread GitBox
kou merged PR #13407: URL: https://github.com/apache/arrow/pull/13407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow] kou commented on issue #13396: Is the Arrow::Table.merge function in a working state?

2022-06-21 Thread GitBox
kou commented on issue #13396: URL: https://github.com/apache/arrow/issues/13396#issuecomment-1162676527 Apache Parquet doesn't support "seconds" as unit: https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#timestamp So "seconds" timestamp type is converted to "millisecon

[GitHub] [arrow-datafusion] liukun4515 commented on issue #2755: support data type coerced and decimal in INLIST expr

2022-06-21 Thread GitBox
liukun4515 commented on issue #2755: URL: https://github.com/apache/arrow-datafusion/issues/2755#issuecomment-1162673018 blocked by this issue https://github.com/apache/arrow-datafusion/issues/2759 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [arrow-datafusion] liukun4515 opened a new issue, #2759: InList Expr: expr and list values must can be convert to a same data type

2022-06-21 Thread GitBox
liukun4515 opened a new issue, #2759: URL: https://github.com/apache/arrow-datafusion/issues/2759 **Describe the bug** In current inList implemention, we don't consider the data type of the list value. For example: I create a table ``` ❯ \d food +---+-

[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #2721: Add additional data types are supported in hash join

2022-06-21 Thread GitBox
liukun4515 commented on code in PR #2721: URL: https://github.com/apache/arrow-datafusion/pull/2721#discussion_r903294153 ## datafusion/core/src/physical_plan/hash_join.rs: ## @@ -1054,6 +1110,116 @@ fn equal_rows( DataType::LargeUtf8 => { equal_row

[GitHub] [arrow-ballista] dependabot[bot] opened a new pull request, #72: Bump numpy from 1.21.3 to 1.22.0 in /python

2022-06-21 Thread GitBox
dependabot[bot] opened a new pull request, #72: URL: https://github.com/apache/arrow-ballista/pull/72 Bumps [numpy](https://github.com/numpy/numpy) from 1.21.3 to 1.22.0. Release notes Sourced from https://github.com/numpy/numpy/releases";>numpy's releases. v1.22.0 NumPy 1

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #2758: Bump numpy from 1.21.3 to 1.22.0 in /integration-tests

2022-06-21 Thread GitBox
codecov-commenter commented on PR #2758: URL: https://github.com/apache/arrow-datafusion/pull/2758#issuecomment-1162638705 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2758?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow-datafusion] AssHero commented on pull request #2750: try to reduce left/right/full join to inner join

2022-06-21 Thread GitBox
AssHero commented on PR #2750: URL: https://github.com/apache/arrow-datafusion/pull/2750#issuecomment-1162635636 Split the test cases into single test method. Implementing this as optimization rule is in progress. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow-datafusion] dependabot[bot] opened a new pull request, #2758: Bump numpy from 1.21.3 to 1.22.0 in /integration-tests

2022-06-21 Thread GitBox
dependabot[bot] opened a new pull request, #2758: URL: https://github.com/apache/arrow-datafusion/pull/2758 Bumps [numpy](https://github.com/numpy/numpy) from 1.21.3 to 1.22.0. Release notes Sourced from https://github.com/numpy/numpy/releases";>numpy's releases. v1.22.0 N

[GitHub] [arrow] github-actions[bot] commented on pull request #13416: ARROW-16092: [Python] Address docstrings in Filesystems (Implementations)

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13416: URL: https://github.com/apache/arrow/pull/13416#issuecomment-1162610356 https://issues.apache.org/jira/browse/ARROW-16092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #13415: ARROW-16578: [R] unique() and is.na() on a column of a tibble is much slower after writing to and reading from a parquet file

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13415: URL: https://github.com/apache/arrow/pull/13415#issuecomment-1162591830 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] github-actions[bot] commented on pull request #13415: ARROW-16578: [R] unique() and is.na() on a column of a tibble is much slower after writing to and reading from a parquet file

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13415: URL: https://github.com/apache/arrow/pull/13415#issuecomment-1162591820 https://issues.apache.org/jira/browse/ARROW-16578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] hideaki opened a new pull request, #13415: ARROW-16578: [R] unique() and is.na() on a column of a tibble is much slower after writing to and reading from a parquet file

2022-06-21 Thread GitBox
hideaki opened a new pull request, #13415: URL: https://github.com/apache/arrow/pull/13415 Fixes ARROW-16578 "[R] unique() and is.na() on a column of a tibble is much slower after writing to and reading from a parquet file". Here I'm materializing the AltrepVectorString at the first c

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1855: support compression for IPC

2022-06-21 Thread GitBox
viirya commented on code in PR #1855: URL: https://github.com/apache/arrow-rs/pull/1855#discussion_r903077863 ## arrow/Cargo.toml: ## @@ -60,7 +63,7 @@ multiversion = { version = "0.6.1", default-features = false } bitflags = { version = "1.2.1", default-features = false } [

[GitHub] [arrow] github-actions[bot] commented on pull request #13414: Bump numpy from 1.21.3 to 1.22.0 in /python

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13414: URL: https://github.com/apache/arrow/pull/13414#issuecomment-1162577211 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue

[GitHub] [arrow] dependabot[bot] opened a new pull request, #13414: Bump numpy from 1.21.3 to 1.22.0 in /python

2022-06-21 Thread GitBox
dependabot[bot] opened a new pull request, #13414: URL: https://github.com/apache/arrow/pull/13414 Bumps [numpy](https://github.com/numpy/numpy) from 1.21.3 to 1.22.0. Release notes Sourced from https://github.com/numpy/numpy/releases";>numpy's releases. v1.22.0 NumPy 1.22

[GitHub] [arrow] vibhatha commented on a diff in pull request #13150: ARROW-16549: [C++] Simplify AggregateNodeOptions aggregates/targets

2022-06-21 Thread GitBox
vibhatha commented on code in PR #13150: URL: https://github.com/apache/arrow/pull/13150#discussion_r903225025 ## r/R/query-engine.R: ## @@ -259,6 +221,49 @@ ExecPlan <- R6Class("ExecPlan", ) }, Stop = function() ExecPlan_StopProducing(self) + ), + private = l

[GitHub] [arrow] github-actions[bot] commented on pull request #13407: ARROW-16869: [C++] Fix bundled abseil and homebrew formula

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13407: URL: https://github.com/apache/arrow/pull/13407#issuecomment-1162533128 Revision: caf11481242097516eb04bd569135e7aafd31603 Submitted crossbow builds: [ursacomputing/crossbow @ actions-a120875ba7](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] nealrichardson commented on pull request #13407: ARROW-16869: [C++] Fix bundled abseil and homebrew formula

2022-06-21 Thread GitBox
nealrichardson commented on PR #13407: URL: https://github.com/apache/arrow/pull/13407#issuecomment-1162532592 @github-actions crossbow submit homebrew-r-brew -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [arrow] nealrichardson commented on pull request #13407: ARROW-16869: [C++] Fix bundled abseil and homebrew formula

2022-06-21 Thread GitBox
nealrichardson commented on PR #13407: URL: https://github.com/apache/arrow/pull/13407#issuecomment-1162532462 > FYI: `resolve_dependency_absl()` isn't related to this case because we don't use bundled Abseil in this case. Yep, I was wrongly assuming that all of my "undefined symbols"

[GitHub] [arrow-datafusion] AssHero opened a new issue, #2757: Reduce outer joins

2022-06-21 Thread GitBox
AssHero opened a new issue, #2757: URL: https://github.com/apache/arrow-datafusion/issues/2757 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** For query: select ... from a left join b on ... where b.xx = 100; if b.xx is null

[GitHub] [arrow-datafusion] AssHero commented on pull request #2750: try to reduce left/right/full join to inner join

2022-06-21 Thread GitBox
AssHero commented on PR #2750: URL: https://github.com/apache/arrow-datafusion/pull/2750#issuecomment-1162521148 > @AssHero Since this is a significant feature could you file an issue for it so that it gets included in the change logs. yes, I'll file an issue. -- This is an automa

[GitHub] [arrow] cyb70289 commented on pull request #13412: ARROW-16865: [C++][Python] Implement cumulative product, max, and min compute functions

2022-06-21 Thread GitBox
cyb70289 commented on PR #13412: URL: https://github.com/apache/arrow/pull/13412#issuecomment-1162520142 You may consider converting it to draft if this PR is not ready for review now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] cyb70289 commented on pull request #13412: ARROW-16865: [C++] Implement cumulative product, max, and min compute functions

2022-06-21 Thread GitBox
cyb70289 commented on PR #13412: URL: https://github.com/apache/arrow/pull/13412#issuecomment-1162518343 Thanks for doing this. Will you add unit tests and update related documents? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [arrow] paleolimbot commented on a diff in pull request #13150: ARROW-16549: [C++] Simplify AggregateNodeOptions aggregates/targets

2022-06-21 Thread GitBox
paleolimbot commented on code in PR #13150: URL: https://github.com/apache/arrow/pull/13150#discussion_r903188788 ## r/R/query-engine.R: ## @@ -259,6 +221,49 @@ ExecPlan <- R6Class("ExecPlan", ) }, Stop = function() ExecPlan_StopProducing(self) + ), + private

[GitHub] [arrow] github-actions[bot] commented on pull request #13413: ARROW-16779:[Python][Packaging] Enable flight on M1 wheels

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13413: URL: https://github.com/apache/arrow/pull/13413#issuecomment-1162507362 Revision: 5a757c9f290b834f48e877f303dd67938b482694 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1812e120cc](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] wjones127 commented on pull request #13413: ARROW-16779:[Python][Packaging] Enable flight on M1 wheels

2022-06-21 Thread GitBox
wjones127 commented on PR #13413: URL: https://github.com/apache/arrow/pull/13413#issuecomment-1162506669 @github-actions crossbow submit wheel-macos-big-sur-cp38-arm64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [arrow] kou commented on pull request #13407: ARROW-16869: [C++] Fix bundled abseil and homebrew formula

2022-06-21 Thread GitBox
kou commented on PR #13407: URL: https://github.com/apache/arrow/pull/13407#issuecomment-1162501599 FYI: `resolve_dependency_absl()` isn't related to this case because we don't use bundled Abseil in this case. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] kou commented on pull request #13407: ARROW-16869: [C++] Fix bundled abseil and homebrew formula

2022-06-21 Thread GitBox
kou commented on PR #13407: URL: https://github.com/apache/arrow/pull/13407#issuecomment-1162500923 Sorry, I missed this in ARROW-14892. Could you try the following? ```diff diff --git a/dev/tasks/homebrew-formulae/apache-arrow.rb b/dev/tasks/homebrew-formulae/apache-arrow.r

[GitHub] [arrow] github-actions[bot] commented on pull request #13413: ARROW-16779:[Python][Packaging] Enable flight on M1 wheels

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13413: URL: https://github.com/apache/arrow/pull/13413#issuecomment-1162498550 Revision: d3429cbb442554feb54d8cf73044addf1360f3be Submitted crossbow builds: [ursacomputing/crossbow @ actions-1bc67ebac8](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] wjones127 commented on pull request #13413: ARROW-16779:[Python][Packaging] Enable flight on M1 wheels

2022-06-21 Thread GitBox
wjones127 commented on PR #13413: URL: https://github.com/apache/arrow/pull/13413#issuecomment-1162497943 @github-actions crossbow submit wheel-macos-big-sur-cp38-arm64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [arrow] emkornfield commented on a diff in pull request #13404: ARROW-16510: [R] Add bindings for GCS filesystem

2022-06-21 Thread GitBox
emkornfield commented on code in PR #13404: URL: https://github.com/apache/arrow/pull/13404#discussion_r903175660 ## r/src/filesystem.cpp: ## @@ -331,3 +337,77 @@ std::string fs___S3FileSystem__region(const std::shared_ptr& f } #endif + +#if defined(ARROW_R_WITH_GCS) + +#in

[GitHub] [arrow] github-actions[bot] commented on pull request #13413: ARROW-16779:[Python][Packaging] Enable flight on M1 wheels

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13413: URL: https://github.com/apache/arrow/pull/13413#issuecomment-1162485417 Revision: 1f9a980602754b0156d47cb6d00c5668fb0defd1 Submitted crossbow builds: [ursacomputing/crossbow @ actions-add7f516ca](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] wjones127 commented on pull request #13413: ARROW-16779:[Python][Packaging] Enable flight on M1 wheels

2022-06-21 Thread GitBox
wjones127 commented on PR #13413: URL: https://github.com/apache/arrow/pull/13413#issuecomment-1162484905 @github-actions crossbow submit wheel-macos-big-sur-cp38-arm64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [arrow] github-actions[bot] commented on pull request #13413: ARROW-16779:[Python][Packaging] Enable flight on M1 wheels

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13413: URL: https://github.com/apache/arrow/pull/13413#issuecomment-1162479203 Revision: 1f9a980602754b0156d47cb6d00c5668fb0defd1 Submitted crossbow builds: [ursacomputing/crossbow @ actions-8de7e78663](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] wjones127 commented on pull request #13413: ARROW-16779:[Python][Packaging] Enable flight on M1 wheels

2022-06-21 Thread GitBox
wjones127 commented on PR #13413: URL: https://github.com/apache/arrow/pull/13413#issuecomment-1162478416 @github-actions crossbow submit wheel-*-cp37-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] github-actions[bot] commented on pull request #13413: ARROW-16779:[Python][Packaging] Enable flight on M1 wheels

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13413: URL: https://github.com/apache/arrow/pull/13413#issuecomment-1162476715 ``` Unable to match any tasks for `wheel--cp37-` The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2539006124 ``` -- This is an auto

[GitHub] [arrow] wjones127 commented on pull request #13413: ARROW-16779:[Python][Packaging] Enable flight on M1 wheels

2022-06-21 Thread GitBox
wjones127 commented on PR #13413: URL: https://github.com/apache/arrow/pull/13413#issuecomment-1162476031 @github-actions crossbow submit wheel--cp37- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #13413: ARROW-16779:[Python][Packaging] Enable flight on M1 wheels

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13413: URL: https://github.com/apache/arrow/pull/13413#issuecomment-1162475823 https://issues.apache.org/jira/browse/ARROW-16779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] coryan commented on pull request #13404: ARROW-16510: [R] Add bindings for GCS filesystem

2022-06-21 Thread GitBox
coryan commented on PR #13404: URL: https://github.com/apache/arrow/pull/13404#issuecomment-1162474007 I suspect `absl::memory` is a header-only library, so it does not have a `$`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] github-actions[bot] commented on pull request #13412: ARROW-16865: [C++] Implement cumulative product, max, and min compute functions

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13412: URL: https://github.com/apache/arrow/pull/13412#issuecomment-1162467083 https://issues.apache.org/jira/browse/ARROW-16865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #13412: ARROW-16865: [C++] Implement cumulative product, max, and min compute functions

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13412: URL: https://github.com/apache/arrow/pull/13412#issuecomment-1162467103 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] nealrichardson commented on pull request #13404: ARROW-16510: [R] Add bindings for GCS filesystem

2022-06-21 Thread GitBox
nealrichardson commented on PR #13404: URL: https://github.com/apache/arrow/pull/13404#issuecomment-1162466449 Well, that didn't work, there must be some other piece I'm missing: ``` -- Configuring done CMake Error at cmake_modules/BuildUtils.cmake:112 (file): Error evaluat

[GitHub] [arrow] JabariBooker opened a new pull request, #13412: ARROW-16865: [C++] Implement cumulative product, max, and min compute functions

2022-06-21 Thread GitBox
JabariBooker opened a new pull request, #13412: URL: https://github.com/apache/arrow/pull/13412 Creating new compute functions to perform cumulative product, max, and min on a given array. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [arrow] nealrichardson commented on pull request #13407: ARROW-16869: [C++] Fix bundled abseil and homebrew formula

2022-06-21 Thread GitBox
nealrichardson commented on PR #13407: URL: https://github.com/apache/arrow/pull/13407#issuecomment-1162456466 Following https://github.com/apache/arrow/pull/13404#issuecomment-1162448555, I think we need `ABSEIL_SOURCE=BUNDLED` so that we get C++11 compatibility--brew builds for C++17.

[GitHub] [arrow] martin-liu commented on pull request #13402: MINOR: [Python] Fix pandas conversion failure when using non-str index name

2022-06-21 Thread GitBox
martin-liu commented on PR #13402: URL: https://github.com/apache/arrow/pull/13402#issuecomment-1162452139 @lidavidm Thanks for your time! I didn't fully get your point, basically Pandas allows non-str column/index names, it's just in PyArrow we are using `str(name)`. The existing co

[GitHub] [arrow-datafusion] andygrove commented on pull request #2549: feat: support for AnyExpression

2022-06-21 Thread GitBox
andygrove commented on PR #2549: URL: https://github.com/apache/arrow-datafusion/pull/2549#issuecomment-1162451730 Hi @ovr What do you think about breaking this up into smaller PRs and starting with the logical plan changes and SQL parsing? I think this might make it easier to start gettin

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2750: try to reduce left/right/full join to inner join

2022-06-21 Thread GitBox
andygrove commented on code in PR #2750: URL: https://github.com/apache/arrow-datafusion/pull/2750#discussion_r903140029 ## datafusion/sql/src/planner.rs: ## @@ -784,6 +784,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { let filter_expr = self.sql_to_rex(p

[GitHub] [arrow] nealrichardson commented on pull request #13404: ARROW-16510: [R] Add bindings for GCS filesystem

2022-06-21 Thread GitBox
nealrichardson commented on PR #13404: URL: https://github.com/apache/arrow/pull/13404#issuecomment-1162448555 @coryan thanks, that's helpful actually. I'll have to dig more on the bundled libraries thing. On the Homebrew build, abseil indeed is being built with C++17 by brew (https://gith

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2750: try to reduce left/right/full join to inner join

2022-06-21 Thread GitBox
andygrove commented on code in PR #2750: URL: https://github.com/apache/arrow-datafusion/pull/2750#discussion_r903138887 ## datafusion/core/tests/sql/joins.rs: ## @@ -1342,3 +1342,458 @@ async fn join_with_hash_unsupported_data_type() -> Result<()> { Ok(()) } + +#[tokio

[GitHub] [arrow-datafusion] andygrove commented on pull request #2750: try to reduce left/right/full join to inner join

2022-06-21 Thread GitBox
andygrove commented on PR #2750: URL: https://github.com/apache/arrow-datafusion/pull/2750#issuecomment-1162448018 @AssHero Since this is a significant feature could you file an issue for it so that it gets included in the change logs. -- This is an automated message from the Apache Git

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #2754: Implement extensible configuration mechanism

2022-06-21 Thread GitBox
codecov-commenter commented on PR #2754: URL: https://github.com/apache/arrow-datafusion/pull/2754#issuecomment-1162447854 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2754?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow-ballista] elferherrera commented on issue #30: [Discuss] Ballista Future Direction

2022-06-21 Thread GitBox
elferherrera commented on issue #30: URL: https://github.com/apache/arrow-ballista/issues/30#issuecomment-1162441423 @andygrove what benefits are you expecting from migrating to Substrait? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] coryan commented on pull request #13404: ARROW-16510: [R] Add bindings for GCS filesystem

2022-06-21 Thread GitBox
coryan commented on PR #13404: URL: https://github.com/apache/arrow/pull/13404#issuecomment-1162435724 TL;DR; not much of an idea, sorry. > any ideas about that undefined abseil symbol mentioned above? I assume "above" refers to https://github.com/apache/arrow/runs/6989838112?c

[GitHub] [arrow] lidavidm commented on pull request #13402: MINOR: [Python] Fix pandas conversion failure when using non-str index name

2022-06-21 Thread GitBox
lidavidm commented on PR #13402: URL: https://github.com/apache/arrow/pull/13402#issuecomment-1162428372 Filed ARROW-16873 I'll try to review this tomorrow, but a quick question, such index/column names won't round-trip back to Pandas right? Should we note that somewhere in the docs?

[GitHub] [arrow] lidavidm commented on pull request #13402: MINOR: [Python] Fix pandas conversion failure when using non-str index name

2022-06-21 Thread GitBox
lidavidm commented on PR #13402: URL: https://github.com/apache/arrow/pull/13402#issuecomment-1162426905 I think that's been happening in several PRs (I don't think an issue has been filed yet…) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow-datafusion] andygrove opened a new issue, #2756: Move some existing config options to key-value based configuration

2022-06-21 Thread GitBox
andygrove opened a new issue, #2756: URL: https://github.com/apache/arrow-datafusion/issues/2756 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** PR https://github.com/apache/arrow-datafusion/pull/2754 adds an extensible configurat

[GitHub] [arrow] arjunsr1 commented on issue #13396: Is the Arrow::Table.merge function in a working state?

2022-06-21 Thread GitBox
arjunsr1 commented on issue #13396: URL: https://github.com/apache/arrow/issues/13396#issuecomment-1162421271 Hi @kou - through using my debugger and stepping through code, it seems that when I save an arrow table with schema fields ``` History Completed Time: timestamp[s] History C

[GitHub] [arrow] nealrichardson commented on pull request #13404: ARROW-16510: [R] Add bindings for GCS filesystem

2022-06-21 Thread GitBox
nealrichardson commented on PR #13404: URL: https://github.com/apache/arrow/pull/13404#issuecomment-1162419856 @coryan any ideas about that undefined abseil symbol mentioned above? `undefined symbol: _ZN4absl12lts_2021110212RFC3339_fullE` Similar issue in the homebrew build `Symbol no

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1855: support compression for IPC

2022-06-21 Thread GitBox
viirya commented on code in PR #1855: URL: https://github.com/apache/arrow-rs/pull/1855#discussion_r903077863 ## arrow/Cargo.toml: ## @@ -60,7 +63,7 @@ multiversion = { version = "0.6.1", default-features = false } bitflags = { version = "1.2.1", default-features = false } [

[GitHub] [arrow] martin-liu commented on pull request #13402: MINOR: [Python] Fix pandas conversion failure when using non-str index name

2022-06-21 Thread GitBox
martin-liu commented on PR #13402: URL: https://github.com/apache/arrow/pull/13402#issuecomment-1162407232 @lidavidm can you help to take a look at this PR? The tests failed with `Segmentation fault` in `test_memory.py`, should be nothing to do with my change, how can I trigger a reru

[GitHub] [arrow] github-actions[bot] commented on pull request #13404: ARROW-16510: [R] Add bindings for GCS filesystem

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13404: URL: https://github.com/apache/arrow/pull/13404#issuecomment-1162381352 Revision: df5033b5a4d4a9164526f0fbe6df07539e6ddf81 Submitted crossbow builds: [ursacomputing/crossbow @ actions-b4426052af](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] nealrichardson commented on pull request #13404: ARROW-16510: [R] Add bindings for GCS filesystem

2022-06-21 Thread GitBox
nealrichardson commented on PR #13404: URL: https://github.com/apache/arrow/pull/13404#issuecomment-1162380105 @github-actions crossbow submit homebrew-r-autobrew -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] github-actions[bot] commented on pull request #13411: [WIP][DO NOT MERGE] R Nightly Troubleshooting

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13411: URL: https://github.com/apache/arrow/pull/13411#issuecomment-1162367794 Revision: 406cb88285e57b4f4dbd7d6b3f7196de1a80c8ec Submitted crossbow builds: [ursacomputing/crossbow @ actions-7e390e345c](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] assignUser commented on pull request #13411: [WIP][DO NOT MERGE] R Nightly Troubleshooting

2022-06-21 Thread GitBox
assignUser commented on PR #13411: URL: https://github.com/apache/arrow/pull/13411#issuecomment-1162366588 @github-actions crossbow submit r-nightly-packages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] arjunsr1 commented on issue #13396: Is the Arrow::Table.merge function in a working state?

2022-06-21 Thread GitBox
arjunsr1 commented on issue #13396: URL: https://github.com/apache/arrow/issues/13396#issuecomment-1162355789 Hi @kou - it seems like `s3_existing_table.concatenate([table])` should work fine. However, I'm getting an error that says `Invalid schema at index 1 was different`. The steps I'm t

[GitHub] [arrow] kou commented on issue #13396: Is the Arrow::Table.merge function in a working state?

2022-06-21 Thread GitBox
kou commented on issue #13396: URL: https://github.com/apache/arrow/issues/13396#issuecomment-1162318465 Ah, sorry. Could you try `s3_existing_table.concatenate([table])`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] arjunsr1 commented on issue #13396: Is the Arrow::Table.merge function in a working state?

2022-06-21 Thread GitBox
arjunsr1 commented on issue #13396: URL: https://github.com/apache/arrow/issues/13396#issuecomment-1162298341 I'm getting this error now: `Caused by TypeError: no implicit conversion of Arrow::Table into Array` -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [arrow] dongjoon-hyun commented on pull request #13392: ARROW-16848: [C++][Java] Update ORC to 1.7.5

2022-06-21 Thread GitBox
dongjoon-hyun commented on PR #13392: URL: https://github.com/apache/arrow/pull/13392#issuecomment-1162294119 Oh, great. Thank you, @williamhyun and @lidavidm . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [arrow-datafusion] mrob95 commented on issue #2736: `rewrite_expression` does not properly handle `Exists` and `ScalarSubquery`

2022-06-21 Thread GitBox
mrob95 commented on issue #2736: URL: https://github.com/apache/arrow-datafusion/issues/2736#issuecomment-1162293517 I will take a look at this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow] kou commented on issue #13396: Is the Arrow::Table.merge function in a working state?

2022-06-21 Thread GitBox
kou commented on issue #13396: URL: https://github.com/apache/arrow/issues/13396#issuecomment-1162289915 Could you try `s3_existing_table.concatenate(table)`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [arrow] iChauster commented on pull request #13366: ARROW-16809: [C++] Add Benchmarks for FilterNode

2022-06-21 Thread GitBox
iChauster commented on PR #13366: URL: https://github.com/apache/arrow/pull/13366#issuecomment-1162283321 > For a filtering operation I think there is an extra parameter which is the selectivity (what percentage of rows are kept). I think it would be valuable to add that as a parameter but

[GitHub] [arrow-datafusion] alamb commented on pull request #2721: Add additional data types are supported in hash join

2022-06-21 Thread GitBox
alamb commented on PR #2721: URL: https://github.com/apache/arrow-datafusion/pull/2721#issuecomment-1162271726 I'll try and take a look at this tomorrow. Sorry for the delay in review, but it is a bit of a crunch time at work (e.g. https://github.com/influxdata/influxdb_iox/issues/4658) so

[GitHub] [arrow-rs] alamb commented on pull request #1855: support compression for IPC

2022-06-21 Thread GitBox
alamb commented on PR #1855: URL: https://github.com/apache/arrow-rs/pull/1855#issuecomment-1162268676 Thanks @liukun4515 -- I will try and find time tomorrow to review this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2721: Add additional data types are supported in hash join

2022-06-21 Thread GitBox
alamb commented on code in PR #2721: URL: https://github.com/apache/arrow-datafusion/pull/2721#discussion_r903011945 ## datafusion/core/src/physical_plan/hash_join.rs: ## @@ -1054,6 +1110,116 @@ fn equal_rows( DataType::LargeUtf8 => { equal_rows_ele

[GitHub] [arrow-rs] alamb commented on pull request #1914: Add Decimal256 API

2022-06-21 Thread GitBox
alamb commented on PR #1914: URL: https://github.com/apache/arrow-rs/pull/1914#issuecomment-1162263623 I will try and find time to review this tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] lidavidm merged pull request #13392: ARROW-16848: [C++][Java] Update ORC to 1.7.5

2022-06-21 Thread GitBox
lidavidm merged PR #13392: URL: https://github.com/apache/arrow/pull/13392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

[GitHub] [arrow] lidavidm merged pull request #13344: ARROW-16686: [C++] Use shared_ptr with FunctionOptions

2022-06-21 Thread GitBox
lidavidm merged PR #13344: URL: https://github.com/apache/arrow/pull/13344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

[GitHub] [arrow] lidavidm merged pull request #13356: ARROW-16800: [C++] RecordBatchBuilder deprecate Status APIs, add Result APIs

2022-06-21 Thread GitBox
lidavidm merged PR #13356: URL: https://github.com/apache/arrow/pull/13356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

[GitHub] [arrow] github-actions[bot] commented on pull request #13411: [WIP][DO NOT MERGE] R Nightly Troubleshooting

2022-06-21 Thread GitBox
github-actions[bot] commented on PR #13411: URL: https://github.com/apache/arrow/pull/13411#issuecomment-1162230576 Revision: 2fd34f755067d352e2490c49754fb26b11a5be31 Submitted crossbow builds: [ursacomputing/crossbow @ actions-534a9f1f8e](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] assignUser commented on pull request #13411: [WIP][DO NOT MERGE] R Nightly Troubleshooting

2022-06-21 Thread GitBox
assignUser commented on PR #13411: URL: https://github.com/apache/arrow/pull/13411#issuecomment-1162229336 @github-actions crossbow submit r-nightly-packages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] icexelloss commented on a diff in pull request #13028: ARROW-16083: [C++] Implement AsofJoin execution node

2022-06-21 Thread GitBox
icexelloss commented on code in PR #13028: URL: https://github.com/apache/arrow/pull/13028#discussion_r902965193 ## cpp/src/arrow/compute/exec/asof_join_node.cc: ## @@ -0,0 +1,806 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

[GitHub] [arrow] icexelloss commented on a diff in pull request #13028: ARROW-16083: [C++] Implement AsofJoin execution node

2022-06-21 Thread GitBox
icexelloss commented on code in PR #13028: URL: https://github.com/apache/arrow/pull/13028#discussion_r902964928 ## cpp/src/arrow/compute/exec/asof_join_node.cc: ## @@ -0,0 +1,806 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

[GitHub] [arrow] icexelloss commented on a diff in pull request #13028: ARROW-16083: [C++] Implement AsofJoin execution node

2022-06-21 Thread GitBox
icexelloss commented on code in PR #13028: URL: https://github.com/apache/arrow/pull/13028#discussion_r902964703 ## cpp/src/arrow/compute/exec/asof_join_node_test.cc: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

[GitHub] [arrow] icexelloss commented on a diff in pull request #13028: ARROW-16083: [C++] Implement AsofJoin execution node

2022-06-21 Thread GitBox
icexelloss commented on code in PR #13028: URL: https://github.com/apache/arrow/pull/13028#discussion_r902964430 ## cpp/src/arrow/compute/exec/asof_join_node_test.cc: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

[GitHub] [arrow] icexelloss commented on a diff in pull request #13028: ARROW-16083: [C++] Implement AsofJoin execution node

2022-06-21 Thread GitBox
icexelloss commented on code in PR #13028: URL: https://github.com/apache/arrow/pull/13028#discussion_r902954389 ## cpp/src/arrow/compute/exec/asof_join_node_test.cc: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

[GitHub] [arrow] icexelloss commented on a diff in pull request #13028: ARROW-16083: [C++] Implement AsofJoin execution node

2022-06-21 Thread GitBox
icexelloss commented on code in PR #13028: URL: https://github.com/apache/arrow/pull/13028#discussion_r902954131 ## cpp/src/arrow/compute/exec/asof_join_node.cc: ## @@ -0,0 +1,806 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

[GitHub] [arrow] icexelloss commented on a diff in pull request #13028: ARROW-16083: [C++] Implement AsofJoin execution node

2022-06-21 Thread GitBox
icexelloss commented on code in PR #13028: URL: https://github.com/apache/arrow/pull/13028#discussion_r902952561 ## cpp/src/arrow/compute/exec/asof_join_node.cc: ## @@ -0,0 +1,806 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

[GitHub] [arrow] nealrichardson commented on pull request #13404: ARROW-16510: [R] Add bindings for GCS filesystem

2022-06-21 Thread GitBox
nealrichardson commented on PR #13404: URL: https://github.com/apache/arrow/pull/13404#issuecomment-1162173479 R debian build is failing with an undefined symbol from absl, a different one from what I saw locally (on macOS): https://github.com/apache/arrow/runs/6989838112?check_suit

[GitHub] [arrow] tielushko closed issue #13410: [JS] No longer able to access columnar data in arrow v8.0

2022-06-21 Thread GitBox
tielushko closed issue #13410: [JS] No longer able to access columnar data in arrow v8.0 URL: https://github.com/apache/arrow/issues/13410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [arrow] tielushko commented on issue #13410: [JS] No longer able to access columnar data in arrow v8.0

2022-06-21 Thread GitBox
tielushko commented on issue #13410: URL: https://github.com/apache/arrow/issues/13410#issuecomment-1162151806 I think I found the property called getChild. Was confused as to what it meant at first, but when tried calling it, I got Vector with the columnar values from the table! As

[GitHub] [arrow] tielushko opened a new issue, #13410: [JS] No longer able to access columnar data in arrow v8.0

2022-06-21 Thread GitBox
tielushko opened a new issue, #13410: URL: https://github.com/apache/arrow/issues/13410 Hi! I have been trying to transition to using the newest version of the apache-arrow-js library and noticed the entire API was re-written. I wanted to have the ability to still access values

[GitHub] [arrow] arjunsr1 commented on issue #13396: Is the Arrow::Table.merge function in a working state?

2022-06-21 Thread GitBox
arjunsr1 commented on issue #13396: URL: https://github.com/apache/arrow/issues/13396#issuecomment-1162086123 I tried to do something like this: `consolidated_table = Arrow::Table.concatenate(s3_existing_table, table)` and I got an error as follows: `Caused by NoMethodError: un

[GitHub] [arrow] nealrichardson commented on pull request #13404: ARROW-16510: [R] Add bindings for GCS filesystem

2022-06-21 Thread GitBox
nealrichardson commented on PR #13404: URL: https://github.com/apache/arrow/pull/13404#issuecomment-1162061355 I turned on GCS wherever S3 was turned on (so NOT_CRAN=true will build GCS on linux). We should check the build times and see if it's worth the cost or whether it should be a more

  1   2   >