martin-liu commented on PR #13402:
URL: https://github.com/apache/arrow/pull/13402#issuecomment-1164017683
@lidavidm Got it, using warning makes sense to me, I added warning for
non-str index name following the mixed type warning pattern, do you think
that's good enough?
--
This is an
viirya commented on code in PR #1914:
URL: https://github.com/apache/arrow-rs/pull/1914#discussion_r904613522
##
arrow/src/util/decimal.rs:
##
@@ -17,124 +17,279 @@
//! Decimal related utils
-use std::cmp::Ordering;
+use crate::error::{ArrowError, Result};
+use num::bigint:
HaoYang670 commented on code in PR #1914:
URL: https://github.com/apache/arrow-rs/pull/1914#discussion_r904601961
##
arrow/src/util/decimal.rs:
##
@@ -17,124 +17,279 @@
//! Decimal related utils
-use std::cmp::Ordering;
+use crate::error::{ArrowError, Result};
+use num::big
kou commented on PR #13150:
URL: https://github.com/apache/arrow/pull/13150#issuecomment-1163971988
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
codecov-commenter commented on PR #2775:
URL:
https://github.com/apache/arrow-datafusion/pull/2775#issuecomment-1163930449
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2775?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_
Ted-Jiang opened a new pull request, #2775:
URL: https://github.com/apache/arrow-datafusion/pull/2775
# Which issue does this PR close?
Closes #2768.
# Rationale for this change
Sometimes like in ballista we need pass multi-path in `ListingTableScanNode
`, like in spark
liukun4515 commented on code in PR #2764:
URL: https://github.com/apache/arrow-datafusion/pull/2764#discussion_r904499674
##
datafusion/physical-expr/src/planner.rs:
##
@@ -310,6 +313,8 @@ pub fn create_physical_expr(
&list_expr_data_type,
liukun4515 closed issue #2774: InList: Can't cast the list expr data type to
value expr data type directly
URL: https://github.com/apache/arrow-datafusion/issues/2774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
liukun4515 commented on issue #2774:
URL:
https://github.com/apache/arrow-datafusion/issues/2774#issuecomment-1163905413
duplicated issue about https://github.com/apache/arrow-datafusion/issues/2759
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
liukun4515 opened a new issue, #2774:
URL: https://github.com/apache/arrow-datafusion/issues/2774
**Describe the bug**
In this pr and comment, we find a bug about data type coercion for the
Inlist expr
https://github.com/apache/arrow-datafusion/pull/2764/files#r904495595
**To Re
liukun4515 commented on code in PR #2764:
URL: https://github.com/apache/arrow-datafusion/pull/2764#discussion_r904495595
##
datafusion/physical-expr/src/planner.rs:
##
@@ -310,6 +313,8 @@ pub fn create_physical_expr(
&list_expr_data_type,
codecov-commenter commented on PR #1924:
URL: https://github.com/apache/arrow-rs/pull/1924#issuecomment-1163886204
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1924?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S
HaoYang670 commented on code in PR #1914:
URL: https://github.com/apache/arrow-rs/pull/1914#discussion_r904483995
##
arrow/src/util/decimal.rs:
##
@@ -17,124 +17,280 @@
//! Decimal related utils
-use std::cmp::Ordering;
+use crate::error::{ArrowError, Result};
+use num::big
liukun4515 commented on PR #2764:
URL:
https://github.com/apache/arrow-datafusion/pull/2764#issuecomment-1163879871
@alamb @andygrove @viirya PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
HaoYang670 opened a new pull request, #1924:
URL: https://github.com/apache/arrow-rs/pull/1924
Signed-off-by: remzi <1371656737...@gmail.com>
# Which issue does this PR close?
None.
Related to #1918.
# Are there any user-facing changes?
No.
--
This is an automat
liyongjing commented on issue #1915:
URL: https://github.com/apache/arrow-rs/issues/1915#issuecomment-1163873174
It looks incompatible that read/write category and filter message type using
arrow high-level api
--
This is an automated message from the Apache Git Service.
To respond to th
vibhatha commented on PR #13150:
URL: https://github.com/apache/arrow/pull/13150#issuecomment-1163869893
@kou need some help with the C-Glib, when I rebased I tried to fix it, but
didn't succeed. Appreciate your help.
--
This is an automated message from the Apache Git Service.
To respon
liukun4515 commented on code in PR #1922:
URL: https://github.com/apache/arrow-rs/pull/1922#discussion_r904473324
##
arrow/src/compute/kernels/cast.rs:
##
@@ -72,9 +72,9 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
// cast one decimal ty
liukun4515 commented on code in PR #1922:
URL: https://github.com/apache/arrow-rs/pull/1922#discussion_r904472049
##
arrow/src/compute/kernels/cast.rs:
##
@@ -72,9 +72,9 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
// cast one decimal ty
liukun4515 commented on issue #2759:
URL:
https://github.com/apache/arrow-datafusion/issues/2759#issuecomment-1163865423
In the spark, we can't compare decimal with boolean, but can compare decimal
with Null.
```
spark-sql> DESC T1;
c1 decimal(10,3)
spar
liukun4515 opened a new issue, #2773:
URL: https://github.com/apache/arrow-datafusion/issues/2773
From this test case, we can know that we should not treat Null as UTF8 data
type
_Originally posted by @liukun4515 in
https://github.com/apache/arrow-datafusion/pull/2764#discussion_r904
viirya commented on code in PR #1922:
URL: https://github.com/apache/arrow-rs/pull/1922#discussion_r904468878
##
arrow/src/compute/kernels/cast.rs:
##
@@ -72,9 +72,9 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
// cast one decimal type t
liukun4515 commented on code in PR #2764:
URL: https://github.com/apache/arrow-datafusion/pull/2764#discussion_r904468132
##
datafusion/physical-expr/src/expressions/in_list.rs:
##
@@ -765,35 +909,38 @@ mod tests {
list,
&true,
vec -> bool {
/// replaces a column with an old n
kou commented on PR #13377:
URL: https://github.com/apache/arrow/pull/13377#issuecomment-1163778275
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
lidavidm commented on PR #12775:
URL: https://github.com/apache/arrow/pull/12775#issuecomment-1163777325
Do we also want to put the example in the Cookbook somehow? I feel like it's
a bit too long/involved to go there directly, but maybe we can cross-reference
it.
--
This is an automated
lidavidm commented on code in PR #12775:
URL: https://github.com/apache/arrow/pull/12775#discussion_r904402488
##
cpp/examples/arrow/rapidjson_row_converter.cc:
##
@@ -0,0 +1,618 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
wjones127 commented on code in PR #13404:
URL: https://github.com/apache/arrow/pull/13404#discussion_r904397786
##
r/configure.win:
##
@@ -104,6 +105,10 @@ function configure_dev() {
PKG_CFLAGS="$PKG_CFLAGS -DARROW_R_WITH_S3"
fi
+ if [ $(cmake_option ARROW_GCS) -eq 1
lidavidm commented on code in PR #13109:
URL: https://github.com/apache/arrow/pull/13109#discussion_r904379120
##
python/pyarrow/_compute.pyx:
##
@@ -2198,7 +2198,14 @@ cdef class Expression(_Weakrefable):
---
cast : Expression
"""
-options
lidavidm commented on PR #13402:
URL: https://github.com/apache/arrow/pull/13402#issuecomment-1163754740
I think it doesn't work for mixed type, you should probably see a warning?
Regardless that was my original point - if it doesn't fully round-trip it's
not _necessarily_ a problem I
comphead commented on issue #2450:
URL:
https://github.com/apache/arrow-datafusion/issues/2450#issuecomment-1163751034
@tustvold for the test, which was before. This represents roundtrip for the
list
```
ScalarValue::List(
Some(vec![
martin-liu commented on PR #13402:
URL: https://github.com/apache/arrow/pull/13402#issuecomment-1163722508
@lidavidm After some debug, it seems like existing code has bug regarding
column names, see below example:
```python
>>> import pandas as pd
>>> import pyarrow as pa
martin-liu commented on code in PR #13402:
URL: https://github.com/apache/arrow/pull/13402#discussion_r904343035
##
python/pyarrow/tests/test_pandas.py:
##
@@ -149,6 +149,12 @@ def test_non_string_columns(self):
table = pa.Table.from_pandas(df)
assert table.fie
viirya commented on PR #1914:
URL: https://github.com/apache/arrow-rs/pull/1914#issuecomment-1163659143
Seems some unrelated errors in interop test between Go and C#:
```
# FAILURES #
FAILED TEST: datetime Go producing, C# consuming
1 failures
wjones127 commented on PR #13404:
URL: https://github.com/apache/arrow/pull/13404#issuecomment-1163658023
(I created docs follow up: https://issues.apache.org/jira/browse/ARROW-16887)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
jeroen commented on PR #13404:
URL: https://github.com/apache/arrow/pull/13404#issuecomment-1163655426
I think `find_package()` is supposed to shell out to `pkg-config --cflags
libcurl` and `pkg-config --libs libcurl` which should automatically include the
macro and static libraries when ne
nealrichardson commented on PR #13404:
URL: https://github.com/apache/arrow/pull/13404#issuecomment-1163637187
For the R Windows packages, I need to use a static libcurl, and stack
overflow tells me that I need to define `CURL_STATICLIB` for the
google-cloud-cpp build. (The thing I just pus
Yuhta commented on issue #13367:
URL: https://github.com/apache/arrow/issues/13367#issuecomment-1163616382
https://issues.apache.org/jira/browse/ARROW-16886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Johnnathanalmeida commented on PR #13421:
URL: https://github.com/apache/arrow/pull/13421#issuecomment-1163616250
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
arjunsr1 commented on issue #13396:
URL: https://github.com/apache/arrow/issues/13396#issuecomment-1163632271
This works- thanks! I'll close the issue then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #13421:
URL: https://github.com/apache/arrow/pull/13421#issuecomment-1163621089
Revision: 8438196a8b0f812e04acb496b7b7f81e9581aa07
Submitted crossbow builds: [ursacomputing/crossbow @
actions-a4b2411d59](https://github.com/ursacomputing/crossbow/bra
arjunsr1 closed issue #13396: Is the Arrow::Table.merge function in a working
state?
URL: https://github.com/apache/arrow/issues/13396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
kou commented on issue #13396:
URL: https://github.com/apache/arrow/issues/13396#issuecomment-1163596808
Could you use the former code in
https://github.com/apache/arrow/issues/13396#issuecomment-1162676527 for now?
We'll release a new version in 2022-07 or 2022-08.
See also: Preparing
kou merged PR #13418:
URL: https://github.com/apache/arrow/pull/13418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on PR #13418:
URL: https://github.com/apache/arrow/pull/13418#issuecomment-1163593949
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
kou merged PR #13417:
URL: https://github.com/apache/arrow/pull/13417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on PR #13417:
URL: https://github.com/apache/arrow/pull/13417#issuecomment-1163593473
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
kou merged PR #13308:
URL: https://github.com/apache/arrow/pull/13308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on code in PR #13308:
URL: https://github.com/apache/arrow/pull/13308#discussion_r904216776
##
docs/source/developers/release.rst:
##
@@ -130,23 +181,28 @@ These are the different steps that are required to create
a release candidate.
# after you complete the
viirya commented on code in PR #1914:
URL: https://github.com/apache/arrow-rs/pull/1914#discussion_r904210422
##
arrow/src/util/decimal.rs:
##
@@ -17,109 +17,201 @@
//! Decimal related utils
-use std::cmp::Ordering;
+use crate::error::{ArrowError, Result};
+use num::bigint:
viirya commented on code in PR #1914:
URL: https://github.com/apache/arrow-rs/pull/1914#discussion_r904204855
##
arrow/src/util/decimal.rs:
##
@@ -17,109 +17,201 @@
//! Decimal related utils
-use std::cmp::Ordering;
+use crate::error::{ArrowError, Result};
+use num::bigint:
viirya commented on code in PR #1914:
URL: https://github.com/apache/arrow-rs/pull/1914#discussion_r901987661
##
arrow/src/util/decimal.rs:
##
@@ -17,109 +17,201 @@
//! Decimal related utils
-use std::cmp::Ordering;
+use crate::error::{ArrowError, Result};
+use num::bigint:
codecov-commenter commented on PR #2772:
URL:
https://github.com/apache/arrow-datafusion/pull/2772#issuecomment-1163564865
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_
nealrichardson commented on code in PR #13404:
URL: https://github.com/apache/arrow/pull/13404#discussion_r904189404
##
r/src/filesystem.cpp:
##
@@ -331,3 +337,77 @@ std::string fs___S3FileSystem__region(const
std::shared_ptr& f
}
#endif
+
+#if defined(ARROW_R_WITH_GCS)
+
+
iChauster commented on PR #13366:
URL: https://github.com/apache/arrow/pull/13366#issuecomment-1163546329
@westonpace , I think this is ready for another round of review. I've
packaged some of the helpful benchmarking code into `benchmark_util.h`, and
have expanded our filter benchmarks. Gi
viirya commented on code in PR #1922:
URL: https://github.com/apache/arrow-rs/pull/1922#discussion_r904175802
##
arrow/src/compute/kernels/cast.rs:
##
@@ -72,9 +72,9 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
// cast one decimal type t
viirya opened a new issue, #1923:
URL: https://github.com/apache/arrow-rs/issues/1923
**Describe the bug**
We allow casting from other datatypes to NullType (see `can_cast_types`). I
suspect that this is a mistake.
For example, Spark doesn't allow casting from any datatypes to
iChauster commented on code in PR #13366:
URL: https://github.com/apache/arrow/pull/13366#discussion_r904166211
##
cpp/src/arrow/compute/exec/filter_benchmark.cc:
##
@@ -0,0 +1,168 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
viirya commented on code in PR #1922:
URL: https://github.com/apache/arrow-rs/pull/1922#discussion_r904163992
##
arrow/src/compute/kernels/cast.rs:
##
@@ -72,9 +72,9 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
// cast one decimal type t
mrob95 opened a new pull request, #2772:
URL: https://github.com/apache/arrow-datafusion/pull/2772
# Which issue does this PR close?
Follows from #2736 and #2765
# Rationale for this change
These functions were redundant with `ExprVisitor` and `ExprRewriter`
markweissman commented on issue #13408:
URL: https://github.com/apache/arrow/issues/13408#issuecomment-1163529320
@amol- Thanks much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
amol- commented on issue #13408:
URL: https://github.com/apache/arrow/issues/13408#issuecomment-1163515796
Well, usually `NULL` values represent missing / unknown values thus there is
no way to match them against anything else. So it's usually the common
behaviour to exclude Null keys.
amol- closed issue #13408: Pyarrow join handles nulls differently than pandas
merge.
URL: https://github.com/apache/arrow/issues/13408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
github-actions[bot] commented on PR #13404:
URL: https://github.com/apache/arrow/pull/13404#issuecomment-1163508561
Revision: 4d789f06e0a4eb6621f42bb85784c12b41a8375d
Submitted crossbow builds: [ursacomputing/crossbow @
actions-f35855420a](https://github.com/ursacomputing/crossbow/bra
nealrichardson commented on PR #13404:
URL: https://github.com/apache/arrow/pull/13404#issuecomment-1163507517
@github-actions crossbow submit homebrew-r-autobrew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
iChauster commented on code in PR #13366:
URL: https://github.com/apache/arrow/pull/13366#discussion_r904131551
##
cpp/src/arrow/compute/exec/filter_benchmark.cc:
##
@@ -0,0 +1,176 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
viirya commented on code in PR #1922:
URL: https://github.com/apache/arrow-rs/pull/1922#discussion_r904128739
##
arrow/src/compute/kernels/cast.rs:
##
@@ -72,9 +72,9 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
// cast one decimal type t
viirya commented on code in PR #1922:
URL: https://github.com/apache/arrow-rs/pull/1922#discussion_r904128383
##
arrow/src/compute/kernels/cast.rs:
##
@@ -72,9 +72,9 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
// cast one decimal type t
wjones127 commented on PR #12775:
URL: https://github.com/apache/arrow/pull/12775#issuecomment-1163488614
I have refactored this PR to only create an example, rebased so that the
RecordBatchBuilder changes are separated, and rewrote most of the prose in the
example.
--
This is an automat
github-actions[bot] commented on PR #13411:
URL: https://github.com/apache/arrow/pull/13411#issuecomment-1163480151
Revision: b60fab37d4c57febc19b79d16584c2b01d471d6e
Submitted crossbow builds: [ursacomputing/crossbow @
actions-6468332506](https://github.com/ursacomputing/crossbow/bra
assignUser commented on PR #13411:
URL: https://github.com/apache/arrow/pull/13411#issuecomment-1163478660
@github-actions crossbow submit r-nightly-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
wjones127 commented on issue #13408:
URL: https://github.com/apache/arrow/issues/13408#issuecomment-1163470295
cc @amol-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
wjones127 commented on issue #13422:
URL: https://github.com/apache/arrow/issues/13422#issuecomment-1163469798
I'm not 100% sure about Intel -> M1, but we do use M1 -> Intel in our Python
packaging (which builds C++ with vcpkg for dependencies):
https://github.com/apache/arrow/blob/master/d
github-actions[bot] commented on PR #13421:
URL: https://github.com/apache/arrow/pull/13421#issuecomment-1163469295
Revision: a86c6bd1559c6509f1dc4e953ac3c0880c2411e1
Submitted crossbow builds: [ursacomputing/crossbow @
actions-40794fe81b](https://github.com/ursacomputing/crossbow/bra
Johnnathanalmeida commented on PR #13421:
URL: https://github.com/apache/arrow/pull/13421#issuecomment-1163468036
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jayhomn-bitquill opened a new issue, #13422:
URL: https://github.com/apache/arrow/issues/13422
Does arrow currently support cross building for M1 Macs? (Intel -> M1). For
more context, we are currently also using a package manager called vcpkg with
the associated arm64-osx triplet
--
Th
github-actions[bot] commented on PR #13421:
URL: https://github.com/apache/arrow/pull/13421#issuecomment-1163445256
Revision: a86c6bd1559c6509f1dc4e953ac3c0880c2411e1
Submitted crossbow builds: [ursacomputing/crossbow @
actions-32999fc89f](https://github.com/ursacomputing/crossbow/bra
Johnnathanalmeida commented on PR #13421:
URL: https://github.com/apache/arrow/pull/13421#issuecomment-1163442928
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #13421:
URL: https://github.com/apache/arrow/pull/13421#issuecomment-1163416954
:warning: Ticket **has not been started in JIRA**, please click 'Start
Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
github-actions[bot] commented on PR #13421:
URL: https://github.com/apache/arrow/pull/13421#issuecomment-1163416927
https://issues.apache.org/jira/browse/ARROW-16881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-actions[bot] commented on PR #13411:
URL: https://github.com/apache/arrow/pull/13411#issuecomment-1163415782
Revision: c3728123cfbcd43c36d1feecb286e3272695aca3
Submitted crossbow builds: [ursacomputing/crossbow @
actions-c2197d2cb0](https://github.com/ursacomputing/crossbow/bra
assignUser commented on PR #13411:
URL: https://github.com/apache/arrow/pull/13411#issuecomment-1163414204
@github-actions crossbow submit r-nightly-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
github-actions[bot] commented on PR #13421:
URL: https://github.com/apache/arrow/pull/13421#issuecomment-1163412291
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue
Johnnathanalmeida opened a new pull request, #13421:
URL: https://github.com/apache/arrow/pull/13421
Fix error in LLVM where didn't find these two functions.
Fix regex to allow negative digits for Interval Year.
--
This is an automated message from the Apache Git Service.
To respond
1 - 100 of 219 matches
Mail list logo
