palak-9202 commented on code in PR #13428:
URL: https://github.com/apache/arrow/pull/13428#discussion_r919698275
##
cpp/src/gandiva/gdv_function_stubs.cc:
##
@@ -611,6 +611,51 @@ int32_t gdv_fn_cast_intervalyear_utf8_int32(int64_t
context_ptr, int64_t holder_
auto* holder =
palak-9202 commented on code in PR #13428:
URL: https://github.com/apache/arrow/pull/13428#discussion_r919694197
##
cpp/src/gandiva/gdv_function_stubs_test.cc:
##
@@ -993,4 +993,61 @@ TEST(TestGdvFnStubs, TestTranslate) {
EXPECT_EQ(expected, std::string(result, out_len));
}
liurenjie1024 commented on issue #2633:
URL:
https://github.com/apache/arrow-datafusion/issues/2633#issuecomment-1182809782
@andygrove @alamb PTAL when you are available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
djnavarro commented on PR #12154:
URL: https://github.com/apache/arrow/pull/12154#issuecomment-1182809818
Thanks @rok! Yes, help with resolving conflicts on the C++ code would be
appreciated if you can spare the time. I'm hoping to take care of the remaining
issues on the R side later this
cyb70289 commented on code in PR #13583:
URL: https://github.com/apache/arrow/pull/13583#discussion_r919682027
##
cpp/src/arrow/util/hashing.h:
##
@@ -428,6 +428,22 @@ class ScalarMemoTable : public MemoTable {
value, [](int32_t i) {}, [](int32_t i) {}, out_memo_index);
kou merged PR #13579:
URL: https://github.com/apache/arrow/pull/13579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on code in PR #13428:
URL: https://github.com/apache/arrow/pull/13428#discussion_r919659653
##
cpp/src/gandiva/gdv_function_stubs_test.cc:
##
@@ -993,4 +993,61 @@ TEST(TestGdvFnStubs, TestTranslate) {
EXPECT_EQ(expected, std::string(result, out_len));
}
+TEST
github-actions[bot] commented on PR #13591:
URL: https://github.com/apache/arrow/pull/13591#issuecomment-1182773191
:warning: Ticket **has not been started in JIRA**, please click 'Start
Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
github-actions[bot] commented on PR #13591:
URL: https://github.com/apache/arrow/pull/13591#issuecomment-1182773179
https://issues.apache.org/jira/browse/ARROW-17046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mirkhosro opened a new pull request, #13591:
URL: https://github.com/apache/arrow/pull/13591
This patch is an attempt to make the documentation of
`pyarrow.parquet.write_to_dataset` function clearer so that the user can easily
learn
- Which parameters are used by the new code path and wh
codecov-commenter commented on PR #2893:
URL:
https://github.com/apache/arrow-datafusion/pull/2893#issuecomment-1182771886
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2893?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_
kou merged PR #13590:
URL: https://github.com/apache/arrow/pull/13590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on PR #13590:
URL: https://github.com/apache/arrow/pull/13590#issuecomment-1182764966
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
Ted-Jiang commented on code in PR #2044:
URL: https://github.com/apache/arrow-rs/pull/2044#discussion_r919644656
##
parquet/src/file/serialized_reader.rs:
##
@@ -481,6 +505,22 @@ pub struct SerializedPageReader {
// Column chunk type.
physical_type: Type,
+
+// t
comphead commented on PR #2893:
URL:
https://github.com/apache/arrow-datafusion/pull/2893#issuecomment-1182756614
@alamb you mentioned in #2840 the encoding/decoding issue still exists,
please give more details, I'll try to fix it in this PR
--
This is an automated message from the Apach
comphead closed pull request #2840: Preserve list element name
URL: https://github.com/apache/arrow-datafusion/pull/2840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
comphead opened a new pull request, #2893:
URL: https://github.com/apache/arrow-datafusion/pull/2893
# Which issue does this PR close?
Closes #2450 .
# Rationale for this change
# What changes are included in this PR?
Preserve list element name
# Ar
projjal commented on code in PR #13446:
URL: https://github.com/apache/arrow/pull/13446#discussion_r919630065
##
cpp/src/gandiva/projector.cc:
##
@@ -75,6 +92,17 @@ Status Projector::Make(SchemaPtr schema, const
ExpressionVector& exprs,
// Verify if previous projector obj co
liukun4515 opened a new issue, #85:
URL: https://github.com/apache/arrow-ballista/issues/85
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
As a distributed query engine, many sql query will submit to the scheduler,
and the schedu
projjal commented on code in PR #13446:
URL: https://github.com/apache/arrow/pull/13446#discussion_r919624157
##
cpp/src/gandiva/filter.cc:
##
@@ -37,8 +37,15 @@ Filter::Filter(std::unique_ptr
llvm_generator, SchemaPtr schema,
Filter::~Filter() {}
+Status Filter::Make(Sche
codecov-commenter commented on PR #2892:
URL:
https://github.com/apache/arrow-datafusion/pull/2892#issuecomment-1182733897
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2892?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_
Ted-Jiang commented on code in PR #2044:
URL: https://github.com/apache/arrow-rs/pull/2044#discussion_r919620826
##
parquet/src/file/serialized_reader.rs:
##
@@ -526,6 +543,34 @@ impl SerializedPageReader {
page_offset_index: None,
seen_num_data_pages:
Ted-Jiang commented on code in PR #2044:
URL: https://github.com/apache/arrow-rs/pull/2044#discussion_r919620637
##
parquet/src/file/serialized_reader.rs:
##
@@ -481,6 +505,22 @@ pub struct SerializedPageReader {
// Column chunk type.
physical_type: Type,
+
+// t
Ted-Jiang commented on code in PR #2044:
URL: https://github.com/apache/arrow-rs/pull/2044#discussion_r919618461
##
parquet/src/file/serialized_reader.rs:
##
@@ -526,6 +543,34 @@ impl SerializedPageReader {
page_offset_index: None,
seen_num_data_pages:
Ted-Jiang commented on code in PR #2044:
URL: https://github.com/apache/arrow-rs/pull/2044#discussion_r919617920
##
parquet/src/file/serialized_reader.rs:
##
@@ -526,6 +543,34 @@ impl SerializedPageReader {
page_offset_index: None,
seen_num_data_pages:
Ted-Jiang commented on code in PR #2044:
URL: https://github.com/apache/arrow-rs/pull/2044#discussion_r919617920
##
parquet/src/file/serialized_reader.rs:
##
@@ -526,6 +543,34 @@ impl SerializedPageReader {
page_offset_index: None,
seen_num_data_pages:
Ted-Jiang commented on code in PR #2044:
URL: https://github.com/apache/arrow-rs/pull/2044#discussion_r919616909
##
parquet/src/file/serialized_reader.rs:
##
@@ -498,9 +566,23 @@ impl SerializedPageReader {
seen_num_values: 0,
decompressor,
tustvold commented on code in PR #2892:
URL: https://github.com/apache/arrow-datafusion/pull/2892#discussion_r919610004
##
datafusion/proto/src/lib.rs:
##
@@ -75,19 +78,32 @@ mod roundtrip_tests {
use std::fmt::Formatter;
use std::sync::Arc;
+#[cfg(feature = "ser
tustvold commented on code in PR #2892:
URL: https://github.com/apache/arrow-datafusion/pull/2892#discussion_r919610004
##
datafusion/proto/src/lib.rs:
##
@@ -75,19 +78,32 @@ mod roundtrip_tests {
use std::fmt::Formatter;
use std::sync::Arc;
+#[cfg(feature = "ser
tustvold opened a new pull request, #2892:
URL: https://github.com/apache/arrow-datafusion/pull/2892
# Which issue does this PR close?
Closes #2889
# Rationale for this change
This provides a way to serialize the datafusion-proto messages to any serde
serializer, e.g. J
codecov-commenter commented on PR #2044:
URL: https://github.com/apache/arrow-rs/pull/2044#issuecomment-1182711168
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2044?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S
andygrove commented on code in PR #2881:
URL: https://github.com/apache/arrow-datafusion/pull/2881#discussion_r919606784
##
benchmarks/src/bin/h2o.rs:
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
alexdesiqueira commented on PR #13144:
URL: https://github.com/apache/arrow/pull/13144#issuecomment-1182707497
@pitrou sorry about the delay as well, life got in the way
:slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please
alexdesiqueira commented on PR #13144:
URL: https://github.com/apache/arrow/pull/13144#issuecomment-1182706778
@pitrou sorry about the delay also; I'll try to fix it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ursabot commented on PR #2887:
URL:
https://github.com/apache/arrow-datafusion/pull/2887#issuecomment-1182705306
Benchmark runs are scheduled for baseline =
eed77a286cac497683ca38fd75b6a134455cb1c2 and contender =
6a5de4fe08597896ab6375e3e4b76c5744dcfba7.
6a5de4fe08597896ab6375e3e4b76c574
andygrove commented on code in PR #2881:
URL: https://github.com/apache/arrow-datafusion/pull/2881#discussion_r919602051
##
benchmarks/src/bin/h2o.rs:
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
andygrove closed issue #2886: It would be nice to have a way to generate unique
IDs in optimizer rules
URL: https://github.com/apache/arrow-datafusion/issues/2886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
andygrove merged PR #2887:
URL: https://github.com/apache/arrow-datafusion/pull/2887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
github-actions[bot] commented on PR #13590:
URL: https://github.com/apache/arrow/pull/13590#issuecomment-1182704153
:warning: Ticket **has not been started in JIRA**, please click 'Start
Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
github-actions[bot] commented on PR #13590:
URL: https://github.com/apache/arrow/pull/13590#issuecomment-1182704138
https://issues.apache.org/jira/browse/ARROW-17063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Ted-Jiang commented on code in PR #2044:
URL: https://github.com/apache/arrow-rs/pull/2044#discussion_r919599314
##
parquet/src/file/serialized_reader.rs:
##
@@ -481,6 +505,22 @@ pub struct SerializedPageReader {
// Column chunk type.
physical_type: Type,
+
+// t
codecov-commenter commented on PR #2041:
URL: https://github.com/apache/arrow-rs/pull/2041#issuecomment-1182690086
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2041?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S
HaoYang670 commented on PR #2041:
URL: https://github.com/apache/arrow-rs/pull/2041#issuecomment-1182684896
Hmm, the failure seems related to the CI env.
https://github.com/apache/arrow-rs/runs/7313219137?check_suite_focus=true#step:3:12
Also find the same failrue in https://github
tustvold commented on PR #2041:
URL: https://github.com/apache/arrow-rs/pull/2041#issuecomment-1182674582
> if the features=force_validate is set.
This is very much a testing only feature, this enables validation
**everywhere** and will absolutely tank performance. It is a MIRI-light
HaoYang670 commented on PR #2041:
URL: https://github.com/apache/arrow-rs/pull/2041#issuecomment-1182673187
> Looks good to me, although I am a little bit confused where we have ended
up w.r.t validating decimals in ArrayData
Thank you @tustvold. The decimal values will be validated i
westonpace commented on PR #13426:
URL: https://github.com/apache/arrow/pull/13426#issuecomment-1182655048
I'll take a closer look at this tomorrow. Another possibility for the
python/c++ discrepancy would be to move the benchmarks themselves into python.
I don't think we have any python
westonpace merged PR #13585:
URL: https://github.com/apache/arrow/pull/13585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.ap
kaoutherab commented on PR #12706:
URL: https://github.com/apache/arrow/pull/12706#issuecomment-1182635329
Sure, I'll follow up on this. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
andygrove commented on issue #2890:
URL:
https://github.com/apache/arrow-datafusion/issues/2890#issuecomment-1182632382
@alamb DataFusion is inconsistent with itself as to when it adds implicit
conversions or not. I think it would be better to not have implicit conversions
at all and keep
ursabot commented on PR #2047:
URL: https://github.com/apache/arrow-rs/pull/2047#issuecomment-1182596785
Benchmark runs are scheduled for baseline =
a2f223c7d9ca525192550ff8e044a3e1b5dabeb0 and contender =
88e0de5d661def7d7a45e4bc51314a366d017dda.
88e0de5d661def7d7a45e4bc51314a366d017dda i
kou merged PR #13580:
URL: https://github.com/apache/arrow/pull/13580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
tustvold closed issue #2046: Don't double-count nulls in
write_batch_with_statistics
URL: https://github.com/apache/arrow-rs/issues/2046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
tustvold merged PR #2047:
URL: https://github.com/apache/arrow-rs/pull/2047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apa
andygrove commented on issue #2890:
URL:
https://github.com/apache/arrow-datafusion/issues/2890#issuecomment-1182585938
Postgres doe not add implicit casts in any of these cases:
```
andy=# select * from type_test where c0 = c1;
ERROR: operator does not exist: integer = charact
drin commented on PR #13583:
URL: https://github.com/apache/arrow/pull/13583#issuecomment-1182562069
I just realized that this introduces (or maybe just exposes) a bug when
calling this function on scalar inputs. If the input is a scalar, `non_nulls`
is incremented without changing state. T
lidavidm commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r919474247
##
cpp/src/arrow/filesystem/gcsfs_test.cc:
##
@@ -106,8 +110,27 @@ class GcsTestbench : public ::testing::Environment {
continue;
}
- server_proc
michalursa commented on code in PR #13493:
URL: https://github.com/apache/arrow/pull/13493#discussion_r919465384
##
cpp/src/arrow/compute/exec/hash_join_benchmark.cc:
##
@@ -132,7 +134,7 @@ class JoinBenchmark {
left_keys, *r_batches_with_schema.
alamb commented on PR #2875:
URL:
https://github.com/apache/arrow-datafusion/pull/2875#issuecomment-1182543735
Update: Doing it properly in
https://github.com/apache/arrow-datafusion/pull/2891 is showing good promise
--
This is an automated message from the Apache Git Service.
To respond
alamb opened a new pull request, #2891:
URL: https://github.com/apache/arrow-datafusion/pull/2891
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/2874
Closes https://github.com/apache/arrow-datafusion/pull/2875
Closes https://github.com/
andygrove opened a new issue, #2890:
URL: https://github.com/apache/arrow-datafusion/issues/2890
**Describe the bug**
I have a table with an int32 and a string column.
```
❯ select c3, c4 from data limit 2;
++--+
| c3 | c4 |
+---
michalursa commented on code in PR #13493:
URL: https://github.com/apache/arrow/pull/13493#discussion_r919453444
##
cpp/src/arrow/compute/exec/swiss_join.h:
##
@@ -0,0 +1,758 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
wjones127 commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r919452500
##
cpp/src/arrow/filesystem/gcsfs_test.cc:
##
@@ -106,8 +110,27 @@ class GcsTestbench : public ::testing::Environment {
continue;
}
- server_pro
wjones127 commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r919452500
##
cpp/src/arrow/filesystem/gcsfs_test.cc:
##
@@ -106,8 +110,27 @@ class GcsTestbench : public ::testing::Environment {
continue;
}
- server_pro
wjones127 commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r919452500
##
cpp/src/arrow/filesystem/gcsfs_test.cc:
##
@@ -106,8 +110,27 @@ class GcsTestbench : public ::testing::Environment {
continue;
}
- server_pro
wjones127 commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r919451986
##
cpp/src/arrow/filesystem/gcsfs_test.cc:
##
@@ -106,8 +110,27 @@ class GcsTestbench : public ::testing::Environment {
continue;
}
- server_pro
codecov-commenter commented on PR #2056:
URL: https://github.com/apache/arrow-rs/pull/2056#issuecomment-1182528686
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2056?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S
jhorstmann commented on issue #2054:
URL: https://github.com/apache/arrow-rs/issues/2054#issuecomment-1182527781
Sounds good, especially forcing users to specify both item and nested
capacities for List/String/Binary arrays. My gut feeling also says that 1024
could be a good default, I'm as
michalursa commented on code in PR #13493:
URL: https://github.com/apache/arrow/pull/13493#discussion_r919450010
##
cpp/src/arrow/compute/exec/swiss_join.cc:
##
@@ -0,0 +1,2545 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
lidavidm commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r919446134
##
cpp/src/arrow/filesystem/gcsfs_test.cc:
##
@@ -106,8 +110,27 @@ class GcsTestbench : public ::testing::Environment {
continue;
}
- server_proc
toddfarmer commented on code in PR #13543:
URL: https://github.com/apache/arrow/pull/13543#discussion_r919442634
##
docs/source/java/jdbc.rst:
##
@@ -0,0 +1,169 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the
wjones127 commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r919441252
##
cpp/src/arrow/filesystem/gcsfs_test.cc:
##
@@ -106,8 +110,27 @@ class GcsTestbench : public ::testing::Environment {
continue;
}
- server_pro
jhorstmann opened a new pull request, #2056:
URL: https://github.com/apache/arrow-rs/pull/2056
# Which issue does this PR close?
Closes #2055.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing c
jhorstmann opened a new issue, #2055:
URL: https://github.com/apache/arrow-rs/issues/2055
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
Similar to #1856, `BooleanArray::from_iter` currently always initializes and
returns a n
michalursa commented on code in PR #13493:
URL: https://github.com/apache/arrow/pull/13493#discussion_r919430595
##
cpp/src/arrow/compute/exec/hash_join_node.cc:
##
@@ -708,8 +736,26 @@ class HashJoinNode : public ExecNode {
// Generate output schema
std::shared_ptr ou
Dandandan commented on code in PR #2881:
URL: https://github.com/apache/arrow-datafusion/pull/2881#discussion_r919429668
##
benchmarks/src/bin/h2o.rs:
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
viirya commented on code in PR #2040:
URL: https://github.com/apache/arrow-rs/pull/2040#discussion_r919426839
##
arrow/src/ipc/writer.rs:
##
@@ -894,12 +1031,66 @@ fn write_array_data(
Some(buffer) => buffer.clone(),
};
-offset = write_buffer(&nul
lidavidm commented on code in PR #13543:
URL: https://github.com/apache/arrow/pull/13543#discussion_r919426886
##
docs/source/java/jdbc.rst:
##
@@ -0,0 +1,169 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the N
github-actions[bot] commented on PR #13584:
URL: https://github.com/apache/arrow/pull/13584#issuecomment-1182498910
https://issues.apache.org/jira/browse/ARROW-17059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
westonpace commented on PR #13584:
URL: https://github.com/apache/arrow/pull/13584#issuecomment-1182497958
> Am I reading this correctly that it's basically reverting the change to
cpp/src/arrow/compute/exec/expression_benchmark.cc in
https://github.com/apache/arrow/pull/13179
There
lidavidm merged PR #13558:
URL: https://github.com/apache/arrow/pull/13558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apac
andygrove commented on issue #2879:
URL:
https://github.com/apache/arrow-datafusion/issues/2879#issuecomment-1182496621
Related to https://github.com/apache/arrow-datafusion/issues/147
fyi @Dandandan @matthewmturner
--
This is an automated message from the Apache Git Service.
To r
github-actions[bot] commented on PR #13588:
URL: https://github.com/apache/arrow/pull/13588#issuecomment-1182495438
https://issues.apache.org/jira/browse/ARROW-16759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jonkeane merged PR #13584:
URL: https://github.com/apache/arrow/pull/13584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apac
jonkeane commented on PR #13584:
URL: https://github.com/apache/arrow/pull/13584#issuecomment-1182492924
Are these failures cause the baseline is failing?
> [Failed ⬇️0.0% ⬆️0.0%]
[test-mac-arm](https://conbench.ursa.dev/compare/runs/6dc38255446041b4ba0089e4c1c211f5...7d9cf2453f7049dc
viirya commented on code in PR #2040:
URL: https://github.com/apache/arrow-rs/pull/2040#discussion_r919419568
##
arrow/src/ipc/writer.rs:
##
@@ -894,12 +1031,66 @@ fn write_array_data(
Some(buffer) => buffer.clone(),
};
-offset = write_buffer(&nul
github-actions[bot] commented on PR #13587:
URL: https://github.com/apache/arrow/pull/13587#issuecomment-1182492784
https://issues.apache.org/jira/browse/ARROW-16759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
codecov-commenter commented on PR #2887:
URL:
https://github.com/apache/arrow-datafusion/pull/2887#issuecomment-1182491941
#
[Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2887?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_
michalursa commented on code in PR #13493:
URL: https://github.com/apache/arrow/pull/13493#discussion_r919418542
##
cpp/src/arrow/compute/exec/partition_util.h:
##
@@ -118,6 +118,43 @@ class PartitionLocks {
/// \brief Release a partition so that other threads can work on it
nealrichardson commented on code in PR #13577:
URL: https://github.com/apache/arrow/pull/13577#discussion_r919416810
##
r/R/io.R:
##
@@ -241,7 +241,7 @@ mmap_open <- function(path, mode = c("read", "write",
"readwrite")) {
make_readable_file <- function(file, mmap = TRUE, comp
icexelloss commented on code in PR #13426:
URL: https://github.com/apache/arrow/pull/13426#discussion_r919412017
##
cpp/src/arrow/compute/exec/asof_join_benchmark.cc:
##
@@ -0,0 +1,1023 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
nealrichardson commented on code in PR #13577:
URL: https://github.com/apache/arrow/pull/13577#discussion_r919416391
##
r/R/io.R:
##
@@ -241,7 +241,7 @@ mmap_open <- function(path, mode = c("read", "write",
"readwrite")) {
make_readable_file <- function(file, mmap = TRUE, comp
icexelloss commented on code in PR #13426:
URL: https://github.com/apache/arrow/pull/13426#discussion_r919412017
##
cpp/src/arrow/compute/exec/asof_join_benchmark.cc:
##
@@ -0,0 +1,1023 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
icexelloss commented on code in PR #13426:
URL: https://github.com/apache/arrow/pull/13426#discussion_r919412017
##
cpp/src/arrow/compute/exec/asof_join_benchmark.cc:
##
@@ -0,0 +1,1023 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
icexelloss commented on code in PR #13426:
URL: https://github.com/apache/arrow/pull/13426#discussion_r919412017
##
cpp/src/arrow/compute/exec/asof_join_benchmark.cc:
##
@@ -0,0 +1,1023 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
icexelloss commented on code in PR #13426:
URL: https://github.com/apache/arrow/pull/13426#discussion_r919412017
##
cpp/src/arrow/compute/exec/asof_join_benchmark.cc:
##
@@ -0,0 +1,1023 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
icexelloss commented on code in PR #13426:
URL: https://github.com/apache/arrow/pull/13426#discussion_r919412017
##
cpp/src/arrow/compute/exec/asof_join_benchmark.cc:
##
@@ -0,0 +1,1023 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
avantgardnerio commented on issue #2889:
URL:
https://github.com/apache/arrow-datafusion/issues/2889#issuecomment-1182484987
As a potential implementation option, we could use something like
https://docs.serde.rs/serde_json/ with our existing visitor pattern. I know
some folks are reticent
lidavidm commented on PR #13589:
URL: https://github.com/apache/arrow/pull/13589#issuecomment-1182484408
TODOs:
- [ ] Add documentation
- [ ] Are we handling time/timestamp types properly when time zones come
into play?
- [ ] Add date support as well
--
This is an automated messa
lidavidm opened a new pull request, #13589:
URL: https://github.com/apache/arrow/pull/13589
This extends the arrow-jdbc adapter to also allow taking Arrow data and
using it to bind JDBC PreparedStatement parameters, allowing you to "round
trip" data to a certain extent. This was factored ou
avantgardnerio opened a new issue, #2889:
URL: https://github.com/apache/arrow-datafusion/issues/2889
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
A significant portion of my time on #2885 was spent manually formatting
subq
1 - 100 of 378 matches
Mail list logo
