[GitHub] [arrow-rs] jiacai2050 opened a new issue, #2491: add into_inner method to ArrowWriter

2022-08-17 Thread GitBox
jiacai2050 opened a new issue, #2491: URL: https://github.com/apache/arrow-rs/issues/2491 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** For now, there is no way to retrieve `Writer` passed into `ArrowWriter` back, this mean

[GitHub] [arrow] ursabot commented on pull request #13769: ARROW-12590: [C++][R] Update copies of Homebrew files to reflect recent updates

2022-08-17 Thread GitBox
ursabot commented on PR #13769: URL: https://github.com/apache/arrow/pull/13769#issuecomment-1219055894 Benchmark runs are scheduled for baseline = 8474ee5a3ed725d4bb56c75fc1b13a53cba1fd1f and contender = 70c67086c01bb1b64c19e3f46382574bd554dcf1. 70c67086c01bb1b64c19e3f46382574bd554dcf1 is

[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2478: Add ChunkReader::get_bytes

2022-08-17 Thread GitBox
Ted-Jiang commented on code in PR #2478: URL: https://github.com/apache/arrow-rs/pull/2478#discussion_r948663929 ## parquet/src/file/serialized_reader.rs: ## @@ -623,26 +627,13 @@ impl PageReader for SerializedPageReader { let page_len = front.compressed_

[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2478: Add ChunkReader::get_bytes

2022-08-17 Thread GitBox
Ted-Jiang commented on code in PR #2478: URL: https://github.com/apache/arrow-rs/pull/2478#discussion_r948662091 ## parquet/src/file/serialized_reader.rs: ## @@ -623,26 +627,13 @@ impl PageReader for SerializedPageReader { let page_len = front.compressed_

[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2478: Add ChunkReader::get_bytes

2022-08-17 Thread GitBox
Ted-Jiang commented on code in PR #2478: URL: https://github.com/apache/arrow-rs/pull/2478#discussion_r948662091 ## parquet/src/file/serialized_reader.rs: ## @@ -623,26 +627,13 @@ impl PageReader for SerializedPageReader { let page_len = front.compressed_

[GitHub] [arrow] github-actions[bot] commented on pull request #13876: ARROW-17409: [Packaging][RPM][GLib] *-glib-libs should have .typelib and *-glib-devel should have .gir

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13876: URL: https://github.com/apache/arrow/pull/13876#issuecomment-1219052470 Revision: 635084557b53206b3eb4c8cc35ffc5fe435c9112 Submitted crossbow builds: [ursacomputing/crossbow @ actions-dc77eebc79](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] kou commented on pull request #13876: ARROW-17409: [Packaging][RPM][GLib] *-glib-libs should have .typelib and *-glib-devel should have .gir

2022-08-17 Thread GitBox
kou commented on PR #13876: URL: https://github.com/apache/arrow/pull/13876#issuecomment-1219051961 @github-actions crossbow submit almalinux-* amazon-linux-* centos-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] github-actions[bot] commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1219046968 Revision: b1c170c1c0e1d4f8bbd3a207ea16613017025301 Submitted crossbow builds: [ursacomputing/crossbow @ actions-a5c87865c8](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] kou commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-17 Thread GitBox
kou commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1219046555 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] github-actions[bot] commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1219045406 Revision: d1ee05e3cd3a7ab5197b7ee896ac6b1cb6a07f03 Submitted crossbow builds: [ursacomputing/crossbow @ actions-dffe65f69a](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] kou commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-17 Thread GitBox
kou commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1219044911 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2460: Support skip_page missing OffsetIndex Fallback in SerializedPageReader

2022-08-17 Thread GitBox
Ted-Jiang commented on code in PR #2460: URL: https://github.com/apache/arrow-rs/pull/2460#discussion_r948635496 ## parquet/src/file/serialized_reader.rs: ## @@ -480,13 +480,17 @@ pub(crate) fn decode_page( Ok(result) } +#[allow(clippy::large_enum_variant)] Review Comme

[GitHub] [arrow-rs] Ted-Jiang closed pull request #2460: Support skip_page missing OffsetIndex Fallback in SerializedPageReader

2022-08-17 Thread GitBox
Ted-Jiang closed pull request #2460: Support skip_page missing OffsetIndex Fallback in SerializedPageReader URL: https://github.com/apache/arrow-rs/pull/2460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2460: Support skip_page missing OffsetIndex Fallback in SerializedPageReader

2022-08-17 Thread GitBox
Ted-Jiang commented on code in PR #2460: URL: https://github.com/apache/arrow-rs/pull/2460#discussion_r948630306 ## parquet/src/file/serialized_reader.rs: ## @@ -480,13 +480,17 @@ pub(crate) fn decode_page( Ok(result) } +#[allow(clippy::large_enum_variant)] Review Comme

[GitHub] [arrow] github-actions[bot] commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1219018641 Revision: dad23b89a205351eef17a987a27059dd44933e74 Submitted crossbow builds: [ursacomputing/crossbow @ actions-c11eb30126](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] github-actions[bot] commented on pull request #13876: ARROW-17409: [Packaging][RPM][GLib] *-glib-libs should have .typelib and *-glib-devel should have .gir

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13876: URL: https://github.com/apache/arrow/pull/13876#issuecomment-1219018485 Revision: 64b335d89c4d1b36fda0d9f4cfba1195f290bfa0 Submitted crossbow builds: [ursacomputing/crossbow @ actions-6ea2a32f3f](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] kou commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-17 Thread GitBox
kou commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1219016024 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] kou commented on pull request #13876: ARROW-17409: [Packaging][RPM][GLib] *-glib-libs should have .typelib and *-glib-devel should have .gir

2022-08-17 Thread GitBox
kou commented on PR #13876: URL: https://github.com/apache/arrow/pull/13876#issuecomment-1219015886 @github-actions crossbow submit almalinux-* amazon-linux-* centos-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] ursabot commented on pull request #13908: MINOR: [CI][Java] Speed up JNI build

2022-08-17 Thread GitBox
ursabot commented on PR #13908: URL: https://github.com/apache/arrow/pull/13908#issuecomment-1219004724 ['Python', 'R'] benchmarks have high level of regressions. [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3680efebac0a4df2b8116812530ce9ca...7efa17dc79d64f39be1b04fb81616659/)

[GitHub] [arrow] ursabot commented on pull request #13908: MINOR: [CI][Java] Speed up JNI build

2022-08-17 Thread GitBox
ursabot commented on PR #13908: URL: https://github.com/apache/arrow/pull/13908#issuecomment-1219004611 Benchmark runs are scheduled for baseline = 4fa40072a776662fdb48e99e7671784b1ee12545 and contender = 8474ee5a3ed725d4bb56c75fc1b13a53cba1fd1f. 8474ee5a3ed725d4bb56c75fc1b13a53cba1fd1f is

[GitHub] [arrow] cyb70289 commented on a diff in pull request #13907: MINOR: Fix docstrings for kleene boolean scalar funcs

2022-08-17 Thread GitBox
cyb70289 commented on code in PR #13907: URL: https://github.com/apache/arrow/pull/13907#discussion_r948617733 ## cpp/src/arrow/compute/kernels/scalar_boolean.cc: ## @@ -467,10 +467,10 @@ const FunctionDoc or_kleene_doc{ "Logical 'or' boolean values (Kleene logic)", ("

[GitHub] [arrow-datafusion] andygrove commented on pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-17 Thread GitBox
andygrove commented on PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#issuecomment-1218968134 @sarahyurick I tried some `expr IS TRUE` type queries in Postgres and it only supports the case where `expr` is a boolean type. Does Dask SQL have different behavior to this?

[GitHub] [arrow] ZMZ91 commented on pull request #13838: ARROW-17382: [C++] open_dataset doesn't ignore BOM in csv file when header's with quotes

2022-08-17 Thread GitBox
ZMZ91 commented on PR #13838: URL: https://github.com/apache/arrow/pull/13838#issuecomment-1218939407 Hi @pitrou, could you help review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow-rs] liukun4515 closed pull request #2357: [WIP]Change precision of decimal without validation

2022-08-17 Thread GitBox
liukun4515 closed pull request #2357: [WIP]Change precision of decimal without validation URL: https://github.com/apache/arrow-rs/pull/2357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [arrow-rs] liukun4515 commented on pull request #2357: [WIP]Change precision of decimal without validation

2022-08-17 Thread GitBox
liukun4515 commented on PR #2357: URL: https://github.com/apache/arrow-rs/pull/2357#issuecomment-1218910380 > What is the status of this PR? This pr will be closed. I am ready to file some small sub-pr to push this forward. -- This is an automated message from the Apache Git Serv

[GitHub] [arrow-datafusion] liukun4515 commented on issue #3031: optimize/simplify the literal data type and remove unnecessary cast、try_cast

2022-08-17 Thread GitBox
liukun4515 commented on issue #3031: URL: https://github.com/apache/arrow-datafusion/issues/3031#issuecomment-1218909474 > > The cast is added in the creation of physical expr/physical plan. > > Yes I agree > > It sounds like you are proposing moving the coercion to the logical

[GitHub] [arrow-ballista] yahoNanJing commented on issue #132: Redefine the executor task slots

2022-08-17 Thread GitBox
yahoNanJing commented on issue #132: URL: https://github.com/apache/arrow-ballista/issues/132#issuecomment-1218907415 @thinkharderdev and I had a short sync up. We can firstly working on #130. Then flesh out the task slots management -- This is an automated message from the Apache Git Ser

[GitHub] [arrow] ConeyLiu commented on pull request #13815: ARROW-17338: [Java] The maximum request memory of BaseVariableWidthVector should limit to Integer.MAX_VALUE

2022-08-17 Thread GitBox
ConeyLiu commented on PR #13815: URL: https://github.com/apache/arrow/pull/13815#issuecomment-1218906755 Thanks, @pitrou for merging this. And also thanks to everyone for the time to review this. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [arrow-cookbook] mystic-lama opened a new pull request, #247: [WIP] Added license to r module

2022-08-17 Thread GitBox
mystic-lama opened a new pull request, #247: URL: https://github.com/apache/arrow-cookbook/pull/247 Second attempt to add License to r module. Excluded index.rmd as it was creating local build failure -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [arrow-datafusion] liukun4515 commented on issue #3031: optimize/simplify the literal data type and remove unnecessary cast、try_cast

2022-08-17 Thread GitBox
liukun4515 commented on issue #3031: URL: https://github.com/apache/arrow-datafusion/issues/3031#issuecomment-1218905298 > +1 for optimization rules to perform type coercion in the logical plan. I am running into some issues around this myself and am seeing quite a lot of inconsistencies i

[GitHub] [arrow] github-actions[bot] commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1218900335 Revision: 1369c1ab6cc54173d9ad415e8bb9d2f830468c26 Submitted crossbow builds: [ursacomputing/crossbow @ actions-9502630c4f](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] github-actions[bot] commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1218899519 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] github-actions[bot] commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1218899479 https://issues.apache.org/jira/browse/ARROW-17081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] kou commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-17 Thread GitBox
kou commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1218899211 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] ursabot commented on pull request #13815: ARROW-17338: [Java] The maximum request memory of BaseVariableWidthVector should limit to Integer.MAX_VALUE

2022-08-17 Thread GitBox
ursabot commented on PR #13815: URL: https://github.com/apache/arrow/pull/13815#issuecomment-1218881922 ['Python', 'R'] benchmarks have high level of regressions. [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/41d22303eead41269feb8bb559b222cf...3680efebac0a4df2b8116812530ce9ca/)

[GitHub] [arrow] ursabot commented on pull request #13815: ARROW-17338: [Java] The maximum request memory of BaseVariableWidthVector should limit to Integer.MAX_VALUE

2022-08-17 Thread GitBox
ursabot commented on PR #13815: URL: https://github.com/apache/arrow/pull/13815#issuecomment-1218881336 Benchmark runs are scheduled for baseline = f0688d01c465417e6f3515f9344154ad6f47ba22 and contender = 4fa40072a776662fdb48e99e7671784b1ee12545. 4fa40072a776662fdb48e99e7671784b1ee12545 is

[GitHub] [arrow] kou merged pull request #13740: ARROW-17233: [Packaging][Linux] Update artifact patterns

2022-08-17 Thread GitBox
kou merged PR #13740: URL: https://github.com/apache/arrow/pull/13740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow] kou merged pull request #13769: ARROW-12590: [C++][R] Update copies of Homebrew files to reflect recent updates

2022-08-17 Thread GitBox
kou merged PR #13769: URL: https://github.com/apache/arrow/pull/13769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow] kou commented on pull request #13769: ARROW-12590: [C++][R] Update copies of Homebrew files to reflect recent updates

2022-08-17 Thread GitBox
kou commented on PR #13769: URL: https://github.com/apache/arrow/pull/13769#issuecomment-1218684344 It seems to be working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] ursabot commented on pull request #13783: ARROW-17289: [C++] Add type category membership checks

2022-08-17 Thread GitBox
ursabot commented on PR #13783: URL: https://github.com/apache/arrow/pull/13783#issuecomment-1218654316 Benchmark runs are scheduled for baseline = cef68940c68ac2f3167cc6cafe5eefdd9f7fab79 and contender = f0688d01c465417e6f3515f9344154ad6f47ba22. f0688d01c465417e6f3515f9344154ad6f47ba22 is

github@arrow.apache.org

2022-08-17 Thread GitBox
kou commented on PR #13874: URL: https://github.com/apache/arrow/pull/13874#issuecomment-1218648758 Sure. Reference: DISCUSS: [C++] Switch to C++17 https://lists.apache.org/thread/9g14n3odhj6kzsgjxr6k6d3q73hg2njr -- This is an automated message from the Apache Git Service. To res

[GitHub] [arrow-rs] thinkharderdev commented on a diff in pull request #2490: Fallback for skip_page/peek_page without OffsetIndex in SerializedPag…

2022-08-17 Thread GitBox
thinkharderdev commented on code in PR #2490: URL: https://github.com/apache/arrow-rs/pull/2490#discussion_r948501910 ## parquet/src/file/serialized_reader.rs: ## @@ -484,13 +484,17 @@ pub(crate) fn decode_page( Ok(result) } +#[allow(clippy::large_enum_variant)] Review

[GitHub] [arrow-rs] thinkharderdev commented on a diff in pull request #2490: Fallback for skip_page/peek_page without OffsetIndex in SerializedPag…

2022-08-17 Thread GitBox
thinkharderdev commented on code in PR #2490: URL: https://github.com/apache/arrow-rs/pull/2490#discussion_r948501196 ## parquet/src/arrow/arrow_reader/selection.rs: ## @@ -119,6 +119,7 @@ impl RowSelection { } /// Given an offset index, return the offset ranges for

[GitHub] [arrow] github-actions[bot] commented on pull request #13910: ARROW-17456: [Go] Mark the compute module as a separate sub-module

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13910: URL: https://github.com/apache/arrow/pull/13910#issuecomment-1218561897 https://issues.apache.org/jira/browse/ARROW-17456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #13910: ARROW-17456: [Go] Mark the compute module as a separate sub-module

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13910: URL: https://github.com/apache/arrow/pull/13910#issuecomment-1218561907 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] zeroshade opened a new pull request, #13910: ARROW-17456: [Go] Mark the compute module as a separate sub-module

2022-08-17 Thread GitBox
zeroshade opened a new pull request, #13910: URL: https://github.com/apache/arrow/pull/13910 I noticed looking at pkg.go.dev that there really isn't anyone who is using the existing `compute` module, which makes sense since it isn't really finished and only provides limited utility currentl

[GitHub] [arrow] github-actions[bot] commented on pull request #13909: ARROW-17455: [Go] Initial Compute Framework [WIP]

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13909: URL: https://github.com/apache/arrow/pull/13909#issuecomment-1218557444 https://issues.apache.org/jira/browse/ARROW-17455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #13909: ARROW-17455: [Go] Initial Compute Framework [WIP]

2022-08-17 Thread GitBox
github-actions[bot] commented on PR #13909: URL: https://github.com/apache/arrow/pull/13909#issuecomment-1218557463 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] lidavidm commented on pull request #13898: ARROW-17254: [C++][Go][Java][FlightRPC] Implement and test Flight SQL GetSchema

2022-08-17 Thread GitBox
lidavidm commented on PR #13898: URL: https://github.com/apache/arrow/pull/13898#issuecomment-1218557358 Thankfully Go is straightforward! And yeah, they're in the spec and in Java, but got omitted from C++ (whoops) -- This is an automated message from the Apache Git Service. To res

[GitHub] [arrow-rs] thinkharderdev opened a new pull request, #2490: Fallback for skip_page/peek_page without OffsetIndex in SerializedPag…

2022-08-17 Thread GitBox
thinkharderdev opened a new pull request, #2490: URL: https://github.com/apache/arrow-rs/pull/2490 …eReader # Which issue does this PR close? Closes #2459 # Rationale for this change Need to be able to peek/skip pages even if we do not have an Offs

[GitHub] [arrow] igor-suhorukov commented on a diff in pull request #13906: ARROW-17430: [Java] ListBinder to bind Arrow List type to DB column

2022-08-17 Thread GitBox
igor-suhorukov commented on code in PR #13906: URL: https://github.com/apache/arrow/pull/13906#discussion_r948465760 ## java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/binder/ListBinder.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [arrow-datafusion] andygrove commented on pull request #3126: [WIP] Changes needed to support recent sqlparser handling of LIKE

2022-08-17 Thread GitBox
andygrove commented on PR #3126: URL: https://github.com/apache/arrow-datafusion/pull/3126#issuecomment-1218522532 Blocked for now, waiting for https://github.com/sqlparser-rs/sqlparser-rs/pull/579 to get merged -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [arrow] ursabot commented on pull request #13893: ARROW-16861: [Rust][Integration] Enable IP compression for Rust

2022-08-17 Thread GitBox
ursabot commented on PR #13893: URL: https://github.com/apache/arrow/pull/13893#issuecomment-1218511072 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/bd38b0f9e452482b8ce691c85c8018da...6dd9ef2bf47b442a91d458273513bf10/)

[GitHub] [arrow] ursabot commented on pull request #13893: ARROW-16861: [Rust][Integration] Enable IP compression for Rust

2022-08-17 Thread GitBox
ursabot commented on PR #13893: URL: https://github.com/apache/arrow/pull/13893#issuecomment-1218510847 Benchmark runs are scheduled for baseline = 951663a41c183c8fec5a4da9a8f9daf45ed85451 and contender = cef68940c68ac2f3167cc6cafe5eefdd9f7fab79. cef68940c68ac2f3167cc6cafe5eefdd9f7fab79 is

[GitHub] [arrow-datafusion] sarahyurick commented on a diff in pull request #3189: [DRAFT] Support "IS TRUE/FALSE" syntax

2022-08-17 Thread GitBox
sarahyurick commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r948428333 ## datafusion/common/src/scalar.rs: ## @@ -726,6 +726,15 @@ impl ScalarValue { } } +/// whether this value is true or not. +pub fn i

[GitHub] [arrow-datafusion] sarahyurick commented on a diff in pull request #3189: [DRAFT] Support "IS TRUE/FALSE" syntax

2022-08-17 Thread GitBox
sarahyurick commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r948424016 ## datafusion/physical-expr/src/expressions/is_true.rs: ## @@ -0,0 +1,140 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [arrow-datafusion] sarahyurick commented on a diff in pull request #3189: [DRAFT] Support "IS TRUE/FALSE" syntax

2022-08-17 Thread GitBox
sarahyurick commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r948424016 ## datafusion/physical-expr/src/expressions/is_true.rs: ## @@ -0,0 +1,140 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [arrow-datafusion] sarahyurick opened a new pull request, #3189: [DRAFT] Support "IS TRUE/FALSE" syntax

2022-08-17 Thread GitBox
sarahyurick opened a new pull request, #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189 # Which issue does this PR close? Closes #3159 # What changes are included in this PR? So far, I've added some basic changes so that IS TRUE works on a scalar (`ColumnarValue

[GitHub] [arrow] marsupialtail commented on pull request #13662: ARROW-14635: [Python][C++] implement fadvise

2022-08-17 Thread GitBox
marsupialtail commented on PR #13662: URL: https://github.com/apache/arrow/pull/13662#issuecomment-1218484157 I measured this on my Systems76 Gazelle laptop with Samsung NVME SSD 970 EVO plus and 32 GB of RAM. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] rok commented on pull request #13501: ARROW-16695: [R][Python][C++] Extension types are not supported in joins

2022-08-17 Thread GitBox
rok commented on PR #13501: URL: https://github.com/apache/arrow/pull/13501#issuecomment-1218472052 Thanks for the explanation @michalursa! That makes a lot of sense! @westonpace could I ask you or someone in vicinity to this code for review? :) -- This is an automated message

[GitHub] [arrow] lidavidm commented on pull request #13800: ARROW-7744: [Java][FlightRPC] JDBC Driver for Arrow Flight SQL

2022-08-17 Thread GitBox
lidavidm commented on PR #13800: URL: https://github.com/apache/arrow/pull/13800#issuecomment-1218470577 Looks like this still doesn't build, I'll take another look soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] anjakefala commented on pull request #13652: ARROW-17131: [Python] add StructType().field(): returns a field by name or index

2022-08-17 Thread GitBox
anjakefala commented on PR #13652: URL: https://github.com/apache/arrow/pull/13652#issuecomment-1218463796 Added the `[]` test case back =) https://github.com/apache/arrow/compare/231f2b3c4d93c0bd3e61288165d1847f83142bdb..add10bdc632f7a064120489fe37f3d950cd4683b -- This is an automated me

[GitHub] [arrow] ursabot commented on pull request #13821: ARROW-13763: [Python] Close files in ParquetFile & ParquetDatasetPiece

2022-08-17 Thread GitBox
ursabot commented on PR #13821: URL: https://github.com/apache/arrow/pull/13821#issuecomment-1218463667 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/946f9431fd7747fbbd40b59be50adf48...bd38b0f9e452482b8ce691c85c8018da/)

[GitHub] [arrow] ursabot commented on pull request #13821: ARROW-13763: [Python] Close files in ParquetFile & ParquetDatasetPiece

2022-08-17 Thread GitBox
ursabot commented on PR #13821: URL: https://github.com/apache/arrow/pull/13821#issuecomment-1218463480 Benchmark runs are scheduled for baseline = b0422e5feb6d335f8e726f6221d42f2a044cd02c and contender = 951663a41c183c8fec5a4da9a8f9daf45ed85451. 951663a41c183c8fec5a4da9a8f9daf45ed85451 is

[GitHub] [arrow] milesgranger commented on pull request #13904: ARROW-17389: [Python] Exclude conftest and tests when PYARROW_INSTALL_TESTS=0

2022-08-17 Thread GitBox
milesgranger commented on PR #13904: URL: https://github.com/apache/arrow/pull/13904#issuecomment-1218437487 Bare with me, I have it working locally, just need to sort out CI discrepancies. 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [arrow-rs] tustvold commented on pull request #2489: Make filter module public

2022-08-17 Thread GitBox
tustvold commented on PR #2489: URL: https://github.com/apache/arrow-rs/pull/2489#issuecomment-1218424943 No worries at all, thank you for double-checking 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] michalursa commented on pull request #13501: ARROW-16695: [R][Python][C++] Extension types are not supported in joins

2022-08-17 Thread GitBox
michalursa commented on PR #13501: URL: https://github.com/apache/arrow/pull/13501#issuecomment-1218423588 > With the current changes in this PR, it fails in ` RowEncoder::Init`, which also would need to be updated to handle ExtensionTypes (delegating to the storage type). > > What I

[GitHub] [arrow-rs] thinkharderdev closed pull request #2489: Make filter module public

2022-08-17 Thread GitBox
thinkharderdev closed pull request #2489: Make filter module public URL: https://github.com/apache/arrow-rs/pull/2489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [arrow-rs] thinkharderdev commented on pull request #2489: Make filter module public

2022-08-17 Thread GitBox
thinkharderdev commented on PR #2489: URL: https://github.com/apache/arrow-rs/pull/2489#issuecomment-1218420065 Sigh, ignore me... brain is apparently not working today :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] ksuarez1423 commented on a diff in pull request #13859: ARROW-17377: [C++][Docs] Adds tutorial for basic Arrow, file access, compute, and datasets

2022-08-17 Thread GitBox
ksuarez1423 commented on code in PR #13859: URL: https://github.com/apache/arrow/pull/13859#discussion_r948341830 ## cpp/examples/tutorial_examples/dataset_example.cc: ## @@ -0,0 +1,169 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lic

[GitHub] [arrow-rs] tustvold commented on pull request #2489: Make filter module public

2022-08-17 Thread GitBox
tustvold commented on PR #2489: URL: https://github.com/apache/arrow-rs/pull/2489#issuecomment-1218413318 It is re-exported a couple of lines down, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] arjunsr1 commented on issue #13847: Arrow::Table.save(path_to_file.parquet) changes data types within Schema.

2022-08-17 Thread GitBox
arjunsr1 commented on issue #13847: URL: https://github.com/apache/arrow/issues/13847#issuecomment-1218406304 Thanks for all the help, @kou . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow] arjunsr1 closed issue #13847: Arrow::Table.save(path_to_file.parquet) changes data types within Schema.

2022-08-17 Thread GitBox
arjunsr1 closed issue #13847: Arrow::Table.save(path_to_file.parquet) changes data types within Schema. URL: https://github.com/apache/arrow/issues/13847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] lidavidm commented on a diff in pull request #13857: ARROW-9773: [C++] Implement Take kernel for ChunkedArray

2022-08-17 Thread GitBox
lidavidm commented on code in PR #13857: URL: https://github.com/apache/arrow/pull/13857#discussion_r948331309 ## cpp/src/arrow/compute/kernels/vector_selection.cc: ## @@ -530,6 +683,54 @@ Status PrimitiveTake(KernelContext* ctx, const ExecSpan& batch, ExecResult* out) retur

[GitHub] [arrow] pitrou commented on a diff in pull request #13857: ARROW-9773: [C++] Implement Take kernel for ChunkedArray

2022-08-17 Thread GitBox
pitrou commented on code in PR #13857: URL: https://github.com/apache/arrow/pull/13857#discussion_r948330188 ## cpp/src/arrow/compute/kernels/vector_selection.cc: ## @@ -530,6 +683,54 @@ Status PrimitiveTake(KernelContext* ctx, const ExecSpan& batch, ExecResult* out) return

[GitHub] [arrow] pitrou commented on a diff in pull request #13857: ARROW-9773: [C++] Implement Take kernel for ChunkedArray

2022-08-17 Thread GitBox
pitrou commented on code in PR #13857: URL: https://github.com/apache/arrow/pull/13857#discussion_r948330624 ## cpp/src/arrow/compute/kernels/vector_selection.cc: ## @@ -530,6 +683,54 @@ Status PrimitiveTake(KernelContext* ctx, const ExecSpan& batch, ExecResult* out) return

[GitHub] [arrow] wjones127 commented on a diff in pull request #13857: ARROW-9773: [C++] Implement Take kernel for ChunkedArray

2022-08-17 Thread GitBox
wjones127 commented on code in PR #13857: URL: https://github.com/apache/arrow/pull/13857#discussion_r948330700 ## cpp/src/arrow/compute/kernels/vector_selection.cc: ## @@ -530,6 +683,54 @@ Status PrimitiveTake(KernelContext* ctx, const ExecSpan& batch, ExecResult* out) retu

[GitHub] [arrow] pitrou commented on a diff in pull request #13857: ARROW-9773: [C++] Implement Take kernel for ChunkedArray

2022-08-17 Thread GitBox
pitrou commented on code in PR #13857: URL: https://github.com/apache/arrow/pull/13857#discussion_r948328578 ## cpp/src/arrow/compute/kernels/vector_selection.cc: ## @@ -365,6 +370,122 @@ struct PrimitiveTakeImpl { } out_arr->null_count = out_arr->length - valid_count;

[GitHub] [arrow] lidavidm commented on a diff in pull request #13857: ARROW-9773: [C++] Implement Take kernel for ChunkedArray

2022-08-17 Thread GitBox
lidavidm commented on code in PR #13857: URL: https://github.com/apache/arrow/pull/13857#discussion_r948328088 ## cpp/src/arrow/compute/kernels/vector_selection.cc: ## @@ -530,6 +683,54 @@ Status PrimitiveTake(KernelContext* ctx, const ExecSpan& batch, ExecResult* out) retur

[GitHub] [arrow-rs] thinkharderdev opened a new pull request, #2489: Make filter module public

2022-08-17 Thread GitBox
thinkharderdev opened a new pull request, #2489: URL: https://github.com/apache/arrow-rs/pull/2489 # Which issue does this PR close? Closes #. # Rationale for this change Recently made `with_row_filter` public in `ArrowReaderBuilder` but there is no way

[GitHub] [arrow-rs] thinkharderdev commented on pull request #2489: Make filter module public

2022-08-17 Thread GitBox
thinkharderdev commented on PR #2489: URL: https://github.com/apache/arrow-rs/pull/2489#issuecomment-1218400038 @tustvold I'm assuming this was an oversight but if this was left private for a reason we can close this PR -- This is an automated message from the Apache Git Service. To respo

[GitHub] [arrow] pitrou commented on a diff in pull request #13857: ARROW-9773: [C++] Implement Take kernel for ChunkedArray

2022-08-17 Thread GitBox
pitrou commented on code in PR #13857: URL: https://github.com/apache/arrow/pull/13857#discussion_r948326162 ## cpp/src/arrow/compute/kernels/vector_selection.cc: ## @@ -530,6 +683,54 @@ Status PrimitiveTake(KernelContext* ctx, const ExecSpan& batch, ExecResult* out) return

[GitHub] [arrow] pitrou merged pull request #13908: MINOR: [CI][Java] Speed up JNI build

2022-08-17 Thread GitBox
pitrou merged PR #13908: URL: https://github.com/apache/arrow/pull/13908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

[GitHub] [arrow] pitrou commented on pull request #13908: MINOR: [CI][Java] Speed up JNI build

2022-08-17 Thread GitBox
pitrou commented on PR #13908: URL: https://github.com/apache/arrow/pull/13908#issuecomment-1218386410 Will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [arrow] pitrou commented on pull request #13908: MINOR: [CI][Java] Speed up JNI build

2022-08-17 Thread GitBox
pitrou commented on PR #13908: URL: https://github.com/apache/arrow/pull/13908#issuecomment-1218386230 Passing build here: https://github.com/pitrou/arrow/runs/7885171489?check_suite_focus=true#step:6:2511 Note how the C++ build phase is down to 21 minutes without cache, while it could t

[GitHub] [arrow] pitrou merged pull request #13815: ARROW-17338: [Java] The maximum request memory of BaseVariableWidthVector should limit to Integer.MAX_VALUE

2022-08-17 Thread GitBox
pitrou merged PR #13815: URL: https://github.com/apache/arrow/pull/13815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

[GitHub] [arrow] pitrou commented on pull request #13908: MINOR: [CI][Java] Speed up JNI build

2022-08-17 Thread GitBox
pitrou commented on PR #13908: URL: https://github.com/apache/arrow/pull/13908#issuecomment-1218354493 cc @assignUser @lwhite1 @davisusanibar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] lidavidm commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-17 Thread GitBox
lidavidm commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r948277546 ## docs/source/cpp/flight.rst: ## @@ -172,6 +172,110 @@ request/response. On the server, they can inspect incoming headers and fail the request; hence, they can be us

[GitHub] [arrow] pitrou opened a new pull request, #13908: MINOR: [CI][Java] Speed up JNI build

2022-08-17 Thread GitBox
pitrou opened a new pull request, #13908: URL: https://github.com/apache/arrow/pull/13908 Currently, Java JNI builds on Github Actions can take one hour due to a very long Arrow C++ build phase. Disable unused Arrow C++ components so as to make the C++ build faster. -- This is an a

[GitHub] [arrow] ursabot commented on pull request #13899: ARROW-17435: [CI][Python][CUDA] Install Numba for CUDA interop tests

2022-08-17 Thread GitBox
ursabot commented on PR #13899: URL: https://github.com/apache/arrow/pull/13899#issuecomment-1218352205 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/65290c5d2c0143399dc499e7b5aa1aed...946f9431fd7747fbbd40b59be50adf48/)

[GitHub] [arrow] ursabot commented on pull request #13899: ARROW-17435: [CI][Python][CUDA] Install Numba for CUDA interop tests

2022-08-17 Thread GitBox
ursabot commented on PR #13899: URL: https://github.com/apache/arrow/pull/13899#issuecomment-1218351946 Benchmark runs are scheduled for baseline = 42ed37e3fc84465f365531e611f1bf632b599e7b and contender = b0422e5feb6d335f8e726f6221d42f2a044cd02c. b0422e5feb6d335f8e726f6221d42f2a044cd02c is

[GitHub] [arrow] g302ge commented on issue #13424: Update Plasma Buffer failed

2022-08-17 Thread GitBox
g302ge commented on issue #13424: URL: https://github.com/apache/arrow/issues/13424#issuecomment-1218345514 > > When I have updated the arrow::plasma project to support some features in our business. > > Can you explain what this means exactly? > > Also, regardless, Plasma is c

[GitHub] [arrow] g302ge closed issue #13866: How can I use arrow in my project as a git submodule

2022-08-17 Thread GitBox
g302ge closed issue #13866: How can I use arrow in my project as a git submodule URL: https://github.com/apache/arrow/issues/13866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [arrow] wjones127 commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-17 Thread GitBox
wjones127 commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r945843007 ## docs/source/cpp/flight.rst: ## @@ -172,6 +172,108 @@ request/response. On the server, they can inspect incoming headers and fail the request; hence, they can be u

[GitHub] [arrow-datafusion] andygrove commented on issue #3187: `like_nlike_with_null_lt` fails with latest sqlparser code

2022-08-17 Thread GitBox
andygrove commented on issue #3187: URL: https://github.com/apache/arrow-datafusion/issues/3187#issuecomment-1218330316 Root cause: https://github.com/sqlparser-rs/sqlparser-rs/issues/578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] progger-dev commented on pull request #13901: ARROW-17255: [C++][Parquet] Add JSON canonical extension type

2022-08-17 Thread GitBox
progger-dev commented on PR #13901: URL: https://github.com/apache/arrow/pull/13901#issuecomment-1218304314 @pitrou Absolutely! That's fine. I was hoping that this PR would trigger that conversation. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [arrow-datafusion] andygrove opened a new issue, #3188: Re-implement parsing/planning for SHOW TABLES due to sqlparser changes

2022-08-17 Thread GitBox
andygrove opened a new issue, #3188: URL: https://github.com/apache/arrow-datafusion/issues/3188 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** We currently handle `SHOW TABLES` in in the planner when handling `Statement::ShowVar

[GitHub] [arrow] pitrou commented on pull request #13815: ARROW-17338: [Java] The maximum request memory of BaseVariableWidthVector should limit to Integer.MAX_VALUE

2022-08-17 Thread GitBox
pitrou commented on PR #13815: URL: https://github.com/apache/arrow/pull/13815#issuecomment-1218302754 Sorry for the delay @ConeyLiu . Given the several +1's I'm gonna merge if/when CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow-rs] psvri opened a new pull request, #2488: refactoring union builder apis

2022-08-17 Thread GitBox
psvri opened a new pull request, #2488: URL: https://github.com/apache/arrow-rs/pull/2488 # Which issue does this PR close? Partially implements #2054 # Rationale for this change Refactor apis to make a consistent new and with_capacity functions # What changes are

[GitHub] [arrow-datafusion] andygrove opened a new issue, #3187: `like_nlike_with_null_lt` fails with latest sqlparser code

2022-08-17 Thread GitBox
andygrove opened a new issue, #3187: URL: https://github.com/apache/arrow-datafusion/issues/3187 **Describe the bug** ``` thread 'sql::expr::like_nlike_with_null_lt' panicked at 'called `Result::unwrap()` on an `Err` value: "SQL(ParserError(\"Expected a concrete value, found: colu

  1   2   3   4   >