[GitHub] [arrow] kou commented on pull request #13920: ARROW-17451: [CI][Java] Use manylinux2014 image for JNI

2022-08-19 Thread GitBox
kou commented on PR #13920: URL: https://github.com/apache/arrow/pull/13920#issuecomment-1221246086 ccache statistics: https://github.com/apache/arrow/runs/7929238651?check_suite_focus=true#step:6:2308a ```text === ccache statistics before build === cache directory

[GitHub] [arrow] ursabot commented on pull request #13926: ARROW-17478: [C++][Java] Update ORC to 1.7.6

2022-08-19 Thread GitBox
ursabot commented on PR #13926: URL: https://github.com/apache/arrow/pull/13926#issuecomment-1221245794 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/35fc2e62229e44b0afdbc081b4e99a46...1ac00971220b4068bfe1e614afa0629f/)

[GitHub] [arrow] ursabot commented on pull request #13926: ARROW-17478: [C++][Java] Update ORC to 1.7.6

2022-08-19 Thread GitBox
ursabot commented on PR #13926: URL: https://github.com/apache/arrow/pull/13926#issuecomment-1221245766 Benchmark runs are scheduled for baseline = 28cf3f9f769dda11ddfe52bd316c96aecb656522 and contender = 80d79564945ab42f3fe9541a7da2fed9edabc541. 80d79564945ab42f3fe9541a7da2fed9edabc541 is

[GitHub] [arrow] github-actions[bot] commented on pull request #13920: ARROW-17451: [CI][Java] Use manylinux2014 image for JNI

2022-08-19 Thread GitBox
github-actions[bot] commented on PR #13920: URL: https://github.com/apache/arrow/pull/13920#issuecomment-1221245581 Revision: 64cf4c70fdeecc1eea56cab2105ae7da6d6d76dd Submitted crossbow builds: [ursacomputing/crossbow @ actions-afee36cc35](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] kou commented on a diff in pull request #13920: ARROW-17451: [CI][Java] Use manylinux2014 image for JNI

2022-08-19 Thread GitBox
kou commented on code in PR #13920: URL: https://github.com/apache/arrow/pull/13920#discussion_r950658921 ## ci/scripts/java_jni_macos_build.sh: ## @@ -41,9 +41,15 @@ install_dir=${build_dir}/cpp-install : ${ARROW_PLASMA:=ON} : ${ARROW_PYTHON:=OFF} : ${ARROW_S3:=ON} +: ${ARRO

[GitHub] [arrow] kou commented on pull request #13920: ARROW-17451: [CI][Java] Use manylinux2014 image for JNI

2022-08-19 Thread GitBox
kou commented on PR #13920: URL: https://github.com/apache/arrow/pull/13920#issuecomment-1221245475 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] dongjoon-hyun commented on pull request #13926: ARROW-17478: [C++][Java] Update ORC to 1.7.6

2022-08-19 Thread GitBox
dongjoon-hyun commented on PR #13926: URL: https://github.com/apache/arrow/pull/13926#issuecomment-1221237398 Thank you, @williamhyun and @kou ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] marsupialtail commented on pull request #13799: ARROW-17299: [C++][Python] Expose the Scanner kDefaultBatchReadahead and kDefaultFragmentReadahead parameters

2022-08-19 Thread GitBox
marsupialtail commented on PR #13799: URL: https://github.com/apache/arrow/pull/13799#issuecomment-1221236737 Don't think the failed checks have anything to do with me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [arrow] marsupialtail commented on pull request #13640: ARROW-14635: [Python][C++] add O_DIRECT support to writes

2022-08-19 Thread GitBox
marsupialtail commented on PR #13640: URL: https://github.com/apache/arrow/pull/13640#issuecomment-1221236445 Let's recap here -- we started from this PR, then we went to https://github.com/apache/arrow/pull/13662 because we think O_DIRECT is not needed. Turns out fadvise performance is bad

[GitHub] [arrow] kou merged pull request #13917: ARROW-17470: [CI][GLib] Add more system packages to sync the upstream PKGBUILD

2022-08-19 Thread GitBox
kou merged PR #13917: URL: https://github.com/apache/arrow/pull/13917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow] kou commented on pull request #13917: ARROW-17470: [CI][GLib] Add more system packages to sync the upstream PKGBUILD

2022-08-19 Thread GitBox
kou commented on PR #13917: URL: https://github.com/apache/arrow/pull/13917#issuecomment-1221232411 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [arrow] github-actions[bot] commented on pull request #13920: ARROW-17451: [CI][Java] Use manylinux2014 image for JNI

2022-08-19 Thread GitBox
github-actions[bot] commented on PR #13920: URL: https://github.com/apache/arrow/pull/13920#issuecomment-1221231843 Revision: 3e7930da2259f7fe52a940e2fefaa8c6b3b422f4 Submitted crossbow builds: [ursacomputing/crossbow @ actions-14ab753fc3](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] kou commented on pull request #13920: ARROW-17451: [CI][Java] Use manylinux2014 image for JNI

2022-08-19 Thread GitBox
kou commented on PR #13920: URL: https://github.com/apache/arrow/pull/13920#issuecomment-1221231690 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] kou commented on a diff in pull request #13920: ARROW-17451: [CI][Java] Use manylinux2014 image for JNI

2022-08-19 Thread GitBox
kou commented on code in PR #13920: URL: https://github.com/apache/arrow/pull/13920#discussion_r950249787 ## docker-compose.yml: ## @@ -1541,37 +1544,6 @@ services: /arrow/ci/scripts/java_build.sh /arrow /build && /arrow/ci/scripts/java_test.sh /arrow /build"

[GitHub] [arrow] kou merged pull request #13926: ARROW-17478: [C++][Java] Update ORC to 1.7.6

2022-08-19 Thread GitBox
kou merged PR #13926: URL: https://github.com/apache/arrow/pull/13926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow-datafusion] jklamer commented on pull request #3201: Use .get() to avoid panic

2022-08-19 Thread GitBox
jklamer commented on PR #3201: URL: https://github.com/apache/arrow-datafusion/pull/3201#issuecomment-1221217919 @alamb knowing where to test this was not immediately obvious to me + given there was the same issue in another place I refactored the functionality into common and tested it th

[GitHub] [arrow-datafusion] jklamer commented on pull request #3201: Use .get() to avoid panic

2022-08-19 Thread GitBox
jklamer commented on PR #3201: URL: https://github.com/apache/arrow-datafusion/pull/3201#issuecomment-1221203968 > Can you please add a regression test for this case? Whoops! misread the issue and thought there was one. Adding now! -- This is an automated message from the Apache Git Se

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950629418 ## go/arrow/flight/doc.go: ## @@ -0,0 +1,79 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE fil

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950629288 ## go/arrow/flight/doc.go: ## @@ -0,0 +1,79 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE fil

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950629194 ## go/arrow/flight/doc.go: ## @@ -0,0 +1,79 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE fil

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950629152 ## docs/source/cpp/flight.rst: ## @@ -172,6 +172,154 @@ request/response. On the server, they can inspect incoming headers and fail the request; hence, they can be used to

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950629084 ## docs/source/cpp/flight.rst: ## @@ -172,6 +172,154 @@ request/response. On the server, they can inspect incoming headers and fail the request; hence, they can be used to

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950628339 ## docs/source/cpp/flight.rst: ## @@ -172,6 +172,154 @@ request/response. On the server, they can inspect incoming headers and fail the request; hence, they can be used to

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950627765 ## docs/source/cpp/flight.rst: ## @@ -172,6 +172,154 @@ request/response. On the server, they can inspect incoming headers and fail the request; hence, they can be used to

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950627810 ## docs/source/cpp/flight.rst: ## @@ -172,6 +172,154 @@ request/response. On the server, they can inspect incoming headers and fail the request; hence, they can be used to

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950627734 ## docs/source/cpp/flight.rst: ## @@ -172,6 +172,154 @@ request/response. On the server, they can inspect incoming headers and fail the request; hence, they can be used to

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950627715 ## go/arrow/flight/doc.go: ## @@ -0,0 +1,98 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE fil

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950627669 ## docs/source/cpp/flight.rst: ## @@ -172,6 +172,110 @@ request/response. On the server, they can inspect incoming headers and fail the request; hence, they can be used to

[GitHub] [arrow] github-actions[bot] commented on pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
github-actions[bot] commented on PR #13873: URL: https://github.com/apache/arrow/pull/13873#issuecomment-1221195710 Revision: 1c4b615d8ef1f99fe3a5d426a0a96d72d6771447 Submitted crossbow builds: [ursacomputing/crossbow @ actions-703d0857cf](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950627624 ## docs/source/cpp/flight.rst: ## @@ -172,6 +172,110 @@ request/response. On the server, they can inspect incoming headers and fail the request; hence, they can be used to

[GitHub] [arrow] rok commented on pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on PR #13873: URL: https://github.com/apache/arrow/pull/13873#issuecomment-1221195476 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow-datafusion] kmitchener commented on pull request #3210: fix issue with now() returning same value across statements

2022-08-19 Thread GitBox
kmitchener commented on PR #3210: URL: https://github.com/apache/arrow-datafusion/pull/3210#issuecomment-1221195165 Actually, I'm going to make this a WIP because I tested with a now() in a view and that code path is still broken. Needs a more robust fix. Will pick it up again in a couple

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3212: MINOR: update cargo.lock and rust-version for datafusion-cli

2022-08-19 Thread GitBox
codecov-commenter commented on PR #3212: URL: https://github.com/apache/arrow-datafusion/pull/3212#issuecomment-1221194332 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3212?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow-datafusion] kmitchener opened a new pull request, #3212: MINOR: update cargo.lock and rust-version for datafusion-cli

2022-08-19 Thread GitBox
kmitchener opened a new pull request, #3212: URL: https://github.com/apache/arrow-datafusion/pull/3212 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? Cargo.lock for datafusion-cli out of

[GitHub] [arrow] ursabot commented on pull request #13913: ARROW-12958: [CI][Developer] Build + host the docs for PR branches

2022-08-19 Thread GitBox
ursabot commented on PR #13913: URL: https://github.com/apache/arrow/pull/13913#issuecomment-1221188047 Benchmark runs are scheduled for baseline = 4af3df0c85dff80e2afbce65f8268435fa327752 and contender = 28cf3f9f769dda11ddfe52bd316c96aecb656522. 28cf3f9f769dda11ddfe52bd316c96aecb656522 is

[GitHub] [arrow-datafusion] kmitchener commented on pull request #3210: fix issue with now() returning same value across statements

2022-08-19 Thread GitBox
kmitchener commented on PR #3210: URL: https://github.com/apache/arrow-datafusion/pull/3210#issuecomment-1221186787 Good thinking, docs updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow] rok commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
rok commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950618527 ## docs/source/cpp/flight.rst: ## @@ -172,6 +172,154 @@ request/response. On the server, they can inspect incoming headers and fail the request; hence, they can be used to

[GitHub] [arrow-datafusion] madihabdul commented on issue #3211: Add `CREATE VIEW` documentation to user guide

2022-08-19 Thread GitBox
madihabdul commented on issue #3211: URL: https://github.com/apache/arrow-datafusion/issues/3211#issuecomment-1221176993 Hi, I could take on this issue! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] westonpace commented on a diff in pull request #13932: MINOR: [C++] Fix StringFormatter type error in localfs_benchmark

2022-08-19 Thread GitBox
westonpace commented on code in PR #13932: URL: https://github.com/apache/arrow/pull/13932#discussion_r950611828 ## cpp/src/arrow/filesystem/localfs_benchmark.cc: ## @@ -66,7 +66,7 @@ class LocalFSFixture : public benchmark::Fixture { arrow::in

[GitHub] [arrow] westonpace commented on a diff in pull request #13931: ARROW-17481: [C++] [Python] Major performance improvements to CSV reading from S3

2022-08-19 Thread GitBox
westonpace commented on code in PR #13931: URL: https://github.com/apache/arrow/pull/13931#discussion_r950606781 ## cpp/src/arrow/csv/reader.cc: ## @@ -545,9 +546,10 @@ class BlockDecodingOperator { / // B

[GitHub] [arrow] drin opened a new pull request, #13932: MINOR: [C++] Fix StringFormatter type error in localfs_benchmark

2022-08-19 Thread GitBox
drin opened a new pull request, #13932: URL: https://github.com/apache/arrow/pull/13932 since size_t is passed as the first argument to the StringFormatter, it needs to be templated with DoubleType instead of Int32Type -- This is an automated message from the Apache Git Service. To resp

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2533: Compare dictionary with primitive array in `eq_dyn` and `neq_dyn`

2022-08-19 Thread GitBox
viirya commented on code in PR #2533: URL: https://github.com/apache/arrow-rs/pull/2533#discussion_r950601312 ## arrow/src/compute/kernels/comparison.rs: ## @@ -2173,45 +2270,28 @@ macro_rules! typed_dict_compares { }}; } -/// Helper function to perform boolean lambda fu

[GitHub] [arrow] westonpace commented on a diff in pull request #13799: ARROW-17299: [C++][Python] Expose the Scanner kDefaultBatchReadahead and kDefaultFragmentReadahead parameters

2022-08-19 Thread GitBox
westonpace commented on code in PR #13799: URL: https://github.com/apache/arrow/pull/13799#discussion_r950598812 ## cpp/src/arrow/dataset/scanner.h: ## @@ -384,6 +381,25 @@ class ARROW_DS_EXPORT ScannerBuilder { /// This option provides a control limiting the memory owned by

[GitHub] [arrow] assignUser commented on a diff in pull request #13925: ARROW-15481: [R] [CI] Add a crossbow job that mimics CRAN's old macOS

2022-08-19 Thread GitBox
assignUser commented on code in PR #13925: URL: https://github.com/apache/arrow/pull/13925#discussion_r950598957 ## dev/tasks/r/github.packages.yml: ## @@ -137,36 +137,48 @@ jobs: matrix: platform: - windows-latest - # This is newer than what

[GitHub] [arrow] westonpace commented on issue #13927: Why signed integer type is used for array sizes rather than unsigned?

2022-08-19 Thread GitBox
westonpace commented on issue #13927: URL: https://github.com/apache/arrow/issues/13927#issuecomment-1221140449 Mostly because Arrow needs to be compatible with as many languages as possible and some languages (e.g. Java) do not have a good representation for unsigned 64 bit integers.

[GitHub] [arrow] marsupialtail closed pull request #13662: ARROW-14635: [Python][C++] implement fadvise

2022-08-19 Thread GitBox
marsupialtail closed pull request #13662: ARROW-14635: [Python][C++] implement fadvise URL: https://github.com/apache/arrow/pull/13662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [arrow] marsupialtail opened a new pull request, #13931: ARROW-17481: [C++] [Python] Major performance improvements to CSV reading from S3

2022-08-19 Thread GitBox
marsupialtail opened a new pull request, #13931: URL: https://github.com/apache/arrow/pull/13931 Draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [arrow] github-actions[bot] commented on pull request #13931: ARROW-17481: [C++] [Python] Major performance improvements to CSV reading from S3

2022-08-19 Thread GitBox
github-actions[bot] commented on PR #13931: URL: https://github.com/apache/arrow/pull/13931#issuecomment-1221134659 https://issues.apache.org/jira/browse/ARROW-17481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #13931: ARROW-17481: [C++] [Python] Major performance improvements to CSV reading from S3

2022-08-19 Thread GitBox
github-actions[bot] commented on PR #13931: URL: https://github.com/apache/arrow/pull/13931#issuecomment-1221134670 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow-rs] viirya commented on issue #2534: Compare dictionary with non-dictionary arrays in comparison kernels

2022-08-19 Thread GitBox
viirya commented on issue #2534: URL: https://github.com/apache/arrow-rs/issues/2534#issuecomment-1221132876 Subtasks: - [ ] #2535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [arrow-rs] viirya opened a new issue, #2535: Compare dictionary with primitive array in eq_dyn and neq_dyn

2022-08-19 Thread GitBox
viirya opened a new issue, #2535: URL: https://github.com/apache/arrow-rs/issues/2535 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Part of #2534 to support comparison between dictionary and primitive array in eq_dyn and

[GitHub] [arrow-rs] viirya opened a new issue, #2534: Compare dictionary with non-dictionary arrays in comparison kernels

2022-08-19 Thread GitBox
viirya opened a new issue, #2534: URL: https://github.com/apache/arrow-rs/issues/2534 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Comparison kernels currently only support comparison among non-dictionary arrays and dic

[GitHub] [arrow] rok merged pull request #13913: ARROW-12958: [CI][Developer] Build + host the docs for PR branches

2022-08-19 Thread GitBox
rok merged PR #13913: URL: https://github.com/apache/arrow/pull/13913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow-rs] viirya opened a new pull request, #2533: Compare dictionary with primitive array in `eq_dyn` and `neq_dyn`

2022-08-19 Thread GitBox
viirya opened a new pull request, #2533: URL: https://github.com/apache/arrow-rs/pull/2533 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing changes?

[GitHub] [arrow-rs] thinkharderdev commented on a diff in pull request #2526: Use offset index in ParquetRecordBatchStream

2022-08-19 Thread GitBox
thinkharderdev commented on code in PR #2526: URL: https://github.com/apache/arrow-rs/pull/2526#discussion_r950582925 ## parquet/src/column/reader.rs: ## @@ -312,7 +312,7 @@ where // If page has less rows than the remaining records to // be sk

[GitHub] [arrow] github-actions[bot] commented on pull request #13930: ARROW-17482: [Go] Remove ValueDescr types

2022-08-19 Thread GitBox
github-actions[bot] commented on PR #13930: URL: https://github.com/apache/arrow/pull/13930#issuecomment-1221120970 https://issues.apache.org/jira/browse/ARROW-17482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #13929: ARROW-17479: [Go] Add ArraySpan and utilities

2022-08-19 Thread GitBox
github-actions[bot] commented on PR #13929: URL: https://github.com/apache/arrow/pull/13929#issuecomment-1221118238 https://issues.apache.org/jira/browse/ARROW-17479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] zeroshade opened a new pull request, #13929: ARROW-17479: [Go] Add ArraySpan and utilities

2022-08-19 Thread GitBox
zeroshade opened a new pull request, #13929: URL: https://github.com/apache/arrow/pull/13929 Relating to the building of the functionality for Compute in Go with Arrow, this is the implementation of ArraySpan / ExecValue / ExecResult etc. It was able to be separated out from the funct

[GitHub] [arrow-datafusion] sarahyurick commented on issue #3195: Support "IS [NOT] UNKNOWN" syntax

2022-08-19 Thread GitBox
sarahyurick commented on issue #3195: URL: https://github.com/apache/arrow-datafusion/issues/3195#issuecomment-1221093272 Sounds good to me - I'll also be opening a PR for #2265 after #3189 merges, so hopefully with both of our contributions we can get all of the boolean operations working

[GitHub] [arrow] sanatdeshpande1 opened a new issue, #13928: How to convert a Message into Uint8Array or ByteBuffer?

2022-08-19 Thread GitBox
sanatdeshpande1 opened a new issue, #13928: URL: https://github.com/apache/arrow/issues/13928 I have created a Message object and I want to serialize it into ByteBuffer. I am not able to find any method as such which can directly convert the Message into either a Uint8Array or ByteBuffer si

[GitHub] [arrow-datafusion] isidentical commented on issue #3195: Support "IS [NOT] UNKNOWN" syntax

2022-08-19 Thread GitBox
isidentical commented on issue #3195: URL: https://github.com/apache/arrow-datafusion/issues/3195#issuecomment-1221089349 Thanks a lot for your answer @sarahyurick! Really happy to work on it (I'll probably wait for #3189 to be merged first to send the PR, so we can reduce the number of co

[GitHub] [arrow] dongjoon-hyun commented on pull request #13926: ARROW-17478: [C++][Java] Update ORC to 1.7.6

2022-08-19 Thread GitBox
dongjoon-hyun commented on PR #13926: URL: https://github.com/apache/arrow/pull/13926#issuecomment-1221083961 Could you click `Start Process` at [ARROW-17478](https://issues.apache.org/jira/browse/ARROW-17478), @williamhyun ? -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow] nvartolomei opened a new issue, #13927: Why signed integer type is used for array sizes rather than unsigned?

2022-08-19 Thread GitBox
nvartolomei opened a new issue, #13927: URL: https://github.com/apache/arrow/issues/13927 Hi. I'm familiarising myself with the Arrow/Parquet ecosystem and though that a good starting point is reading their specs. The [Array lengths](https://arrow.apache.org/docs/format/Columnar.html

[GitHub] [arrow-datafusion] sarahyurick commented on a diff in pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-19 Thread GitBox
sarahyurick commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r950529018 ## datafusion/physical-expr/src/expressions/is_true.rs: ## @@ -0,0 +1,139 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [arrow-rs] tustvold commented on issue #2361: AmazonS3Builder::from_env to populate credentials from environment

2022-08-19 Thread GitBox
tustvold commented on issue #2361: URL: https://github.com/apache/arrow-rs/issues/2361#issuecomment-1221056856 Thank you for volunteering, I think option 2 makes the most sense. The idea is to get people up and running quickly, much like the standard AWS SDKs, not necessarily to expose the

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-19 Thread GitBox
andygrove commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r950526104 ## datafusion/physical-expr/src/expressions/is_false.rs: ## @@ -0,0 +1,139 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-19 Thread GitBox
andygrove commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r950519839 ## datafusion/physical-expr/src/expressions/is_true.rs: ## @@ -0,0 +1,139 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-19 Thread GitBox
andygrove commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r950525011 ## datafusion/physical-expr/src/expressions/is_true.rs: ## @@ -0,0 +1,139 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [arrow] zeroshade commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
zeroshade commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950522786 ## go/arrow/flight/doc.go: ## @@ -0,0 +1,79 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTI

[GitHub] [arrow] zeroshade commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
zeroshade commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950522169 ## go/arrow/flight/doc.go: ## @@ -0,0 +1,79 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTI

[GitHub] [arrow] zeroshade commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
zeroshade commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950520840 ## go/arrow/flight/doc.go: ## @@ -0,0 +1,79 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTI

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-19 Thread GitBox
andygrove commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r950520533 ## datafusion/physical-expr/src/expressions/is_true.rs: ## @@ -0,0 +1,139 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-19 Thread GitBox
andygrove commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r950519839 ## datafusion/physical-expr/src/expressions/is_true.rs: ## @@ -0,0 +1,139 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [arrow] zeroshade commented on a diff in pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-08-19 Thread GitBox
zeroshade commented on code in PR #13873: URL: https://github.com/apache/arrow/pull/13873#discussion_r950519650 ## go/arrow/flight/doc.go: ## @@ -0,0 +1,79 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTI

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-19 Thread GitBox
andygrove commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r950516458 ## datafusion/physical-expr/src/expressions/is_true.rs: ## @@ -0,0 +1,139 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [arrow-rs] roeap commented on pull request #2509: Replace azure sdk with custom implementation

2022-08-19 Thread GitBox
roeap commented on PR #2509: URL: https://github.com/apache/arrow-rs/pull/2509#issuecomment-1221040687 Turns out getting an oauth token, especially with a client secret is not all that complex... we have a working implementation now, that is to say it is working, how we go abut that can lik

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-19 Thread GitBox
andygrove commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r950513732 ## datafusion/physical-expr/src/expressions/is_false.rs: ## @@ -0,0 +1,143 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

[GitHub] [arrow-datafusion] andygrove opened a new issue, #3211: Add `CREATE VIEW` documentation to user guide

2022-08-19 Thread GitBox
andygrove opened a new issue, #3211: URL: https://github.com/apache/arrow-datafusion/issues/3211 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** In docs/source/user-guide/sql/ddl.md we do not show that we support CREATE VIEW.

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3209: Add support for inline column alias in CREATE VIEW

2022-08-19 Thread GitBox
andygrove commented on code in PR #3209: URL: https://github.com/apache/arrow-datafusion/pull/3209#discussion_r950506661 ## datafusion/sql/src/planner.rs: ## @@ -189,8 +191,14 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { query, with_options

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3209: Add support for inline column alias in CREATE VIEW

2022-08-19 Thread GitBox
andygrove commented on code in PR #3209: URL: https://github.com/apache/arrow-datafusion/pull/3209#discussion_r950503794 ## datafusion/sql/src/planner.rs: ## @@ -336,14 +346,29 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { Some(cte_name.clone()),

[GitHub] [arrow-datafusion] DaltonModlin commented on a diff in pull request #3209: feat(planner): Add support for inline column alias

2022-08-19 Thread GitBox
DaltonModlin commented on code in PR #3209: URL: https://github.com/apache/arrow-datafusion/pull/3209#discussion_r950496351 ## datafusion/sql/src/planner.rs: ## @@ -189,8 +191,14 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { query, with_opti

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3209: feat(planner): Add support for inline column alias

2022-08-19 Thread GitBox
andygrove commented on code in PR #3209: URL: https://github.com/apache/arrow-datafusion/pull/3209#discussion_r950492656 ## datafusion/sql/src/planner.rs: ## @@ -336,14 +346,37 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { Some(cte_name.clone()),

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3209: feat(planner): Add support for inline column alias

2022-08-19 Thread GitBox
andygrove commented on code in PR #3209: URL: https://github.com/apache/arrow-datafusion/pull/3209#discussion_r950490948 ## datafusion/sql/src/planner.rs: ## @@ -189,8 +191,14 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { query, with_options

[GitHub] [arrow-datafusion] DaltonModlin commented on a diff in pull request #3209: feat(planner): Add support for inline column alias

2022-08-19 Thread GitBox
DaltonModlin commented on code in PR #3209: URL: https://github.com/apache/arrow-datafusion/pull/3209#discussion_r950487937 ## datafusion/sql/src/planner.rs: ## @@ -336,14 +346,40 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { Some(cte_name.clone()),

[GitHub] [arrow-rs] psvri opened a new pull request, #2532: Decimal precision scale datatype change

2022-08-19 Thread GitBox
psvri opened a new pull request, #2532: URL: https://github.com/apache/arrow-rs/pull/2532 # Which issue does this PR close? Closes #2496. # Rationale for this change The maximum precision and scale for decimal types is 76, and yet we consume an entire usize to store thi

[GitHub] [arrow] github-actions[bot] commented on pull request #13926: ARROW-17478: [C++][Java] Update ORC to 1.7.6

2022-08-19 Thread GitBox
github-actions[bot] commented on PR #13926: URL: https://github.com/apache/arrow/pull/13926#issuecomment-1221004756 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] github-actions[bot] commented on pull request #13926: ARROW-17478: [C++][Java] Update ORC to 1.7.6

2022-08-19 Thread GitBox
github-actions[bot] commented on PR #13926: URL: https://github.com/apache/arrow/pull/13926#issuecomment-1221004733 https://issues.apache.org/jira/browse/ARROW-17478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3209: feat(planner): Add support for inline column alias

2022-08-19 Thread GitBox
andygrove commented on code in PR #3209: URL: https://github.com/apache/arrow-datafusion/pull/3209#discussion_r950482255 ## datafusion/sql/src/planner.rs: ## @@ -336,14 +346,40 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { Some(cte_name.clone()),

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3209: feat(planner): Add support for inline column alias

2022-08-19 Thread GitBox
andygrove commented on code in PR #3209: URL: https://github.com/apache/arrow-datafusion/pull/3209#discussion_r950482255 ## datafusion/sql/src/planner.rs: ## @@ -336,14 +346,40 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { Some(cte_name.clone()),

[GitHub] [arrow] lidavidm commented on a diff in pull request #13924: ARROW-17475: [Go] Function interface and Registry impl

2022-08-19 Thread GitBox
lidavidm commented on code in PR #13924: URL: https://github.com/apache/arrow/pull/13924#discussion_r950480750 ## go/arrow/compute/registry.go: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See th

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3209: feat(planner): Add support for inline column alias

2022-08-19 Thread GitBox
andygrove commented on code in PR #3209: URL: https://github.com/apache/arrow-datafusion/pull/3209#discussion_r950478912 ## datafusion/core/src/datasource/view.rs: ## @@ -134,6 +134,82 @@ mod tests { Ok(()) } +#[tokio::test] +async fn query_view_with_alia

[GitHub] [arrow] zeroshade commented on a diff in pull request #13924: ARROW-17475: [Go] Function interface and Registry impl

2022-08-19 Thread GitBox
zeroshade commented on code in PR #13924: URL: https://github.com/apache/arrow/pull/13924#discussion_r950477307 ## go/arrow/compute/registry.go: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See t

[GitHub] [arrow] zeroshade commented on a diff in pull request #13924: ARROW-17475: [Go] Function interface and Registry impl

2022-08-19 Thread GitBox
zeroshade commented on code in PR #13924: URL: https://github.com/apache/arrow/pull/13924#discussion_r950473801 ## go/arrow/compute/functions.go: ## @@ -0,0 +1,63 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See t

[GitHub] [arrow] zeroshade commented on a diff in pull request #13924: ARROW-17475: [Go] Function interface and Registry impl

2022-08-19 Thread GitBox
zeroshade commented on code in PR #13924: URL: https://github.com/apache/arrow/pull/13924#discussion_r950472899 ## go/arrow/compute/doc.go: ## @@ -0,0 +1,29 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOT

[GitHub] [arrow] lidavidm commented on a diff in pull request #13924: ARROW-17475: [Go] Function interface and Registry impl

2022-08-19 Thread GitBox
lidavidm commented on code in PR #13924: URL: https://github.com/apache/arrow/pull/13924#discussion_r950464998 ## go/arrow/compute/doc.go: ## @@ -0,0 +1,29 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTI

[GitHub] [arrow] assignUser commented on pull request #13913: ARROW-12958: [CI][Developer] Build + host the docs for PR branches

2022-08-19 Thread GitBox
assignUser commented on PR #13913: URL: https://github.com/apache/arrow/pull/13913#issuecomment-1220961393 @rok https://issues.apache.org/jira/browse/ARROW-17477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] assignUser commented on pull request #13925: ARROW-15481: [R] [CI] Add a crossbow job that mimics CRAN's old macOS

2022-08-19 Thread GitBox
assignUser commented on PR #13925: URL: https://github.com/apache/arrow/pull/13925#issuecomment-1220946305 @jonkeane 🥳 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [arrow] github-actions[bot] commented on pull request #13925: ARROW-15481: [R] [CI] Add a crossbow job that mimics CRAN's old macOS

2022-08-19 Thread GitBox
github-actions[bot] commented on PR #13925: URL: https://github.com/apache/arrow/pull/13925#issuecomment-1220945210 Revision: 2d615734af9047171ef8d62dd4cb8e817194453e Submitted crossbow builds: [ursacomputing/crossbow @ actions-968ba3a186](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] assignUser commented on pull request #13925: ARROW-15481: [R] [CI] Add a crossbow job that mimics CRAN's old macOS

2022-08-19 Thread GitBox
assignUser commented on PR #13925: URL: https://github.com/apache/arrow/pull/13925#issuecomment-1220943055 @github-actions crossbow submit r-binary-packages homebrew-r-autobrew -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] github-actions[bot] commented on pull request #13925: ARROW-15481: [R] [CI] Add a crossbow job that mimics CRAN's old macOS

2022-08-19 Thread GitBox
github-actions[bot] commented on PR #13925: URL: https://github.com/apache/arrow/pull/13925#issuecomment-1220942702 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

  1   2   3   4   >